D11941: Make it possible for KTextEditor to build on Android NDK's gcc 4.9

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  If that stuff is not around, why not, better than no compilation.
  Thanks for taking care!

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11941

To: apol, #frameworks, cullmann
Cc: cullmann, michaelh, kevinapavew, ngraham, demsking, sars, dhaumann

D11924: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  Thanks, @graesslin. I enjoyed this challenge.
  
  I removed the `[WIP]` tag from the title.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey retitled this revision from "[WIP] Add "SkipSwitcher" to API" to "Add 
"SkipSwitcher" to API".

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/95/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 05 Apr 2018 03:28:43 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 120 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/120/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 05 Apr 2018 03:28:43 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13481)19%
(1978/10637)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

D11941: Make it possible for KTextEditor to build on Android NDK's gcc 4.9

[Aleix Pol Gonzalez]

apol added a comment.


  Proof F5789511: Screenshot_20180327-200943.png 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11941

To: apol, #frameworks
Cc: michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D11941: Make it possible for KTextEditor to build on Android NDK's gcc 4.9

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added projects: Kate, Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  log2 and std::rename aren't available there.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11941

AFFECTED FILES
  src/buffer/katesecuretextbuffer.cpp
  src/document/katedocument.cpp

To: apol, #frameworks
Cc: michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 56 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/56/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Thu, 05 Apr 2018 00:10:52 +
 Build duration:
18 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 206 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/206/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 05 Apr 2018 00:10:52 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31708/59756)38%
(18621/48977)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8597/9158)48%
(5264/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8452/14385)50%
(4908/9727)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3888/7876)33%
(1639/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1376/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/55/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 05 Apr 2018 00:10:52 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31784/59757)38%
(18649/48973)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8597/9158)48%
(5263/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8523/14386)51%
(4937/9731)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3889/7876)33%
(1640/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 183 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/183/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 04 Apr 2018 23:13:57 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D11745: databasesanitizer: Use flags for filtering

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> databasesanitizer.h:41
> +IgnoreUnavailable = 2,
> +IgnoreMounted = IgnoreAvailable << 1,
> +IgnoreUnmounted = IgnoreUnavailable << 1

Is this correct? IgnoreMounted = (1 << 1) = 2 == IgnoreUnavailable?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11745

To: michaelh, #baloo, #frameworks
Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D11753: baloodb: Add clean command

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in databasesanitizer.cpp:333
> I did that before, but decided on `--dry-run` to simulate the process as 
> close as possible. 
> Also, compared to the time it takes to collect the data, removing the docs is 
> completely neglectible. Committing to the database takes some seconds (on 
> ~3 entries) again.

Fair reason, the comment below is also mood then ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/54/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 04 Apr 2018 23:13:57 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31759/59757)38%
(18624/48973)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8597/9158)48%
(5264/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8509/14386)51%
(4926/9731)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3888/7876)33%
(1639/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Henrik Fehlauer]

rkflx added a comment.


  In D11767#240162 , @ngraham wrote:
  
  > That was before I got some formal acceptance. I probably should have ended 
with "if nobody formally accepts by then", which was the intention. This patch 
had been open for a week...
  
  
  Then don't set #gwenview  as a 
reviewer and announce that you'll give time for review until the weekend. Some 
people have other plans in the Easter week…

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: rkflx, davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, 
rizzitello, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 205 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/205/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 23:13:57 +
 Build duration:
8 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31725/59756)38%
(18625/48977)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8597/9158)48%
(5265/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8464/14385)50%
(4912/9727)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3888/7876)33%
(1639/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
   

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Nathaniel Graham]

ngraham added a comment.


  That was before I got some formal acceptance. I probably should have ended 
with "if nobody formally accepts by then", which was the intention. This patch 
had been open for a week...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: rkflx, davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, 
rizzitello, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Henrik Fehlauer]

rkflx added a comment.


  In D11767#238868 , @ngraham wrote:
  
  > Okay, unless I hear any impassioned pleas in favor of these entries, I will 
commit this patch on Saturday, April 7th.
  
  
  Huh?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: rkflx, davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, 
rizzitello, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7e1d2fb84546: Remove Recently Saved This Month and 
Recently Saved Last Month entries by… (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11767?vs=30798=31340#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11767?vs=30798=31340

REVISION DETAIL
  https://phabricator.kde.org/D11767

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, 
ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Nathaniel Graham]

ngraham added a comment.


  Thanks folks.

REPOSITORY
  R241 KIO

BRANCH
  remove-recently-saved-this-month-and-last-month (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, 
ngraham

D11891: Fix crashes in NotifyByAudio when closing applications

[Albert Astals Cid]

aacid added a comment.


  In D11891#239437 , @rjvbb wrote:
  
  > This is about better and more concise English. The queued connection is the 
indirect explanation why the patch is necessary, and thus comes after the 
direct explanation (the fact that there may be pending signals). Think of it as 
a courtesy to people who want to get to the point first and maybe deal with the 
finer detail later.
  >
  > The problem with this whole comment is that it's long and not very easy to 
follow for devs who are not (very) familiar with the code already (and those 
who are might not need all the detail). Rereading it with after-bedtime eyes I 
think you should probably just leave only the 1st sentence. The explanation why 
you can end up "here" after close was called could be put in the commit 
message, or as a "warning" above the connect() call that creates the connection.
  
  
  I disagree, i've read that code lots of times and it took me finding a 
semi-reproducible case to figure out what was wrong, so having a comment helps 
people that are familiar with it.
  
  > Come to think of it, your patch could take the form below because there is 
already a check of `notification`:
  > 
  >   if (Q_UNLIKELY(!notification)) {
  >   return;
  >   } else if ((notification->flags() & KNotification::LoopSound)) {
  >   m->play();
  >   return;
  >   }
  > 
  > 
  > Maybe merge your comment with the one about "if the sound is short enough" 
because I from what I understand that describes more or less the same situation.
  
  No, it describes a different situation, it's about
  
m->enqueue(soundURL);
  
  not having had time to finish and thus onAudioSourceChanged not triggering.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann, rjvbb
Cc: cfeck, rjvbb, mpyne, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/53/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 04 Apr 2018 22:20:27 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31787/59763)38%
(18637/48973)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8602/9158)48%
(5250/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8523/14386)51%
(4939/9731)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3892/7882)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
  

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 204 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/204/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 22:20:27 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/442)67%
(296/442)53%
(31756/59765)38%
(18599/48977)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8602/9158)48%
(5250/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core86%
(102/119)86%
(102/119)59%
(8491/14387)51%
(4917/9727)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7883)33%
(1637/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(535/1008)42%
(422/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
   

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 54 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/54/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 04 Apr 2018 22:20:27 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 431.85 KB...][ 37%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kabstractfileitemactionplugin.cpp.objC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\widgets\kdesktopfileactions.cpp(75): warning C4996: 'KRun::runUrl': was declared deprecatedc:\ci\workspace\frameworks kio kf5-qt5 windowsmsvcqt5.10\src\widgets\krun.h(302): note: see declaration of 'KRun::runUrl'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\widgets\kdesktopfileactions.cpp(120): warning C4996: 'KRun::runUrl': was declared deprecatedc:\ci\workspace\frameworks kio kf5-qt5 windowsmsvcqt5.10\src\widgets\krun.h(302): note: see declaration of 'KRun::runUrl'kabstractfileitemactionplugin.cpp[ 37%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/koverlayiconplugin.cpp.objkoverlayiconplugin.cpp[ 37%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kbuildsycocaprogressdialog.cpp.objkbuildsycocaprogressdialog.cpp[ 38%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurlrequester.cpp.objkurlrequester.cpp[ 38%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/krun.cpp.objkrun.cpp[ 38%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/sslui.cpp.objsslui.cpp[ 38%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurlpixmapprovider.cpp.objkurlpixmapprovider.cpp[ 38%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/pixmaploader.cpp.objpixmaploader.cpp[ 38%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/thumbsequencecreator.cpp.objthumbsequencecreator.cpp[ 38%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/thumbcreator.cpp.objthumbcreator.cpp[ 39%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kshellcompletion.cpp.objkshellcompletion.cpp[ 39%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurlcompletion.cpp.objC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\widgets\kurlrequester.cpp(432): warning C4996: 'KUrlRequester::fileDialog': was declared deprecatedc:\ci\workspace\frameworks kio kf5-qt5 windowsmsvcqt5.10\src\widgets\kurlrequester.h(184): note: see declaration of 'KUrlRequester::fileDialog'kurlcompletion.cpp[ 39%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurifilter.cpp.objC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\widgets\krun.cpp(1354): warning C4996: 'KRun::runUrl': was declared deprecatedC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\widgets\krun.cpp(170): note: see declaration of 'KRun::runUrl'kurifilter.cpp[ 39%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/dropjob.cpp.obj[ 39%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/openfilemanagerwindowjob.cpp.objdropjob.cppopenfilemanagerwindowjob.cpp[ 39%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/pastejob.cpp.obj[ 39%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/previewjob.cpp.objpastejob.cpppreviewjob.cpp[ 40%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/renamedialog.cpp.objrenamedialog.cpp[ 40%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kdynamicjobtracker.cpp.objC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\widgets\kurlcompletion.cpp(66): fatal error C1083: Cannot open include file: 'pwd.h': No such file or directoryjom: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\build\src\widgets\CMakeFiles\KF5KIOWidgets.dir\build.make [src\widgets\CMakeFiles\KF5KIOWidgets.dir\kurlcompletion.cpp.obj] Error 2kdynamicjobtracker.cppC:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\include\algorithm(3061): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of dataC:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\include\algorithm(3078): note: see reference to function template instantiation 'void std::_Guess_median_unchecked<_RanIt,_Pr>(_RanIt,_RanIt,_RanIt,_Pr)' being compiledwith[_RanIt=QTypedArrayData::iterator,_Pr=KUriFilter::loadPlugins::]C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\include\algorithm(3178): note: see reference to function template instantiation 'std::pair<_RanIt,_RanIt> std::_Partition_by_median_guess_unchecked<_RanIt,_Pr>(_RanIt,_RanIt,_Pr)' being compiledwith[_RanIt=QTypedArrayData::iterator,_Pr=KUriFilter::loadPlugins::]C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\include\algorithm(3212): note: see reference to function 

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 182 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/182/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 04 Apr 2018 22:20:27 +
 Build duration:
8 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest

D11734: Have KIO build for Android

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a486fd6b2776: Have KIO build for Android (authored by 
apol).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11734?vs=31305=31335

REVISION DETAIL
  https://phabricator.kde.org/D11734

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h
  src/widgets/kurlcompletion.cpp
  src/widgets/previewjob.cpp

To: apol, #frameworks, aacid
Cc: aacid, michaelh, ngraham

D11888: Handle adjacent special characters correctly

[Stefan Brüns]

bruns marked 8 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11888

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add optimization test

[Stefan Brüns]

bruns added a comment.


  Although this is probably a useful addition (haven't checked which cases the 
existing unit test already cover), it does not cover the changes in D11826 
.
  
  The code in 
https://cgit.kde.org/baloo.git/tree/src/lib/advancedqueryparser.cpp#n100 
replicates the new logic in the `Term::Term(Term&, Operation&, Term&)` 
constructor (merging of compatible terms), and, after the changes in D11826 
, could be replaced with just
  
static void addTermToStack(QStack& stack, const Term& 
termInConstruction, Term::Operation op)
{
auto top = stack.pop();
stack.push(Term(top, op, termInConstruction));
}
  
  `operator&&` is e.g. used in
  https://cgit.kde.org/baloo.git/tree/src/lib/query.cpp#n189
  
  To test operator&&, the following should be true:
  
Term{Term:And, {Term{"", "a"}, Term{"", "b"}, Term{"", "c"}, Term{"", "d"} }
==
Term{"", "a"} && Term{"", "b"} && Term{"", "c"} && Term{"", "d"}

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked 3 inline comments as done.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 31330.
sharvey added a comment.


  - Add `_KDE` prefix to SkipSwitcher state; correct enum

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11924?vs=31307=31330

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

AFFECTED FILES
  autotests/kwindowinfox11test.cpp
  autotests/netwininfotestwm.cpp
  src/kwindowsystem.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a subscriber: ngraham.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked an inline comment as done.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: graesslin, apol, #frameworks, michaelh, ngraham

D11907: advancedqueryparsertest: Add optimization test

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> advancedqueryparsertest.cpp:228
> +const QString nofail;
> +QString phrase;
> +phrase = QStringLiteral("a AND b AND c AND d");

better use a different name, phrase has a special meaning, i.e. 
Baloo:EngineQuery:Phrase

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  In D11924#240057 , @graesslin 
wrote:
  
  > In D11924#240045 , @graesslin 
wrote:
  >
  > > I'm not sure whether we can add elements to the states.
  >
  
  
  
  
  > An implementation MAY add new atoms to this list. Implementations without 
extensions MUST ignore any unknown atoms, effectively removing them from the 
list. These extension atoms MUST NOT start with the prefix _NET.
  
  Thanks, Martin. That's very interesting. I'm in the process of making the 
changes. Does the invalid atom name mean KWin would not honor it? Or does it 
"just" mean it's out of compliance with a standard?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: graesslin, apol, #frameworks, michaelh, ngraham

D11734: Have KIO build for Android

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11734

To: apol, #frameworks, aacid
Cc: aacid, michaelh, ngraham

D10937: Retouching of Screen Layout Selection OSD Icons

[Nathaniel Graham]

ngraham added a comment.


  In D10937#240070 , @pstefan wrote:
  
  > I am glad you like them :)
  >
  > I will hand in the updated diff tomorrow. The color fix script somehow ate 
my icons and I have to restore them from a backup.
  
  
  You can download them from this diff, if they're current.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Andres Betts]

abetts added a comment.


  I don't have any objections. Good work!
  
  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  I am glad you like them :)
  
  I will hand in the updated diff tomorrow. The color fix script somehow ate my 
icons and I have to restore them from a backup.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D11924: [WIP] Add "SkipSwitcher" to API

[Martin Flöser]

graesslin added a comment.


  In D11924#240045 , @graesslin 
wrote:
  
  > I'm not sure whether we can add elements to the states.
  
  
  Just checked:
  
  An implementation MAY add new atoms to this list. Implementations without 
extensions MUST ignore any unknown atoms, effectively removing them from the 
list. These extension atoms MUST NOT start with the prefix _NET.
  
  So all is fine, but the prefix needs to change

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: graesslin, apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  I'm not sure whether we can add elements to the states.

INLINE COMMENTS

> netwininfotestwm.cpp:432
>  const QByteArray skipTaskbar  = 
> QByteArrayLiteral("_NET_WM_STATE_SKIP_TASKBAR");
> +const QByteArray skipSwitcher = 
> QByteArrayLiteral("_NET_WM_STATE_SKIP_SWITCHER");
>  const QByteArray keepAbove= 
> QByteArrayLiteral("_NET_WM_STATE_ABOVE");

This needs a KDE prefix as it's a KDE specific extension

> netwm_def.h:502
>  **/
> -DemandsAttention = 1u << 11
> +DemandsAttention = 1u << 12
> +

You cannot change enum values. Please add the new one afterwards

> atoms_p.h:136
>  ENUM(_NET_WM_STATE_DEMANDS_ATTENTION),
> +ENUM(_NET_WM_STATE_SKIP_SWITCHER),
>  

Also a KDE prefix is needed

> netwm.cpp:26
>  
> -//#define NETWMDEBUG
> +// #define NETWMDEBUG
>  #include "netwm.h"

Unrelated change

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: graesslin, apol, #frameworks, michaelh, ngraham

D11811: avoid Asan runtime error: shift exponent -1 is negative

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:3e8bbe0ad838: avoid Asan runtime error: shift exponent -1 
is negative (authored by jtamate).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11811?vs=31271=31312

REVISION DETAIL
  https://phabricator.kde.org/D11811

AFFECTED FILES
  src/completion/katecompletionconfig.cpp

To: jtamate, #kate, #frameworks, mwolff
Cc: mwolff, brauch, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D10937: Retouching of Screen Layout Selection OSD Icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Heh, I don't think anyone is ever going to want to use 16x16 versions of 
these in the first place, so I can live with that.
  
  These icons look fantastic. Big +1 from me. Any other comments?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked 5 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 31311.
sharvey marked an inline comment as done.
sharvey added a comment.


  - Correct & update version numbers in XML entries

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=31308=31311

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11652: Don't show the background if Button.flat

[Aleix Pol Gonzalez]

apol updated this revision to Diff 31309.
apol added a comment.


  Now both Button {flat: true} and ToolButton look the same

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11652?vs=30414=31309

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11652

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  tests/buttons_pc3.0.qml

To: apol, #plasma
Cc: mart, #frameworks, michaelh, ngraham

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:731ba7036eff: Make use of upstream CMake infrastructure 
to detect the compiler toolchain (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11776?vs=30824=31310

REVISION DETAIL
  https://phabricator.kde.org/D11776

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/deployment-file.json.in
  toolchain/specifydependencies.cmake

To: apol, #frameworks, #build_system, vkrause
Cc: vkrause, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked 2 inline comments as done.
sharvey added inline comments.

INLINE COMMENTS

> graesslin wrote in plasmawindowmodel.h:110
> I normally update those just before pushing to the next frameworks release 
> number.

Sorry. Was busy uploading before seeing your reply. Will gladly change again if 
necessary.

> sharvey wrote in plasmashell_interface.h:144
> Version 5.45?

Will change again if necessary.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 31308.
sharvey added a comment.


  - Add `@since 5.45` tag to SkipSwitcher doxygen comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=31296=31308

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked an inline comment as done.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 31307.
sharvey added a comment.


  - Add `@since 5.45` to SkipSwitcher doxygen comments

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11924?vs=31294=31307

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

AFFECTED FILES
  autotests/kwindowinfox11test.cpp
  autotests/netwininfotestwm.cpp
  src/kwindowsystem.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> sharvey wrote in plasmawindowmodel.h:110
> Correct version number? 5.45?

I normally update those just before pushing to the next frameworks release 
number.

> plasma-shell.xml:339
> +
> +
> +

The since is wrong. It must be higher than the current version. You also need 
to increase the version number and I think this should be added as last request 
and not in between.

> plasma-window-management.xml:49
> since="3"/>
> +  
>  

Here also the since is wrong

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11683: Make it possible to request a plugin configuration module programatically

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:0a3c90c89bdb: Make it possible to request a plugin 
configuration module programatically (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11683?vs=30512=31306#toc

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11683?vs=30512=31306

REVISION DETAIL
  https://phabricator.kde.org/D11683

AFFECTED FILES
  src/kpluginselector.cpp
  src/kpluginselector.h
  src/kpluginselector_p.h

To: apol, #frameworks, #kde_connect, albertvaka
Cc: albertvaka, michaelh, ngraham

D11734: Have KIO build for Android

[Aleix Pol Gonzalez]

apol updated this revision to Diff 31305.
apol added a comment.


  Include comment saying that method won't work on Android

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11734?vs=30676=31305

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11734

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h
  src/widgets/kurlcompletion.cpp
  src/widgets/previewjob.cpp

To: apol, #frameworks
Cc: aacid, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  In D11924#239922 , @apol wrote:
  
  > 5.44 was just released, so I'd assume it's 5.45 (or we can fix change it 
later if it takes us longer to merge).
  
  
  I took a minute to think it through and came to the conclusion of `5.45` as 
well.
  
  I'll update.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Aleix Pol Gonzalez]

apol added a comment.


  5.44 was just released, so I'd assume it's 5.45 (or we can fix change it 
later if it takes us longer to merge).

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added inline comments.

INLINE COMMENTS

> apol wrote in netwm_def.h:492
> add `@since 5.45`?

Will it be `5.45` for KWayland as well? There were `@since` tags in what I 
duplicated, but I wasn't certain which version.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> netwm_def.h:492
>  /**
> +   indicates that a window should not be included on a switcher.
> +**/

add `@since 5.45`?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  Latest revision:
  F5787871: pls_assess.png 
  I moved the window a bit up while maintaining the alignment, as requested. I 
had to remove the stand of the projector screen tho. Originally I "cheated" and 
moved the stand off-center to make it still visible. However, with the "header" 
of the projector screen shown, it was easily apparent that the stand wasn't 
centered anymore.
  
  As for the 16px icons … I say they can't be done. At least for the 5th row 
from the left onward. There simply is not enough room to squeeze two windows 
(as in, window icons) next to each other while 1. having them look like windows 
and 2. being meaningful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added inline comments.

INLINE COMMENTS

> plasmawindowmodel.h:110
> +/**
> + * @since 5.??
> + */

Correct version number? 5.45?

> plasmashell_interface.h:144
> + * in a window switcher
> + * @since 5.??
> + **/

Version 5.45?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Michael Heidelbach]

michaelh added a comment.


  > Let me announce that I'm willing to take all the heat from any potential 
issues, so feel free to offer formal acceptance, folks! :-)
  
  Can I have this as a signature?
  
  > It comes from gerrit that most of us use for Qt.
  >  https://gerrit-review.googlesource.com/Documentation/config-labels.html
  
  Ah... that clarifies quite a bit, thanks.

REPOSITORY
  R241 KIO

BRANCH
  remove-recently-saved-this-month-and-last-month (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, 
ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey edited the summary of this revision.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Is there social convention I miss?
  
  It comes from gerrit that most of us use for Qt.
  
  https://gerrit-review.googlesource.com/Documentation/config-labels.html

REPOSITORY
  R241 KIO

BRANCH
  remove-recently-saved-this-month-and-last-month (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, rizzitello, 
ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  F5787709: kwayland-test-exception.txt 
  KWayland test results / exception report

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Nathaniel Graham]

ngraham added a comment.


  In general, people offer a +1 without formally accepting when they generally 
and vaguely approve, but not enough to:
  
  - Care that much about it
  - Want to put their formal stamp of approval on it for the purpose of blame 
if it breaks or proves unpopular
  
  Let me announce that I'm willing to take all the heat from any potential 
issues, so feel free to offer formal acceptance, folks! :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  NOTE: This is a junior job and a work in progress!
  
  Following discussion in BUG 375921 
, it was decided to add 
`SkipSwitcher` to the API. This is my first submission to the 
KWin/KWayland/KWindowSystem group, and @hein has graciously offered to help me 
out.
  
  As Martin wrote in the bug report, this should be straightforward, following 
the implementation of `SkipTaskbar`. For the most part, it is - the autotest 
results include
  
PASS   : TestWindowManagement::testRequestsBoolean(skipSwitcher)
  
  However, autotest #6 (`kwayland-testWaylandSurface`) is failing with an 
exception. I got the same exception when testing KWayland without my changes. 
I'm attaching the test output, in case it helps figure out what's wrong. All 
the other tests succeed.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey created this revision.
sharvey added a reviewer: hein.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sharvey requested review of this revision.

REVISION SUMMARY
  Adding "SkipSwitcher" to API, as a result of discussion in
  BUG 375921
  
  Depends on / related to D11924 

REPOSITORY
  R127 KWayland

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  NOTE: This is a junior job and a work in progress!
  
  After discussion in BUG 375921 , 
it was decided to add `SkipSwitcher` to the KWin API. It's a junior job and my 
first submission to the KWin/KWayland/KWindowSystem family. @hein has agreed to 
help me out, and I do in fact have a few issues.
  
  - Autotests 7, 8, and 10 are failing, and I'm unable to determine why. It 
appears to be somehow related to the addition of `NET::SkipSwitcher` to the 
list of `NET::States`, but I'm unclear why or how.
  - I know KWin/X11 is feature-frozen, so this may not be relevant any longer.
  
  As Martin wrote in the bug report, this should be straightforward, and it 
seems that way. But clearly the results of the autotests are a problem, which I 
need help resolving.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey created this revision.
sharvey added a reviewer: hein.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sharvey requested review of this revision.

REVISION SUMMARY
  Adding "SkipSwitcher" to API, stemming from discussion in
  BUG 375921. Please see following comments for important information.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

AFFECTED FILES
  autotests/kwindowinfox11test.cpp
  autotests/netwininfotestwm.cpp
  src/kwindowsystem.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 119 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/119/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 12:39:38 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13481)19%
(1978/10637)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/94/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 04 Apr 2018 12:39:38 +
 Build duration:
9 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11922: Wallpaper templates: set background color to ensure contrast to sample text content

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:682dd4a142fa: Wallpaper templates: set background color 
to ensure contrast to sample text… (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11922?vs=31290=31292

REVISION DETAIL
  https://phabricator.kde.org/D11922

AFFECTED FILES
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper/package/contents/ui/main.qml

To: kossebau, #plasma, mart
Cc: #frameworks, michaelh, ngraham

D11922: Wallpaper templates: set background color to ensure contrast to sample text content

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improvetemplateswithbackground

REVISION DETAIL
  https://phabricator.kde.org/D11922

To: kossebau, #plasma, mart
Cc: #frameworks, michaelh, ngraham

D11882: autotests: Use built executable instead of installed

[Michael Heidelbach]

michaelh retitled this revision from "extractortest: Use built executable 
instead of installed" to "autotests: Use built executable instead of installed".

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11922: Wallpaper templates: set background color to ensure contrast to sample text content

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  To avoid black text on black background and thus confusion if things are
  working after the initial generation from the template and first test build
  and installation, also set an background with themed color.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improvetemplateswithbackground

REVISION DETAIL
  https://phabricator.kde.org/D11922

AFFECTED FILES
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper/package/contents/ui/main.qml

To: kossebau, #plasma, mart
Cc: #frameworks, michaelh, ngraham

D11882: extractortest: Use built executable instead of installed

[Michael Heidelbach]

michaelh added a comment.


  In D11882#239638 , @alexeymin 
wrote:
  
  > Code looks fine, but I did not test if it actually works. ;)
  
  
  It's a little hard to see the effect of this, because the installed extractor 
and the freshly built have to differ somehow.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

[Michael Heidelbach]

michaelh marked 3 inline comments as done.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

[Michael Heidelbach]

michaelh updated this revision to Diff 31289.
michaelh added a comment.


  - Move excess space to line 58

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11882?vs=31267=31289

BRANCH
  testexe (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11882

AFFECTED FILES
  autotests/extractortest.cpp
  autotests/filemetadatawidgettest.cpp

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Michael Heidelbach]

michaelh added a comment.


  Why is sum(+1) == +3 but noone accepted this? Is there social convention I 
miss?
  (It's scaring me off from simply accepting this.)
  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: michaelh, sharvey, elvisangelaccio, abetts, rizzitello, ngraham

D11882: extractortest: Use built executable instead of installed

[Alexey Min]

alexeymin added a comment.


  Code looks fine, but I did not test if it actually works. ;)

INLINE COMMENTS

> filemetadatawidgettest.cpp:58
> +const auto extractorPath = QDir( 
> QStringLiteral("%1/baloo_filemetadata_temp_extractor").arg(QFINDTESTDATA("../src"))).absolutePath();
> +
> QCOMPARE(QStandardPaths::findExecutable(QStringLiteral("baloo_filemetadata_temp_extractor")),extractorPath);
>  

Missing space after comma?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11811: avoid Asan runtime error: shift exponent -1 is negative

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  thanks

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11811

To: jtamate, #kate, #frameworks, mwolff
Cc: mwolff, brauch, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D11811: avoid Asan runtime error: shift exponent -1 is negative

[Jaime Torres Amate]

jtamate updated this revision to Diff 31271.
jtamate added a comment.


  Implemented mwolf solution.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11811?vs=30952=31271

REVISION DETAIL
  https://phabricator.kde.org/D11811

AFFECTED FILES
  src/completion/katecompletionconfig.cpp

To: jtamate, #kate, #frameworks
Cc: mwolff, brauch, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D11882: extractortest: Use built executable instead of installed

[Michael Heidelbach]

michaelh added a dependent revision: D11913: Change property selection to 
opt-in.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

[Michael Heidelbach]

michaelh updated this revision to Diff 31267.
michaelh added a comment.


  - Use list separator

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11882?vs=31265=31267

BRANCH
  testexe (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11882

AFFECTED FILES
  autotests/extractortest.cpp
  autotests/filemetadatawidgettest.cpp

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> alexeymin wrote in filemetadatawidgettest.cpp:60
> Should probably use `QDir::listSeparator()` instead of this `#ifdef` logic

Great! Thanks.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

[Alexey Min]

alexeymin added inline comments.

INLINE COMMENTS

> filemetadatawidgettest.cpp:60
> +qputenv("PATH", qPrintable(QStringLiteral("%1;%2").arg(np).arg(op)));
> +#endif
> +const auto extractorPath = QDir( 
> QStringLiteral("%1/baloo_filemetadata_temp_extractor").arg(QFINDTESTDATA("../src"))).absolutePath();

Should probably use `QDir::listSeparator()` instead of this `#ifdef` logic

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

[Michael Heidelbach]

michaelh updated this revision to Diff 31265.
michaelh added a comment.


  - Add our extractor to PATH

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11882?vs=31145=31265

BRANCH
  testexe (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11882

AFFECTED FILES
  autotests/extractortest.cpp
  autotests/filemetadatawidgettest.cpp

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: ashaposhnikov, astippich, spoorun, alexeymin

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/16/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 04 Apr 2018 08:58:37 +
 Build duration:
9 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(258/306)62%
(155/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(216/249)63%
(140/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 68 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/68/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 04 Apr 2018 08:58:37 +
 Build duration:
3 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupe

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/72/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 08:58:37 +
 Build duration:
3 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(258/306)62%
(155/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(216/249)63%
(140/224)

D11888: Handle adjacent special characters correctly

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in advancedqueryparser.cpp:69
> > I don't understand. token is QString. Why not instead of switch 
> > (token.at(0).toLatin1())
> > 
> >   switch (token) {
> >   case '>'`: comparator = Term::Greater; break;
> >   case '>='`: comparator = Term::GreaterEqual; break;
> > 
> > 
> > What am I missing?
> 
> You can only `switch` on integral statements (ints, chars, ...). With C++11, 
> you can do some `constexpr` hacks, but your code won't work as is.

> You can only switch on integral statements (ints, chars, ...).

Heh? That's surprising![1] Anyway, thanks for the lesson a keep this code as it 
is now.

[1]
Coming from javascript `switch` definitely is a "false friend". 
Can I become a beef steak?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11888

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

KDE CI: Frameworks kinit kf5-qt5 SUSEQt5.10 - Build # 19 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20SUSEQt5.10/19/
 Project:
Frameworks kinit kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 04 Apr 2018 08:02:37 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/10)0%
(0/10)0%
(0/2003)0%
(0/1391)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/2)0%
(0/2)0%
(0/294)0%
(0/157)src.kdeinit0%
(0/3)0%
(0/3)0%
(0/947)0%
(0/604)src.klauncher0%
(0/5)0%
(0/5)0%
(0/762)0%
(0/630)

D11822: Make the word/char count a global preference

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  Yeah, makes sense.
  Thanks for the contribution.

REPOSITORY
  R39 KTextEditor

BRANCH
  patch-1

REVISION DETAIL
  https://phabricator.kde.org/D11822

To: wsdfhjxc, #ktexteditor, #kate, mwolff, cullmann
Cc: mwolff, dhaumann, cullmann, ngraham, #frameworks, michaelh, kevinapavew, 
demsking, sars