D13899: KMessageWidget: use theme instead of hardcoded colours

[Nathaniel Graham]

ngraham added a comment.


  This patch works as advertised, and does not imposes any visual regressions 
when using the Breeze color scheme.
  
  And yet, when trying it out with non-default color schemes, I can't help but 
wonder what we're actually accomplishing here. While the Positive color message 
looks sane enough with all of the standard non-default color schemes that we 
ship with, the warning, negative, and informational message colors are all over 
the map, and a lot of them totally lose the intended meaning of the default 
colors. It becomes impossible to tell at-a-glance whether the message is good 
or bad or neutral by looking at its color, which is the whole point of using 
colors here. Here are some combinations that I think don't work at all:
  
  Informational message, Oxygen:
  F6109824: Info - Oxygen.png 
  
  Informational Message, Steel:
  F6109826: Info - Steel.png 
  
  Informational message, Wonton Soup:
  F6109829: Info - Wonton Soup.png 
  
  Informational message, Honeycomb:
  F6109831: Info - Honeycomb.png 
  
  Informational message, Norway:
  F6109833: Info - Norway.png 
  
  Negative Message, Steel:
  F6109838: Negative - Steel.png 
  
  Negative Message, Wonton Soup:
  F6109841: Negative - Wonton Soup.png 
  
  Warning message: Honeycomb:
  F6109845: Warning - Honeycomb.png 
  
  It's very easy for me to imagine 3rd-party color schemes and user-created 
color schemes producing equally nonsensical and impossible-to-parse color 
combinations.
  
  On one hand, that's their choice, right? But on the other hand, what do we 
gain from all this? What do the users gain?
  
  Since Kirigami already uses colors from the theme, I guess we need to follow 
suit here to maintain consistency. But especially for informational messages, 
the message's background color seems just totally wrong for quite a lot of 
color schemes.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13899

To: rjvbb, #frameworks, #vdg
Cc: ngraham, aacid, broulik, kde-frameworks-devel, michaelh, crozbo, firef, 
bruns, skadinna, aaronhoneycutt, mbohlender

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:39944a5e4fa4: Avoid manipulation of lists with quadratic 
complexity (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12233?vs=35068=37835

REVISION DETAIL
  https://phabricator.kde.org/D12233

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/pendingfilequeue.cpp

To: bruns, mgallien, mpyne, #frameworks, #baloo
Cc: #baloo, mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns added a comment.


  Sorry for the noise - apparently, if one requests changes, adopt the 
revision, does the changes, the "Changes requested" flag is not cleared and can 
not be cleared ...

REPOSITORY
  R293 Baloo

BRANCH
  arcpatch-D12233

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, mgallien, mpyne, #frameworks, #baloo
Cc: #baloo, mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns edited reviewers, added: Baloo; removed: michaelh.

REPOSITORY
  R293 Baloo

BRANCH
  arcpatch-D12233

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, mgallien, mpyne, #frameworks, #baloo
Cc: #baloo, mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns removed a reviewer: Baloo.
This revision is now accepted and ready to land.
Restricted Application added a subscriber: Baloo.

REPOSITORY
  R293 Baloo

BRANCH
  arcpatch-D12233

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, michaelh, mgallien, mpyne, #frameworks
Cc: #baloo, mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns marked 4 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, #baloo, michaelh, mgallien, mpyne, #frameworks
Cc: mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, #baloo, michaelh, mgallien, mpyne, #frameworks
Cc: mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns added a reviewer: Frameworks.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, #baloo, michaelh, mgallien, mpyne, #frameworks
Cc: mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> kformatprivate.cpp:121
>  { KFormat::UnitPrefix::Nano,  1e-9,  bpow(-30), u'n' },
> -{ KFormat::UnitPrefix::Micro, 1e-6,  bpow(-20), u'µ' },
> +// Thanks to broken MSVC, we can not use u'µ', but have to use the 
> unicode codepoint
> +{ KFormat::UnitPrefix::Micro, 1e-6,  bpow(-20), QChar(0xB5) },

Would it make sense to mention with which MSVC version this was tested? At some 
point in time, this may be fixed, and then the comment is wrong.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14122

To: bruns, #frameworks, kossebau, bcooksley
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.11 - Build # 10 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.11/10/
 Project:
Frameworks ki18n kf5-qt5 AndroidQt5.11
 Date of build:
Sun, 15 Jul 2018 18:13:30 +
 Build duration:
2 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 65.74 KB...]-- Looking for dngettext - not found-- libintl is a separate library.-- Found LibIntl: /opt/kdeandroid-deps/include  -- Performing Test HAVE_NL_MSG_CAT_CNTR-- Performing Test HAVE_NL_MSG_CAT_CNTR - Success-- Found PythonInterp: /usr/bin/python3.5 (found version "3.5.2") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.7") -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- At least one python version must be available to use PythonModuleGeneration.-- The following REQUIRED packages have been found: * ECM (required version >= 5.48.0), Extra CMake Modules.,  * Qt5Script (required version >= 5.8.0) * Qt5Core * LibIntl,Needed for building KI18n unless glibc is the system libc implementation * PythonInterp * Gettext * Qt5Test * Qt5Network (required version >= 5.11.0) * Qt5Qml * Qt5Concurrent * Qt5 (required version >= 5.8.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * PythonModuleGeneration-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:KF5_HOST_TOOLING-- Build files have been written to: /home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks ki18n kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project ki18n --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target KF5I18n_autogenScanning dependencies of target ktranscript_autogen[  2%] Automatic MOC for target KF5I18n[  5%] Automatic MOC for target ktranscript[  5%] Built target KF5I18n_autogen[  5%] Built target ktranscript_autogenScanning dependencies of target KF5I18n[  8%] Building CXX object src/CMakeFiles/KF5I18n.dir/klocalizedtranslator.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5I18n.dir/klocalizedstring.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5I18n.dir/kuitmarkup.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5I18n.dir/kcatalog.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5I18n.dir/common_helpers.cpp.oScanning dependencies of target ktranscript[ 23%] Building CXX object src/CMakeFiles/ktranscript.dir/ktranscript.cpp.oIn file included from /home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/kcatalog.cpp:23:0:/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/gettext.h: In function 'const char* dpgettext_expr(const char*, const char*, const char*)':/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/gettext.h:115:45: warning: ISO C++ forbids variable length array 'msg_ctxt_id' [-Wvla] char msg_ctxt_id[msgctxt_len + msgid_len]; ^/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/gettext.h: In function 'const char* dnpgettext_expr(const char*, const char*, const char*, const char*, long unsigned int)':/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/gettext.h:165:45: warning: ISO C++ forbids variable length array 'msg_ctxt_id' [-Wvla] char msg_ctxt_id[msgctxt_len + msgid_len]; ^[ 26%] Building CXX object src/CMakeFiles/ktranscript.dir/common_helpers.cpp.o[ 29%] Building CXX object src/CMakeFiles/KF5I18n.dir/klocalizedcontext.cpp.o[ 32%] Building CXX object src/CMakeFiles/KF5I18n.dir/main.cpp.o[ 35%] Building CXX object src/CMakeFiles/ktranscript.dir/ktranscript_autogen/mocs_compilation.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5I18n.dir/KF5I18n_autogen/mocs_compilation.cpp.o[ 41%] Linking CXX shared module ../bin/ktranscript.so[ 41%] Built target ktranscript[ 44%] Linking CXX shared library ../bin/libKF5I18n.so/home/user/workspace/Frameworks ki18n kf5-qt5 AndroidQt5.11/src/kcatalog.cpp:200: error: undefined reference to '_nl_msg_cat_cntr'collect2: error: ld returned 1 exit statussrc/CMakeFiles/KF5I18n.dir/build.make:189: recipe for target 'bin/libKF5I18n.so' failedmake[2]: *** [bin/libKF5I18n.so] Error 1CMakeFiles/Makefile2:153: recipe for target 'src/CMakeFiles/KF5I18n.dir/all' failedmake[1]: *** [src/CMakeFiles/KF5I18n.dir/all] Error 2Makefile:140: recipe for target 'all' failedmake: *** [all] Error 2[Pipeline] 

D12233: Avoid manipulation of lists with quadratic complexity

[Michael Pyne]

mpyne accepted this revision.
mpyne added a comment.


  I don't use Baloo directly but I've taken a look from a code sanity 
perspective and agree with @dhaumann that the change is a proper port of the 
existing logic.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, #baloo, michaelh, mgallien, mpyne
Cc: mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D12271: Don't remove trailing whitespace from cursor line

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann edited reviewers, added: sraizada; removed: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12271

To: cullmann, #ktexteditor, dhaumann, sraizada
Cc: cullmann, kwrite-devel, kde-frameworks-devel, dhaumann, anthonyfieroni, 
#ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, 
sars

D12271: Don't remove trailing whitespace from cursor line

[Christoph Cullmann]

cullmann abandoned this revision.
cullmann added a comment.


  > as said, we don't want that behavior change, sorry for that.
  ==

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12271

To: cullmann, #ktexteditor, dhaumann, sraizada
Cc: cullmann, kwrite-devel, kde-frameworks-devel, dhaumann, anthonyfieroni, 
#ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, 
sars

D14137: CSS: update syntax and fix some errors

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks like a nice update - thanks for your work. Can you 'arc land' yourself? 
:-)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  css

REVISION DETAIL
  https://phabricator.kde.org/D14137

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 42 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/42/
 Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sun, 15 Jul 2018 16:22:40 +
 Build duration:
8 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdelibs4configmigratortestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kformattestFailed: TestSuite.krandomtest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/96/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 15 Jul 2018 16:22:40 +
 Build duration:
6 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6310/8408)43%
(10100/23345)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2685/2761)49%
(5766/11833)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(827/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/41/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 15 Jul 2018 16:22:40 +
 Build duration:
3 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6311/8408)43%
(10100/23341)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2685/2761)49%
(5767/11835)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(826/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/19/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 15 Jul 2018 16:22:40 +
 Build duration:
3 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:5c3f5eade4cc: KFormat: Replace unicode literal with 
unicode codepoint to fix MSVC build (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14122?vs=37776=37819#toc

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14122?vs=37776=37819

REVISION DETAIL
  https://phabricator.kde.org/D14122

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: bruns, #frameworks, kossebau, bcooksley
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/40/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 15 Jul 2018 16:12:45 +
 Build duration:
6 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6311/8408)43%
(10100/23341)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2685/2761)49%
(5767/11835)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(826/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/18/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 15 Jul 2018 16:12:57 +
 Build duration:
5 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/95/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 15 Jul 2018 16:12:28 +
 Build duration:
3 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6312/8408)43%
(10110/23345)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2687/2761)49%
(5776/11833)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(827/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/39/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 15 Jul 2018 16:09:10 +
 Build duration:
3 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6306/8405)43%
(10104/23323)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2685/2758)49%
(5773/11817)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(726/908)52%
(824/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 41 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/41/
 Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sun, 15 Jul 2018 16:10:55 +
 Build duration:
1 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 104.39 KB...][Pipeline] { (Compiling)[Pipeline] bat[Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10] Running batch scriptC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.0.16 - empower your coresScanning dependencies of target KF5CoreAddons_autogen[  0%] Automatic MOC for target KF5CoreAddons[  0%] Built target KF5CoreAddons_autogenScanning dependencies of target desktoptojson_autogen[  0%] Automatic MOC for target desktoptojson[  0%] Built target desktoptojson_autogenScanning dependencies of target ktexttohtmltest_autogen[  0%] Automatic MOC for target ktexttohtmltest[  0%] Built target ktexttohtmltest_autogenScanning dependencies of target KF5CoreAddons[  0%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kaboutdata.cpp.obj[  1%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kcoreaddons.cpp.obj[  0%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.obj[  3%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.obj[  3%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.obj[  3%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.obj[  4%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.obj[  4%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.objkaboutdata.cppkcoreaddons.cpp[  5%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.objkfilesystemtype.cpp[  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.objkmessage.cpp[  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.objkbackup.cppKDE5 TODO: Remove KConfig correctlykautosavefile.cpp[  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.objkprocess.cpp[  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.obj[  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.objkurlmimedata.cppkjobuidelegate.cppkdirwatch.cppkcompositejob.cppkjob.cppkpluginfactory.cppkjobtrackerinterface.cpp[  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginloader.cpp.objkpluginloader.cpp[  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginmetadata.cpp.objkpluginmetadata.cpp[ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/desktopfileparser.cpp.obj[ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandom.cpp.objdesktopfileparser.cppkrandom.cpp[ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandomsequence.cpp.objC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(124): warning C4996: 'KPluginFactory::createPartObject': was declared deprecatedC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(103): note: see declaration of 'KPluginFactory::createPartObject'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(129): warning C4996: 'KPluginFactory::createObject': was declared deprecatedC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(93): note: see declaration of 'KPluginFactory::createObject'krandomsequence.cpp[ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander.cpp.objkmacroexpander.cpp[ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kstringhandler.cpp.objkstringhandler.cpp[ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/ktexttohtml.cpp.objktexttohtml.cpp[ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4migration.cpp.objkdelibs4migration.cpp[ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4configmigrator.cpp.objkdelibs4configmigrator.cpp[ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformat.cpp.objkformat.cpp[ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformatprivate.cpp.objkformatprivate.cpp[ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kshell.cpp.obj[ 16%] Building CXX object 

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/17/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 15 Jul 2018 16:09:10 +
 Build duration:
3 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/94/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 15 Jul 2018 16:09:10 +
 Build duration:
3 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6305/8405)43%
(10102/23327)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2685/2758)49%
(5770/11815)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(726/908)52%
(825/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 40 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/40/
 Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sun, 15 Jul 2018 16:09:10 +
 Build duration:
1 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 106.52 KB...]**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.0.16 - empower your coresScanning dependencies of target KF5CoreAddons_autogen[  0%] Automatic MOC for target KF5CoreAddons[  0%] Built target KF5CoreAddons_autogenScanning dependencies of target desktoptojson_autogen[  0%] Automatic MOC for target desktoptojson[  0%] Built target desktoptojson_autogenScanning dependencies of target ktexttohtmltest_autogen[  0%] Automatic MOC for target ktexttohtmltest[  0%] Built target ktexttohtmltest_autogenScanning dependencies of target KF5CoreAddons[  0%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kaboutdata.cpp.obj[  1%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kcoreaddons.cpp.obj[  1%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.obj[  2%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.obj[  3%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.obj[  3%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.obj[  4%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.obj[  4%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.objkaboutdata.cpp[  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.obj[  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.obj[  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.obj[  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.objkcoreaddons.cpp[  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.objkmessage.cpp[  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.objkbackup.cppKDE5 TODO: Remove KConfig correctlykjobtrackerinterface.cpp[  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginloader.cpp.obj[  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginmetadata.cpp.objkfilesystemtype.cppkurlmimedata.cppkjob.cppkcompositejob.cpp[ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/desktopfileparser.cpp.obj[ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandom.cpp.objkautosavefile.cpp[ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandomsequence.cpp.obj[ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander.cpp.obj[ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kstringhandler.cpp.objkjobuidelegate.cppkstringhandler.cppkdirwatch.cppdesktopfileparser.cppkpluginfactory.cppkprocess.cppkpluginloader.cppkrandom.cppkmacroexpander.cppkrandomsequence.cppkpluginmetadata.cpp[ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/ktexttohtml.cpp.objktexttohtml.cpp[ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4migration.cpp.objC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(124): warning C4996: 'KPluginFactory::createPartObject': was declared deprecatedC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(103): note: see declaration of 'KPluginFactory::createPartObject'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(129): warning C4996: 'KPluginFactory::createObject': was declared deprecatedC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(93): note: see declaration of 'KPluginFactory::createObject'kdelibs4migration.cpp[ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4configmigrator.cpp.objkdelibs4configmigrator.cpp[ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformat.cpp.objkformat.cpp[ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformatprivate.cpp.objkformatprivate.cpp[ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kshell.cpp.obj[ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/caching/kshareddatacache_win.cpp.objkshell.cppkshareddatacache_win.cpp[ 17%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander_win.cpp.objkmacroexpander_win.cpp[ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kshell_win.cpp.objkshell_win.cpp[ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kuser_win.cpp.objkuser_win.cpp[ 19%] Building CXX object 

D14121: KFormat: Add unit tests for mili/micro SI prefixes

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R244:b95bfd7e47a3: KFormat: Add unit tests for mili/micro SI 
prefixes (authored by bruns).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14121?vs=37808=37817

REVISION DETAIL
  https://phabricator.kde.org/D14121

AFFECTED FILES
  autotests/kformattest.cpp

To: bruns, #frameworks, kossebau, astippich
Cc: astippich, kde-frameworks-devel, michaelh, ngraham, bruns

D14135: KFormat: fix typo in SI prefix name enum

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:2300c57fcd75: KFormat: fix typo in SI prefix name enum 
(authored by bruns).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14135?vs=37807=37816

REVISION DETAIL
  https://phabricator.kde.org/D14135

AFFECTED FILES
  src/lib/util/kformat.h
  src/lib/util/kformatprivate.cpp

To: bruns, #frameworks, astippich, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14135: KFormat: fix typo in SI prefix name enum

[Pino Toscano]

pino accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  prefix_typo

REVISION DETAIL
  https://phabricator.kde.org/D14135

To: bruns, #frameworks, astippich, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14137: CSS: update syntax and fix some errors

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
jpoelen added projects: Frameworks, Framework: Syntax Highlighting.
Restricted Application added a project: Kate.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - fix tag followed by a pseudo-class in a nested rule (@media, ...)
  - fix constraint in a rule
  - fix Kate auto-completion for properties and rules
  
  New highlighting categories
  
  - Keyword
  - Operator
  - Separator Symbol
  - SpecialChar
  - Variable
  - Value Keyword
  - Color
  - Number
  - Unit
  - Selector Tag

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  css

REVISION DETAIL
  https://phabricator.kde.org/D14137

AFFECTED FILES
  autotests/folding/highlight.css.fold
  autotests/html/highlight.css.html
  autotests/html/review128925-1.css.html
  autotests/html/review128925-2.css.html
  autotests/html/test.htm.html
  autotests/input/highlight.css
  autotests/reference/highlight.css.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/test.css.ref
  autotests/reference/test.htm.ref
  data/syntax/css.xml

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14121: KFormat: Add unit tests for mili/micro SI prefixes

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> astippich wrote in kformattest.cpp:118
> typo: KFormat::UnitPrefix::Mil_l_i . Should be safe to change it since it 
> hasn't been released in its current state, isn't it?

see D14135 

REPOSITORY
  R244 KCoreAddons

BRANCH
  test1

REVISION DETAIL
  https://phabricator.kde.org/D14121

To: bruns, #frameworks, kossebau, astippich
Cc: astippich, kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Stefan Brüns]

bruns added a comment.


  In D13583#292480 , @siddharthasahu 
wrote:
  
  > Hi. This commit seems to have introduced a build failure when the optional 
component PythonModuleGeneration is enabled: 
https://paste.kde.org/pvh0kutbq/5jo1sl
  
  
  Apparently it does not handle strongly typed enums - it has to be e.g. 
KFormat::UnitPrefix::AutoAdjust

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: siddharthasahu, bcooksley, kossebau, kde-frameworks-devel, astippich, 
michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Stefan Brüns]

bruns added a dependent revision: D14135: KFormat: fix typo in SI prefix name 
enum.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: siddharthasahu, bcooksley, kossebau, kde-frameworks-devel, astippich, 
michaelh, ngraham, bruns

D14135: KFormat: fix typo in SI prefix name enum

[Stefan Brüns]

bruns added a dependency: D13583: KFormat: Allow usage of quantities beyond 
bytes and seconds.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14135

To: bruns, #frameworks, astippich
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Siddhartha Sahu]

siddharthasahu added a comment.


  Hi. This commit seems to have introduced a build failure when the optional 
component PythonModuleGeneration is enabled: 
https://paste.kde.org/pvh0kutbq/5jo1sl
  
  On a related note, the CI does not have that component enables, which means 
it is not getting tested. Perhaps the optional components should also be 
enabled?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: siddharthasahu, bcooksley, kossebau, kde-frameworks-devel, astippich, 
michaelh, ngraham, bruns

D14121: KFormat: Add unit tests for mili/micro SI prefixes

[Stefan Brüns]

bruns edited dependencies, added: D14135: KFormat: fix typo in SI prefix name 
enum; removed: D13583: KFormat: Allow usage of quantities beyond bytes and 
seconds.

REPOSITORY
  R244 KCoreAddons

BRANCH
  test1

REVISION DETAIL
  https://phabricator.kde.org/D14121

To: bruns, #frameworks, kossebau, astippich
Cc: astippich, kde-frameworks-devel, michaelh, ngraham, bruns

D14135: KFormat: fix typo in SI prefix name enum

[Stefan Brüns]

bruns added a dependent revision: D14121: KFormat: Add unit tests for 
mili/micro SI prefixes.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14135

To: bruns, #frameworks, astippich
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14134: KFormat: fix typo in SI prefix name enum

[Stefan Brüns]

bruns abandoned this revision.
bruns added a comment.


  duplicate

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14134

To: bruns, #frameworks, astippich, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Stefan Brüns]

bruns removed a dependent revision: D14121: KFormat: Add unit tests for 
mili/micro SI prefixes.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, 
bruns

D14121: KFormat: Add unit tests for mili/micro SI prefixes

[Stefan Brüns]

bruns updated this revision to Diff 37808.
bruns added a comment.


  update after typo fix

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14121?vs=37775=37808

BRANCH
  test1

REVISION DETAIL
  https://phabricator.kde.org/D14121

AFFECTED FILES
  autotests/kformattest.cpp

To: bruns, #frameworks, kossebau, astippich
Cc: astippich, kde-frameworks-devel, michaelh, ngraham, bruns

D14134: KFormat: fix typo in SI prefix name enum

[Stefan Brüns]

bruns requested review of this revision.
bruns added a comment.


  duplicate

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14134

To: bruns, #frameworks, astippich, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14135: KFormat: fix typo in SI prefix name enum

[Stefan Brüns]

bruns updated this revision to Diff 37807.
bruns added a comment.


  Complete the fix

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14135?vs=37806=37807

BRANCH
  prefix_typo

REVISION DETAIL
  https://phabricator.kde.org/D14135

AFFECTED FILES
  src/lib/util/kformat.h
  src/lib/util/kformatprivate.cpp

To: bruns, #frameworks, astippich
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14135: KFormat: fix typo in SI prefix name enum

[Pino Toscano]

pino added a comment.


  Duplicate of D14134: KFormat: fix typo in SI prefix name enum 
? If so, please abandon this.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14135

To: bruns, #frameworks, astippich
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14134: KFormat: fix typo in SI prefix name enum

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  It must be fixed in `src/lib/util/kformatprivate.cpp` too.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14134

To: bruns, #frameworks, astippich, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14135: KFormat: fix typo in SI prefix name enum

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, astippich.
bruns added a project: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  Its milli, not mili. Change the enum name without any backwards
  compatibility, as the name is not yet in any release.

REPOSITORY
  R244 KCoreAddons

BRANCH
  prefix_typo

REVISION DETAIL
  https://phabricator.kde.org/D14135

AFFECTED FILES
  src/lib/util/kformat.h

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14134: KFormat: fix typo in SI prefix name enum

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, astippich.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Its milli, not mili. Change the enum name without any backwards
  compatibility, as the name is not in any release yet.

REPOSITORY
  R244 KCoreAddons

BRANCH
  prefix_typo

REVISION DETAIL
  https://phabricator.kde.org/D14134

AFFECTED FILES
  src/lib/util/kformat.h

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D13583#292115 , @bcooksley 
wrote:
  
  > You can add #windows  to a 
review, however there still needs to be a degree of responsibility by those who 
are actually making commits to projects (especially in the case of #Frameworks 
).
  
  
  Sure, breaking things on purpose or by complete ignorance is not what I mean 
here. I am searching for responsibility of those who want to see certain 
platforms supported, to have known ways to approach them in case of such 
emergencies, where progress is inhibited due to platform-specific issues (and 
especially when it comes to ClosedSource/questionably licensed platforms which 
undermine the whole idea oif KDE software).
  
  Or even see those stakeholders proactively care for their platform. See e.g. 
all the KF5 unit tests which only fail on Windows. That does not help those who 
work on enhancing KF5 for FLOSS platforms, they cannot be sure if it was their 
work which fails on that other platform. It also sends a signal of dont-care to 
their fellows :(
  
  And app developers using KF5 on those platforms need to take responsibility, 
too. Saying "oh, In version x.y.z things worked for me on all platforms, now 
don't dare to touch it, as I only care for my app and not somebody else needs" 
does not work for shared libraries. They are shared between all the app 
developers, not given to them as free present. We are collaborating here on the 
KF5 libraries. Delegating platform maintainership on your active fellows is 
surely not what we want, right?
  
  > The fix in this case is likely relatively trivial, so it should be done by 
the original developer.
  
  Even if trivial, it needs persons not interested in a platform (and here even 
a platform from the dark side of the software universe) do work for those who 
are interested in it. Which also means, that very issue which caused the need 
for a workaround is not reported upstream by the stakeholders or tracked in any 
way by them. We do not know e.g. which versions of the compilers are affected, 
so when this workaround can be removed again to clean the code.
  
  Thankfully your work on the staging builds for review requests might improve 
the situation., catching such breakage before its enters the repos. But it 
still needs some organized way to have stakeholders of all platforms involved, 
taking up their duties of maintainership of the platforms. If things should be 
supported on Android, Windows, etc, there need to be well known point of 
contacts.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, 
bruns

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/12/
 Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 15 Jul 2018 12:07:40 +
 Build duration:
1 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D14131: Add enum alias Property::Language for typo Property::Langauge

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: mgallien.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
kossebau requested review of this revision.

TEST PLAN
  Unit tests still pass, Dolphin still shows the right file metadata

REPOSITORY
  R286 KFileMetaData

BRANCH
  fixLangaugeEnumTypoNow

REVISION DETAIL
  https://phabricator.kde.org/D14131

AFFECTED FILES
  autotests/office2007extractortest.cpp
  autotests/taglibextractortest.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp
  src/extractors/taglibextractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: kossebau, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 11 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/11/
 Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 15 Jul 2018 11:52:35 +
 Build duration:
5 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.ktextwidgets-krichtextedittest

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/10/
 Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 15 Jul 2018 11:44:00 +
 Build duration:
1 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D14121: KFormat: Add unit tests for mili/micro SI prefixes

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  test itself is fine, but I spotted a typo.

INLINE COMMENTS

> kformattest.cpp:118
> +
> +QCOMPARE(format.formatValue(0.010, KFormat::Unit::Meter, 1, 
> KFormat::UnitPrefix::Mili, KFormat::MetricBinaryDialect), 
> QStringLiteral("10.0 mm"));
> +QCOMPARE(format.formatValue(10.12e-6, KFormat::Unit::Meter, 2, 
> KFormat::UnitPrefix::Micro, KFormat::MetricBinaryDialect), 
> QStringLiteral("10.12 µm"));

typo: KFormat::UnitPrefix::Mil_l_i . Should be safe to change it since it 
hasn't been released in its current state, isn't it?

REPOSITORY
  R244 KCoreAddons

BRANCH
  test1

REVISION DETAIL
  https://phabricator.kde.org/D14121

To: bruns, #frameworks, kossebau, astippich
Cc: astippich, kde-frameworks-devel, michaelh, ngraham, bruns

D14124: Fix qtplugins in KStandardDirs

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R239:3ab2e2f5592d: Fix qtplugins in KStandardDirs (authored by 
arojas).

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14124?vs=37785=37794

REVISION DETAIL
  https://phabricator.kde.org/D14124

AFFECTED FILES
  src/kdecore/kstandarddirs.cpp

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/27/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 15 Jul 2018 09:41:59 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kglobalsettingstestFailed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21718/45960)38%
(13162/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11460/11759)50%
(7245/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9501/17866)49%
(5591/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(747/9693)6%
(325/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

how to get the list of keywords in KSyntaxHighlighting

[Alexander Semke]

Hi,

I'd like to remove the maintenance of syntax keywords in Cantor (e.g. https://
cgit.kde.org/cantor.git/tree/src/backends/maxima/maximakeywords.cpp) and to 
switch to KSyntaxHighlighting.

Cantor uses its own highlighters and I'd need to get the list of keywords from 
KSyntaxHighlighter for this (constructor in https://cgit.kde.org/cantor.git/
tree/src/backends/maxima/maximahighlighter.cpp). If I see it correctly, 
DefinitionData holding the keyword lists is not part of the public API. I don't 
see how to get the list of keywords.

Ideally, there should be something like

QStringList Definition::keywordListsNames() const;

to get the list of available section in the xml syntax file and

QStringList Definition::keyworkList(const QString& name) const;

to get the actual keywords for the specified section.


Would this make sense or is there already another way to get the keywords?


Regards,
Alexander 

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/13/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 15 Jul 2018 09:41:59 +
 Build duration:
5 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kmimetypetestFailed: TestSuite.kstandarddirstest

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/53/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 15 Jul 2018 09:41:59 +
 Build duration:
3 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21610/45959)38%
(13044/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9471/17864)48%
(5539/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D14124: Fix qtplugins in KStandardDirs

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Interestingly it works for me with and without this patch, because of 
"%lib/plugins/" later on in the code, but indeed at that point installdir is 
/d/kde/inst/kde_frameworks/lib64/plugins/plugins/ which looks wrong.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14124

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14124: Fix qtplugins in KStandardDirs

[Antonio Rojas]

arojas created this revision.
arojas added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  PLUGIN_INSTALL_DIR already contains the /plugins/ suffix, don't duplicate it

TEST PLAN
  'kf5-config --path qtplugins' returns the right thing

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14124

AFFECTED FILES
  src/kdecore/kstandarddirs.cpp

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns