D13808: Fix KMainWindow saving incorrect widget settings

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I say let's remove the test for now so we can commit this, and then you 
can add the test back in another patch please (in working form, of course!). :)

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: arojas, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D13773: [KDirOperator] Use alternating background colors for multi-column views

[Nathaniel Graham]

ngraham retitled this revision from "[KDirOperator] Use alternating background 
colors for list-style views" to "[KDirOperator] Use alternating background 
colors for multi-column views".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13773

To: ngraham, #frameworks, #vdg, #dolphin
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

[Nathaniel Graham]

ngraham updated this revision to Diff 37920.
ngraham added a comment.


  Only use the alternating row colors for multi-column views, to avoid having 
it on any vertical sidebar-style lists

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13773?vs=36806=37920

BRANCH
  alternating-row-colors-for-list-style-views (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13773

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: ngraham, #frameworks, #vdg, #dolphin
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

[Roman Gilg]

romangg added a dependent revision: D14176: Use locked cursor position hint.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14175

To: romangg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

[Roman Gilg]

romangg added a task: T4692: [kwayland] Support cursor hint on 
LockedPointerInterface.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14175

To: romangg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

[Roman Gilg]

romangg updated this revision to Diff 37917.
romangg added a comment.


  - Cleanup: remove hint getter

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14175?vs=37916=37917

BRANCH
  cursorHints

REVISION DETAIL
  https://phabricator.kde.org/D14175

AFFECTED FILES
  src/server/pointerconstraints_interface.cpp
  src/server/pointerconstraints_interface.h
  src/server/pointerconstraints_interface_p.h
  src/server/pointerconstraints_interface_v1.cpp

To: romangg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Implement support for locked pointer cursor hints.

TEST PLAN
  Needs autotest.

REPOSITORY
  R127 KWayland

BRANCH
  cursorHints

REVISION DETAIL
  https://phabricator.kde.org/D14175

AFFECTED FILES
  src/server/pointerconstraints_interface.cpp
  src/server/pointerconstraints_interface.h
  src/server/pointerconstraints_interface_p.h
  src/server/pointerconstraints_interface_v1.cpp

To: romangg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14052: Add bluetooth plugin

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:1
> Maybe should have `find_qmlmodule(org.kde.bluezqt 1.0)`?

Makes sense.

When I include it cmake tells me it's not found, although 
/usr/lib/qt/qml/org/kde/bluezqt exists. Am I missing something?

REPOSITORY
  R495 Purpose Library

BRANCH
  bluetooth

REVISION DETAIL
  https://phabricator.kde.org/D14052

To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 57 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/57/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 16 Jul 2018 21:30:24 +
 Build duration:
6 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(27/33)82%
(27/33)79%
(2273/2891)68%
(1562/2301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(499/512)63%
(244/388)examples0%
(0/2)0%
(0/2)0%
(0/197)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib86%
(18/21)86%
(18/21)85%
(1595/1879)74%
(1165/1583)

D14137: CSS: update syntax and fix some errors

[jonathan poelen]

jpoelen added a comment.


  It is done. So much emotion :')

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14137

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 41 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/41/
 Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 16 Jul 2018 21:30:24 +
 Build duration:
2 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.testhighlighter_test

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 113 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/113/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Jul 2018 21:30:24 +
 Build duration:
2 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(27/33)82%
(27/33)79%
(2273/2891)68%
(1562/2301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(499/512)63%
(244/388)examples0%
(0/2)0%
(0/2)0%
(0/197)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib86%
(18/21)86%
(18/21)85%
(1595/1879)74%
(1165/1583)

D14137: CSS: update syntax and fix some errors

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:423239c45ec5: CSS: update syntax and fix some errors 
(authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14137?vs=37815=37912

REVISION DETAIL
  https://phabricator.kde.org/D14137

AFFECTED FILES
  autotests/folding/highlight.css.fold
  autotests/html/highlight.css.html
  autotests/html/review128925-1.css.html
  autotests/html/review128925-2.css.html
  autotests/html/test.htm.html
  autotests/input/highlight.css
  autotests/reference/highlight.css.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/test.css.ref
  autotests/reference/test.htm.ref
  data/syntax/css.xml

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14160: [KMessageBox] Call style for icon

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  In general, looks good to me.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14160

To: broulik, dfaure, kfunk, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

[Mladen Milinkovic]

maxrd2 added a comment.


  @ngraham Don't think I can. I have no commit rights.
  Should i revert/remove test part, as currently it doesn't test anything i 
believe.. it always passes.

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: arojas, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Siddhartha Sahu]

siddharthasahu added a comment.


  Thank you for the clarification @bcooksley. I wonder if there is a way to 
enforce compilation of certain parts single threaded in make. Or some other way 
to ensure testing these components.
  
  But in any case, the builds are still failing for me. I hope @bruns or 
someone else will fix it soon. Thanks.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: siddharthasahu, bcooksley, kossebau, kde-frameworks-devel, astippich, 
michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

[Nathaniel Graham]

ngraham added a comment.


  Shall we commit this? maxrd2 , can you do it, or does one of us need to 
commit it for you?

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: arojas, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

[René J . V . Bertin]

rjvbb updated this revision to Diff 37897.
rjvbb added a comment.


  Using QApplication::style()

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14000?vs=37568=37897

REVISION DETAIL
  https://phabricator.kde.org/D14000

AFFECTED FILES
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h

To: rjvbb, #frameworks
Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

[René J . V . Bertin]

rjvbb set the repository for this revision to R858 Qt Quick Controls 2: Desktop 
Style.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D14000

To: rjvbb, #frameworks
Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale

[Albert Astals Cid]

aacid added a comment.


  The docu of ki18n says we localize numbers (as far as i remember), so that 
patch you discarded is "the right thing" imho

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D12164

To: kossebau, ilic
Cc: aacid, kde-frameworks-devel, huftis, broulik, michaelh, ngraham, bruns

D14052: Add bluetooth plugin

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  LGTM overall.

INLINE COMMENTS

> CMakeLists.txt:1
> +add_share_plugin(bluetoothplugin bluetoothplugin.cpp)

Maybe should have `find_qmlmodule(org.kde.bluezqt 1.0)`?

REPOSITORY
  R495 Purpose Library

BRANCH
  bluetooth

REVISION DETAIL
  https://phabricator.kde.org/D14052

To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

[Alexey Min]

alexeymin added a comment.


  Don't know how much offtopic will be what I'm going to say, but I recently 
ran into an issue while packaging QQC2 application in flatpak with 
org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, 
but under flatpak it failed to start with the following message: `QWidget: 
Cannot create a QWidget without QApplication`. Of course, I had only 
QGuiApplication. But I wasn't using widgets! The only class from QtWidgets was 
QSystemTrayIcon for a nice integration with desktop. My guess was that was 
caused by platform style used in flatpak's KDE runtime may use widgets. But 
this was unexpected, without flatpak all was working. In the end I was forced 
to use QApplication, and visually saw the style used was ogr.kde.desktop.
  
  I wrote a small test QML QQC2 program with QGuiApplication and packaged it 
with flatpak with the same runtime, surprisingly, it started OK, without any 
error message. Basically, QQC2 ApplicationWindow with a button inside, not 
linked to widgets. ( https://github.com/minlexx/test_qqc2hello - repo with test 
scripts )
  
  So, if the program is linked to Qt5Widgets in any way, it has to use 
QApplication in flatpak's org.kde.Platform even if it does not use widgets? Is 
it related to this patch? Will it solve my problem? (if included in flatpak's 
kde runtime) 

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D14000

To: rjvbb, #frameworks
Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14123: Add `drive-optical` icon

[Andreas Kainz]

andreaska added a comment.


  Thanks for the patch.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14123

To: ngraham, broulik, andreask, #breeze, #vdg
Cc: andreaska, kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Upon close look I realised that there was a lot of allocations there. It 
turned
  out to be because it's allocating for the whole size of the value for every 
item.
  This way we just do it for the value of the element.
  It also includes a unit test that showed this escaping code never actually 
worked
  because the parser was choking on it.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14162

AFFECTED FILES
  autotests/kconfigtest.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp

To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13773

To: ngraham, #frameworks, #vdg, #dolphin
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14161: [KStyle] Use dialog-question for question icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, ngraham, rkflx.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This was changed in `KMessageBox` in 9b05a12a43dbe2b31a4655052f20de0832ac7a61 
 but 
never "upstreamed" to `KStyle` which wasn't an issue until D14160 

  
  `dialog-information` is kept as a fallback since e.g. Oxygen doesn't have 
`dialog-question` since using that icon is a pretty new addition

TEST PLAN
  `kdialog --yesno "test"` shows question mark icon again in Breeze. shows 
information icon still with Oxygen.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D14161

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: broulik, dfaure, ngraham, rkflx
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14160: [KMessageBox] Call style for icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, kfunk.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `QMessageBox::standardIcon` is deprecated. Also, both `QCommonStyle` does 
exactly what we do here, and so does `KStyle`.

TEST PLAN
  Tests still pass. Dialog icons are correct on Linux with Breeze, Fusion, and 
Windows 95 style.
  This needs testing on Windows and Mac as there it might use the 
system-provided graphics now?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14160

AFFECTED FILES
  src/kmessagebox.cpp

To: broulik, dfaure, kfunk
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

[Nathaniel Graham]

ngraham added a comment.


  Ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13773

To: ngraham, #frameworks, #vdg, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

[David Edmundson]

davidedmundson added a comment.


  Please swap qApp->style for QApplication::style as it's static.
  
  Solution is quite clever. 
  It's risky as any qstyle will always be written assuming it's a QApplication; 
but by definition the QQC2 code shields from a lot of the QWidget casting that 
would cause an issue.
  
  Worst case we crash, which is the current state.
  
  I don't think we should remove the plasma-integration guard, but this is 
surprisingly un-invasive. Meh, +1

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D14000

To: rjvbb, #frameworks
Cc: davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/96/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Jul 2018 15:23:37 +
 Build duration:
3 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/40/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 16 Jul 2018 15:23:37 +
 Build duration:
1 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/16/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 16 Jul 2018 15:23:37 +
 Build duration:
1 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.scalable

D14123: Add `drive-optical` icon

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:ca645a423dbb: Add `drive-optical` icon (authored by 
ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14123?vs=37779=37881

REVISION DETAIL
  https://phabricator.kde.org/D14123

AFFECTED FILES
  icons-dark/devices/16/drive-optical.svg
  icons-dark/devices/22/drive-optical.svg
  icons-dark/devices/64/drive-optical.svg
  icons/devices/16/drive-optical.svg
  icons/devices/22/drive-optical.svg
  icons/devices/64/drive-optical.svg

To: ngraham, broulik, andreask, #breeze, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14123: Add `drive-optical` icon

[Nathaniel Graham]

ngraham added a comment.


  @andreask verbally (textually?) approved this in the VDG room; landing it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14123

To: ngraham, broulik, andreask, #breeze, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12388: Output device color curves correction

[David Edmundson]

davidedmundson updated this revision to Diff 37879.
davidedmundson added a comment.


  Rebase and fix conflicts

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12388?vs=34770=37879

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12388

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h

To: davidedmundson, #frameworks, graesslin, romangg
Cc: kde-frameworks-devel, graesslin, davidedmundson, zzag, cfeck, michaelh, 
ngraham, bruns

D12388: Output device color curves correction

[David Edmundson]

davidedmundson commandeered this revision.
davidedmundson edited reviewers, added: romangg; removed: davidedmundson.
davidedmundson added a comment.


  Comadeering to rebase on top of my changes that also moved outputdevice to 
version 2.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: davidedmundson, #frameworks, graesslin, romangg
Cc: kde-frameworks-devel, graesslin, davidedmundson, zzag, cfeck, michaelh, 
ngraham, bruns

D14097: Change default sort order in the download dialog to Rating

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D14097

To: ngraham, apol, leinir, #knewstuff
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13899: KMessageWidget: use theme instead of hardcoded colours

[Nathaniel Graham]

ngraham added a comment.


  I think the problem here is that while themes have dedicated Positive, 
Negative, and Neutral colors, for the Informational color we just re-use the 
active or highlight color from the theme, which may not always be appropriate 
for use as a background for informational KMessageWidgets. With a lot of 
themes, this color winds up looking like the negative color or just being 
really weird.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13899

To: rjvbb, #frameworks, #vdg
Cc: ngraham, aacid, broulik, kde-frameworks-devel, michaelh, crozbo, firef, 
bruns, skadinna, aaronhoneycutt, mbohlender

D13828: Revert "updated Japanese holidays (in Japanese and English)"

[Jumpei Ogawa]

phanect abandoned this revision.
phanect added a comment.


  Sorry, I didn't notice that I have permission to close this.
  I just closed this.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D13828

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 68 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/68/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Jul 2018 14:13:46 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 41 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSelectionFailed: TestSuite.kwayland-testTextInputFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(228/254)90%
(228/254)85%
(23862/27957)52%
(9434/18049)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)97%
(11121/11516)49%
(5903/12105)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(70/72)97%
(70/72)84%
(5600/6695)64%
(1487/2308)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server97%
(111/115)97%
(111/115)86%
(6707/7815)65%
(1875/2879)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/30/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 16 Jul 2018 14:13:46 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 16 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSelectionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgShellStableFailed: TestSuite.kwayland-testXdgShellV5

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/41/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 16 Jul 2018 14:13:46 +
 Build duration:
7 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 41 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSelectionFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(228/254)90%
(228/254)85%
(23842/27957)52%
(9423/18049)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)96%
(11102/11516)49%
(5894/12105)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(70/72)97%
(70/72)84%
(5600/6695)64%
(1486/2308)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server97%
(111/115)97%
(111/115)86%
(6706/7815)65%
(1874/2879)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/29/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 16 Jul 2018 13:39:06 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 16 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSelectionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgShellV5Failed: TestSuite.kwayland-testXdgShellV6

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/40/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 16 Jul 2018 13:39:06 +
 Build duration:
8 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSelectionFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(228/254)90%
(228/254)85%
(23862/27957)52%
(9434/18049)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)97%
(11121/11516)49%
(5903/12105)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(70/72)97%
(70/72)84%
(5600/6695)64%
(1487/2308)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server97%
(111/115)97%
(111/115)86%
(6707/7815)65%
(1875/2879)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/67/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Jul 2018 13:39:06 +
 Build duration:
8 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSelectionFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(228/254)90%
(228/254)85%
(23864/27958)52%
(9432/18049)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)97%
(11123/11517)49%
(5902/12105)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(70/72)97%
(70/72)84%
(5600/6695)64%
(1486/2308)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server97%
(111/115)97%
(111/115)86%
(6707/7815)65%
(1875/2879)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 79 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/79/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Jul 2018 13:29:26 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)19%
(412/2116)18%
(194/1082)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(119/123)58%
(56/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/20)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%

D13899: KMessageWidget: use theme instead of hardcoded colours

[René J . V . Bertin]

rjvbb added a comment.


  This is what approach 1 looks like with (clockwise) Breeze Dark, Oxygen and 
Wonton Soup:
  
  F6110913: image.png 
  
  Positive messages don't have an icon here because currently only the Breeze 
icon set has a "positive" icon. The absence doesn't disturb me here and may 
even be good if my assumption is correct that this kind of message should draw 
less attention than information messages.
  
  An actual (information) message in an actual context (using Breeze and my own 
colour scheme):
  
  F6110973: image.png 
  
  F6110977: image.png 
  
  Try as I might, I don't see how it could get any better from a design 
approach that favours non-intrusive interfaces (based on 10yo fond memories of 
Tufte's books). The slightly lighter or darker "normal" background with 
coloured border draws attention and helps giving urgency to the display but 
limits visual clutter compared to a coloured background. Text in the regular 
colour on the (almost) standard background means the message reads just as 
easily as any other text.
  
  Evidently one can obtain the same effect and more with approach 2 but the 
image above is obtained with only small modifications of the current patch.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13899

To: rjvbb, #frameworks, #vdg
Cc: ngraham, aacid, broulik, kde-frameworks-devel, michaelh, crozbo, firef, 
bruns, skadinna, aaronhoneycutt, mbohlender

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

[Kai Uwe Broulik]

broulik added a comment.


  Should this show an error to the user? I could also imagine this interfering 
with thumbnail generation when viewing the device

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14158

To: jtamate, #frameworks
Cc: broulik

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 56 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/56/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 16 Jul 2018 13:29:26 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)20%
(429/2116)19%
(209/1082)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)53%
(51/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/20)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%
 

D14052: Add bluetooth plugin

[Nicolas Fella]

nicolasfella added a comment.


  @apol I would like your opinion before merging

REPOSITORY
  R495 Purpose Library

BRANCH
  bluetooth

REVISION DETAIL
  https://phabricator.kde.org/D14052

To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14107: [Telegram] Don't wait for Telegram to be closed

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:6803b1203e46: [Telegram] Dont wait for Telegram to 
be closed (authored by nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14107?vs=37723=37875

REVISION DETAIL
  https://phabricator.kde.org/D14107

AFFECTED FILES
  src/plugins/telegram/telegramplugin.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 66 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/66/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Jul 2018 12:21:56 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 41 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSelectionFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)89%
(226/254)89%
(226/254)82%
(22916/27912)50%
(8950/18049)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(39/41)95%
(39/41)91%
(10526/11513)46%
(5578/12105)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client96%
(69/72)96%
(69/72)80%
(5326/6673)58%
(1338/2308)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server97%
(111/115)97%
(111/115)85%
(6630/7795)65%
(1865/2879)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 28 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/28/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 16 Jul 2018 12:21:56 +
 Build duration:
7 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 14 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSelectionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 39 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/39/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 16 Jul 2018 12:21:56 +
 Build duration:
6 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testSelectionFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(228/254)90%
(228/254)85%
(23860/27958)52%
(9429/18049)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)97%
(11122/11517)49%
(5902/12105)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(70/72)97%
(70/72)84%
(5597/6695)64%
(1483/2308)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server97%
(111/115)97%
(111/115)86%
(6707/7815)65%
(1875/2879)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

D13510: Add XDG WM Base support to our XDGShell API

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:59259d8dc1f3: Add XDG WM Base support to our XDGShell API 
(authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13510?vs=36244=37872

REVISION DETAIL
  https://phabricator.kde.org/D13510

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_shell.cpp
  autotests/client/test_xdg_shell_stable.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-shell.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgshell.cpp
  src/client/xdgshell.h
  src/client/xdgshell_p.h
  src/client/xdgshell_stable.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_stable_interface.cpp
  src/server/xdgshell_stable_interface_p.h

To: davidedmundson, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13488: Make XDGShellV5 co-compilable with XDGWMBase

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:63bd1f441644: Make XDGShellV5 co-compilable with 
XDGWMBase (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13488?vs=37034=37871

REVISION DETAIL
  https://phabricator.kde.org/D13488

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/registry.cpp
  src/client/xdgshell_v5.cpp
  src/compat/wayland-xdg-shell-v5-client-protocol.h
  src/compat/wayland-xdg-shell-v5-protocol.c
  src/compat/wayland-xdg-shell-v5-server-protocol.h
  src/server/CMakeLists.txt
  src/server/xdgshell_v5_interface.cpp

To: davidedmundson, #plasma, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  When the device is blocked, for example by amarok mtp plugin, the result of 
LIBMTP_Open_Raw_Device_Uncached(rawDevice) is nullptr and 
  LIBMTP_Get_Friendlyname(nullptr) crashes.
  
  Avoid to create a cache for a device that can't be opened.
  
  CCBUG: 396527

TEST PLAN
  With Amarok started and its mtp plugin enabled, plug in an android device.
  Try to open it with dolphin, always the same kio backtrace:
  
==13233== Invalid read of size 8
==13233==at 0x1087ABCE: LIBMTP_Get_Friendlyname (in 
/usr/lib64/libmtp.so.9.4.0)
==13233==by 0x105EE67C: 
CachedDevice::CachedDevice(LIBMTP_mtpdevice_struct*, LIBMTP_raw_device_struct*, 
QString, int) (devicecache.cpp:44)
==13233==by 0x105F0A30: DeviceCache::checkDevice(Solid::Device) 
(devicecache.cpp:150)
==13233==by 0x105F1517: DeviceCache::DeviceCache(int, QObject*) 
(devicecache.cpp:94)
==13233==by 0x105F2FC1: MTPSlave::MTPSlave(QByteArray const&, 
QByteArray const&) (kio_mtp.cpp:70)
==13233==by 0x105F8BF9: kdemain (kio_mtp.cpp:54)
==13233==by 0x4016CC: main (kioslave.cpp:130)
==13233==  Address 0x8 is not stack'd, malloc'd or (recently) free'd
  
  And in dolphin, the message: MTP died unexpectedly
  
  After, the message: The file or folder 
udi=/org/kde/solid/udev/sys/devices/pci:00/:00:14.0/usb1/1-1 does not 
exist.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14158

AFFECTED FILES
  mtp/devicecache.cpp

To: jtamate, #frameworks

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 38 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/38/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 16 Jul 2018 12:03:46 +
 Build duration:
3 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 265.67 KB...][ 35%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/clientconnection.cpp.o[ 35%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/buffer_interface.cpp.o[ 35%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/compositor_interface.cpp.omake[1]: *** [CMakeFiles/Makefile2:175: src/client/CMakeFiles/KF5WaylandClient.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 35%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/datadevice_interface.cpp.o[ 36%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/datadevicemanager_interface.cpp.o[ 36%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/dataoffer_interface.cpp.o[ 36%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/datasource_interface.cpp.o[ 36%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/display.cpp.o[ 36%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/dpms_interface.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/filtered_display.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/global.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/idle_interface.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/idleinhibit_interface_v1.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/idleinhibit_interface.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/fakeinput_interface.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/keyboard_interface.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/remote_access_interface.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/outputconfiguration_interface.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/outputchangeset.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/outputmanagement_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/outputdevice_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/logging.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/output_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointer_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/plasmashell_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/plasmawindowmanagement_interface.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointerconstraints_interface.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointerconstraints_interface_v1.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointergestures_interface.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/qtsurfaceextension_interface.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointergestures_interface_v1.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/region_interface.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/relativepointer_interface.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/relativepointer_interface_v1.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/resource.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/seat_interface.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/slide_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/shadow_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/blur_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/surface_interface.cpp.o/home/jenkins/workspace/Frameworks kwayland kf5-qt5 SUSEQt5.9/src/server/surface_interface.cpp:278:1: warning: missing initializer for member 'wl_surface_interface::damage_buffer' [-Wmissing-field-initializers] }; ^[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/subcompositor_interface.cpp.o[ 43%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/shell_interface.cpp.o[ 43%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/server_decoration_palette_interface.cpp.o[ 43%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/touch_interface.cpp.o[ 43%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/server_decoration_interface.cpp.o[ 43%] 

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 65 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/65/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Jul 2018 12:03:46 +
 Build duration:
4 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 265.04 KB...][ 35%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/display.cpp.o[ 36%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/xdgshell.cpp.o/home/jenkins/workspace/Frameworks kwayland kf5-qt5 SUSEQt5.10/src/client/xdgshell.cpp:26:10: fatal error: wayland-xdg-shell-v5-client-protocol.h: No such file or directory #include   ^~~~compilation terminated.make[2]: *** [src/client/CMakeFiles/KF5WaylandClient.dir/build.make:895: src/client/CMakeFiles/KF5WaylandClient.dir/xdgshell.cpp.o] Error 1make[2]: *** Waiting for unfinished jobs[ 36%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/dpms_interface.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/filtered_display.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/global.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/idle_interface.cpp.omake[1]: *** [CMakeFiles/Makefile2:175: src/client/CMakeFiles/KF5WaylandClient.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/idleinhibit_interface.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/idleinhibit_interface_v1.cpp.o[ 37%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/fakeinput_interface.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/keyboard_interface.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/remote_access_interface.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/outputconfiguration_interface.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/outputchangeset.cpp.o[ 38%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/outputmanagement_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/outputdevice_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/logging.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/output_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointer_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/plasmashell_interface.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointergestures_interface_v1.cpp.o[ 39%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/qtsurfaceextension_interface.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/region_interface.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointergestures_interface.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointerconstraints_interface_v1.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/relativepointer_interface.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/pointerconstraints_interface.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/relativepointer_interface_v1.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/plasmawindowmanagement_interface.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/resource.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/seat_interface.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/slide_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/shadow_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/blur_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/contrast_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/server_decoration_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/server_decoration_palette_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/surface_interface.cpp.o[ 43%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/shell_interface.cpp.o[ 43%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/subcompositor_interface.cpp.o/home/jenkins/workspace/Frameworks kwayland kf5-qt5 SUSEQt5.10/src/server/surface_interface.cpp:278:1: warning: missing initializer for member 'wl_surface_interface::damage_buffer' [-Wmissing-field-initializers] }; ^[ 43%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/xdgshell_interface.cpp.o[ 44%] Building CXX object 

D14107: [Telegram] Don't wait for Telegram to be closed

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I guess this only happens if Telegram wasn't running already.

REPOSITORY
  R495 Purpose Library

BRANCH
  finishtelegramjob

REVISION DETAIL
  https://phabricator.kde.org/D14107

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 27 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/27/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 16 Jul 2018 12:03:46 +
 Build duration:
1 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 260.38 KB...][ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/relativepointer_interface_v1.cpp.o[ 40%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/resource.cpp.o[ 41%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/server_decoration_palette.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/seat_interface.cpp.o[ 41%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/shadow.cpp.o[ 41%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/slide_interface.cpp.o/usr/home/jenkins/workspace/Frameworks kwayland kf5-qt5 FreeBSDQt5.10/src/client/server_decoration_palette.cpp:124:34: warning: private field 'q' is not used [-Wunused-private-field]ServerSideDecorationPalette *q; ^1 warning generated.[ 41%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/shell.cpp.o/usr/home/jenkins/workspace/Frameworks kwayland kf5-qt5 FreeBSDQt5.10/src/server/seat_interface.cpp:782:50: warning: unused parameter 'button' [-Wunused-parameter]static quint32 qtToWaylandButton(Qt::MouseButton button) ^[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/shadow_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/blur_interface.cpp.o[ 42%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/shm_pool.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/contrast_interface.cpp.o[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/server_decoration_interface.cpp.o[ 42%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/subcompositor.cpp.o1 warning generated.[ 42%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/server_decoration_palette_interface.cpp.o[ 43%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/shell_interface.cpp.o[ 43%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/surface_interface.cpp.o[ 44%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/subsurface.cpp.o[ 44%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/subcompositor_interface.cpp.o/usr/home/jenkins/workspace/Frameworks kwayland kf5-qt5 FreeBSDQt5.10/src/server/surface_interface.cpp:278:1: warning: missing field 'damage_buffer' initializer [-Wmissing-field-initializers]};^[ 44%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/touch_interface.cpp.o[ 44%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/surface.cpp.o[ 44%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/textinput_interface.cpp.o1 warning generated.[ 44%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/textinput_interface_v0.cpp.o[ 45%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/textinput_interface_v2.cpp.o[ 45%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/touch.cpp.o[ 45%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/xdgshell_interface.cpp.o[ 45%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/xdgshell_v5_interface.cpp.o/usr/home/jenkins/workspace/Frameworks kwayland kf5-qt5 FreeBSDQt5.10/src/client/touch.cpp:148:1: warning: missing field 'shape' initializer [-Wmissing-field-initializers]};^[ 45%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/xdgforeign_v2_interface.cpp.o1 warning generated.[ 45%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/textinput.cpp.o[ 45%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/xdgforeign_interface.cpp.o[ 46%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/xdgshell_v6_interface.cpp.o[ 46%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/textinput_v0.cpp.o[ 46%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/xdgshell_stable_interface.cpp.o[ 46%] Building CXX object src/server/CMakeFiles/KF5WaylandServer.dir/xdgoutput_interface.cpp.o[ 47%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/textinput_v2.cpp.o[ 47%] Building CXX object src/client/CMakeFiles/KF5WaylandClient.dir/xdgshell.cpp.o[ 47%] Building C object src/server/CMakeFiles/KF5WaylandServer.dir/__/compat/wayland-xdg-shell-v5-protocol.c.o[ 47%] Building C object src/server/CMakeFiles/KF5WaylandServer.dir/wayland-output-management-protocol.c.o[ 48%] Building C object src/server/CMakeFiles/KF5WaylandServer.dir/wayland-org_kde_kwin_outputdevice-protocol.c.o[ 48%] Building C object src/server/CMakeFiles/KF5WaylandServer.dir/wayland-plasma-shell-protocol.c.o[ 48%] Building C object 

D14154: Add

[Jumpei Ogawa]

phanect retitled this revision from "Update substitute holidays & holidays 
between public holidays" to "Add ".
phanect edited the summary of this revision.
phanect added reviewers: winterz, mlaurent, KDE PIM, Frameworks.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D14154

To: phanect, winterz, mlaurent, #kde_pim, #frameworks
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

[Ben Cooksley]

bcooksley added inline comments.

INLINE COMMENTS

> dhaumann wrote in kformatprivate.cpp:121
> Would it make sense to mention with which MSVC version this was tested? At 
> some point in time, this may be fixed, and then the comment is wrong.

For the record, the current version of MSVC in use is 19.14.26430.0 (MSVS 2017, 
v15.7.3)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14122

To: bruns, #frameworks, kossebau, bcooksley
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Ben Cooksley]

bcooksley added a comment.


  In regards to Python, that is not enabled as the bindings generation is not 
reliable and can easily fail on a highly parallel system (which the CI is, 
depending on the node it could be a Hexa Core with HT, so run using make -j13)
  The generation also had a nasty tendency to fail for certain Frameworks more 
often than not due to various generation failures which would disappear on 
subsequent runs.
  
  In terms of various platforms, subscribing the appropriate Phabricator group 
when issues turn up is probably the best thing to do, we have #windows 
, #freebsd 
 and #android 
 for this. We don't have anything for 
macOS at the moment although interest in that platform is very minimal.
  
  In terms of people who support those platforms, tests haven't been addressed 
as there are only a few people who work on keeping quite a large amount of 
software working, which makes getting around to looking at the tests a bit 
difficult.
  
  I've found that the app developers do care about current versions, the 
problem arises here as they generally only use released versions rather than 
master, so any issues they find will be much later down the road when they try 
to upgrade. The CI does try to keep an eye on this fortunately and pre-review 
CI should hopefully stop breakages from being fixed after the fact.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: siddharthasahu, bcooksley, kossebau, kde-frameworks-devel, astippich, 
michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 82 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/82/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 16 Jul 2018 10:17:31 +
 Build duration:
4 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/81/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 16 Jul 2018 03:20:27 +
 Build duration:
6 hr 57 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-threadtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 325 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/325/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Jul 2018 09:41:55 +
 Build duration:
7 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31597/59590)38%
(16034/42566)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8736/9166)51%
(3857/7628)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8285/14352)50%
(4635/9281)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3891/7897)34%
(1580/4655)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 172 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/172/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 16 Jul 2018 09:41:55 +
 Build duration:
7 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31655/59591)38%
(16053/42564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8736/9166)51%
(3855/7628)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8342/14353)50%
(4656/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7897)34%
(1582/4655)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(628/1330)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3523ba575b39: [KFilePlacesModel] Support pretty 
baloosearch URLs (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14043?vs=37553=37858

REVISION DETAIL
  https://phabricator.kde.org/D14043

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham, hein
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14042: Support special URLs for finding files of a certain type

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:d02597aa9406: Support special URLs for finding files of a 
certain type (authored by broulik).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14042?vs=37552=37857

REVISION DETAIL
  https://phabricator.kde.org/D14042

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp

To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, hein, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D14095: Fix DownloadDialog window margins to meet general theme margins

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:6c4fe2cf761d: Fix DownloadDialog window margins to meet 
general theme margins (authored by kossebau).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14095?vs=37692=37853

REVISION DETAIL
  https://phabricator.kde.org/D14095

AFFECTED FILES
  src/downloaddialog.cpp

To: kossebau, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14097: Change default sort order in the download dialog to Rating

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  As an aside, I'd probably like this to end up being remembered between 
sessions, but this no different to the current state, and so outside the scope 
of this patch. As a default setting, yup, sorting by Rating definitely makes 
better sense than Newest :) (Newest would make better sense for people who look 
regularly, but Rating is definitely the best first-run thing, and that's the 
experience we're trying to improve - we can get to remembering the state later 
on, if everybody else agrees that that's something we want to do)

REPOSITORY
  R304 KNewStuff

BRANCH
  sort-by-rating-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14097

To: ngraham, apol, leinir, #knewstuff
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14095: Fix DownloadDialog window margins to meet general theme margins

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  In principle, this would really want to go via the designers, but at the same 
time it does seem that this was what was originally intended anyway. Shippit :)

REPOSITORY
  R304 KNewStuff

BRANCH
  fixdownloaddialogmarginstake2

REVISION DETAIL
  https://phabricator.kde.org/D14095

To: kossebau, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns