KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 58 - Fixed!

2018-07-17 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/58/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 18 Jul 2018 03:32:43 +
 Build duration:
9 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)20%
(435/2150)20%
(214/1096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(119/123)58%
(56/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 326 - Still Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/326/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 18 Jul 2018 03:32:29 +
 Build duration:
7 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31587/59590)38%
(16026/42566)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8736/9166)51%
(3855/7628)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8275/14352)50%
(4631/9281)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3891/7897)34%
(1580/4655)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 83 - Still Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/83/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 18 Jul 2018 03:32:29 +
 Build duration:
6 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 173 - Still Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/173/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 18 Jul 2018 03:32:29 +
 Build duration:
6 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31651/59592)38%
(16053/42564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8736/9166)51%
(3858/7628)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8340/14354)50%
(4651/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3891/7897)34%
(1580/4655)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(628/1330)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 81 - Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/81/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 18 Jul 2018 03:32:43 +
 Build duration:
2 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)19%
(406/2150)17%
(186/1096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)50%
(48/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

D14161: [KStyle] Use dialog-question for question icon

2018-07-17 Thread Henrik Fehlauer 
rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  Thanks for noticing, LGTM and restores the proper icon indeed.
  
  > This was changed in `KMessageBox` in 
9b05a12a43dbe2b31a4655052f20de0832ac7a61 
 but 
never "upstreamed" to `KStyle`
  
  Sorry, did not know about this, and neither did the reviewer notice.
  
  Should I submit Diffs (or commit directly?) where the wrong icon is still in 
use, e.g. here 
, 
here 
, 
here 

 and/or here 
?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D14161

To: broulik, dfaure, ngraham, rkflx
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14160: [KMessageBox] Call style for icon

2018-07-17 Thread Henrik Fehlauer 
rkflx added a comment.


  > Dialog icons are correct on Linux with Breeze
  
  …if you also apply D14161 . Otherwise 
LGTM.
  
  > This needs testing on Windows and Mac
  
  You could add or ping more reviewers who happen to have a dev setup on those 
platforms, perhaps #Elisa ?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14160

To: broulik, dfaure, kfunk, dhaumann
Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14193: Don't generate files in the source directory

2018-07-17 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14193

To: vkrause, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14187: Fix variable definition check

2018-07-17 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:17158129a853: Fix variable definition check (authored by 
apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14187?vs=37958=37987

REVISION DETAIL
  https://phabricator.kde.org/D14187

AFFECTED FILES
  toolchain/Android.cmake

To: apol, #frameworks, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14194: Fix the configure check for _nl_msg_cat_cntr

2018-07-17 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks! Had to workaround this earlier today.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14194

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13926: Avoid warnings for PolkitQt5-1 headers

2018-07-17 Thread Friedrich W. H. Kossebau 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R283:9fe09a1dff85: Avoid warnings for PolkitQt5-1 headers 
(authored by kossebau).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13926?vs=37275=37985

REVISION DETAIL
  https://phabricator.kde.org/D13926

AFFECTED FILES
  src/ConfigureChecks.cmake

To: kossebau, shumski
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

2018-07-17 Thread Frederik Gladhorn 
gladhorn accepted this revision.
gladhorn added a comment.
This revision is now accepted and ready to land.


  I'd say make the casing consistent, otherwise it's a clear improvement in my 
opinion.

INLINE COMMENTS

> containment.cpp:127
>  if (closeApplet) {
> -closeApplet->setText(i18nc("%1 is the name of the applet", "Remove 
> this %1", title()));
> +closeApplet->setText(i18nc("%1 is the name of the applet", "Remove 
> this %1 widget", title()));
>  }

The translation help says applet, is widget or applet the better word? But 
actually the "add new" dialog in plasma says widget, so I'm for that for 
consistency reasons.

> applet_p.cpp:124
>  if (closeApplet) {
> -closeApplet->setText(i18nc("%1 is the name of the applet", "Remove 
> this %1", q->title()));
> +closeApplet->setText(i18nc("%1 is the name of the applet", "Remove 
> this %1 Widget", q->title()));
>  }

This (Widget) is upper case (above it's lower case, which I prefer a tiny bit).

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-this-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14118

To: ngraham, #plasma, #vdg, gladhorn
Cc: gladhorn, kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

2018-07-17 Thread Nathaniel Graham 
ngraham added a comment.


  Ping? Is the proposed wording good enough, or should we maybe instead just 
remove the word "this" and make it use "Remove ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14118

To: ngraham, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14187: Fix variable definition check

2018-07-17 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14187

To: apol, #frameworks, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14194: Fix the configure check for _nl_msg_cat_cntr

2018-07-17 Thread Volker Krause 
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  We need to pass -Wl,--no-undefined to the linker for this to fail when the
  symbol isn't present, otherwise this always passes.
  
  This fixes the build on Android, where this symbol doesn't exist.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14194

AFFECTED FILES
  cmake/FindLibIntl.cmake

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14193: Don't generate files in the source directory

2018-07-17 Thread Volker Krause 
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14193

AFFECTED FILES
  .gitignore
  CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

2018-07-17 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  cursorHints

REVISION DETAIL
  https://phabricator.kde.org/D14175

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

2018-07-17 Thread Roman Gilg 
romangg marked 4 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14175

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

2018-07-17 Thread Roman Gilg 
romangg updated this revision to Diff 37971.
romangg added a comment.


  - Add hint getter
  - Add since keyword

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14175?vs=37938=37971

BRANCH
  cursorHints

REVISION DETAIL
  https://phabricator.kde.org/D14175

AFFECTED FILES
  autotests/client/test_pointer_constraints.cpp
  src/server/pointerconstraints_interface.cpp
  src/server/pointerconstraints_interface.h
  src/server/pointerconstraints_interface_p.h
  src/server/pointerconstraints_interface_v1.cpp

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 57 - Still Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/57/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 17 Jul 2018 16:10:02 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)20%
(429/2150)19%
(209/1096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)53%
(51/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

D14052: Add bluetooth plugin

2018-07-17 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R495:0c9bf25e18a8: Add bluetooth plugin (authored by 
nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14052?vs=37583=37969

REVISION DETAIL
  https://phabricator.kde.org/D14052

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/bluetooth/CMakeLists.txt
  src/plugins/bluetooth/Messages.sh
  src/plugins/bluetooth/bluetoothplugin.cpp
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/bluetooth/bluetoothplugin_config.qml

To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14052: Add bluetooth plugin

2018-07-17 Thread Aleix Pol Gonzalez 
apol added a comment.


  Yes, I can reproduce too. `qmlplugindump-qt5 org.kde.bluezqt 1.0` returns 2 
for some reason. Will have to investigate.
  
  Land this for now if you want.

REPOSITORY
  R495 Purpose Library

BRANCH
  bluetooth

REVISION DETAIL
  https://phabricator.kde.org/D14052

To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14187: Fix variable definition check

2018-07-17 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  We'd check if the variable's value is defined, which is wrong and prevented us
  from properly initialising using these deprecated variables.
  It would also ignore the value we're passing to the actually right variable 
when
  using it.

TEST PLAN
  Built kstars which needs -DCMAKE_ANDROID_API=24

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14187

AFFECTED FILES
  toolchain/Android.cmake

To: apol, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-17 Thread Mladen Milinkovic 
maxrd2 added a comment.


  Events from the window system seem to be handled after normal events.
  
http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp#n70
  Is there a way to send the event so qt processes it as window system event? 
Have tried looking through code and documentation, but everything that deals 
with window system events is private.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

2018-07-17 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0351ea74b24e: [Containment] Dont load containment 
actions with plasma/containment_actions… (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14045?vs=37558=37953

REVISION DETAIL
  https://phabricator.kde.org/D14045

AFFECTED FILES
  src/plasma/containment.cpp

To: broulik, #plasma, mart, sitter, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-17 Thread Mladen Milinkovic 
maxrd2 added a comment.


  @dfaure great.. thanks

INLINE COMMENTS

> anthonyfieroni wrote in kmainwindow_unittest.cpp:267
> mw->setAttribute(Qt::WA_DeleteOnClose);
> Then post event close or deleteLater should work

KMainWindowPrivate::init() which is called from constructor already does 
setAttribute(Qt::WA_DeleteOnClose), so that doesnt change anything :-/

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 186 - Still Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/186/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 17 Jul 2018 13:53:40 +
 Build duration:
5 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)31%
(39/126)31%
(39/126)27%
(3489/13084)19%
(1789/9422)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests79%
(11/14)79%
(11/14)53%
(588/1113)29%
(310/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core19%
(3/16)19%
(3/16)11%
(252/2208)7%
(94/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma55%
(12/22)55%
(12/22)41%
(1410/3477)30%
(784/2623)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(661/1540)30%
(299/1001)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)28%
(547/1973)17%
(297/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-17 Thread Mladen Milinkovic 
maxrd2 updated this revision to Diff 37950.
maxrd2 added a comment.


  Rebased to master

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13808?vs=37211=37950

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

AFFECTED FILES
  autotests/kmainwindow_unittest.cpp
  autotests/kmainwindow_unittest.h

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, arojas, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 36 - Still Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/36/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 17 Jul 2018 13:53:40 +
 Build duration:
2 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D14009: [Plasma PluginLoader] Cache plugins during startup

2018-07-17 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in pluginloader.cpp:195
> Seems the wrong approach we know the ID, there's no point iterating in the 
> first place.
> 
> https://api.kde.org/frameworks/kcoreaddons/html/classKPluginLoader.html#a3a69c4f1826926a2145f14770b8b5010

We know the ID but not the file name of the library, so `findPlugin` won't work.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14009

To: broulik, #plasma, davidedmundson, mart
Cc: ngraham, zzag, kde-frameworks-devel, michaelh, bruns

D14009: [Plasma PluginLoader] Cache plugins during startup

2018-07-17 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> pluginloader.cpp:195
>  // COMPAT CODE for applets installed into the toplevel plugins dir 
> by mistake.
> -plugins = KPluginLoader::findPlugins(QString(), filter);
>  }

Seems the wrong approach we know the ID, there's no point iterating in the 
first place.

https://api.kde.org/frameworks/kcoreaddons/html/classKPluginLoader.html#a3a69c4f1826926a2145f14770b8b5010

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14009

To: broulik, #plasma, davidedmundson, mart
Cc: ngraham, zzag, kde-frameworks-devel, michaelh, bruns

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

2018-07-17 Thread Marco Martin 
mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14045

To: broulik, #plasma, mart, sitter, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14009: [Plasma PluginLoader] Cache plugins during startup

2018-07-17 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14009

To: broulik, #plasma, davidedmundson, mart
Cc: ngraham, zzag, kde-frameworks-devel, michaelh, bruns

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

2018-07-17 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14045

To: broulik, #plasma, mart, sitter, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14183: Fix selection and seat auto tests

2018-07-17 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  fixAutotests

REVISION DETAIL
  https://phabricator.kde.org/D14183

To: romangg, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14184: Reduce unnecessary long wait times on failing signal spies

2018-07-17 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  autotestsWaits

REVISION DETAIL
  https://phabricator.kde.org/D14184

To: romangg, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

2018-07-17 Thread Eike Hein 
hein added a comment.


  I have a problem: When I restart plasmashell, I don't get any desktops again. 
I think the code may not be re-sending the data when the client goes away and 
comes a second time.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, 
ngraham, bruns

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 13 - Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/13/
 Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 17 Jul 2018 12:41:02 +
 Build duration:
6 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.ktextwidgets-krichtextedittest

D14184: Reduce unnecessary long wait times on failing signal spies

2018-07-17 Thread Roman Gilg 
romangg created this revision.
romangg added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Several signal spies, which were supposed to fail, were waiting for the
  default 5 seconds, which is most often unnecessary long.
  
  This patch sets a time limit of 500ms in suitable cases. Reduces for me
  the total test time by 40%.

TEST PLAN
  Before (with fixed seat and selection tests):
  98% tests passed, 1 tests failed out of 45
  
  Total Test time (real) = 173.31 sec
  
  The following tests FAILED:
  
19 - kwayland-testWindowmanagement (Failed)
  
  After:
  98% tests passed, 1 tests failed out of 45
  
  Total Test time (real) = 102.12 sec
  
  The following tests FAILED:
  
19 - kwayland-testWindowmanagement (Failed)

REPOSITORY
  R127 KWayland

BRANCH
  autotestsWaits

REVISION DETAIL
  https://phabricator.kde.org/D14184

AFFECTED FILES
  autotests/client/test_drag_drop.cpp
  autotests/client/test_pointer_constraints.cpp
  autotests/client/test_selection.cpp
  autotests/client/test_text_input.cpp
  autotests/client/test_wayland_seat.cpp
  autotests/client/test_wayland_surface.cpp

To: romangg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14183: Fix selection and seat auto tests

2018-07-17 Thread Roman Gilg 
romangg edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14183

To: romangg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14183: Fix selection and seat auto tests

2018-07-17 Thread Roman Gilg 
romangg created this revision.
romangg added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The selection test is broken since 5e195c2a67ce 
, 
because a frame event now
  also follows a relative pointer motion.
  
  The seat test is broken since 0e580ae9bdc5 
, 
because clearing a selection,
  which never has been set, is a noop now.

REPOSITORY
  R127 KWayland

BRANCH
  fixAutotests

REVISION DETAIL
  https://phabricator.kde.org/D14183

AFFECTED FILES
  autotests/client/test_selection.cpp
  autotests/client/test_wayland_seat.cpp

To: romangg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

2018-07-17 Thread Roman Gilg 
romangg added inline comments.

INLINE COMMENTS

> davidedmundson wrote in pointerconstraints_interface.h:126
> do we not want a getter method?
> 
> One of kwayland's main roles is to be a property cache

The hint is used by the compositor after unlock again. This unlock can also 
happen on destruction of the LockedPointerInterface. So one need to to connect 
to a signal announcing this and then set the pointer position.

Resource has a `aboutToBeUnbound` signal. Maybe use this?

> davidedmundson wrote in pointerconstraints_interface_v1.cpp:175
> Only non-negative x and y values are allowed
> 
> is it worth enforcing that with a check here?

I wanted to allow negative values, such that a client can decide to opt-out of 
hinting again. Sadly the specs does not say anything about invalid values. But 
my assumption is that a client should only be allowed to shift the cursor in 
the dimensions of its surface.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14175

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14137: CSS: update syntax and fix some errors

2018-07-17 Thread Dominik Haumann 
dhaumann added a comment.


  Thanks for pushing.
  
  Could you have a quick look at https://build.kde.org and search for 
"syntax-highlighting"? It seems the unit tests do not pass since this change, 
probably a minor issue:
  
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/57/

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14137

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14175: Support cursor hints on locked pointer

2018-07-17 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test_pointer_constraints.cpp:258
> +QVERIFY(hintChangedSpy.wait());
> +
>  // and unlock again

We should check the value of hintChangedSpy.first() to properly test it.

Also, use something better than 1,0 to check y is set correctly

> pointerconstraints_interface.h:126
>  QRegion region() const;
>  
>  /**

do we not want a getter method?

One of kwayland's main roles is to be a property cache

> pointerconstraints_interface.h:165
> + * should be ignored by the compositor.
> + *
> + **/

@since

> pointerconstraints_interface_v1.cpp:175
> +auto p = cast(resource);
> +p->pendingHint = QPointF(wl_fixed_to_double(surface_x), 
> wl_fixed_to_double(surface_y));
> +p->hintIsSet = true;

Only non-negative x and y values are allowed

is it worth enforcing that with a check here?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14175

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

2018-07-17 Thread Roman Gilg 
romangg updated this revision to Diff 37938.
romangg added a comment.


  - Add autotest

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14175?vs=37917=37938

BRANCH
  cursorHints

REVISION DETAIL
  https://phabricator.kde.org/D14175

AFFECTED FILES
  autotests/client/test_pointer_constraints.cpp
  src/server/pointerconstraints_interface.cpp
  src/server/pointerconstraints_interface.h
  src/server/pointerconstraints_interface_p.h
  src/server/pointerconstraints_interface_v1.cpp

To: romangg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13488: Make XDGShellV5 co-compilable with XDGWMBase

2018-07-17 Thread David Edmundson 
davidedmundson added a comment.


  It was an exported symbol, but the relevant header was never exposed

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13488

To: davidedmundson, #plasma, romangg
Cc: rikmills, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/19/
 Project:
Frameworks kxmlgui kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 17 Jul 2018 07:46:38 +
 Build duration:
2 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.kxmlgui_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)46%
(35/76)46%
(35/76)40%
(4044/10046)32%
(2013/6202)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)99%
(1343/1360)49%
(432/886)src53%
(28/53)53%
(28/53)35%
(2701/7767)30%
(1581/5191)src.ksendbugmail0%
(0/4)0%
(0/4)0%
(0/274)0%
(0/67)tests0%
(0/10)0%
(0/10)0%
(0/585)0%
(0/46)tests.krichtexteditor0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/12)

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

2018-07-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/35/
 Project:
Frameworks kxmlgui kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 17 Jul 2018 07:46:38 +
 Build duration:
2 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.kxmlgui_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)46%
(35/76)46%
(35/76)40%
(4046/10046)32%
(2014/6202)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)99%
(1343/1360)49%
(432/886)src53%
(28/53)53%
(28/53)35%
(2703/7767)30%
(1582/5191)src.ksendbugmail0%
(0/4)0%
(0/4)0%
(0/274)0%
(0/67)tests0%
(0/10)0%
(0/10)0%
(0/585)0%
(0/46)tests.krichtexteditor0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/12)

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-17 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I just pushed the fix 
https://commits.kde.org/kxmlgui/d35a88289513c0420863b80aa6c1cb7d2c6e978f
  Please continue working on the unittest here ;)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, arojas, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

2018-07-17 Thread Ben Cooksley 
bcooksley added a comment.


  No problem @siddharthasahu.
  For the issue you're having with bindings i'd suggest raising a separate 
thread about that on kde-frameworks-devel as others might have missed it buried 
in this review.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: siddharthasahu, bcooksley, kossebau, kde-frameworks-devel, astippich, 
michaelh, ngraham, bruns

D13488: Make XDGShellV5 co-compilable with XDGWMBase

2018-07-17 Thread Rik Mills 
rikmills added a comment.


  In libkf5waylandclient5 and libkf5waylandserver5 I see the previously emitted 
symbol xdg_shell_interface@Base is now reported as MISSING.
  
  Can you confirm this is private and/or not an ABI break?
  
  Build symbols output: https://paste.kde.org/pfpkps1mb#line-109

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13488

To: davidedmundson, #plasma, romangg
Cc: rikmills, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-17 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> maxrd2 wrote in kmainwindow_unittest.cpp:267
> Retried with all of these... none of them causes the failure, only closing 
> the window manually cause it
> 
>   QApplication::postEvent(mw, new QDeferredDeleteEvent); // qpa/window 
> manager sends this one.. with spontaneous flag tho
>   QApplication::postEvent(mw, new QCloseEvent); // this one does absolutely 
> nothing
>   QTimer::singleShot(1000, [&](){ QApplication::sendEvent(mw, new 
> QDeferredDeleteEvent); });
>   mw->close();
>   QTimer::singleShot(1000, [&](){ mw->close(); });
>   mw->deleteLater();

mw->setAttribute(Qt::WA_DeleteOnClose);
Then post event close or deleteLater should work

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, arojas, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns