KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 418 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/418/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 05 Oct 2018 03:54:06 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31516/6)36%
(15958/43880)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8608/9499)42%
(3789/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8327/14346)50%
(4651/9275)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3847/7922)33%
(1531/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1022)38%
(316/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1780/4318)36%
(1309/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%

D15935: Don't show an emblem for mounted disks, only unmounted disks

[Nathaniel Graham]

ngraham retitled this revision from "Don't show a emblem for mounted disks, 
only unmounted disks" to "Don't show an emblem for mounted disks, only 
unmounted disks".

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 263 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/263/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 05 Oct 2018 03:54:06 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31572/60001)36%
(15980/43878)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)42%
(3788/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8385/14347)50%
(4676/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3848/7922)33%
(1532/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1780/4318)36%
(1309/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/75/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 05 Oct 2018 03:54:18 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(439/3554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 34 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/34/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 05 Oct 2018 03:54:06 +
 Build duration:
13 min and counting

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 116 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/116/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 05 Oct 2018 03:54:18 +
 Build duration:
6 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(439/3554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

D15932: [UDisks2] Power down drive on remove if supported

[Stefan Brüns]

bruns updated this revision to Diff 42905.
bruns added a comment.


  - do not create additional connections on the system bus
  - avoid disconnecting optical drives, no need to power down

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15932?vs=42824=42905

BRANCH
  udisks2_power_down

REVISION DETAIL
  https://phabricator.kde.org/D15932

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: bruns, #frameworks, ngraham
Cc: broulik, kde-frameworks-devel, ngraham, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/59/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 05 Oct 2018 01:48:17 +
 Build duration:
5 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6331/8428)43%
(10156/23441)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2700/2776)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 115 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/115/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 05 Oct 2018 01:48:17 +
 Build duration:
2 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8428)43%
(10166/23445)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2702/2776)49%
(5810/11901)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D15421: [server] Add surface data proxy mechanism

[David Edmundson]

davidedmundson added a comment.


  Seems ok, I need to re-read it in the context of the other patches that I'm 
getting through.

INLINE COMMENTS

> surface_interface.h:268
> + * Setting a data proxy is only allowed when the client owning this 
> surface
> + * has not creted a data device itself.
> + * @since 5.XX

creted -> created.

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 42903.
kossebau added a comment.


  Improve rendering in scaled mode

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=41828=42903

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/utils/ktexteditor.cpp
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau, #kate, #kdevelop
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

D15023: [server] Add selectionChanged signal

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  0selectionChangeXwl

REVISION DETAIL
  https://phabricator.kde.org/D15023

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 262 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/262/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 04 Oct 2018 20:10:31 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31583/60003)36%
(15986/43878)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8605/9499)42%
(3792/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8393/14349)50%
(4674/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3863/7923)33%
(1537/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4317)35%
(1306/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 417 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/417/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 04 Oct 2018 20:10:31 +
 Build duration:
7 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)52%
(31456/5)36%
(15927/43880)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)42%
(3790/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8296/14346)50%
(4636/9275)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3846/7922)33%
(1530/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4317)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
  

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 33 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/33/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 04 Oct 2018 20:10:31 +
 Build duration:
3.8 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeRunning on Windows Builder 3 in C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] }[Pipeline] // stage[Pipeline] }java.nio.file.FileSystemException: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests: The process cannot access the file because it is being used by another process.	at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)	at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)	at java.nio.file.Files.deleteIfExists(Unknown Source)	at hudson.Util.tryOnceDeleteFile(Util.java:316)	at hudson.Util.deleteFile(Util.java:272)Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:57673		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at hudson.FilePath.act(FilePath.java:1070)		at hudson.FilePath.act(FilePath.java:1059)		at hudson.FilePath.deleteRecursive(FilePath.java:1266)		at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:77)		at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:69)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:50)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:47)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		at java.util.concurrent.FutureTask.run(FutureTask.java:266)		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)		at java.lang.Thread.run(Thread.java:748)Caused: java.io.IOException: Unable to delete 'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.	at hudson.Util.deleteFile(Util.java:277)	at hudson.FilePath.deleteRecursive(FilePath.java:1303)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1312)	at hudson.FilePath.deleteRecursive(FilePath.java:1294)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1312)	at hudson.FilePath.deleteRecursive(FilePath.java:1294)	at hudson.FilePath.access$1600(FilePath.java:211)	at hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1272)	at hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1268)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3084)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)	at java.lang.Thread.run(Unknown Source)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D15952: [KFilePlacesView] Change icon for the 'Edit' context menu entry in Places panel

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15952

To: thsurrel, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15952: [KFilePlacesView] Change icon for the 'Edit' context menu entry in Places panel

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arc_editicon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15952

To: thsurrel, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15952: [KFilePlacesView] Change icon for the 'Edit' context menu entry in Places panel

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  Twin of https://phabricator.kde.org/D15938 for dolphin

TEST PLAN
  In Kate, open the Open File dialog and right-click on a Place in left panel.

REPOSITORY
  R241 KIO

BRANCH
  arc_editicon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15952

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 416 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/416/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 04 Oct 2018 19:25:06 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)52%
(31449/59998)36%
(15926/43880)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)42%
(3790/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8289/14345)50%
(4638/9275)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3846/7922)33%
(1530/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4317)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 261 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/261/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 04 Oct 2018 19:25:06 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31509/5)36%
(15945/43878)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8601/9499)42%
(3779/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8356/14346)50%
(4665/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3846/7922)33%
(1530/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4317)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%

D15939: Perform checks for unindexed files and stale index entries on startup

[Igor Poboiko]

poboiko updated this revision to Diff 42886.
poboiko added a comment.


  Fixed typos

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15939?vs=42848=42886

REVISION DETAIL
  https://phabricator.kde.org/D15939

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/indexerstate.h
  src/file/mainhub.cpp

To: poboiko, #baloo, #frameworks, vhanda
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15927: Use specified Perl interpreter instead of relying on PATH

[Luigi Toscano]

ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Uhm, I guess than this can go in then.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15927

To: zrax, ltoscano
Cc: ltoscano, vonreth, kde-doc-english, kde-frameworks-devel, michaelh, 
ngraham, bruns, skadinna

D15931: [Places panel] use more appropriate network icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:31c07fa8d6c7: [Places panel] use more appropriate network 
icon (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15931?vs=42823=42885

REVISION DETAIL
  https://phabricator.kde.org/D15931

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #vdg, nicolasfella, andreaska
Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

[Andreas Kainz]

andreaska accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  better-network-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg, nicolasfella, andreaska
Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

[Nicolas Fella]

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  better-network-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg, nicolasfella
Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R269:5f12404807cc: Implement Media and MediaEndpoint API 
(authored by mweichselbaumer, committed by drosca).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15745?vs=42877=42878#toc

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15745?vs=42877=42878

REVISION DETAIL
  https://phabricator.kde.org/D15745

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/fakebluez.cpp
  autotests/fakebluez/fakebluez.h
  autotests/fakebluez/media.cpp
  autotests/fakebluez/media.h
  autotests/mediatest.cpp
  autotests/mediatest.h
  src/CMakeLists.txt
  src/a2dp-codecs.c
  src/a2dp-codecs.h
  src/interfaces/org.bluez.Media1.xml
  src/interfaces/org.bluez.MediaEndpoint1.xml
  src/manager.cpp
  src/manager.h
  src/manager_p.cpp
  src/manager_p.h
  src/media.cpp
  src/media.h
  src/media_p.h
  src/mediaendpoint.cpp
  src/mediaendpoint.h
  src/mediaendpoint_p.cpp
  src/mediaendpoint_p.h
  src/mediaendpointadaptor.cpp
  src/mediaendpointadaptor.h
  src/pendingcall.h
  src/request.cpp
  src/request.h
  src/services.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[Manuel Weichselbaumer]

mweichselbaumer added a comment.


  In D15745#336711 , @drosca wrote:
  
  > Thanks.
  >  I'll need your full name + e-mail if you don't have dev account to push it.
  
  
  You're welcome. It's been a pleasure to contribute to this lib.
  Manuel Weichselbaumer, mince...@web.de

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[David Rosca]

drosca added a comment.


  Thanks.
  I'll need your full name + e-mail if you don't have dev account to push it.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[Manuel Weichselbaumer]

mweichselbaumer updated this revision to Diff 42877.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15745?vs=42861=42877

REVISION DETAIL
  https://phabricator.kde.org/D15745

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/fakebluez.cpp
  autotests/fakebluez/fakebluez.h
  autotests/fakebluez/media.cpp
  autotests/fakebluez/media.h
  autotests/mediatest.cpp
  autotests/mediatest.h
  src/CMakeLists.txt
  src/a2dp-codecs.c
  src/a2dp-codecs.h
  src/interfaces/org.bluez.Media1.xml
  src/interfaces/org.bluez.MediaEndpoint1.xml
  src/manager.cpp
  src/manager.h
  src/manager_p.cpp
  src/manager_p.h
  src/media.cpp
  src/media.h
  src/media_p.h
  src/mediaendpoint.cpp
  src/mediaendpoint.h
  src/mediaendpoint_p.cpp
  src/mediaendpoint_p.h
  src/mediaendpointadaptor.cpp
  src/mediaendpointadaptor.h
  src/pendingcall.h
  src/request.cpp
  src/request.h
  src/services.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15935: Don't show a emblem for mounted disks, only unmounted disks

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15935: Don't show a emblem for mounted disks, only unmounted disks

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15935: Don't show a emblem for mounted disks, only unmounted disks

[Nathaniel Graham]

ngraham added a comment.


  Sure!
  
  External hard drive:
  F6303952: Device notifier - external hard drive.png 

  
  iPhone
  F6303953: Device notifier - iPhone.png 
  
  (The duplicate entries are caused by 
https://bugs.kde.org/show_bug.cgi?id=383255

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[David Rosca]

drosca added a comment.


  In D15745#336662 , 
@mweichselbaumer wrote:
  
  > In D15745#336644 , @drosca wrote:
  >
  > > Remove NoInputNoOutputAgent and it's good to go.
  >
  >
  > Agree. Is it ok to move it to mediaendpointconnector?
  
  
  Sure

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[Manuel Weichselbaumer]

mweichselbaumer added a comment.


  In D15745#336644 , @drosca wrote:
  
  > Remove NoInputNoOutputAgent and it's good to go.
  
  
  Agree. Is it ok to move it to mediaendpointconnector?

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 260 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/260/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 04 Oct 2018 16:49:55 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/397)66%
(262/397)53%
(31732/60015)37%
(16053/43878)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)42%
(3782/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8345/14346)50%
(4658/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3847/7922)33%
(1531/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1784/4317)36%
(1312/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 415 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/415/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 04 Oct 2018 16:49:55 +
 Build duration:
6 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)52%
(31457/5)36%
(15937/43880)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)91%
(8607/9499)42%
(3792/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8297/14346)50%
(4644/9275)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3846/7922)33%
(1530/4667)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4317)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
  

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15945

To: thsurrel, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15745: Implement Media and MediaEndpoint API

[David Rosca]

drosca accepted this revision.
drosca added a comment.
This revision is now accepted and ready to land.


  Remove NoInputNoOutputAgent and it's good to go.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15941: Fix invalid char constant

[Nathaniel Graham]

ngraham added a comment.


  Whoops! Thanks for fixing this.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15941

To: poboiko, #baloo, #frameworks, broulik
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

[Nathaniel Graham]

ngraham added a comment.


  You should apply for a developer account!
  
  https://community.kde.org/Infrastructure/Get_a_Developer_Account
  
  I'll land this one.

REPOSITORY
  R241 KIO

BRANCH
  arc_rootdetails (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15945

To: thsurrel, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15745: Implement Media and MediaEndpoint API

[David Rosca]

drosca added a comment.


  In D15745#336615 , 
@mweichselbaumer wrote:
  
  > In D15745#336593 , @drosca wrote:
  >
  > > Alright, last thing:
  > >
  > > Why NoInputNoOutputAgent? That should be implemented by the application, 
and not be part of library. In almost all cases you actually want to inform 
user that something is trying to connect anyway.
  >
  >
  > Yes, i also thought this should be application specific. However, i could 
not imagine another use case of a NoInputNoOutputAgent, except from doing auto 
connecting to a limited set of UUIDs. So, i thought it is generic enough to be 
part of the library.
  
  
  Well, in any case it has nothing to do being included in this commit. So 
please take it out, and create a separate revision if you want and we can 
discuss it there.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D7446: [Places panel] Add a Recently Used item by default

[Nathaniel Graham]

ngraham updated this revision to Diff 42865.
ngraham added a comment.


  Only create "Recently Used" if the protocol is available because `kio-extras` 
is installed

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=42277=42865

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp

D15947: Start drawing emblems in the bottom-right corner

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15947

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[Manuel Weichselbaumer]

mweichselbaumer added a comment.


  In D15745#336593 , @drosca wrote:
  
  > Alright, last thing:
  >
  > Why NoInputNoOutputAgent? That should be implemented by the application, 
and not be part of library. In almost all cases you actually want to inform 
user that something is trying to connect anyway.
  
  
  Yes, i also thought this should be application specific. However, i could not 
imagine another use case of a NoInputNoOutputAgent, except from doing auto 
connecting to a limited set of UUIDs. So, i thought it is generic enough to be 
part of the library.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15947: Start drawing emblems in the bottom-right corner

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  While writing a HIG page about emblems (D15897 
), we noticed an inconsistency in where 
they're currently placed: All of our icons that have built-in emblems as well 
as all 3rd-party system tray icons put their emblems in the bottom-right 
corner. But when `KIconLoader` it used to add emblems to a regular icon, it 
puts the first emblem in the bottom-left corner.
  
  This arbitrary inconsistency makes it impossible to write a clear rule in the 
HIG about emblem placement. Changing hundreds of icons and 3rd-party apps to 
move all their emblems to the bottom-right corner doesn't seem likely. 
Therefore, this patch adjusts 'KIconLoader` to position the first emblem in the 
bottom-right corner to match existing icons and 3rd-party apps.

TEST PLAN
  Symlink emblem:
  
  Shared folder emblem:
  
  Emblem on a disk in the Places panel:
  
  Folders with multiple emblems:

REPOSITORY
  R302 KIconThemes

BRANCH
  emblems-start-in-bottom-right (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15947

AFFECTED FILES
  src/kiconloader.cpp

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15943: [balooctl] Monitor also for index changes

[Stefan Brüns]

bruns added a comment.


  Looks sane in general. Can you extend the summary a bit, e.g. "Connect to the 
scheduler DBus interface to "? Thx

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D15745: Implement Media and MediaEndpoint API

[David Rosca]

drosca added a comment.


  Alright, last thing:
  
  Why NoInputNoOutputAgent? That should be implemented by the application, and 
not be part of library. In almost all cases you actually want to inform user 
that something is trying to connect anyway.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[Manuel Weichselbaumer]

mweichselbaumer updated this revision to Diff 42861.
mweichselbaumer added a comment.


  Fixed style issues and smart pointer construction

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15745?vs=42813=42861

REVISION DETAIL
  https://phabricator.kde.org/D15745

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/fakebluez.cpp
  autotests/fakebluez/fakebluez.h
  autotests/fakebluez/media.cpp
  autotests/fakebluez/media.h
  autotests/mediatest.cpp
  autotests/mediatest.h
  autotests/noinputnooutputagenttest.cpp
  autotests/noinputnooutputagenttest.h
  src/CMakeLists.txt
  src/a2dp-codecs.c
  src/a2dp-codecs.h
  src/interfaces/org.bluez.Media1.xml
  src/interfaces/org.bluez.MediaEndpoint1.xml
  src/manager.cpp
  src/manager.h
  src/manager_p.cpp
  src/manager_p.h
  src/media.cpp
  src/media.h
  src/media_p.h
  src/mediaendpoint.cpp
  src/mediaendpoint.h
  src/mediaendpoint_p.cpp
  src/mediaendpoint_p.h
  src/mediaendpointadaptor.cpp
  src/mediaendpointadaptor.h
  src/noinputnooutputagent.cpp
  src/noinputnooutputagent.h
  src/pendingcall.h
  src/request.cpp
  src/request.h
  src/services.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[Manuel Weichselbaumer]

mweichselbaumer marked 3 inline comments as done and an inline comment as not 
done.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15927: Use specified Perl interpreter instead of relying on PATH

[Hannah von Reth]

vonreth added a comment.


  ah sorry I took this for a config file, everything is fine then.
  
  Note to myself: Don't review code on the phone

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15927

To: zrax
Cc: vonreth, kde-doc-english, kde-frameworks-devel, michaelh, ngraham, bruns, 
skadinna

D8532: [WIP] Restrict file extractor with Seccomp

[Fabian Vogt]

fvogt added a comment.


  AFAICT this won't actually protect much - the open DBus socket is enough to 
execute arbitrary programs.
  
  The best design would be (IMO, not sure how well the current architecture 
fits) to have a fully sandboxed executable which can only communicate with 
baloo over a single socket.
  Over that socket it receives a (read-only) file descriptor for the to be 
dissected file and then sends the result to baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D8532

To: davidk, apol, ossi, #frameworks, smithjd, bruns
Cc: fvogt, mgallien, kde-frameworks-devel, michaelh, #baloo, detlefe, ngraham, 
nicolasfella, ashaposhnikov, astippich, spoorun, bruns, abrahams

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

[Thomas Surrel]

thsurrel added a comment.


  Someone will have to land this, I don't have a developer account, thanks !

REPOSITORY
  R241 KIO

BRANCH
  arc_rootdetails (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15945

To: thsurrel, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks everyone who so far looked at this, especially @dhaumann for detailed 
comments.
  
  I am tempted to interpret the lack of further comments, especially the lack 
of principal objections as an implicit +1 on this patch as it is now :)
  
  While I still am slightly unsure about parts of the API, given no better 
ideas there I would leave it now to real life experience gathering. And then 
polishing things as found needed in any next ABI/API version.
  
  To keep things moving, I will go and merge this patch, once KF 5.51 has been 
tagged the upcoming WE, so there are 4 weeks to give the new API and also the 
default implementation some testing and considerations before getting published 
with 5.52. Of course unless there are objections raised now.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau, #kate, #kdevelop
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense, thanks!

REPOSITORY
  R241 KIO

BRANCH
  arc_rootdetails (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15945

To: thsurrel, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

[Thomas Surrel]

thsurrel added a comment.


  F6303519: before.png 
  
  F6303521: after.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15945

To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

[Thomas Surrel]

thsurrel created this revision.
thsurrel added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  Any folder laying in the / partition was excluded to have its 'Mounted on'
  and 'Mounted from' displayed in a KPropertiesDialog.

TEST PLAN
  In dolphin, navigate to Root, right-click on 'etc' to open its properties.
  Mounted on and Mounted from should be displayed.

REPOSITORY
  R241 KIO

BRANCH
  arc_rootdetails (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15945

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7446: [Places panel] Add a Recently Used item by default

[Nathaniel Graham]

ngraham added a comment.


  In D7446#336245 , @dfaure wrote:
  
  > I guess the implicit part of the question is "what if kio-extras isn't 
installed ?".
  >  I assume it will lead to a broken item.
  >
  > So this should probably use a check like 
`KProtocolInfo::isKnownProtocol("recentdocuments")`
  
  
  Ah, I see now. Sure, I can do that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp

D15944: [balooctl] Fix "index" command with already indexed, but moved file

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  If I move a file (while baloo was not running) and perform `balooctl index` 
on new file
  (so that document Id is not changed), it won't update the path of the file, 
keeping the
  invalid entry in index.
  Explicitly tell Baloo that we want to update everything concerning this file.

TEST PLAN
  1. `echo "hello world" >~/file1`
  2. `balooctl stop`
  3. `mv ~/file1 ~/file2`
  4. `balooctl start && balooctl index ~/file2`
  5. `balooshow file2` and `balooshow -x `
  
  The first command should show the right path, and the second command 
shouldn't complain about bug in Baloo (invalid index entry)

REPOSITORY
  R293 Baloo

BRANCH
  fix-index-renamed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15944

AFFECTED FILES
  src/tools/balooctl/indexer.cpp

To: poboiko, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15943: [balooctl] Monitor also for index changes

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Frameworks, Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

TEST PLAN
  1. Run `balooctl monitor`
  2. In different terminal session, run `balooctl stop && balooctl start`
  3. Monitor now says what exactly baloo is doing right now

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp
  src/tools/balooctl/monitorcommand.h

To: poboiko, #frameworks, #baloo
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15941: Fix invalid char constant

[Igor Poboiko]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:ade5188979c4: Fix invalid char constant (authored by 
poboiko).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15941?vs=42853=42854

REVISION DETAIL
  https://phabricator.kde.org/D15941

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: poboiko, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15941: Fix invalid char constant

[Igor Poboiko]

poboiko updated this revision to Diff 42853.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15941?vs=42851=42853

REVISION DETAIL
  https://phabricator.kde.org/D15941

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: poboiko, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15941: Fix invalid char constant

[Igor Poboiko]

poboiko added a comment.


  In D15941#336481 , @broulik wrote:
  
  > I think you updated the wrong diff here
  
  
  True. Sorry, messed up with arc. Will revert it.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15941

To: poboiko, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15941: Fix invalid char constant

[Kai Uwe Broulik]

broulik added a comment.


  I think you updated the wrong diff here

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15941

To: poboiko, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15941: Fix invalid char constant

[Igor Poboiko]

poboiko updated this revision to Diff 42851.
poboiko added a comment.


  [balooctl] Monitor also for state changes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15941?vs=42850=42851

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15941

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp
  src/tools/balooctl/monitorcommand.cpp
  src/tools/balooctl/monitorcommand.h

To: poboiko, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15941: Fix invalid char constant

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15941

To: poboiko, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15941: Fix invalid char constant

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  I assume that was a typo. Compiler pointed out that as a warning.

TEST PLAN
  Compiler is happy now.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15941

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: poboiko, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15939: Perform checks for unindexed files and stale index entries on startup

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks, vhanda.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  Right now, if a file was moved / removed while baloo_file was not running
  (a common use-case for those who have dualboot), there is no way baloo will
  become aware of such change (apart from running `balooctl check` by hand).
  
  There will be stale (if a file was removed) or invalid (pointing to 
non-existing file,
  if a file was moved) index entries, they will pop up if user performs search, 
which is
  frustrating. I suggest performing those checks on `baloo_file` startup.

TEST PLAN
  1. `balooctl stop && echo "hello world" > ~/new-file && balooctl start`
  2. after some time: `balooshow ~/new-file`, and see if it's indexed

REPOSITORY
  R293 Baloo

BRANCH
  startup-checks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15939

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/indexerstate.h
  src/file/mainhub.cpp

To: poboiko, #baloo, #frameworks, vhanda
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis added a comment.


  In D15934#336409 , @broulik wrote:
  
  > > It is actual part of the Breeze Plasma theme though:
  >
  > Interesting. I have never seen it used, though. Then the Bluetooth applet 
(and likely Network manager applet) need to be fixed to use that one instead. 
Not sure I would like the padlock when my headphones are connected.
  
  
  To be honest, I don't think that's really necessary. If other DEs don't use 
that icon and we don't //need// that icon, why not just remove it or ignore it? 
Grey/50% opacity for disabled, normal for enabled and the dots on either side 
for active connection should be enough.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis updated this revision to Diff 42846.
ndavis added a comment.


  Add symbolic links

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15934?vs=42829=42846

BRANCH
  other-desktop-compatibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15934

AFFECTED FILES
  icons-dark/status/16/battery-000-charging.svg
  icons-dark/status/16/battery-000.svg
  icons-dark/status/16/battery-010-charging.svg
  icons-dark/status/16/battery-010.svg
  icons-dark/status/16/battery-020-charging.svg
  icons-dark/status/16/battery-020.svg
  icons-dark/status/16/battery-030-charging.svg
  icons-dark/status/16/battery-030.svg
  icons-dark/status/16/battery-040-charging.svg
  icons-dark/status/16/battery-040.svg
  icons-dark/status/16/battery-050-charging.svg
  icons-dark/status/16/battery-050.svg
  icons-dark/status/16/battery-060-charging.svg
  icons-dark/status/16/battery-060.svg
  icons-dark/status/16/battery-070-charging.svg
  icons-dark/status/16/battery-070.svg
  icons-dark/status/16/battery-080-charging.svg
  icons-dark/status/16/battery-080.svg
  icons-dark/status/16/battery-090-charging.svg
  icons-dark/status/16/battery-090.svg
  icons-dark/status/16/battery-100-charging.svg
  icons-dark/status/16/battery-100.svg
  icons-dark/status/16/battery-caution-charging.svg
  icons-dark/status/16/battery-caution.svg
  icons-dark/status/16/battery-empty-charging.svg
  icons-dark/status/16/battery-empty.svg
  icons-dark/status/16/battery-full-charging.svg
  icons-dark/status/16/battery-full.svg
  icons-dark/status/16/battery-good-charging.svg
  icons-dark/status/16/battery-good.svg
  icons-dark/status/16/battery-low-charging.svg
  icons-dark/status/16/battery-low.svg
  icons-dark/status/16/battery-missing.svg
  icons-dark/status/16/bluetooth-active.svg
  icons-dark/status/16/bluetooth-disabled.svg
  icons-dark/status/16/bluetooth-paired.svg
  icons-dark/status/16/bluetooth.svg
  icons-dark/status/22/battery-000-charging.svg
  icons-dark/status/22/battery-000.svg
  icons-dark/status/22/battery-010-charging.svg
  icons-dark/status/22/battery-010.svg
  icons-dark/status/22/battery-020-charging.svg
  icons-dark/status/22/battery-020.svg
  icons-dark/status/22/battery-030-charging.svg
  icons-dark/status/22/battery-030.svg
  icons-dark/status/22/battery-040-charging.svg
  icons-dark/status/22/battery-040.svg
  icons-dark/status/22/battery-050-charging.svg
  icons-dark/status/22/battery-050.svg
  icons-dark/status/22/battery-060-charging.svg
  icons-dark/status/22/battery-060.svg
  icons-dark/status/22/battery-070-charging.svg
  icons-dark/status/22/battery-070.svg
  icons-dark/status/22/battery-080-charging.svg
  icons-dark/status/22/battery-080.svg
  icons-dark/status/22/battery-090-charging.svg
  icons-dark/status/22/battery-090.svg
  icons-dark/status/22/battery-100-charging.svg
  icons-dark/status/22/battery-100.svg
  icons-dark/status/22/battery-caution-charging.svg
  icons-dark/status/22/battery-caution.svg
  icons-dark/status/22/battery-empty-charging.svg
  icons-dark/status/22/battery-empty.svg
  icons-dark/status/22/battery-full-charging.svg
  icons-dark/status/22/battery-full.svg
  icons-dark/status/22/battery-good-charging.svg
  icons-dark/status/22/battery-good.svg
  icons-dark/status/22/battery-low-charging.svg
  icons-dark/status/22/battery-low.svg
  icons-dark/status/22/battery-missing.svg
  icons-dark/status/22/bluetooth-active.svg
  icons-dark/status/22/bluetooth-disabled.svg
  icons-dark/status/22/bluetooth-paired.svg
  icons-dark/status/22/bluetooth.svg
  icons-dark/status/symbolic/battery-caution-charging-symbolic.svg
  icons-dark/status/symbolic/battery-caution-symbolic.svg
  icons-dark/status/symbolic/battery-empty-charging-symbolic.svg
  icons-dark/status/symbolic/battery-empty-symbolic.svg
  icons-dark/status/symbolic/battery-full-charging-symbolic.svg
  icons-dark/status/symbolic/battery-full-symbolic.svg
  icons-dark/status/symbolic/battery-good-charging-symbolic.svg
  icons-dark/status/symbolic/battery-good-symbolic.svg
  icons-dark/status/symbolic/battery-low-charging-symbolic.svg
  icons-dark/status/symbolic/battery-low-symbolic.svg
  icons-dark/status/symbolic/battery-missing-symbolic.svg
  icons/status/16/battery-000-charging.svg
  icons/status/16/battery-000.svg
  icons/status/16/battery-010-charging.svg
  icons/status/16/battery-010.svg
  icons/status/16/battery-020-charging.svg
  icons/status/16/battery-020.svg
  icons/status/16/battery-030-charging.svg
  icons/status/16/battery-030.svg
  icons/status/16/battery-040-charging.svg
  icons/status/16/battery-040.svg
  icons/status/16/battery-050-charging.svg
  icons/status/16/battery-050.svg
  icons/status/16/battery-060-charging.svg
  icons/status/16/battery-060.svg
  icons/status/16/battery-070-charging.svg
  icons/status/16/battery-070.svg
  icons/status/16/battery-080-charging.svg
  icons/status/16/battery-080.svg
  icons/status/16/battery-090-charging.svg
  

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

[David Faure]

dfaure accepted this revision.
dfaure added a comment.


  Great stuff. Only found some typos and very minor things, feel free to fix 
and push.

INLINE COMMENTS

> mtpdevice.cpp:119
> +{
> +QList list;
> +for (const MTPStorage *storage : m_storages) {

Technically this is missing a

  list.reserve(m_storages.count())

but I guess these lists are pretty small in practice...

> mtpstorage.cpp:31
> + */
> +uint16_t onDataPut(void *, void *priv, uint32_t sendlen, unsigned char 
> *data, uint32_t *putlen)
> +{

Prepend "static" to all these class-level functions (so they don't get 
exported, and so that the compiler knows they are only usable in this file, 
which can lead to more optimizations like inlining).

> kmtpdeviceinterface.cpp:35
> +const auto storageNames = m_dbusInterface->listStorages().value();
> +for (const QDBusObjectPath  : storageNames) {
> +m_storages.append(new KMTPStorageInterface(storageName.path(), 
> this));

m_storages.reserve(storageNames.count())

> kmtpstorageinterface.cpp:33
> +  this);
> +m_dbusInterface->setTimeout(5 * 60 * 1000); // TODO: listening folders 
> with a huge amount of files may take a while
> +

s/listening/listing/ ?

> org.kde.kmtp.daemon.xml:40
> +
> +

D15934: Add battery and bluetooth icons for other DE compatibility

[Kai Uwe Broulik]

broulik added a comment.


  > It is actual part of the Breeze Plasma theme though:
  
  Interesting. I have never seen it used, though. Then the Bluetooth applet 
(and likely Network manager applet) need to be fixed to use that one instead. 
Not sure I would like the padlock when my headphones are connected.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis added a comment.


  In D15934#336349 , @broulik wrote:
  
  > For Bluetooth we currently use:
  >
  > - disabled: grayed out/softened icon
  > - active: black icon
  > - paired: black icon with dots next to each other That "padlock" doesn't 
communicate "paired" to me and is inconsistent with Plasma's icon
  
  
  Actually, the icon with dots on both sides is used when a device is connected 
in other DEs, so I'm not sure if the icon with the padlock is used much at all. 
Adwaita doesn't include it. I'm just including it because Papirus does.
  
  This is Xfce:
  
https://cdn.discordapp.com/attachments/366985425371398148/497318487736188929/Screenshot_2018-10-04_16-05-47.png
  
  It is actual part of the Breeze Plasma theme though:
  F6303272: Screenshot_20181004_073703.png 

  
  And it does match the icon Papirus uses for `bluetooth-paired`:
  F6303277: Screenshot_20181004_073950.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis added a comment.


  In D15934#336261 , @ngraham wrote:
  
  > How can I test this? Or even, how did you test this?
  
  
  I tested it by comparing the icons and names with Adwaita and Papirus, then 
asking an Xfce user to see if the icons worked for them on their laptop. This 
was a week or two ago and they didn't report any problems since I gave them the 
icons.
  
  Do note that I did not include Xfce specific symlinks for bluetooth status 
icons (blueman and blueberry symlinks) in this commit. I want to find out if 
they are really necessary for Xfce. If they are, I will include them later in a 
general Xfce compatibility patch. In the mean time, the bluetooth icons should 
be compatible with most DEs without needing additional symlinks since they use 
the same names as Adwaita.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15745: Implement Media and MediaEndpoint API

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> manager_p.cpp:46
>  , m_bluezProfileManager(nullptr)
> +, m_media(nullptr)
>  , m_initialized(false)

No need because it is smart pointer.

> manager_p.cpp:162
> +if (interfaces.contains(Strings::orgBluezMedia1())) {
> +m_media = MediaPtr(new Media(path, this));
> +}

As it is smart pointer, it must not have a parent.

> mediaendpoint.cpp:46
> +
> +const QVariantMap& MediaEndpoint::properties() const
> +{

`const QVariantMap &`

> mediaendpoint.cpp:74
> +else if (caps.channel_mode & SBC_CHANNEL_MODE_JOINT_STEREO) 
> caps.channel_mode = SBC_CHANNEL_MODE_JOINT_STEREO;
> +//else if (caps.channel_mode & SBC_CHANNEL_MODE_DUAL_CHANNEL) 
> caps.channel_mode = SBC_CHANNEL_MODE_DUAL_CHANNEL;
> +else break;

Remove commented code.

Also coding style:

  if (..) { // braces always, even for one statement
 ..
  } else if {
 ...
  }

> mediaendpoint.h:141
> + */
> +void configurationSet(const QString& transportObjectPath, const 
> QVariantMap& properties);
> +

`const QVariantMap `

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

[Kai Uwe Broulik]

broulik added a comment.


  +1
  Oxygen uses a globe for "network-workgroup" and a folder with a cable as 
"folder-network", someone might wanted to have a globe icon here for 
recognizability ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15932: [UDisks2] Power down drive on remove if supported

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> udisksstorageaccess.cpp:186
>  Device drive(drivePath);
> +QDBusConnection c = 
> QDBusConnection::connectToBus(QDBusConnection::SystemBus, 
> "Solid::Udisks2::Drive::" + drivePath);
> +

Why this change?

REPOSITORY
  R245 Solid

BRANCH
  udisks2_power_down

REVISION DETAIL
  https://phabricator.kde.org/D15932

To: bruns, #frameworks, ngraham
Cc: broulik, kde-frameworks-devel, ngraham, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Kai Uwe Broulik]

broulik added a comment.


  For Bluetooth we currently use:
  
  - disabled: grayed out/softened icon
  - active: black icon
  - paired: black icon with dots next to each other
  
  That "padlock" doesn't communicate "paired" to me and is inconsistent with 
Plasma's icon

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15935: Don't show a emblem for mounted disks, only unmounted disks

[Kai Uwe Broulik]

broulik added a comment.


  I think that's a sensible idea. Can you also evaluate the implications for 
Device Notifier?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns