date:20181102

Re: KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Failing!

2018-11-02 Thread Ben Cooksley

Hi Marco & Plasma Folks,

Can someone please look into this?
This seems to be the usual class of QTest compilation failures due to
changes in how it handles casts between 5.9 / 5.10.

Cheers,
Ben

On Sat, Nov 3, 2018 at 5:06 PM CI System  wrote:

> *BUILD FAILURE*
> Build URL
> https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/69/
> Project: kf5-qt5 SUSEQt5.9
> Date of build: Sat, 03 Nov 2018 04:05:12 +
> Build duration: 1 min 20 sec and counting
> * CONSOLE OUTPUT *
> [...truncated 475.62 KB...]
> [ 70%] Building CXX object tests/CMakeFiles/panelTest.dir/paneltest.cpp.o
> Scanning dependencies of target testRenderingServer
> [ 70%] Built target testFilter_autogen
> [ 70%] Built target testWaylandServerSeat_autogen
> [ 70%] Building CXX object
> tests/CMakeFiles/testServer.dir/waylandservertest.cpp.o
> [ 70%] Building CXX object
> tests/CMakeFiles/testRenderingServer.dir/renderingservertest.cpp.o
> [ 71%] Building CXX object
> tests/CMakeFiles/panelTest.dir/panelTest_autogen/mocs_compilation.cpp.o
> [ 71%] Building CXX object
> tests/CMakeFiles/testRenderingServer.dir/testRenderingServer_autogen/mocs_compilation.cpp.o
> [ 71%] Built target testNoXdgRuntimeDir_autogen
> Scanning dependencies of target org-kde-kf5-kwayland-testserver
> Scanning dependencies of target testPlasmaVirtualDesktop
> [ 72%] Building CXX object
> src/tools/testserver/CMakeFiles/org-kde-kf5-kwayland-testserver.dir/main.cpp.o
> [ 72%] Built target testQtSurfaceExtension_autogen
> Scanning dependencies of target testRemoteAccess
> [ 72%] Built target testWaylandServerDisplay_autogen
> [ 72%] Building CXX object
> autotests/client/CMakeFiles/testPlasmaVirtualDesktop.dir/test_plasma_virtual_desktop.cpp.o
> [ 72%] Building CXX object
> autotests/client/CMakeFiles/testPlasmaVirtualDesktop.dir/testPlasmaVirtualDesktop_autogen/mocs_compilation.cpp.o
> [ 73%] Building CXX object
> tests/CMakeFiles/testServer.dir/testServer_autogen/mocs_compilation.cpp.o
> [ 73%] Building CXX object
> autotests/client/CMakeFiles/testRemoteAccess.dir/test_remote_access.cpp.o
> Scanning dependencies of target testAppmenu
> Scanning dependencies of target testServerSideDecorationPalette
> [ 73%] Building CXX object
> autotests/client/CMakeFiles/testAppmenu.dir/test_wayland_appmenu.cpp.o
> [ 74%] Building CXX object
> autotests/client/CMakeFiles/testServerSideDecorationPalette.dir/test_server_side_decoration_palette.cpp.o
> [ 74%] Building CXX object
> src/tools/testserver/CMakeFiles/org-kde-kf5-kwayland-testserver.dir/testserver.cpp.o
> [ 74%] Linking CXX executable ../../bin/testWaylandFullscreenShell
> [ 74%] Linking CXX executable ../bin/testServer
> [ 74%] Built target testServer
> [ 74%] Built target testWaylandFullscreenShell
> [ 74%] Building CXX object
> src/tools/testserver/CMakeFiles/org-kde-kf5-kwayland-testserver.dir/org-kde-kf5-kwayland-testserver_autogen/mocs_compilation.cpp.o
> [ 75%] Building CXX object
> autotests/client/CMakeFiles/testAppmenu.dir/testAppmenu_autogen/mocs_compilation.cpp.o
> [ 75%] Building CXX object
> autotests/client/CMakeFiles/testServerSideDecorationPalette.dir/testServerSideDecorationPalette_autogen/mocs_compilation.cpp.o
> [ 75%] Building CXX object
> autotests/client/CMakeFiles/testRemoteAccess.dir/testRemoteAccess_autogen/mocs_compilation.cpp.o
> Scanning dependencies of target testContrast
> [ 75%] Linking CXX executable ../bin/panelTest
> [ 76%] Building CXX object
> autotests/client/CMakeFiles/testContrast.dir/test_wayland_contrast.cpp.o
> [ 76%] Built target panelTest
> Scanning dependencies of target testSubSurface
> [ 76%] Building CXX object
> autotests/client/CMakeFiles/testSubSurface.dir/test_wayland_subsurface.cpp.o
> [ 77%] Building CXX object
> autotests/client/CMakeFiles/testSubSurface.dir/testSubSurface_autogen/mocs_compilation.cpp.o
> Scanning dependencies of target testSubCompositor
> [ 77%] Building CXX object
> autotests/client/CMakeFiles/testSubCompositor.dir/test_wayland_subcompositor.cpp.o
> [ 78%] Linking CXX executable ../../bin/testRemoteAccess
> [ 78%] Linking CXX executable ../bin/testRenderingServer
> [ 78%] Linking CXX executable ../../bin/testAppmenu
> [ 78%] Linking CXX executable ../../../bin/org-kde-kf5-kwayland-testserver
> [ 78%] Linking CXX executable ../../bin/testServerSideDecorationPalette
> [ 78%] Built target testRemoteAccess
> Scanning dependencies of target testCompositor
> [ 78%] Built target testAppmenu
> [ 78%] Building CXX object
> autotests/client/CMakeFiles/testSubCompositor.dir/testSubCompositor_autogen/mocs_compilation.cpp.o
> [ 78%] Built target testRenderingServer
> [ 78%] Building CXX object
> autotests/client/CMakeFiles/testCompositor.dir/test_compositor.cpp.o
> [ 78%] Built target org-kde-kf5-kwayland-testserver
> [ 78%] Building CXX object
> autotests/client/CMakeFiles/testCompositor.dir/testCompositor_autogen/mocs_compilation.cpp.o
> Scanning dependencies of target testWaylandOutputDevice
> [ 78%] Building CXX object
>

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Failing!

2018-11-02 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/69/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 04:05:12 +
 Build duration:
1 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 475.62 KB...][ 70%] Building CXX object tests/CMakeFiles/panelTest.dir/paneltest.cpp.oScanning dependencies of target testRenderingServer[ 70%] Built target testFilter_autogen[ 70%] Built target testWaylandServerSeat_autogen[ 70%] Building CXX object tests/CMakeFiles/testServer.dir/waylandservertest.cpp.o[ 70%] Building CXX object tests/CMakeFiles/testRenderingServer.dir/renderingservertest.cpp.o[ 71%] Building CXX object tests/CMakeFiles/panelTest.dir/panelTest_autogen/mocs_compilation.cpp.o[ 71%] Building CXX object tests/CMakeFiles/testRenderingServer.dir/testRenderingServer_autogen/mocs_compilation.cpp.o[ 71%] Built target testNoXdgRuntimeDir_autogenScanning dependencies of target org-kde-kf5-kwayland-testserverScanning dependencies of target testPlasmaVirtualDesktop[ 72%] Building CXX object src/tools/testserver/CMakeFiles/org-kde-kf5-kwayland-testserver.dir/main.cpp.o[ 72%] Built target testQtSurfaceExtension_autogenScanning dependencies of target testRemoteAccess[ 72%] Built target testWaylandServerDisplay_autogen[ 72%] Building CXX object autotests/client/CMakeFiles/testPlasmaVirtualDesktop.dir/test_plasma_virtual_desktop.cpp.o[ 72%] Building CXX object autotests/client/CMakeFiles/testPlasmaVirtualDesktop.dir/testPlasmaVirtualDesktop_autogen/mocs_compilation.cpp.o[ 73%] Building CXX object tests/CMakeFiles/testServer.dir/testServer_autogen/mocs_compilation.cpp.o[ 73%] Building CXX object autotests/client/CMakeFiles/testRemoteAccess.dir/test_remote_access.cpp.oScanning dependencies of target testAppmenuScanning dependencies of target testServerSideDecorationPalette[ 73%] Building CXX object autotests/client/CMakeFiles/testAppmenu.dir/test_wayland_appmenu.cpp.o[ 74%] Building CXX object autotests/client/CMakeFiles/testServerSideDecorationPalette.dir/test_server_side_decoration_palette.cpp.o[ 74%] Building CXX object src/tools/testserver/CMakeFiles/org-kde-kf5-kwayland-testserver.dir/testserver.cpp.o[ 74%] Linking CXX executable ../../bin/testWaylandFullscreenShell[ 74%] Linking CXX executable ../bin/testServer[ 74%] Built target testServer[ 74%] Built target testWaylandFullscreenShell[ 74%] Building CXX object src/tools/testserver/CMakeFiles/org-kde-kf5-kwayland-testserver.dir/org-kde-kf5-kwayland-testserver_autogen/mocs_compilation.cpp.o[ 75%] Building CXX object autotests/client/CMakeFiles/testAppmenu.dir/testAppmenu_autogen/mocs_compilation.cpp.o[ 75%] Building CXX object autotests/client/CMakeFiles/testServerSideDecorationPalette.dir/testServerSideDecorationPalette_autogen/mocs_compilation.cpp.o[ 75%] Building CXX object autotests/client/CMakeFiles/testRemoteAccess.dir/testRemoteAccess_autogen/mocs_compilation.cpp.oScanning dependencies of target testContrast[ 75%] Linking CXX executable ../bin/panelTest[ 76%] Building CXX object autotests/client/CMakeFiles/testContrast.dir/test_wayland_contrast.cpp.o[ 76%] Built target panelTestScanning dependencies of target testSubSurface[ 76%] Building CXX object autotests/client/CMakeFiles/testSubSurface.dir/test_wayland_subsurface.cpp.o[ 77%] Building CXX object autotests/client/CMakeFiles/testSubSurface.dir/testSubSurface_autogen/mocs_compilation.cpp.oScanning dependencies of target testSubCompositor[ 77%] Building CXX object autotests/client/CMakeFiles/testSubCompositor.dir/test_wayland_subcompositor.cpp.o[ 78%] Linking CXX executable ../../bin/testRemoteAccess[ 78%] Linking CXX executable ../bin/testRenderingServer[ 78%] Linking CXX executable ../../bin/testAppmenu[ 78%] Linking CXX executable ../../../bin/org-kde-kf5-kwayland-testserver[ 78%] Linking CXX executable ../../bin/testServerSideDecorationPalette[ 78%] Built target testRemoteAccessScanning dependencies of target testCompositor[ 78%] Built target testAppmenu[ 78%] Building CXX object autotests/client/CMakeFiles/testSubCompositor.dir/testSubCompositor_autogen/mocs_compilation.cpp.o[ 78%] Built target testRenderingServer[ 78%] Building CXX object autotests/client/CMakeFiles/testCompositor.dir/test_compositor.cpp.o[ 78%] Built target org-kde-kf5-kwayland-testserver[ 78%] Building CXX object autotests/client/CMakeFiles/testCompositor.dir/testCompositor_autogen/mocs_compilation.cpp.oScanning dependencies of target testWaylandOutputDevice[ 78%] Building CXX object autotests/client/CMakeFiles/testWaylandOutputDevice.dir/test_wayland_outputdevice.cpp.oScanning dependencies of target testWaylandRegistryScanning dependencies of target testRegion[ 78%] Building CXX object autotests/client/CMakeFiles/testWaylandRegistry.dir/test_wayland_registry.cpp.o[ 79%] Building CXX object autotests/client/CMakeFiles/testRegion.dir/test_wayland_region.cpp.o[ 79%] Built target testServerSideDecorationPalette[ 79%] Building CXX

KDE CI: Frameworks » kconfig » kf5-qt5 AndroidQt5.11 - Build # 33 - Fixed!

2018-11-02 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20AndroidQt5.11/33/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 03 Nov 2018 04:05:05 +
 Build duration:
52 sec and counting

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.11 - Build # 22 - Fixed!

2018-11-02 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.11/22/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 03 Nov 2018 04:05:05 +
 Build duration:
51 sec and counting

[sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

2018-11-02 Thread Ben Cooksley

Git commit a01c4d1ba8fd31f1112c207b61542b14aab3e9e8 by Ben Cooksley.
Committed on 03/11/2018 at 03:48.
Pushed by bcooksley into branch 'master'.

Disable parts of the System Dependency building on Android CI until rsync can 
be made available.
The Docker image for Android CI currently can't be built due to missing 
tags/branches in the Qt Git repositories which were previously present.
See 
https://build.kde.org/job/Administration/job/Docker%20Generate%20AndroidQt5.11%20SDK/
 for more information.

CCMAIL: kde-frameworks-devel@kde.org
CCMAIL: aleix...@kde.org

M  +1-1pipeline-templates/AndroidQt5.11.template
M  +1-0system-images/android/sdk/Dockerfile

https://commits.kde.org/sysadmin/ci-tooling/a01c4d1ba8fd31f1112c207b61542b14aab3e9e8

diff --git a/pipeline-templates/AndroidQt5.11.template 
b/pipeline-templates/AndroidQt5.11.template
index 17d21da..1c5f1b1 100644
--- a/pipeline-templates/AndroidQt5.11.template
+++ b/pipeline-templates/AndroidQt5.11.template
@@ -68,7 +68,7 @@ timestamps {
 
\$systemDependencies
 
-   rsync -Ha '\$DESTDIR/\$APP_INSTALL_PREFIX/' 
'\$APP_INSTALL_PREFIX/'
+   #rsync -Ha '\$DESTDIR/\$APP_INSTALL_PREFIX/' 
'\$APP_INSTALL_PREFIX/'
"""
}
 
diff --git a/system-images/android/sdk/Dockerfile 
b/system-images/android/sdk/Dockerfile
index 14deab2..14034ea 100644
--- a/system-images/android/sdk/Dockerfile
+++ b/system-images/android/sdk/Dockerfile
@@ -13,6 +13,7 @@ RUN apt-get -qq update && apt-get install -qq \
 build-essential \
 gperf gettext \
 python3 python3-paramiko python3-lxml python3-yaml \
+rsync \
 bison flex \
 ruby wget \
 libxml2-utils \

Regression in Frameworks - DBus Hangs

2018-11-02 Thread Ben Cooksley

Hi all,

Following commits made to Frameworks somewhere in the October 21 to
October 28 time frame, the unit tests of Konsole on the CI system have
started to hang following completion.

This hang is occurring due to a behaviour of CTest, where it will wait
(indefinitely) following the conclusion of a test for processes
spawned by that test to exit.

Previously, the "konsole --separate" process launched by Konsole's
dbus unit test would exit normally, however following the changes in
Frameworks it now hangs and does not exit as expected.

This is causing quite a bit of trouble as these builds require manual
Sysadmin intervention in order to have the jobs complete successfully.

Could someone take a look into this regression please?

Regretfully it isn't possible to run GDB within the CI system
environment (Docker drops CAP_SYS_PTRACE) so i'm unable to get a
backtrace out of Konsole to find where it is stuck.

Thanks,
Ben

KDE CI: Frameworks » kconfig » kf5-qt5 AndroidQt5.11 - Build # 32 - Still Failing!

2018-11-02 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20AndroidQt5.11/32/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 03 Nov 2018 03:38:00 +
 Build duration:
33 sec and counting
   CONSOLE OUTPUT
  [...truncated 2.45 KB...][Pipeline] { (Checkout Sources)[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/kconfig > git init /home/user/workspace/Frameworks/kconfig/kf5-qt5 AndroidQt5.11 # timeout=10Fetching upstream changes from git://anongit.kde.org/kconfig > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kconfig +refs/heads/*:refs/remotes/origin/* # timeout=120 > git config remote.origin.url git://anongit.kde.org/kconfig # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/kconfig # timeout=10Fetching upstream changes from git://anongit.kde.org/kconfig > git fetch --tags --progress git://anongit.kde.org/kconfig +refs/heads/*:refs/remotes/origin/* # timeout=120 > git rev-parse origin/master^{commit} # timeout=10Checking out Revision d5c5113e8ea18ec0de70eb9edf286e4dac7109e9 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f d5c5113e8ea18ec0de70eb9edf286e4dac7109e9Commit message: "Remove unused variable" > git rev-list --no-walk d5c5113e8ea18ec0de70eb9edf286e4dac7109e9 # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /home/user/workspace/Frameworks/kconfig/kf5-qt5 AndroidQt5.11/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision cdfa0d74bcd096acb51f8c015496d60977439c83 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f cdfa0d74bcd096acb51f8c015496d60977439c83Commit message: "Update variable name per comment from Sandro."[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks/kconfig/kf5-qt5 AndroidQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision f83b8471e5e7345225b2a8eb0a5cf534dee4c10f (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f f83b8471e5e7345225b2a8eb0a5cf534dee4c10fCommit message: "add translations"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks/kconfig/kf5-qt5 AndroidQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 09f38e86982eed1e2218223133ba5274dcf44f85 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 09f38e86982eed1e2218223133ba5274dcf44f85Commit message: "libqaccessibilityclient now in

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.11 - Build # 21 - Still Failing!

2018-11-02 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.11/21/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 03 Nov 2018 03:37:55 +
 Build duration:
40 sec and counting
   CONSOLE OUTPUT
  [...truncated 2.55 KB...]Cloning the remote Git repositoryCloning repository git://anongit.kde.org/kjobwidgets > git init /home/user/workspace/Frameworks/kjobwidgets/kf5-qt5 AndroidQt5.11 # timeout=10Fetching upstream changes from git://anongit.kde.org/kjobwidgets > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kjobwidgets +refs/heads/*:refs/remotes/origin/* # timeout=120 > git config remote.origin.url git://anongit.kde.org/kjobwidgets # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/kjobwidgets # timeout=10Fetching upstream changes from git://anongit.kde.org/kjobwidgets > git fetch --tags --progress git://anongit.kde.org/kjobwidgets +refs/heads/*:refs/remotes/origin/* # timeout=120 > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 35b22731bed2f568acdfa9f94d8509516fffe045 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 35b22731bed2f568acdfa9f94d8509516fffe045Commit message: "Revert some port to function-object based connect" > git rev-list --no-walk 35b22731bed2f568acdfa9f94d8509516fffe045 # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /home/user/workspace/Frameworks/kjobwidgets/kf5-qt5 AndroidQt5.11/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision cdfa0d74bcd096acb51f8c015496d60977439c83 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f cdfa0d74bcd096acb51f8c015496d60977439c83Commit message: "Update variable name per comment from Sandro."[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks/kjobwidgets/kf5-qt5 AndroidQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision f83b8471e5e7345225b2a8eb0a5cf534dee4c10f (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f f83b8471e5e7345225b2a8eb0a5cf534dee4c10fCommit message: "add translations"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks/kjobwidgets/kf5-qt5 AndroidQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 09f38e86982eed1e2218223133ba5274dcf44f85 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 09f38e86982eed1e2218223133ba5274dcf44f85Commit message:

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

2018-11-02 Thread Stefan Brüns

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16523

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-02 Thread Stefan Brüns

bruns marked 2 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> apol wrote in xmlextractortest.cpp:70
> Won't this break any use?

Previously, the last element was "foo_bar__", now it is "foo_bar_".
SimpleExtractionResult::append(text) adds a space after the inserted text after 
each call.
If there is something sensitive to multiple whitespaces, we have a problem - 
but I really doubt it.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16591

To: bruns, #frameworks, astippich
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

[sysadmin/ci-tooling] pipeline-templates: Ensure that Groovy passes the shell script through to the shell interpreter for evaluation.

2018-11-02 Thread Ben Cooksley

Git commit 88415288d6803f28f413a67233185ed9698ceeb9 by Ben Cooksley.
Committed on 03/11/2018 at 03:14.
Pushed by bcooksley into branch 'master'.

Ensure that Groovy passes the shell script through to the shell interpreter for 
evaluation.

CCMAIL: kde-frameworks-devel@kde.org

M  +5-5pipeline-templates/AndroidQt5.11.template

https://commits.kde.org/sysadmin/ci-tooling/88415288d6803f28f413a67233185ed9698ceeb9

diff --git a/pipeline-templates/AndroidQt5.11.template 
b/pipeline-templates/AndroidQt5.11.template
index 3df926f..17d21da 100644
--- a/pipeline-templates/AndroidQt5.11.template
+++ b/pipeline-templates/AndroidQt5.11.template
@@ -61,14 +61,14 @@ timestamps {
sh """
systemDependencies=`python3 
ci-tooling/helpers/getsetting.py --product ${productName} --project 
${projectName} --platform ${currentPlatform} --key externalDependencies`
 
-   export 
DESTDIR=INSTALL_ROOT='$WORKSPACE/install-divert/'
-   export 
APP_INSTALL_PREFIX='$HOME/install-prefix/'
+   export 
DESTDIR=INSTALL_ROOT='\$WORKSPACE/install-divert/'
+   export 
APP_INSTALL_PREFIX='\$HOME/install-prefix/'
 
-   mkdir -p '$DESTDIR/$APP_INSTALL_PREFIX/'
+   mkdir -p '\$DESTDIR/\$APP_INSTALL_PREFIX/'
 
-   $systemDependencies
+   \$systemDependencies
 
-   rsync -Ha '$DESTDIR/$APP_INSTALL_PREFIX/' 
'$APP_INSTALL_PREFIX/'
+   rsync -Ha '\$DESTDIR/\$APP_INSTALL_PREFIX/' 
'\$APP_INSTALL_PREFIX/'
"""
}

D16465: [KSambaShare] Make "net usershare info" parser testable

2018-11-02 Thread Stefan Brüns

bruns added a comment.


  In D16465#353081 , @apol wrote:
  
  > I'm confused, you didn't add a test?
  
  
  See stack

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16465

To: bruns, #frameworks, broulik
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 65 - Still Unstable!

2018-11-02 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/65/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 01:57:53 +
 Build duration:
4 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16588: Change package manager icons to emblems

2018-11-02 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c52a911f9035: Change package manager icons to emblems 
(authored by ndavis, committed by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16588?vs=44736=44749#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16588?vs=44736=44749

REVISION DETAIL
  https://phabricator.kde.org/D16588

AFFECTED FILES
  icons-dark/actions/16/installed.svg
  icons-dark/actions/16/newer.svg
  icons-dark/actions/16/noninstalled.svg
  icons-dark/actions/16/outdated.svg
  icons-dark/actions/16/package-available-locked.svg
  icons-dark/actions/16/package-available.svg
  icons-dark/actions/16/package-broken.svg
  icons-dark/actions/16/package-downgrade.svg
  icons-dark/actions/16/package-install.svg
  icons-dark/actions/16/package-installed-locked.svg
  icons-dark/actions/16/package-installed-outdated.svg
  icons-dark/actions/16/package-installed-updated.svg
  icons-dark/actions/16/package-new.svg
  icons-dark/actions/16/package-purge.svg
  icons-dark/actions/16/package-reinstall.svg
  icons-dark/actions/16/package-remove.svg
  icons-dark/actions/16/package-supported.svg
  icons-dark/actions/16/package-upgrade.svg
  icons-dark/actions/16/unrequired.svg
  icons-dark/emblems/16/installed.svg
  icons-dark/emblems/16/newer.svg
  icons-dark/emblems/16/noninstalled.svg
  icons-dark/emblems/16/outdated.svg
  icons-dark/emblems/16/package-available-locked.svg
  icons-dark/emblems/16/package-available.svg
  icons-dark/emblems/16/package-broken.svg
  icons-dark/emblems/16/package-downgrade.svg
  icons-dark/emblems/16/package-install-auto.svg
  icons-dark/emblems/16/package-install.svg
  icons-dark/emblems/16/package-installed-locked.svg
  icons-dark/emblems/16/package-installed-outdated.svg
  icons-dark/emblems/16/package-installed-updated.svg
  icons-dark/emblems/16/package-new.svg
  icons-dark/emblems/16/package-purge.svg
  icons-dark/emblems/16/package-reinstall.svg
  icons-dark/emblems/16/package-remove-auto.svg
  icons-dark/emblems/16/package-remove.svg
  icons-dark/emblems/16/package-upgrade-auto.svg
  icons-dark/emblems/16/package-upgrade.svg
  icons-dark/emblems/16/unrequired.svg
  icons/actions/16/installed.svg
  icons/actions/16/newer.svg
  icons/actions/16/noninstalled.svg
  icons/actions/16/outdated.svg
  icons/actions/16/package-available-locked.svg
  icons/actions/16/package-available.svg
  icons/actions/16/package-broken.svg
  icons/actions/16/package-downgrade.svg
  icons/actions/16/package-install.svg
  icons/actions/16/package-installed-locked.svg
  icons/actions/16/package-installed-outdated.svg
  icons/actions/16/package-installed-updated.svg
  icons/actions/16/package-new.svg
  icons/actions/16/package-purge.svg
  icons/actions/16/package-reinstall.svg
  icons/actions/16/package-remove.svg
  icons/actions/16/package-supported.svg
  icons/actions/16/package-upgrade.svg
  icons/actions/16/unrequired.svg
  icons/emblems/16/installed.svg
  icons/emblems/16/newer.svg
  icons/emblems/16/noninstalled.svg
  icons/emblems/16/outdated.svg
  icons/emblems/16/package-available-locked.svg
  icons/emblems/16/package-available.svg
  icons/emblems/16/package-broken.svg
  icons/emblems/16/package-downgrade.svg
  icons/emblems/16/package-install-auto.svg
  icons/emblems/16/package-install.svg
  icons/emblems/16/package-installed-locked.svg
  icons/emblems/16/package-installed-outdated.svg
  icons/emblems/16/package-installed-updated.svg
  icons/emblems/16/package-new.svg
  icons/emblems/16/package-purge.svg
  icons/emblems/16/package-reinstall.svg
  icons/emblems/16/package-remove-auto.svg
  icons/emblems/16/package-remove.svg
  icons/emblems/16/package-upgrade-auto.svg
  icons/emblems/16/package-upgrade.svg
  icons/emblems/16/unrequired.svg

To: ndavis, #vdg, ngraham
Cc: valorie, bruns, ngraham, #vdg, kde-frameworks-devel, michaelh

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.11 - Build # 20 - Failure!

2018-11-02 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.11/20/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 03 Nov 2018 01:57:18 +
 Build duration:
36 sec and counting
   CONSOLE OUTPUT
  [...truncated 16.20 KB...]Cloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks/kjobwidgets/kf5-qt5 AndroidQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision f83b8471e5e7345225b2a8eb0a5cf534dee4c10f (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f f83b8471e5e7345225b2a8eb0a5cf534dee4c10fCommit message: "add translations"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks/kjobwidgets/kf5-qt5 AndroidQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 09f38e86982eed1e2218223133ba5274dcf44f85 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 09f38e86982eed1e2218223133ba5274dcf44f85Commit message: "libqaccessibilityclient now in review; stable also set to master"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kjobwidgets --branchGroup kf5-qt5 --environment production --platform AndroidQt5.11 --installTo /home/user/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Prepare Android Dependencies)[Pipeline] }[Pipeline] // stage[Pipeline] }groovy.lang.MissingPropertyException: No such property: DESTDIR for class: groovy.lang.Binding	at groovy.lang.Binding.getVariable(Binding.java:63)	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onGetProperty(SandboxInterceptor.java:264)	at org.kohsuke.groovy.sandbox.impl.Checker$6.call(Checker.java:288)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:292)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.getProperty(SandboxInvoker.java:29)	at com.cloudbees.groovy.cps.impl.PropertyAccessBlock.rawGet(PropertyAccessBlock.java:20)	at WorkflowScript.run(WorkflowScript:79)	at ___cps.transform___(Native Method)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.get(PropertyishBlock.java:74)	at com.cloudbees.groovy.cps.LValueBlock$GetAdapter.receive(LValueBlock.java:30)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.fixName(PropertyishBlock.java:66)	at sun.reflect.GeneratedMethodAccessor403.invoke(Unknown Source)	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)	at java.lang.reflect.Method.invoke(Method.java:498)	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)	at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)	at com.cloudbees.groovy.cps.Next.step(Next.java:83)	at

D16588: Change package manager icons to emblems

2018-11-02 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better, thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  package-manager-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16588

To: ndavis, #vdg, ngraham
Cc: valorie, bruns, ngraham, #vdg, kde-frameworks-devel, michaelh

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 249 - Still Unstable!

2018-11-02 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/249/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 00:35:03 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13119)19%
(1820/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3490)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(300/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 175 - Still Unstable!

2018-11-02 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/175/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 00:35:03 +
 Build duration:
2 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5178/13179)29%
(2737/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1698/3504)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 125 - Fixed!

2018-11-02 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/125/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 00:34:38 +
 Build duration:
1 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)19%
(417/2154)18%
(195/1106)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(124/128)58%
(57/98)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/96)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

D16562: Reuse resultMap instead of converting to map two times more

2018-11-02 Thread Albert Astals Cid

aacid closed this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D16562

To: aacid, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16575: Remove unused variables

2018-11-02 Thread Albert Astals Cid

aacid closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16575

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16620: add const to TypeInfo compare operater

2018-11-02 Thread Aleix Pol Gonzalez

apol added inline comments.

INLINE COMMENTS

> astippich wrote in typeinfo.h:41
> Yeah, forgot about that :/

You can't change but you can add new ones.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16620

To: astippich, #frameworks, bruns
Cc: apol, broulik, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-02 Thread Aleix Pol Gonzalez

apol added a comment.


  Patch looks good overall +1

INLINE COMMENTS

> bruns wrote in xmlextractortest.cpp:70
> QDomElement::text() leaves a final trailing whitespace which is not trimmed.

Won't this break any use?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16591

To: bruns, #frameworks, astippich
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16583: use qlatin1 for embedded image extractor

2018-11-02 Thread Aleix Pol Gonzalez

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  embedded_image_latin1

REVISION DETAIL
  https://phabricator.kde.org/D16583

To: astippich, mgallien, bruns, apol
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16619: add missing license information

2018-11-02 Thread Aleix Pol Gonzalez

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  license

REVISION DETAIL
  https://phabricator.kde.org/D16619

To: astippich, #frameworks, bruns, apol
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16465: [KSambaShare] Make "net usershare info" parser testable

2018-11-02 Thread Aleix Pol Gonzalez

apol added a comment.


  I'm confused, you didn't add a test?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16465

To: bruns, #frameworks, broulik
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16575: Remove unused variables

2018-11-02 Thread Aleix Pol Gonzalez

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16575

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16562: Reuse resultMap instead of converting to map two times more

2018-11-02 Thread Aleix Pol Gonzalez

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16562

To: aacid, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-02 Thread Emirald Mateli

emateli added a comment.


  Also, thoughts on my previous comments regarding `BatchRenameJob`?

INLINE COMMENTS

> mlaurent wrote in batchrenamedialog.h:69
> it's a good idea to initialize to nullptr each pointer here.
> So we can see problem easily.

You mean to initialize them to nullptr on the header file or using a 
constructor initialization list? Also see what problem?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-02 Thread Emirald Mateli

emateli updated this revision to Diff 44737.
emateli marked 4 inline comments as done.
emateli added a comment.


  - coding style fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14631?vs=44218=44737

BRANCH
  batchrename2

REVISION DETAIL
  https://phabricator.kde.org/D14631

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/batchrenametypestest.cpp
  autotests/batchrenametypestest.h
  src/widgets/CMakeLists.txt
  src/widgets/rename/batchrenamedialog.cpp
  src/widgets/rename/batchrenamedialog.h
  src/widgets/rename/batchrenamedialogmodel_p.cpp
  src/widgets/rename/batchrenamedialogmodel_p.h
  src/widgets/rename/batchrenametypes_p.cpp
  src/widgets/rename/batchrenametypes_p.h
  src/widgets/rename/batchrenamevar_p.cpp
  src/widgets/rename/batchrenamevar_p.h
  src/widgets/rename/filenameutils_p.cpp
  src/widgets/rename/filenameutils_p.h
  tests/CMakeLists.txt
  tests/batchrenamedialogtest_gui.cpp

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis

ndavis updated this revision to Diff 44736.
ndavis added a comment.


  Removed broken symlink. It was already copied to the emblems/16 directory, 
but I forgot to remove the old copy.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16588?vs=44713=44736

BRANCH
  package-manager-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16588

AFFECTED FILES
  icons-dark/actions/16/installed.svg
  icons-dark/actions/16/newer.svg
  icons-dark/actions/16/noninstalled.svg
  icons-dark/actions/16/outdated.svg
  icons-dark/actions/16/package-available-locked.svg
  icons-dark/actions/16/package-available.svg
  icons-dark/actions/16/package-broken.svg
  icons-dark/actions/16/package-downgrade.svg
  icons-dark/actions/16/package-install.svg
  icons-dark/actions/16/package-installed-locked.svg
  icons-dark/actions/16/package-installed-outdated.svg
  icons-dark/actions/16/package-installed-updated.svg
  icons-dark/actions/16/package-new.svg
  icons-dark/actions/16/package-purge.svg
  icons-dark/actions/16/package-reinstall.svg
  icons-dark/actions/16/package-remove.svg
  icons-dark/actions/16/package-supported.svg
  icons-dark/actions/16/package-upgrade.svg
  icons-dark/actions/16/unrequired.svg
  icons-dark/emblems/16/installed.svg
  icons-dark/emblems/16/newer.svg
  icons-dark/emblems/16/noninstalled.svg
  icons-dark/emblems/16/outdated.svg
  icons-dark/emblems/16/package-available-locked.svg
  icons-dark/emblems/16/package-available.svg
  icons-dark/emblems/16/package-broken.svg
  icons-dark/emblems/16/package-downgrade.svg
  icons-dark/emblems/16/package-install-auto.svg
  icons-dark/emblems/16/package-install.svg
  icons-dark/emblems/16/package-installed-locked.svg
  icons-dark/emblems/16/package-installed-outdated.svg
  icons-dark/emblems/16/package-installed-updated.svg
  icons-dark/emblems/16/package-new.svg
  icons-dark/emblems/16/package-purge.svg
  icons-dark/emblems/16/package-reinstall.svg
  icons-dark/emblems/16/package-remove-auto.svg
  icons-dark/emblems/16/package-remove.svg
  icons-dark/emblems/16/package-upgrade-auto.svg
  icons-dark/emblems/16/package-upgrade.svg
  icons-dark/emblems/16/unrequired.svg
  icons/actions/16/installed.svg
  icons/actions/16/newer.svg
  icons/actions/16/noninstalled.svg
  icons/actions/16/outdated.svg
  icons/actions/16/package-available-locked.svg
  icons/actions/16/package-available.svg
  icons/actions/16/package-broken.svg
  icons/actions/16/package-downgrade.svg
  icons/actions/16/package-install.svg
  icons/actions/16/package-installed-locked.svg
  icons/actions/16/package-installed-outdated.svg
  icons/actions/16/package-installed-updated.svg
  icons/actions/16/package-new.svg
  icons/actions/16/package-purge.svg
  icons/actions/16/package-reinstall.svg
  icons/actions/16/package-remove.svg
  icons/actions/16/package-supported.svg
  icons/actions/16/package-upgrade.svg
  icons/actions/16/unrequired.svg
  icons/emblems/16/installed.svg
  icons/emblems/16/newer.svg
  icons/emblems/16/noninstalled.svg
  icons/emblems/16/outdated.svg
  icons/emblems/16/package-available-locked.svg
  icons/emblems/16/package-available.svg
  icons/emblems/16/package-broken.svg
  icons/emblems/16/package-downgrade.svg
  icons/emblems/16/package-install-auto.svg
  icons/emblems/16/package-install.svg
  icons/emblems/16/package-installed-locked.svg
  icons/emblems/16/package-installed-outdated.svg
  icons/emblems/16/package-installed-updated.svg
  icons/emblems/16/package-new.svg
  icons/emblems/16/package-purge.svg
  icons/emblems/16/package-reinstall.svg
  icons/emblems/16/package-remove-auto.svg
  icons/emblems/16/package-remove.svg
  icons/emblems/16/package-upgrade-auto.svg
  icons/emblems/16/package-upgrade.svg
  icons/emblems/16/unrequired.svg

To: ndavis, #vdg, ngraham
Cc: valorie, bruns, ngraham, #vdg, kde-frameworks-devel, michaelh

D16618: add explicit to constructors

2018-11-02 Thread Matthieu Gallien

mgallien accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  explicit

REVISION DETAIL
  https://phabricator.kde.org/D16618

To: astippich, #frameworks, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16588: Change package manager icons to emblems

2018-11-02 Thread Nathaniel Graham

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This fails the symlink test:
  
$  (arcpatch-D16588) make test
Running tests...
Test project /home/dev/repos/breeze-icons
Start 1: appstreamtest
1/5 Test #1: appstreamtest    Passed0.56 sec
Start 2: symlink
2/5 Test #2: symlink ..***Failed0.23 sec
Start 3: newline
3/5 Test #3: newline ..   Passed0.11 sec
Start 4: dupe
4/5 Test #4: dupe .***Failed0.01 sec
Start 5: scalable
5/5 Test #5: scalable .***Failed0.03 sec
  
  
  
2/5 Testing: symlink
2/5 Test: symlink
Command: "/home/dev/repos/breeze-icons/bin/symlink"
Directory: /home/dev/repos/breeze-icons/autotests
"symlink" start time: Nov 02 16:29 MDT
Output:
--
* Start testing of SymlinkTest *
Config: Using QtTest library 5.11.2, Qt 5.11.2 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 7.3.0)
PASS   : SymlinkTest::initTestCase()
FAIL!  : SymlinkTest::test_broken() 
  Found broken symlinks:
/home/dev/repos/breeze-icons/icons-dark/actions/16/unrequired.svg => 
/home/dev/repos/breeze-icons/icons-dark/actions/16/package-install.svg
  
  Please fix.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16588

To: ndavis, #vdg, ngraham
Cc: valorie, bruns, ngraham, #vdg, kde-frameworks-devel, michaelh

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 124 - Unstable!

2018-11-02 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/124/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 02 Nov 2018 21:41:32 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)19%
(403/2151)17%
(186/1106)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)91%
(117/128)48%
(47/98)src100%
(8/8)100%
(8/8)66%
(205/309)49%
(103/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/96)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)68%
(30/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 36 - Still Unstable!

2018-11-02 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/36/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 02 Nov 2018 21:39:39 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7098/9494)55%
(3473/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3137)51%
(1260/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(773/1377)45%
(294/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

2018-11-02 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/48/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 02 Nov 2018 21:39:39 +
 Build duration:
3 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7098/9494)55%
(3472/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3137)51%
(1259/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(773/1377)45%
(294/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D16561: Remove unused variable

2018-11-02 Thread Albert Astals Cid

aacid closed this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D16561

To: aacid, svuorela
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16567: Remove unused variable

2018-11-02 Thread Albert Astals Cid

aacid closed this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16567

To: aacid, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16568: Remove unused variables

2018-11-02 Thread Albert Astals Cid

aacid closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16568

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16569: Remove unused variable

2018-11-02 Thread Albert Astals Cid

aacid closed this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16569

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16571: Remove unused variable

2018-11-02 Thread Albert Astals Cid

aacid closed this revision.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16571

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16572: don't assign variable to itself

2018-11-02 Thread Albert Astals Cid

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:09b4523248ab: dont assign variable to itself 
(authored by aacid).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16572?vs=44595=44735

REVISION DETAIL
  https://phabricator.kde.org/D16572

AFFECTED FILES
  src/platforms/xcb/kwindoweffects.cpp

To: aacid, svuorela
Cc: kde-frameworks-devel, mart, michaelh, ngraham, bruns

D16573: Remove unused variables

2018-11-02 Thread Albert Astals Cid

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:4a7c3dbdaf25: Remove unused variables (authored by aacid).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16573?vs=44596=44734

REVISION DETAIL
  https://phabricator.kde.org/D16573

AFFECTED FILES
  src/kaboutapplicationpersonmodel_p.cpp

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kconfig » kf5-qt5 AndroidQt5.11 - Build # 31 - Failure!

2018-11-02 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20AndroidQt5.11/31/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Fri, 02 Nov 2018 21:38:16 +
 Build duration:
30 sec and counting
   CONSOLE OUTPUT
  [...truncated 14.98 KB...]Commit message: "Allow for the appropriate file extension to use on files to be specified when managing an archive."[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks/kconfig/kf5-qt5 AndroidQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision f83b8471e5e7345225b2a8eb0a5cf534dee4c10f (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f f83b8471e5e7345225b2a8eb0a5cf534dee4c10fCommit message: "add translations"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks/kconfig/kf5-qt5 AndroidQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 09f38e86982eed1e2218223133ba5274dcf44f85 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 09f38e86982eed1e2218223133ba5274dcf44f85Commit message: "libqaccessibilityclient now in review; stable also set to master"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kconfig --branchGroup kf5-qt5 --environment production --platform AndroidQt5.11 --installTo /home/user/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Prepare Android Dependencies)[Pipeline] }[Pipeline] // stage[Pipeline] }groovy.lang.MissingPropertyException: No such property: DESTDIR for class: groovy.lang.Binding	at groovy.lang.Binding.getVariable(Binding.java:63)	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onGetProperty(SandboxInterceptor.java:264)	at org.kohsuke.groovy.sandbox.impl.Checker$6.call(Checker.java:288)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:292)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.getProperty(SandboxInvoker.java:29)	at com.cloudbees.groovy.cps.impl.PropertyAccessBlock.rawGet(PropertyAccessBlock.java:20)	at WorkflowScript.run(WorkflowScript:79)	at ___cps.transform___(Native Method)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.get(PropertyishBlock.java:74)	at com.cloudbees.groovy.cps.LValueBlock$GetAdapter.receive(LValueBlock.java:30)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.fixName(PropertyishBlock.java:66)	at sun.reflect.GeneratedMethodAccessor403.invoke(Unknown Source)	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)	at java.lang.reflect.Method.invoke(Method.java:498)	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)	at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)	at

D16574: Remove unused variable

2018-11-02 Thread Albert Astals Cid

aacid closed this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D16574

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16565: Remove unused variable

2018-11-02 Thread Albert Astals Cid

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:d5c5113e8ea1: Remove unused variable (authored by aacid).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16565?vs=44588=44733

REVISION DETAIL
  https://phabricator.kde.org/D16565

AFFECTED FILES
  src/kconfig_compiler/kconfig_compiler.cpp

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-02 Thread Alexander Stippich

astippich accepted this revision.
astippich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> bruns wrote in extractorcollection.cpp:163
> http://doc.qt.io/qt-5/qdebug.html#setAutoInsertSpaces is true by default.

I meant the code, not the output :)

> bruns wrote in extractorcollection.cpp:164
> > doesn't returning here cause immediate return after the first matching 
> > extractor for the mimetype has been found? that doesn't fit to the first 
> > paragraph of the summary.
> 
> Yes, and this is the intended change - best matching. We don't want 
> text/plain if we have a better one.

That's what I figured, the summary was a little bit misleading.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16618: add explicit to constructors

2018-11-02 Thread Alexander Stippich

astippich updated this revision to Diff 44731.
astippich added a comment.


  - don't change exported classes

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16618?vs=44724=44731

BRANCH
  explicit

REVISION DETAIL
  https://phabricator.kde.org/D16618

AFFECTED FILES
  src/externalextractor.h
  src/writers/taglibwriter.h

To: astippich, #frameworks, bruns
Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-02 Thread Stefan Brüns

bruns edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-02 Thread Stefan Brüns

bruns marked 2 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> astippich wrote in extractorcollection.cpp:163
> nitpick: extra space before "for"

http://doc.qt.io/qt-5/qdebug.html#setAutoInsertSpaces is true by default.

> astippich wrote in extractorcollection.cpp:164
> doesn't returning here cause immediate return after the first matching 
> extractor for the mimetype has been found? that doesn't fit to the first 
> paragraph of the summary.
> "Otherwise, all matches for all mime ancestors are returned, even if one 
> plugin is a much better match than any other." sounds to me that all plugins 
> of all ancestors are returned.

> doesn't returning here cause immediate return after the first matching 
> extractor for the mimetype has been found? that doesn't fit to the first 
> paragraph of the summary.

Yes, and this is the intended change - best matching. We don't want text/plain 
if we have a better one.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16618: add explicit to constructors

2018-11-02 Thread Alexander Stippich

astippich planned changes to this revision.
astippich added inline comments.

INLINE COMMENTS

> mgallien wrote in simpleextractionresult.h:42
> Given this class is exported, is this binary compatible ?

I've been not really thinking about it while I was looking at the EBN stuff and 
pushed too fast

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16618

To: astippich, #frameworks, bruns
Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16620: add const to TypeInfo compare operater

2018-11-02 Thread Alexander Stippich

astippich abandoned this revision.
astippich added inline comments.

INLINE COMMENTS

> broulik wrote in typeinfo.h:41
> This method is exported so you cannot change cv qualifiers

Yeah, forgot about that :/

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16620

To: astippich, #frameworks, bruns
Cc: broulik, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-02 Thread Stefan Brüns

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> astippich wrote in xmlextractortest.cpp:70
> why is there a difference?

QDomElement::text() leaves a final trailing whitespace which is not trimmed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16591

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16618: add explicit to constructors

2018-11-02 Thread Matthieu Gallien

mgallien added inline comments.

INLINE COMMENTS

> simpleextractionresult.h:42
>  public:
> -SimpleExtractionResult(const QString& url, const QString& mimetype = 
> QString(), const Flags& flags = ExtractEverything);
> +explicit SimpleExtractionResult(const QString& url, const QString& 
> mimetype = QString(), const Flags& flags = ExtractEverything);
>  SimpleExtractionResult(const SimpleExtractionResult& rhs);

Given this class is exported, is this binary compatible ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16618

To: astippich, #frameworks, bruns
Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16620: add const to TypeInfo compare operater

2018-11-02 Thread Kai Uwe Broulik

broulik added inline comments.

INLINE COMMENTS

> typeinfo.h:41
>  TypeInfo& operator=(const TypeInfo& rhs);
> -bool operator==(const TypeInfo& rhs);
> +bool operator==(const TypeInfo& rhs) const;
>  

This method is exported so you cannot change cv qualifiers

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16620

To: astippich, #frameworks, bruns
Cc: broulik, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16620: add const to TypeInfo compare operater

2018-11-02 Thread Alexander Stippich

astippich created this revision.
astippich added reviewers: Frameworks, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  as suggested by EBN

REPOSITORY
  R286 KFileMetaData

BRANCH
  const_type_comp

REVISION DETAIL
  https://phabricator.kde.org/D16620

AFFECTED FILES
  src/typeinfo.cpp
  src/typeinfo.h

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16619: add missing license information

2018-11-02 Thread Alexander Stippich

astippich added a comment.


  I actually don't know what the correct procedure here is regarding copyright. 
I added the copyright for Varun Joshi who is the first author according to git 
log. I added myself to the taglibwriter files as where I've added quite a lot 
of code recently.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16619

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16619: add missing license information

2018-11-02 Thread Alexander Stippich

astippich created this revision.
astippich added reviewers: Frameworks, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  add missing license information as suggested by EBN

REPOSITORY
  R286 KFileMetaData

BRANCH
  license

REVISION DETAIL
  https://phabricator.kde.org/D16619

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/config-kfilemetadata.h.in
  src/writers/taglibwriter.cpp
  src/writers/taglibwriter.h

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16618: add explicit to constructors

2018-11-02 Thread Alexander Stippich

astippich created this revision.
astippich added reviewers: Frameworks, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  add explicit to constructors as suggested by EBN

REPOSITORY
  R286 KFileMetaData

BRANCH
  explicit

REVISION DETAIL
  https://phabricator.kde.org/D16618

AFFECTED FILES
  src/externalextractor.h
  src/extractionresult.h
  src/propertyinfo.h
  src/simpleextractionresult.h
  src/typeinfo.h
  src/usermetadata.h
  src/writers/taglibwriter.h

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

2018-11-02 Thread Alexander Stippich

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16617

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16560: create a separate test file for embedded images test

2018-11-02 Thread Alexander Stippich

astippich added a dependent revision: D16617: fix extraction of GPS altitude 
for exif data.

REPOSITORY
  R286 KFileMetaData

BRANCH
  cover_jpg

REVISION DETAIL
  https://phabricator.kde.org/D16560

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

2018-11-02 Thread Alexander Stippich

astippich added a dependency: D16560: create a separate test file for embedded 
images test.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16617

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

2018-11-02 Thread Alexander Stippich

astippich created this revision.
astippich added reviewers: Frameworks, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  The previous code was wrong, since the altitude
  is given with only a single double value
  below or above sea level.

REPOSITORY
  R286 KFileMetaData

BRANCH
  exif_gps_altitude

REVISION DETAIL
  https://phabricator.kde.org/D16617

AFFECTED FILES
  autotests/exiv2extractortest.cpp
  autotests/samplefiles/test.jpg
  src/extractors/exiv2extractor.cpp
  src/extractors/exiv2extractor.h

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-02 Thread Alexander Stippich

astippich added inline comments.

INLINE COMMENTS

> xmlextractortest.cpp:70
>  QCOMPARE(result.text().leftRef(8), content.leftRef(8));
> -QCOMPARE(result.text().size(), 1 + 8 * count);
> +QCOMPARE(result.text().size(), 8 * count);
>  

why is there a difference?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16591

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-02 Thread Alexander Stippich

astippich added inline comments.

INLINE COMMENTS

> extractorcollection.cpp:163
> +if (!plugins.isEmpty()) {
> +qCDebug(KFILEMETADATA_LOG) << "Using inherited mimetype" << 
> ancestor <<  "for" << mimetype;
> +return plugins;

nitpick: extra space before "for"

> extractorcollection.cpp:164
> +qCDebug(KFILEMETADATA_LOG) << "Using inherited mimetype" << 
> ancestor <<  "for" << mimetype;
> +return plugins;
>  }

doesn't returning here cause immediate return after the first matching 
extractor for the mimetype has been found? that doesn't fit to the first 
paragraph of the summary.
"Otherwise, all matches for all mime ancestors are returned, even if one plugin 
is a much better match than any other." sounds to me that all plugins of all 
ancestors are returned.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16579: Fix APE tag extraction

2018-11-02 Thread Alexander Stippich

astippich requested changes to this revision.
astippich added a comment.


  You're doing the exact opposite of what we're asking for.
  Look, I'd love to merge the bug fix for the DISC property. But we need 
compatibility.
  I'll give you another reason: KFileMetaData has basically required that users 
use the DISCNUMBER field until now. And now you want to change that without 
providing any suitable transition. That's not user-friendly.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
spoorun, ngraham, abrahams

D16583: use qlatin1 for embedded image extractor

2018-11-02 Thread Alexander Stippich

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16583

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16583: use qlatin1 for embedded image extractor

2018-11-02 Thread Alexander Stippich

astippich updated this revision to Diff 44718.
astippich added a comment.


  - coding style

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16583?vs=44619=44718

BRANCH
  embedded_image_latin1

REVISION DETAIL
  https://phabricator.kde.org/D16583

AFFECTED FILES
  src/embeddedimagedata.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16583: use qlatin1 for embedded image extractor

2018-11-02 Thread Alexander Stippich

astippich marked an inline comment as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16583

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16592: [ExtractorCollection] Add unit-test to verify only specific extractor is used

2018-11-02 Thread Alexander Stippich

astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  Thanks :)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16592

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis

ndavis added a comment.


  In D16588#352847 , @valorie wrote:
  
  > Could not Muon be updated in this way as well? It now uses a package icon 
for all packages which seems a waste of space.
  
  
  Perhaps, and that would be great, but that would have to be done as a change 
to Muon, not breeze-icons

REPOSITORY
  R266 Breeze Icons

BRANCH
  package-manager-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16588

To: ndavis, #vdg, ngraham
Cc: valorie, bruns, ngraham, #vdg, kde-frameworks-devel, michaelh

D16588: Change package manager icons to emblems

2018-11-02 Thread Valorie Zimmerman

valorie added a comment.


  Could not Muon be updated in this way as well? It now uses a package icon for 
all packages which seems a waste of space.

REPOSITORY
  R266 Breeze Icons

BRANCH
  package-manager-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16588

To: ndavis, #vdg, ngraham
Cc: valorie, bruns, ngraham, #vdg, kde-frameworks-devel, michaelh

D16434: Fix keyboard layout change notifications

2018-11-02 Thread Fabian Vogt

fvogt updated this revision to Diff 44715.
fvogt added a comment.


  Use if-else ladder instead of switch-case and fix a typo.

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16434?vs=44714=44715

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16434

AFFECTED FILES
  CMakeLists.txt
  src/runtime/plugins/CMakeLists.txt
  src/runtime/plugins/xcb/CMakeLists.txt
  src/runtime/plugins/xcb/kglobalaccel_x11.cpp
  src/runtime/plugins/xcb/kglobalaccel_x11.h

To: fvogt, #frameworks, #plasma, romangg
Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, michaelh, bruns

D16434: Fix keyboard layout change notifications

2018-11-02 Thread Fabian Vogt

fvogt marked 2 inline comments as done.
fvogt added inline comments.

INLINE COMMENTS

> romangg wrote in kglobalaccel_x11.cpp:96
> Before there was a check to `QX11Info::isPlatformX11()`. Probably we don't 
> need the check, but did you test on Wayland?

The plugin is only loaded if the Qt platform is xcb, so the connection can 
never be null in that case.
I'll add a `Q_ASSERT` though.

> romangg wrote in kglobalaccel_x11.cpp:220
>   case m_xkb_first_event:
>   if (m_xkb_first_event) {
>   ...
>   }
>   default:
>   return false;
> 
> Or directly do the switching on `responseType` with if-else statements.

case m_xkb_first_event:

Is not valid C++ - case expressions have to be constants.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16434

To: fvogt, #frameworks, #plasma, romangg
Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, michaelh, bruns

D16434: Fix keyboard layout change notifications

2018-11-02 Thread Fabian Vogt

fvogt updated this revision to Diff 44714.
fvogt marked an inline comment as done.
fvogt added a comment.


  Add Q_ASSERT and xcb_key_symbols_free.

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16434?vs=44247=44714

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16434

AFFECTED FILES
  CMakeLists.txt
  src/runtime/plugins/CMakeLists.txt
  src/runtime/plugins/xcb/CMakeLists.txt
  src/runtime/plugins/xcb/kglobalaccel_x11.cpp
  src/runtime/plugins/xcb/kglobalaccel_x11.h

To: fvogt, #frameworks, #plasma, romangg
Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, michaelh, bruns

Downtime announcement: www.kde.org

2018-11-02 Thread Ben Cooksley

Hi all,

In order to allow for hardware maintenance, one of our physical
hardware hosts will need to be shutdown for a few hours on Monday.
This downtime will commence around 9:30am UTC and may take several
hours.

During this time a number of sites will be inaccessible, including:
- www.kde.org
- autoconfig.kde.org
- docs.kde.org
- ev.kde.org
- freebsd.kde.org
- hig.kde.org
- kdesrc-build.kde.org
- neon.kde.org
- releases.neon.kde.org
- networkcheck.kde.org
- planet.kde.org

Other websites within KDE.org that are dependent on resources hosted
on those sites may also experience delayed loading times in browsers
during this window.

As some of these sites are relied upon by applications to function
properly, those applications may experience degraded functionality
during this time.

Affected applications include:
- Discover
- Kaffeine
- Kopete
- Plasma Network Manager (when behind a captive portal)
- Any application using GHNS

In addition, any other site which is hosted by the server known as
"olios.kde.org" will also be unavailable during this time.

Apologies for any inconvenience caused.

Regards,
Ben Cooksley
KDE Sysadmin

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis

ndavis updated this revision to Diff 44713.
ndavis added a comment.


  Changed installed.svg symlink to target package-installed-updated.svg
  
  The original target was package-reinstall.svg
  
  I believe it was the way it was because:
  
  The original version of package-reinstall looked more like a symbol for 
"installed" than the original version of package-installed-updated
  
  I've changed it because the new version of package-installed-updated makes 
more sense

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16588?vs=44629=44713

BRANCH
  package-manager-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16588

AFFECTED FILES
  icons-dark/actions/16/installed.svg
  icons-dark/actions/16/newer.svg
  icons-dark/actions/16/noninstalled.svg
  icons-dark/actions/16/outdated.svg
  icons-dark/actions/16/package-available-locked.svg
  icons-dark/actions/16/package-available.svg
  icons-dark/actions/16/package-broken.svg
  icons-dark/actions/16/package-downgrade.svg
  icons-dark/actions/16/package-install.svg
  icons-dark/actions/16/package-installed-locked.svg
  icons-dark/actions/16/package-installed-outdated.svg
  icons-dark/actions/16/package-installed-updated.svg
  icons-dark/actions/16/package-new.svg
  icons-dark/actions/16/package-purge.svg
  icons-dark/actions/16/package-reinstall.svg
  icons-dark/actions/16/package-remove.svg
  icons-dark/actions/16/package-supported.svg
  icons-dark/actions/16/package-upgrade.svg
  icons-dark/emblems/16/installed.svg
  icons-dark/emblems/16/newer.svg
  icons-dark/emblems/16/noninstalled.svg
  icons-dark/emblems/16/outdated.svg
  icons-dark/emblems/16/package-available-locked.svg
  icons-dark/emblems/16/package-available.svg
  icons-dark/emblems/16/package-broken.svg
  icons-dark/emblems/16/package-downgrade.svg
  icons-dark/emblems/16/package-install-auto.svg
  icons-dark/emblems/16/package-install.svg
  icons-dark/emblems/16/package-installed-locked.svg
  icons-dark/emblems/16/package-installed-outdated.svg
  icons-dark/emblems/16/package-installed-updated.svg
  icons-dark/emblems/16/package-new.svg
  icons-dark/emblems/16/package-purge.svg
  icons-dark/emblems/16/package-reinstall.svg
  icons-dark/emblems/16/package-remove-auto.svg
  icons-dark/emblems/16/package-remove.svg
  icons-dark/emblems/16/package-upgrade-auto.svg
  icons-dark/emblems/16/package-upgrade.svg
  icons-dark/emblems/16/unrequired.svg
  icons/actions/16/installed.svg
  icons/actions/16/newer.svg
  icons/actions/16/noninstalled.svg
  icons/actions/16/outdated.svg
  icons/actions/16/package-available-locked.svg
  icons/actions/16/package-available.svg
  icons/actions/16/package-broken.svg
  icons/actions/16/package-downgrade.svg
  icons/actions/16/package-install.svg
  icons/actions/16/package-installed-locked.svg
  icons/actions/16/package-installed-outdated.svg
  icons/actions/16/package-installed-updated.svg
  icons/actions/16/package-new.svg
  icons/actions/16/package-purge.svg
  icons/actions/16/package-reinstall.svg
  icons/actions/16/package-remove.svg
  icons/actions/16/package-supported.svg
  icons/actions/16/package-upgrade.svg
  icons/actions/16/unrequired.svg
  icons/emblems/16/installed.svg
  icons/emblems/16/newer.svg
  icons/emblems/16/noninstalled.svg
  icons/emblems/16/outdated.svg
  icons/emblems/16/package-available-locked.svg
  icons/emblems/16/package-available.svg
  icons/emblems/16/package-broken.svg
  icons/emblems/16/package-downgrade.svg
  icons/emblems/16/package-install-auto.svg
  icons/emblems/16/package-install.svg
  icons/emblems/16/package-installed-locked.svg
  icons/emblems/16/package-installed-outdated.svg
  icons/emblems/16/package-installed-updated.svg
  icons/emblems/16/package-new.svg
  icons/emblems/16/package-purge.svg
  icons/emblems/16/package-reinstall.svg
  icons/emblems/16/package-remove-auto.svg
  icons/emblems/16/package-remove.svg
  icons/emblems/16/package-upgrade-auto.svg
  icons/emblems/16/package-upgrade.svg
  icons/emblems/16/unrequired.svg

To: ndavis, #vdg, ngraham
Cc: bruns, ngraham, #vdg, kde-frameworks-devel, michaelh

D16588: Change package manager icons to emblems

2018-11-02 Thread Stefan Brüns

bruns added a comment.


  +1!

REPOSITORY
  R266 Breeze Icons

BRANCH
  package-manager-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16588

To: ndavis, #vdg, ngraham
Cc: bruns, ngraham, #vdg, kde-frameworks-devel, michaelh

D16588: Change package manager icons to emblems

2018-11-02 Thread Nathaniel Graham

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  package-manager-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16588

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16579: Fix APE tag extraction

2018-11-02 Thread Stefan Brüns

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Stop breaking code!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
spoorun, ngraham, abrahams

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-02 Thread Shubham

shubham updated this revision to Diff 44712.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16249?vs=44710=44712

REVISION DETAIL
  https://phabricator.kde.org/D16249

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/global.h
  src/core/job_error.cpp

To: shubham, ngraham, elvisangelaccio, #frameworks, bruns
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-02 Thread Nathaniel Graham

ngraham added a comment.


  Uh-oh, I think the latest update to this diff isn't quite correct. I see 
unrelated changes that you didn't make being marked as additions.
  
  You might try using `arc` in the future. It makes this process much simpler. 
See 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks, bruns
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-02 Thread Shubham

shubham retitled this revision from "Warn user before copy/move job if the file 
size exceeds the maximum possible file size in FAT32 file system(4 GB) " to 
"Warn user before copy/move job if the file size exceeds the maximum possible 
file size in FAT32 filesystem(4 GB) ".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks, bruns
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-11-02 Thread Shubham

shubham updated this revision to Diff 44710.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16249?vs=44688=44710

REVISION DETAIL
  https://phabricator.kde.org/D16249

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/global.h
  src/core/job_error.cpp

To: shubham, ngraham, elvisangelaccio, #frameworks, bruns
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16579: Fix APE tag extraction

2018-11-02 Thread James Smith

smithjd added a comment.


  In D16579#352788 , @smithjd wrote:
  
  > - Use the de-facto Album Artist field name for APE tags.
  >
  >   Since the discussion around this patch has also included the Album Artist 
field, add the changes required for this field to this review.
  
  
  Also adding that EasyTag uses the 'Album Artist' field name. Not sure about 
picard, but the above-linked documentation seems to suggest this.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
spoorun, ngraham, abrahams

D16579: Fix APE tag extraction

2018-11-02 Thread James Smith

smithjd retitled this revision from "Musepack disk number field name is DISC." 
to "Fix APE tag extraction".
smithjd edited the summary of this revision.
smithjd edited the test plan for this revision.
smithjd added a reviewer: mgallien.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
spoorun, ngraham, abrahams

D16579: Musepack disk number field name is DISC.

2018-11-02 Thread James Smith

smithjd updated this revision to Diff 44708.
smithjd added a comment.


  - Use the de-facto Album Artist field name for APE tags.
  
  Since the discussion around this patch has also included the Album Artist
  field, add the changes required for this field to this review.

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16579?vs=44638=44708

BRANCH
  master-musepackFixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16579

AFFECTED FILES
  autotests/samplefiles/test.ape
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.wv
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp

To: smithjd, astippich, bruns
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
spoorun, ngraham, abrahams

D16612: Connect slots explicitly instead of using auto-connections

2018-11-02 Thread Alexander Volkov

volkov added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16612

To: volkov, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16612: Connect slots explicitly instead of using auto-connections

2018-11-02 Thread Alexander Volkov

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Auto-connections is bad practice cause object renames break code
  and it can't be detected at compile time.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16612

AFFECTED FILES
  src/kcms/kio/cache.cpp
  src/kcms/kio/cache.h
  src/kcms/kio/kcookiesmanagement.cpp
  src/kcms/kio/kcookiesmanagement.h
  src/kcms/kio/kproxydlg.cpp
  src/kcms/kio/kproxydlg.h
  src/kcms/kio/useragentdlg.cpp
  src/kcms/kio/useragentdlg.h

To: volkov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16434: Fix keyboard layout change notifications

2018-11-02 Thread Roman Gilg

romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kglobalaccel_x11.cpp:96
>  if (!m_keySymbols) {
> -return false;
> +m_keySymbols = xcb_key_symbols_alloc(QX11Info::connection());
> +if (!m_keySymbols) {

Before there was a check to `QX11Info::isPlatformX11()`. Probably we don't need 
the check, but did you test on Wayland?

> kglobalaccel_x11.cpp:220
>  default:
> +if(m_xkb_first_event && responseType == m_xkb_first_event) {
> +const uint8_t xkbEvent = event->pad0;

case m_xkb_first_event:
  if (m_xkb_first_event) {
  ...
  }
  default:
  return false;

Or directly do the switching on `responseType` with if-else statements.

> kglobalaccel_x11.cpp:264
> + // Force reloading of the keySym mapping
> + m_keySymbols = nullptr;
> +

Might leak? Use `xcb_key_symbols_free`.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16434

To: fvogt, #frameworks, #plasma, romangg
Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, michaelh, bruns

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-11-02 Thread Fabian Vogt

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:3501660aa3d7: Add a QIconEnginePlugin to allow QIcon 
deserialization (authored by fvogt).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16305?vs=43893=44698

REVISION DETAIL
  https://phabricator.kde.org/D16305

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconengineplugin.cpp
  src/kiconengineplugin.json

To: fvogt, #frameworks, davidedmundson
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-11-02 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16305

To: fvogt, #frameworks, davidedmundson
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis

ndavis added a comment.


  In D16588#352554 , @ngraham wrote:
  
  > These are pretty darn good. They no longer have package-related 
iconography, but maybe that's okay and they never needed it in the first place. 
I can see how it would actually get in the way given how these icons are 
actually used.
  >
  > These icons are also used by Apper, which is a distro-agnostic KDE app you 
can try out to see how they look there.
  >
  > I'm inclined to give 'em a thumbs up, but let's see what other #VDG 
 folks think as well!
  
  
  Apper might be easier to test than Synaptic if it doesn't need to be run as 
root, so I'll check it out. I can't get Synaptic to change themes on the KDE 
Neon live image.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16588

To: ndavis, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16561: Remove unused variable

2018-11-02 Thread Sune Vuorela

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16561

To: aacid, svuorela
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16567: Remove unused variable

2018-11-02 Thread Sune Vuorela

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16567

To: aacid, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16569: Remove unused variable

2018-11-02 Thread Sune Vuorela

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16569

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16568: Remove unused variables

2018-11-02 Thread Sune Vuorela

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16568

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16571: Remove unused variable

2018-11-02 Thread Sune Vuorela

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16571

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16572: don't assign variable to itself

2018-11-02 Thread Sune Vuorela

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16572

To: aacid, svuorela
Cc: kde-frameworks-devel, mart, michaelh, ngraham, bruns

D16573: Remove unused variables

2018-11-02 Thread Sune Vuorela

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16573

To: aacid, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

1 2 >

1 - 100 of 102 matches

Mail list logo