D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#361317 , @ngraham wrote:
  
  > What about making the MMB turn white when it has the blue highlight?
  
  
  white MMB F642: Screenshot_20181118_005525.png 

  
  white MMB with slightly longer highlight next to right click icon with 
original highlight length F6430002: Screenshot_20181118_005628.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16951: Add mouse button icons

[Nathaniel Graham]

ngraham added a comment.


  What about making the MMB turn white when it has the blue highlight?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

[Nathaniel Graham]

ngraham added a comment.


  Why does this need a timer?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D16913

To: thsurrel, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#361294 , @ngraham wrote:
  
  > Much better shape!
  >
  > What do you think about making the mouse wheel detached from the top of the 
mouse so it looks more like a wheel and less like a notch? Then also you might 
not need to omit it from `input-mouse-click-middle`'
  
  
  It does look better on the other mouse icons, but the middle mouse button 
still needs to be covered by the blue highlight because otherwise the highlight 
is too difficult to see.
  
  detached MMB F6429945: Screenshot_20181118_001313.png 

  
  highlight under detached MMB F6429909: Screenshot_20181118_000942.png 

  
  slightly longer highlight under detached MMB F6429942: 
Screenshot_20181118_000920.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16951: Add mouse button icons

[Nathaniel Graham]

ngraham added a comment.


  Much better shape!
  
  What do you think about making the mouse wheel detached from the top of the 
mouse so it looks more like a wheel and less like a notch? Then also you might 
not need to omit it from `input-mouse-click-middle`'

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16852: Add Documents to the default list of Places

[Andrew Crouthamel]

acrouthamel added a comment.


  In D16852#360940 , 
@elvisangelaccio wrote:
  
  > @acrouthamel Please open another diff with your patch thats updates the 
dolphin test, so I can try easily try it out
  
  
  Ok, I created D16967 . Thanks!

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D16951: Add mouse button icons

[Andres Betts]

abetts added a comment.


  Looks good to me +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16852: Add Documents to the default list of Places

[Andrew Crouthamel]

acrouthamel added a dependent revision: D16967: Add Documents shortcut 
detection.

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis planned changes to this revision.
ndavis added a comment.


  Alright, that's 2 people in favor of a curved mouse. After all, we're not 
using Apple Macintoshes from the 80s.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16964: Change archive-* action icons to represent archives

[Noah Davis]

ndavis added a comment.


  In D16964#361253 , @ngraham wrote:
  
  > In D16964#361250 , @ndavis wrote:
  >
  > > zypper
  >
  >
  > Found the openSUSE user. :)
  
  
  LOL, I've gotten too used to openSUSE to speak normal english now.
  
  Anyway, here are the 16 and 22px mimetype icons for reference:
  
  16px F6429832: Screenshot_20181117_224651.png 

  
  22px F6429833: Screenshot_20181117_224710.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16964

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D16964: Change archive-* action icons to represent archives

[Nathaniel Graham]

ngraham added a comment.


  In D16964#361250 , @ndavis wrote:
  
  > zypper
  
  
  Found the openSUSE user. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16964

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D16964: Change archive-* action icons to represent archives

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  In D16964#361229 , @ngraham wrote:
  
  > Beautiful, just what I had in mind! Amazing what a little zipper will do. 
@ndavis, does this look good to you too?
  
  
  It's consistent with other icons associated with packages and archives. LGTM!

REPOSITORY
  R266 Breeze Icons

BRANCH
  change-archive-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16964

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, 
ngraham, bruns

D16951: Add mouse button icons

[Nathaniel Graham]

ngraham added a comment.


  +1 for more curves. That rectangle doesn't particular scream "I'm a mouse!" 
to me.
  
  `dialog-input-devices` itself is pretty lousy, honestly. It would also use a 
bit of sprucing up rather than copying its style.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16966: Fix typo in i18n message (cmdline option description)

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R290 KPackage

BRANCH
  opt-i18n

REVISION DETAIL
  https://phabricator.kde.org/D16966

AFFECTED FILES
  src/kpackagetool/options.h

To: aspotashev
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 13 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/13/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 17 Nov 2018 10:19:48 +
 Build duration:
14 hr and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D16964: Change archive-* action icons to represent archives

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16964

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16964: Change archive-* action icons to represent archives

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  change-archive-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16964

AFFECTED FILES
  icons-dark/actions/16/archive-extract.svg
  icons-dark/actions/16/archive-insert.svg
  icons-dark/actions/16/archive-remove.svg
  icons-dark/actions/22/archive-extract.svg
  icons-dark/actions/22/archive-insert.svg
  icons-dark/actions/22/archive-remove.svg
  icons-dark/actions/24/archive-extract.svg
  icons-dark/actions/24/archive-insert.svg
  icons-dark/actions/24/archive-remove.svg
  icons-dark/actions/32/archive-extract.svg
  icons-dark/actions/32/archive-insert.svg
  icons-dark/actions/32/archive-remove.svg
  icons/actions/16/archive-extract.svg
  icons/actions/16/archive-insert.svg
  icons/actions/16/archive-remove.svg
  icons/actions/22/archive-extract.svg
  icons/actions/22/archive-insert.svg
  icons/actions/22/archive-remove.svg
  icons/actions/24/archive-extract.svg
  icons/actions/24/archive-insert.svg
  icons/actions/24/archive-remove.svg
  icons/actions/32/archive-extract.svg
  icons/actions/32/archive-insert.svg
  icons/actions/32/archive-remove.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Increasing KF5 cmake requirement to 3.5?

[Albert Astals Cid]

El dissabte, 17 de novembre de 2018, a les 20:03:37 CET, Wolfgang Bauer va 
escriure:
> > -Original Message-
> > I'm going to suggest it to increase it to 3.6, it would still most
> probably be a lie
> > since i don't think any of use uses such an old (2 years version) either
> 
> We currently do still build the latest KDE Frameworks, Plasma, and
> Applications on/for openSUSE Leap 42.3 (plus latest Qt5) with cmake 3.5.2.

Ok, good, then maybe actually increase it to 3.5 only and it won't be a lie 
because the openSUSE people are using it :)

Cheers,
  albert

>  
> Only problem so far: discover started to use a new feature of cmake 3.6 in
> the latest (bugfix) version, namely the IMPORTED_TARGET option to
> pkg_checkmodule(), so the flatpak and fwupd backends are not built anymore
> with cmake 3.5.2. (cmake says "No package 'IMPORTED_TARGET' found")
> https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=d9ccf1d41fc3265ae
> e9e01eebbc090b163fefe07
> https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=2fe3d58fc652fc995
> 7f063cbbd0722dc1cf45730
> (we couldn't build the fwupd backend anyway though because fwupd is too old)
> 
> Kind Regards,
> Wolfgang
> 
> 
> 

Re: firewall-applet icons break breeze auto tests

[Noah Davis]

On Saturday, November 17, 2018 11:17:15 AM EST Albert Astals Cid wrote:
> El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah Davis va 
escriure:
> > On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote:
> > > Hi Noah,
> > > 
> > > At the moment breeze-icons auto tests are failing with this error (both
> > > for
> > > icons and icons-dark)
> > > 
> > > The following icons are not available in a scalable directory:
> > >   firewall-applet-shields_up
> > >   firewall-applet-panic
> > >   firewall-applet
> > >   firewall-applet-error
> > > 
> > > This is because the test makes sure that all icons present in a "Fixed
> > > size
> > > folder" (for apps 16, 22, 32) should be available in a "Scalable size
> > > folder" (for apps 48).
> > > 
> > > Could you please work in fixing that so the auto test starts passing
> > > again?
> > > 
> > > Cheers,
> > > 
> > >   Albert
> > 
> > Hi, I was notified about that on the Phabricator diff after it was landed
> > (https://phabricator.kde.org/D11880), but I didn't know what the error
> > meant or what to do about it. I would be glad to fix it if you or someone
> > else could help me figure out what to do.
> 
> I did tell you exactly what is the problem, didn't I?
> 
> *
> This is because the test makes sure that all icons present in a "Fixed size
> folder" (for apps 16, 22, 32) should be available in a "Scalable size
> folder" (for apps 48).
> *
> 
> Cheers,
>   Albert

I think I just don't understand the system. I think what's tripping me up is 
that some icon themes use a folder called "scalable" for SVGs and the other 
folders are used for PNGs, but Breeze doesn't do that because it only uses 
SVGs and SVGs are naturally scalable.

signature.asc
Description: This is a digitally signed message part.

D16963: Fix running kdoctools-install autotest without kdoctools installed

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Works, I'm not a kdoctools *real* expert so maybe you want to wait for 
someone else to approve, but i'd say just commit, i mean i don't think it's  
worse than what we have now and the test will pass which is always a good thing 
:)

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16963

To: habacker, aacid
Cc: asturmlechner, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, 
bruns, skadinna

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/76/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 20:36:21 +
 Build duration:
4 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 132 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/132/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 20:36:21 +
 Build duration:
1 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16934: Add help-browser symlink to 16px and 22px directories

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:ae50e26abbad: Add help-browser symlink to 16px and 22px 
directories (authored by trickyricky26, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16934?vs=45614=45693

REVISION DETAIL
  https://phabricator.kde.org/D16934

AFFECTED FILES
  icons-dark/apps/16/help-browser.svg
  icons-dark/apps/22/help-browser.svg
  icons/apps/16/help-browser.svg
  icons/apps/22/help-browser.svg

To: trickyricky26, #breeze, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/75/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 20:31:29 +
 Build duration:
4 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16934: Add help-browser symlink to 16px and 22px directories

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  This is a very simple change that doesn't need much reviewing. I see no 
reason not to land this now.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-help-browser-symlink (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16934

To: trickyricky26, #breeze, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/131/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 20:31:29 +
 Build duration:
1 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16905: Add new generic sorting icons; rename existing sorting icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:64b3a8fa6ff7: Add new generic sorting icons; rename 
existing sorting icons (authored by trickyricky26, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16905?vs=45689=45692

REVISION DETAIL
  https://phabricator.kde.org/D16905

AFFECTED FILES
  icons-dark/actions/16/sort-name.svg
  icons-dark/actions/16/view-sort-ascending-name.svg
  icons-dark/actions/16/view-sort-ascending.svg
  icons-dark/actions/16/view-sort-descending-name.svg
  icons-dark/actions/16/view-sort-descending.svg
  icons-dark/actions/16/view-sort.svg
  icons-dark/actions/22/sort-name.svg
  icons-dark/actions/22/view-sort-ascending-name.svg
  icons-dark/actions/22/view-sort-ascending.svg
  icons-dark/actions/22/view-sort-descending-name.svg
  icons-dark/actions/22/view-sort-descending.svg
  icons-dark/actions/22/view-sort.svg
  icons-dark/actions/24/sort-name.svg
  icons-dark/actions/24/view-sort-ascending-name.svg
  icons-dark/actions/24/view-sort-ascending.svg
  icons-dark/actions/24/view-sort-descending-name.svg
  icons-dark/actions/24/view-sort-descending.svg
  icons-dark/actions/24/view-sort.svg
  icons-dark/actions/32/view-sort-ascending-name.svg
  icons-dark/actions/32/view-sort-ascending.svg
  icons-dark/actions/32/view-sort-descending-name.svg
  icons-dark/actions/32/view-sort-descending.svg
  icons-dark/actions/32/view-sort.svg
  icons/actions/16/sort-name.svg
  icons/actions/16/view-sort-ascending-name.svg
  icons/actions/16/view-sort-ascending.svg
  icons/actions/16/view-sort-descending-name.svg
  icons/actions/16/view-sort-descending.svg
  icons/actions/16/view-sort.svg
  icons/actions/22/sort-name.svg
  icons/actions/22/view-sort-ascending-name.svg
  icons/actions/22/view-sort-ascending.svg
  icons/actions/22/view-sort-descending-name.svg
  icons/actions/22/view-sort-descending.svg
  icons/actions/22/view-sort.svg
  icons/actions/24/sort-name.svg
  icons/actions/24/view-sort-ascending-name.svg
  icons/actions/24/view-sort-ascending.svg
  icons/actions/24/view-sort-descending-name.svg
  icons/actions/24/view-sort-descending.svg
  icons/actions/24/view-sort.svg
  icons/actions/32/view-sort-ascending-name.svg
  icons/actions/32/view-sort-ascending.svg
  icons/actions/32/view-sort-descending-name.svg
  icons/actions/32/view-sort-descending.svg
  icons/actions/32/view-sort.svg

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons; rename existing sorting icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I will land this now. There's nothing left that needs to be done.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16963: Fix running kdoctools-install autotest without kdoctools installed

[Ralf Habacker]

habacker marked an inline comment as done.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D16963

To: habacker, aacid
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D16963: Fix running kdoctools-install autotest without kdoctools installed

[Ralf Habacker]

habacker updated this revision to Diff 45690.
habacker added a comment.


  - fix parallel builds

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16963?vs=45685=45690

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16963

AFFECTED FILES
  KF5DocToolsMacros.cmake
  autotests/CMakeLists.txt

To: habacker, aacid
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D16905: Add new generic sorting icons; rename existing sorting icons

[Noah Davis]

ndavis added a comment.


  In D16905#361148 , @trickyricky26 
wrote:
  
  > Ok I will change that, however the graphic on the Icons HIG Page 
(https://hig.kde.org/_images/Breeze-icon-design-5.png) says a inner size of 
28px which means 2px margins on each size. 
  >  So that graphic should be updated, or if the 4px margins only apply to 
action icons, that should be clearly stated in the text.
  >  I don't recall either of them being adressed in D16848: Revamp Icon Design 
and Emblem pages .
  
  
  Yes, our HIG still needs more work. My advice is that when you notice a broad 
inconsistency between what the HIG says and what actually exists, look at icons 
similar to what you're making and copy what you can from those. The exception 
here is with the new icon colors because they will not have a noticable 
difference in existing KDE apps where the color is changed by the colorscheme 
anyway.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons; rename existing sorting icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons; rename existing sorting icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 45689.
trickyricky26 added a comment.


  - Change margins to 4px in 32px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16905?vs=45684=45689

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

AFFECTED FILES
  icons-dark/actions/16/sort-name.svg
  icons-dark/actions/16/view-sort-ascending-name.svg
  icons-dark/actions/16/view-sort-ascending.svg
  icons-dark/actions/16/view-sort-descending-name.svg
  icons-dark/actions/16/view-sort-descending.svg
  icons-dark/actions/16/view-sort.svg
  icons-dark/actions/22/sort-name.svg
  icons-dark/actions/22/view-sort-ascending-name.svg
  icons-dark/actions/22/view-sort-ascending.svg
  icons-dark/actions/22/view-sort-descending-name.svg
  icons-dark/actions/22/view-sort-descending.svg
  icons-dark/actions/22/view-sort.svg
  icons-dark/actions/24/sort-name.svg
  icons-dark/actions/24/view-sort-ascending-name.svg
  icons-dark/actions/24/view-sort-ascending.svg
  icons-dark/actions/24/view-sort-descending-name.svg
  icons-dark/actions/24/view-sort-descending.svg
  icons-dark/actions/24/view-sort.svg
  icons-dark/actions/32/view-sort-ascending-name.svg
  icons-dark/actions/32/view-sort-ascending.svg
  icons-dark/actions/32/view-sort-descending-name.svg
  icons-dark/actions/32/view-sort-descending.svg
  icons-dark/actions/32/view-sort.svg
  icons/actions/16/sort-name.svg
  icons/actions/16/view-sort-ascending-name.svg
  icons/actions/16/view-sort-ascending.svg
  icons/actions/16/view-sort-descending-name.svg
  icons/actions/16/view-sort-descending.svg
  icons/actions/16/view-sort.svg
  icons/actions/22/sort-name.svg
  icons/actions/22/view-sort-ascending-name.svg
  icons/actions/22/view-sort-ascending.svg
  icons/actions/22/view-sort-descending-name.svg
  icons/actions/22/view-sort-descending.svg
  icons/actions/22/view-sort.svg
  icons/actions/24/sort-name.svg
  icons/actions/24/view-sort-ascending-name.svg
  icons/actions/24/view-sort-ascending.svg
  icons/actions/24/view-sort-descending-name.svg
  icons/actions/24/view-sort-descending.svg
  icons/actions/24/view-sort.svg
  icons/actions/32/view-sort-ascending-name.svg
  icons/actions/32/view-sort-ascending.svg
  icons/actions/32/view-sort-descending-name.svg
  icons/actions/32/view-sort-descending.svg
  icons/actions/32/view-sort.svg

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons; rename existing sorting icons

[TrickyRicky]

trickyricky26 added a comment.


  Ok I will change that, however the graphic on the Icons HIG Page 
(https://hig.kde.org/_images/Breeze-icon-design-5.png) says a inner size of 
28px which means 2px margins on each size. 
  So that graphic should be updated, or if the 4px margins only apply to action 
icons, that should be clearly stated in the text.
  I don't recall either of them being adressed in D16848: Revamp Icon Design 
and Emblem pages .

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons; rename existing sorting icons

[Noah Davis]

ndavis added a comment.


  The margins on the 32px icons are different from other 32px icons. The 
existing ones use a 4px margin on each side.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

RE: Increasing KF5 cmake requirement to 3.6?

[Wolfgang Bauer]

> -Original Message-
> I'm going to suggest it to increase it to 3.6, it would still most
probably be a lie
> since i don't think any of use uses such an old (2 years version) either

We currently do still build the latest KDE Frameworks, Plasma, and
Applications on/for openSUSE Leap 42.3 (plus latest Qt5) with cmake 3.5.2.
 
Only problem so far: discover started to use a new feature of cmake 3.6 in
the latest (bugfix) version, namely the IMPORTED_TARGET option to
pkg_checkmodule(), so the flatpak and fwupd backends are not built anymore
with cmake 3.5.2. (cmake says "No package 'IMPORTED_TARGET' found")
https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=d9ccf1d41fc3265ae
e9e01eebbc090b163fefe07
https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=2fe3d58fc652fc995
7f063cbbd0722dc1cf45730
(we couldn't build the fwupd backend anyway though because fwupd is too old)

Kind Regards,
Wolfgang

D16963: Fix running kdoctools-install autotest without kdoctools installed

[Albert Astals Cid]

aacid added a comment.


  Cool test passes now, **BUT** see comment

INLINE COMMENTS

> KF5DocToolsMacros.cmake:205
>  set(_bootstrapOption "--srcdir=${KDocTools_BINARY_DIR}/src")
> -set(_extraDependency "docbookl10nhelper")
>  elseif (CMAKE_CROSSCOMPILING AND CMAKE_SYSTEM_NAME STREQUAL "Windows")

We need to figure a way to fix it without removing this line, since this is a 
fix i did to fix parallel builds (see git log). Or we need to find another way 
to fix parallel builds :D

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D16963

To: habacker, aacid
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D16905: Add new generic sorting icons; rename existing sorting icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 45684.
trickyricky26 added a comment.


  - Remove old sort.svg icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16905?vs=45667=45684

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

AFFECTED FILES
  icons-dark/actions/16/sort-name.svg
  icons-dark/actions/16/view-sort-ascending-name.svg
  icons-dark/actions/16/view-sort-ascending.svg
  icons-dark/actions/16/view-sort-descending-name.svg
  icons-dark/actions/16/view-sort-descending.svg
  icons-dark/actions/16/view-sort.svg
  icons-dark/actions/22/sort-name.svg
  icons-dark/actions/22/view-sort-ascending-name.svg
  icons-dark/actions/22/view-sort-ascending.svg
  icons-dark/actions/22/view-sort-descending-name.svg
  icons-dark/actions/22/view-sort-descending.svg
  icons-dark/actions/22/view-sort.svg
  icons-dark/actions/24/sort-name.svg
  icons-dark/actions/24/view-sort-ascending-name.svg
  icons-dark/actions/24/view-sort-ascending.svg
  icons-dark/actions/24/view-sort-descending-name.svg
  icons-dark/actions/24/view-sort-descending.svg
  icons-dark/actions/24/view-sort.svg
  icons-dark/actions/32/view-sort-ascending-name.svg
  icons-dark/actions/32/view-sort-ascending.svg
  icons-dark/actions/32/view-sort-descending-name.svg
  icons-dark/actions/32/view-sort-descending.svg
  icons-dark/actions/32/view-sort.svg
  icons/actions/16/sort-name.svg
  icons/actions/16/view-sort-ascending-name.svg
  icons/actions/16/view-sort-ascending.svg
  icons/actions/16/view-sort-descending-name.svg
  icons/actions/16/view-sort-descending.svg
  icons/actions/16/view-sort.svg
  icons/actions/22/sort-name.svg
  icons/actions/22/view-sort-ascending-name.svg
  icons/actions/22/view-sort-ascending.svg
  icons/actions/22/view-sort-descending-name.svg
  icons/actions/22/view-sort-descending.svg
  icons/actions/22/view-sort.svg
  icons/actions/24/sort-name.svg
  icons/actions/24/view-sort-ascending-name.svg
  icons/actions/24/view-sort-ascending.svg
  icons/actions/24/view-sort-descending-name.svg
  icons/actions/24/view-sort-descending.svg
  icons/actions/24/view-sort.svg
  icons/actions/32/view-sort-ascending-name.svg
  icons/actions/32/view-sort-ascending.svg
  icons/actions/32/view-sort-descending-name.svg
  icons/actions/32/view-sort-descending.svg
  icons/actions/32/view-sort.svg

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16963: Fix running kdoctools-install autotest without kdoctools installed

[Ralf Habacker]

habacker added a reviewer: aacid.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D16963

To: habacker, aacid
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D16963: Fix running kdoctools-install autotest without kdoctools installed

[Ralf Habacker]

habacker created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
habacker requested review of this revision.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16963

AFFECTED FILES
  KF5DocToolsMacros.cmake
  autotests/CMakeLists.txt

To: habacker
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D16905: Add new generic sorting icons; rename existing sorting icons

[TrickyRicky]

trickyricky26 added a comment.


  That was not supposed to be there anymore after we changed the name. I'm 
going to remove `sort.svg`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons; rename existing sorting icons

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  `sort.svg` uses the older version of your style. Make it a relative symlink 
to `view-sort.svg`.
  F6429080: Screenshot_20181117_130528.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons; rename existing sorting icons

[Noah Davis]

ndavis added a comment.


  Great! That will work.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons; rename existing sorting icons

[TrickyRicky]

trickyricky26 retitled this revision from "Add new generic sorting icons and 
rename existing alphabetic sorting icons to -name scheme" to "Add new generic 
sorting icons; rename existing sorting icons".

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Noah Davis]

ndavis added a comment.


  See if yo can shorten the title down to 50 characters and if not that, see if 
you can get it down to below 80.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  Unless someone has a final request, I think this is ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

Increasing KF5 cmake requirement to 3.6?

[Albert Astals Cid]

The KF5 minimum cmake requirement sits at 3.0

I doubt anyone is using that to build KF5 so it's a bit of a "lie".

I'm going to suggest it to increase it to 3.6, it would still most probably be 
a lie since i don't think any of use uses such an old (2 years version) either, 
but it'll be a smaller lie, and if we look at the cross section of distros that 
ship Qt 5.9[1] (current minimum requirement) and their cmake versions[2], 
Scientific Linux is the one shipping an oldest cmake and it's 3.6.3.

What do you think?

Cheers,
  Albert

[1] https://repology.org/metapackage/qt5-base/badges
[2] https://repology.org/metapackage/cmake/badges

D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Good find. No idea why it was not like this from the start.
  
  Untested (besides grepping my local Qt 5.11 CMake Config files to confirm 
myself that's really the place where the imported target is added), but given 
you tested pretty sure this is a proper fix. Thanks.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  find-qhelpgenerator-target

REVISION DETAIL
  https://phabricator.kde.org/D16938

To: pino, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

Re: firewall-applet icons break breeze auto tests

[Albert Astals Cid]

El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah Davis va escriure:
> On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote:
> > Hi Noah,
> > 
> > At the moment breeze-icons auto tests are failing with this error (both for
> > icons and icons-dark)
> > 
> > The following icons are not available in a scalable directory:
> >   firewall-applet-shields_up
> >   firewall-applet-panic
> >   firewall-applet
> >   firewall-applet-error
> > 
> > This is because the test makes sure that all icons present in a "Fixed size
> > folder" (for apps 16, 22, 32) should be available in a "Scalable size
> > folder" (for apps 48).
> > 
> > Could you please work in fixing that so the auto test starts passing again?
> > 
> > Cheers,
> >   Albert
> 
> Hi, I was notified about that on the Phabricator diff after it was landed 
> (https://phabricator.kde.org/D11880), but I didn't know what the error meant 
> or what to do about it. I would be glad to fix it if you or someone else 
> could 
> help me figure out what to do.

I did tell you exactly what is the problem, didn't I?

*
This is because the test makes sure that all icons present in a "Fixed size
folder" (for apps 16, 22, 32) should be available in a "Scalable size
folder" (for apps 48).
*

Cheers,
  Albert

Re: firewall-applet icons break breeze auto tests

[Noah Davis]

On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote:
> Hi Noah,
> 
> At the moment breeze-icons auto tests are failing with this error (both for
> icons and icons-dark)
> 
> The following icons are not available in a scalable directory:
>   firewall-applet-shields_up
>   firewall-applet-panic
>   firewall-applet
>   firewall-applet-error
> 
> This is because the test makes sure that all icons present in a "Fixed size
> folder" (for apps 16, 22, 32) should be available in a "Scalable size
> folder" (for apps 48).
> 
> Could you please work in fixing that so the auto test starts passing again?
> 
> Cheers,
>   Albert

Hi, I was notified about that on the Phabricator diff after it was landed 
(https://phabricator.kde.org/D11880), but I didn't know what the error meant 
or what to do about it. I would be glad to fix it if you or someone else could 
help me figure out what to do.

signature.asc
Description: This is a digitally signed message part.

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 updated this revision to Diff 45667.
trickyricky26 added a comment.


  - Switch arrow directions in ascending and descending variants

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16905?vs=45611=45667

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

AFFECTED FILES
  icons-dark/actions/16/sort-name.svg
  icons-dark/actions/16/sort.svg
  icons-dark/actions/16/view-sort-ascending-name.svg
  icons-dark/actions/16/view-sort-ascending.svg
  icons-dark/actions/16/view-sort-descending-name.svg
  icons-dark/actions/16/view-sort-descending.svg
  icons-dark/actions/16/view-sort.svg
  icons-dark/actions/22/sort-name.svg
  icons-dark/actions/22/sort.svg
  icons-dark/actions/22/view-sort-ascending-name.svg
  icons-dark/actions/22/view-sort-ascending.svg
  icons-dark/actions/22/view-sort-descending-name.svg
  icons-dark/actions/22/view-sort-descending.svg
  icons-dark/actions/22/view-sort.svg
  icons-dark/actions/24/sort-name.svg
  icons-dark/actions/24/view-sort-ascending-name.svg
  icons-dark/actions/24/view-sort-ascending.svg
  icons-dark/actions/24/view-sort-descending-name.svg
  icons-dark/actions/24/view-sort-descending.svg
  icons-dark/actions/24/view-sort.svg
  icons-dark/actions/32/view-sort-ascending-name.svg
  icons-dark/actions/32/view-sort-ascending.svg
  icons-dark/actions/32/view-sort-descending-name.svg
  icons-dark/actions/32/view-sort-descending.svg
  icons-dark/actions/32/view-sort.svg
  icons/actions/16/sort-name.svg
  icons/actions/16/sort.svg
  icons/actions/16/view-sort-ascending-name.svg
  icons/actions/16/view-sort-ascending.svg
  icons/actions/16/view-sort-descending-name.svg
  icons/actions/16/view-sort-descending.svg
  icons/actions/16/view-sort.svg
  icons/actions/22/sort-name.svg
  icons/actions/22/sort.svg
  icons/actions/22/view-sort-ascending-name.svg
  icons/actions/22/view-sort-ascending.svg
  icons/actions/22/view-sort-descending-name.svg
  icons/actions/22/view-sort-descending.svg
  icons/actions/22/view-sort.svg
  icons/actions/24/sort-name.svg
  icons/actions/24/view-sort-ascending-name.svg
  icons/actions/24/view-sort-ascending.svg
  icons/actions/24/view-sort-descending-name.svg
  icons/actions/24/view-sort-descending.svg
  icons/actions/24/view-sort.svg
  icons/actions/32/view-sort-ascending-name.svg
  icons/actions/32/view-sort-ascending.svg
  icons/actions/32/view-sort-descending-name.svg
  icons/actions/32/view-sort-descending.svg
  icons/actions/32/view-sort.svg

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16857: Do not disconnect all StorageAccess signals when unmounting

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:e710a6431160: Do not disconnect all StorageAccess signals 
when unmounting (authored by thsurrel).

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16857?vs=45400=45665

REVISION DETAIL
  https://phabricator.kde.org/D16857

AFFECTED FILES
  src/panels/places/placesitemmodel.cpp

To: thsurrel, #dolphin, #frameworks, bruns, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, sourabhboss, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D16927: KTextEditor : disconnect contextmenu from all aboutToXXContextMenu receivers

[René J . V . Bertin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:3f0c617e22ab: disconnect contextmenu from all 
aboutToXXContextMenu receivers (authored by rjvbb).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16927?vs=45597=45664#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16927?vs=45597=45664

REVISION DETAIL
  https://phabricator.kde.org/D16927

AFFECTED FILES
  src/view/kateview.cpp

To: rjvbb, #ktexteditor, #frameworks, cullmann
Cc: cullmann, kde-frameworks-devel, kwrite-devel, michaelh, ngraham, bruns, 
demsking, head7, kfunk, sars, dhaumann

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/10/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 17 Nov 2018 11:23:28 +
 Build duration:
2 hr 8 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#360965 , @rizzitello 
wrote:
  
  > I think the Mouse itself needs a bit more curve with less box.
  
  
  I kind of agree. I was just copying the existing `dialog-input-devices` icon, 
but I suppose I could change that as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: rizzitello, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

[Chris Rizzitello]

rizzitello added a comment.


  I think the Mouse itself needs a bit more curve with less box.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: rizzitello, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb added a comment.


  In case anyone wonders why this has gone undetected: I think because of an 
undocumented feature, the fact `aboutToShowContextMenu` was called for all 
views. Indeed, with the KTextEditor fix in place the duplication issue occurs 
also without loading the CTags plugin (= with stock KDevelop code).

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau
Cc: kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, 
iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16852: Add Documents to the default list of Places

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @acrouthamel Please open another diff with your patch thats updates the 
dolphin test, so I can try easily try it out

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Noah Davis]

ndavis added a comment.


  In D16905#360938 , @trickyricky26 
wrote:
  
  > I am sure that in ascending, the lines get longer further down 
(representing larger file sizes etc.). The thing I am not quite sure about is 
the direction of the arrows.
  
  
  I would say make the direction of the arrows match the `view-sort-*-name` 
icons. This way existing users won't be confused.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[TrickyRicky]

trickyricky26 added a comment.


  I am sure that in ascending, the lines get longer further down (representing 
larger file sizes etc.). The thing I am not quite sure about is the direction 
of the arrows.
  
  In D16905#360524 , @cfeck wrote:
  
  > On lists that are sorted alphabetically A-Z (i.e. ascending), the first 
item is at the top, the last at the bottom. That's why user interfaces show an 
arrow pointing down; they show the direction of item "flow".
  
  
  According to this, on ascending (alphabetically a-z) sorted lists, the arrows 
points downwards to indicate the flow. 
  If this is correct, the new icons show the correct arrow direction, while the 
existing alphabetical sorting icons have this backwards.
  Perhaps they need to be changed in that regard, however I think this might be 
beyond the scope of this revision.
  
  Looking around the internet, quite some icons have arrows always pointing 
downwards, regardless of the sorting direction; I think this is the worst 
solution as the arrow does not provide any meaning.
  The La Capitaine icons have the same alphabetic icons as we do with the arrow 
pointing upwards in ascending versions; their generic sorting icons have the 
arrow pointing downwards in ascending versions.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D7700: Show list of tags in PlacesView

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> kfileplacesmodel.h:66
> +UnknownType,
> +TagsType
>  };

This is missing a `///< @since 5.53` comment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7700

To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham
Cc: kde-frameworks-devel, bruns, rkflx, mmustac, spoorun, michaelh, renatoo, 
anthonyfieroni, cfeck, elvisangelaccio, emmanuelp, ngraham, alexeymin, 
#dolphin, alexde, sourabhboss, feverfew, navarromorales, firef, andrebarros, 
mikesomov

D16927: KTextEditor : disconnect contextmenu from all aboutToXXContextMenu receivers

[Christoph Cullmann]

cullmann added a comment.


  You are right. Please add some comment why one disconnects all things and 
push it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16927

To: rjvbb, #ktexteditor, #frameworks, cullmann
Cc: cullmann, kde-frameworks-devel, kwrite-devel, michaelh, ngraham, bruns, 
demsking, head7, kfunk, sars, dhaumann

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

[Noah Davis]

ndavis added a comment.


  In D16905#360586 , @trickyricky26 
wrote:
  
  > - Fix naming of ascending and descending versions; make ascending versions 
less confusing; fix symlink sort-name
  >
  >   I have flipped the naming of the ascending and descending versions to be 
correct. The arrow in the ascending versions is now always at the top and does 
not cut off lines. The symbolic link `sort-name` was changed from 
`view-sort-ascending` to `view-sort-ascending-name`
  
  
  I hate to have you going back and forth, but are you (and anyone who 
suggested you do this) sure that this is right?
  F6428508: Screenshot_20181117_064300.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  add-sort-options-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16905

To: trickyricky26, #vdg, #breeze, ndavis
Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 27 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/27/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 11:23:28 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)82%
(14/17)82%
(14/17)45%
(1596/3580)36%
(710/1999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)68%
(255/377)49%
(71/144)src.imageformats91%
(10/11)91%
(10/11)44%
(1337/3069)35%
(637/1797)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/41/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 10:21:25 +
 Build duration:
1 hr 12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7099/9494)55%
(3475/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(773/1377)45%
(294/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 84 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/84/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 10:21:13 +
 Build duration:
1 hr 8 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(237/257)92%
(237/257)87%
(25549/29250)54%
(10142/18852)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(12000/12073)50%
(6361/12625)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(72/73)99%
(72/73)85%
(5919/6972)65%
(1538/2376)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(116/116)100%
(116/116)87%
(7196/8259)67%
(2074/3092)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/33/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 11:23:28 +
 Build duration:
1 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1467/3578)32%
(642/1999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(265/377)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1198/3067)32%
(568/1797)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 66 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/66/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 10:20:01 +
 Build duration:
1 hr 1 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(18/19)95%
(18/19)72%
(1538/2132)51%
(1075/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(537/539)51%
(243/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(558/755)64%
(598/935)src.kpackage.private100%
(6/6)100%
(6/6)79%
(284/358)49%
(96/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/26/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 10:18:42 +
 Build duration:
1 hr 1 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)82%
(14/17)82%
(14/17)45%
(1613/3581)36%
(715/1999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(272/378)53%
(76/144)src.imageformats91%
(10/11)91%
(10/11)44%
(1337/3069)35%
(637/1797)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

D16857: Do not disconnect all StorageAccess signals when unmounting

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  Thanks, this fixes the bug for me.
  
  I think we can ship it on the stable branch (`Applications/18.12`)

REPOSITORY
  R318 Dolphin

BRANCH
  arc_remount_local (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16857

To: thsurrel, #dolphin, #frameworks, bruns, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, sourabhboss, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/50/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 10:17:15 +
 Build duration:
56 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45961)38%
(13184/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5599/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

kdoctools test if running uninstalled

[Albert Astals Cid]

Hey Ralf, 

the kdoctools_install test fails when running uninstalled (i.e. like how CI 
does) since it can't find kf5/kdoctools/customization

I tried to make it work but doesn't seem it's going to be easy since meinproc 
really looks for the "kf5/kdoctools/customization" hierarchy that is nowhere to 
be found in the build dir.

Maybe we should disable this test meanwhile? Or only run it if you have 
kdoctools installed? (like most of us do?).

Cheers,
  Albert

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/72/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 10:16:45 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8431)43%
(10151/23425)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5802/11905)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D16954: Add find module for Google's libphonenumber

[Volker Krause]

vkrause created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This is currently in use by plasma-phone-components, but will also be
  needed by KItinerary.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16954

AFFECTED FILES
  find-modules/FindPhoneNumber.cmake

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb edited the summary of this revision.
rjvbb edited the test plan for this revision.
rjvbb set the repository for this revision to R32 KDevelop.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau
Cc: kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, 
iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/74/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 17 Nov 2018 10:15:27 +
 Build duration:
50 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb updated this revision to Diff 45642.
rjvbb added a comment.


  New patch, same purpose, active principle as outlined in the reopening 
comment.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16882?vs=45471=45642

REVISION DETAIL
  https://phabricator.kde.org/D16882

AFFECTED FILES
  kdevplatform/shell/textdocument.cpp

To: rjvbb, #kdevelop, kossebau
Cc: kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, 
iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 263 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/263/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 10:53:33 +
 Build duration:
5 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13119)19%
(1820/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3490)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(300/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb reclaimed this revision.
rjvbb added a comment.
This revision now requires changes to proceed.


  Re-opening because I found an actual flaw in KDevelop after noticing that 
context menu duplication still occurred when only the active view receives the 
aboutToShowContextMenu signal.
  
  The `addedContextMenu` member exists because `"we want to remove the added 
stuff when the menu hides"`. This should of course read "when the menu reopens 
in again, possibly in a different view".
  The flaw here is that the design forgets that the context menu instance is 
shared among views. It expects `d->addedContextMenu` to exist and contain the 
QMenu added by a previous view, but this cannot be the case in the current 
implementation where the variable is only allocated when the menu is first 
opened in a given view.
  If the `addedContextMenu` is to be removed in JIT-fashion before reopening 
the context menu, it should be a static variable.
  
  Fix upcoming.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau
Cc: kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, 
iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 262 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/262/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 10:22:00 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13119)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3490)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/53/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 10:21:25 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7101/9494)55%
(3475/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(774/1377)45%
(293/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3315/4657)60%
(1917/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/76/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 10:17:15 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kglobalsettingstestFailed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21591/45958)38%
(13041/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11358/11759)50%
(7169/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(747/9693)6%
(325/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

firewall-applet icons break breeze auto tests

[Albert Astals Cid]

Hi Noah,

At the moment breeze-icons auto tests are failing with this error (both for 
icons and icons-dark)

The following icons are not available in a scalable directory:
  firewall-applet-shields_up
  firewall-applet-panic
  firewall-applet
  firewall-applet-error

This is because the test makes sure that all icons present in a "Fixed size 
folder" (for apps 16, 22, 32) should be available in a "Scalable size folder" 
(for apps 48).

Could you please work in fixing that so the auto test starts passing again?

Cheers,
  Albert

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/32/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 10:18:42 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1484/3579)32%
(647/1999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(282/378)53%
(77/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1198/3067)32%
(568/1797)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

D16951: Add mouse button icons

[Noah Davis]

ndavis added a subscriber: nicolasfella.
ndavis added a comment.


  @nicolasfella Will these work for you? Let me know if you need thumb buttons 
as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/67/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 10:17:45 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

D16934: Add help-browser symlink to 16px and 22px directories

[TrickyRicky]

trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16934

To: trickyricky26, #breeze, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/128/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 10:16:45 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6331/8431)43%
(10151/23429)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D16951: Add mouse button icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Add left, middle and right click icons for KDE Connect
  
  FEATURE: 399295
  FIXED-IN: 5.53

REPOSITORY
  R266 Breeze Icons

BRANCH
  mouse-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/22/input-mouse-click-left.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-right.svg
  icons/actions/16/input-mouse-click-left.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-right.svg
  icons/actions/22/input-mouse-click-left.svg
  icons/actions/22/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-right.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 15 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/15/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 17 Nov 2018 10:16:03 +
 Build duration:
8 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 130 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/130/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 17 Nov 2018 10:15:28 +
 Build duration:
4 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

Frameworks minimum Qt version raised to 5.9

[Albert Astals Cid]

I just executed the policy that says last three Qt versions, i.e. 5.9, 5.10 and 
5.11

Cheers,
  Albert

D16949: Support for TLS 1.3 (part of Qt 5.12)

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16949

AFFECTED FILES
  src/core/ktcpsocket.cpp
  src/core/ktcpsocket.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16946: Port more search providers to HTTPS

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Those are mostly services with more complex URLs changes than just adding
  the extra 's' to get to HTTPS. The exception is ethicle.com which redirects
  to ecosia.com without supporting HTTPS itself, so just merge their desktop
  files.
  
  There are still a few ones left not using HTTPS now, but those services
  actually seem to not support that at all. Do we want to support such
  insecure services here at all?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16946

AFFECTED FILES
  src/urifilters/ikws/searchproviders/ecosia.desktop
  src/urifilters/ikws/searchproviders/ethicle.desktop
  src/urifilters/ikws/searchproviders/metacrawler.desktop
  src/urifilters/ikws/searchproviders/nl-teletekst.desktop
  src/urifilters/ikws/searchproviders/pgpkeys.desktop
  src/urifilters/ikws/searchproviders/php.desktop
  src/urifilters/ikws/searchproviders/rag.desktop
  src/urifilters/ikws/searchproviders/thesaurus.desktop
  src/urifilters/ikws/searchproviders/webster.desktop

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16929: Remove dead search provider

[Volker Krause]

vkrause updated this revision to Diff 45632.
vkrause added a comment.


  Restore dictfr.desktop, that actually still works, just not with HTTPS.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16929?vs=45609=45632

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16929

AFFECTED FILES
  src/urifilters/ikws/searchproviders/dmoz.desktop
  src/urifilters/ikws/searchproviders/ibl.desktop

To: vkrause
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D16929: Remove dead search provider

[Volker Krause]

vkrause added a comment.


  In D16929#360646 , @cgiboudeaux 
wrote:
  
  > In D16929#360570 , @vkrause 
wrote:
  >
  > > Remove more dead search providers, just checking for non-resolving 
domains isn't enough.
  >
  >
  > mmh.. http://www.cnrtl.fr/definition/$something works fine here
  
  
  Indeed, thanks for checking!
  My browser history suggests I had a typo in the URL when manually verifying 
the results of my test script, which reported issues with that site due to it 
not supporting TLS.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16929

To: vkrause
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns