D17090: Use append instead of operator+= when appending to an QVector

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17090

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  LGTM; just a minor change needed.

INLINE COMMENTS

> basicindexingjob.cpp:153
> +//{"application/vnd.ms-excel", Type::Document},
> +//{"application/vnd.ms-excel", Type::Spreadsheet},
>  // Office 2007

Remove instead of committing commented out code?

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17089

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 333 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/333/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Nov 2018 05:22:14 +
 Build duration:
5 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32087/59993)38%
(16573/44016)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9105/9545)48%
(4277/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8366/14294)51%
(4680/9249)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3898/7946)34%
(1605/4741)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1034)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4293)35%
(1305/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%
(682/1356)42%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 332 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/332/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 21 Nov 2018 07:03:44 +
 Build duration:
22 hr and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiocore-threadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)54%
(32272/59992)38%
(1/43998)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(56/57)98%
(56/57)95%
(9074/9544)48%
(4269/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8376/14294)51%
(4683/9249)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3897/7945)34%
(1604/4739)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1019)37%
(315/852)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4293)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%
  

D17084: Prolog & Lua: fix shebang

[Nibaldo González]

nibags updated this revision to Diff 45991.
nibags added a comment.


  - Add tests

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17084?vs=45973=45991

BRANCH
  fix-shebang

REVISION DETAIL
  https://phabricator.kde.org/D17084

AFFECTED FILES
  autotests/folding/test.prolog.fold
  autotests/html/test.prolog.html
  autotests/input/test.prolog
  autotests/reference/test.prolog.ref
  data/syntax/lua.xml
  data/syntax/prolog.xml

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17086: Add icons for application-vnd.appimage

[Nathaniel Graham]

ngraham added a comment.


  That reasoning makes sense. Currently AppImages get the generic 
`application-x-executable` which isn't great:
  
  F6436057: Screenshot_20181121_193014.png 

  
  The document motif isn't really accurate here, but it's also used by other 
executables such as Java apps:
  
  F6436059: Screenshot_20181121_193200.png 

  
  We have two options here:
  
  1. Follow the style and make the AppImage icon look like a document with a 
folded-over corner that has an the AppImage logo  in the middle
  2. Engage #VDG  and Come up a new icon 
style for executables, and then make the AppImage icon in that new style
  
  Either way, I think we're going to do #2 and define a new style for 
executable apps: https://bugs.kde.org/show_bug.cgi?id=401299. Feel free to do 
#1 for now if you'd rather not wait for the outcome of that. Or wait if you'd 
like, which is fine too!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17079: Provide a qqc2/kirigami-based about page

[Nathaniel Graham]

ngraham added a comment.


  Cool!
  
  For this design, I'd like to get rid of the tabs and put everything in a 
scrollview. We generally have enough space that a tabbed view is overkill.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17091: Remove ununsed wdfInc parameter for addTerm and addPositionTerm

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  wdf (word frequency) is neither saved to the database nor used anywhere
  else. It is also not tested, and has no documented semantics.
  
  Remove add*BoolTerm(), as it is identical to add*Term() after the change.
  
  This change affects the API and ABI of libKF5BalooEngine, but it is an
  internal library interface only used by libKF5Baloo. Only the latter
  is exported.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17091

AFFECTED FILES
  src/engine/document.cpp
  src/engine/document.h
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/file/basicindexingjob.cpp
  src/file/extractor/result.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17090: Use append instead of operator+= when appending to an QVector

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  operator+= could easily be taken for an algebraic addition, whereas the
  meaning of append is obvious.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17090

AFFECTED FILES
  src/engine/document.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The mimetype is matched with "powerpoint" and "excel" already, no need
  to add it to the list a second time.
  This has no influence on DB contents, as adding a term is idempotent, but
  makes the QHash here and the returned QVector slightly smaller.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17089

AFFECTED FILES
  src/file/basicindexingjob.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol updated this revision to Diff 45984.
apol added a comment.


  Make new constructors explicit

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17078?vs=45964=45984

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17078

AFFECTED FILES
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: apol, #frameworks, dfaure
Cc: mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Michael Pyne]

mpyne added a comment.


  In D17078#363886 , @apol wrote:
  
  > In D17078#363772 , 
@anthonyfieroni wrote:
  >
  > > You can't change parameters in methods or constructors, it's a BIC.
  >
  >
  > https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
  
  
  To be clear, it is possible to have a change in default values be BIC (as the 
page describes). The updated code has to still work in compatible fashion if 
called with old default values (if any), since that is what existing 
application binaries would have used.
  
  There weren't default values before and even if there were, there's no change 
in behavior in the methods, so this change would be BC. From a source compat 
perspective, the changes made here do result in `KAboutData` becoming 
implicitly constructible when it wasn't before, which we may not want. Then 
again, maybe we do?

INLINE COMMENTS

> kaboutdata.h:551
>   */
> -KAboutData(const QString ,
> -   const QString ,
> -   const QString 
> +KAboutData(const QString  = {},
> +   const QString  = {},

Do we want to make this constructor `explicit` since the new default values now 
make it possible to construct a `KAboutData` with no parameters at all?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks, dfaure
Cc: mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol added a comment.


  In D17079#363906 , @ltoscano wrote:
  
  > That's a great idea! Would it be possible:
  >
  > - to also (optionally) support the translators' information, like in the 
current about box? (probably in a future patch, but maybe some groundwork is 
needed here)
  
  
  Yes, I actually forgot to add it, it's basically a matter of replicating the 
authors bit but instead of calling .authors, we call .translators. Actually we 
should do the same for contributors too.
  
  > - to move this about page to some common kirigami-addons library?
  
  We would have to look into it, we don't want to have kirigami depend on 
kcoreaddons, but we can easily allow applications that don't use kcoreaddons to 
pass a json object that looks like KAboutData instance (duck typing!).
  Otherwise, we could also move it to kdeclarative or have kcoreaddons install 
it.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: broulik, TheAssassin, azubieta.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The current CMake Config file of libappimage does not specify any
  imported target nameed "appimage". Instead it provides a shared lib
  target "libappimage" and a static lib target "libappimage_static".
  Both though are also broken in that they have targets to further
  dependencies in their link list, which though are only defined in the
  internal build system, but not provided with the installed CMake Config
  file.
  
  Additionally the LIBAPPIMAGE_INCLUDE_DIRS is currently not set,
  https://github.com/AppImage/libappimage/pull/17 hopefully fixes this
  for future versions.
  
  The previous simple "appimage" only worked if libappimage was installed
  to an otherwise known prefix, so include dirs and library paths were among
  the ones considered, and the linker would find libappimage via -lappimage.

TEST PLAN
  Building against current version of libappimage installed to custom prefix
  works, as well as building against the patched version.

REPOSITORY
  R320 KIO Extras

BRANCH
  fixappimagelinking

REVISION DETAIL
  https://phabricator.kde.org/D17088

AFFECTED FILES
  thumbnail/CMakeLists.txt

To: kossebau, broulik, TheAssassin, azubieta
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D16867: Don't generate appstream data for files that lack a description

[Rik Mills]

rikmills added a comment.


  And we have a casualty from this ;)
  
  Marble 18.12 branch:
  
  >   CMake Warning at 
/usr/lib/x86_64-linux-gnu/cmake/KF5Package/KF5PackageMacros.cmake:68 (message):
  >couldn't generate metainfo for org.kde.plasma.worldmap: Package type
  >"Plasma/Wallpaper" not found
  >
  >Error: description missing, will result in broken appdata field as
  > is mandatory.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D16867

To: apol, #plasma, #frameworks, ngraham
Cc: rikmills, ngraham, kde-frameworks-devel, michaelh, bruns

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Actually, I do need you to do something, but the icons themselves are fine. I 
need to to rebase this patch onto master. I can walk you through it here or in 
a chat room if you need help.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17062

To: trickyricky26, #vdg, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D17079: Provide a qqc2/kirigami-based about page

[Luigi Toscano]

ltoscano added a comment.


  That's a great idea! Would it be possible:
  
  - to also (optionally) support the translators' information, like in the 
current about box? (probably in a future patch, but maybe some groundwork is 
needed here)
  - to move this about page to some common kirigami-addons library?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 80 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/80/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Nov 2018 00:05:50 +
 Build duration:
4 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 136 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/136/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Nov 2018 00:05:51 +
 Build duration:
4 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.11 - Build # 37 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.11/37/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Thu, 22 Nov 2018 00:05:51 +
 Build duration:
1 min 12 sec and counting

D16951: Resolve merge conflict

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2a85454d7a42: Resolve merge conflict (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45981=45982

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons/actions/16/dialog-input-devices.svg

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Resolve merge conflict

[Nicolas Fella]

nicolasfella accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Resolve merge conflict

[Noah Davis]

ndavis retitled this revision from "Add mouse button icons" to "Resolve merge 
conflict".

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Resolve merge conflict

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  In D16951#363898 , @ndavis wrote:
  
  > So now I have 2 commits and one of them is already on master, but they're 
both called "Add mouse button icons" and use the same description. Should I 
update this diff to describe only the latest commit or make it apply to both?
  
  
  Just rename this one to something like "Resolve merge conflict"

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  So now I have 2 commits and one of them is already on master, but they're 
both called "Add mouse button icons" and use the same description. Should I 
update this diff to describe only the latest commit or make it apply to both?

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis updated this revision to Diff 45981.
ndavis marked an inline comment as done.
ndavis added a comment.


  Rebase onto master again

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45980=45981

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons/actions/16/dialog-input-devices.svg

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951_1

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  Ok, I see what the issue was. The conflicts are literally stored *in* the 
file that has the conflict as text, so `dialog-input-devices.svg` was turned 
into a diff of the old and new versions.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis updated this revision to Diff 45980.
ndavis added a comment.


  Fix conflicts

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45979=45980

BRANCH
  arcpatch-D16951_1

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/actions/22/input-mouse-click-left.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-right.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/16/input-mouse-click-left.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-right.svg
  icons/actions/22/dialog-input-devices.svg
  icons/actions/22/input-mouse-click-left.svg
  icons/actions/22/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-right.svg

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol added a comment.


  In D17078#363772 , @anthonyfieroni 
wrote:
  
  > You can't change parameters in methods or constructors, it's a BIC.
  
  
  https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17071

To: davidedmundson, dfaure, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  This assumes the files that you uploaded before the merge are all correct.
  
  - Save the correct icons somewhere.
  - Checkout the old diff: arc patch --diff 45755
  - Begin rebase: git rebase master
  - Override the files with conflicts with the files you saved
  - git add files
  - git rebase --continue
  - Upload it: arc diff

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#363879 , @nicolasfella 
wrote:
  
  > In D16951#363878 , @ndavis wrote:
  >
  > > Save what or how? Doesn't `arc diff --update D16951` save things? I know 
I added the right files and there were only 2 conflicts 
(`icons/actions/16/dialog-input-devices.svg` and 
`icons-dark/actions/16/dialog-input-devices.svg`).
  >
  >
  > Saved in the program you resolved the conflict with
  >
  > > I just pulled the patch with `arc patch D16951`
  > >  If I do `git status`, it says
  > > 
  > >   On branch arcpatch-D16951
  > >nothing to commit, working tree clean
  > > 
  > > This is what Git looks like in `git-dag`:
  > >  F6435866: Screenshot_20181121_180633.png 

  >
  > git thinks everything is ok, but the merge conflict markers are still in 
the file.
  >
  > I think you should restore the unmerged version, merge again, resolve the 
conflict and upload it again
  
  
  How do I do this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  In D16951#363878 , @ndavis wrote:
  
  > Save what or how? Doesn't `arc diff --update D16951` save things? I know I 
added the right files and there were only 2 conflicts 
(`icons/actions/16/dialog-input-devices.svg` and 
`icons-dark/actions/16/dialog-input-devices.svg`).
  
  
  Saved in the program you resolved the conflict with
  
  > I just pulled the patch with `arc patch D16951`
  >  If I do `git status`, it says
  > 
  >   On branch arcpatch-D16951
  >nothing to commit, working tree clean
  > 
  > This is what Git looks like in `git-dag`:
  >  F6435866: Screenshot_20181121_180633.png 

  
  git thinks everything is ok, but the merge conflict markers are still in the 
file.
  
  I think you should restore the unmerged version, merge again, resolve the 
conflict and upload it again

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#363876 , @nicolasfella 
wrote:
  
  > In D16951#363875 , @ndavis wrote:
  >
  > > I thought I did this already. I rebased onto master, then added the 
version of the file I wanted, then continued the rebase, then updated the diff. 
Is there something I missed?
  >
  >
  > Sounds reasonable. Maybe you forgot to save, or forgot to add a file or 
added the wrong file.
  
  
  Save what or how? Doesn't `arc diff --update D16951` save things? I know I 
added the right files and there were only 2 conflicts 
(`icons/actions/16/dialog-input-devices.svg` and 
`icons-dark/actions/16/dialog-input-devices.svg`).
  
  I just pulled the patch with `arc patch D16951`
  If I do `git status`, it says
  
On branch arcpatch-D16951
nothing to commit, working tree clean
  
  This is what Git looks like in `git-dag`:
  F6435866: Screenshot_20181121_180633.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  I any case, try again and check the files for merge conflict markers

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  In D16951#363875 , @ndavis wrote:
  
  > I thought I did this already. I rebased onto master, then added the version 
of the file I wanted, then continued the rebase, then updated the diff. Is 
there something I missed?
  
  
  Sounds reasonable. Maybe you forgot to save, or forgot to add a file or added 
the wrong file.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  I thought I did this already. I rebased onto master, then added the version 
of the file I wanted, then continued the rebase, then updated the diff. Is 
there something I missed?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> dialog-input-devices.svg:3
>  

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 79 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/79/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 21 Nov 2018 22:35:20 +
 Build duration:
2 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 94.62 KB...][ 20%] Built target qrcAlias_autogenScanning dependencies of target breeze-icons-mkdir[ 20%] Built target scalable_autogen[ 20%] Built target dupe_autogen[ 20%] Built target symlink_autogen[ 20%] Built target breeze-icons-mkdir[ 20%] Built target newline_autogenScanning dependencies of target breeze-icons-dark-mkdirScanning dependencies of target qrcAliasScanning dependencies of target scalableScanning dependencies of target dupe[ 20%] Built target breeze-icons-dark-mkdirScanning dependencies of target newline[ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[ 29%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[ 33%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[ 37%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.oScanning dependencies of target symlink[ 41%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons-dark/actions/16/dialog-input-devices.svg:8: parser error : Opening and ending tag mismatch: svg line 1 and defs   ^./icons-dark/actions/16/dialog-input-devices.svg:9: parser error : Extra content at the end of the document  ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons/actions/16/dialog-input-devices.svg:8: parser error : Opening and ending tag mismatch: svg line 1 and defs   ^./icons/actions/16/dialog-input-devices.svg:9: parser error : Extra content at the end of the document  ^make[2]: *** [CMakeFiles/breeze-validate-svg.dir/build.make:57: CMakeFiles/breeze-validate-svg] Error 1make[1]: *** [CMakeFiles/Makefile2:174: CMakeFiles/breeze-validate-svg.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 45%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[ 50%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[ 54%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[ 58%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[ 62%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[ 66%] Linking CXX executable bin/qrcAlias[ 66%] Built target qrcAlias[ 70%] Linking CXX executable ../bin/newline[ 75%] Linking CXX executable ../bin/symlink[ 79%] Linking CXX executable ../bin/dupe[ 79%] Built target newline[ 79%] Built target symlink[ 79%] Built target dupe[ 83%] Linking CXX executable ../bin/scalable[ 83%] Built target scalablemake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 135 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/135/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 21 Nov 2018 22:35:20 +
 Build duration:
2 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 83.96 KB...] * Qt5Test * Qt5 (required version >= 5.9.0)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:BUILD_QCH-- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target qrcAlias_autogenScanning dependencies of target breeze-validate-svg[  4%] Automatic MOC for target qrcAlias[  4%] Built target qrcAlias_autogenScanning dependencies of target newline_autogen[  8%] Automatic MOC for target newline[  8%] Built target newline_autogenScanning dependencies of target symlink_autogen[ 12%] Automatic MOC for target symlink[ 12%] Built target symlink_autogenScanning dependencies of target dupe_autogen[ 16%] Automatic MOC for target dupe[ 16%] Built target dupe_autogenScanning dependencies of target scalable_autogen[ 20%] Automatic MOC for target scalable./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons-dark/actions/16/dialog-input-devices.svg:8: parser error : Opening and ending tag mismatch: svg line 1 and defs   ^./icons-dark/actions/16/dialog-input-devices.svg:9: parser error : Extra content at the end of the document  ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons/actions/16/dialog-input-devices.svg:8: parser error : Opening and ending tag mismatch: svg line 1 and defs   ^./icons/actions/16/dialog-input-devices.svg:9: parser error : Extra content at the end of the document  ^make[2]: *** [CMakeFiles/breeze-validate-svg.dir/build.make:57: CMakeFiles/breeze-validate-svg] Error 1make[1]: *** [CMakeFiles/Makefile2:174: CMakeFiles/breeze-validate-svg.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 20%] Built target scalable_autogenmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.11 - Build # 36 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.11/36/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 21 Nov 2018 22:35:20 +
 Build duration:
27 sec and counting
   CONSOLE OUTPUT
  [...truncated 72.81 KB...][ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[ 29%] Built target dupe_autogen[ 29%] Built target symlink_autogen[ 29%] Built target scalable_autogen[ 29%] Built target newline_autogenScanning dependencies of target dupe[ 37%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[ 37%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.oScanning dependencies of target scalableScanning dependencies of target symlink[ 41%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[ 45%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[ 54%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[ 54%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.oScanning dependencies of target newline[ 58%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[ 66%] Linking CXX executable bin/qrcAlias./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons/actions/16/dialog-input-devices.svg:8: parser error : Opening and ending tag mismatch: svg line 1 and defs   ^./icons/actions/16/dialog-input-devices.svg:9: parser error : Extra content at the end of the document  ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD  ^./icons-dark/actions/16/dialog-input-devices.svg:3: parser error : StartTag: invalid element name<<< HEAD   ^./icons-dark/actions/16/dialog-input-devices.svg:8: parser error : Opening and ending tag mismatch: svg line 1 and defs   ^./icons-dark/actions/16/dialog-input-devices.svg:9: parser error : Extra content at the end of the document  ^gmake[2]: *** [CMakeFiles/breeze-validate-svg.dir/build.make:57: CMakeFiles/breeze-validate-svg] Error 1gmake[1]: *** [CMakeFiles/Makefile2:142: CMakeFiles/breeze-validate-svg.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 66%] Built target qrcAlias/usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.11/autotests/scalabletest.cpp:75:26: warning: result of comparison of constant -1 with _expression_ of type 'KIconLoaderDummy::Context' is always true [-Wtautological-constant-out-of-range-compare]QVERIFY2(context != -1, ~~~ ^  ~~/usr/local/include/qt5/QtTest/qtestcase.h:76:9: note: expanded from macro 'QVERIFY2'if (statement) {\^[ 70%] Linking CXX executable ../bin/symlink[ 75%] Linking CXX executable ../bin/dupe[ 79%] Linking CXX executable ../bin/newline[ 79%] Built target symlink[ 79%] Built target newline[ 79%] Built target dupe1 warning generated.[ 83%] Linking CXX executable ../bin/scalable[ 83%] Built target scalablegmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D16951: Add mouse button icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6976172920e2: Add mouse button icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45978=45979

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/actions/22/input-mouse-click-left.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-right.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/16/input-mouse-click-left.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-right.svg
  icons/actions/22/dialog-input-devices.svg
  icons/actions/22/input-mouse-click-left.svg
  icons/actions/22/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-right.svg

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#363861 , @nicolasfella 
wrote:
  
  > Looks great!
  
  
  Ah thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis updated this revision to Diff 45978.
ndavis added a comment.


  Rebase onto master

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45755=45978

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/actions/22/input-mouse-click-left.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-right.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/16/input-mouse-click-left.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-right.svg
  icons/actions/22/dialog-input-devices.svg
  icons/actions/22/input-mouse-click-left.svg
  icons/actions/22/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-right.svg

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.


  Looks great!

REPOSITORY
  R266 Breeze Icons

BRANCH
  mouse-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D17086#363855 , @ngraham wrote:
  
  > Thanks for the icon! I'd recommend mimicking the style of the other package 
icons that have a symbol:
  >
  > In other words, add a zipper towards the right-side,, put the AppImage 
symbol in the bottom-left corner, and make the small version just be a line-art 
version of the AppImage logo.
  
  
  I considered that. But decided in the initial proposal against, with this 
reasoning:
  AppImage files are different to distribution packages, they will not be 
unpackaged or untarred in any way to be deployed into the system, at least to 
what the user will experience. But will be used as is. Same like a ODT file is 
actually a ZIP file, but the nature of being something tarred and composed from 
lots of different "files" is not exposed to the user.
  So the semantics of a zipper would not really match that much, unless one 
looks at it from a pure file creation POV.
  
  I rather think the zipper might misguide people into thinking AppImages are 
the same category as debs, rpms & Co.
  
  With that in mind, what do you think?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> sitter wrote in kio_smb_browse.cpp:508
> https://en.wikipedia.org/wiki/If_and_only_if

How about writing that out in English, then? :) "iff" just looks like a typo in 
this context.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, 
sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
bruns, emmanuelp, mikesomov

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  It's been 3 days and no response. It has already been approved by another 
reviewer, so I'm going to land this now.

REPOSITORY
  R266 Breeze Icons

BRANCH
  mouse-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks for the icon! I'd recommend mimicking the style of the other package 
icons that have a symbol:
  
  F6435828: Screenshot_20181121_151526.png 

  
  F6435829: Screenshot_20181121_151602.png 

  
  F6435832: Screenshot_20181121_151649.png 

  
  In other words, add a zipper towards the right-side,, put the AppImage symbol 
in the bottom-left corner, and make the small version just be a line-art 
version of the AppImage logo.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16983: Move firewall-applet icons to status category

[Noah Davis]

ndavis retitled this revision from "Add 48px firewall-applet* icons" to "Move 
firewall-applet icons to status category".
ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewall-applet-fix-tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16983

To: ndavis, #vdg, #breeze, ngraham
Cc: sitter, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D16983: Add 48px firewall-applet* icons

[Noah Davis]

ndavis added a comment.


  Anyone opposed to moving the firewall-applet icons into the status category? 
`status/22` is a scalable directory. If no-one speaks by tomorrow, I'm going to 
land the patch.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewall-applet-fix-tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16983

To: ndavis, #vdg, #breeze, ngraham
Cc: sitter, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Open questions:
  
  - how to support the dark icon set?
  - what would be better colors?
  
  Example of icon use with 64 & 16 pixel size, and bigger in preview:
  F6435751: Screenshot_20181121_220325.png 

  
  The icon also fixes a small offset issue in the original logo :) cmp. the one 
on https://appimage.org/

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17083: Fix hidden languages in the mode menu

[Nibaldo González]

nibags updated this revision to Diff 45975.
nibags added a comment.


  - Update comment

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17083?vs=45972=45975

BRANCH
  fix-hidden-modes

REVISION DETAIL
  https://phabricator.kde.org/D17083

AFFECTED FILES
  src/mode/katemodemanager.cpp

To: nibags, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

D17085: Fix language load after including keywords from this language in another file

[Nibaldo González]

nibags retitled this revision from "Fix language load after including keywords 
from this language" to "Fix language load after including keywords from this 
language in another file".

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17085

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17085: Fix language load after including keywords from this language

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann, 
vkrause, jpoelen.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17085

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> global.h:249
> +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by 
> Slave::createSlave, @since 5.30
> +ERR_FILE_TOO_LARGE_FOR_FAT32 = KJob::UserDefinedError + 74 ///< @since 
> 5.52
>  };

Should be bumped to 5.53

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham

D17085: Fix language load after including keywords from this language

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-keys-include

REVISION DETAIL
  https://phabricator.kde.org/D17085

AFFECTED FILES
  data/syntax/scss.xml
  src/lib/definition.cpp

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17084: Prolog & Lua: fix shebang

[Nibaldo González]

nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17084

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17084: Prolog & Lua: fix shebang

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Before, the shebang was highlighted if there were empty lines before. Now it 
will only be highlighted in the first line.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-shebang

REVISION DETAIL
  https://phabricator.kde.org/D17084

AFFECTED FILES
  data/syntax/lua.xml
  data/syntax/prolog.xml

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17083: Fix hidden languages in the mode menu

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> katemodemanager.cpp:103
>  for (int i = 0; i < modes.size(); ++i) {
>  // filter out None hl, we add that later as "normal" mode
> +if (modes[i].isHidden() || modes[i].name() == QLatin1String("None")) 
> {

Now the comment is wrong :) can you adapt it as well?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17083

To: nibags, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

D17083: Fix hidden languages in the mode menu

[Nibaldo González]

nibags added a reviewer: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17083

To: nibags, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17083: Fix hidden languages in the mode menu

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  In the status bar, the syntax highlighting menu (mode menu) shows hidden 
languages, for example:
  
Others -> Alerts
Others -> Modelines

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-hidden-modes

REVISION DETAIL
  https://phabricator.kde.org/D17083

AFFECTED FILES
  src/mode/katemodemanager.cpp

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17078: Make it possible to use KAboutData/License/Person from QML

[Kai Uwe Broulik]

broulik added a comment.


  You can change default values just fine, it requires re-compilation to use 
them but no ABI implications.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Anthony Fieroni]

anthonyfieroni added a reviewer: dfaure.
anthonyfieroni added a comment.


  You can't change parameters in methods or constructors, it's a BIC.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol edited the summary of this revision.
apol added a dependency: D17080: Make it possible to fallback to a different 
icon.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol added a comment.


  WRT the gravatar bit, I'm not married to it, it's just a way to have this 
moving forward.
  
  I'll add some screenshots so you get an idea:
  
  F6435584: discover-about1.png 
  
  F6435585: discover-about2.png 
  
  F6435586: discover-about3.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol updated this revision to Diff 45968.
apol added a comment.


  Don't show the gravatar logo when not there

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17079?vs=45965=45968

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17079

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/main.cpp
  discover/qml/AboutPage.qml
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  discover/resources.qrc

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol edited the summary of this revision.
apol added a dependency: D17078: Make it possible to use 
KAboutData/License/Person from QML.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol added a dependent revision: D17079: Provide a qqc2/kirigami-based about 
page.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of using the one in xmlgui, create one that integrates properly in 
Kirigami/Discover.

TEST PLAN
  Used it, saw myself in it.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17079

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/main.cpp
  discover/qml/AboutPage.qml
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  discover/resources.qrc

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Exposes their properties through Q_GADGET.
  Makes it possible to export them as QVariant by declaring it and making it 
possible to create an empty instance of them.

TEST PLAN
  Tests still pass, see Discover patch.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17078

AFFECTED FILES
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Shubham]

shubham added a comment.


  @bruns @ngraham what's your view on this? Did you tested it out?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D17048: Restore sendfile support

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:31980ecd1cac: Restore sendfile support (authored by 
davidedmundson).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17048?vs=45889=45955

REVISION DETAIL
  https://phabricator.kde.org/D17048

AFFECTED FILES
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file_unix.cpp

To: davidedmundson, dfaure
Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

D17051: Use correct variable type for returned value from read/sendfile

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8f926e459622: Use correct variable type for returned 
value from read/sendfile (authored by davidedmundson).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17051?vs=45890=45956

REVISION DETAIL
  https://phabricator.kde.org/D17051

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: davidedmundson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16878: Resolve symlinks in exclude folders

[Igor Poboiko]

poboiko added a comment.


  I believe can do something better here. 
  I think if we stick to canonical paths everywhere, and resolve symlinks ASAP 
(but still follow them), that might solve all the problems.
  
  In D16878#359864 , @bruns wrote:
  
  > Because it can never be consistent.
  >  What happens when I create two symlinks to the same folder, and put one 
link into includeFolders, the other one in excludeFolders?
  
  
  Here the behavior would be the same as if user just add the same folder to 
both lists. Not quite sure how it works now (I guess, one of two rules will 
just pop first). 
  But here the undefined behavior would be acceptable, because it seems like 
user tried to shoot his leg intentionally :)
  
  > What really should happen, the indexer should **never** follow symlinks, 
but only add files by their canonical path. This avoids a bunch of problems, 
symlink loops, nondeterministic pathes for files when these are added to the 
index, ...
  
  As for symlink loops, `QDirIterator` with `FollowSymlinks` seems to be able 
to handle this nicely (at least according to Qt docs).
  As for nondeterministic pathes - just add canonical path, and that's it.
  
  The only problem I see here is that if we try `baloosearch -d folder/` and 
inside there will be symlink `folder/subfolder -> /somewhere/else`, we won't 
find any results inside `subfolder`. 
  This is less trivial, to work with it we need to store the whole FS graph 
(which is not tree anymore) with symlinks. But for now we can live without it, 
I suppose.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16878

To: poboiko, #frameworks, #baloo
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Andrew Crouthamel]

acrouthamel added a comment.


  In D16299#363498 , @sitter wrote:
  
  > If someone has a thought to offer on this please do.
  >  Personally I am somewhat leaning towards assuming that systems should be 
properly configured. The problem with setting the URL to the ip address is that 
it messes with the visual look in the address bar. So, if we want reliable 
resolution and good looks we'd need to resolve each dnssd address (e.g. 
`foobar.local`) to their ip address (e.g. 172.17.0.1) via kdnssd and then 
resolve that back to a hostname via glibc/qhostinfo (e.g. `foobar.sky.net`). 
That way we'd know that the name we have in the end is in fact resolvable by 
the system without aid from dnssd. Speed impact of this aside it also adds 3 
additional points of failure (and KDNSSD currently doesn't implement the 
resolver API it seems).
  
  
  I would recommend assuming DNS and systems are configured properly. I say 
that as someone with ~15 years IT experience. Modern IT networks are so heavily 
reliant on it (ever set up a VMware cluster? phew!), almost nothing works if it 
is not set up properly.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, 
sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
bruns, emmanuelp, mikesomov

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Shubham]

shubham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Shubham]

shubham updated this revision to Diff 45951.
shubham added a comment.


  - a

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16249?vs=45470=45951

BRANCH
  fat

REVISION DETAIL
  https://phabricator.kde.org/D16249

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/global.h
  src/core/job_error.cpp

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D17071: Don't include any directory sizes in DirectorySizeJob

[David Edmundson]

davidedmundson updated this revision to Diff 45947.
davidedmundson edited the summary of this revision.
davidedmundson edited the test plan for this revision.
davidedmundson added a comment.


  Squash

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17071?vs=45942=45947

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17071

AFFECTED FILES
  autotests/jobtest.cpp
  src/core/directorysizejob.cpp

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17070: Don't double-count size of directories in DirectorySizeJob

[David Edmundson]

davidedmundson abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17070

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17070: Don't double-count size of directories in DirectorySizeJob

[David Edmundson]

davidedmundson added a dependent revision: D17071: Don't include any directory 
sizes in DirectorySizeJob.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17070

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

[David Edmundson]

davidedmundson added a dependency: D17070: Don't double-count size of 
directories in DirectorySizeJob.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17071

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

[David Edmundson]

davidedmundson added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17071

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17070: Don't double-count size of directories in DirectorySizeJob

[David Edmundson]

davidedmundson added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17070

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Running stat on a directory gives a size of on ext3 gives a size of
  
  4096. Running stat on a directory on NTFS gives a size of 0.
  
  If you copy some files to another FS the total size is different and it
  falsely appears that some data is lost.
  
  We're not trying to count the disk usage, otherwise we'd be looking at
  block usage not adding up individual files. Therefore this patch removes
  including the directory size as it's a meaningless value.
  
  Note: this patch is separate from "Don't double-count size of
  directories in DirectorySizeJob". We would still require both.
  I've split it to separate a potentially controversial design choice from
  a definite bug.

TEST PLAN
  More precise unit test passes on ext3
  
  Dolphin properties shows the same value for copied files on an ext3 and ntfs 
file system

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17071

AFFECTED FILES
  autotests/jobtest.cpp
  src/core/directorysizejob.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17070: Don't double-count size of directories in DirectorySizeJob

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Running "stat" on a directory gives a size of on ext3 gives a size of
  "4096".
  
  DirectorySizeJob has a bug that it counts this directory size twice.
  Once when it encounters a directory in the entry list, then again when
  it finds the "." entry in that subdirectory.
  
  The unit test passes because it's super vague to be file system
  independent.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17070

AFFECTED FILES
  src/core/directorysizejob.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter added a comment.


// TODO: it may be better to resolve the host to an ip address. dnssd
//   being able to find a service doesn't mean name resolution is
//   properly set up for its domain. So, we may not be able to resolve
//   this without help from avahi. OTOH KDNSSD doesn't have API for this
//   and from a platform POV we should probably assume that if avahi
//   is functional it is also set up as resolution provider.
//   Given the plugin design on glibc's libnss however I am not sure
//   that assumption will be true all the time. ~sitter, 2018
  
  If someone has a thought to offer on this please do.
  Personally I am somewhat leaning towards assuming that systems should be 
properly configured. The problem with setting the URL to the ip address is that 
it messes with the visual look in the address bar. So, if we want reliable 
resolution and good looks we'd need to resolve each dnssd address (e.g. 
`foobar.local`) to their ip address (e.g. 172.17.0.1) via kdnssd and then 
resolve that back to a hostname via glibc/qhostinfo (e.g. `foobar.sky.net`). 
That way we'd know that the name we have in the end is in fact resolvable by 
the system without aid from dnssd. Speed impact of this aside it also adds 3 
additional points of failure (and KDNSSD currently doesn't implement the 
resolver API it seems).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter retitled this revision from "RFC fallback to dnssd service discovery if 
smb listDir failed on root" to "fallback to dnssd service discovery if smb 
listDir failed on root".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> ngraham wrote in kio_smb_browse.cpp:508
> iff -> if

https://en.wikipedia.org/wiki/If_and_only_if

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter updated this revision to Diff 45938.
sitter marked 4 inline comments as done.
sitter added a comment.


  - check kdnssd version; do not use dnssd discovery if it too old and suffers 
from signal racing (also see D16298 )
  - fix typo in function name
  - no longer use debug names for udsentry
  - convert resolution from fixme to todo, I am unsure if we should even care 
though. input welcome
  - add note about lack of workgroup resolution, it's also unclear if workgroup 
resolution in its current form has any future. specifically LLMNR (the future 
replacement of NBS) does not have a concept of SMB workgroups, so the way I see 
it workgroup discovery is a dead-end anyway. in the future the only way to 
inspect workgroups would be to actually talk to the SMB host (which may require 
auth) and as such is impossible to do consistently AFAICT

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16299?vs=43869=45938

BRANCH
  smb-discovery

REVISION DETAIL
  https://phabricator.kde.org/D16299

AFFECTED FILES
  CMakeLists.txt
  config-runtime.h.cmake
  smb/CMakeLists.txt
  smb/kio_smb.h
  smb/kio_smb_browse.cpp

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D17068: actually install the version header

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R272 KDNSSD

BRANCH
  install-version

REVISION DETAIL
  https://phabricator.kde.org/D17068

To: sitter, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17068: actually install the version header

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R272:43543acfee14: actually install the version header 
(authored by sitter).

REPOSITORY
  R272 KDNSSD

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17068?vs=45936=45937

REVISION DETAIL
  https://phabricator.kde.org/D17068

AFFECTED FILES
  CMakeLists.txt

To: sitter, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17068: actually install the version header

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  we've generated it but never installed it :|
  this enables lib consumers to check the kdnssd version without having to
  pass around cmake data
  
  CHANGELOG: now installs kdnssd_version.h to check the version of the lib

TEST PLAN
  builds; install correctly

REPOSITORY
  R272 KDNSSD

BRANCH
  install-version

REVISION DETAIL
  https://phabricator.kde.org/D17068

AFFECTED FILES
  CMakeLists.txt

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17068: actually install the version header

[Harald Sitter]

sitter added reviewers: Frameworks, broulik.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D17068

To: sitter, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns