D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Shubham]

shubham marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Shubham]

shubham updated this revision to Diff 46174.
shubham added a comment.


  @since 5.53

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16249?vs=45951=46174

REVISION DETAIL
  https://phabricator.kde.org/D16249

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/global.h
  src/core/job_error.cpp

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 341 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/341/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 25 Nov 2018 04:26:28 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)54%
(32101/59984)38%
(16585/44010)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9105/9545)48%
(4282/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8375/14294)51%
(4679/9249)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3891/7937)34%
(1601/4735)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(532/1034)37%
(319/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4293)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
(703/1356)43%
  

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Nathaniel Graham]

ngraham added a comment.


  Sorry for the extended review time; I've found myself super busy with family 
stuff during this vacation. :)
  
  Please address Elvis' inline comment and then this will look good to me.

INLINE COMMENTS

> global.h:249
> +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by 
> Slave::createSlave, @since 5.30
> +ERR_FILE_TOO_LARGE_FOR_FAT32 = KJob::UserDefinedError + 74 ///< @since 
> 5.52
>  };

You still need to change `@since 5.52` to `@since 5.53`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 340 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/340/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 24 Nov 2018 20:21:51 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiowidgets-kdirlistertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32058/59984)38%
(16549/44010)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9088/9545)48%
(4255/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8367/14294)51%
(4684/9249)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3890/7937)34%
(1600/4735)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1034)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4293)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%

T8349: Improve Places panel usability and presentation

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, alexde, IohannesPetros, sourabhboss, 
feverfew, trickyricky26, crozbo, spoorun, ndavis, navarromorales, firef, 
andrebarros, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D17139: Add highlighting file for Wayland Debug Traces

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  > I am ok with that ;=)
  ===

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  feature/waylandLogHighlighting

REVISION DETAIL
  https://phabricator.kde.org/D17139

To: cordlandwehr, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16671: Refactor embedded image extractor for greater extensibility

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16671

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17114: [KUrlNavigator] Re-activate on mouse middle button click

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fc5a98db98a8: [KUrlNavigator] Re-activate on mouse middle 
button click (authored by thsurrel).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17114?vs=46049=46155

REVISION DETAIL
  https://phabricator.kde.org/D17114

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h

To: thsurrel, #frameworks, elvisangelaccio, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17114: [KUrlNavigator] Re-activate on mouse middle button click

[Thomas Surrel]

thsurrel added a comment.


  I tried that too, but it was not working for Dolphin. It did reactivate 
correctly the disabled split view, but the tab was not opened, I guess we were 
missing an event.

REPOSITORY
  R241 KIO

BRANCH
  arc_kurlnavigator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17114

To: thsurrel, #frameworks, elvisangelaccio, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17139: Add highlighting file for Wayland Debug Traces

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 46148.
cordlandwehr added a comment.


  - Fix detection of interface names with numbers
  - Fix reference for nomal text itemData
  - Add test data for Wayland trace highlighting

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17139?vs=46133=46148

BRANCH
  feature/waylandLogHighlighting

REVISION DETAIL
  https://phabricator.kde.org/D17139

AFFECTED FILES
  autotests/folding/wayland.txt.fold
  autotests/html/wayland.txt.html
  autotests/input/wayland.txt
  autotests/input/wayland.txt.syntax
  autotests/reference/wayland.txt.ref
  data/syntax/wayland-trace.xml

To: cordlandwehr, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

[loh tar]

loh.tar added a reviewer: Frameworks.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17056

To: loh.tar, #frameworks
Cc: mludwig, kde-frameworks-devel, michaelh, ngraham, bruns

D17055: Avoid Q_FOREACH

[loh tar]

loh.tar added a reviewer: davidedmundson.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17055

To: loh.tar, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[loh tar]

loh.tar added a reviewer: Frameworks.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

[loh tar]

loh.tar added a reviewer: Frameworks.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17026

To: loh.tar, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17137: File menu: Put Save, Print and Export in submenus

[gregormi]

gregormi edited the summary of this revision.
gregormi added a reviewer: KDevelop.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D8649: move detecting comments to before operators so -- is interpreted as a comment, not an operator

[Christoph Cullmann]

cullmann abandoned this revision.
cullmann added a comment.


  Already fix in current master.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8649

To: cullmann, #framework_syntax_highlighting, dhaumann, genethomas
Cc: kwrite-devel, kde-frameworks-devel, cullmann, dhaumann, michaelh, ngraham, 
bruns, demsking, sars

D8649: move detecting comments to before operators so -- is interpreted as a comment, not an operator

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann added a reviewer: genethomas.
cullmann added a comment.
Herald added a project: Kate.
Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: 
Frameworks.


  These fixes are already in the current state in our git ;=)
  Thanks for the patch anyways!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8649

To: cullmann, #framework_syntax_highlighting, dhaumann, genethomas
Cc: kwrite-devel, kde-frameworks-devel, cullmann, dhaumann, michaelh, ngraham, 
bruns, demsking, sars, #frameworks

D17114: [KUrlNavigator] Re-activate on mouse middle button click

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  We could have used `KUrlNavigator::mouseReleaseEvent()` where we already have 
the same check, but this is also fine.

REPOSITORY
  R241 KIO

BRANCH
  arc_kurlnavigator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17114

To: thsurrel, #frameworks, elvisangelaccio, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16370: KTextEditor : syntax definition priority UI usability

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think we merge the change here now.
  The tooltip is no real issue, we can try to consolidate 
what-this-tooltip-inline help an other time if somebody has interest.
  Allowing negative prios makes sense.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16370

To: rjvbb, #ktexteditor, cullmann
Cc: dhaumann, ngraham, cullmann, kde-frameworks-devel, kwrite-devel, michaelh, 
bruns, demsking, head7, kfunk, sars

D12295: Supporting nested brackets for Kate autobrackets

[Christoph Cullmann]

cullmann added a comment.


  Hi, I like the improvements, just want some feedback on my questions above.
  Still alive?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12295

To: sraizada, #ktexteditor, #kate, cullmann, dhaumann, brauch
Cc: brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
michaelh, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c7095834d282: Expose Toggle Comment feature 
through tools menu and default shortcut (authored by slenz, committed by 
cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17008?vs=45841=46144

REVISION DETAIL
  https://phabricator.kde.org/D17008

AFFECTED FILES
  src/data/katepart5ui.rc
  src/view/kateview.cpp

To: slenz, #vdg, ngraham, #kate, #ktexteditor, cullmann
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, 
demsking, sars, dhaumann

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  As long as the old shortcuts stay, I think this is ok.

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D17008_1

REVISION DETAIL
  https://phabricator.kde.org/D17008

To: slenz, #vdg, ngraham, #kate, #ktexteditor, cullmann
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, 
demsking, sars, dhaumann

D17128: DocumentPrivate: Remove comment mark when joining lines

[Christoph Cullmann]

cullmann added a comment.


  Whereas I think such an extension is good, I am not sure if the normal join 
lines should try to be that clever.
  ATM it is very "deterministic" what happens and I think people like that.
  It would make more sense to have an extra action for such a "smart" variant 
in my eyes.
  What do others think?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann

D17092: Add syntax highlighting for TypeScript & TypeScript React

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a25ce26d2c6b: Add syntax highlighting for TypeScript 
 TypeScript React (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17092?vs=46105=46141

REVISION DETAIL
  https://phabricator.kde.org/D17092

AFFECTED FILES
  autotests/folding/highlight.js.fold
  autotests/folding/test.js.fold
  autotests/folding/test.jsx.fold
  autotests/folding/test.qml.fold
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/highlight.js.html
  autotests/html/test.jsx.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.jsx
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17092: Add syntax highlighting for TypeScript & TypeScript React

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I like that ;=)
  And its a very nice show-case for the keyword list inclusion.
  Cool!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-typescript

REVISION DETAIL
  https://phabricator.kde.org/D17092

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17139: Add highlighting file for Wayland Debug Traces

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Could you add a minimal test case to the auto-tests?
  Otherwise all fine with having this.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17139

To: cordlandwehr, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D17093: Rust & Yacc/Bison: improve comments

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6643d91bbbaa: Rust  Yacc/Bison: improve comments 
(authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17093?vs=46104=46139

REVISION DETAIL
  https://phabricator.kde.org/D17093

AFFECTED FILES
  autotests/folding/highlight.y.fold
  autotests/folding/test.rs.fold
  autotests/html/highlight.y.html
  autotests/html/test.rs.html
  autotests/input/highlight.y
  autotests/input/test.rs
  autotests/reference/highlight.y.ref
  autotests/reference/test.rs.ref
  data/syntax/rust.xml
  data/syntax/yacc.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17093: Rust & Yacc/Bison: improve comments

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Good idea => will apply it.
  Thanks!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-comments-rust-yacc

REVISION DETAIL
  https://phabricator.kde.org/D17093

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17083: Fix hidden languages in the mode menu

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:bb5f34d7224d: Fix hidden languages in the mode menu 
(authored by nibags, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17083?vs=45975=46138

REVISION DETAIL
  https://phabricator.kde.org/D17083

AFFECTED FILES
  src/mode/katemodemanager.cpp

To: nibags, #ktexteditor, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D17083: Fix hidden languages in the mode menu

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks good, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-hidden-modes

REVISION DETAIL
  https://phabricator.kde.org/D17083

To: nibags, #ktexteditor, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D17084: Prolog & Lua: fix shebang

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6f109cf88198: Prolog  Lua: fix shebang (authored by 
nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17084?vs=45991=46137

REVISION DETAIL
  https://phabricator.kde.org/D17084

AFFECTED FILES
  autotests/folding/test.prolog.fold
  autotests/html/test.prolog.html
  autotests/input/test.prolog
  autotests/reference/test.prolog.ref
  data/syntax/lua.xml
  data/syntax/prolog.xml

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17084: Prolog & Lua: fix shebang

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable, has tests, will be applied, thanks!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-shebang

REVISION DETAIL
  https://phabricator.kde.org/D17084

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17139: Add highlighting file for Wayland Debug Traces

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  When running a Wayland application with parameter WAYLAND_DEBUG=1, all
  communication between Wayland server and client is printed to the
  standard output. This scheme highlights the interfaces, called functions
  and parameters.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  feature/waylandLogHighlighting

REVISION DETAIL
  https://phabricator.kde.org/D17139

AFFECTED FILES
  data/syntax/wayland-trace.xml

To: cordlandwehr
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:edbf2e36c805: SpellCheckBar: Use DictionaryComboBox 
instead of plain QComboBox (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17103?vs=46020=46135

REVISION DETAIL
  https://phabricator.kde.org/D17103

AFFECTED FILES
  src/spellcheck/spellcheckbar.cpp
  src/spellcheck/spellcheckbar.ui

To: loh.tar, cullmann
Cc: mludwig, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D17123: KTextEditor::ViewPrivate: Avoid warning "Text requested for invalid range"

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:db6be05824b5: KTextEditor::ViewPrivate: Avoid warning 
Text requested for invalid range (authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17123?vs=46082=46134

REVISION DETAIL
  https://phabricator.kde.org/D17123

AFFECTED FILES
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think neither the dialog/spellcheck bar nor the context menu things got any 
love in the close past.
  If you have time to improve this, any patch is welcome!
  
  I will apply this one and you can submit more things in a new patch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17103

To: loh.tar, cullmann
Cc: mludwig, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D17137: File menu: Put Save, Print and Export in submenus

[gregormi]

gregormi edited the summary of this revision.
gregormi added a reviewer: Kate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17137: File menu: Put Save, Print and Export in submenus

[gregormi]

gregormi updated this revision to Diff 46132.
gregormi added a comment.


  rebase on master

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17137?vs=46128=46132

BRANCH
  arcpatch-D17137

REVISION DETAIL
  https://phabricator.kde.org/D17137

AFFECTED FILES
  src/data/katepart5ui.rc

To: gregormi
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17137: File menu: Put Save, Print and Export in submenus

[gregormi]

gregormi retitled this revision from "File menu: Put Save, Print and Export in 
submenus

With https://phabricator.kde.org/D16830 the file menu gets more entries. This 
is a suggestion to do some cleanup before.

This is the corresponding patch for Kate: TODO (screenshots are there)..." to 
"File menu: Put Save, Print and Export in submenus".
gregormi edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17137: File menu: Put Save, Print and Export in submenusWith https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before.This is the correspondi

[gregormi]

gregormi created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gregormi requested review of this revision.

REVISION SUMMARY
  ...NOTE: I assume that dependent applications like KWrite and KDevelop must 
be adapted, too. So, a broader discussion is expected.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17137

AFFECTED FILES
  src/data/katepart5ui.rc

To: gregormi
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17132: Add 22px dialog-warning icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b23134a4220a: Add 22px dialog-warning icon (authored by 
trickyricky26, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17132?vs=46110=46129

REVISION DETAIL
  https://phabricator.kde.org/D17132

AFFECTED FILES
  icons-dark/status/22/dialog-warning.svg
  icons/status/22/dialog-warning.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17132: Add 22px dialog-warning icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this works!

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-dialog-warning-22px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17132

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17114: [KUrlNavigator] Re-activate on mouse middle button click

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This approach makes sense to me and works beautifully!

REPOSITORY
  R241 KIO

BRANCH
  arc_kurlnavigator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17114

To: thsurrel, #frameworks, elvisangelaccio, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Alexander Schlarb]

ntninja added a comment.


  Thanks, I'll keep that in mind for next time.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: ntninja, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Shubham]

shubham added a comment.


  @ngraham @bruns do you have any objections?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.10 - Build # 104 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.10/104/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 24 Nov 2018 12:12:14 +
 Build duration:
4 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/2)0%
(0/8)0%
(0/8)0%
(0/1413)0%
(0/867)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskirigami-plasmadesktop-integration0%
(0/4)0%
(0/4)0%
(0/142)0%
(0/46)plugin0%
(0/4)0%
(0/4)0%
(0/1271)0%
(0/821)

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.9 - Build # 80 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.9/80/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 24 Nov 2018 12:12:14 +
 Build duration:
3 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/2)0%
(0/8)0%
(0/8)0%
(0/1413)0%
(0/867)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskirigami-plasmadesktop-integration0%
(0/4)0%
(0/4)0%
(0/142)0%
(0/46)plugin0%
(0/4)0%
(0/4)0%
(0/1271)0%
(0/821)

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 WindowsMSVCQt5.11 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20WindowsMSVCQt5.11/18/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 24 Nov 2018 12:12:13 +
 Build duration:
46 sec and counting

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 FreeBSDQt5.11 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20FreeBSDQt5.11/18/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 24 Nov 2018 12:12:14 +
 Build duration:
27 sec and counting

D16929: Remove dead search provider

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:abfddc54afc0: Remove dead search providers (authored by 
vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16929?vs=45632=46112#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16929?vs=45632=46112

REVISION DETAIL
  https://phabricator.kde.org/D16929

AFFECTED FILES
  src/urifilters/ikws/searchproviders/dmoz.desktop
  src/urifilters/ikws/searchproviders/ibl.desktop

To: vkrause, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D16946: Port more search providers to HTTPS

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:719461805318: Port more search providers to HTTPS 
(authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16946?vs=45635=46111#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16946?vs=45635=46111

REVISION DETAIL
  https://phabricator.kde.org/D16946

AFFECTED FILES
  src/urifilters/ikws/searchproviders/ecosia.desktop
  src/urifilters/ikws/searchproviders/ethicle.desktop
  src/urifilters/ikws/searchproviders/metacrawler.desktop
  src/urifilters/ikws/searchproviders/nl-teletekst.desktop
  src/urifilters/ikws/searchproviders/pgpkeys.desktop
  src/urifilters/ikws/searchproviders/php.desktop
  src/urifilters/ikws/searchproviders/rag.desktop
  src/urifilters/ikws/searchproviders/thesaurus.desktop
  src/urifilters/ikws/searchproviders/webster.desktop

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16929: Remove dead search provider

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16929

To: vkrause, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D16929: Remove dead search provider

[Volker Krause]

vkrause added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16929

To: vkrause, #frameworks
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D16954: Add find module for Google's libphonenumber

[Volker Krause]

vkrause added reviewers: Build System, Frameworks.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16954

To: vkrause, #build_system, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17132: Add 22px dialog-warning icon

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17132

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17132: Add 22px dialog-warning icon

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-dialog-warning-22px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17132

AFFECTED FILES
  icons-dark/status/22/dialog-warning.svg
  icons/status/22/dialog-warning.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.11/16/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 24 Nov 2018 11:03:48 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.frameworkintegration-kstyle_unittest

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[David Faure]

dfaure closed this revision.
dfaure added a comment.


  
https://commits.kde.org/frameworkintegration/4cc12a5ad1fa92f8b934f02ff2e401539ec9b9f7

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: ntninja, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[David Faure]

dfaure added a comment.


  Ah, you need to specify that you don't have a developer account, otherwise 
the assumption is simply that you'll push the patch once approved.
  
  I'll land it now.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: ntninja, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16825: Export again KFilePlaceEditDialog

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7ad161b1a2bb: Export again KFilePlaceEditDialog (authored 
by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16825?vs=45313=46109

REVISION DETAIL
  https://phabricator.kde.org/D16825

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfileplaceeditdialog.cpp
  src/filewidgets/kfileplaceeditdialog.h
  src/filewidgets/kfileplaceeditdialog_p.h
  src/filewidgets/kfileplacesview.cpp

To: elvisangelaccio, #dolphin, dfaure, ngraham, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15368: [Comic Thumbnailer] support more image formats

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15368

To: fleger, broulik, #frameworks, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D15368: [Comic Thumbnailer] support more image formats

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> comiccreator.cpp:101
>  QMap entryMap;
> -Q_FOREACH(const QString& entry, entries) {
> -if (entry.endsWith(QLatin1String(".gif"), Qt::CaseInsensitive) ||
> -entry.endsWith(QLatin1String(".jpg"), Qt::CaseInsensitive) ||
> -entry.endsWith(QLatin1String(".jpeg"), Qt::CaseInsensitive) 
> ||
> -entry.endsWith(QLatin1String(".png"), Qt::CaseInsensitive)) {
> -entryMap.insert(entry.toLower(), entry);
> +QVector nameFilters;
> +QMimeDatabase db;

`QRegExp` shouldn't be used in new code.

Can you try to use `QRegularExpression` instead?

> comiccreator.cpp:105
> +const QMimeType mime = db.mimeTypeForName(mimeTypeName);
> +Q_FOREACH (const QString& globPattern, mime.globPatterns())
> +{

Please consider using the C++11 `for` loop instead.

See https://lists.qt-project.org/pipermail/development/2016-May/025843.html

> comiccreator.cpp:106
> +Q_FOREACH (const QString& globPattern, mime.globPatterns())
> +{
> +nameFilters.append(QRegExp(globPattern, Qt::CaseInsensitive, 
> QRegExp::Wildcard));

Coding style: opening brace should start at the end of previous line.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15368

To: fleger, broulik, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D15367: [Comic Thumbnailer] fix CBR thumbnail generation

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  Sorry for taking so long.
  
  Please give us the email address we should use for pushing this patch on your 
behalf.

REPOSITORY
  R320 KIO Extras

BRANCH
  comicbook-fix-cbr

REVISION DETAIL
  https://phabricator.kde.org/D15367

To: fleger, broulik, #frameworks, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D17079: Provide a qqc2/kirigami-based about page

[Volker Krause]

vkrause added a comment.


  In D17079#364308 , @mart wrote:
  
  > In D17079#364263 , @apol wrote:
  >
  > > In D17079#364163 , @ltoscano 
wrote:
  > >
  > > > kcoreaddons is tier1 just like kirigami. Why not create a new 
Frameworks, kirigami-addons (or another appropriate name), which would collect 
all the common UI items which depends on other frameworks? Basically the 
kxmlgui of Kirigami.
  > >
  > >
  > > I think an external framework is a big overkill. In this case, it's only 
runtime dependencies so both either kcoreaddons or kirigami could offer it. I 
would favor putting it in kirigami because there's the duck-typing opportunity 
there too, but it may be a stretch.
  > >  That said, we'll need someone to register the KAbout* types somewhere 
too, but we can also rely on applications doing that as a first iteration.
  >
  >
  > one thing i'm a bit concerned is kirigami becomeing too much of a QML 
kdelibs monolith :p
  
  
  This came up when discussing date/time input widgets at Akademy as well. The 
idea there was also to have tier2 framework ("kirigami-addons") for this kind 
of stuff. Ie. higher-level controls that depend on Kirigami and possibly other 
tier1 frameworks, but unlike kdeclarative doesn't pull in QtWidgets as a 
dependency. So this wouldn't be just for the about page, but seems of much 
broader use.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: vkrause, mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20WindowsMSVCQt5.11/17/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 24 Nov 2018 09:36:03 +
 Build duration:
1 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 89.32 KB...]-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx64/x64/cl.exe -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Found KF5Kirigami2: C:/CI/Software Installs/qqc2-desktop-style/lib/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.53.0") -- Found KF5: success (found suitable version "5.53.0", minimum required is "5.52.0") found components:  Kirigami2 -- Found KF5IconThemes: C:/CI/Software Installs/qqc2-desktop-style/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.53.0") -- Found KF5ConfigWidgets: C:/CI/Software Installs/qqc2-desktop-style/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.53.0") -- Found KF5: success (found suitable version "5.53.0", minimum required is "5.52.0") found components:  IconThemes ConfigWidgets -- Found PkgConfig: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/pkg-config.exe (found version "0.29.2") -- The following OPTIONAL packages have been found: * KF5IconThemes (required version >= 5.52.0) * KF5ConfigWidgets (required version >= 5.52.0) * PkgConfig-- The following REQUIRED packages have been found: * ECM (required version >= 5.52.0) * Qt5Core * Qt5Network (required version >= 5.11.2) * Qt5Qml (required version >= 5.11.2) * Qt5Quick * Qt5Gui * Qt5Widgets * Qt5QuickControls2 * Qt5 (required version >= 5.9.0) * KF5Kirigami2 (required version >= 5.52.0) * KF5 (required version >= 5.52.0)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:BUILD_QCH-- Build files have been written to: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] batC:\CI\workspace\Frameworks\qqc2-desktop-style\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target qqc2desktopstyleplugin_autogenScanning dependencies of target org.kde.desktop_autogen[ 20%] Automatic MOC for target qqc2desktopstyleplugin[ 20%] Built target qqc2desktopstyleplugin_autogen[ 10%] Automatic MOC for target org.kde.desktop[ 20%] Built target org.kde.desktop_autogenScanning dependencies of target qqc2desktopstyleplugin[ 50%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin.cpp.obj[ 50%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin_autogen/mocs_compilation.cpp.objScanning dependencies of target org.kde.desktop[ 40%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/kquickstyleitem.cpp.objqqc2desktopstyleplugin.cppmocs_compilation.cppkquickstyleitem.cppC:\CI\workspace\Frameworks\qqc2-desktop-style\kf5-qt5 WindowsMSVCQt5.11\plugin\kquickstyleitem.cpp(1650): error C2664: 'QString QString::arg(const QString &,int,QChar) const': cannot convert argument 1 from 'QStyle *' to 'qlonglong'C:\CI\workspace\Frameworks\qqc2-desktop-style\kf5-qt5 WindowsMSVCQt5.11\plugin\kquickstyleitem.cpp(1650): note: There is no context in which this conversion is possibleC:\CI\workspace\Frameworks\qqc2-desktop-style\kf5-qt5 WindowsMSVCQt5.11\plugin\kquickstyleitem.cpp(1651): error C2228: left of '.arg' must have class/struct/unionC:\CI\workspace\Frameworks\qqc2-desktop-style\kf5-qt5 WindowsMSVCQt5.11\plugin\kquickstyleitem.cpp(1652): error C2228: left of '.arg' must have class/struct/unionC:\CI\workspace\Frameworks\qqc2-desktop-style\kf5-qt5 WindowsMSVCQt5.11\plugin\kquickstyleitem.cpp(1648): error C2660: 'qsgnode_set_description': function does not take 1 argumentsC:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtQuick/qsgnode.h(188): note: see declaration of 'qsgnode_set_description'jom: C:\CI\workspace\Frameworks\qqc2-desktop-style\kf5-qt5 

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.10 - Build # 103 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.10/103/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 24 Nov 2018 09:36:03 +
 Build duration:
51 sec and counting
   CONSOLE OUTPUT
  [...truncated 190.24 KB...]/usr/include/qt5/QtCore/qchar.h:569:5: note: candidate: ���QChar::QChar(char)���  QChar(char c) Q_DECL_NOTHROW; ^/usr/include/qt5/QtCore/qchar.h:569:5: note:   conversion of argument 1 would be ill-formed:/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem.cpp:1650:39: error: invalid conversion from ���QStyle*��� to ���char��� [-fpermissive] .arg(style())  ~^~In file included from /usr/include/qt5/QtCore/qstring.h:48, from /usr/include/qt5/QtCore/qhashfunctions.h:44, from /usr/include/qt5/QtCore/qlist.h:47, from /usr/include/qt5/QtCore/qstringlist.h:41, from /usr/include/qt5/QtGui/qcolor.h:46, from /usr/include/qt5/QtGui/qimage.h:44, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem_p.h:45, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem.cpp:42:/usr/include/qt5/QtCore/qchar.h:90:22: note: candidate: ���constexpr QChar::QChar(char16_t)���  Q_DECL_CONSTEXPR QChar(char16_t ch) Q_DECL_NOTHROW : ucs(ushort(ch)) {} // implicit  ^/usr/include/qt5/QtCore/qchar.h:90:22: note:   conversion of argument 1 would be ill-formed:/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem.cpp:1650:39: error: invalid conversion from ���QStyle*��� to ���char16_t��� [-fpermissive] .arg(style())  ~^~In file included from /usr/include/qt5/QtCore/qstring.h:48, from /usr/include/qt5/QtCore/qhashfunctions.h:44, from /usr/include/qt5/QtCore/qlist.h:47, from /usr/include/qt5/QtCore/qstringlist.h:41, from /usr/include/qt5/QtGui/qcolor.h:46, from /usr/include/qt5/QtGui/qimage.h:44, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem_p.h:45, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem.cpp:42:/usr/include/qt5/QtCore/qchar.h:86:22: note: candidate: ���constexpr QChar::QChar(int)���  Q_DECL_CONSTEXPR QChar(int rc) Q_DECL_NOTHROW : ucs(ushort(rc & 0x)) {}  ^/usr/include/qt5/QtCore/qchar.h:86:22: note:   conversion of argument 1 would be ill-formed:/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem.cpp:1650:39: error: invalid conversion from ���QStyle*��� to ���int��� [-fpermissive] .arg(style())  ~^~In file included from /usr/include/qt5/QtCore/qstring.h:48, from /usr/include/qt5/QtCore/qhashfunctions.h:44, from /usr/include/qt5/QtCore/qlist.h:47, from /usr/include/qt5/QtCore/qstringlist.h:41, from /usr/include/qt5/QtGui/qcolor.h:46, from /usr/include/qt5/QtGui/qimage.h:44, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem_p.h:45, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem.cpp:42:/usr/include/qt5/QtCore/qchar.h:85:22: note: candidate: ���constexpr QChar::QChar(uint)���  Q_DECL_CONSTEXPR QChar(uint rc) Q_DECL_NOTHROW : ucs(ushort(rc & 0x)) {}  ^/usr/include/qt5/QtCore/qchar.h:85:22: note:   conversion of argument 1 would be ill-formed:/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem.cpp:1650:39: error: invalid conversion from ���QStyle*��� to ���uint��� {aka ���unsigned int���} [-fpermissive] .arg(style())  ~^~In file included from /usr/include/qt5/QtCore/qstring.h:48, from /usr/include/qt5/QtCore/qhashfunctions.h:44, from /usr/include/qt5/QtCore/qlist.h:47, from /usr/include/qt5/QtCore/qstringlist.h:41, from /usr/include/qt5/QtGui/qcolor.h:46, from /usr/include/qt5/QtGui/qimage.h:44, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem_p.h:45, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.10/plugin/kquickstyleitem.cpp:42:/usr/include/qt5/QtCore/qchar.h:84:22: note: candidate: 

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.9 - Build # 79 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.9/79/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 24 Nov 2018 09:36:03 +
 Build duration:
48 sec and counting
   CONSOLE OUTPUT
  [...truncated 186.38 KB...] from /usr/include/qt5/QtCore/qstringlist.h:41, from /usr/include/qt5/QtGui/qcolor.h:46, from /usr/include/qt5/QtGui/qimage.h:44, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem_p.h:45, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem.cpp:42:/usr/include/qt5/QtCore/qchar.h:563:5: note: candidate: ���QChar::QChar(uchar)���  QChar(uchar c) Q_DECL_NOTHROW; ^/usr/include/qt5/QtCore/qchar.h:563:5: note:   conversion of argument 1 would be ill-formed:/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem.cpp:1650:39: error: invalid conversion from ���QStyle*��� to ���uchar��� {aka ���unsigned char���} [-fpermissive] .arg(style())  ~^~In file included from /usr/include/qt5/QtCore/qhashfunctions.h:44, from /usr/include/qt5/QtCore/qlist.h:47, from /usr/include/qt5/QtCore/qstringlist.h:41, from /usr/include/qt5/QtGui/qcolor.h:46, from /usr/include/qt5/QtGui/qimage.h:44, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem_p.h:45, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem.cpp:42:/usr/include/qt5/QtCore/qchar.h:562:5: note: candidate: ���QChar::QChar(char)���  QChar(char c) Q_DECL_NOTHROW; ^/usr/include/qt5/QtCore/qchar.h:562:5: note:   conversion of argument 1 would be ill-formed:/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem.cpp:1650:39: error: invalid conversion from ���QStyle*��� to ���char��� [-fpermissive] .arg(style())  ~^~In file included from /usr/include/qt5/QtCore/qhashfunctions.h:44, from /usr/include/qt5/QtCore/qlist.h:47, from /usr/include/qt5/QtCore/qstringlist.h:41, from /usr/include/qt5/QtGui/qcolor.h:46, from /usr/include/qt5/QtGui/qimage.h:44, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem_p.h:45, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem.cpp:42:/usr/include/qt5/QtCore/qchar.h:86:22: note: candidate: ���constexpr QChar::QChar(int)���  Q_DECL_CONSTEXPR QChar(int rc) Q_DECL_NOTHROW : ucs(ushort(rc & 0x)) {}  ^/usr/include/qt5/QtCore/qchar.h:86:22: note:   conversion of argument 1 would be ill-formed:/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem.cpp:1650:39: error: invalid conversion from ���QStyle*��� to ���int��� [-fpermissive] .arg(style())  ~^~In file included from /usr/include/qt5/QtCore/qhashfunctions.h:44, from /usr/include/qt5/QtCore/qlist.h:47, from /usr/include/qt5/QtCore/qstringlist.h:41, from /usr/include/qt5/QtGui/qcolor.h:46, from /usr/include/qt5/QtGui/qimage.h:44, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem_p.h:45, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem.cpp:42:/usr/include/qt5/QtCore/qchar.h:85:22: note: candidate: ���constexpr QChar::QChar(uint)���  Q_DECL_CONSTEXPR QChar(uint rc) Q_DECL_NOTHROW : ucs(ushort(rc & 0x)) {}  ^/usr/include/qt5/QtCore/qchar.h:85:22: note:   conversion of argument 1 would be ill-formed:/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem.cpp:1650:39: error: invalid conversion from ���QStyle*��� to ���uint��� {aka ���unsigned int���} [-fpermissive] .arg(style())  ~^~In file included from /usr/include/qt5/QtCore/qhashfunctions.h:44, from /usr/include/qt5/QtCore/qlist.h:47, from /usr/include/qt5/QtCore/qstringlist.h:41, from /usr/include/qt5/QtGui/qcolor.h:46, from /usr/include/qt5/QtGui/qimage.h:44, from /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.9/plugin/kquickstyleitem_p.h:45, from 

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps

[René J . V . Bertin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:1e02355c1786: Support for QGuiApplication-based apps 
(authored by rjvbb).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14000?vs=44083=46108#toc

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14000?vs=44083=46108

REVISION DETAIL
  https://phabricator.kde.org/D14000

AFFECTED FILES
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h

To: rjvbb, #frameworks, mart
Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 FreeBSDQt5.11 - Build # 17 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20FreeBSDQt5.11/17/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 24 Nov 2018 09:36:02 +
 Build duration:
35 sec and counting
   CONSOLE OUTPUT
  [...truncated 96.58 KB...]/usr/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 FreeBSDQt5.11/plugin/kquickstyleitem.cpp:607:25: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant]opt->features = 0;^nullptr/usr/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 FreeBSDQt5.11/plugin/kquickstyleitem.cpp:1609:31: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant]disconnect(m_control, 0, this, 0);  ^  nullptr/usr/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 FreeBSDQt5.11/plugin/kquickstyleitem.cpp:1609:40: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant]disconnect(m_control, 0, this, 0);   ^   nullptr/usr/home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 FreeBSDQt5.11/plugin/kquickstyleitem.cpp:1650:30: error: no matching member function for call to 'arg'.arg(style())~^~~/usr/local/include/qt5/QtCore/qstring.h:275:31: note: candidate function not viable: no known conversion from 'QStyle *' to 'qlonglong' (aka 'long long') for 1st argumentQ_REQUIRED_RESULT QString arg(qlonglong a, int fieldwidth=0, int base=10,  ^/usr/local/include/qt5/QtCore/qstring.h:277:31: note: candidate function not viable: no known conversion from 'QStyle *' to 'qulonglong' (aka 'unsigned long long') for 1st argumentQ_REQUIRED_RESULT QString arg(qulonglong a, int fieldwidth=0, int base=10,  ^/usr/local/include/qt5/QtCore/qstring.h:291:31: note: candidate function not viable: no known conversion from 'QStyle *' to 'double' for 1st argumentQ_REQUIRED_RESULT QString arg(double a, int fieldWidth = 0, char fmt = 'g', int prec = -1,  ^/usr/local/include/qt5/QtCore/qstring.h:293:31: note: candidate function not viable: no known conversion from 'QStyle *' to 'char' for 1st argumentQ_REQUIRED_RESULT QString arg(char a, int fieldWidth = 0,  ^/usr/local/include/qt5/QtCore/qstring.h:295:31: note: candidate function not viable: no known conversion from 'QStyle *' to 'QChar' for 1st argumentQ_REQUIRED_RESULT QString arg(QChar a, int fieldWidth = 0,  ^/usr/local/include/qt5/QtCore/qstring.h:298:31: note: candidate function not viable: no known conversion from 'QStyle *' to 'const QString' for 1st argumentQ_REQUIRED_RESULT QString arg(const QString , int fieldWidth = 0,  ^/usr/local/include/qt5/QtCore/qstring.h:301:31: note: candidate function not viable: no known conversion from 'QStyle *' to 'QStringView' for 1st argumentQ_REQUIRED_RESULT QString arg(QStringView a, int fieldWidth = 0,  ^/usr/local/include/qt5/QtCore/qstring.h:303:31: note: candidate function not viable: no known conversion from 'QStyle *' to 'QLatin1String' for 1st argumentQ_REQUIRED_RESULT QString arg(QLatin1String a, int fieldWidth = 0,  ^/usr/local/include/qt5/QtCore/qstring.h:970:25: note: candidate function not viable: no known conversion from 'QStyle *' to 'int' for 1st argumentinline QString QString::arg(int a, int fieldWidth, int base, QChar fillChar) const^/usr/local/include/qt5/QtCore/qstring.h:972:25: note: candidate function not viable: no known conversion from 'QStyle *' to 'uint' (aka 'unsigned int') for 1st argumentinline QString QString::arg(uint a, int fieldWidth, int base, QChar fillChar) const^/usr/local/include/qt5/QtCore/qstring.h:974:25: note: candidate function not viable: no known conversion from 'QStyle *' to 'long' for 1st argumentinline QString QString::arg(long a, int fieldWidth, int base, QChar fillChar) const^/usr/local/include/qt5/QtCore/qstring.h:976:25: note: candidate function not viable: no known conversion from 'QStyle *' to 'ulong' (aka 'unsigned long') for 1st argumentinline QString QString::arg(ulong a, int fieldWidth, int base, QChar fillChar) const^/usr/local/include/qt5/QtCore/qstring.h:978:25: note: candidate function not viable: no known conversion from 'QStyle *' to 'short' for 1st argumentinline QString QString::arg(short a, int fieldWidth, int base, QChar fillChar) const^/usr/local/include/qt5/QtCore/qstring.h:980:25: note: candidate function not viable: no known conversion from 'QStyle *' to 'ushort' (aka 'unsigned