D18329: Remove the AndroidX support library dependency

[Aleix Pol Gonzalez]

apol added subscribers: nicolasfella, apol.
apol added a comment.


  LGTM, @nicolasfella?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D18329

To: vkrause
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D18302: Add Android notification channel support

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18302

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18299: ComboBox: fix default delegate

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> broulik wrote in ComboBox.qml:58
> Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a 
> `ComboBox` is recommended as:
> "This ensures that the interaction works as expected, and the popup will 
> automatically close when appropriate. "
> The `currentIndex` change makes sense, though

otherwise it didn't work. I may have overlooked something though.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18299

To: apol, #frameworks, davidedmundson
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: KDE file dialog column resize no longer possible?

[René J . V . Bertin]

On Friday January 18 2019 14:11:38 Nate Graham wrote:
> Yeah, go ahead and put it up on Phab!
> 
> Nate

Okidoki. Willdo tomorow, I'm still tweaking it a bit.

R.

Re: KDE file dialog column resize no longer possible?

[Nate Graham]

Yeah, go ahead and put it up on Phab!

Nate



On 1/18/19 1:56 PM, René J.V. Bertin wrote:

Hi,


Assistance would be appreciated. :-)


I've whipped up something, a bit sneaky but it does more or less what I had in 
mind.

- the QEvent::Polish handler connects to the sectionResized signal
- this sectionResized slot will check if the QTreeView contains a positive number of 
elements, if the new size is positive and if the current resize mode is not already 
"Interactive". If so, it sets the current section to interactive resize and 
sets the new size explictly.
- somehow this per-column change does not have the intended effect (when done 
here, with Qt 5.9 and FW 5.52.0), so a class state variable is toggled too
- at an appropriate moment the entire QHeaderView is set to interactive mode if 
that state variable is true. The first QPaintEvent should come after the 
section widths have been determined and turns out to be just in time to get 
actually resizable sections.

I haven't checked in depth if there are side-effects but this works good enough 
for me (as a first draft). The only thing I'd like to see added is the 
persistence of the column widths I mentioned earlier: save the widths of any 
columns the user resized manually, and use those values when the dialog is 
reopened.

Let me know what you think; should I put this on phab?

R.

Re: KDE file dialog column resize no longer possible?

[René J . V . Bertin]

Hi,

>Assistance would be appreciated. :-)

I've whipped up something, a bit sneaky but it does more or less what I had in 
mind.

- the QEvent::Polish handler connects to the sectionResized signal
- this sectionResized slot will check if the QTreeView contains a positive 
number of elements, if the new size is positive and if the current resize mode 
is not already "Interactive". If so, it sets the current section to interactive 
resize and sets the new size explictly.
- somehow this per-column change does not have the intended effect (when done 
here, with Qt 5.9 and FW 5.52.0), so a class state variable is toggled too
- at an appropriate moment the entire QHeaderView is set to interactive mode if 
that state variable is true. The first QPaintEvent should come after the 
section widths have been determined and turns out to be just in time to get 
actually resizable sections.

I haven't checked in depth if there are side-effects but this works good enough 
for me (as a first draft). The only thing I'd like to see added is the 
persistence of the column widths I mentioned earlier: save the widths of any 
columns the user resized manually, and use those values when the dialog is 
reopened.

Let me know what you think; should I put this on phab?

R.diff --git src/filewidgets/kdiroperatordetailview.cpp src/filewidgets/kdiroperatordetailview.cpp
index fa8094f8..f3116e21 100644
--- src/filewidgets/kdiroperatordetailview.cpp
+++ src/filewidgets/kdiroperatordetailview.cpp
@@ -85,25 +85,55 @@ bool KDirOperatorDetailView::setViewMode(KFile::FileView viewMode)
 
 bool KDirOperatorDetailView::event(QEvent *event)
 {
-if (event->type() == QEvent::Polish) {
-QHeaderView *headerView = header();
-headerView->setSectionResizeMode(0, QHeaderView::Stretch);
-headerView->setSectionResizeMode(1, QHeaderView::ResizeToContents);
-headerView->setSectionResizeMode(2, QHeaderView::ResizeToContents);
-headerView->setStretchLastSection(false);
-headerView->setSectionsMovable(false);
-
-setColumnHidden(KDirModel::Size, m_hideDetailColumns);
-setColumnHidden(KDirModel::ModifiedTime, m_hideDetailColumns);
-hideColumn(KDirModel::Type);
-hideColumn(KDirModel::Permissions);
-hideColumn(KDirModel::Owner);
-hideColumn(KDirModel::Group);
-} else if (event->type() == QEvent::UpdateRequest) {
-// A wheel movement will scroll 4 items
-if (model()->rowCount()) {
-verticalScrollBar()->setSingleStep((sizeHintForRow(0) / 3) * 4);
+switch (event->type()) {
+case QEvent::Polish: {
+QHeaderView *headerView = header();
+headerView->setSectionResizeMode(0, QHeaderView::Stretch);
+headerView->setSectionResizeMode(1, QHeaderView::ResizeToContents);
+headerView->setSectionResizeMode(2, QHeaderView::ResizeToContents);
+headerView->setStretchLastSection(false);
+headerView->setSectionsMovable(false);
+
+setColumnHidden(KDirModel::Size, m_hideDetailColumns);
+setColumnHidden(KDirModel::ModifiedTime, m_hideDetailColumns);
+hideColumn(KDirModel::Type);
+hideColumn(KDirModel::Permissions);
+hideColumn(KDirModel::Owner);
+hideColumn(KDirModel::Group);
+m_setInteractiveResizeMode = false;
+connect(header(), ::sectionResized,
+[=](int column, int, int newSize) {
+if (newSize > 0 && model()->rowCount() > 0
+&& header()->sectionResizeMode(column) != QHeaderView::Interactive) {
+qWarning() << "Section" << column << "resized to" << newSize
+<< "count=" << model()->rowCount()
+<< "changing resizeMode to interactive from" << header()->sectionResizeMode(column);
+header()->setSectionResizeMode(column, QHeaderView::Interactive);
+header()->resizeSection(column, newSize);
+// for some reason the selective ResizeMode setting has no effect,
+// we need to set interactive mode on all sections, queue that now.
+m_setInteractiveResizeMode = true;
+}
+});
+break;
 }
+case QEvent::UpdateRequest:
+// A wheel movement will scroll 4 items
+if (model()->rowCount()) {
+verticalScrollBar()->setSingleStep((sizeHintForRow(0) / 3) * 4);
+}
+break;
+case QEvent::Paint:
+// event analysis confirms that the 1st paint event arrives after all headers have
+// had a size set, so we can now activate interactive mode.
+if (m_setInteractiveResizeMode) {
+header()->setSectionResizeMode(QHeaderView::Interactive);
+

D18205: Test empty and zero gps data

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  gps_tests

REVISION DETAIL
  https://phabricator.kde.org/D18205

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17977: Improve reliability and semantic correctless of dupe test

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Since this is essentially a workaround for doing in-source builds, the 
obvious superior course of action is for me to the the work to set up some 
basic infrastructure for painless out-of-source builds. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17977

To: ngraham, #breeze, ndavis, GB_2
Cc: rizzitello, tcanabrava, kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE file dialog column resize no longer possible?

[René J . V . Bertin]

OK, bummer, apparently Qt didn't think it a good idea to add a "size 
automatically but allow the user to change afterwards) :-(

There is QHeaderView::sectionSizeFromContents() but using that may give the 
same 
performance issue as your reverted fix (it's protected so you'd need to use a 
wrapped QHeaderView instance)?

Is there a callback or event where you can query the size that Qt determined, 
set the resizemode to Interactive and then use resizeSection() with the 
obtained 
size value? I'll look at the sectionResized and geometriesChanged signals later.

R.

D18369: Create tel: links for phone numbers

[Volker Krause]

vkrause updated this revision to Diff 49836.
vkrause added a comment.


  Handle empty tel: URLs, as found in the review email.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18369?vs=49834=49836

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18369

AFFECTED FILES
  autotests/ktexttohtmltest.cpp
  src/lib/text/ktexttohtml.cpp
  src/lib/text/ktexttohtml_p.h

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18369: Create tel: links for phone numbers

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  KDE Connect can handle tel: URLs and trigger a call, so this enables to
  directly call phone numbers found e.g. in emails.
  
  This is obviously a heuristic and might need more fine-tuning, as we can't
  depend on libphonenumber here for more precision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18369

AFFECTED FILES
  autotests/ktexttohtmltest.cpp
  src/lib/text/ktexttohtml.cpp
  src/lib/text/ktexttohtml_p.h

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17977: Improve reliability and semantic correctless of dupe test

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I found an issue.
  
  With the patch, the dupe test does not detect 2 identical files with the same 
name in different categories. It is able to detect that issue from
  
  How to reproduce:
  
  1. `cp icons/categories/32/applications-internet.svg 
icons/preferences/32/applications-internet.svg`
  2. `make && make test`
  
  Failed test before patch (includes false positives and true positive): 
F6555407: LastTest.old.log 
  
  Passed test after patch (no false positives or true positive): F6555406: 
LastTest.log 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17977

To: ngraham, #breeze, ndavis, GB_2
Cc: rizzitello, tcanabrava, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Don't fail if defaultLanguage dictionary can't be loaded

[Ahmad Samir]

ahmadsamir added a comment.


  @loh.tar: I'll think that over, thanks for the pointers :)

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D17977: Improve reliability and semantic correctless of dupe test

[Chris Rizzitello]

rizzitello added a comment.


  Seams to function correctly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17977

To: ngraham, #breeze, ndavis, GB_2
Cc: rizzitello, tcanabrava, kde-frameworks-devel, michaelh, ngraham, bruns

D17977: Improve reliability and semantic correctless of dupe test

[Tomaz Canabrava]

tcanabrava added inline comments.

INLINE COMMENTS

> dupetest.cpp:87-88
>  }
>  for (auto dir : ICON_DIRS) {
> -dupesForDirectory(PROJECT_SOURCE_DIR + QStringLiteral("/") + 
> dir);
> +for (auto type : ICON_TYPES) {
> +dupesForDirectory(PROJECT_SOURCE_DIR + QStringLiteral("/") + 
> dir + QStringLiteral("/") + type);

const ref& ?

> dupetest.cpp:89
> +for (auto type : ICON_TYPES) {
> +dupesForDirectory(PROJECT_SOURCE_DIR + QStringLiteral("/") + 
> dir + QStringLiteral("/") + type);
> +}

QLatin1Char('/')

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17977

To: ngraham, #breeze, ndavis, GB_2
Cc: tcanabrava, kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE file dialog column resize no longer possible?

[René J . V . Bertin]

OK, bummer, apparently Qt didn't think it a good idea to add a "size 
automatically but allow the user to change afterwards) :-(

There is QHeaderView::sectionSizeFromContents() but using that may give the 
same 
performance issue as your reverted fix (it's protected so you'd need to use a 
wrapped QHeaderView instance)?

Is there a callback or event where you can query the size that Qt determined, 
set the resizemode to Interactive and then use resizeSection() with the 
obtained 
size value? I'll look at the sectionResized and geometriesChanged signals later.

R.

Re: KDE file dialog column resize no longer possible?

[Nate Graham]

Yes, this was an intentional change: 
https://cgit.kde.org/kio.git/commit/?id=e504bc1fd56412ee7e9748a0dfafa537977ec1b5

Check out the listed bugs that it fixed! However I understand that it did cause 
some fallout: https://bugs.kde.org/show_bug.cgi?id=401506

I tried to fix that in 
https://cgit.kde.org/kio.git/commit/?id=f28e343063783c6a0a6b925a390a1a1a5e10d91c

But it had to be reverted in 
https://cgit.kde.org/kio.git/commit/?id=9f1b7e879fd2a8e315e564a47e147d90760b0786
 because it caused an unacceptable performance regression.

Essentially what we want to do is auto-size the columns when there's enough 
horizontal space to show everything (i.e. provide a good default view without 
the need for manual adjustment), but when horizontal space is limited, we want 
to ensure that the Name column retains its automatically-determined width and 
give the whole view a scrollbar. I tried a few ways to accomplish this but 
eventually ran into a Qt bug: https://bugreports.qt.io/browse/QTBUG-1248

Assistance would be appreciated. :-)

Nate 


  On Fri, 18 Jan 2019 03:20:26 -0700 René J.V. Bertin  
wrote  
 > Hi, 
 >  
 > Sorry for cross-posting (initially), I'm not certain which list is the most 
 > appropriate. 
 >  
 > It's often been tricky to trigger column resize mode in the KDE file dialog 
 > (when in one of the detailed view modes) but I realise I haven't been able 
 > to do this at all for a little while now. I just checked a Qt example, this 
 > is not a regression in the Qt version I'm using. 
 >  
 > Has resizing support been turned off in KF5 maybe, and if so, where and why? 
 >  
 > Thanks, 
 > René 
 > 

Re: KDE file dialog column resize no longer possible?

[Nate Graham]

Yes, this was an intentional change: 
https://cgit.kde.org/kio.git/commit/?id=e504bc1fd56412ee7e9748a0dfafa537977ec1b5

Check out the listed bugs that it fixed! However I understand that it did cause 
some fallout: https://bugs.kde.org/show_bug.cgi?id=401506

I tried to fix that in 
https://cgit.kde.org/kio.git/commit/?id=f28e343063783c6a0a6b925a390a1a1a5e10d91c

But it had to be reverted in 
https://cgit.kde.org/kio.git/commit/?id=9f1b7e879fd2a8e315e564a47e147d90760b0786
 because it caused an unacceptable performance regression.

Essentially what we want to do is auto-size the columns when there's enough 
horizontal space to show everything (i.e. provide a good default view without 
the need for manual adjustment), but when horizontal space is limited, we want 
to ensure that the Name column retains its automatically-determined width and 
give the whole view a scrollbar. I tried a few ways to accomplish this but 
eventually ran into a Qt bug: https://bugreports.qt.io/browse/QTBUG-1248

Assistance would be appreciated.  :-)

Nate


  On Fri, 18 Jan 2019 03:20:26 -0700 René J.V. Bertin  
wrote  
 > Hi, 
 >  
 > Sorry for cross-posting (initially), I'm not certain which list is the most 
 > appropriate. 
 >  
 > It's often been tricky to trigger column resize mode in the KDE file dialog 
 > (when in one of the detailed view modes) but I realise I haven't been able 
 > to do this at all for a little while now. I just checked a Qt example, this 
 > is not a regression in the Qt version I'm using. 
 >  
 > Has resizing support been turned off in KF5 maybe, and if so, where and why? 
 >  
 > Thanks, 
 > René 
 > 

D18345: Fix python binding generation for classes with deleted copy constructors

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:a2a404f9f924: Fix python binding generation for classes 
with deleted copy constructors (authored by aacid).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18345?vs=49775=49830

REVISION DETAIL
  https://phabricator.kde.org/D18345

AFFECTED FILES
  find-modules/sip_generator.py

To: aacid, lbeltrame
Cc: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

Re: KDE file dialog column resize no longer possible?

[René J . V . Bertin]

Hmmm, I never see a scrollbar.

Maybe the easiest workaround would be a mode where the user can disable all 
automatic sizing (possibly after getting a good initial setting), and then use 
the user's size choices? That's the behaviour you get on Mac (and MSWin) and 
something I more or less expect everywhere. I often deal with files that have 
long names for which I don't want the required width to be allocated - and iin 
general I strongly believe that the user should at least feel in control of his 
GUI (there's a reason I don't use Gnome ;))
Dialog information is already saved so there should be no need to implement 
something new for that.

I'm currently a bit handicapped by the recent requirement bump to Qt 5.10 
(which 
is not supported on my main machine and I thus don't have on my Linux rig 
either). I'm slowly working my way around that but kio still a little way off.

D18365: Add a flag to keep a window on top

[David Edmundson]

davidedmundson retitled this revision from "Add flag to keep a window on top." 
to "Add a flag to keep a window on top".
davidedmundson edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18365

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18365: Add flag to keep a window on top.

[Vlad Zagorodniy]

zzag added a comment.


  Looks good to me.
  
  (please remove period from the title)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18365

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE file dialog column resize no longer possible?

[René J . V . Bertin]

Kai Uwe Broulik wrote:

> Yes, to ensure sane default sizing of the columns, especially as you
> resize the dialog, which were often too narrow or too wide or otherwise
> unfitting.

Hmm, where? Could have been made optional as they were indeed often not the 
appropriate size and while I haven't seen them being far too wide for some time 
now I don't really see why they would now always be sized fittingly...
In fact, I came asking here because one of my KDevelop dialogs is now all of a 
sudden way too wide in its entirety.

Supposing there's a new algorithm which works better than the old shouldn't 
that 
also be the case if you allow resizing of the columns afterwards?

R. 

D18365: Add flag to keep a window on top.

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Intended usage is just for the calendar/system tray "keep on top" pin.
  It's very specific just for plasmashell cases.
  
  There's already a panel behavior flag but that didn't really match as it
  ties too closely to screen edges.
  
  Flags are used rather than an enum for easier future expansion.

TEST PLAN
  Unit test

REPOSITORY
  R127 KWayland

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18365

AFFECTED FILES
  autotests/client/test_plasmashell.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/protocols/plasma-shell.xml
  src/client/registry.cpp
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Don't fail if defaultLanguage dictionary can't be loaded

[loh tar]

loh.tar added a comment.


  Just my thoughts:
  
  - I think there shouldn't be the (default) dictionary changed by some smart 
logic. Just hint the user that the setting is not applicable.
  - To set the dict to the system locale seems to me the less smartest trick. 
If everybody want such "auto-fix" should then the bad setting investigated and 
tried to find some similar setting, e.g. Bad "de_AT_ost" -> "de_AT" -> "de_DE". 
Why? Someone may have a locale of "de_DE" but a dict setting "en_US" for 
whatever reason. Besides I guess Loader::createSpeller is not only called when 
the default dict will loaded. IIRC has Sonnet some functionallity to guess a 
language and choose a fitting dict (May that help?)
  - The Config-GUI should show some hint in case of trouble, src/ui/configui.ui
  - Don't overwrite permanently some bad setting with a new value. Perhaps has 
the user just set up a new system and only missed to install some package
  - Perhaps should the error message saved in a QString(List), retrievable 
later so it can be shown e.g by KTextEditor::Message
  - Perhaps should Loader::createSpeller return some "Error-Helper-Dictionary" 
instead of a nullptr, so that Sonnet::defaultLanguage may give something like 
"ERROR-de_AT_ost" instead of e.g "de_AT_ost".
  - Accordingly should Sonnet::preferredDictionaries filled with data like 
"ERROR-de_AT_ost"/"ERROR-Deutsch (Östereich something)"
  - See also Sonnet::DictionaryComboBox. There should then the error hints are 
be visible
  - Take a look at D18125 , why I think 
that may helpful. In the new button should then the hint possible to be shown 
"ERROR-foo".
  
  Not investigated if all of these is needed or possible.
  
  PS: Typo in SUMMARY "..of the the dictionary.." 2x the

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Don't fail if defaultLanguage dictionary can't be loaded

[Ahmad Samir]

ahmadsamir added a comment.


  In D18317#395530 , @pino wrote:
  
  > In D18317#395513 , @pino wrote:
  >
  > > This makes a "core" library grow a dependency on widgets -- not really a 
good idea, considering there is the sonnetui library for that.
  >
  >
  > In addition to the above, there are also really bad consquences: take a 
console-only application running QCoreApplication as application class and 
using sonnetcore. Now, in case of the situation described, sonnetcore will try 
spawn a QMessageBox, which IIRC exits the application, as no GUI is available.
  
  
  OK. I didn't know the core/ui differentiation, I'll adjust the patch and see 
if I can come up with a better solution without having core lib depend on 
widgets.
  
  Thanks for the pointers.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

[Vlad Zagorodniy]

zzag added a comment.


  David's comment is still not done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17691

To: mart, #plasma, #kwin
Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

[Fabian Vogt]

fvogt updated this revision to Diff 49806.
fvogt marked 2 inline comments as done.
fvogt added a comment.


  Add some style

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17122?vs=49802=49806

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17122

AFFECTED FILES
  autotests/server/test_display.cpp
  src/server/display.cpp
  src/server/display.h

To: fvogt, #kwin, #plasma
Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

[Fabian Vogt]

fvogt added a comment.




REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/8/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 Jan 2019 11:34:42 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 18 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/18/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 18 Jan 2019 11:34:42 +
 Build duration:
3 min 28 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3602/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 18 Jan 2019 11:34:42 +
 Build duration:
1 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D18356: [Plasma Theme] Use new connect syntax

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8c5099140751: [Plasma Theme] Use new connect syntax 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18356?vs=49804=49805

REVISION DETAIL
  https://phabricator.kde.org/D18356

AFFECTED FILES
  src/plasma/theme.cpp

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18356: [Plasma Theme] Use new connect syntax

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18356

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18356: [Plasma Theme] Use new connect syntax

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Saves some cycles

TEST PLAN
  Saves like 0.6ms on startup here, given the amount of `Theme` objects created.
  `ThemePrivate` is also a `QObject`, I don't understand why it checks for 
`qApp` or why it's not done in the `Private`'s constructor though..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18356

AFFECTED FILES
  src/plasma/theme.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 17 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/17/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 18 Jan 2019 11:25:02 +
 Build duration:
7 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 95 lines...] > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 28dca00d2f3a9682d1fe675751ed54f87db463a4Commit message: "Fix doxygen markdown rendering"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-dev-scripts > git init /home/jenkins/workspace/Frameworks/plasma-framework/kf5-qt5 SUSEQt5.11/ci-tooling/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/*Checking out Revision 16c0570a8441d341747e8d760cd68fbfc3337357 (origin/master) > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 16c0570a8441d341747e8d760cd68fbfc3337357Commit message: "Fix generate code"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project plasma-framework --branchGroup kf5-qt5 --environment production --platform SUSEQt5.11 --installTo /home/jenkins//install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-karchive-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kwindowsystem-kf5-qt5Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kcrash-kf5-qt5Retrieving: Frameworks-kdbusaddons-kf5-qt5Retrieving: Frameworks-kdoctools-kf5-qt5Retrieving: Frameworks-polkit-qt-1-kf5-qt5Retrieving: Frameworks-kauth-kf5-qt5Retrieving: Frameworks-kcodecs-kf5-qt5Retrieving: Frameworks-kguiaddons-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-kconfigwidgets-kf5-qt5Retrieving: Frameworks-kitemviews-kf5-qt5Retrieving: Frameworks-kcompletion-kf5-qt5Retrieving: Frameworks-kiconthemes-kf5-qt5Retrieving: Frameworks-kservice-kf5-qt5Retrieving: Frameworks-sonnet-kf5-qt5Retrieving: Frameworks-attica-kf5-qt5Retrieving: Frameworks-kglobalaccel-kf5-qt5Retrieving: Frameworks-ktextwidgets-kf5-qt5Retrieving: Frameworks-breeze-icons-kf5-qt5Retrieving: Frameworks-phonon-kf5-qt5Retrieving: Frameworks-knotifications-kf5-qt5Retrieving: Frameworks-kxmlgui-kf5-qt5Retrieving: Frameworks-solid-kf5-qt5Retrieving: Frameworks-kjobwidgets-kf5-qt5Retrieving: Frameworks-kbookmarks-kf5-qt5Retrieving: Frameworks-kwallet-kf5-qt5Retrieving: Frameworks-kio-kf5-qt5Retrieving: Frameworks-kparts-kf5-qt5Retrieving: Frameworks-syntax-highlighting-kf5-qt5Retrieving: Frameworks-kpackage-kf5-qt5Retrieving: Frameworks-kactivities-kf5-qt5Retrieving: Frameworks-kdnssd-kf5-qt5Retrieving: Frameworks-kdeclarative-kf5-qt5Retrieving: Frameworks-kidletime-kf5-qt5Retrieving: Frameworks-kitemmodels-kf5-qt5Retrieving: Frameworks-kjs-kf5-qt5Retrieving: Frameworks-kross-kf5-qt5Retrieving: Frameworks-threadweaver-kf5-qt5Retrieving: Frameworks-kunitconversion-kf5-qt5Retrieving: Frameworks-kwayland-kf5-qt5Retrieving: Frameworks-ktexteditor-kf5-qt5Retrieving: Frameworks-oxygen-icons5-kf5-qt5Traceback (most recent call last):  File "ci-tooling/helpers/prepare-dependencies.py", line 71, in filename, metadata = packageArchive.retrievePackage( package )  File "/home/jenkins/workspace/Frameworks/plasma-framework/kf5-qt5 SUSEQt5.11/ci-tooling/helpers/helperslib/Packages.py", line 124, in retrievePackagelatestContent.write( response.read() )  File "/usr/lib64/python3.6/http/client.py", line 462, in reads = self._safe_read(self.length)  File "/usr/lib64/python3.6/http/client.py", line 612, in _safe_readchunk = self.fp.read(min(amt, MAXAMOUNT))  File "/usr/lib64/python3.6/socket.py", line 586, in readintoreturn self._sock.recv_into(b)  File "/usr/lib64/python3.6/ssl.py", line 1009, in recv_intoreturn self.read(nbytes, buffer)  File "/usr/lib64/python3.6/ssl.py", line 871, in readreturn self._sslobj.read(len, buffer)  File "/usr/lib64/python3.6/ssl.py", line 631, in readv = self._sslobj.read(len, buffer)ConnectionResetError: [Errno 104] Connection reset by peer[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/7/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 Jan 2019 11:25:02 +
 Build duration:
4 min 39 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
  

D18149: Share Plasma::Theme instances between multiple ColorScope

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:eac69e04690b: Share Plasma::Theme instances between 
multiple ColorScope (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18149?vs=49537=49803

REVISION DETAIL
  https://phabricator.kde.org/D18149

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h

To: broulik, #plasma, mart
Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 18 Jan 2019 11:25:02 +
 Build duration:
4 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D18149: Share Plasma::Theme instances between multiple ColorScope

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18149

To: broulik, #plasma, mart
Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> display.cpp:87
> +bool running = false,
> + automaticSocketNaming = false;
>  QList outputs;

bool running = false;
  bool automaticSocketNaming = false;

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> display.cpp:86-87
>  QString socketName = QStringLiteral("wayland-0");
> -bool running = false;
> +bool running = false,
> + automaticSocketNaming = false;
>  QList outputs;

Style: 
https://techbase.kde.org/Policies/Frameworks_Coding_Style#Variable_Declarations

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D18345: Fix python binding generation for classes with deleted copy constructors

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  As far as I understand the logic of the whole thing, it looks sane.  At some 
point we ought to find a way to properly test that the generated code...

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18345

To: aacid, lbeltrame
Cc: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

[Fabian Vogt]

fvogt retitled this revision from "RFC: Use wl_display_add_socket_auto by 
default" to "Add option to use wl_display_add_socket_auto".
fvogt edited the summary of this revision.
fvogt edited the test plan for this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: RFC: Use wl_display_add_socket_auto by default

[Fabian Vogt]

fvogt updated this revision to Diff 49802.
fvogt added a comment.


  Use a new bool instead.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17122?vs=46075=49802

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17122

AFFECTED FILES
  autotests/server/test_display.cpp
  src/server/display.cpp
  src/server/display.h

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE file dialog column resize no longer possible?

[Kai Uwe Broulik]

Has resizing support been turned off in KF5 maybe, and if so, where and why?


Yes, to ensure sane default sizing of the columns, especially as you 
resize the dialog, which were often too narrow or too wide or otherwise 
unfitting.


Cheers
Kai Uwe

D17122: RFC: Use wl_display_add_socket_auto by default

[Fabian Vogt]

fvogt added a comment.


  In D17122#395762 , @romangg wrote:
  
  > In D17122#395745 , @fvogt wrote:
  >
  > > > Hmm, maybe then add another setter setAutomaticSocketNaming instead to 
switch to automatic socket name query instead. When it's not called before 
start it would fall back to old behavior.
  > >
  > > That would need changes in KWin though so Plasma 5.16 only :-(
  >
  >
  > Yes, that's fine. Do you need it for something in 5.15?
  
  
  I've been using a patched kwayland locally for several months now already, so 
I'd need to continue doing that for a another couple months. That's all though.
  
  I'll do the change and remove the RFC.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE file dialog column resize no longer possible?

[René J . V . Bertin]

Hi,

Sorry for cross-posting (initially), I'm not certain which list is the most 
appropriate.

It's often been tricky to trigger column resize mode in the KDE file dialog 
(when in one of the detailed view modes) but I realise I haven't been able to 
do this at all for a little while now. I just checked a Qt example, this is not 
a regression in the Qt version I'm using.

Has resizing support been turned off in KF5 maybe, and if so, where and why?

Thanks,
René

D17122: RFC: Use wl_display_add_socket_auto by default

[Roman Gilg]

romangg added a comment.


  In D17122#395745 , @fvogt wrote:
  
  > > Hmm, maybe then add another setter setAutomaticSocketNaming instead to 
switch to automatic socket name query instead. When it's not called before 
start it would fall back to old behavior.
  >
  > That would need changes in KWin though so Plasma 5.16 only :-(
  
  
  Yes, that's fine. Do you need it for something in 5.15?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: RFC: Use wl_display_add_socket_auto by default

[Fabian Vogt]

fvogt added a comment.


  > Hmm, maybe then add another setter setAutomaticSocketNaming instead to 
switch to automatic socket name query instead. When it's not called before 
start it would fall back to old behavior.
  
  That would need changes in KWin though so Plasma 5.16 only :-(

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: RFC: Use wl_display_add_socket_auto by default

[Roman Gilg]

romangg added a comment.


  In D17122#395705 , @fvogt wrote:
  
  > In D17122#395704 , @romangg 
wrote:
  >
  > > In D17122#395696 , @fvogt 
wrote:
  > >
  > > > In D17122#395537 , @romangg 
wrote:
  > > >
  > > > > According to description some autotest fails. Which one exactly?
  > > >
  > > >
  > > > testSocketName as the default value of socketName changed.
  > > >
  > > >   FAIL!  : TestWaylandServerDisplay::testSocketName() Compared values 
are not the same
  > > >  Actual   (display.socketName())   : ""
  > > >  Expected (QStringLiteral("wayland-0")): "wayland-0"
  > > >  Loc: 
[/home/fabian/kderepos/kwayland/autotests/server/test_display.cpp(54)]
  > > >
  > >
  > >
  > > Is there an argument against just checking on empty string at this 
location? Since the socket name is not yet set in line 54, there shouldn't be 
one.
  >
  >
  > The argument is that the default value changed, which is technically an ABI 
break - that's why this is an RFC. If you say that it's fine, I'll do the 
change and remove the RFC.
  
  
  Hmm, maybe then add another setter `setAutomaticSocketNaming` instead to 
switch to automatic socket name query instead. When it's not called before 
start it would fall back to old behavior.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D18288: Make the clock svg's shadows more logically correct and visually appropriate

[Shubham]

shubham added a dependent revision: D17751: Add shadow to Hour's hand.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18288

To: ngraham, #vdg, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18345: Fix python binding generation for classes with deleted copy constructors

[Christophe Giboudeaux]

cgiboudeaux added a reviewer: lbeltrame.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18345

To: aacid, lbeltrame
Cc: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D17122: RFC: Use wl_display_add_socket_auto by default

[Fabian Vogt]

fvogt added a comment.


  In D17122#395704 , @romangg wrote:
  
  > In D17122#395696 , @fvogt wrote:
  >
  > > In D17122#395537 , @romangg 
wrote:
  > >
  > > > I don't think we need  a second variable effectiveSocketName. Just test 
if socketName is empty. If it is call wl_display_add_socket_auto, otherwise 
call wl_display_add_socket.
  > >
  > >
  > > If `socketName` is overwritten after using `wl_display_add_socket_auto`, 
it's not possible to call `start` twice without resetting `socketName` again.
  > >
  > > If the actual socket's name is not written to any variable, it's 
impossible to set `WAYLAND_DISPLAY` correctly in KWin.
  > >
  > > The new variable is used to be fully API compatible except if 
`socketName` was explicitly set to an empty string.
  >
  >
  > Is a Display object meant to be started and terminated more than once? But 
ok, let's make sure.
  
  
  Not sure, but it's technically possible and I don't see anything discouraging 
it.
  
  >>> According to description some autotest fails. Which one exactly?
  >> 
  >> testSocketName as the default value of socketName changed.
  >> 
  >>   FAIL!  : TestWaylandServerDisplay::testSocketName() Compared values are 
not the same
  >>  Actual   (display.socketName())   : ""
  >>  Expected (QStringLiteral("wayland-0")): "wayland-0"
  >>  Loc: 
[/home/fabian/kderepos/kwayland/autotests/server/test_display.cpp(54)]
  > 
  > Is there an argument against just checking on empty string at this 
location? Since the socket name is not yet set in line 54, there shouldn't be 
one.
  
  The argument is that the default value changed, which is technically an ABI 
break - that's why this is an RFC. If you say that it's fine, I'll do the 
change and remove the RFC.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: RFC: Use wl_display_add_socket_auto by default

[Roman Gilg]

romangg added a comment.


  In D17122#395696 , @fvogt wrote:
  
  > In D17122#395537 , @romangg 
wrote:
  >
  > > I don't think we need  a second variable effectiveSocketName. Just test 
if socketName is empty. If it is call wl_display_add_socket_auto, otherwise 
call wl_display_add_socket.
  >
  >
  > If `socketName` is overwritten after using `wl_display_add_socket_auto`, 
it's not possible to call `start` twice without resetting `socketName` again.
  >
  > If the actual socket's name is not written to any variable, it's impossible 
to set `WAYLAND_DISPLAY` correctly in KWin.
  >
  > The new variable is used to be fully API compatible except if `socketName` 
was explicitly set to an empty string.
  
  
  Is a Display object meant to be started and terminated more than once? But 
ok, let's make sure.
  
  >> According to description some autotest fails. Which one exactly?
  > 
  > testSocketName as the default value of socketName changed.
  > 
  >   FAIL!  : TestWaylandServerDisplay::testSocketName() Compared values are 
not the same
  >  Actual   (display.socketName())   : ""
  >  Expected (QStringLiteral("wayland-0")): "wayland-0"
  >  Loc: 
[/home/fabian/kderepos/kwayland/autotests/server/test_display.cpp(54)]
  
  Is there an argument against just checking on empty string at this location? 
Since the socket name is not yet set in line 54, there shouldn't be one.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns