D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

[loh tar]

loh.tar added a comment.


  
  
  > the selection becomes wrapped in two ? - is that right?
  
  Yes
  
  > if we only want this for, say, markdown, then it should be a 
per-highlightfile list of chars that trigger this special behavior
  
  How that?
  
  > if I have foo + bar and I select the + bar part and then start typing - 
asdf, would I now suddenly get foo -+ bar- asdf?!
  
  Just try it. Almost right. Due it's behavior to move the cursor at the start 
of the selection and to keep the selection it becomes `foo - asfd-`
  
  > In C++ e.g. I would hate if I couldn't just select code and replace it by 
an operator anymore,
  
  Hm, I see. IIRC has the highlight stuff functions to ask the type of 
something. So probably there is a `isOperator(QChar c)` function available. 
Will then try that.
  
  If not. Would it be too annoying to type `- SPACE asdf DEL`?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor, cullmann
Cc: mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, dhaumann

D18490: Add Virtual Desktops KCM icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:8fd382fc414e: Add Virtual Desktops KCM icon (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18490?vs=50159=50161

REVISION DETAIL
  https://phabricator.kde.org/D18490

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-virtual.svg
  icons/preferences/32/preferences-desktop-virtual.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18490: Add Virtual Desktops KCM icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Perfecto, shipit!

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-virtual-desktop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18490

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18490: Add Virtual Desktops KCM icon

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18490

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18490: Add Virtual Desktops KCM icon

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18490

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18490: Add Virtual Desktops KCM icon

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-virtual-desktop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18490

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-virtual.svg
  icons/preferences/32/preferences-desktop-virtual.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:9aec0d9cc43f: Add icons for Touch Screen and Screen Edge 
KCMs (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18483?vs=50156=50157

REVISION DETAIL
  https://phabricator.kde.org/D18483

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons-dark/preferences/32/preferences-desktop-gestures-touch.svg
  icons/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons/preferences/32/preferences-desktop-gestures-touch.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Noah Davis]

ndavis updated this revision to Diff 50156.
ndavis added a comment.


  Add change to breeze dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18483?vs=50154=50156

BRANCH
  preferences-gestures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18483

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons-dark/preferences/32/preferences-desktop-gestures-touch.svg
  icons/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons/preferences/32/preferences-desktop-gestures-touch.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Love it. Shipit!

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-gestures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Noah Davis]

ndavis updated this revision to Diff 50154.
ndavis added a comment.


  Change style of screen edges icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18483?vs=50139=50154

BRANCH
  preferences-gestures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18483

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons-dark/preferences/32/preferences-desktop-gestures-touch.svg
  icons/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons/preferences/32/preferences-desktop-gestures-touch.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18487: Reparse background contrast settings when colors changed

[Nathaniel Graham]

ngraham added a comment.


  Nice, it works great for me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18487

To: broulik, #plasma
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18474: Fix file sharing preference related icon names

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:39926c33c188: Fix file sharing preference related icon 
names (authored by ndavis).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18474?vs=50115=50149#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18474?vs=50115=50149

REVISION DETAIL
  https://phabricator.kde.org/D18474

AFFECTED FILES
  icons-dark/preferences/32/preferences-system-network-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-nfs.svg
  icons-dark/preferences/32/preferences-system-network-server-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-share-windows.svg
  icons-dark/preferences/32/preferences-system-network-server-share.svg
  icons-dark/preferences/32/preferences-system-network-share-windows.svg
  icons-dark/preferences/32/preferences-system-network-share.svg
  icons-dark/preferences/32/yast-nfs-server.svg
  icons-dark/preferences/32/yast-samba-client.svg
  icons-dark/preferences/32/yast-samba-server.svg
  icons/preferences/32/preferences-system-network-samba.svg
  icons/preferences/32/preferences-system-network-server-nfs.svg
  icons/preferences/32/preferences-system-network-server-samba.svg
  icons/preferences/32/preferences-system-network-server-share-windows.svg
  icons/preferences/32/preferences-system-network-server-share.svg
  icons/preferences/32/preferences-system-network-share-windows.svg
  icons/preferences/32/preferences-system-network-share.svg
  icons/preferences/32/yast-nfs-server.svg
  icons/preferences/32/yast-samba-client.svg
  icons/preferences/32/yast-samba-server.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18474: Fix file sharing preference related icon names

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-share (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18474

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Nathaniel Graham]

ngraham added a comment.


  Cool. I think the issue here is that the hotcorner bit is simultaneously too 
small to be easily noticeable, but visible enough to subtly unbalance the icon. 
I might recommend experimenting with making the hotcorner highlight more 
visually prominent and then adding a screen edge highlight on the right side to 
balance it out.
  
  Or here's an idea: do those things and then remove the cursor icon from it 
entirely.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

[Nathaniel Graham]

ngraham added a comment.


  Still can't actually apply the patch to land it using Phab. Can you remove 
the symlink-related changes from this patch and then provide a list of them so 
I can do them manually?

REPOSITORY
  R266 Breeze Icons

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick edited the summary of this revision.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11236: [KCrash] Establish socket to allow change of ptracer

[Christoph Roick]

croick added a comment.


  Ok, now I got it. After reading the YAMA doc again (more carefully) I realize 
that it really just is the parent that can be attached to the child by default 
and not the other way around.
  I still wonder why I seem to recall that there was a working backtrace for 
the directly started DrKonqi in the tests, although the tracer was never set. 
Sorry about that.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

[Christoph Roick]

croick edited the summary of this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added reviewers: Dolphin, apol.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D18380#398301 , @rjvbb wrote:
  
  > > The behavior is better now, thanks.
  >
  > It's back to what you liked before I started tinkering with font squeezing 
(plus a few fixes to the behaviour in side-bars).
  
  
  Much nicer. I like it! Thanks for the explanation regarding the moc change. 
Seems sane. Code overall seems sane, but please wait for a more in-depth review 
from someone else before committing.
  
  > Do you know of other applications that use this widget/mode for/in a 
filebrowser side-bar thingy or otherwise in situations where it might have 
unexpected behaviour? Neither Dolphin nor KDevelop seem to use.
  
  Check this out: 
https://lxr.kde.org/search?_filestring=&_string=KDirOperator&_casesensitive=1
  
  A few others I know off the top of my head are Okteta and K3B.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham, #frameworks, #dolphin, apol
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

[Nathaniel Graham]

ngraham added a reviewer: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18479

To: wbauer, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18487: Reparse background contrast settings when colors changed

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> theme_p.cpp:754
>  }
>  backgroundContrast = cg.readEntry("contrast", _contrast);
>  backgroundIntensity = cg.readEntry("intensity", _intensity);

An alternative approach would be to store those values and then do the default 
fallback and `qGray(color(Plasma::Theme::BackgroundColor).rgb()) < 127` stuff 
on the fly on demand.
It's runtime cpu cycles vs parsing a config file once on color change (with 
some awful copy paste)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18487

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D18450#398143 , @astippich 
wrote:
  
  > Can you add a test please?
  
  
  Done. The sample file sadly is some 2xx KB big, but the AppImage devs could 
not help to get it smaller without no longer being a real appimage, the runtime 
payload brings that weight.
  
  > In D18450#397920 , @kossebau 
wrote:
  > 
  >> There seems to be some bug with the Comment field though, somehow in 
Dolphin the comment is not shown, where "dump" displays it as existing.
  > 
  > 
  > That property "conflicts" with the xattr comment and is excluded in 
baloo-widgets because of that.
  
  I see. Guess it still makes sense to extract something for the Comment field, 
for any other consumers or the future.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo
Cc: astippich, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 50146.
kossebau added a comment.


  add unit test

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18450?vs=50077=50146

BRANCH
  addappimageextractor

REVISION DETAIL
  https://phabricator.kde.org/D18450

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/appimageextractortest.cpp
  autotests/appimageextractortest.h
  autotests/samplefiles/test.AppImage
  src/extractors/CMakeLists.txt
  src/extractors/appimageextractor.cpp
  src/extractors/appimageextractor.h

To: kossebau, #baloo
Cc: astippich, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, bruns, abrahams

D18487: Reparse background contrast settings when colors changed

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When switching between light and dark system colors, the background contrast 
might change which we didn't do at runtime leading to washed out Plasma popup 
backgrounds.
  Also, while at it, update complimentary colorscheme as well, which was 
forgotten here.
  
  BUG: 401142

TEST PLAN
  - Used Breeze Plasma theme (the one that follows system colors), switched 
from Breeze light color scheme to Breeze dark, popups immediately looked as 
they should have rather than only after a plasmashell restart

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18487

AFFECTED FILES
  src/plasma/private/theme_p.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

[Milian Wolff]

mwolff added a comment.


  can you say what this exactly does? from reading the code and the somewhat 
vague commit message, it makes me believe that when I have anything selected 
and then press e.g. `?` the selection becomes wrapped in two `?` - is that 
right? when would we ever want this?
  
  and if we only want this for, say, markdown, then it should be a 
per-highlightfile list of chars that trigger this special behavior. In C++ e.g. 
I would hate if I couldn't just select code and replace it by an operator 
anymore, e.g. if I have `foo + bar` and I select the `+ bar` part and then 
start typing `- asdf`, would I now suddenly get `foo -+ bar- asdf`?!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor, cullmann
Cc: mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, dhaumann

Re: Power Management and Inhibition by Applications

[Matthieu Gallien]

Hello,

On mercredi 23 janvier 2019 08:52:26 CET Kai Uwe Broulik wrote:
> Hi,
> 
> > I had thought that would only inhibit the screensaver instead of automatic
> > sleep.
> 
> KScreenLocker (previously KSMServer) that owns the
> org.freedesktop.ScreenSaver interface tells PowerDevil to keep the
> screen on when screensaver is inhibited. It makes no sense to prevent
> the screen from locking (ie. keep the desktop visible) but then allow
> the screen to turn off, having the same effect: hiding the desktop.
> > I did a quick test and in case I inhibit through
> > org.freedesktop.ScreenSaver interface, the battery applet does not
> > indicate any inhibit whereas through
> > org.freedesktop.PowerManagement.Inhibit indicates that an inhibition is
> > valid.
> It should and it does here. Note that PowerDevil only enforces
> inhibitions after five seconds to prevent short transient inhibitions
> (e.g. web browsers block suspend when playing audio which could also
> lead to short notification sounds prolonging the time until suspend)

I have restarted my session and it is now working. Sorry for that.

I also had somehow missed that interface. It looks to me like it is also 
supported by other desktop environments. Do you know if it is really the case 
?

> > I wonder if I should not instead make usage of the Inhibit mechanism from
> > logind coupled with powerdevil. I am not sure if this is desired.
> 
> It is and I would love that, I just haven't had the time to implement it.
> 
> Also I'm a bit tired of adding yet another inhibition interface (we
> already have like three or four of them) of the "but this time, I
> promise, it will be perfect!!" kind. Last time I checked logind didn't
> offer signals for when an inhibition was added/removed, so the "xyz is
> curently blocking PM" in Battery Monitor might not be possible anymore
> this way.
> 
> Cheers
> Kai Uwe

My understanding of the current mechanism in Logind is that except the 
"systemctl suspend" command, nothing prevent suspend when you add an inhibitor 
blocking sleep. I was hoping for this interface to be the "universal" one that 
would avoid the need to support many interfaces in an application.

As far as I understand, each software wanting to suspend has to check itself 
for any blocking inhibition for sleep. I can volunteer to add this to 
Powerdevil if this is deemed useful.

I had checked the dbus interface for logind and there is still no any signals 
to know when an inhibition is added or removed.

Best regards

--
Matthieu Gallien

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Noah Davis]

ndavis added a comment.


  In D18483#398753 , @ngraham wrote:
  
  > Maybe `preferences-desktop-gestures-screenedges` should have the cursor 
near to the hot corner to reinforce the concept? Otherwise it kind of feels 
like an icon for the cursors KCM.
  
  
  The issue with that is that it would be the only one with an uncentered 
symbol. I can make an icon for the Cursors KCM with no desktop background, so 
it shouldn't be that bad.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Nathaniel Graham]

ngraham added a comment.


  Maybe `preferences-desktop-gestures-screenedges` should have the cursor near 
to the hot corner to reinforce the concept? Otherwise it kind of feels like an 
icon for the cursors KCM.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18483

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

[Wolfgang Bauer]

wbauer added a comment.


  In D18479#398655 , @wbauer wrote:
  
  > The existing check did work fine for me back in D13782 
 also for symlinks for some reason.
  >  Maybe this broke because of some change in the kernel or glibc? :-/
  
  
  I assume the symlink had the type of the target back then (on my systems at 
least), and that has been fixed meanwhile...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18479

To: wbauer, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-gestures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18483

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons-dark/preferences/32/preferences-desktop-gestures-touch.svg
  icons/preferences/32/preferences-desktop-gestures-screenedges.svg
  icons/preferences/32/preferences-desktop-gestures-touch.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

[Wolfgang Bauer]

wbauer added a comment.


  The existing check did work fine for me back in D13782 
 also for symlinks for some reason.
  Maybe this broke because of some change in the kernel or glibc? :-/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18479

To: wbauer, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

[Wolfgang Bauer]

wbauer created this revision.
wbauer added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
wbauer requested review of this revision.

REVISION SUMMARY
  A symlink to the mountpoint of an NTFS partition can have the type DT_LNK.
  So extend the check to cover that case as well.
  
  BUG: 402738

TEST PLAN
  Create a symlink to an NTFS mountpoint.
  Open dolphin and browse to the folder containing the symlink.
  
  It is not hidden anymore.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18479

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: wbauer, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17806: Add Itinerary plugin

[Nicolas Fella]

nicolasfella abandoned this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17806

To: nicolasfella, apol, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18473: Add monochrome symlinks for preferences-system

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:14bbb8f64ba2: Add monochrome symlinks for 
preferences-system (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18473?vs=50114=50127

REVISION DETAIL
  https://phabricator.kde.org/D18473

AFFECTED FILES
  icons-dark/actions/16/preferences-system.svg
  icons-dark/actions/22/preferences-system.svg
  icons-dark/actions/24/preferences-system.svg
  icons-dark/actions/symbolic/preferences-system-symbolic.svg
  icons/actions/16/preferences-system.svg
  icons/actions/22/preferences-system.svg
  icons/actions/24/preferences-system.svg
  icons/actions/symbolic/preferences-system-symbolic.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18475: Add AsciiDoc support

[Andreas Gratzer]

andreasgr created this revision.
andreasgr added a reviewer: Framework: Syntax Highlighting.
andreasgr added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
andreasgr requested review of this revision.

REVISION SUMMARY
  AsciiDoc syntax highlighting aiming to behave like Asciidoctor and
  use colours similar to its default style sheet.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18475

AFFECTED FILES
  data/syntax/asciidoc.xml

To: andreasgr, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, #framework_syntax_highlighting, 
bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

D18474: Fix file sharing preference related icon names

[Noah Davis]

ndavis added a comment.


  In D18474#398581 , @ngraham wrote:
  
  > Screenshots would be appreciated. :)
  
  
  Sorry, I had to deal with something. The only visual difference is with the 
samba share KCM. I also added `preferences-system-network-share` to act as a 
fallback for any other KCMs that use an icon with 
`preferences-system-network-share*` before the icon actually created. That was 
the case with `preferences-system-network-share-windows`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18474

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18474: Fix file sharing preference related icon names

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18474

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18474: Fix file sharing preference related icon names

[Nathaniel Graham]

ngraham added a comment.


  Screenshots would be appreciated. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18474

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18473: Add monochrome symlinks for preferences-system

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-system-small (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18473

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18439: Add proper edit-delete-shred icons

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I've checked the files and they all look good to me.

REPOSITORY
  R266 Breeze Icons

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18473: Add monochrome symlinks for preferences-system

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18473

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18439: Add proper edit-delete-shred icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 50116.
trickyricky26 added a comment.


  - Use a pattern with wider paper strips in the 32px version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18439?vs=50067=50116

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

AFFECTED FILES
  icons-dark/actions/16/edit-delete-shred.svg
  icons-dark/actions/22/edit-delete-shred.svg
  icons-dark/actions/24/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/16/edit-delete-shred.svg
  icons/actions/22/edit-delete-shred.svg
  icons/actions/24/edit-delete-shred.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18474: Fix file sharing preference related icon names

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Fixes the names of file sharing preference related icons so that they show up 
in system settings.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-share (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18474

AFFECTED FILES
  icons-dark/preferences/32/preferences-system-network-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-nfs.svg
  icons-dark/preferences/32/preferences-system-network-server-samba.svg
  icons-dark/preferences/32/preferences-system-network-server-share-windows.svg
  icons-dark/preferences/32/preferences-system-network-server-share.svg
  icons-dark/preferences/32/preferences-system-network-share-windows.svg
  icons-dark/preferences/32/preferences-system-network-share.svg
  icons-dark/preferences/32/yast-nfs-server.svg
  icons-dark/preferences/32/yast-samba-client.svg
  icons-dark/preferences/32/yast-samba-server.svg
  icons/preferences/32/preferences-system-network-samba.svg
  icons/preferences/32/preferences-system-network-server-nfs.svg
  icons/preferences/32/preferences-system-network-server-samba.svg
  icons/preferences/32/preferences-system-network-server-share-windows.svg
  icons/preferences/32/preferences-system-network-server-share.svg
  icons/preferences/32/preferences-system-network-share-windows.svg
  icons/preferences/32/preferences-system-network-share.svg
  icons/preferences/32/yast-nfs-server.svg
  icons/preferences/32/yast-samba-client.svg
  icons/preferences/32/yast-samba-server.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18473: Add monochrome symlinks for preferences-system

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This will improve visual compatibility with some 3rd party applications that 
use preferences-system for preferences in application menus.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-system-small (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18473

AFFECTED FILES
  icons-dark/actions/16/preferences-system.svg
  icons-dark/actions/22/preferences-system.svg
  icons-dark/actions/24/preferences-system.svg
  icons-dark/actions/symbolic/preferences-system-symbolic.svg
  icons/actions/16/preferences-system.svg
  icons/actions/22/preferences-system.svg
  icons/actions/24/preferences-system.svg
  icons/actions/symbolic/preferences-system-symbolic.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18439: Add proper edit-delete-shred icons

[Nathaniel Graham]

ngraham added a comment.


  In D18439#398526 , @trickyricky26 
wrote:
  
  > Do you think these are better?
  >  F6563857: edit-delete-shred-alt-pattern-32.svg.png 

  
  
  I like this one!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

[TrickyRicky]

trickyricky26 added a comment.


  Do you think these are better?
  F6563857: edit-delete-shred-alt-pattern-32.svg.png 

  This has smaller gaps, which are still large enough imo.
  F6563859: edit-delete-shred-alt-pattern2-32.svg.png 

  This has bigger gaps and isn't quite as pretty.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

[loh tar]

loh.tar updated this revision to Diff 50104.
loh.tar edited the summary of this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Update 'What's This' hint to reflect new behaviour and to be more precise
  - Update 'What's This' hint of dyn wrap too to be more precise
  - Update/clear Summary

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17949?vs=50082=50104

REVISION DETAIL
  https://phabricator.kde.org/D17949

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateview.h

To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D18167#398360 , @aacid wrote:
  
  > In D18167#398343 , @kossebau 
wrote:
  >
  > > only 3(?) days between proposal and commit was also a very rushy
  >
  >
  > Check your dates better please, it's 9 days
  
  
  Oops, indeed, my bad, somehow my eyes slipped one line from the data of the 
"Closed by commit" to  the date of the announcement "will push next saturday". 
No coffee yet perhaps when I wrote that, the "(?)" hints I was at least unsure 
;) But yes, blame taken.
  
  Still, also 9 days I would consider a too short period for central setting 
changes. It has not been an urgent change.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: zzag, davidedmundson, kossebau, graesslin, apol, vkrause, 
kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Albert Astals Cid]

aacid added a comment.


  In D18167#398076 , @graesslin 
wrote:
  
  > The human error exists as long as clang-tidy is not used. What I fear is 
that someone does a hand porting - we have seen several attempts to do that in 
KWin from various developers. If devs don't know and now fix the warnings, they 
can bring in human error.
  
  
  The nice thing about override is that the space for human error is *very* 
thin, it either compiles and then it's good or it doesn't compile and then it's 
bad.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: zzag, davidedmundson, kossebau, graesslin, apol, vkrause, 
kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Albert Astals Cid]

aacid added a comment.


  In D18167#398343 , @kossebau wrote:
  
  > only 3(?) days between proposal and commit was also a very rushy
  
  
  Check your dates better please, it's 9 days
  
  > Though then in this very case, my own take is to be pragmatic and see that 
this change makes sense in the end and that any active KDE software projects 
which have code left which should not be upgraded to C++11 and more recent 
standards should simply on their side opt-out from this warning.
  > 
  > While talking about it, not sure what is the better approach, I have seen 
different cmake-based approaches:
  > 
  >   string(REPLACE "-Wsuggest-override" "" CMAKE_CXX_FLAGS 
"${CMAKE_CXX_FLAGS}")
  > 
  > 
  >   check_cxx_compiler_flag("-Wno-suggest-override" HAS_WNO_SUGGEST_OVERRIDE)
  >   
  >   if (${HAS_WNO_SUGGEST_OVERRIDE})
  >   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-suggest-override" )
  >   endif()
  > 
  > 
  > What would cmake professionals use here?
  
  The second one seems better to me.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: zzag, davidedmundson, kossebau, graesslin, apol, vkrause, 
kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D18167#398076 , @graesslin 
wrote:
  
  > The human error exists as long as clang-tidy is not used. What I fear is 
that someone does a hand porting - we have seen several attempts to do that in 
KWin from various developers. If devs don't know and now fix the warnings, they 
can bring in human error.
  
  
  Okay, this experience of yours hints to me why you appear to be a bit more 
sensitive about this change.  Where myself I have never seen any issues related 
to moving to override usage, rather the opposite.
  I also understand that you have an extra level of is-this-needed protection 
when it comes to kwin due to being a core product, which one could say has paid 
out so far given the stability we all enjoy with kwin. Just...
  
  > Thus I suggest that those who think this should be the default for all 
projects by KDE do the work to run clang-tidy over the complete KDE code base 
and afterwards enable this warning.
  
  As said, it seems that most of the actively maintained codebase has already 
been moved to override usage (he, I am to "blame" for that as well) in the last 
two years or so. Which also could be seen as kind of silent support for seeing 
the non-use of override something to improve.
  
  > I'm just not happy with the approach of breaking workflow without any 
discussion at all with the larger community. We have points in time where we 
can break things. E.g. the upcoming Qt 6. What I do not like is breaking in the 
middle of a release cycle without any coordination. Also I don't want to spend 
my very little spare time hunting behind what broke KWin build. I'm really not 
pleased about this from above attitude to break the compile of projects.
  
  I would not agree on the definition of "break". This change adds a warning by 
default. Same like if some new compiler version decides to be more nasty by 
default about issues it sees. Or methods being deprecated in some newer version 
of a library.
  
  I would agree though to the point of this change being done very quickly in 
just a few days and without passing this a bit more visible by the eyes of the 
bigger developer community which relies on the defaults defined by ECM's KDE 
macros.
  Just "build-system" and "frameworks" was not really sufficient here given the 
scope it effects, and only 3(?) days between proposal and commit was also a 
very rushy, ignoring that the major community might not be able to comment 24/7 
on things.  In a perfect organisation this change of default settings would 
have been exposed some more.
  I do not think though this is "from above attitude", but more a 
"sane-to-me-and-my-circle-so-must-be-sane-to-everyone attitude" or a 
"afraid-of-potential-bikeshedding-discussion attitude"?  Not healthy in any 
case.
  
  So -1 on the execution of this change from me as well.
  
  Though then in this very case, my own take is to be pragmatic and see that 
this change makes sense in the end and that any active KDE software projects 
which have code left which should not be upgraded to C++11 and more recent 
standards should simply on their side opt-out from this warning.
  
  While talking about it, not sure what is the better approach, I have seen 
different cmake-based approaches:
  
string(REPLACE "-Wsuggest-override" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
  
check_cxx_compiler_flag("-Wno-suggest-override" HAS_WNO_SUGGEST_OVERRIDE)

if (${HAS_WNO_SUGGEST_OVERRIDE})
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-suggest-override" )
endif()
  
  What would cmake professionals use here?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: zzag, davidedmundson, kossebau, graesslin, apol, vkrause, 
kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

[René J . V . Bertin]

rjvbb added a reviewer: Frameworks.
rjvbb added a subscriber: kwrite-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

[René J . V . Bertin]

rjvbb added a comment.


  > The behavior is better now, thanks.
  
  It's back to what you liked before I started tinkering with font squeezing 
(plus a few fixes to the behaviour in side-bars).
  
  Do you know of other applications that use this widget/mode for/in a 
filebrowser side-bar thingy or otherwise in situations where it might have 
unexpected behaviour? Neither Dolphin nor KDevelop seem to use.

INLINE COMMENTS

> ngraham wrote in kdiroperatordetailview.cpp:296
> This is almost always wrong. Can you explain why you think it's required here?

I didn't think anything, I did what an error message told me.

When I remove the include it comes back:

  [ 78%] Automatic MOC for target KF5KIOFileWidgets
  cd /path/to/build/src/filewidgets && /opt/local/bin/cmake -E cmake_autogen 
/path/to/build/src/filewidgets/CMakeFiles/KF5KIOFileWidgets_autogen.dir/AutogenInfo.cmake
 MacPorts
  AutoMoc error
  -
"/path/to/kio-git/src/filewidgets/kdiroperatordetailview.cpp"
  The file contains a Q_OBJECT macro, but does not include 
"kdiroperatordetailview.moc"!
  Consider to
   - add #include "kdiroperatordetailview.moc"
   - enable SKIP_AUTOMOC for this file
  
  make[2]: *** [src/filewidgets/CMakeFiles/KF5KIOFileWidgets_autogen] Error 1

It must be due to the fact that I put the entire KDirHeaderView class 
definition into the implementation file, which I did because it's really 
private and changes to it shouldn't trigger a rebuild  of a large number of 
files that are not concerned by those changes at all 
(kdiroperatordetailview_p.h is included by quite a few files).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns