D17932: Improvements to completion

[Milian Wolff]

mwolff added a comment.


  I'm in favor!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17932

To: thomassc, #ktexteditor, #kdevelop, mwolff
Cc: dhaumann, apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, 
kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, head7, sars

D18163: Set the color scheme to Printing for Print Preview

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  yes, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  print-preview-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18612: Cache the default KColorScheme configuration

[Milian Wolff]

mwolff added a comment.


  sure, but first let's get this in. @broulik or @dfaure care to give your +1?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D18612

To: mwolff, #kate, #kdevelop, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17734: Add Opus support for KIO AudioCD

[Yuri Chornoivan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R342:ed3eb5a6a3e9: Add Opus support for KIO AudioCD (authored 
by yurchor).

REPOSITORY
  R342 KIO AudioCD

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17734?vs=48392=50906

REVISION DETAIL
  https://phabricator.kde.org/D17734

AFFECTED FILES
  CMakeLists.txt
  HACKING
  kcmaudiocd/kcmaudiocd.cpp
  plugins/CMakeLists.txt
  plugins/opus/CMakeLists.txt
  plugins/opus/Messages.sh
  plugins/opus/audiocd_opus_encoder.kcfg
  plugins/opus/audiocd_opus_encoder.kcfgc
  plugins/opus/encoderopus.cpp
  plugins/opus/encoderopus.h
  plugins/opus/encoderopusconfig.ui

To: yurchor, #kde_applications, #frameworks, aacid
Cc: aacid, ngraham, cfeck

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405368 , @ngraham wrote:
  
  > One thing I will not do in this patch is synthesize a fake button that has 
different behaviors from the standard button. If there's a problem with our 
buttons we need to fix it everywhere, not work around it here (and elsewhere).
  >
  > Here are our two options:
  >
  > F6588077: Inline dark buttons.gif 
  >
  > F6588078: Slightly escaping light buttons.gif 

  >
  > Maybe we should just take a vote.
  
  
  Both are very compelling, I must say! I like version 1 better.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  One thing I will not do in this patch is synthesize a fake button that has 
different behaviors from the standard button. If there's a problem with our 
buttons we need to fix it everywhere, not work around it here (and elsewhere).
  
  Here are our two options:
  
  F6588077: Inline dark buttons.gif 
  
  F6588078: Slightly escaping light buttons.gif 

  
  Maybe we should just take a vote.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Chris Rizzitello]

rizzitello added a comment.


  I think it looks better slightly off the edge of the item and I agree that if 
its on the item its looks much better with the shaded bar under it.  To improve 
the contrast we could make the button our highlight color when hovered.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

[Stefan Brüns]

bruns added a comment.


  As fvogt already said, the current (old) code is wrong, the event should not 
be blindly ignored (line 97).
  
  The second change fvogt mentioned is IMHO handled quite strangely here - 
`!m_enabled || m_temporaryInhibition` is the inverse of `!m_enabled || 
m_temporaryInhibition`, so doing a `event->ignore()` === 
`event->setAccepted(false)` prior to the first return statement would cover the 
ignored case, and allows the event to bubble up.
  
  This leaves the cases where the area is neither disabled nor inhibited. For 
large moves (pos() changed >= 1.0 pixels), the event is accepted, and the event 
is delivered to the quick item, where it can be left as is (accepted), or reset 
to ignored by the code.
  
  Why is a small move handled differently? Shouldn't the `if (event->pos() == 
oldDragMovePos)` code path be removed completely?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Filip Fila]

filipf added a comment.


  Round buttons looked nice, but the square buttons fit in a lot more with 
Breeze.
  
  As for the color, in a vacuum I think the dark buttons look better, but 
contextually they feel weird to me as well. We're used to everything following 
the color scheme.
  
  Inline vs. vertical offset seems like a tomayto tomatoh thing. The offset 
does seem a bit snazzier a bit though, but I don't seem to able to articulate 
why exactly.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

[David Edmundson]

davidedmundson edited the test plan for this revision.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18739

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In systemsettings 6a9df821ecfaa008206a260b20f595136e254821 
 it 
was
  determined that the QML KCMs should do their own padding for some
  reason.
  
  QML KCMs now do this to match what's expected in system settings.
  
  This change was not mirrored in KMultiDialog (and hence kcmshell5)
  
  Populating d->modules had to move in order to make sure this was
  available when the first page was sadding.

TEST PLAN
  Ran kcmshell5 autostart (a qwidgets module) main frame still matched where 
the buttons where
  Ran kcmsheel5 lookandfeel (a qtquick module) main frame now matches where the 
buttons are

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18739

AFFECTED FILES
  src/kcmultidialog.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  The dark inline buttons entirely within the thumbnail are growing on me. I'll 
sleep on it.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

[Nathaniel Graham]

ngraham added a comment.


  @bruns? Last call before we land this. :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D18738: Add ebook thumbnailer

[Kai Uwe Broulik]

broulik updated this revision to Diff 50896.
broulik added a comment.


  - Resolve path to cover relative to OPF file
  - Search for `iTunesArtwork` as fallback
  - Search for any file `*cover*` as fallback

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18738?vs=50894=50896

REVISION DETAIL
  https://phabricator.kde.org/D18738

AFFECTED FILES
  thumbnail/CMakeLists.txt
  thumbnail/ebookcreator.cpp
  thumbnail/ebookcreator.h
  thumbnail/ebookthumbnail.desktop

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18738: Add ebook thumbnailer

[Andres Betts]

abetts added a comment.


  +1
  
  Awesome!

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18738: Add ebook thumbnailer

[Nathaniel Graham]

ngraham added a comment.


  Works great for most of my ePubs. Here's an archive of some public-domain 
books in my collection that don't work.F6587654: ePubs that don't get 
thumbnails.tar.gz 

INLINE COMMENTS

> ebookthumbnail.desktop:3
> +Type=Service
> +Name=Electronic Book
> +

How about "eBooks" or "eBook Files" (a more common term, and all the other 
entries are plural)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

To: broulik, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18638: Avoid using trimmed method

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> highlighter.cpp:311
>  {
> -if (text.trimmed().isEmpty() || !d->active || !d->spellCheckerFound) {
> +if (!hasNotEmptyText(text) || !d->active || !d->spellCheckerFound) {
>  return;

if (std::all_of(text.cbegin(), text.cend(),
  [](QString::const_iterator it) { return it->isSpace(); })
  {
  return;
  }

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18638

To: mlaurent, dfaure
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham

D18734: Update octave.xml to Octave 4.2.0

[Dominik Haumann]

dhaumann added a comment.


  ...And there are also new Default Styles for kateversion="5.0", see: 
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
  
  Maybe you could also use these for the itemData, like for Operator 
dsOperator, or for Builtin dsBuiltIn, for Variable dsVariable. Ideally, the 
itemDatas would not have any hard-coded color anymore at all, since then the 
highlighting will work with all color schemas out of the box.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Dominik Haumann]

dhaumann added a comment.


  Could you also switch to WordDetect for the trivial cases, and set 
kateversion="5.0" ?

INLINE COMMENTS

> octave.xml:2690-2711
>   beginRegion="block" />
>   endRegion="block" />
>   beginRegion="block" />
>   endRegion="block" />
>   beginRegion="block" />
>   endRegion="block" />
>   beginRegion="block" />

While you are working on this, could you change all RegExpr that use the simple 
\b...\b form into a WordDetect form? See: 
https://docs.kde.org/trunk5/en/applications/katepart/highlight.html

  

This would be much faster than general purpose RegExps.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/13/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Feb 2019 21:37:47 +
 Build duration:
3 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 04 Feb 2019 21:37:46 +
 Build duration:
4 min 14 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3602/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/17/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 04 Feb 2019 21:37:46 +
 Build duration:
3 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D18604: Implement support for writing rating information for taglib writer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibwriter.cpp:229
> +writeID3v2Tags(file.ID3v2Tag(), properties);
> +}
>  file.save();

Is this the same as

  auto id3Tags = dynamic_cast(file.tag());
  if (id3Tags) { ... }

?

> taglibwriter.cpp:279
> +if (mp4Tags) {
> +qDebug() << QStringLiteral("enter");
> +writeMp4Tags(mp4Tags, properties);

leftover ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18630: Fix warning

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:901ae4083442: Fix warning (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18630?vs=50602=50895

REVISION DETAIL
  https://phabricator.kde.org/D18630

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TextArea.qml

To: apol, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18738: Add ebook thumbnailer

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

To: broulik, #plasma, #vdg
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18601: Rewrite taglib writer to use property interface

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibwriter.cpp:70
>  
> -if (properties.contains(Property::Title)) {
> -title = 
> QStringToTString(properties.value(Property::Title).toString());
> -tags->setTitle(title);
> +void writeGenericProperties(TagLib::PropertyMap , const 
> PropertyMap )
> +{

When you make this
`void writeGenericProperties(Taglib::File *file, const PropertyMap 
)`, you can do `file->properties(); {/* merge */}; 
file->setProperties(...);` here, saving most of the duplicate code below.

dito for the specializations in D18604 , 
just pass in `Taglib::File*`, and call `auto tags = 
dynamic_cast(file->tag());` there.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18738: Add ebook thumbnailer

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This can extract thumbnails from epub and fb2 ("fiction book", both zipped 
and unzipped) files.

TEST PLAN
  F6587587: Screenshot_20190204_222436.png 


REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

AFFECTED FILES
  thumbnail/CMakeLists.txt
  thumbnail/ebookcreator.cpp
  thumbnail/ebookcreator.h
  thumbnail/ebookthumbnail.desktop

To: broulik, #plasma, #vdg
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18731: Replace KIconThemes dependency with equivalent QIcon usage

[Christoph Feck]

cfeck added a comment.


  Are application-specific icons now accessible with QIcon::fromTheme? Think 
Konqueror favicons in bookmark menu.
  
  Also, according to 
https://api.kde.org/frameworks/kbookmarks/html/kbookmarks-dependencies.html 
KBookmarks indirectly depends on KIconThemes via KTextWidgets anyway.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18731

To: vkrause, davidedmundson
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D18603: Implement more tags for taglib writer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibwriter.cpp:134
>  TagLib::MPEG::File file(, 
> TagLib::ID3v2::FrameFactory::instance(), false);
> -auto savedProperties = file.properties();
> -writeGenericProperties(savedProperties, properties);

I think you have to rediff this ...

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglibwriter2

REVISION DETAIL
  https://phabricator.kde.org/D18603

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17734: Add Opus support for KIO AudioCD

[Albert Astals Cid]

aacid added a comment.


  i'll test it later today

REPOSITORY
  R342 KIO AudioCD

REVISION DETAIL
  https://phabricator.kde.org/D17734

To: yurchor, #kde_applications, #frameworks
Cc: aacid, ngraham, cfeck

D18665: Cleanup taglib writer test

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  simplify_writing_test

REVISION DETAIL
  https://phabricator.kde.org/D18665

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17302: Add test for adding properties to result

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> resulttest.cpp:63
> +QCOMPARE(keywords->type(), QVariant::List);
> +QCOMPARE(keywords->toList().count(), 2);
> +

This looks wrong to me ...
How many items do you get when you append "keyword3" first and ["keyword1", 
"keyword2"] next?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18116: Add TODO KF6 note

[Dominik Haumann]

dhaumann accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405214 , @ngraham wrote:
  
  > I want to point out that the original problem was not that the buttons 
lacked contrast, but that the //icons// were illegible with a variety of 
thumbnail contents. This problem is 100% solved by using a real button with 
background that uses the system color scheme in some capacity (theme-following 
or inverted). Whether the button backgrounds should be theme-following or 
inverted is an aesthetic judgment, not a usability one.
  
  
  Exactly. My argument is to support the direction for usability purposes and 
add an aesthetic element that helps contrast. I think others in the discussion 
want to stop at the usability fix, I want to push that a little more and add 
the aesthetic element.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  I want to point out that the original problem was not that the buttons lacked 
contrast, but that the //icons// were illegible with a variety of thumbnail 
contents. This problem is 100% solved by using a real button with background 
that uses the system color scheme in some capacity (theme-following or 
inverted). Whether the button backgrounds should be theme-following or inverted 
is an aesthetic judgment, not a usability one.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D17734: Add Opus support for KIO AudioCD

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.
ngraham added a comment.


  I can't test because I lack any CD reading hardware. :(
  
  Can anyone else test and review?

REPOSITORY
  R342 KIO AudioCD

REVISION DETAIL
  https://phabricator.kde.org/D17734

To: yurchor, #kde_applications, #frameworks
Cc: aacid, ngraham, cfeck

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405210 , @abetts wrote:
  
  > In D18649#405209 , @GB_2 wrote:
  >
  > > In D18649#405200 , @ngraham 
wrote:
  > >
  > > > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  > > >
  > > > F6587345: Screenshot_20190204_130444.png 

  > > >
  > > > I have to admit, it ain't half bad.
  > >
  > >
  > > I still think it looks better if it follows the color scheme.
  >
  >
  > Why do you think that? Context?
  
  
  For the reasons @ngraham gave.
  It just doesn't look right IMO.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405209 , @GB_2 wrote:
  
  > In D18649#405200 , @ngraham 
wrote:
  >
  > > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  > >
  > > F6587345: Screenshot_20190204_130444.png 

  > >
  > > I have to admit, it ain't half bad.
  >
  >
  > I still think it looks better if it follows the color scheme.
  
  
  Why do you think that? Context?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405200 , @ngraham wrote:
  
  > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  >
  > F6587345: Screenshot_20190204_130444.png 

  >
  > I have to admit, it ain't half bad.
  
  
  I still think it looks better if it follows the color scheme.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405200 , @ngraham wrote:
  
  > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  >
  > F6587345: Screenshot_20190204_130444.png 

  >
  > I have to admit, it ain't half bad.
  
  
  Thank you for trying it out Nate. I appreciate your willingness to take turns 
in our thinking.
  
  I agree, it doesn't look bad. If it was placed the way you proposed, at the 
top right, or bottom right, a little over the image frame, it would stand out 
even more. Either way works for me.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  
  F6587345: Screenshot_20190204_130444.png 

  
  I have to admit, it ain't half bad.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405180 , @ngraham wrote:
  
  > In D18649#405179 , @abetts wrote:
  >
  > > I was thinking of dark buttons mostly. Something along these lines\
  > >
  > > https://dribbble.com/shots/5204192-Buttons-Dark
  > >
  > > I think the breeze default color is just too close to white, the contrast 
with regular buttons is pretty low IMHO.
  >
  >
  >
  >
  > 1. If there's a problem with Breeze colors, we should fix it there rather 
than working around this in downstream software
  
  
  I disagree on this point. I feel the problem we experience is the belief that 
breeze colors should be slapped on every element on the desktop. There is 
nothing wrong with Breeze colors, but we should allow for variations within 
without thinking that Breeze needs to change. I am suggesting that we can make 
these buttons show more contrast by "not" using the main gray breeze color as 
the background for them. Instead we use something a little more subtle and that 
can help our line-art icons stand out. You proposed a really good idea of 
floating buttons but we have bumped into the same problem we did before, that 
the contrast of these buttons is not great.
  
  > 2. If anything I think the gray color used for our button backgrounds is 
too dark, not too light. Right now it's the exact same color as the window 
background. Most other color schemes make buttons a bit lighter, and I think 
that looks better in general
  > 3. The only elements that use a dark background with the Breeze light theme 
are tooltips; making only these buttons dark would be inconsistent with every 
other button in every other piece of KDE software
  
  And to the user, what does this mean? I think it means something to us, but 
not necessarily them. I don't see users saying, "OMG, this button is dark, not 
light, that color belongs in tooltips... KDE is so inconsistent..." To me, what 
works here is practicality. By trying to align the concepts to the rest of the 
desktop environment, we are limiting ourselves from providing good contrast and 
practical functionality.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Kai Uwe Broulik]

broulik added a comment.


  Can we put the buttons at least fully inside the frame? With the boxes 
halfway outside it looks weird imho

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  In D18649#405179 , @abetts wrote:
  
  > I was thinking of dark buttons mostly. Something along these lines\
  >
  > https://dribbble.com/shots/5204192-Buttons-Dark
  >
  > I think the breeze default color is just too close to white, the contrast 
with regular buttons is pretty low IMHO.
  
  
  
  
  1. If there's a problem with Breeze colors, we should fix it there rather 
than working around this in downstream software
  2. If anything I think the gray color used for our button backgrounds is too 
dark, not too light. Right now it's the exact same color as the window 
background. Most other color schemes make buttons a bit lighter, and I think 
that looks better in general
  3. The only elements that use a dark background with the Breeze light theme 
are tooltips; making only these buttons dark would be inconsistent with every 
other button in every other piece of KDE software

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405162 , @GB_2 wrote:
  
  > I think it looks good.
  
  
  I was thinking of dark buttons mostly. Something along these lines\
  
  https://dribbble.com/shots/5204192-Buttons-Dark
  
  I think the breeze default color is just too close to white, the contrast 
with regular buttons is pretty low IMHO.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko created this revision.
sirgienko added a reviewer: Framework: Syntax Highlighting.
sirgienko added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sirgienko requested review of this revision.

REVISION SUMMARY
  I have updated keywords, commands, builtions and functions. As you can see, i 
move all builtins with normal name to functions list (like it was done before 
in third version), because builtins have highlight different from functions 
(for example, `acos` is builtin and `acot` is function, so if we *really* fill 
builtins list by octave builtions, file will turn into colour mess).
  
  I aslo have added new blocks for classes. But some of them (`events`, 
`methods`, etc.) valid only into `classdef` block, how I could add resctriction 
for this?

TEST PLAN
  As I see, there aren't tests for octave, right?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  octave

REVISION DETAIL
  https://phabricator.kde.org/D18734

AFFECTED FILES
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  I think it looks good.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  I like this version because it feels slightly more conventional with the 
square-ish KDE-style buttons. A blend of old and new, so to speak. It says, "I 
may be modern and sleek, but I'm still a powerful KDE app, not some garbage 
mobile UI inappropriately applied to the traditional desktop you know and love."
  
  At least, that's what it says to me. :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405156 , @ngraham wrote:
  
  > Use square buttons and put them on the bottom right, not the top right
  
  
  The functionality seems great! We might need to do more padding with labels. 
Is there any way we can style the buttons in different ways? Colors, shades, 
etc? I don't mind the square but doesn't look very good when it uses regular 
breeze colors.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50879.
ngraham added a comment.


  Use square buttons and put them on the bottom right, not the top right

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50869=50879

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405153 , @ngraham wrote:
  
  > Nah, it's actually fine:
  >
  > F6587198: Screenshot_20190204_122428.png 

  
  
  Oh, ok, then it's fine!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Nah, it's actually fine:
  
  F6587198: Screenshot_20190204_122428.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  Now that I think about it though, the buttons overlap the label of the label 
text is long...

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405146 , @ngraham wrote:
  
  > Like this? Or fully contained within the thumbnail?
  >
  > F6587190: Screenshot_20190204_122020.png 

  
  
  This is good!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns added a comment.


  In D18698#404820 , @poboiko wrote:
  
  > Explained the race condition in summary, expanded test to check if watches 
were installed correctly.
  
  
  I am not sure if I understood your description correctly, but I am quite sure 
this race condition does not exist - the files/folders inside the moved folder 
are not created/moved one by one, but the containing folder ist just "renamed" 
- it is unlinked from the old parent and linked into the new one, atomically.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Like this? Or fully contained within the thumbnail?
  
  F6587190: Screenshot_20190204_122020.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kinotify.cpp:430
> +// HACK: For some reason, it.fileInfo() returns an 
> empty QFileInfo for `path` here
> +// Creating new QFileInfo works fine though
> +QFileInfo fi(it.filePath());

FilteredDirIterator  is somewhat odd, as it returns the traversed folder itself 
as the first element (if not filtered/excluded by the config).

The folder itself has no fileInfo, as it is not backed by a QDirIterator item. 
Unfortunately, this is not really trivial to fix.

Instead of creating another QFileInfo for each item, you can just do the 
following:

  if (event->mask & IN_ISDIR) {
  Baloo::FilteredDirIterator it(d->config, QFile::decodeName(path));
  if (!it.next().isEmpty()) {
  // add folder itself, it not excluded
  d->addWatch(it.filePath());
  }
  while (!it.next().isEmpty()) {
  Q_EMIT created(it.filePath(), it.fileInfo().isDir());
  if (it.fileInfo().isDir()) {
  d->addWatch(it.filePath());
  }
  }
  }
  Q_EMIT created(QFile::decodeName(path), event->mask & IN_ISDIR);

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405137 , @ngraham wrote:
  
  > Not sure I catch your meaning, sorry. How big should the square buttons be? 
I kinda like them at that size TBH. Gwenview also has inline square hover 
buttons like this and it's fine.
  
  
  Ok, but can we put them on the bottom right?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18116: Add TODO KF6 note

[loh tar]

loh.tar updated this revision to Diff 50875.
loh.tar added a comment.


  - Move to correct function
  
  Good catch :-)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18116?vs=50759=50875

REVISION DETAIL
  https://phabricator.kde.org/D18116

AFFECTED FILES
  src/include/ktexteditor/document.h

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Not sure I catch your meaning, sorry. How big should the square buttons be? I 
kinda like them at that size TBH. Gwenview also has inline square hover buttons 
like this and it's fine.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  I'm not a expert in abi-complience-checker, so we need to find out together...
  
  In T3689#175022 , @danders wrote:
  
  >
  
  
  The ABI error started with build 4:
  https://build.kde.org/job/Calligra/job/kdiagram/job/kf5-qt5%20SUSEQt5.10/4/
  
  but yes I can't see why the symbols are changed. Maybe the Qt version was 
switched in between. But from the error type it sounds like, that acc do not 
get the needed information of the underlying structure of QSet/QPair and can't 
garantee that this structure will be the same in future.
  
  > Afaics these lines have not been changed since last release.
  
  Well we don't have a released version with ABI, so we just check them against 
a470d77be5a33529a95eb89243ddfaef6ee27ee7 
. 
This will change if the next version is released.
  
  > Also it does not complain about similar use in calligra (although not 
*exactly* the same, calligra uses other datatypes)
  
  
  
  > Can anybody shed any light on this?
  
  well you can dig more into it by getting the abi dumps:
  https://build-artifacts.kde.org/production/ABIReference/
  
  after you downloaded two of the dumps you can check them again locally:
  
abi-compliance-checker -l KGrantt --old  --new 
  
  than you can look to all outputs yourself.
  
  The abidumps look different:
  
  for a470d77be5a33529a95eb89243ddfaef6ee27ee7 
:
  
'90987' => {
 'Algn' => 1,
 'Header' => 'qpair.h',
 'Line' => '49',
 'Memb' => {
 '0' => {
  'algn' => 1,
  'name' => 'first',
  'type' => '11416'
},
 '1' => {
  'algn' => 1,
  'name' => 'second',
  'type' => '11416'
}
   },
 'Name' => 'QPair',
 'TParam' => {
   '0' => {
'name' => 'struct QDateTime'
  },
   '1' => {
'name' => 'struct QDateTime'
  }
 },
 'Type' => 'Struct'
   },
  
  and for f7f9ca1a7a8bfd550022ca4aafe3bb2985a1bee4 

  
'90223' => {
 'Algn' => 1,
 'Header' => 'qpair.h',
 'Line' => '49',
 'Name' => 'QPair',
 'TParam' => {
   '0' => {
'name' => 'struct QDateTime'
  },
   '1' => {
'name' => 'struct QDateTime'
  }
 },
 'Type' => 'Struct'
   },
  
  so yeah somehow it does not get as much information out of qpair.h as before.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405094 , @ngraham wrote:
  
  > In D18649#405091 , @GB_2 wrote:
  >
  > > What if the buttons just looked normal and not so big and not as circles?
  >
  >
  > With regular-sized square buttons:
  >
  > F6587075: Small square buttons.png 
  
  
  Maybe twice as big buttons on the bottom right?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18731: Replace KIconThemes dependency with equivalent QIcon usage

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18731

To: vkrause, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18731: Replace KIconThemes dependency with equivalent QIcon usage

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18731

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kbookmarkdialog.cpp

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  In D18649#405091 , @GB_2 wrote:
  
  > What if the buttons just looked normal and not so big and not as circles?
  
  
  With regular-sized square buttons:
  
  F6587075: Small square buttons.png 

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  Just some variations on Nate's idea:
  
  https://dribbble.com/shots/4981650-Floating-Button-Micro-Interaction
  
  https://dribbble.com/shots/2619684-Expense-Floating-Button
  
  The floating buttons is a very Android-unique feature. Not sure we are 
copying that if we utilize something similar. But I think it is very effective. 
It keeps the action buttons where the actions are happening. This also reminds 
me of the way that the mobile version of pinterest works.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  What if the buttons just looked normal and not so big and not as circles?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18730: Use breeze icons for search providers

[Nathaniel Graham]

ngraham added a comment.


  In D18730#405089 , @shubham wrote:
  
  > @ngraham I had a look at KuriFilter in frameworks, 
iconNameForPreferredSearchProvider() function is producing same icon name for 
all the entries.
  
  
  That's probably where we should fix this, then.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

[Shubham]

shubham added a comment.


  @ngraham I had a look at KuriFilter in frameworks, 
iconNameForPreferredSearchProvider() function is producing same icon name for 
all the entries.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

[Nathaniel Graham]

ngraham added reviewers: Frameworks, cfeck.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405082 , @ngraham wrote:
  
  > In D18649#405081 , @abetts wrote:
  >
  > > In D18649#405078 , @ngraham 
wrote:
  > >
  > > > Use round buttons in the corner rather than an inline toolbar
  > >
  > >
  > > What does it look like now?
  >
  >
  > Test Plan section updates with new screenshots. :)
  
  
  That looks very interesting. Very Android in the way that the buttons are 
laid out. I like them. I think it is a good direction. It may be a bit rough, I 
will propose some examples along this idea.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  In D18649#405081 , @abetts wrote:
  
  > In D18649#405078 , @ngraham 
wrote:
  >
  > > Use round buttons in the corner rather than an inline toolbar
  >
  >
  > What does it look like now?
  
  
  Test Plan section updates with new screenshots. :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405078 , @ngraham wrote:
  
  > Use round buttons in the corner rather than an inline toolbar
  
  
  What does it look like now?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50869.
ngraham added a comment.


  Use round buttons in the corner rather than an inline toolbar

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50662=50869

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18714: Add some Maxima constans and function

[Nikita Sirgienko]

sirgienko closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18714

To: sirgienko, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18116: Add TODO KF6 note

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> document.h:394
> +// TODO KF6: Not needed anymore since we show load trouble as 
> KTextEditor::Message.
> +//  Remove all code which set m_openingErrorMessage
>  bool openingError() const;

Hm, is it really that `bool openingError()` is not needed anymore? I thought 
this is about `bool openingErrorMessage()` that is not required anymore.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18714: Add some Maxima constans and function

[Dominik Haumann]

dhaumann added a comment.


  In your branch, you should type: `arc land`
  This will merge your branch to master and commit/push your changes, and close 
this revision. This only works, if you have commit access. If not, we'll take 
care of this for now.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18714

To: sirgienko, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

[Harald Sitter]

sitter added a comment.


  BTw, am I missing something or shouldn't this entire kioslave lookup be made 
static? It only needs computing once but currently is run for every new slave 
that gets started (in fork-mode).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18725

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the kioslave harness is installed to LIBEXEC_KF5 which is '$libexec/' on
  win32 (technically $bindir) and '$libexec/kf5/' everywhere else.
  since we cannot expect qt.conf to point to the $libexec/kf5/ path
  (what with other bits of the application or libraries wanting to find
  their own stuff in libexec), we need to explicitly try to search the
  suffixed version as well. IOW: the expectation is that the path is
  `/foo/libexec/` and we'll also want to check `/foo/libexec/kf5/` as that
  is where the binary may be located on !win32.
  
  this enables !win32 builds to be somewhat more relocatable, so long as
  qt.conf contains a suitable path config

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18725

AFFECTED FILES
  src/core/slave.cpp

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 04 Feb 2019 12:42:40 +
 Build duration:
5 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)

D14927: KConfig: handle directory symlinks correctly.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14927

To: dfaure, adridg, arichardson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14927: KConfig: handle directory symlinks correctly.

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14927

To: dfaure, adridg, arichardson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Igor Poboiko]

poboiko updated this revision to Diff 50832.
poboiko edited the summary of this revision.
poboiko added a comment.


  Explained the race condition in summary, expanded test to check if watches 
were installed correctly.
  
  I've encountered some pretty weird issue: the watch for the moved folder is 
not installed; but it is installed for all its subfolders.
  The reason is that `it.fileInfo()` returns empty `QFileInfo()` for the moved 
folder. But it works fine for all the subentries.
  That is not the issue with the previous version, because `KInotify::addWatch` 
doesn't check for `fileInfo().isDir()` explicitly: it just relies on `DirsOnly` 
flag for the iterator.
  
  There is a workaround: if I create `QFileInfo` by hand, using `QFileInfo 
fi(it.filePath())` instead of `it.fileInfo()`, everything seems to be working 
fine.
  (the test fails if I use `it.fileInfo()`, but it passes if I use this 
workaround)

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18698?vs=50776=50832

BRANCH
  add-watch-moved (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18698

AFFECTED FILES
  autotests/unit/file/kinotifytest.cpp
  src/file/kinotify.cpp

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM, thanks!

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Igor Poboiko]

poboiko marked 2 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/23/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 04 Feb 2019 08:24:51 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18653: [PreviewJob] Also pass along that we're the thumbnailer when stat'ing file

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fa6eaac55beb: [PreviewJob] Also pass along that 
were the thumbnailer when stating file (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18653?vs=50670=50817

REVISION DETAIL
  https://phabricator.kde.org/D18653

AFFECTED FILES
  src/widgets/previewjob.cpp

To: broulik, #frameworks, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns