D18878: Force NT1 protocol when listing smb:// network

[Mikhail Novosyolov]

mikhailnov updated this revision to Diff 51302.
mikhailnov added a comment.


  smbc_setOptionProtocols()  does not edit context. smbc_set_context(nullptr) 
will not change context, but will only return existing one.
  
  P.S. qCDebug(KIO_SMB) does not print anything for some reason now...

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18878?vs=51259&id=51302

REVISION DETAIL
  https://phabricator.kde.org/D18878

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb_browse.cpp

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18891: Avoid leaking a QObject in ExternalExtractor

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Passing a nullptr as a parent is fine, passing an untracked object
  definitely is not.

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18891

AFFECTED FILES
  src/externalextractor.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18882: [Image Thumbnailer] Support eps files

[Pino Toscano]

pino added a comment.


  In D18882#408915 , @broulik wrote:
  
  > But that will create additional, potentially defunct entries in Previewer 
settings?
  
  
  without kio-extras there isn't any previewer available...

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure, ngraham
Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18883: Add PDF thumbnailer

[Pino Toscano]

pino added a comment.


  In D18883#408893 , @ngraham wrote:
  
  > Conceptually I think it makes sense to have all the thumbnailers in their 
own package so it's easy to remove them all if for people who really don't want 
them.
  
  
  ... resulting in a single package with lots of dependencies. Or the 
distributions will split the package (how?), getting compliants from upstream 
(yay?).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18882: [Image Thumbnailer] Support eps files

[Kai Uwe Broulik]

broulik added a comment.


  But that will create additional, potentially defunct entries in Previewer 
settings?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure, ngraham
Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18882: [Image Thumbnailer] Support eps files

[Pino Toscano]

pino added a comment.


  Then just ship a desktop file for that format in kimageformats:
  
  - if kio-extras is not installed, that desktop file will be unused (although 
just a couple of kilobytes on disk)
  - if ko-extras is installed, it will register PS as thumbnail format using 
imagethumbnail
  
  The same change can IMHO be done for all the formats currently in MimeType, 
and that provided by kimageformats.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure, ngraham
Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18882: [Image Thumbnailer] Support eps files

[Kai Uwe Broulik]

broulik planned changes to this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure, ngraham
Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D17245: Add string formatting function to property info

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  display_value

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D18882: [Image Thumbnailer] Support eps files

[Kai Uwe Broulik]

broulik added a comment.


  Ah, yeah, it tries and if it fails, it aborts, it doesn't try every 
thumbnailer that claims to support a format.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure, ngraham
Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18882: [Image Thumbnailer] Support eps files

[Kai Uwe Broulik]

broulik added a comment.


  > OTOH this will not work if kimageformats is not installed, and the 
thumbnailer gives no hint about that.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure, ngraham
Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18883: Add PDF thumbnailer

[Kai Uwe Broulik]

broulik updated this revision to Diff 51292.
broulik added a comment.


  - Render image at desired size already
  - Remove unused include

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18883?vs=51290&id=51292

REVISION DETAIL
  https://phabricator.kde.org/D18883

AFFECTED FILES
  thumbnail/CMakeLists.txt
  thumbnail/pdfcreator.cpp
  thumbnail/pdfcreator.h
  thumbnail/pdfthumbnail.desktop

To: broulik, dfaure, aacid, jtamate
Cc: ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18882: [Image Thumbnailer] Support eps files

[Pino Toscano]

pino added a comment.


  OTOH this will not work if kimageformats is not installed, and the 
thumbnailer gives no hint about that.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure, ngraham
Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18878: Force NT1 protocol when listing smb:// network

[Nathaniel Graham]

ngraham added reviewers: Dolphin, Frameworks, sitter, broulik.
ngraham added a comment.


  This fixes https://bugs.kde.org/show_bug.cgi?id=390551, so you can add `BUG: 
390551` to the Summary section.
  
  As far as I've been able to tell, there are two ways to resolve the problem 
of un-discoverable shares when using recent versions of Samba:
  
  1. Fall back to SMB1 for the purpose of share discovery and browsing (which 
is what 390551 is all about)
  2. Implement the WS-DISCOVERY protocol (tracked with 392447)
  
  Both may ultimately necessary, since old SMB1 servers can only be found with 
#1, and new shares that have turned off SMB1 compatibility for security 
purposes (as @acrouthamel talks about) can only be found with #2.
  
  As such, +1 on moving forward with this approach, which is also what the 
Nautilus and Nemo file managers did to work around the issue.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18882: [Image Thumbnailer] Support eps files

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Cool, this tiny change is certainly much simpler than the whole separate 
standalone thumbnailer in `kdegraphics-thumbnailers`.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18882: [Image Thumbnailer] Support eps files

[Kai Uwe Broulik]

broulik added a comment.


  You'll get a thumbnail either way \o/

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure
Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18882: [Image Thumbnailer] Support eps files

[Nathaniel Graham]

ngraham added a comment.


  But what happens when both of the thumbnailers are installed?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

To: broulik, jtamate, dfaure
Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D18883: Add PDF thumbnailer

[Nathaniel Graham]

ngraham added a comment.


  Conceptually I think it makes sense to have all the thumbnailers in their own 
package so it's easy to remove them all if for people who really don't want 
them. That package (`kdegraphics-thumbnailers`) is shipped by default by at 
least Kubuntu, openSUSE, Manjaro and Neon, so it's not like moving them all 
over there would result in a user experience regression for many (any?) people.
  
  I don't have a problem with ultimately putting everything into that separate 
package, but perhaps it makes sense to do that all at once in a deliberate 
manner rather than piecemeal. In which case we would land this, then move all 
the thumbnailers in `kio-extras` into `kdegraphics-thumbnailers`.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18883: Add PDF thumbnailer

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> pdfcreator.cpp:23
> +
> +#include 
> +#include 

the QFile include is no more needed now

> broulik wrote in pdfcreator.cpp:45-46
> I can't. The `renderToImage` can only be told a resolution or part of the 
> page to render, to render downscaled into a certain box.
> 
> The `ThumbnailJob` downscales the image when it exceeds the requested size, 
> so doing any manual downscaling (other than already getting the correct size 
> which we can't) here is superfluous.

Sure you can: see what okular does, for example, as it requests pixmaps of 
precise sizes.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D18883: Add PDF thumbnailer

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> pino wrote in pdfcreator.cpp:45-46
> please honor the requested width and height

I can't. The `renderToImage` can only be told a resolution or part of the page 
to render, to render downscaled into a certain box.

The `ThumbnailJob` downscales the image when it exceeds the requested size, so 
doing any manual downscaling (other than already getting the correct size which 
we can't) here is superfluous.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D18883: Add PDF thumbnailer

[Kai Uwe Broulik]

broulik updated this revision to Diff 51290.
broulik added a comment.


  - Remove mimetypes left from testing
  - Don't encode filename (missed that there's one other than the `QByteArray` 
one)

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18883?vs=51281&id=51290

REVISION DETAIL
  https://phabricator.kde.org/D18883

AFFECTED FILES
  thumbnail/CMakeLists.txt
  thumbnail/pdfcreator.cpp
  thumbnail/pdfcreator.h
  thumbnail/pdfthumbnail.desktop

To: broulik, dfaure, aacid, jtamate
Cc: pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D18610: Introduce KF5AuthCore

[Albert Astals Cid]

aacid added a comment.


  It's only BIC for windows IIRC, the rest of the world is fine, KF5Auth pulls 
KF5AuthCore so all the symbols are still tehre.
  
  i don't really think we care about abi in windows for KAuth which AFAICS 
doesn't even have a windows backend.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: rikmills, sitter, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I think it's ok, although it is arguably whether this improves anything. 
Still, let's move on.

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D18788

REVISION DETAIL
  https://phabricator.kde.org/D18788

To: shubham, cullmann, dhaumann
Cc: dhaumann, sars, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, cullmann

D18610: Introduce KF5AuthCore

[Rik Mills]

rikmills added subscribers: sitter, rikmills.
rikmills added a comment.


  Is this not breaking ABI? even if just moving to another lib?
  
  @sitter FYI I get https://paste.ubuntu.com/p/NHsbqg7DbN/

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: rikmills, sitter, apol, kde-frameworks-devel, michaelh, ngraham, bruns

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

[Ben Cooksley]

On Sun, Feb 10, 2019 at 8:35 AM David Faure  wrote:
>
> On samedi 9 février 2019 20:11:53 CET Ben Cooksley wrote:
> > On Sat, Feb 9, 2019 at 9:46 PM David Faure  wrote:
> > > Do you have more details? Which kioslave, from which test program?
> >
> > Looking more closely it seems that the issue is only happening on the
> > stable branch - did your fix land there by any chance?
>
> Oops, no, it was in master only.
>
> Backported now.

Perfect. Looks like both the stable runs passed, so this is indeed
fixed as far as I can tell following that.

Cheers,
Ben

>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

D18883: Add PDF thumbnailer

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> pdfcreator.cpp:45-46
> +{
> +Q_UNUSED(width);
> +Q_UNUSED(height);
> +

please honor the requested width and height

> pdfcreator.cpp:49
> +QScopedPointer document;
> +document.reset(Document::load(QFile::encodeName(path)));
> +

Document::load() takes a QString, so do not encode the filename (which will be 
encoded twice)

> pdfthumbnail.desktop:6
> +X-KDE-ServiceTypes=ThumbCreator
> +MimeType=application/pdf;application/x-dvi;application/postscript;
> +

definitely neither DVI nor PS...

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

[David Faure]

On samedi 9 février 2019 20:11:53 CET Ben Cooksley wrote:
> On Sat, Feb 9, 2019 at 9:46 PM David Faure  wrote:
> > Do you have more details? Which kioslave, from which test program?
> 
> Looking more closely it seems that the issue is only happening on the
> stable branch - did your fix land there by any chance?

Oops, no, it was in master only.

Backported now.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D18873: add baloo engine debugging category

[Stefan Brüns]

bruns added a comment.


  Looks good to me. @mlaurent ?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

[Ben Cooksley]

On Sat, Feb 9, 2019 at 9:46 PM David Faure  wrote:
>
> Do you have more details? Which kioslave, from which test program?

Looking more closely it seems that the issue is only happening on the
stable branch - did your fix land there by any chance?

Cheers,
Ben

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov updated this revision to Diff 51284.
valeriymalov marked 4 inline comments as done.
valeriymalov added a comment.


  - fix ::del error logging criteria, don't return without closing cursor in

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=51282&id=51284

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> valeriymalov wrote in documentdatadb.cpp:107
> Trying to delete a non-existent entry seems like an error to me

Deleting is an idempotent operation, so e.g. doing it twice is fine. There may 
be multiple events queued leading to the deletion of a database entry, i.e. 
deleting a file and then deleting a parent directory recursively.

> bruns wrote in postingdb.cpp:232
> //critical - You are leaking the cursor now//

not done ... you have to always `mdb_cursor_close`

Also, MDB_NOTFOUND is not an error here.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18883: Add PDF thumbnailer

[Luigi Toscano]

ltoscano added a comment.


  Why can't this go to kdegraphics-thumbnailer? Kio-extras shouldn't be, IMHO, 
a "drop everything which does not fit elsewhere"

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D18369: Create tel: links for phone numbers

[Sune Vuorela]

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18369

To: vkrause, svuorela
Cc: apol, aacid, svuorela, nicolasfella, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18883: Add PDF thumbnailer

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, aacid, jtamate.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This adds a PDF thumbnailer using libpoppler.
  There is one in kdegraphics-thumbnailers but that one (as far as I could 
understand the old (fork+exec etc) and convoluted code) relies on an external 
`gs` binary to generate the thumbnails and is pretty slow.
  This one is just 40 lines of code and would get people PDF thumbnails out of 
the box.

TEST PLAN
  Disabled gsthumbs from kdegraphics-thumbnailer, still got neat little PDF 
thumbnails
  EPS files can be generated using KImageFormats (cf D18882 
) so the only bits missing from 
kdegraphics-thumbnailers (which isn't installed by default on most distros) is 
DVI and ghostscript files (and RAW files).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

AFFECTED FILES
  thumbnail/CMakeLists.txt
  thumbnail/pdfcreator.cpp
  thumbnail/pdfcreator.h
  thumbnail/pdfthumbnail.desktop

To: broulik, dfaure, aacid, jtamate
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov added inline comments.

INLINE COMMENTS

> bruns wrote in documentdatadb.cpp:107
> see get

Trying to delete a non-existent entry seems like an error to me

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov updated this revision to Diff 51282.
valeriymalov marked 10 inline comments as done.
valeriymalov added a comment.


  - update logging per review

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=51252&id=51282

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18873: add baloo engine debugging category

[Valeriy Malov]

valeriymalov updated this revision to Diff 51279.
valeriymalov added a comment.


  is it now how it's supposed to look in the end? not really sure where 
.category syntax is defined

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18873?vs=51261&id=51279

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18882: [Image Thumbnailer] Support eps files

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: jtamate, dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  There's a KImageFormats plugin for EPS files, so we can just load them easily 
as QImage

TEST PLAN
  I now get thumbnails for eps files without having kdegraphcis-thumbnailers 
(ghostscript/pdf thumbnailer) installed

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18882

AFFECTED FILES
  thumbnail/imagethumbnail.desktop

To: broulik, jtamate, dfaure
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D17245: Add string formatting function to property info

[Alexander Stippich]

astippich updated this revision to Diff 51271.
astippich added a comment.


  - rebase onto current master
  - rename header
  - update docs

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17245?vs=48690&id=51271

BRANCH
  display_value

REVISION DETAIL
  https://phabricator.kde.org/D17245

AFFECTED FILES
  CMakeLists.txt
  autotests/propertyinfotest.cpp
  autotests/propertyinfotest.h
  src/CMakeLists.txt
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp
  src/propertyinfo.h

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D18878: Force NT1 protocol when listing smb:// network

[Mikhail Novosyolov]

mikhailnov added a comment.


  In D18878#408686 , @acrouthamel 
wrote:
  
  > How do dependencies work here? Does this force SMB1 to be installed and 
enabled in Dolphin now? I ask because many companies have disabled and removed 
version 1 due to the security issues.
  
  
  How can smb1 be installed? libsmbclient.so.0 can work using different 
versions of SMB protocol depending on it's version (but it's API and ABI are 
stable). It chooses protocol version by itself. SMB2 and SMB3 currently cannot 
be discovered via NetBIOS by samba, because only smb1 supports netbios 
discovery, but samba developers have some plans to send DCERPC over smb2/smb3 
connections (I don;t know what is DCERPC, but that's what samba developer told 
me).
  
  Before samba 4.7, NT1 (smb1) the maximum protocol in libsmbclient, if I'm not 
mistaken; then they made it possible to connect to smb3 servers without 
manually rising client max protocol, this and/or badlock fixes broke network 
discovery via smb://, for now, the only way is to manually force NT1 whaen 
needed, it's what this patch does.
  
  See also https://bugzilla.samba.org/show_bug.cgi?id=13782

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov
Cc: acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D18822: Fix Windows build [hopefully]

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Given the autotests reuse the source files from the lib (and thus also using 
the headers) the export macros confuse windows here.
  
  So in autotests/CMakeLists,txt, one needs to extend
  
target_compile_definitions(kauth_tests_static PUBLIC KAUTH_STATIC_DEFINE=1)
  
  into
  
target_compile_definitions(kauth_tests_static PUBLIC 
KAUTHCORE_STATIC_DEFINE=1 PUBLIC KAUTH_STATIC_DEFINE=1)
  
  Cmp. the generated src/kauthcore_export.h in case you wonder how this 
(assumingly) fixes things :)

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18822

To: aacid, vonreth
Cc: albertvaka, kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17932: Improvements to completion

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:7c42ba4a1aed: Improvements to completion (authored by 
thomassc, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17932?vs=49397&id=51267

REVISION DETAIL
  https://phabricator.kde.org/D17932

AFFECTED FILES
  autotests/src/completion_test.cpp
  src/completion/katecompletionmodel.cpp
  src/completion/katecompletionmodel.h

To: thomassc, #ktexteditor, #kdevelop, mwolff, cullmann
Cc: dhaumann, apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, 
kde-frameworks-devel, michaelh, ngraham, bruns, demsking, head7, sars

D18878: Force NT1 protocol when listing smb:// network

[Andrew Crouthamel]

acrouthamel added a comment.


  How do dependencies work here? Does this force SMB1 to be installed and 
enabled in Dolphin now? I ask because many companies have disabled and removed 
version 1 due to the security issues.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov
Cc: acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D18822: Fix Windows build [hopefully]

[Hannah von Reth]

vonreth requested changes to this revision.
vonreth added a comment.
This revision now requires changes to proceed.


  Doesn't build yet, we really need pre commit ci
  
Scanning dependencies of target KF5AuthCore_autogen
[  1%] Automatic MOC for target KF5AuthCore
[  1%] Built target KF5AuthCore_autogen
Scanning dependencies of target KF5AuthCore
[  3%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/kauthaction.cpp.obj
kauthaction.cpp
[  4%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/kauthactionreply.cpp.obj
kauthactionreply.cpp
[  6%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/kauthexecutejob.cpp.obj
kauthexecutejob.cpp
[  8%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/AuthBackend.cpp.obj
AuthBackend.cpp
[  9%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/BackendsManager.cpp.obj
BackendsManager.cpp
[ 11%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/HelperProxy.cpp.obj
HelperProxy.cpp
[ 13%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/kauthhelpersupport.cpp.obj
kauthhelpersupport.cpp
[ 14%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/kauthdebug.cpp.obj
kauthdebug.cpp
[ 16%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/backends/fake/FakeBackend.cpp.obj
FakeBackend.cpp
[ 18%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/backends/fakehelper/FakeHelperProxy.cpp.obj
FakeHelperProxy.cpp
[ 19%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/ECMQmLoader-kauth5_qt.cpp.obj
ECMQmLoader-kauth5_qt.cpp
[ 21%] Building CXX object 
src/CMakeFiles/KF5AuthCore.dir/KF5AuthCore_autogen/mocs_compilation.cpp.obj
mocs_compilation.cpp
[ 22%] Linking CXX shared library ..\bin\KF5AuthCore.dll
   Creating library ..\lib\KF5AuthCore.lib and object ..\lib\KF5AuthCore.exp
   Creating library ..\lib\KF5AuthCore.lib and object ..\lib\KF5AuthCore.exp
[ 22%] Built target KF5AuthCore
Scanning dependencies of target KF5Auth_autogen
[ 24%] Automatic MOC for target KF5Auth
[ 24%] Built target KF5Auth_autogen
Scanning dependencies of target KF5Auth
[ 26%] Building CXX object src/CMakeFiles/KF5Auth.dir/kauthdebug.cpp.obj
kauthdebug.cpp
[ 27%] Building CXX object 
src/CMakeFiles/KF5Auth.dir/kauthobjectdecorator.cpp.obj
kauthobjectdecorator.cpp
[ 29%] Building CXX object 
src/CMakeFiles/KF5Auth.dir/KF5Auth_autogen/mocs_compilation.cpp.obj
mocs_compilation.cpp
[ 31%] Linking CXX shared library ..\bin\KF5Auth.dll
   Creating library ..\lib\KF5Auth.lib and object ..\lib\KF5Auth.exp
   Creating library ..\lib\KF5Auth.lib and object ..\lib\KF5Auth.exp
[ 31%] Built target KF5Auth
Scanning dependencies of target kauth_helper_plugin_autogen
[ 32%] Automatic MOC for target kauth_helper_plugin
[ 32%] Built target kauth_helper_plugin_autogen
[ 34%] Generating kf5authadaptor.cpp, kf5authadaptor.h
[ 36%] Generating kf5authadaptor.moc
Scanning dependencies of target kauth_helper_plugin
[ 37%] Building CXX object 
src/CMakeFiles/kauth_helper_plugin.dir/backends/dbus/DBusHelperProxy.cpp.obj
DBusHelperProxy.cpp
[ 39%] Building CXX object 
src/CMakeFiles/kauth_helper_plugin.dir/kf5authadaptor.cpp.obj
kf5authadaptor.cpp
[ 40%] Building CXX object 
src/CMakeFiles/kauth_helper_plugin.dir/HelperProxy.cpp.obj
HelperProxy.cpp
[ 42%] Building CXX object 
src/CMakeFiles/kauth_helper_plugin.dir/kauthdebug.cpp.obj
kauthdebug.cpp
[ 44%] Building CXX object 
src/CMakeFiles/kauth_helper_plugin.dir/kauth_helper_plugin_autogen/mocs_compilation.cpp.obj
mocs_compilation.cpp
[ 45%] Linking CXX shared module ..\bin\kauth_helper_plugin.dll
   Creating library ..\lib\kauth_helper_plugin.lib and object 
..\lib\kauth_helper_plugin.exp
   Creating library ..\lib\kauth_helper_plugin.lib and object 
..\lib\kauth_helper_plugin.exp
[ 45%] Built target kauth_helper_plugin
Scanning dependencies of target kauth_tests_static_autogen
[ 47%] Automatic MOC for target kauth_tests_static
[ 47%] Built target kauth_tests_static_autogen
[ 49%] Generating kf5authadaptor.cpp, kf5authadaptor.h
[ 50%] Generating kf5authadaptor.moc
Scanning dependencies of target kauth_tests_static
[ 52%] Building CXX object 
autotests/CMakeFiles/kauth_tests_static.dir/__/src/kauthaction.cpp.obj
kauthaction.cpp
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(60): warning C4273: 
'KAuth::Action::Action': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(112): note: see previous 
definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(65): warning C4273: 
'KAuth::Action::Action': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(115): note: see previous 
definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(70): warning C4273: 
'KAuth::Action::Action': inconsistent dll linka

D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> documentdatadb.cpp:42
> +if (rc) {
> +qCDebug(ENGINE) << "DocumentDataDB::create" << mdb_strerror(rc);
> +return 0;

Warning

> documentdatadb.cpp:54
> +if (rc) {
> +qCDebug(ENGINE) << "DocumentDataDB::open" << mdb_strerror(rc);
>  return 0;

warning

> documentdatadb.cpp:76
> +if (rc) {
> +qCDebug(ENGINE) << "DocumentDataDB::put" << mdb_strerror(rc);
> +}

warning

> documentdatadb.cpp:90
>  int rc = mdb_get(m_txn, m_dbi, &key, &val);
> -if (rc == MDB_NOTFOUND) {
> +if (rc) {
> +qCDebug(ENGINE) << "DocumentDataDB::get" << docId << 
> mdb_strerror(rc);

please keep MDB_NOTFOUND as "ok" here, any other return code != 0 -> qCWarning

> documentdatadb.cpp:107
>  int rc = mdb_del(m_txn, m_dbi, &key, nullptr);
> -if (rc == MDB_NOTFOUND) {
> -return;
> +if (rc) {
> +qCDebug(ENGINE) << "DocumentDataDB::del" << docId << 
> mdb_strerror(rc);

see get

> documentdatadb.cpp:123
> +if (rc) {
> +qCDebug(ENGINE) << "DocumentDataDB::contains" << docId << 
> mdb_strerror(rc);
>  return false;

see get

> documentdb.cpp:44
> +if (rc) {
> +qCDebug(ENGINE) << "DocumentDB::create" << name << mdb_strerror(rc);
> +return 0;

same rules for warning/debug as in documentdatadb

> postingdb.cpp:141
>  }
> -Q_ASSERT_X(rc == 0, "PostingDB::fetchTermsStartingWith", 
> mdb_strerror(rc));
> +qCDebug(ENGINE) << "PostingDB::fetchTermsStartingWith" << 
> mdb_strerror(rc);
>  

if (rc != MDB_NOTFOUND) ...

> postingdb.cpp:232
> +qCDebug(ENGINE) << "PostingDB::regexpIter" << mdb_strerror(rc);
> +return nullptr;
>  }

//critical - You are leaking the cursor now//

> transaction.cpp:283
> +if (!m_writeTrans) {
> +qCDebug(ENGINE) << "m_writeTrans is null";
> +return;

warning

> fileindexscheduler.cpp:186
>  if (isOnBattery && m_indexerState == ContentIndexing) {
> -qDebug() << "On battery stopping content indexer";
> +qCDebug(BALOO) << "On battery stopping content indexer";
>  m_contentIndexer->quit();

add a ", " after battery

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

[Shubham]

shubham added a comment.


  Can someone experienced review this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17632

To: dfaure, shubham, broulik, bruns, chinmoyr
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18873: add baloo engine debugging category

[Laurent Montel]

mlaurent added a comment.


  ecm_qt_declare_logging_category(kio_timeline_SRCS
  
HEADER kio_timeline_debug.h
IDENTIFIER Baloo::KIO_TIMELINE
DEFAULT_SEVERITY Warning
CATEGORY_NAME kf5.kio.kio_timeline
  
  > yep you force DEFAULT_SEVERITY Warning
  
  here ;ecm_qt_declare_logging_category(
  
BALOO_ENGINE_SRCS
HEADER "enginedebug.h"
  
  IDENTIFIER "ENGINE"
  
CATEGORY_NAME "org.kde.baloo.engine")
  
  I don't see where you force DEFAULT_SEVERITY here :)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18873: add baloo engine debugging category

[Stefan Brüns]

bruns added a comment.


  In D18873#408662 , @mlaurent wrote:
  
  > DEFAULT_SEVERITY [WARNING] is false too as you don't force it.
  
  
  i.e. add "DEFAULT_SEVERITY Warning" in ecm_qt_declare_logging_category
  compare with 
https://phabricator.kde.org/source/baloo/browse/master/src/kioslaves/timeline/CMakeLists.txt

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18873: add baloo engine debugging category

[Laurent Montel]

mlaurent added a comment.


  DEFAULT_SEVERITY [WARNING] is false too as you don't force it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18873: add baloo engine debugging category

[Laurent Montel]

mlaurent added a comment.


  Baloo::ENGINE it's wrong as you generate it as "IDENTIFIER "ENGINE" 
CATEGORY_NAME "org.kde.baloo.engine")"
  it's not Baloo::ENGINE but ENGINE
  
  so you need to change IDENTIFIER "ENGINE" in ecm_qt_declare_logging_category(

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18873: add baloo engine debugging category

[Valeriy Malov]

valeriymalov updated this revision to Diff 51261.
valeriymalov added a comment.


  - update categories per review

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18873?vs=51255&id=51261

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18873: add baloo engine debugging category

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> baloo.categories:4
>  kf5.kio.kio_timeline Baloo Timeline (KIO) DEFAULT_SEVERITY [WARNING] 
> IDENTIFIER [Baloo::KIO_TIMELINE]
> +org.kde.baloo.engine Baloo engine debug DEFAULT_SEVERITY [WARNING] 
> IDENTIFIER [ENGINE]

description "Baloo engine debug" -> "Baloo Engine"
identifier "Baloo::ENGINE"

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18878: Force NT1 protocol when listing smb:// network

[Mikhail Novosyolov]

mikhailnov added a comment.


  Samba developers told that currently other methods of browsong network, than 
using old SMB1 protocol, are not implemented.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18878: Force NT1 protocol when listing smb:// network

[Mikhail Novosyolov]

mikhailnov created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
mikhailnov requested review of this revision.

REVISION SUMMARY
  Samba 4.8 changed default 'client max protocol' from NT1 to SMB3, together 
with fixes of Badlock, it broke browsing smb:// with default settings, because 
only NT1 (SMB1) protocol can browse network. Samba 4.10 made it possible to set 
min/max protocol version via libsmbclient API.
  Similar to 
https://gitlab.gnome.org/GNOME/gvfs/commit/6c8bc39f570ea82cf14e83ce7d1dbdbe569d09d1

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb_browse.cpp

To: mikhailnov
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18877: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  There is no need to delete and create a new Private on assignment, it is
  sufficient to reassign its members.
  
  File::load(url) resets the url, afterwards he old corresponding property
  map is no longer valid, clear it.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18877

AFFECTED FILES
  src/lib/file.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/11/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Feb 2019 14:48:34 +
 Build duration:
3 min 28 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5683/9485)43%
(2221/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(849/1674)42%
(437/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
 

D18819: Use content to determine mime type

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:7415aa60d9f6: Use content to determine mime type 
(authored by astippich).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18819?vs=51112&id=51258

REVISION DETAIL
  https://phabricator.kde.org/D18819

AFFECTED FILES
  src/file/extractor/app.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov added a dependency: D18873: add baloo engine debugging category.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18873: add baloo engine debugging category

[Valeriy Malov]

valeriymalov added a dependent revision: D18664: Baloo engine: treat every 
non-success code as a failure.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent
Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/9/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Feb 2019 13:11:56 +
 Build duration:
1 hr 25 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

D18873: add baloo engine debugging category

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Ok so you need to commit this one first and making second patch dependancy 
against it.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent
Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18873: add baloo engine debugging category

[Valeriy Malov]

valeriymalov marked an inline comment as done.
valeriymalov added inline comments.

INLINE COMMENTS

> mlaurent wrote in CMakeLists.txt:31
> which files uses it ?
> you generate it but it seems that you don't use it in file no ?

I've been asked to split this from D18664: Baloo engine: treat every 
non-success code as a failure 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent
Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18873: add baloo engine debugging category

[Valeriy Malov]

valeriymalov updated this revision to Diff 51255.
valeriymalov added a comment.


  - use new syntax for baloo.categories

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18873?vs=51248&id=51255

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo, mlaurent
Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18873: add baloo engine debugging category

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> baloo.categories:4
>  kf5.kio.kio_timeline Baloo Timeline (KIO) DEFAULT_SEVERITY [WARNING] 
> IDENTIFIER [Baloo::KIO_TIMELINE]
> +org.kde.baloo.engine Baloo engine debug

Please use new syntax see previous line.

> CMakeLists.txt:31
> +BALOO_ENGINE_SRCS
> +HEADER "enginedebug.h"
> +IDENTIFIER "ENGINE"

which files uses it ?
you generate it but it seems that you don't use it in file no ?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent
Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 9 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/9/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Feb 2019 13:11:08 +
 Build duration:
1 hr 13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26669/31416)53%
(10638/20133)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)98%
(12166/12375)50%
(6372/12859)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6271/7383)65%
(1805/2795)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)86%
(7778/9005)65%
(2284/3490)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Feb 2019 13:11:20 +
 Build duration:
1 hr 14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7184/9546)55%
(3545/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3049/3136)53%
(1292/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3341/4662)61%
(1948/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

[Shubham]

shubham added a comment.


  Is it okay now?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18788

To: shubham, cullmann
Cc: dhaumann, sars, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, cullmann

D18824: Implement wl_eglstream_controller Server Interface

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> CMakeLists.txt:349
>xdgoutput_interface.h
> +  eglstream_controller_interface.h
>  )

alphabetical sorted

> display.cpp:529
> +} else {
> +qCWarning(KWAYLAND_SERVER) << "Unable to load 
> libnvidia-egl-wayland.so.1";
> +}

There should be always a non-null object returned. Instead check somewhere 
before the create call of EglStreamControllerInterface if the library can be 
loaded. Also this would put the logic and the QLibrary include in the class 
file and not in display.cpp, what I would prefer.

One could overwrite the `Global::create` method in the 
`EglStreamControllerInterface` child class. From there then call 
QLibrary::resolve and only if it succeeds the parent create method. Afterwards 
compositor needs to check `Global::isValid`.

The control flow would then be in the compositor:

  auto *e = display->createEglStreamControllerInterface();
  // other initial setup
  e->create();
  if (!e->isValid()) {
  // error handling
  }

It's unfortunate that the create method is not virtual in Global. We can change 
this in KF6.

> display.h:310
> + * @return the created EGL Stream controller, or nullptr on failure
> + * @since 5.55
> + */

5.56

> eglstream_controller_interface.cpp:53
> +Q_UNUSED(client);
> +Q_UNUSED(attribs);
> +Private *p = static_cast(wl_resource_get_user_data(resource));

Why is attribs unused in this implementation?

> eglstream_controller_interface.cpp:54
> +Q_UNUSED(attribs);
> +Private *p = static_cast(wl_resource_get_user_data(resource));
> +emit 
> p->m_controller->streamConsumerAttached(SurfaceInterface::get(surface), (void 
> *)eglStream);

Use `Global::Private::cast`.

> eglstream_controller_interface.cpp:58
> +
> +EglStreamControllerInterface::Private::Private(EglStreamControllerInterface 
> *controller,
> +   Display *display,

Rename `controller` and `m_controller` below to `q` for enhanced pimpl street 
cred.

> eglstream_controller_interface.h:28
> +#include "surface_interface.h"
> +
> +namespace KWayland

Cleanup includes

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

[Roman Gilg]

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Impressive. Some small issues to resolve.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18731: Replace KIconThemes dependency with equivalent QIcon usage

[Christoph Feck]

cfeck accepted this revision.
cfeck added a comment.


  But KDE also supports

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18731

To: vkrause, davidedmundson, cfeck
Cc: broulik, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Feb 2019 13:09:58 +
 Build duration:
1 hr 3 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:12:18 +
 Build duration:
1 hr 0 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/21/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:11:56 +
 Build duration:
57 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/8/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Feb 2019 13:08:02 +
 Build duration:
59 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3159/3861)48%
(4680/9810)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(864/883)49%
(1873/3805)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:11:20 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:11:08 +
 Build duration:
50 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 15 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Feb 2019 13:06:52 +
 Build duration:
54 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5ConfigWidgets_compat_report.htmllogs/KF5ConfigWidgets/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.kcolorschemetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)41%
(13/32)41%
(13/32)33%
(910/2718)25%
(345/1363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests80%
(4/5)80%
(4/5)94%
(313/333)51%
(105/206)src47%
(9/19)47%
(9/19)28%
(597/2163)21%
(240/1137)tests0%
(0/8)0%
(0/8)0%
(0/222)0%
(0/20)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Feb 2019 13:06:57 +
 Build duration:
52 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov updated this revision to Diff 51252.
valeriymalov added a comment.


  - move new logging category to D18873: add baloo engine debugging category 


REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=51251&id=51252

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov updated this revision to Diff 51251.
valeriymalov marked 3 inline comments as done.
valeriymalov added a comment.


  - clean up rest of the asserts

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=50708&id=51251

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/17/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 09 Feb 2019 13:11:56 +
 Build duration:
37 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/6/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 09 Feb 2019 13:11:20 +
 Build duration:
37 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7194/9546)56%
(3557/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3056/3136)53%
(1296/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(786/1391)45%
(303/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3345/4662)61%
(1955/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:10:38 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:10:20 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:09:58 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/26/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:08:55 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/7/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 09 Feb 2019 13:09:57 +
 Build duration:
26 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 22 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/22/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 09 Feb 2019 13:08:54 +
 Build duration:
26 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32206/60191)38%
(16675/44242)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9139/9576)48%
(4319/9027)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8365/14360)51%
(4712/9313)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3906/7970)34%
(1613/4775)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/13/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:07:25 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:07:39 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/9/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 09 Feb 2019 13:06:57 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6347/8464)43%
(10135/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2697/2772)49%
(5765/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/13/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 09 Feb 2019 13:08:02 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3159/3861)48%
(4680/9810)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(864/883)49%
(1873/3805)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.10/9/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 09 Feb 2019 13:06:52 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5ConfigWidgets_compat_report.htmllogs/KF5ConfigWidgets/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.kcolorschemetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)41%
(13/32)41%
(13/32)33%
(910/2718)25%
(345/1363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests80%
(4/5)80%
(4/5)94%
(313/333)51%
(105/206)src47%
(9/19)47%
(9/19)28%
(597/2163)21%
(240/1137)tests0%
(0/8)0%
(0/8)0%
(0/222)0%
(0/20)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:06:57 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Feb 2019 13:06:52 +
 Build duration:
8 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.kcolorschemetest

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 25 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/25/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 09 Feb 2019 13:06:21 +
 Build duration:
9 min 22 sec and counting
   CONSOLE OUTPUT
  [...truncated 437 lines...]C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(158): warning C4273: 'KAuth::ActionReply::failed': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(476): note: see previous definition of 'failed'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(163): warning C4273: 'KAuth::ActionReply::errorCode': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(498): note: see previous definition of 'errorCode'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(168): warning C4273: 'KAuth::ActionReply::setErrorCode': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(524): note: see previous definition of 'setErrorCode'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(176): warning C4273: 'KAuth::ActionReply::error': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(487): note: see previous definition of 'error'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(181): warning C4273: 'KAuth::ActionReply::setError': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(512): note: see previous definition of 'setError'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(186): warning C4273: 'KAuth::ActionReply::errorDescription': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(536): note: see previous definition of 'errorDescription'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(191): warning C4273: 'KAuth::ActionReply::setErrorDescription': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(546): note: see previous definition of 'setErrorDescription'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(196): warning C4273: 'KAuth::ActionReply::serialized': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(556): note: see previous definition of 'serialized'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(206): warning C4273: 'KAuth::ActionReply::deserialize': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(566): note: see previous definition of 'deserialize'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(218): warning C4273: 'KAuth::ActionReply::operator =': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(569): note: see previous definition of '='C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(229): warning C4273: 'KAuth::ActionReply::operator ==': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(586): note: see previous definition of '=='C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthactionreply.cpp(234): warning C4273: 'KAuth::ActionReply::operator !=': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthactionreply.h(593): note: see previous definition of '!='kauthexecutejob.cppC:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthexecutejob.cpp(53): warning C4273: 'KAuth::ExecuteJob::ExecuteJob': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthexecutejob.h(53): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthexecutejob.cpp(69): warning C4273: 'KAuth::ExecuteJob::~ExecuteJob': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthexecutejob.h(69): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthexecutejob.cpp(74): warning C4273: 'KAuth::ExecuteJob::action': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthexecutejob.h(82): note: see previous definition of 'action'C:\CI\workspace\Frameworks\kauth\kf5-qt5 WindowsMSVCQt5.11\src\kauthexecutejob.cpp(79): warning C4273: 'KAuth::ExecuteJob::data': inconsistent dll linkagec:\ci\workspace\frameworks\kauth\kf5-qt5 windowsmsvcqt5.11\src\kauthexecutejob.h(95): note: see previous 

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 18 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/18/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 09 Feb 2019 13:09:46 +
 Build duration:
2 min 33 sec and counting
   CONSOLE OUTPUT
  [...truncated 217 lines...] * Qt5TextToSpeech, Qt text to speech module   Required to build text to speech notification support * PkgConfig * Qt5Test (required version >= 5.10.0)-- The following REQUIRED packages have been found: * ECM (required version >= 5.55.0), Extra CMake Modules.,  * Qt5Gui (required version >= 5.11.3) * Qt5Widgets * Qt5AndroidExtras * Gradle * Qt5 (required version >= 5.10.0) * Qt5Core * KF5WindowSystem (required version >= 5.55.0) * KF5Config (required version >= 5.55.0) * KF5Codecs (required version >= 5.55.0) * KF5CoreAddons (required version >= 5.55.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * X11 * Canberra, Library for generating event sounds,Needed to build audio notification support * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library   Needed to build audio notification support when Canberra isn't available * dbusmenu-qt5, DBusMenuQt,Support for notification area menus via the DBusMenu protocol-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project knotifications --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target gradleScanning dependencies of target KF5Notifications_autogen[  5%] Generating gradle/gradlew[ 10%] Automatic MOC for target KF5Notifications[ 10%] Built target gradleScanning dependencies of target knotifications_aar[ 15%] Generating gradle_build/KF5Notifications/build/outputs/aar/KF5Notifications-debug.aar[ 15%] Built target KF5Notifications_autogen[ 20%] Automatic RCC for knotifications.qrcScanning dependencies of target KF5Notifications[ 25%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotification.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotificationmanager.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotificationplugin.cpp.o[ 45%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybylogfile.cpp.o[ 45%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotifyconfig.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5Notifications.dir/kpassivepopup.cpp.o[ 55%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybyexecute.cpp.o[ 60%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybypopupgrowl.cpp.oStarting a Gradle Daemon, 1 incompatible and 1 stopped Daemons could not be reused, use --status for details[ 65%] Building CXX object src/CMakeFiles/KF5Notifications.dir/ECMQmLoader-knotifications5_qt.cpp.o[ 70%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybytaskbar.cpp.o[ 75%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybyandroid.cpp.o[ 80%] Building CXX object src/CMakeFiles/KF5Notifications.dir/debug_p.cpp.o[ 85%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybytts.cpp.o[ 90%] Building CXX object src/CMakeFiles/KF5Notifications.dir/KF5Notifications_autogen/mocs_compilation.cpp.o[ 95%] Building CXX object src/CMakeFiles/KF5Notifications.dir/KF5Notifications_autogen/EWIEGA46WW/qrc_knotifications.cpp.o[100%] Linking CXX shared library ../bin/libKF5Notifications.so[100%] Built target KF5NotificationsFAILURE: Build failed with an exception.* Where:Build file '/home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.11/build/src/android/gradle_build/KF5Notifications/build.gradle' line: 3* What went wrong:A problem occurred evaluating root project 'KF5Notifications'.> Could not find method google() for arguments [] on repository container of type org.gradle.api.internal.artifacts.dsl.DefaultRepositoryHandler.* Try:Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.BUILD FAILEDTotal time: 6.486 secssrc/android/CMakeFiles/knotifications_aar.dir/build.make:65: recipe for target 'src/android/gradle_build/KF5Notifications/build/outputs/aar/KF5Notifications-debug.aar' failedmake[2]: *** [src/android/gradle_build/KF5Notifications/build/outputs/aar/KF5Notifications-debug.aar] Error 1CMakeFiles/Makefile2:276: recipe for target 'src/android/CMakeFiles/knotifications_aar.dir/all' failedmake[1]: *** [src/android/CMakeFiles/knotifications_aar.dir/all] Error 2Makefile:140: recipe for target 'all' failedmake: *** [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned 

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/10/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Feb 2019 13:05:30 +
 Build duration:
4 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5683/9485)43%
(2221/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(849/1674)42%
(437/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
 

D18873: add baloo engine debugging category

[Valeriy Malov]

valeriymalov created this revision.
valeriymalov added a reviewer: Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
valeriymalov requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18369: Create tel: links for phone numbers

[Volker Krause]

vkrause added a comment.


  ping?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D18369

To: vkrause
Cc: apol, aacid, svuorela, nicolasfella, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18731: Replace KIconThemes dependency with equivalent QIcon usage

[Volker Krause]

vkrause added a comment.


  Tested Konqueror bookmarks. New bookmarks don't seem to get the favicon set 
until you explicitly trigger the "Update Favicon" action, afterwards they have 
it and it remains across restarts. So this seems to work as expected.
  Regarding the indirect dependencies, yes, this does not actually change much 
on its own. I run into this while debugging icon loading issues in Okular on 
Android, which seems related to KIconThemes interfering, so less places where I 
need to strip it out help.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18731

To: vkrause, davidedmundson
Cc: broulik, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns