D19324: Add code-oss icon

[Ariel AxionL]

axionl added a comment.


  In D19324#419767 , @ndavis wrote:
  
  > In D19324#419766 , @axionl wrote:
  >
  > > I use the Gravit Designer (https://designer.io/) to design this icon, not 
the inkscape, but I think I can redraw it by inkscape.
  >
  >
  > Please do. KDE software is only made with free and open source software. If 
you need help with Inkscape, let us know. We would be glad to help.
  >
  > > For the filename, because I'm using archlinux and the icon name is 
`code-oss.svg` on `/usr/share/pixmaps`.
  >
  > In that case, run `ln -sr code-oss.svg code.svg` in the same directory as 
`code-oss.svg` to made a symlink so that the icon works for Arch Linux and any 
other distro.
  
  
  Ok, I am done as soon as possible.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  In D19324#419766 , @axionl wrote:
  
  > I use the Gravit Designer (https://designer.io/) to design this icon, not 
the inkscape, but I think I can redraw it by inkscape.
  
  
  Please do. KDE software is only made with free and open source software. If 
you need help with Inkscape, let us know. We would be glad to help.
  
  > For the filename, because I'm using archlinux and the icon name is 
`code-oss.svg` on `/usr/share/pixmaps`.
  
  In that case, run `ln -sr code-oss.svg code.svg` in the same directory as 
`code-oss.svg` to made a symlink so that the icon works for Arch Linux and any 
other distro.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl added a comment.


  In D19324#419751 , @ndavis wrote:
  
  > Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and 
Gwenview it looks like vector graphics. Something is seriously screwed up in 
this SVG. Did you use Inkscape? Can you explain what process you used to make 
this icon?
  >  F6636063: Screenshot_20190226_020059.png 

  >  F6636069: Screenshot_20190226_020524.png 

  >
  > In D19324#419700 , @ngraham 
wrote:
  >
  > > > `code-oss-dark.svg`
  > >
  > > Is this the correct name?
  >
  >
  > I don't think so. The Code-OSS flatpak and the VS Code RPM use `code.png`, 
so I think the name needs to be `code.svg` for light and dark Breeze icons. It 
would be a good idea to test if using icon themes actually works though, 
because `code.png` installs to 
`/usr/share/code/resources/app/resources/linux/code.png` and 
`/usr/share/pixmaps/code.png` instead of hicolor.
  
  
  I use the Gravit Designer (https://designer.io/) to design this icon, not the 
inkscape, but I think I can redraw it by inkscape.
  
  For the filename, because I'm using archlinux and the icon name is 
`code-oss.svg` on `/usr/share/pixmaps`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52581.
axionl added a comment.


  - Merge branch 'master' into code-oss

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52571=52581

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons/apps/48/code-oss.svg

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Noah Davis]

ndavis added a comment.


  Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and 
Gwenview it looks like vector graphics. Something is seriously screwed up in 
this SVG. Did you use Inkscape? Can you explain what process you used to make 
this icon?
  F6636063: Screenshot_20190226_020059.png 

  F6636069: Screenshot_20190226_020524.png 

  
  In D19324#419700 , @ngraham wrote:
  
  > > `code-oss-dark.svg`
  >
  > Is this the correct name?
  
  
  I don't think so. The Code-OSS flatpak and the VS Code RPM use `code.png`, so 
I think the name needs to be `code.svg` for light and dark Breeze icons. It 
would be a good idea to test if using icon themes actually works though, 
because `code.png` installs to 
`/usr/share/code/resources/app/resources/linux/code.png` and 
`/usr/share/pixmaps/code.png` instead of hicolor.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl added a comment.


  In D19324#419702 , @rooty wrote:
  
  > There are commands/aliases here for how to take quick screenshots 
https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow
  >
  > I ran montage-breeze and I got F6635927: new.png 

  >  which looks really nice.
  >
  > However, is there some reason that it looks different from a Dolphin 
generated thumbnail? F6635929: image.png 
  >
  > EDIT: And yes the dark version should have the same name as the regular 
version (code-oss.svg).
  
  
  I have the same problem but this icon working well and can be display normaly 
on my firebrowser.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19326: Compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R237 KConfig

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19326

AFFECTED FILES
  CMakeLists.txt
  autotests/kconfigtest.cpp
  src/core/kauthorized.cpp
  src/core/kconfig.cpp
  src/core/kconfiggroup.h
  src/core/kconfigini.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kdesktopfile.cpp
  src/core/ksharedconfig.cpp
  src/gui/kconfigloader.cpp
  src/kconf_update/kconf_update.cpp
  src/kconf_update/kconfigutils.cpp
  src/kconfig_compiler/kconfig_compiler.cpp
  src/kreadconfig/kreadconfig.cpp
  src/kreadconfig/kwriteconfig.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/27/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 26 Feb 2019 04:31:42 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13330)18%
(1817/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(299/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
  

D19324: Add code-oss icon

[Krešimir Čohar]

rooty added a comment.


  There are quick commands/aliases here for how to take quick screenshots 
https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow
  
  I ran it and I got F6635927: new.png 
  which looks really nice.
  
  However, is there some reason that it looks different from a Dolphin 
generated thumbnail? F6635929: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

[Nathaniel Graham]

ngraham added a comment.


  > `code-oss-dark.svg`
  
  Is this the correct name? I assume the app itself isn't named 
"code-oss-dark", right? Also screenshots are appreciated, as is filling in the 
test plan. :)
  
  https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/31/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 26 Feb 2019 04:31:42 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/19/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 26 Feb 2019 04:31:42 +
 Build duration:
7 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%

D19324: Add code-oss icon

[Krešimir Čohar]

rooty added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19324

To: axionl, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
axionl requested review of this revision.

REVISION SUMMARY
  Add the code-oss icons follow the breeze and breeze-dark style

REPOSITORY
  R266 Breeze Icons

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss-dark.svg
  icons/apps/48/code-oss.svg

To: axionl
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @dfaure ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19080

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52566.
trickyricky26 added a comment.


  - Change 16px player-volume-muted to symlink in order to pass duplicate test

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19307?vs=52543=52566

BRANCH
  correct-muted-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19307

AFFECTED FILES
  icons-dark/actions/16/player-volume-muted.svg
  icons-dark/actions/24/audio-volume-low.svg
  icons-dark/actions/24/audio-volume-medium.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons/actions/16/player-volume-muted.svg
  icons/actions/24/audio-volume-low.svg
  icons/actions/24/audio-volume-medium.svg
  icons/actions/24/audio-volume-muted.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19016: Update Android toolchain files to reality

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> Android.cmake:150
>  set_deprecated_variable(CMAKE_ANDROID_ARCH_ABI ANDROID_ABI "armeabi-v7a")
> -set_deprecated_variable(CMAKE_ANDROID_API ANDROID_API_LEVEL "14")
> +set_deprecated_variable(CMAKE_ANDROID_API ANDROID_API_LEVEL "21")
>  

Sorry, I'm a bit late, but would it be possible to put 16 as minimum here? Some 
projects (GCompris at least) do not use KF5 and would like to target lower API 
levels.
I can do the diff/commit to change it if necessary

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19016

To: vkrause, apol
Cc: jjazeix, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

[Thomas Fischer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:3bfe329b7136: KConfig: Assign documentation to correct 
enum value (authored by thomasfischer).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19320?vs=52558=52564

REVISION DETAIL
  https://phabricator.kde.org/D19320

AFFECTED FILES
  src/core/kconfigbase.h

To: thomasfischer, broulik, dfaure, davidedmundson
Cc: kde-frameworks-devel, gennad, michaelh, ngraham, bruns, skadinna

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19320

To: thomasfischer, broulik, dfaure, davidedmundson
Cc: kde-frameworks-devel, gennad, michaelh, ngraham, bruns, skadinna

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

[Thomas Fischer]

thomasfischer added reviewers: broulik, dfaure, davidedmundson.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19320

To: thomasfischer, broulik, dfaure, davidedmundson
Cc: kde-frameworks-devel, gennad, michaelh, ngraham, bruns, skadinna

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

[Thomas Fischer]

thomasfischer created this revision.
thomasfischer added a project: Documentation.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thomasfischer requested review of this revision.

REVISION SUMMARY
  In commit 8579ec54 
 
(D13034 ), the `Notify` value got 
introduced in `enum WriteConfigFlag` in KConfigBase. When adding this new 
value, the value and its documentation (Doxygen format, `/**<`) got placed 
wrongly.
  After commit 8579ec54 
, 
the documentation for `Notify` "documents" the previously existing value 
`Localized`, whereas the documentation for `Localized` documents `Notify`.
  Simply exchanging the order of the documentation comments should fix this 
issue.

TEST PLAN
  See the automatically generated online documentation for enum WriteConfigFlag 


REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19320

AFFECTED FILES
  src/core/kconfigbase.h

To: thomasfischer
Cc: kde-frameworks-devel, gennad, michaelh, ngraham, bruns, skadinna

D19319: make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R291 KPty

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19319

AFFECTED FILES
  CMakeLists.txt
  src/kpty.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19318: compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R274 KIdleTime

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19318

AFFECTED FILES
  CMakeLists.txt
  src/kidletime.cpp
  src/widgetbasedpoller.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19317: compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R287 KImageFormats

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19317

AFFECTED FILES
  CMakeLists.txt
  autotests/readtest.cpp
  autotests/writetest.cpp
  src/imageformats/pic.cpp
  tests/imageconverter.cpp
  tests/imagedump.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 43 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/43/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 23 Feb 2019 18:04:48 +
 Build duration:
2 days 1 hr and counting

D19263: Add more highlighting for nested languages in markdown.

[Dominik Haumann]

dhaumann added a comment.


  Good idea, thanks.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19263

To: vandenoever, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, sars

D19313: Remove URLs being fetched when listing job is `completed`

[Nathaniel Graham]

ngraham added reviewers: Frameworks, Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19313

To: dpalacio, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19313: Remove URLs being fetched when listing job is `completed`

[David Palacio]

dpalacio created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dpalacio requested review of this revision.

REVISION SUMMARY
  Currently `ExpandToUrl` may fail to fully expand to an existing folder if any 
parent folder in the path has several hundred entries and the next folder to 
expand isn't in the first retrieved batch. In this patch I remove the discard 
URL logic from `_k_slotNewItems` and move it to a new slot `_k_slotCompleted` 
so that KDirModel can process as many batches as needed until its job is 
finished.
  
  BUG: 383534

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19313

AFFECTED FILES
  src/widgets/kdirmodel.cpp

To: dpalacio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[Nathaniel Graham]

ngraham added a comment.


  Can you verify the permissions of these files? when I apply this patch, build 
it, and run the tests, I get permissions errors:
  
Running tests...
Test project /home/dev/kde/build/breeze-icons
CMake Error: Cannot open file for write: 
/home/dev/kde/build/breeze-icons/Testing/Temporary/LastTest.log.tmp
CMake Error: : System Error: Permission denied
Problem opening file: 
/home/dev/kde/build/breeze-icons/Testing/Temporary/LastTest.log
Cannot create log file: LastTest.log
Start 1: appstreamtest
1/5 Test #1: appstreamtest    Passed0.49 sec
Start 2: symlink
2/5 Test #2: symlink ..   Passed0.13 sec
Start 3: newline
3/5 Test #3: newline ..   Passed0.06 sec
Start 4: dupe
4/5 Test #4: dupe .***Failed1.32 sec
Start 5: scalable
5/5 Test #5: scalable .   Passed0.05 sec

80% tests passed, 1 tests failed out of 5

Total Test time (real) =   2.05 sec

The following tests FAILED:
CMake Error: Cannot open file for write: 
/home/dev/kde/build/breeze-icons/Testing/Temporary/LastTestsFailed.log.tmp
CMake Error: : System Error: Permission denied
Problem opening file: 
/home/dev/kde/build/breeze-icons/Testing/Temporary/LastTestsFailed.log
Cannot create log file: LastTestsFailed.log
  4 - dupe (Failed)
Errors while running CTest
Makefile:118: recipe for target 'test' failed
make: *** [test] Error 8
dev@dev-pc:~/kde/src/breeze
  
  Everything works fine if I build-and-test with git master, so I'm lead to 
believe that something with this patch is wonky.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19263: Add more highlighting for nested languages in markdown.

[Christoph Cullmann]

cullmann added a comment.


  Jos fixed it in commit
  
  1653403267ed9ad0a27ee4042be8e0d714a5dcc4 

  
  I made that check now required.
  
  All current files pass, people can comment out contexts during development.
  
  713c3f918fd0102d91ee893cbe91c95bfe39c4d3 


REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19263

To: vandenoever, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, sars

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Christoph Cullmann]

cullmann added a comment.


  Hmpf :/
  I improved my commit message and amended, but arc at it :/
  I will BUG: and CCBUG: the bugs manually :/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:ce4194b5bc2e: try to improve painting height for text 
lines - bug 403868 avoid to cut _ and… (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19283?vs=52466=52544#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19283?vs=52466=52544

REVISION DETAIL
  https://phabricator.kde.org/D19283

AFFECTED FILES
  src/render/katerenderer.cpp
  src/view/kateviewinternal.cpp

To: cullmann, dhaumann
Cc: loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52543.
trickyricky26 added a comment.


  - Lower opacity of inactive sound waves to 0.25

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19307?vs=52542=52543

BRANCH
  correct-muted-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19307

AFFECTED FILES
  icons-dark/actions/16/player-volume-muted.svg
  icons-dark/actions/24/audio-volume-low.svg
  icons-dark/actions/24/audio-volume-medium.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons/actions/16/player-volume-muted.svg
  icons/actions/24/audio-volume-low.svg
  icons/actions/24/audio-volume-medium.svg
  icons/actions/24/audio-volume-muted.svg

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  correct-muted-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19307

AFFECTED FILES
  icons-dark/actions/16/player-volume-muted.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons/actions/16/player-volume-muted.svg
  icons/actions/24/audio-volume-muted.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19255: Only commit XdgOutput::done if changed

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:5afbaa5e43f9: Only commit XdgOutput::done if changed 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19255?vs=52385=52538#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19255?vs=52385=52538

REVISION DETAIL
  https://phabricator.kde.org/D19255

AFFECTED FILES
  src/server/xdgoutput_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

[Nathaniel Graham]

ngraham added a reviewer: Plasma.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D16913

To: thsurrel, #frameworks, #plasma
Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 21 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/21/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 25 Feb 2019 14:16:21 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26854/31462)53%
(10760/20169)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12291/12393)50%
(6457/12883)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6295/7398)65%
(1816/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7814/9018)66%
(2310/3498)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 15 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/15/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 25 Feb 2019 14:16:21 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 4 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModelFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSeatFailed: projectroot.autotests.client.kwayland_testXdgShellStable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(237/260)91%
(237/260)80%
(25110/31363)49%
(9877/20169)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(41/43)95%
(41/43)92%
(11417/12389)46%
(5973/12883)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client97%
(72/74)97%
(72/74)79%
(5794/7353)54%
(1505/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)83%
(7445/8968)64%
(/3498)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/26/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 25 Feb 2019 14:16:20 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:b6cb0fa963db: [appimage thumbnailer] Rely on imported 
cmake target libappimage (authored by kossebau).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18611?vs=52353=52531

REVISION DETAIL
  https://phabricator.kde.org/D18611

AFFECTED FILES
  thumbnail/CMakeLists.txt

To: kossebau, broulik, sitter
Cc: sitter, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D19299: Make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R244 KCoreAddons

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19299

AFFECTED FILES
  CMakeLists.txt
  autotests/desktoptojsontest.cpp
  autotests/kautosavefiletest.cpp
  autotests/kdelibs4configmigratortest.cpp
  autotests/ktexttohtmltest.cpp
  src/lib/io/kautosavefile.cpp
  src/lib/io/kbackup.cpp
  src/lib/io/kdirwatch.cpp
  src/lib/io/kdirwatch_p.h
  src/lib/jobs/kcompositejob.cpp
  src/lib/kaboutdata.cpp
  src/lib/plugin/desktopfileparser.cpp
  src/lib/plugin/kpluginfactory.cpp
  src/lib/plugin/kpluginloader.cpp
  src/lib/plugin/kpluginmetadata.cpp
  src/lib/util/kdelibs4configmigrator.cpp
  src/lib/util/kdelibs4migration.cpp
  tests/faceicontest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19298: Make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R283 KAuth

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19298

AFFECTED FILES
  CMakeLists.txt
  src/BackendsManager.cpp
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/kauth-policy-gen-polkit1.cpp
  src/policy-gen/policy-gen.cpp
  src/policy-gen/policy-gen.h

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19255: Only commit XdgOutput::done if changed

[David Edmundson]

davidedmundson added a comment.


  I wouldn't say it's handling it incorrectly. In the scenario you've give the 
logical size hasn't changed.
  
  > a single wl_output::done event might be generated but not the respective 
xdg_output::done event.
  
  I was under the impression that xwayland expects an xdg_output::done to have 
a corresponding wl_output::done, but not necessarily the other way round?
  
  If we do need them to always be paired we'll have the same issue if you 
change refresh rate without changing the resolution.
  
  The only long term option I can think of that would fix that is exposing the 
dirty bit publicly and having kwin do:
  
if (output->isDirty() || xdgOutput->isDirty()) {
  output->done();
  xdgOutput->done();
}
  
  (after porting Output to this same pattern)

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19255

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D19255: Only commit XdgOutput::done if changed

[David Edmundson]

davidedmundson edited the summary of this revision.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19255

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D19255: Only commit XdgOutput::done if changed

[David Edmundson]

davidedmundson retitled this revision from "WIP: Alternate approach to D19253" 
to "Only commit XdgOutput::done if changed".
davidedmundson edited the summary of this revision.
davidedmundson edited the test plan for this revision.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19255

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/37/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 25 Feb 2019 10:08:22 +
 Build duration:
59 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Please add the comment as suggested by Thomas.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

[Harald Sitter]

sitter accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  relyonappimageimportedtarget

REVISION DETAIL
  https://phabricator.kde.org/D18611

To: kossebau, broulik, sitter
Cc: sitter, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D19168: Fix crash in Dolphin when dropping trashed file in trash

[David Hallas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f56af9e2ea0a: Fix crash in Dolphin when dropping trashed 
file in trash (authored by hallas).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19168?vs=52508=52509

REVISION DETAIL
  https://phabricator.kde.org/D19168

AFFECTED FILES
  autotests/dropjobtest.cpp
  src/widgets/dropjob.cpp

To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

[David Hallas]

hallas updated this revision to Diff 52508.
hallas added a comment.


  Rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19168?vs=52132=52508

BRANCH
  fix_crash_when_dropping_trashed_file_in_trash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19168

AFFECTED FILES
  autotests/dropjobtest.cpp
  src/widgets/dropjob.cpp

To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

[Thomas Surrel]

thsurrel updated this revision to Diff 52507.
thsurrel added a comment.


  Rebase

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16913?vs=50295=52507

BRANCH
  arc_focussearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16913

AFFECTED FILES
  src/kpluginselector.cpp
  src/kpluginselector.h

To: thsurrel, #frameworks
Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, 
bruns