D19438: Add syntax definition for Elm language to syntax-highlighting

[Nibaldo González]

nibags added a comment.


  Use: `cmake ./ && make` to compile

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19438

To: bonghyunkim
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim updated this revision to Diff 53180.
bonghyunkim edited the summary of this revision.
bonghyunkim added a comment.


  I created 'highlight.elm' in autotests/input/ folder, as per guide on 
https://github.com/KDE/syntax-highlighting, but couldn't follow the instruction.
  I tried running make && make test, but the root folder didn't have Makefile, 
and when I ran it inside autotests/input/, it failed to run because of the 
missing Makefile.in.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19438?vs=52880=53180

REVISION DETAIL
  https://phabricator.kde.org/D19438

AFFECTED FILES
  autotests/input/highlight.elm
  data/syntax/elm.xml

To: bonghyunkim
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D19461: Logcat: fix dsError color with underline="0"

[Christoph Cullmann]

cullmann added a comment.


  If it is only borked in Kate, that might be 
https://bugs.kde.org/show_bug.cgi?id=143399

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19461

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19461: Logcat: fix dsError color with underline="0"

[Nibaldo González]

nibags added a comment.


  I still have problems with dsError + underline="0" :(
  In "autotest/html" these aren't underlined, but when I open the file 
"test.logcat" with Kate, it's underlined. 
  I even tried creating a new Unix user, but the problem persists (I'm using 
KDE Frameworks 5.55.0). 
  Even removing the underlines in "Configure Kate -> Fonts & Colors", the 
problem persists. 
  Also clarify that the file "$HOME/.config/katesyntaxhighlightingrc" doesn't 
exist.
  
  I will check well this before sending it

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19461

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19534: [i18n] compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R249 KI18n

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19534

AFFECTED FILES
  CMakeLists.txt
  autotests/klocalizedstringtest.cpp
  src/kcatalog.cpp
  src/klocalizedstring.cpp
  src/kuitmarkup.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19532: Don't crash when no contexts are present

[Christoph Cullmann]

cullmann added a comment.


  Hi, first: good thing to get this fixed, yes, it shall not crash.
  
  For the fix: Wouldn't it be enough to just change the
  
  if (!d->m_definition.isValid()) {
  
applyFormat(0, text.size(), Format());
  
  ​  ...
  
  shortcut to check for
  
  if (!d->m_definition.isValid() || defData->isLoaded()) {

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19530: Avoid fractionals in GridDelegate sizes and alignments

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  A lot easier on the eyes now, really nice fix

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19530

To: davidedmundson, #plasma, ngraham, rooty
Cc: rooty, ngraham, filipf, kde-frameworks-devel, michaelh, bruns

T10554: KDiff3 to join Applications

[Christoph Feck]

cfeck added a comment.


  Moving KDiff3 to KDE Applications was suggested at 
https://marc.info/?l=kde-core-devel=155055818529475=2
  
  In https://phabricator.kde.org/T10546 I instructed Michael to ask developers 
for a quick review of the (many) changes made for the KF5 port.
  
  Apparently Michael prefers Phabricator task to mailing list postings ...

TASK DETAIL
  https://phabricator.kde.org/T10554

To: cfeck
Cc: cfeck, aacid, kde-frameworks-devel, mreeves

D19527: Remove find modules provided by ECM

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I doubt a bit here because they work slightly different, but being part of 
kdelibs4support it's probably a matter of just using the right ones.

REPOSITORY
  R239 KDELibs4Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19527

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19530: Avoid fractionals in GridDelegate sizes and alignments

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice fix.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19530

To: davidedmundson, #plasma, ngraham
Cc: ngraham, filipf, kde-frameworks-devel, michaelh, bruns

T10554: KDiff3 to join Applications

[Albert Astals Cid]

aacid added a comment.


  Did anyone tell you to create a task in phabricator and subscribe frameworks 
developers to it? I mean this is not about frameworks developement so it seems 
to me you're asking the wrong people.
  
  On the topic of KDiff3 joining KDE Applications where was discussed? I can't 
see any discussion neither on kde-core-devel nor on release-team, did I miss it?

TASK DETAIL
  https://phabricator.kde.org/T10554

To: aacid
Cc: aacid, kde-frameworks-devel, mreeves

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh added reviewers: cullmann, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19533

To: davispuh, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh added a dependent revision: D19533: Don't crash on malformed syntax 
highlighting files.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh added a dependency: D19532: Don't crash when no contexts are present.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19533

To: davispuh, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davispuh requested review of this revision.

TEST PLAN
  1. Create malformed syntax highlighting file with missing end tags
  2. Place it in ~/.local/share/katepart5/syntax/
  3. Open Kate with file which uses that syntax highlighting

REPOSITORY
  R39 KTextEditor

BRANCH
  malformed

REVISION DETAIL
  https://phabricator.kde.org/D19533

AFFECTED FILES
  src/syntax/katehighlight.cpp

To: davispuh
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19508: [kconf_update] move from custom logging tech to qCDebug

[Albert Astals Cid]

aacid added a comment.


  Don't see anything obviously wrong, but i personally don't feel like i have 
enough knowledge on the file to say "yep go ahead and commit", but maybe noone 
feels like that so i'd say if after one or two weeks noone does, do a quick 
ping and the commit :D

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19508

To: sitter, apol, aacid, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18883: Add PDF thumbnailer

[Albert Astals Cid]

aacid added a comment.


  Also do we have a way to limit thumbnailers to run say for X seconds? There's 
some files in which poppler will run "forever"

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: bruns, dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, 
alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh updated this revision to Diff 53175.
davispuh added a comment.


  Actually fix it

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19532?vs=53170=53175

BRANCH
  context

REVISION DETAIL
  https://phabricator.kde.org/D19532

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/definition.cpp

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh added a comment.


  Creating a syntax highlighting file with few unclosed tags made Kate to 
crash. No matter how malformed XML it loads, editor should never crash as it 
can cause loss of unsaved work.
  
  Crash is caused by
  
Context* DefinitionData::initialContext() const
{
Q_ASSERT(!contexts.isEmpty());
return contexts.first();
}
  
  which is called from
  
State AbstractHighlighter::highlightLine(const QString& text, const State 
)
{
Q_D(AbstractHighlighter);

// verify definition, deal with no highlighting being enabled
d->ensureDefinitionLoaded();
if (!d->m_definition.isValid()) {
applyFormat(0, text.size(), Format());
return State();
}

// verify/initialize state
auto defData = DefinitionData::get(d->m_definition);
auto newState = state;
auto stateData = StateData::get(newState);
const DefinitionRef currentDefRef(d->m_definition);
if (!stateData->isEmpty() && (stateData->m_defRef != currentDefRef)) {
qCDebug(Log) << "Got invalid state, resetting.";
stateData->clear();
}
if (stateData->isEmpty()) {
stateData->push(defData->initialContext(), QStringList());
stateData->m_defRef = currentDefRef;
}
  
  here's the backtrace itself
  
#0  0x7fe9863b4d7f in raise () from /usr/lib/libc.so.6
#1  0x7fe98639f672 in abort () from /usr/lib/libc.so.6
#2  0x7fe9867567fc in QMessageLogger::fatal(char const*, ...) const () 
from /usr/lib/libQt5Core.so.5
#3  0x7fe986755c28 in qt_assert(char const*, char const*, int) () from 
/usr/lib/libQt5Core.so.5
#4  0x7fe985e966f3 in 
KSyntaxHighlighting::DefinitionData::initialContext (this=) from 
/usr/lib/libKF5SyntaxHighlighting.so.5
#5  0x7fe985e981c2 in 
KSyntaxHighlighting::AbstractHighlighter::highlightLine 
(this=this@entry=0x55c256cba090, text=..., state=...)
at /usr/include/qt/QtCore/qlist.h:151
#6  0x7fe988464b6f in KateHighlighting::doHighlight 
(this=0x55c256cba090, prevLine=, textLine=0x55c25690cb70, 
nextLine=nextLine@entry=0x55c2569b7420, ctxChanged=@0x7ffe2d101ae3: 
false, tabWidth=8)
at /usr/src/debug/ktexteditor/src/buffer/katetextline.h:311
#7  0x7fe9883facbd in KateBuffer::doHighlight (invalidate=, endLine=, startLine=, 
this=0x55c257a097d0) at 
/usr/src/debug/ktexteditor/src/document/katebuffer.h:203
#8  KateBuffer::doHighlight (this=0x55c257a097d0, startLine=, endLine=, invalidate=)
at /usr/src/debug/ktexteditor/src/document/katebuffer.cpp:360
#9  0x7fe9883d8cf4 in KTextEditor::DocumentPrivate::kateTextLine 
(this=0x55c255de2c10, i=0)
at /usr/src/debug/ktexteditor/src/document/katedocument.cpp:5249
#10 0x7fe98844a0a5 in KateLineLayout::textLine (this=0x55c256b75980, 
reloadForce=reloadForce@entry=false)
at /usr/src/debug/ktexteditor/src/render/katelinelayout.cpp:79
#11 0x7fe988440350 in KateRenderer::layoutLine (this=0x55c256cef2a0, 
lineLayout=..., maxwidth=-1, cacheLayout=)
at /usr/src/debug/ktexteditor/src/render/katerenderer.cpp:1021
#12 0x7fe988444591 in KateLayoutCache::line (this=0x55c256cee360, 
realLine=0, virtualLine=)
at /usr/include/c++/8.2.1/bits/atomic_base.h:295
#13 0x7fe988446a6a in KateLayoutCache::updateViewCache 
(this=this@entry=0x55c256cee360, startPos=..., 
newViewLineCount=newViewLineCount@entry=40, 
viewLinesScrolled=viewLinesScrolled@entry=0)
at /usr/src/debug/ktexteditor/src/render/katelayoutcache.cpp:242
#14 0x7fe98848916b in KateViewInternal::updateView 
(this=0x55c255f63a50, changed=true, viewLinesScrolled=viewLinesScrolled@entry=0)
at /usr/src/debug/ktexteditor/src/include/ktexteditor/cursor.h:98
#15 0x7fe98846f3a7 in KTextEditor::ViewPrivate::updateView 
(this=0x55c255f30f40, changed=)
at /usr/src/debug/ktexteditor/src/view/kateview.cpp:2047
#16 0x7fe9883dc786 in KTextEditor::DocumentPrivate::makeAttribs 
(this=this@entry=0x55c255de2c10, needInvalidate=needInvalidate@entry=false)
at /usr/src/debug/ktexteditor/src/document/katedocument.cpp:2910
#17 0x7fe9883dc7fc in KTextEditor::DocumentPrivate::bufferHlChanged 
(this=0x55c255de2c10)
at /usr/src/debug/ktexteditor/src/document/katedocument.cpp:1876
#18 0x7fe9883faaad in KateBuffer::setHighlight (this=0x55c257a097d0, 
hlMode=)
at /usr/src/debug/ktexteditor/src/document/katebuffer.cpp:346
#19 0x7fe9883ec4ff in KTextEditor::DocumentPrivate::updateFileType 
(this=this@entry=0x55c255de2c10, newType=..., user=user@entry=false)
at /usr/src/debug/ktexteditor/src/document/katedocument.cpp:5061
#20 0x7fe9883ef5b4 in KTextEditor::DocumentPrivate::openFile 
(this=0x55c255de2c10) at /usr/src/debug/ktexteditor/src/utils/kateglobal.h:252
#21 

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Christoph Feck]

cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  addsyntaxhighlighttotextpreview

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik, cfeck
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D19530: Avoid fractionals in GridDelegate sizes and alignments

[Filip Fila]

filipf added a comment.


  David this really does fix it! Previews are nice and sharp everywhere now.
  
  See before:
  F6657490: Screenshot_20190304_173527.png 

  
  And after:
  F6657492: Screenshot_20190304_231358.png 

  
  Notice how e.g. the 4 squares are sharp now?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19530

To: davidedmundson, #plasma
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh added reviewers: cullmann, dhaumann, vandenoever.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davispuh requested review of this revision.

TEST PLAN
  1. Compiled
  2. Placed malformed XML in ~/.local/share/katepart5/syntax/
  3. Opened a file which uses that previously created highlighter

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  context

REVISION DETAIL
  https://phabricator.kde.org/D19532

AFFECTED FILES
  src/lib/definition.cpp

To: davispuh
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau added a reviewer: cfeck.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik, cfeck
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau added a comment.


  So, from my side I am fine with the current patch. While the change to 
QTextDocument (& syntax highlighting?) results in a marginal bigger linespacing 
and as result up to one line less text rendered in the preview, I find the 
newer linespacing actually better to read and by my samples found the missing 
line not to be important to get which file this is and what content. So I have 
stopped further experiments to restore the old linespacing.
  
  Given only positive comments so far & the unclear maintainership of 
kio-extra, I would then proceed to a ship-in-7-days-unless-someone-objects. Of 
course welcoming any +1 or Accept before :;)
  
  Before:
  F6645792: Screenshot_20190301_000252.png 

  Current After:
  F6657475: Screenshot_20190304_225906.png 


REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D19530: Avoid fractionals in GridDelegate sizes and alignments

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The thumbnail object within the Delegate is offset by float amounts

TEST PLAN
  TBH it all looks the same to me. 
  Gammray no longer has float values for the inner Thumbnail offset

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19530

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19491: generic config interface

[Dominik Haumann]

dhaumann added a comment.


  Currently, one cannot 'unset' a value, but I guess that is ok, since we did 
not have that before
  
  In general this approach is OK. Some thoughts on this:
  
  - is it as fast as before, if you start Kate with e.g. 100 documents open?
  - will this allow easy access through the KTextEditor::Config interface? This 
is a Document and View extension interface.
  - can we allow modification of the config values through a generic 
KTextEditor::Command? I.e. set  ? Maybe also reset ?
  - Can we make this accessible through the upcoming variable interface, e.g. 
as ${CurrentDocument:Config:}?
  
  As you can see, I am trying to push this concept a bit further...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19491

To: cullmann, #ktexteditor, dhaumann, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19287: [ExtractorCollection] Load extractor plugins lazily

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19287

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19527: Remove find modules provided by ECM

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This matters specifically here as kdelibs4support installs them and
  adds them to the module search path, which can interfere with the
  newer ones provided by ECM (see e.g. D18943 
).

REPOSITORY
  R239 KDELibs4Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19527

AFFECTED FILES
  cmake/modules/CMakeLists.txt
  cmake/modules/FindFontconfig.cmake
  cmake/modules/FindGLIB2.cmake
  cmake/modules/FindUDev.cmake

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

[Stefan Brüns]

bruns added a comment.


  I think some repetitive code can be avoided when the `T*` inside the 
FooPrivate classes are replaced by e.g. `QScopedPointer` or 
`std::unique_ptr`.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D19514

To: jpalecek, sitter
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

[Stefan Brüns]

bruns added a comment.


  In D19514#424501 , @sitter wrote:
  
  > I haven't had a proper look, so only style complaints for now... but...
  >
  > Isn't the problem rather that the daemon shouldn't be randomly restarted on 
a live system? I.e. this ultimately is an integration issue on the distro-level.
  >  I doubt many if any avahi clients handle this properly and disadvantageous 
side effects are rather expected. Same as pulseaudio for example.
  
  
  As Avahi is mostly stateless, I see no reason why it shouldn't be restarted 
after e.g. an update.
  
  > So I am not sure if this is worth handling at all, but if we handle it we 
should do it properly and republish/rediscover services. The client shouldn't 
get broken frontend objects just because the backend of the backend restarted.
  
  +1 - especially, as the client side is almost guaranteed to be implemented.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D19514

To: jpalecek, sitter
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D19486: Add UDev find module

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:8999b7bd6f6d: Add UDev find module (authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19486?vs=53055=53160#toc

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19486?vs=53055=53160

REVISION DETAIL
  https://phabricator.kde.org/D19486

AFFECTED FILES
  attic/modules/FindUDev.cmake
  docs/find-module/FindUDev.rst
  find-modules/FindUDev.cmake

To: vkrause, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18894: [RFC] General config interface

[loh tar]

loh.tar abandoned this revision.
loh.tar added a comment.


  In favor of D19491 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18894

To: loh.tar, cullmann, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 44 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/44/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Mar 2019 19:26:44 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.56.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33103/48507)51%
(15918/31192)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4480/4773)49%
(1709/3472)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1712/1903)76%
(1213/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)60%
(1897/3182)48%
(1589/3341)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1245)66%
(626/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%

D19511: ViewPrivate: Disable read-only mode action when doc is modified

[loh tar]

loh.tar added a subscriber: ngraham.
loh.tar added a comment.


  There is some reason why I came to this idea. ATM is that thought not so 
sharp present :-/
  But it was related to the auto-reload patch and the lock icon in the bar.
  
  @ngraham what do you think in general? Make a read only setting to an already 
modified file sense from the logic point, not because some strange use case? 
  Why not save the file with the changes you had done? Or reload to discard?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19511

To: loh.tar, #ktexteditor, cullmann
Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 43 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/43/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Mar 2019 19:08:08 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.56.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testCstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33102/48506)51%
(15917/31192)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4480/4773)49%
(1709/3472)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1712/1903)76%
(1213/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)60%
(1896/3181)48%
(1587/3341)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1245)66%
(626/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
 

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/30/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 04 Mar 2019 19:16:38 +
 Build duration:
7 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.56.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33126/48506)51%
(15943/31192)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4472/4771)49%
(1709/3472)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1712/1903)76%
(1212/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)60%
(1895/3182)47%
(1585/3341)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1245)66%
(626/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)67%
(721/1069)57%
(266/465)src.search100%
(7/7)100%
  

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 48 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/48/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 04 Mar 2019 19:16:38 +
 Build duration:
6 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

[Christoph Cullmann]

cullmann added a comment.


  In D19367#424714 , @loh.tar wrote:
  
  > > The batch processing approach is sane.
  >
  > hm, thanks
  >
  > > My real issue here is: What to do with multi-line expressions that might 
span more than one line? Won't we miss matches if the ranges just overlap at 
that locations?
  >
  > Well, yes...that should be the case. I had also some idea but ...
  >
  > > not compute the batch ranges beforehand
  >
  > ...that sound not so nice. What if I would keep it but find some solution?
  
  
  I am not sure that the precomputation saves you a lot of things, you can your 
compute the next batch in the slot that searches.
  But if the issue with the multi-line stuff is solved, I won't t reject this 
for the precomputation, this still can be "optimized" later on if wanted.
  
  > OTH is that multiline search for me a slightly rare case
  
  Yes, that is true.
  It should just work reasonable well, if would be bad if e.g. even a trivial 
case like lala\nlala would break because of badly choosen boundaries.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19367

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

[Christoph Cullmann]

cullmann added a comment.


  Diffs like:
  
  - /usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 
FreeBSDQt5.12/autotests/input/indent/cstyle/openpar12/expected   2019-03-04 
16:49:58.559736000 +
  
  +++ /usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 
FreeBSDQt5.12/autotests/input/indent/cstyle/openpar12/actual   2019-03-04 
16:51:44.182941000 +
  @@ -1,7 +1,6 @@
   class X
   {
  
void foo()
  
  - {
  -
  - }
  
  +  {}
  +  
   };

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

[Christoph Cullmann]

cullmann requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

[loh tar]

loh.tar added a comment.


  > The batch processing approach is sane.
  
  hm, thanks
  
  > My real issue here is: What to do with multi-line expressions that might 
span more than one line? Won't we miss matches if the ranges just overlap at 
that locations?
  
  Well, yes...that should be the case. I had also some idea but ...
  
  > not compute the batch ranges beforehand
  
  ...that sound not so nice. What if I would keep it but find some solution?
  
  OTH is that multiline search for me a slightly rare case

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19367

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Unfortunately that kills some indenter tests.
  
  
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/47/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 29 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/29/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 04 Mar 2019 19:08:08 +
 Build duration:
5 min 36 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.56.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: projectroot.autotests.kateindenttest_testCstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33125/48505)51%
(15942/31192)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4472/4771)49%
(1709/3472)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1712/1903)76%
(1212/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)60%
(1894/3181)47%
(1585/3341)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1245)66%
(626/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)67%
(721/1069)57%
(266/465)src.search100%

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/47/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 04 Mar 2019 19:08:08 +
 Build duration:
5 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testCstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D17241: WIP:Disable highlighting after 512 characters on a line.

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I think we shall count the number of ranges on the line to judge the limit, 
otherwise this is a sound idea.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: sars, cullmann, vkrause, dhaumann, mwolff
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:65e3b5462f1c: DocumentPrivate: Dont scroll view when 
add auto-bracket at end of file (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17857?vs=48366=53155

REVISION DETAIL
  https://phabricator.kde.org/D17857

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I can not reproduce this, but I think one setCursorPosition less is always 
good :P

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

[Christoph Cullmann]

cullmann added a comment.


  My proposal would be:
  
  1. not compute the batch ranges beforehand but just remember the complete 
range and compute the range for the next scan.
  2. after scan is done without a hit, not start behind the range but start in 
the middle of the current range with again such a batch.
  
  That way we should avoid to skip even multi-line matches if you don't do 
perversions that match "" lines, which I think is ok for incremental search.
  The drawback is that one searches more text.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19367

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

[Christoph Cullmann]

cullmann added reviewers: dhaumann, cullmann.
cullmann added a comment.


  Perhaps Dominik has some ideas, too :P

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19367

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

[Christoph Cullmann]

cullmann added a comment.


  The batch processing approach is sane.
  My real issue here is: What to do with multi-line expressions that might span 
more than one line? Won't we miss matches if the ranges just overlap at that 
locations?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19367

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D7909: Add syntax support for Crystal Programming Language

[Christoph Cullmann]

cullmann added a comment.


  ;=) Any updates?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D7909

To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, 
cullmann
Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks, 
faguilar, bmortimer, domson, michaelh, genethomas, bruns, demsking, vkrause, 
sars, dhaumann

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

[Friedrich W. H. Kossebau]

kossebau added a comment.


  FWIW, this still results in inproper pc files, from what I heard recently. 
The `prefix` variable can be overriden from outside when calling `pkg-config` 
(cmp. `pkg-config --help`) to allow for relocatable installations. Same like 
CMake Config files also allow relocation by having the install prefix not 
hardcoded into directory var values.
  
  So ideally any other paths expressions in the pc file use at least the prefix 
variable.
  
  No more info here myself.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: kossebau, cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, 
michaelh, ngraham, bruns

D19416: Restore the search wrapped message to its former type and position.

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:ac35dba35988: Restore the search wrapped message to its 
former type and position. (authored by rjvbb, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19416?vs=52814=53149

REVISION DETAIL
  https://phabricator.kde.org/D19416

AFFECTED FILES
  src/search/katesearchbar.cpp

To: rjvbb, #ktexteditor, dhaumann
Cc: dhaumann, neundorf, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, 
domson, michaelh, bruns, demsking, head7, cullmann, kfunk, sars

D19491: generic config interface

[Christoph Cullmann]

cullmann added a comment.


  Any input?
  We could give this a go "after" the next frameworks release is out.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19491

To: cullmann, #ktexteditor, dhaumann, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15002: Allow to install syntax files instead of having them in a resource

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  If somebody has an fix for the CMake thingy, please open a new diffusion for 
that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15002

To: cullmann, vkrause, dhaumann
Cc: kfunk, dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D19511: ViewPrivate: Disable read-only mode action when doc is modified

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Thought about it bit more, actually like the "I can save even thought not 
modified" I think the "I can set read-only thought modified" is ok and actually 
no bug but a feature.
  I see no merit in forbidding that (and actually would be even confused why 
this is disabled sometimes).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19511

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I think the lock icon won't hurt.
  
  For the implementation: isn't it enough to watch for the 
readWriteChanged(...) signal of the document and trigger the modifiedChanged() 
changed there?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19512

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19517: DocumentPrivate: Auto reload in read-only mode

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I think in principle the idea is sound.
  
  But e.g., if you have have some file where one process writes to "fast" and 
it is "large" this will instantly lock up the application.
  
  If we really want that, we need to: 1) ask the user e.g. if he wants to 
"auto-reload" this document on first change 2) have some timer based 
throtteling of the reloading to avoid lockups.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D18793: Handle text completion with block selection mode

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I don't like the change to call typeChars.
  
  1. that needs a valid view, activeView() might be null.
  2. replaceText is not interactive per-default, but typeChars is.
  
  And yes, a test would be wanted I think,too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18793

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, mwolff
Cc: loh.tar, mwolff, kde-frameworks-devel, kwrite-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19461: Logcat: fix dsError color with underline="0"

[Christoph Cullmann]

cullmann added a comment.


  Question: I just applied this but adjust the hl back to
  
  
  
  
  For me the tests still work and I see no underline.
  
  Is the patch then at all needed for current master?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19461

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19511: ViewPrivate: Disable read-only mode action when doc is modified

[Christoph Cullmann]

cullmann added a comment.


  Hmm, two things:
  
  1. implementation wise: don't we have a problem here that the 
connect(document(), ::DocumentPrivate::modifiedChanged, [=] { 
m_toggleWriteLock->setEnabled(!doc()->isModified()); }); will not be 
unconnected if the view dies and we call on an invalid pointer?
  
  2. logic wise: why not allow people to set read only if it was modified? That 
avoids that you type something into the document by accident.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19511

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

[Christoph Cullmann]

cullmann added a comment.


  :=) Perhaps I read this diff to fast, but I can not really tell if it does 
what it should.
  
  I can understand from the description it tries to keep auto-wrapped things in 
balance during editing.
  
  I think to better understand the behavior, one needs to have tests for the 
different cases it kicks in.
  
  For the implementation: I think that code shall not be triggered ever if the 
user has the static wrap off, I think that would be very confusing.
  
  I am even not sure if that should be the default behavior or if one should 
not be able to turn that off to have a "dumb" but deterministic wrapping.
  
  But I use static word wrap "never", therefore I might be off with my opinion.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19131

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  Given we have a test, the code is documented and nobody raises large 
objections since long over the latest implementation, I think this shall go in 
:=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17949

To: loh.tar, #ktexteditor, mwolff, cullmann
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.10 - Build # 18 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.10/18/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Mar 2019 17:08:54 +
 Build duration:
7 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   CONSOLE OUTPUT
  [...truncated 658 lines...][2019-03-04T17:15:35.926Z] -- Set runtime path of "/home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert//home/jenkins/install-prefix/lib64/libKF5Declarative.so.5.56.0" to "/home/jenkins/install-prefix/lib64"[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/libKF5Declarative.so[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/kdeclarative/kdeclarative_export.h[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/kdeclarative/kdeclarative.h[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/kdeclarative/qmlobject.h[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/kdeclarative/qmlobjectsharedengine.h[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/kdeclarative/configpropertymap.h[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/mkspecs/modules/qt_KDeclarative.pri[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/QuickAddons/ImageTexturesCache[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/QuickAddons/ManagedTextureNode[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/KQuickAddons/ImageTexturesCache[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/KQuickAddons/ManagedTextureNode[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/KQuickAddons/QtQuickSettings[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/KQuickAddons/ConfigModule[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/KQuickAddons/QuickViewSharedEngine[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/libKF5QuickAddons.so.5.56.0[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/libKF5QuickAddons.so.5[2019-03-04T17:15:35.926Z] -- Set runtime path of "/home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert//home/jenkins/install-prefix/lib64/libKF5QuickAddons.so.5.56.0" to "/home/jenkins/install-prefix/lib64"[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/libKF5QuickAddons.so[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/quickaddons/quickaddons_export.h[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KDeclarative/quickaddons/imagetexturescache.h[2019-03-04T17:15:35.926Z] -- Installing: /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.12 - Build # 14 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.12/14/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 04 Mar 2019 17:05:51 +
 Build duration:
9 min 45 sec and counting
   BUILD ARTIFACTS
  acc/KF5Declarative-5.56.0.xmllogs/KF5Declarative/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(5/15)21%
(12/57)21%
(12/57)20%
(689/3406)14%
(295/2043)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(5/5)100%
(5/5)83%
(382/459)39%
(182/465)src.calendarevents0%
(0/2)0%
(0/2)0%
(0/62)0%
(0/2)src.kdeclarative75%
(3/4)75%
(3/4)51%
(150/297)38%
(55/144)src.kdeclarative.private100%
(2/2)100%
(2/2)19%
(6/31)0%
(0/18)src.kpackagelauncherqml0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/18)src.qmlcontrols.draganddrop0%
(0/7)0%
(0/7)0%
(0/359)0%
(0/200)src.qmlcontrols.kcmcontrols0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.qmlcontrols.kconfig0%
(0/2)0%
(0/2)0%
(0/11)0%
(0/2)src.qmlcontrols.kcoreaddons0%
(0/4)0%
(0/4)0%
(0/85)0%
(0/66)src.qmlcontrols.kioplugin0%
(0/2)0%
(0/2)0%
(0/20)0%
(0/18)src.qmlcontrols.kquickcontrols.private0%
(0/4)0%
(0/4)0%
(0/314)0%
(0/220)src.qmlcontrols.kquickcontrolsaddons8%
(1/13)8%
(1/13)5%
(65/1303)5%
(35/720)src.qmlcontrols.kwindowsystemplugin0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/36)src.quickaddons17%
(1/6)17%
(1/6)28%
(86/311)18%
(23/130)tests0%
(0/2)0%
(0/2)0%
(0/27)0%
(0/2)

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.10 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.10/17/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Mar 2019 17:05:51 +
 Build duration:
3 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Declarative-5.56.0.xmlcompat_reports/KF5Declarative_compat_report.htmllogs/KF5Declarative/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(5/15)21%
(12/57)21%
(12/57)20%
(689/3406)14%
(295/2043)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(5/5)100%
(5/5)83%
(382/459)39%
(182/465)src.calendarevents0%
(0/2)0%
(0/2)0%
(0/62)0%
(0/2)src.kdeclarative75%
(3/4)75%
(3/4)51%
(150/297)38%
(55/144)src.kdeclarative.private100%
(2/2)100%
(2/2)19%
(6/31)0%
(0/18)src.kpackagelauncherqml0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/18)src.qmlcontrols.draganddrop0%
(0/7)0%
(0/7)0%
(0/359)0%
(0/200)src.qmlcontrols.kcmcontrols0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.qmlcontrols.kconfig0%
(0/2)0%
(0/2)0%
(0/11)0%
(0/2)src.qmlcontrols.kcoreaddons0%
(0/4)0%
(0/4)0%
(0/85)0%
(0/66)src.qmlcontrols.kioplugin0%
(0/2)0%
(0/2)0%
(0/20)0%
(0/18)src.qmlcontrols.kquickcontrols.private0%
(0/4)0%
(0/4)0%
(0/314)0%
(0/220)src.qmlcontrols.kquickcontrolsaddons8%
(1/13)8%
(1/13)5%
(65/1303)5%
(35/720)src.qmlcontrols.kwindowsystemplugin0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/36)src.quickaddons17%
(1/6)17%
(1/6)28%
(86/311)18%
(23/130)tests0%
(0/2)0%
(0/2)0%
(0/27)0%
(0/2)

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.12/18/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 04 Mar 2019 17:05:51 +
 Build duration:
1 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D19517: DocumentPrivate: Auto reload in read-only mode

[loh tar]

loh.tar added a comment.


  I would like to expand this patch by "auto reload when file is empty"
  Sometimes I have the case that a session is opened where some files are gone 
due to work on a different branch. Switching the branch then caused to ask 
unneeded.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19517: DocumentPrivate: Auto reload in read-only mode

[loh tar]

loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

[Harald Sitter]

sitter added a comment.


  I haven't had a proper look, so only style complaints for now... but...
  
  Isn't the problem rather that the daemon shouldn't be randomly restarted on a 
live system? I.e. this ultimately is an integration issue on the distro-level.
  I doubt many if any avahi clients handle this properly and disadvantageous 
side effects are rather expected. Same as pulseaudio for example.
  
  So I am not sure if this is worth handling at all, but if we handle it we 
should do it properly and republish/rediscover services. The client shouldn't 
get broken frontend objects just because the backend of the backend restarted.

INLINE COMMENTS

> CMakeLists.txt:22
>  avahi_listener.cpp
> +avahi-disconn-handler.cpp
>  )

disconn**ect**

> avahi-disconn-handler.cpp:1
> +#include 
> +#include 

needs a license header

> avahi-disconn-handler.cpp:8
> +auto nameChangeObserver = new 
> QDBusServiceWatcher("org.freedesktop.Avahi", QDBusConnection::systemBus(), 
> QDBusServiceWatcher::WatchForOwnerChange, this);
> +QObject::connect(nameChangeObserver, 
> ::serviceOwnerChanged, this,
> + [this](const QString& name, const QString& oldO, const 
> QString& newO) {

no need for QObject::

> avahi-disconn-handler.cpp:9
> +QObject::connect(nameChangeObserver, 
> ::serviceOwnerChanged, this,
> + [this](const QString& name, const QString& oldO, const 
> QString& newO) {
> + if (newO.isEmpty())

`&` go right of the space

use descriptive variable names

> avahi-disconn-handler.cpp:15
> +
> +auto KDNSSD::AvahiDisconnectHandler::instance() -> AvahiDisconnectHandler&
> +{

don't use trailing return type but simply use return type instead of auto

> avahi-disconn-handler.h:1
> +#ifndef AVAHI_DISCONNECT_HANDLER___H_
> +#define AVAHI_DISCONNECT_HANDLER___H_

needs a license header

> avahi-disconn-handler.h:8
> +
> +  class AvahiDisconnectHandler : public QObject
> +  {

we do not indent classes within a namespace

> avahi-disconn-handler.h:12
> +
> +  AvahiDisconnectHandler();
> +  Q_SIGNALS:

privates at the bottom of the class in a private section please

> avahi-disconn-handler.h:13
> +  AvahiDisconnectHandler();
> +  Q_SIGNALS:
> +  void avahiDisconnected();

the signal section goes after the public section

> avahi-domainbrowser.cpp:40
> + [this]() {
> + delete d->m_browser;
> + d->m_browser = 0;

deleteLater may be better

the cleanup in this slot seems insufficient compared to the cleanup done for 
ServiceBrowser?

> avahi-remoteservice.cpp:37
>  {
> +  QObject::connect(::instance (), 
> ::avahiDisconnected, this,
> +   [this]() {

no need for QObject::

goes for all? other classes as well

> avahi-remoteservice.cpp:40
> +   K_D;
> +   if(d->m_resolver) {
> +   delete d->m_resolver;

space after if

> avahi-servicebrowser.cpp:42
>  d->m_timer.setSingleShot(true);
> +QObject::connect(::instance (), 
> ::avahiDisconnected, d, [this]() { d->clean(); });
>  }

no space after instance

also I think you need to bind the connection to `this` seeing as you are 
capturing `this`

> avahi-servicebrowser.cpp:42
>  d->m_timer.setSingleShot(true);
> +QObject::connect(::instance (), 
> ::avahiDisconnected, d, [this]() { d->clean(); });
>  }

no need for QObject::

> avahi-servicebrowser_p.h:38
>  friend class ServiceBrowser; // So the public class may functor connect.
> +void clean();
>  public:

put this in an actual private section at the bottom please

> avahi-servicetypebrowser.cpp:37
>  d->m_timer.setSingleShot(true);
> +QObject::connect(::instance(), 
> ::avahiDisconnected, this,
> + [this]() {

no need for QObject::

> avahi-servicetypebrowser.cpp:39
> + [this]() {
> + delete d->m_browser;
> + d->m_browser = 0;

deleteLater may be better seeing as this is a slot and deletes in slots are 
dangerous

> avahi-servicetypebrowser.cpp:40
> + delete d->m_browser;
> + d->m_browser = 0;
> + });

nullptr

> avahi_listener.cpp:28
>  {
> +m_connection = QObject::connect(::instance(), 
> ::avahiDisconnected,
> +[this]() {

use a member initializer list here

> avahi_listener.cpp:32
> +});
>  }
>  

The other classes ctors look super repetitive and could maybe just be moved in 
here. couldn't you simply make a pure virtual `reset()` in here that is 
implemented in all avahi listeners and connect to that? Specifically since the 
expectation is that every dbus based object switches state when avahi 
disappears/appears the best way to express that in a way that one doesn't 
forget about it moving forward would be making the 

D19517: DocumentPrivate: Auto reload in read-only mode

[loh tar]

loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19517: DocumentPrivate: Auto reload in read-only mode

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  This patch auto reload the document only when it was not already
  modified and it is in read-only mode
  

  
  BUG:375361
  BUG:377505
  FIXED-IN: 5.57

TEST PLAN
  375361 Request a behaviour like tail -f, to fulfil this would an option 
needed to scroll to the bottom of the view or move the cursor there.
  However, some comments are against this at all, but I think it's no harm to 
have it. 
  Should it be accected in general I would look to add such extra option before 
landing.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19517

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

[Jiří Paleček]

jpalecek edited the summary of this revision.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D19514

To: jpalecek, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

[Jiří Paleček]

jpalecek added inline comments.

INLINE COMMENTS

> avahi-publicservice_p.h:42
>  PublicServicePrivate(PublicService *parent, const QString , const 
> QString , const QString , unsigned int port) :
> -QObject(), ServiceBasePrivate(name, type, domain, QString(), port), 
> m_published(false), m_running(false), m_group(nullptr),
> +QObject(parent), ServiceBasePrivate(name, type, domain, QString(), 
> port), m_published(false), m_running(false), m_group(nullptr),
>  m_server(nullptr), m_collision(false), m_parent(parent)

Initialize the QObject with the parent object to ensure deleting the Private 
object. In this case, the ##PublicService## object simply doesn't do it in its 
destructor AFAIK

> avahi_listener.cpp:28
>  {
> +m_connection = QObject::connect(::instance(), 
> ::avahiDisconnected,
> +[this]() {

##m_connection## is needed to manually manage the connection, because 
##AvahiListener## is not a ##QObject##. It is inherited by ##QObject##s, but 
relying on that (and casting) would need that the ##QObject## is initialized 
first which would be brittle. OTOH saving the connection handle seems 
hassle-free.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D19514

To: jpalecek, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

[Jiří Paleček]

jpalecek edited the test plan for this revision.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D19514

To: jpalecek, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

[Kai Uwe Broulik]

broulik added a reviewer: sitter.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D19514

To: jpalecek, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

[Jiří Paleček]

jpalecek edited the summary of this revision.
jpalecek edited the test plan for this revision.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D19514

To: jpalecek
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

[Jiří Paleček]

jpalecek created this revision.
Herald added a project: Frameworks.
jpalecek requested review of this revision.

REVISION SUMMARY
  This is a first take at tackling a problem caused by avahi going out of 
service -- usually its restart during an upgrade. In the current state, these 
things happen:
  
  - kdnssd holds dbus paths of avahi objects that no longer exist. Eventually, 
it calls methods on those paths, which might or might not exist or designate 
different objects
  - the client won't discover that published addresses/browsing addresses etc. 
don't work anymore. Ironically (this happens with kopete), the client will get 
some error message in the moment avahi comes //alive// again, not when it's 
going dead
  - KDNSSD objects used with this avahi instance stop working, and are unusable 
in the future
  
In this diff, mostly the first problem is tackled. I add a new singleton 
class, ##AvahiDisconnectListener##, which will provide a signal when avahi goes 
away. Every KDNSSD object would listen for that signal and perform the 
necessary cleanup. This means, in this diff, mostly deleting dbus objects and 
clearing dbus addresses. On top of that, the ##PublicService## class is changed 
that it reports failure to publish with a ##published(false)## signal, and a 
##RemoteService## reports failure with ##resolved(false)##. The latter should 
be able to restart when convienient with ##resolveAsync##. Other objects are 
simply left in a consistent, but nonworking state and can't be used anymore, 
because they lack the signals to signal error, and methods to restart their 
operations. Looking forward, this patch could be extended by adding 
aforementioned error signals, or even, providing a much better user experience, 
automatically restarting normal operation when avahi comes on again. That 
information is doable in the client, but is tedious and error prone, as it 
needs listening for DBus ##NameOwnerChanged##, and then correctly wait because 
Avahi isn't ready for business right away. Also, you need to manage all the 
race conditions.

TEST PLAN
  Launch kopete with an (online) Bonjour Account and run
  
WARNING: this stops avahi
# systemctl mask avahi-daemon.socket; systemctl stop avahi-daemon;
  
  kopete should notice immediately that Bonjour isn't online anymore. Ideally, 
when you restart avahi with
  
  1. systemctl unmask avahi-daemon.socket; systemctl start avahi-daemon
  
kopete should make Bonjour online immediately, however that neds more work

REPOSITORY
  R272 KDNSSD

BRANCH
  wip-merged

REVISION DETAIL
  https://phabricator.kde.org/D19514

AFFECTED FILES
  src/CMakeLists.txt
  src/avahi-disconn-handler.cpp
  src/avahi-disconn-handler.h
  src/avahi-domainbrowser.cpp
  src/avahi-publicservice.cpp
  src/avahi-publicservice_p.h
  src/avahi-remoteservice.cpp
  src/avahi-servicebrowser.cpp
  src/avahi-servicebrowser_p.h
  src/avahi-servicetypebrowser.cpp
  src/avahi_listener.cpp
  src/avahi_listener_p.h

To: jpalecek
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  This may not needed because the information is already shown as part of the
  inputMode label, on the other hand is that information there somehow 
misplaced.

TEST PLAN
  You see the little lock bottom left?
  F6656347: 1551707627.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19512

AFFECTED FILES
  src/view/katestatusbar.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19511: ViewPrivate: Disable read-only mode action when doc is modified

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  It's somehow pointless to activate the read-only mode when the document
  is already modified. However, after an save event becomes the action
  available again.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19511

AFFECTED FILES
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19508: [kconf_update] move from custom logging tech to qCDebug

[Aleix Pol Gonzalez]

apol added a reviewer: Frameworks.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19508

To: sitter, apol, aacid, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19508: [kconf_update] move from custom logging tech to qCDebug

[Aleix Pol Gonzalez]

apol added a comment.


  +1 makes sense to me

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19508

To: sitter, apol, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19338: New location for KNSRC files

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 53117.
leinir added a comment.


  Since 5.57, not 5.56

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19338?vs=52607=53117

REVISION DETAIL
  https://phabricator.kde.org/D19338

AFFECTED FILES
  KF5NewStuffCoreConfig.cmake.in
  README.md
  src/core/engine.cpp
  src/core/engine.h

To: leinir, #knewstuff, apol, ngraham, fvogt
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

[David Faure]

dfaure closed this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19503: Improve code: Remove temp container just to iterate

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R283:d044788ac38d: Improve code: Remove temp container just to 
iterate (authored by mlaurent).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19503?vs=53098=53116

REVISION DETAIL
  https://phabricator.kde.org/D19503

AFFECTED FILES
  src/backends/polkit-1/Polkit1Backend.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  Thanks.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D19506#424301 , @cgiboudeaux 
wrote:
  
  > The autotest has to be fixed as well
  
  
  Comment edited, the includedir value is correct for this test.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

[Christophe Giboudeaux]

cgiboudeaux requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  The autotest has to be fixed as well
  
  The includedir value looks bogus, the test file contains
  
includedir=/usr/KCoreAddons

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

[Filipe Azevedo]

fazevedo accepted this revision.
fazevedo added a comment.
This revision is now accepted and ready to land.


  Works for me !

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo
Cc: fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, ngraham, bruns

D19508: [kconf_update] move from custom logging tech to qCDebug

[Harald Sitter]

sitter added reviewers: apol, aacid.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19508

To: sitter, apol, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19508: [kconf_update] move from custom logging tech to qCDebug

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the previous logging tech got kind of defunct in 2014 (to the point where
  it was basically qCDebug). seeing as no one really complained it seems
  reasonable to just move to qCDebug instead and make use of category filters
  and other qdebug goodness (such as system logging facilities for the
  various platforms)
  
  - new logging category kf5.kconfig.update; at info level by default (i.e. 
unless otherwise configured kconf_update is now silent)
  - --debug cmdline option now also attempts to force-enable the debug mode on 
that category (and debugs that attempt in of itself, so we don't get confused 
by categories magically getting enabled).
  - all log() calls are now qCDebug calls
  - all logFileErorr() calls (which was context-sensitive to the .upd file 
parsing) have been changed to qCDebugFile
  - qCDebugFile is a new *macro* wrapping around qCDebug to give it file context
  - everything is now qCDebug instead of qDebug
  - arguments updated to drop excess quoting and spaces to reduce "noise"
  
  https://markmail.org/thread/ofaeqcabguxyohyb

TEST PLAN
  updater still works and debugs when debug is enabled

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19508

AFFECTED FILES
  CMakeLists.txt
  src/kconf_update/CMakeLists.txt
  src/kconf_update/kconf_update.cpp

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 19 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/19/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 04 Mar 2019 10:23:11 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.56.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRegion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26881/31461)53%
(10788/20173)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12327/12394)50%
(6490/12887)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6287/7396)65%
(1812/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7813/9018)66%
(2309/3498)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/30/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 04 Mar 2019 10:23:11 +
 Build duration:
5 min 41 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 25 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/25/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Mar 2019 10:23:11 +
 Build duration:
5 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.56.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPointerConstraints
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(238/260)92%
(238/260)83%
(26218/31410)52%
(10533/20173)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)97%
(12041/12390)49%
(6332/12887)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client97%
(72/74)97%
(72/74)83%
(6133/7368)64%
(1784/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)84%
(7590/8999)64%
(2240/3498)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

[David Faure]

dfaure created this revision.
dfaure added a reviewer: apol.
Herald added projects: Frameworks, Build System.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  If we ever end up in a situation where the generated .pc file is
  actually used by cmake's pkg_check_modules, then we need the
  includedir and libdir variables; pkg_check_modules ignores the
  Makefile-like Libs and Cflags lines of the .pc file.
  
  Context: craft adds a cmake buildsystem for sqlite3, which is then
  found using pkgconfig in akonadi.

TEST PLAN
  Filipe Azevedo is doing all the testing, I'm just providing patches :)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19506

AFFECTED FILES
  modules/ECMGeneratePkgConfigFile.cmake

To: dfaure, apol
Cc: kde-buildsystem, kde-frameworks-devel, michaelh, ngraham, bruns

D19476: Hopefully fix flaky remote access test

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:f0152135b198: Hopefully fix flaky remote access test 
(authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19476?vs=52992=53107

REVISION DETAIL
  https://phabricator.kde.org/D19476

AFFECTED FILES
  autotests/client/test_remote_access.cpp

To: davidedmundson, #kwin, zzag
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11924: Add "SkipSwitcher" to API

[Vlad Zagorodniy]

zzag added a comment.


  @dfaure I'll take a look into this issue.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: zzag, dfaure, kde-frameworks-devel, #plasma, ngraham, graesslin, apol, 
michaelh, bruns

D19476: Hopefully fix flaky remote access test

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19476

To: davidedmundson, #kwin, zzag
Cc: kde-frameworks-devel, michaelh, ngraham, bruns