D19598: DocumentPrivate: Make auto bracket slightly smarter

[loh tar]

loh.tar updated this revision to Diff 53412.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - *hmpf* forgot may last cleanup change

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19598?vs=53410=53412

REVISION DETAIL
  https://phabricator.kde.org/D19598

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19598: DocumentPrivate: Make auto bracket slightly smarter

[loh tar]

loh.tar updated this revision to Diff 53410.
loh.tar added reviewers: cullmann, mwolff.
loh.tar added a comment.


  - Add KateDocumentTest::testAutoBrackets
  
  Just a note to the current RegEx solution:
  It's done as you see in a slightly redundant dumb way. Perhaps is a special 
function without regex faster?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19598?vs=53375=53410

REVISION DETAIL
  https://phabricator.kde.org/D19598

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19602: [KParts] Fix compilation for Qt 5.13

[Matthieu Gras]

matthieugras created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
matthieugras requested review of this revision.

REVISION SUMMARY
  Method is deprecated in Qt 5.13

TEST PLAN
  Compiles

REPOSITORY
  R306 KParts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19602

AFFECTED FILES
  src/browserrun.cpp

To: matthieugras
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis added a comment.


  I just noticed, there is already a `go-top` icon that looks just like 
`collapse-all`. That's a problem. "Collapse all" is different enough from "Go 
to top" that they shouldn't be the same icon.
  
  I do think that the arrow with the bar on top is more appropriate for 
"Collapse all" though, so I think `go-top` should be changed, along with the 
other `go-*` icons. Maybe double arrows like KWin's "Keep above" button? Then 
we would need to decide if "Go to top" is similar enough to "Keep above" that 
they should be allowed to look the same.
  
  From the VDG chat:
  
  > Any thoughts on https://phabricator.kde.org/D19575 ? Should I make them 
match them to the titlebar ones which I think have a shorter top line, or do 
some symlinking action with arrow-up-double which is similar to these as well?
  
  They should match the current version of `go-top`. The problem with matching 
the titlebar button is that it's not perfectly aligned with the grid. The 
titlebar button should probably be changed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis added a comment.


  The symlinks in the symbolic folder should end with `-symbolic`

REPOSITORY
  R266 Breeze Icons

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis added a comment.


  In D19575#426762 , @ngraham wrote:
  
  > Could we get symlinks for these that point to `window-keep-above` and 
`window-keep-below` too?
  
  
  Ink KWin, the keep above and keep below icons are different. These are the 
shade/unshade buttons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[Nathaniel Graham]

ngraham added a comment.


  Could we get symlinks for these that point to `window-keep-above` and 
`window-keep-below` too?

REPOSITORY
  R266 Breeze Icons

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19307: Enforce new muted icon style in all action icons

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:ae8fcdcd409b: Enforce new muted icon style in all action 
icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19307?vs=52566=53384

REVISION DETAIL
  https://phabricator.kde.org/D19307

AFFECTED FILES
  icons-dark/actions/16/player-volume-muted.svg
  icons-dark/actions/24/audio-volume-low.svg
  icons-dark/actions/24/audio-volume-medium.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons/actions/16/player-volume-muted.svg
  icons/actions/24/audio-volume-low.svg
  icons/actions/24/audio-volume-medium.svg
  icons/actions/24/audio-volume-muted.svg

To: trickyricky26, #vdg, ngraham, rooty
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19307: Enforce new muted icon style in all action icons

[Krešimir Čohar]

rooty accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  correct-muted-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg, ngraham, rooty
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  There's free space check in CopyJob. And Dolphin still gives an error in the 
said situation. But if some application decides to directly use FileCopyJob 
then IMO the free space check should be at application's side. Anyway, I tried 
adding it here and it felt awkward to me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D19599: textfield height based only on clear text

[Krešimir Čohar]

rooty added a dependent revision: D19214: [sddm-theme] Replace login button 
label with icon.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/echo

REVISION DETAIL
  https://phabricator.kde.org/D19599

To: mart, #plasma, ngraham, rooty
Cc: rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19599: textfield height based only on clear text

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  Good things come to those who wait, thanks for the fix.
  I can also confirm that this doesn't affect any other font adversely in any 
way.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/echo

REVISION DETAIL
  https://phabricator.kde.org/D19599

To: mart, #plasma, ngraham, rooty
Cc: rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19599: textfield height based only on clear text

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  It's fixed
  
  Of course now the issue with the dots is worse since the dots are just too 
high up in the text field: F6670642: Peek 2019-03-07 10-44.gif 

  
  However that's an issue in Noto Symbols itself. Aoparently all the characters 
in the whole font have a descent value that's too large (7 vs 4 for in regular 
Noto Sans). We're tracking this with 
https://github.com/googlei18n/noto-fonts/issues/1468. Thanks so much for fixing 
this, Marco!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/echo

REVISION DETAIL
  https://phabricator.kde.org/D19599

To: mart, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19585: [CopyJob] Report results after finishing copy

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  > Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it 
sit at the "Override?" prompt until the job view in Plasma showed up. >Chose a 
different filename and continued.
  > [...]
  > The URL isn't updated in case of a rename but I bet it just needs a 
m_bURLDirty call somewhere in the conflict handler
  
  I followed the steps for $HOME/foo. 
  Before: notification showed $HOME/foo
  After: notification showed $HOME/foo1
  
  Keeping or removing the line in D19586  
had no effect at all.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19585

To: broulik, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19599: textfield height based only on clear text

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  as the implicit height could change when switching to password mode,
  use a textmetrics which always computes it from the visible text
  
  BUG:399155

TEST PLAN
  height doesn't change

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/echo

REVISION DETAIL
  https://phabricator.kde.org/D19599

AFFECTED FILES
  src/declarativeimports/plasmastyle/TextFieldStyle.qml

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19598: DocumentPrivate: Make auto bracket slightly smarter

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ..in handling of quotes
  
  - Skip auto quotes when these looks already balanced
  - Improve readability, const correctness
  - const QChar as value, not reference
  
  BUG:405089
  FIXED-IN: 5.56

TEST PLAN
Try to type this in a C++ file:
('\'') => ended up in something like: ('\''')

Try to add afterwarnds double quotes to some word in a text, without to 
select the word:
foo "bar" haz => ended up in something like: foo "bar"" haz
  
  - Autotest looks good
  - Contains partial code from unloved D17693 
 which is here only added to became it in. 
See latter two Summary notes
  - Is the fix-in number right?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19598

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19557: Update css

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53367.
ognarb added a comment.


  Add breeze like style for note/info/warning/tip admonitions and make image 
responsive

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53359=53367

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19532: Don't crash when no contexts are present

[Christoph Cullmann]

cullmann added a comment.


  In D19532#426505 , @dhaumann wrote:
  
  > As you wish.
  >
  > Questions remains: does it fix https://bugs.kde.org/show_bug.cgi?id=401480
  
  
  No, will just crash later.
  Therefore one needs a proper variant of https://phabricator.kde.org/D19533 in 
addition.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dominik Haumann]

dhaumann added a comment.


  As you wish.
  
  Questions remains: does it fix https://bugs.kde.org/show_bug.cgi?id=401480

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53359.
ognarb edited the test plan for this revision.
ognarb added a comment.


  Change to jpg and remove now useless files

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53251=53359

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19534: [i18n] compile without foreach

[Laurent Montel]

mlaurent closed this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D19534

To: mlaurent, dfaure
Cc: kossebau, sh-zam, kde-frameworks-devel, michaelh, ngraham, bruns

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

[Kai Uwe Broulik]

broulik added a dependent revision: D19588: [Notifications] Improve finished 
notification.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19586

To: broulik, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19585: [CopyJob] Report results after finishing copy

[Kai Uwe Broulik]

broulik added a dependent revision: D19588: [Notifications] Improve finished 
notification.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19585

To: broulik, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, chingku.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When a file already exists and user choses to rename the file, the URL wasn't 
updated.
  This lead to the job potentially still showing the old destination when 
finished.

TEST PLAN
  See D19585 
  
  Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it sit 
at the "Override?" prompt until the job view in Plasma showed up. Chose a 
different filename and continued.
  
  With this, the destination URL reflects the rename and points to the actual 
file copied.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19586

AFFECTED FILES
  src/core/copyjob.cpp

To: broulik, dfaure, chingku
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

[Kai Uwe Broulik]

broulik edited reviewers, added: chinmoyr; removed: chingku.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19586

To: broulik, dfaure, chinmoyr, chingku
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19585: [CopyJob] Report results after finishing copy

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, chinmoyr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Currently, `slotReport` is called all the way at the end when in 
`STATE_SETTING_DIR_ATTRIBUTES`. However, `slotReport` does nothing in this 
state.
  Instead, move it to before changing away from `STATE_COPYING_FILES` so that 
progress is correctly reported for a final time.

TEST PLAN
  Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it sit 
at the "Override?" prompt until the job view in Plasma showed up. Chose a 
different filename and continued.
  
  Before, the job would finish without having reported any progress as the 
report timer never fired since that one file was copied super quickly. With 
this patch, the final progress is correct. The URL isn't updated in case of a 
rename but I bet it just needs a `m_bURLDirty` call somewhere in the conflict 
handler

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19585

AFFECTED FILES
  src/core/copyjob.cpp

To: broulik, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D19583

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It is not really meant to be changing after the job started, but there can be 
instances where the job first has to examine the real destination and only can 
then set it and start.
  This patch ensures that at least when the job has finished, the destUrl is 
correct so that the job view can provide a more useful finished notification.

TEST PLAN
  In plasma-browser-integration I only get the destination after the job has 
been started.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D19583

AFFECTED FILES
  src/kuiserverjobtracker.cpp

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19532: Don't crash when no contexts are present

[Christoph Cullmann]

cullmann added a comment.


  I the unit test is separated, no longer all things will be tested with the 
invalid definitions.
  
  In D19532#426268 , @dhaumann wrote:
  
  > Could you change the unit test please to not mix with the other ones?
  >
  > - add a new void testBrokenDefinition()
  > - use a local Repository repo;
  > - add custom search oath to this repo
  > - and then check only the broken file.
  >
  >   This would be much cleaner and better to understand & maintain. Maybe 
even put broken.xml into autotest/input/syntax/broken/
  
  
  Hmm, I disagree: then not all functions are tested with a broken file in the 
repo.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19581: Fix build with cmake < 3.7

[Wolfgang Bauer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a08e2ebd589f: Fix build with cmake  3.7 (authored by 
wbauer).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19581?vs=53332=53336

REVISION DETAIL
  https://phabricator.kde.org/D19581

AFFECTED FILES
  data/CMakeLists.txt

To: wbauer, vkrause
Cc: kwrite-devel, kde-frameworks-devel, cullmann, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D19581: Fix build with cmake < 3.7

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19581

To: wbauer, vkrause
Cc: kwrite-devel, kde-frameworks-devel, cullmann, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D19581: Fix build with cmake < 3.7

[Wolfgang Bauer]

wbauer created this revision.
wbauer added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
wbauer requested review of this revision.

REVISION SUMMARY
  VERSION_GREATER_EQUAL requires cmake 3.7 or higher, but the minimum version 
supported by KDE Frameworks is 3.5.
  So use NOT VERSION_LESS instead, which is logically equivalent and also
  works with older cmake versions.

TEST PLAN
  Builds fine with cmake 3.5.2 now.
  Before, I got this cmake error:
  
CMake Error at data/CMakeLists.txt:69 (if):
  if given arguments:

"3.5.2" "VERSION_GREATER_EQUAL" "3.13.0"

  Unknown arguments specified
  
  Still builds fine with newer cmake versions, tested with 3.10.2 and 3.13.4.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19581

AFFECTED FILES
  data/CMakeLists.txt

To: wbauer
Cc: kwrite-devel, kde-frameworks-devel, cullmann, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dominik Haumann]

dhaumann added a comment.


  Could you change the unit test please to not mix with the other ones?
  
  - add a new void testBrokenDefinition()
  - use a local Repository repo;
  - add custom search oath to this repo
  - and then check only the broken file.
  
  This would be much cleaner and better to understand & maintain. Maybe even 
put broken.xml into autotest/input/syntax/broken/

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dominik Haumann]

dhaumann added a comment.


  Will this fix https://bugs.kde.org/show_bug.cgi?id=401480 ?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann