D21264: Display accurate status message during installation

2019-05-17 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R432:2072ac711e15: Display accurate status message during 
installation (authored by ngraham).

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21264?vs=58227=58228

REVISION DETAIL
  https://phabricator.kde.org/D21264

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks, ndavis


D21264: Display accurate status message during installation

2019-05-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 58227.
ngraham added a comment.


  Rebase

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21264?vs=58224=58227

BRANCH
  update-status-message-during-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21264

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks, ndavis


D21264: Display accurate status message during installation

2019-05-17 Thread Noah Davis
ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  update-status-message-during-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21264

To: ngraham, #vdg, #frameworks, ndavis


D21264: Display accurate status message during installation

2019-05-17 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, the status message says "Samba is not installed" during the 
installation.
  Technically this is true, but it really should be describing the current 
status instead.

TEST PLAN
  F6829016: Message-2019-05-17_14.11.04.webm 


REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  update-status-message-during-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21264

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks


D18161: [kioslave/file] Add a codec for legacy filenames

2019-05-17 Thread David Faure
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> legacycodec.cpp:118
> +bool nonCharacter;
> +if (!(nonCharacter = QChar::isNonCharacter(uc)) && uc > 
> 0x && uc < 0x11) {
> +// surrogate pair

[it would be so much more readable to move the assignment to the previous 
line...]

> legacycodec.h:21
> +#ifndef LEGACY_CODEC_H
> +#define LEGACY_CODEC_H 1
> +

this "1" here is unusual :-)

> legacycodec.h:36
> +setCodecForLocale(nullptr);
> +};
> +

remove the extra ';', some compilers warn about that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18161

To: cfeck, #frameworks, #dolphin, dfaure
Cc: frispete, nathanshearer, nerdopolist, ngraham, kde-frameworks-devel, 
michaelh, bruns


D21204: Ensure no trailing slash in mountpoint read from fstab file.

2019-05-17 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:140
> +
> +// strips last slash so that the device matches the one returned by 
> getmntent when filesystem is mounted
> +// even when fstab mnt_dir ends with a '/' in /etc/fstab

break @ < 80 chars

> fstabhandling.cpp:142
> +// even when fstab mnt_dir ends with a '/' in /etc/fstab
> +if (source.endsWith((QLatin1Char('/' {
> +QString deviceName(source);

that likely breaks for "server:/" NFS mounts

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: ngraham, bruns, apol, kde-frameworks-devel, michaelh


D21249: Test current filter before setting a new one

2019-05-17 Thread Jan-Marek Glogowski
jglogowski updated this revision to Diff 58215.
jglogowski added a comment.


  Hope this compiles now. Since I can't test the rebased patch, I hope that is 
the last update.
  The original working version is based on v5.44. See my previous comment.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21249?vs=58193=58215

REVISION DETAIL
  https://phabricator.kde.org/D21249

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: jglogowski, #frameworks, ngraham
Cc: ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns


D21249: Test current filter before setting a new one

2019-05-17 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Sorry, but this doesn't compile:
  
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp: In member function 
‘bool KFileWidgetPrivate::matchFilter(const QString&, const QString&, bool)’:
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp:2459:25: error: ‘p’ 
declared as reference but not initialized
 for (const QString , patterns) {
 ^
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp:2459:36: error: 
expected ‘;’ before ‘)’ token
 for (const QString , patterns) {
^
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp:2459:36: error: 
expected primary-expression before ‘)’ token
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp:2459:36: error: 
expected ‘;’ before ‘)’ token
  
  Needs to be `for (const QString  : patterns) {`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21249

To: jglogowski, #frameworks, ngraham
Cc: ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns


D21098: Handle apps which set the desktopFileName property with filename suffix

2019-05-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:eef093cd6adc: Handle apps which set the desktopFileName 
property with filename suffix (authored by kossebau).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21098?vs=57807=58212

REVISION DETAIL
  https://phabricator.kde.org/D21098

AFFECTED FILES
  src/kstatusnotifieritem.cpp
  src/notifybyaudio_canberra.cpp
  src/notifybypopup.cpp

To: kossebau, broulik, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21098: Handle apps which set the desktopFileName property with filename suffix

2019-05-17 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  handledesktopfilenamesuffix

REVISION DETAIL
  https://phabricator.kde.org/D21098

To: kossebau, broulik, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 107 - Still Unstable!

2019-05-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/107/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 May 2019 16:43:22 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13378)18%
(1823/9885)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 100 - Still Unstable!

2019-05-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/100/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 May 2019 16:43:22 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13378)18%
(1823/9885)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 110 - Still Unstable!

2019-05-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/110/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 17 May 2019 16:43:22 +
 Build duration:
7 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21001: Update *.qmltypes to current API of QML modules

2019-05-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3b950f38ccd5: Update *.qmltypes to current API of QML 
modules (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21001?vs=57486=58202

REVISION DETAIL
  https://phabricator.kde.org/D21001

AFFECTED FILES
  src/declarativeimports/calendar/plugins.qmltypes
  src/declarativeimports/core/plugins.qmltypes
  src/declarativeimports/plasmacomponents/plugins.qmltypes
  src/declarativeimports/plasmaextracomponents/plugins.qmltypes
  src/declarativeimports/platformcomponents/plugins.qmltypes

To: kossebau, #plasma, apol, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21001: Update *.qmltypes to current API of QML modules

2019-05-17 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  updateqmltypes

REVISION DETAIL
  https://phabricator.kde.org/D21001

To: kossebau, #plasma, apol, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21001: Update *.qmltypes to current API of QML modules

2019-05-17 Thread Nathaniel Graham
ngraham added a reviewer: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21001

To: kossebau, #plasma, apol, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21204: Ensure no trailing slash in mountpoint read from fstab file.

2019-05-17 Thread Nathaniel Graham
ngraham added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:136
>  {
>  if (fstype.startsWith("fuse.")) {
>  return fstype + mountpoint;

So this situation could never happen with FUSE mounts? Or should that case be 
checked too.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: ngraham, bruns, apol, kde-frameworks-devel, michaelh


D21249: Test current filter before setting a new one

2019-05-17 Thread Jan-Marek Glogowski
jglogowski added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21249

To: jglogowski, #frameworks
Cc: michaelweghorn, kde-frameworks-devel, michaelh, ngraham, bruns


D21249: Test current filter before setting a new one

2019-05-17 Thread Jan-Marek Glogowski
jglogowski updated this revision to Diff 58193.
jglogowski added a comment.


  Readd dropped QLatin1Char and use them in new code too.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21249?vs=58191=58193

REVISION DETAIL
  https://phabricator.kde.org/D21249

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: jglogowski
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21249: Test current filter before setting a new one

2019-05-17 Thread Jan-Marek Glogowski
jglogowski planned changes to this revision.
jglogowski added a comment.


  This patch was developed on KIO v5.44 (git tag) in an Ubuntu 18.04 chroot 
(because that's my LibreOffice development environment) and rebased on master.
  The test-program was run on Debian Buster via 
LD_PRELOAD=./git_kio/build/bin/libKF5KIOFileWidgets.so, which has otherwise KIO 
v5.54.
  
  I tried to build master on Ubuntu 18.04, but that failed. The git log for 
kfilewidget.cpp looked unsuspicious enough.
  
  There were some conflicts in the rebase, which I manually fixed, but as 
always, this might result in typos, as I couldn't even compile master.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21249

To: jglogowski
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21249: Test current filter before setting a new one

2019-05-17 Thread Jan-Marek Glogowski
jglogowski created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jglogowski requested review of this revision.

REVISION SUMMARY
  If KFileWidget's filter list has two matching filters for an extension,
  it will always select the first filter, even if the current filter
  already matches the file name.
  

  
  This is fine, if you auto-select the filter to match the file name, but 
  breaks, if you want to auto-change the file name's extension via the 
  selected filter.
  

  
  So this checks, if the current filter already matches the file name
  before trying to find a matching filter and select it.
  

  
  BUG: 407642

TEST PLAN
  1. Compile and run the attached program to the bug report 407642
  2. Make sure that "auto extension" checkbox is enable
  3. Select the last file filter (DocBook (.xml)) via dropdown list
  
  OBSERVED RESULT
  Filter is "Word 2003 XML (.xml)"
  
  EXPECTED RESULT
  Filter is "DocBook (.xml)"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21249

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: jglogowski
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20838: Allow to drop one file or one folder on KDirOperator

2019-05-17 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  I think this can land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham, #frameworks
Cc: elvisangelaccio, apol, kde-frameworks-devel, michaelh, ngraham, bruns


D21204: Ensure no trailing slash in mountpoint read from fstab file.

2019-05-17 Thread Méven Car
meven updated this revision to Diff 58190.
meven added a comment.


  Move code change to _k_deviceNameForMountpoint

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=58189=58190

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham


D21204: Ensure no trailing slash in mountpoint read from fstab file.

2019-05-17 Thread Méven Car
meven marked 2 inline comments as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham


D21204: Ensure no trailing slash in mountpoint read from fstab file.

2019-05-17 Thread Méven Car
meven updated this revision to Diff 58189.
meven marked 3 inline comments as done.
meven added a comment.


  use chop to strip last /

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=58188=58189

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham


D21204: Ensure no trailing slash in mountpoint read from fstab file.

2019-05-17 Thread Méven Car
meven updated this revision to Diff 58188.
meven added a comment.


  Fix code, improved doc, better testing

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=58048=58188

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham


KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

2019-05-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/36/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 May 2019 08:54:12 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.59.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/262)92%
(240/262)85%
(27097/31760)53%
(10896/20416)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12431/12521)50%
(6550/13039)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6335/7453)65%
(1824/2820)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)86%
(7877/9129)66%
(2345/3566)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 44 - Still Unstable!

2019-05-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/44/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 17 May 2019 08:54:12 +
 Build duration:
6 min 41 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D18933: Allow compositors to send discrete axis values

2019-05-17 Thread Vlad Zagorodniy
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:ddff2c06d17a: Allow compositors to send discrete axis 
values (authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18933?vs=57883=58186

REVISION DETAIL
  https://phabricator.kde.org/D18933

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/server/pointer_interface.cpp
  src/server/pointer_interface.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns