KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/34/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 29 May 2019 05:50:24 +
 Build duration:
1 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D21467: fix highlighting of '\0' in C mode

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6ae1acec9ff5: fix highlighting of \0 in C 
mode (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21467?vs=58802=58808

REVISION DETAIL
  https://phabricator.kde.org/D21467

AFFECTED FILES
  autotests/folding/test.c.fold
  autotests/html/test.c.html
  autotests/html/test.qdocconf.html
  autotests/input/test.c
  autotests/reference/test.c.ref
  autotests/reference/test.qdocconf.ref
  src/lib/rule.cpp

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21467: fix highlighting of '\0' in C mode

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Guess that's fine.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21467

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21466: Recommend rebooting after installing Samba

[Nathaniel Graham]

ngraham added a comment.


  In D21466#471371 , @bruns wrote:
  
  > In D21466#471325 , @ngraham 
wrote:
  >
  > > In D21466#471321 , @bruns 
wrote:
  > >
  > > > For group membership changes, only a relogin is required (at most).
  > >
  > >
  > > I know, but telling people to log out and log back in again involves more 
ways to mess up than just telling them to reboot. It's not really much slower 
or more invasive either.
  >
  >
  > I disagree. How could a relogin mess something up? Rebooting requires 
stopping everything outside the session. It may also require unlocking the 
harddisk, waiting for the computer to boot, repopulating caches ... Requesting 
to reboot may also give some bad press - "Rebooting, is this Windows??? ROFL!!!"
  
  
  I'm talking more about UX than technical concerns. Rebooting can be 
accomplished with a single button; logging out and back in requires a 
multi-step process that offers more ways for a user to mess it up.
  
  > 
  > 
  >>> The only relevant group membership here is the usershare group
  >> 
  >> On Arch the group name is actually `sambashare`. I don't believe there is 
a consistent standard here.
  > 
  > The standard is to retrieve the group from the directory. KSambaShare 
already fetches the directory name from the samba config (to add a watch), 
exposing the owner group is trivial.
  
  How can I do that?

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol
Cc: bruns

D21466: Recommend rebooting after installing Samba

[Stefan Brüns]

bruns added a comment.


  In D21466#471325 , @ngraham wrote:
  
  > In D21466#471321 , @bruns wrote:
  >
  > > For group membership changes, only a relogin is required (at most).
  >
  >
  > I know, but telling people to log out and log back in again involves more 
ways to mess up than just telling them to reboot. It's not really much slower 
or more invasive either.
  
  
  I disagree. How could a relogin mess something up? Rebooting requires 
stopping everything outside the session. It may also require unlocking the 
harddisk, waiting for the computer to boot, repopulating caches ... Requesting 
to reboot may also give some bad press - "Rebooting, is this Windows??? ROFL!!!"
  
  >> The only relevant group membership here is the usershare group
  > 
  > On Arch the group name is actually `sambashare`. I don't believe there is a 
consistent standard here.
  
  The standard is to retrieve the group from the directory. KSambaShare already 
fetches the directory name from the samba config (to add a watch), exposing the 
owner group is trivial.

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol
Cc: bruns

D19785: DocumentPrivate: Review del/backspace

[Christoph Cullmann]

cullmann added a comment.


  Thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19785

To: loh.tar, #ktexteditor, cullmann
Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21467: fix highlighting of '\0' in C mode

[Christoph Cullmann]

cullmann added reviewers: dhaumann, vkrause, nibags.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21467

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21467: fix highlighting of '\0' in C mode

[Christoph Cullmann]

cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  before the second ' was red for the '\0' literal
  now it is ok, just like '\123'

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21467

AFFECTED FILES
  autotests/folding/test.c.fold
  autotests/html/test.c.html
  autotests/html/test.qdocconf.html
  autotests/input/test.c
  autotests/reference/test.c.ref
  autotests/reference/test.qdocconf.ref
  src/lib/rule.cpp

To: cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21466: Recommend rebooting after installing Samba

[Nathaniel Graham]

ngraham added a comment.


  In D21466#471321 , @bruns wrote:
  
  > For group membership changes, only a relogin is required (at most).
  
  
  I know, but telling people to log out and log back in again involves more 
ways to mess up than just telling them to reboot. It's not really much slower 
or more invasive either.
  
  > The only relevant group membership here is the usershare group
  
  On Arch the group name is actually `sambashare`. I don't believe there is a 
consistent standard here.
  
  > If the user does not belong to a group which should be able to write to 
, neither a relogin nor a reboot will help.
  
  Right, this is tracked with https://bugs.kde.org/show_bug.cgi?id=407846 and I 
plan to tackle it next.

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol
Cc: bruns

D21466: Recommend rebooting after installing Samba

[Stefan Brüns]

bruns added a comment.


  For group membership changes, only a relogin is required (at most).
  
  The only relevant group membership here is the usershare group, which can be 
determined from the owner/group of the "usershare path = " directory 
(samba config). If the user can write to the directory already, everything is 
fine. If the user does not belong to a group which should be able to write to 
, neither a relogin nor a reboot will help.

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol
Cc: bruns

D21466: Recommend rebooting after installing Samba

[Nathaniel Graham]

ngraham updated this revision to Diff 58801.
ngraham added a comment.


  Revert unintentional whitespace change

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21466?vs=58800=58801

BRANCH
  recommend-rebooting (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21466

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks, #dolphin, apol

D21466: Recommend rebooting after installing Samba

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Frameworks, Dolphin, apol.
ngraham requested review of this revision.

REVISION SUMMARY
  After Samba is installed, very frequently it will not work correctly until 
the machine is
  rebooted. One potential reason is when the installed package has made group 
membership
  changes, which only take effect after a reboot.
  
  This patch implements a reboot recommendation along with a button to reboot 
the machine.
  Both are shown immediately after Samba has been installed.
  
  Because some expert users may understand the technical details of what's 
going on, the
  reboot is only recommended, not required. If the window is closed and then 
re-opened,
  the normal Samba sharing configuration UI is displayed instead of the reboot 
prompt.
  
  Added a new function rather than using a Lambda because it may be useful for 
additional
  purposes too (e.g. https://bugs.kde.org/show_bug.cgi?id=407846)
  
  FEATURE: 407845
  FIXED-IN: 19.08.0

TEST PLAN
  http://s1.webmshare.com/Ry55q.webm (not uploaded to Phab due to file size 
limit)
  
  1. Remove Samba
  2. Go to share a folder
  3. Click "Install Samba"
  4. After the installation has completed, click the "Restart" button and see 
that the machine reboots
  
  5. Remove Samba again
  6. Go to share a folder
  7. Click "Install Samba"
  8. Close the window and re-open it instead of rebooting as recommended
  9. See that the Samba sharing config UI is all there

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  recommend-rebooting (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21466

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks, #dolphin, apol

D19785: DocumentPrivate: Review del/backspace

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:7e739920fd23: Dont delete entire previous line by 
backspace in pos 0 (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19785?vs=58682=58796#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19785?vs=58682=58796

REVISION DETAIL
  https://phabricator.kde.org/D19785

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Nathaniel Graham]

ngraham added a comment.


  No problem, thanks for checking in again!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D19785: DocumentPrivate: Review del/backspace

[Christoph Cullmann]

cullmann added a comment.


  I ATM have no access to my compile env. here, please commit the fix.
  It would be best to have some test for this, too, for future reference.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19785

To: loh.tar, #ktexteditor, cullmann
Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works perfectly and the code looks sensible!

INLINE COMMENTS

> meven wrote in kdiroperator.cpp:1955
> Well there are pretty much reusable already, their actions are available in 
> the actionCollection, although not documented.
> 
> But reusing kdiroperator in dolphin is another matter.
> The views here are simply based on existing kdiroperator views and most of 
> their bugs and features gaps with Dolphin remains.

Yeah, I'm afraid it isn't possible without putting KDirOperator back into 
Dolphin, which was removed on purpose many years ago. I like to see Dolphin 
once again use a re-usable component too, but that's outside the scope of this 
patch.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Nathaniel Graham]

ngraham added a comment.


  Nice! What do you think about moving the `if (configGroup && itemView) {` 
into the new function and calling it something more conditional, like 
`writeIconZoomSettingsIfNeeded`? Also it seems like there could be some code 
shared in a new function so that `KDirOperator::Private::iconSizeForViewType()` 
and `KDirOperator::Private::writeIconZoomSettings()` don't have to have so much 
duplicated code. They're both in the same scope so they have access to the same 
set of variables which should hopefully make it possible.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21401: Use native dialog overwrite check

[Nathaniel Graham]

ngraham added a comment.


  So nice!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21401

To: meven, ngraham, #frameworks, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D21441: Start krunner later

[Nathaniel Graham]

ngraham added a task: T10958: Faster Startup.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21441

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, kde-frameworks-devel, mart, jraleigh, GB_2, ragreen, Pitel, 
michaelh, ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D19785: DocumentPrivate: Review del/backspace

[loh tar]

loh.tar added a comment.


  That may fix it.
  
diff --git a/src/document/katedocument.cpp b/src/document/katedocument.cpp
index e365c380..7c24f67f 100644
--- a/src/document/katedocument.cpp
+++ b/src/document/katedocument.cpp
@@ -3350,7 +3350,9 @@ void 
KTextEditor::DocumentPrivate::backspace(KTextEditor::ViewPrivate *view, con
 
 } else {
 // col == 0: wrap to previous line
-if (line > 0) {
+const Kate::TextLine textLine = m_buffer->plainLine(line - 1);
+
+if (line > 0 && textLine) {
 if (config()->wordWrap() && textLine->endsWith(QLatin1String(" 
"))) {
 // gg: in hard wordwrap mode, backspace must also eat the 
trailing space
 removeText(KTextEditor::Range(line - 1, textLine->length() 
- 1, line, 0));

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19785

To: loh.tar, #ktexteditor, cullmann
Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19785: DocumentPrivate: Review del/backspace

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  See https://bugs.kde.org/show_bug.cgi?id=408016
  
  Guess this needs a revert, + some tests for that cases + a fix, thanks ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19785

To: loh.tar, #ktexteditor, cullmann
Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kdiroperator.cpp:1955
> Can we make them reusable, it should be in framework and then accessed in 
> Dolphin.

Well there are pretty much reusable already, their actions are available in the 
actionCollection, although not documented.

But reusing kdiroperator in dolphin is another matter.
The views here are simply based on existing kdiroperator views and most of 
their bugs and features gaps with Dolphin remains.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven updated this revision to Diff 58780.
meven added a comment.


  Removing parent commit

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21459?vs=58779=58780

BRANCH
  icon-save2

REVISION DETAIL
  https://phabricator.kde.org/D21459

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21440: Start baloo_file later

[Kai Uwe Broulik]

broulik added a comment.


  The idle tracking is only in the extractor process, not in baloo_file itself. 
On startup it runs the `UnindexedFileIndexer` and iterates all the folders 
looking for files to re-index, consuming a considerable amount of CPU time, 
spending most of its time doing regexp matching, mime type determination, and 
date time processing. Only after that it may run the extractor process when 
there's new files to be indexed.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven updated this revision to Diff 58779.
meven added a comment.


  Make the expanded detail view and the regular one share the same zoom setting

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21459?vs=58778=58779

BRANCH
  icon-save2

REVISION DETAIL
  https://phabricator.kde.org/D21459

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12378: Properly search for NetworkManager

[Rik Mills]

Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D12378

To: jgrulich, #frameworks
Cc: kde-frameworks-devel, rikmills, #frameworks, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a dependent revision: D21459: Always save view settings when 
switching from one view mode to another.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven added a dependency: D21315: Dolphin-style view modes in the file dialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  - Add zoom setings for each view kind
  - Save and restore zoom when view is changed

REPOSITORY
  R241 KIO

BRANCH
  icon-save2

REVISION DETAIL
  https://phabricator.kde.org/D21459

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> hallas wrote in fstabdevice.cpp:88
> This is what I have in mounts:
> 
>   fuseiso on /home/dha/mnt1 type fuse.fuseiso 
> (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)
> 
> so there just isn't a whole lot of information - we don't even have the iso 
> filename :/

By default fuseiso seems to maintain also a file "~/.mtab.fuseiso", there may 
be more information

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58776.
meven added a comment.


  Bad comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58775=58776

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58775.
meven added a comment.


  Remove icon zoom settings change this belong to another review

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58774=58775

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58774.
meven added a comment.


  Allow to save different zoom settings for all view kinds

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58642=58774

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21440: Start baloo_file later

[Stefan Brüns]

bruns added a comment.


  One possible reason for the idle tracking not working, IIRC it tries to 
connect to some service via DBus, don't know what happens if that is not 
available (yet).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21440: Start baloo_file later

[Stefan Brüns]

bruns added a comment.


  The reason to start baloo_file early is to be notified of all file changes. 
The extractor could be started later, and it has some mechanisms to throttle 
itself if the system isn't idle. If this isn't working as expected we have to 
fix it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21440: Start baloo_file later

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for your input. Yeah, I was mostly interested in having the file 
extractor wait some more. I'll poke the thing a bit then.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21315: Dolphin-style view modes in the file dialog

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kdiroperator.cpp:1955
>  
> +// View modes that match those of Dolphin
> +KToggleAction *iconsViewAction = new KToggleAction(i18n("Icons View"), 
> this);

Can we make them reusable, it should be in framework and then accessed in 
Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> batchrenametypes.cpp:98-106
> +QStringList firstCapturedGroups()
> +{
> +return capturedGroups;
> +}
> +
> +void clearCapturedGroups()
> +{

Make a class instead, free functions with global variable in, is no-go. It's 
totally miss of encapsulation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D21441: Start krunner later

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5bb4680bcffc: Start krunner later (authored by broulik).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21441?vs=58755=58756

REVISION DETAIL
  https://phabricator.kde.org/D21441

AFFECTED FILES
  krunner/krunner.desktop

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, kde-frameworks-devel, mart, jraleigh, GB_2, ragreen, Pitel, 
michaelh, ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D21441: Start krunner later

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21441

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, mart, michaelh, ngraham, bruns

D21441: Start krunner later

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  Ideally, KRunner were DBus-activated and launched the first time you hit the 
shortcut, or never if you just always used Meta and start menu search. @mart 
did something along the lines a while ago.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21441

AFFECTED FILES
  krunner/krunner.desktop

To: broulik, #plasma
Cc: kde-frameworks-devel, mart, michaelh, ngraham, bruns

D21440: Start baloo_file later

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: bruns, Baloo, davidedmundson.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We noticed that `baloo_file` starts quite early in the process and then kicks 
off `baloo_file_extractor` taking quite some CPU away from the important 
startup of `plasmashell` and others.
  I don't really see a reason why it would need to start this early but I could 
be wrong.

TEST PLAN
  Literally none.
  
  F6856249: Screenshot_20190528_113358.png 


REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

AFFECTED FILES
  src/file/baloo_file.desktop

To: broulik, bruns, #baloo, davidedmundson
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a reviewer: VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli added a comment.


  I'll need to rewrite the BatchRenameJob part which does the batch processing 
without breaking binary compatibility. Been unusually busy lately between job 
and uni but I'll start working on this sooner than later.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> bruns wrote in fstabhandling.cpp:142
> for NFS the following entries are valid:
> 
> - 192.168.0.1:/some/dir
> - 192.168.0.1:/some/dir/
> - server:/other
> - server:/
> 
> while `server:` (without slash) is invalid.
> 
> The first two entries are semantically the same

What is the udi of of a mounted nfs that has an umounted udi like: server:/ 
server:/other and server:/other/ ?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: ngraham, bruns, apol, kde-frameworks-devel, michaelh

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a comment.


  ANy

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58746.
mlaurent added a comment.


  Change as qlogging-categories5

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58604=58746

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent added a comment.


  Thanks david.
  Indeed qlogging-categories5 seems a good name :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21421: Tcsh: fix operators and keywords

[Christoph Cullmann]

cullmann added a comment.


  Actually the resource should be recreated on syntax file changes and be used.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21421

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann