D20193: Expose locked keystates on KModifierKeyInfo when on wayland

[Alexey Min]

alexeymin added inline comments.

INLINE COMMENTS

> dfaure wrote in kmodifierkeyinfoprovider.cpp:90
> Calling this an "abuse" is very arguable, see 
> https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/
> I'm not aware of a KF5 policy about this, so it's fine as is.

There is a Qt recommendation though: 
https://wiki.qt.io/Coding_Conventions#auto_Keyword

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol, romangg, dfaure
Cc: alexeymin, zzag, romangg, dfaure, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> zzag wrote in kmodifierkeyinfoprovider.cpp:90
> Abuse of `auto`.

Calling this an "abuse" is very arguable, see 
https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/
I'm not aware of a KF5 policy about this, so it's fine as is.

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol, romangg, dfaure
Cc: zzag, romangg, dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21959: Fix selectedNameFilter() multiple matches

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  fix_selectedNameFilter

REVISION DETAIL
  https://phabricator.kde.org/D21959

To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21940: Make automatic spellcheck work after reloading a document

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in ontheflycheck.cpp:75
>   In file included from /usr/include/qt5/QtCore/qalgorithms.h:43,
>from /usr/include/qt5/QtCore/qlist.h:43,
>from /usr/include/qt5/QtCore/QList:1,
>from 
> /home/ahmad/dev/ktexteditor/git/src/spellcheck/ontheflycheck.h:25,
>from 
> /home/ahmad/dev/ktexteditor/git/src/spellcheck/ontheflycheck.cpp:26:
>   /usr/include/qt5/QtCore/qobject.h: In instantiation of ‘static 
> QMetaObject::Connection QObject::connect(const typename 
> QtPrivate::FunctionPointer::Object*, Func1, const typename 
> QtPrivate::FunctionPointer::Object*, Func2, Qt::ConnectionType) [with 
> Func1 = void (KTextEditor::Document::*)(KTextEditor::Document*); Func2 = void 
> (KateOnTheFlyChecker::*)(const KTextEditor::Range&); typename 
> QtPrivate::FunctionPointer::Object = KTextEditor::Document; typename 
> QtPrivate::FunctionPointer::Object = KateOnTheFlyChecker]’:
>   /home/ahmad/dev/ktexteditor/git/src/spellcheck/ontheflycheck.cpp:76:58:   
> required from here
>   /usr/include/qt5/QtCore/qobject.h:241:9: error: static assertion failed: 
> Signal and slot arguments are not compatible.
> 241 | 
> Q_STATIC_ASSERT_X((QtPrivate::CheckCompatibleArguments SignalType::Arguments, typename SlotType::Arguments>::value),
> | ^

In that case, please use an anonymous lambda:

  [this](KTextEditor:: Document*){refreshSpellCheck ();}

That keeps the code closer together.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21940

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: dhaumann, sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, 
michaelh, ngraham, bruns, demsking, cullmann

D21861: Add default variables for variables interface

[Dominik Haumann]

dhaumann edited the summary of this revision.
dhaumann edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21861

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21861: Add default variables for variables interface

[Dominik Haumann]

dhaumann updated this revision to Diff 60393.
dhaumann added a comment.


  - Drop 'Current' prefix and improve documentation
  
  This should be good enough now, OK to commit?

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21861?vs=60384=60393

BRANCH
  add-default-variables

REVISION DETAIL
  https://phabricator.kde.org/D21861

AFFECTED FILES
  autotests/src/variable_test.cpp
  autotests/src/variable_test.h
  src/utils/kateglobal.cpp

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21907: Show feedback inline when creating new files or folders

[Dominik Haumann]

dhaumann added a comment.


  So it boils down to "let's try this and improve later if necessary" - well 
then :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf, meven
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Ben Cooksley]

bcooksley added a comment.


  Thanks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: bcooksley, maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21861: Add default variables for variables interface

[gregormi]

gregormi added a comment.


  In D21861#484556 , @dhaumann wrote:
  
  > I'd like to drop the " Current" prefix in all the variables. It just makes 
the names longer and I don't see any value for users. Comments?
  
  
  There is no other Document than the current one. I also don't come up with an 
idea where "Current" prefix makes things clearer. => Removal seems ok to me.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21861

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21861: Add default variables for variables interface

[Dominik Haumann]

dhaumann added a comment.


  I'd like to drop the " Current" prefix in all the variables. It just makes 
the names longer and I don't see any value for users. Comments?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21861

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21861: Add default variables for variables interface

[Dominik Haumann]

dhaumann updated this revision to Diff 60384.
dhaumann added a comment.


  - Implement JS: variable expansion, e.g. %{JS:3+%{JS:2+1}} --> 6
  - Variable expansion: Add unit tests

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21861?vs=59959=60384

BRANCH
  add-default-variables

REVISION DETAIL
  https://phabricator.kde.org/D21861

AFFECTED FILES
  autotests/src/variable_test.cpp
  autotests/src/variable_test.h
  src/utils/kateglobal.cpp

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg updated this revision to Diff 60366.
romangg added a comment.


  - Minor style changes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=60364=60366

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg updated this revision to Diff 60364.
romangg added a comment.


  - Revert drm_fourcc.h whitespace changes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=60360=60364

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D22003: Change selected text color to black

[Noah Davis]

ndavis edited the summary of this revision.
ndavis added a dependency: D22000: [colors/Breeze] Change selected text color 
to black.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D22003

To: ndavis, #vdg, #breeze, #plasma
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22003: Change selected text color to black

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Also make black text color match the Shade Black color:
  
  https://hig.kde.org/style/color/default.html
  
  Depends on  D21999 

REPOSITORY
  R265 KConfigWidgets

BRANCH
  selected-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22003

AFFECTED FILES
  src/kcolorscheme.cpp

To: ndavis, #vdg, #breeze, #plasma
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg updated this revision to Diff 60360.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=28986=60360

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg commandeered this revision.
romangg added a reviewer: fredrik.
romangg added a comment.


  Thanks @fredrik for initiating this. I'll try to finish the patches up.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D13150: Add ellipsis where appropriate

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham added a comment.


  In D21907#484197 , @dhaumann wrote:
  
  > These two points were not discussed anymore:
  
  
  I addressed them in https://phabricator.kde.org/D21907#482181:
  
  > 1. Isn't there a better solution by creating the folder and immediately 
select it + change to edit mode?
  
  Not really. The proposed behavior would need to be implemented in every 
single app rather than in KIO, because KIO doesn't know about the view that 
will hold the new file or folder that's being created. Even if we did do add 
view-specifric behavior to every app, then we would still have the problem here 
in KIO's new file/folder dialog, which is app- and view-agnostic. I think it's 
nicer to have it here in KIO, and have every app use the same component, rather 
than re-implement the same set of features in many places for different views.
  
  > 2. Resizing dialogs are usually not preferred.
  
  Yeah, I can understand this concern. In general I find that people get upset 
when the window or the window content changes when a KMessageWidget appears, 
which is a legitimate criticism. However this is a general problem with the 
KMessageWidget's visual design itself, not really with this specific patch. I 
would be in favor of making a "popover" version that shows the message in a 
little pop-up frame that doesn't resize the window or its content. GNOME and 
macOS do this and it's really quite nice.
  
  Of course someone would need to write that component. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf, meven
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.12 - Build # 60 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/60/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 22 Jun 2019 13:55:01 +
 Build duration:
1 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest

D21989: Don't show error message if sharing is cancelled by the user

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:a207a669815f: Dont show error message if sharing is 
cancelled by the user (authored by nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21989?vs=60321=60351

REVISION DETAIL
  https://phabricator.kde.org/D21989

AFFECTED FILES
  src/fileitemactionplugin/sharefileitemaction.cpp
  src/widgets/JobDialog.qml
  src/widgets/menu.h

To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21989: Don't show error message if sharing is cancelled by the user

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R495 Purpose Library

BRANCH
  noerror

REVISION DETAIL
  https://phabricator.kde.org/D21989

To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 60346.
nicolasfella added a comment.


  - fall back to name

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=60341=60346

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/alternativesmodel.cpp
  src/alternativesmodel.h
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D21907: Show feedback inline when creating new files or folders

[Dominik Haumann]

dhaumann added a comment.


  These two points were not discussed anymore:
  
  1. Isn't there a better solution by creating the folder and immediately 
select it + change to edit mode?
  2. Resizing dialogs are usually not preferred.
  
  If everyone else thinks this change is a good idea - then fine. I sm rather 
sceptical ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf, meven
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Alexander Potashev]

aspotashev added a comment.


  We probably need to fall back to "%1..." if X-Purpose-Action is not defined, 
which is possible for 3rd-party plugins.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 43 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/43/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Jun 2019 12:57:26 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.60.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModelFailed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)89%
(238/266)89%
(238/266)82%
(26102/31761)51%
(10389/20432)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)94%
(11814/12516)48%
(6202/13039)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client95%
(72/76)95%
(72/76)81%
(6027/7449)59%
(1672/2828)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server97%
(117/121)97%
(117/121)85%
(7807/9139)65%
(2338/3574)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/51/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 22 Jun 2019 12:57:26 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D13150: Add ellipsis where appropriate

[Nathaniel Graham]

ngraham added a comment.


  Looks like a couple of strings are now blank: F6923766: 
Screenshot_20190622_150439.png 

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella added a comment.


  This resolves the issue that the name with ellipsis shows up in the dialog 
title

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella requested review of this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella planned changes to this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 60341.
nicolasfella added a comment.


  Implement Alexander's suggestion

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=53551=60341

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/alternativesmodel.cpp
  src/alternativesmodel.h
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/50/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 22 Jun 2019 12:16:36 +
 Build duration:
6 min 42 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 137 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/137/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 22 Jun 2019 11:48:00 +
 Build duration:
33 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report61%
(22/36)64%
(259/402)64%
(259/402)53%
(32598/61156)38%
(16638/44036)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9400/9856)48%
(4326/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8348/14465)50%
(4650/9232)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4512/8223)41%
(1955/4767)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file0%
(0/7)0%
(0/7)0%
(0/1194)0%
(0/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1789/4291)36%
(1316/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D20526: Fix extracting of some properties to match what was written

[Alexander Stippich]

astippich retitled this revision from "fix extracting of some properties to 
match what was writen" to "Fix extracting of some properties to match what was 
written".
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: fix extracting of some properties to match what was writen

[Alexander Stippich]

astippich updated this revision to Diff 60334.
astippich added a comment.


  - remove usage of contactsFromString entirely

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20526?vs=56170=60334

BRANCH
  arcpatch-D20526

REVISION DETAIL
  https://phabricator.kde.org/D20526

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/extractors/taglibextractor.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: fix extracting of some properties to match what was writen

[Alexander Stippich]

astippich commandeered this revision.
astippich edited reviewers, added: mgallien; removed: astippich.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 127 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/127/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Jun 2019 11:48:00 +
 Build duration:
29 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/402)66%
(266/402)55%
(33385/61180)39%
(17048/44039)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9400/9856)48%
(4325/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8489/14478)51%
(4703/9235)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4510/8223)41%
(1953/4767)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(655/1206)39%
(371/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1789/4291)36%
(1316/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 137 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/137/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 22 Jun 2019 11:48:00 +
 Build duration:
7 min 49 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_kprotocolinfotestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D14467#483848 , @bcooksley 
wrote:
  
  > It would appear that the commit of this change disturbed somethng with 
FreeBSD builds - see 
https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/135/
  >
  > Could someone take a look into that please?
  
  
  https://commits.kde.org/kio/91901a64adcaab9e444bb67a75bebd2ea77c3db2 should 
fix this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: bcooksley, maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 136 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/136/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 22 Jun 2019 11:32:25 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 868 lines...][2019-06-22T11:44:48.811Z] Scanning dependencies of target httpauthenticationtest_autogen[2019-06-22T11:44:48.811Z] [ 24%] Automatic MOC for target httpauthenticationtest[2019-06-22T11:44:48.811Z] [ 24%] Built target kprotocolinfotest_autogen[2019-06-22T11:44:48.811Z] Scanning dependencies of target kcookiejartest_autogen[2019-06-22T11:44:48.811Z] [ 25%] Automatic MOC for target kcookiejartest[2019-06-22T11:44:49.068Z] [ 25%] Built target jobremotetest_autogen[2019-06-22T11:44:49.068Z] Scanning dependencies of target kio_file[2019-06-22T11:44:49.068Z] [ 25%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.o[2019-06-22T11:44:49.068Z] [ 25%] Built target ktcpsockettest_autogen[2019-06-22T11:44:49.068Z] [ 25%] Built target klocalsockettest_autogen[2019-06-22T11:44:49.068Z] [ 25%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o[2019-06-22T11:44:49.068Z] [ 25%] Built target jobtest_autogen[2019-06-22T11:44:49.068Z] [ 25%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o[2019-06-22T11:44:49.068Z] [ 25%] Built target kfileitemtest_autogen[2019-06-22T11:44:49.326Z] [ 26%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/fdreceiver.cpp.o[2019-06-22T11:44:49.326Z] Scanning dependencies of target file_helper[2019-06-22T11:44:49.326Z] [ 26%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/file_helper_autogen/mocs_compilation.cpp.o[2019-06-22T11:44:49.326Z] [ 26%] Built target listdirtest_autogen[2019-06-22T11:44:49.326Z] [ 26%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/legacycodec.cpp.o[2019-06-22T11:44:49.326Z] [ 26%] Built target httpauthenticationtest_autogen[2019-06-22T11:44:49.599Z] Scanning dependencies of target kio_ghelp[2019-06-22T11:44:49.599Z] [ 27%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.o[2019-06-22T11:44:49.599Z] [ 27%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_help.cpp.o[2019-06-22T11:44:49.599Z] [ 27%] Built target httpobjecttest_autogen[2019-06-22T11:44:49.599Z] Scanning dependencies of target kio_help[2019-06-22T11:44:49.599Z] [ 27%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_autogen/mocs_compilation.cpp.o[2019-06-22T11:44:49.858Z] [ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help.cpp.o[2019-06-22T11:44:49.858Z] [ 28%] Built target kcookiejartest_autogen[2019-06-22T11:44:49.858Z] Scanning dependencies of target kio_http_cache_cleaner[2019-06-22T11:44:49.858Z] [ 28%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http_cache_cleaner.dir/kio_http_cache_cleaner_autogen/mocs_compilation.cpp.o[2019-06-22T11:44:49.858Z] [ 28%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http_cache_cleaner.dir/http_cache_cleaner.cpp.o[2019-06-22T11:44:49.858Z] Scanning dependencies of target kio_http[2019-06-22T11:44:50.117Z] [ 28%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/kio_http_autogen/mocs_compilation.cpp.o[2019-06-22T11:44:50.117Z] [ 28%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/filehelper.cpp.o[2019-06-22T11:44:50.118Z] Scanning dependencies of target kio_ftp[2019-06-22T11:44:50.118Z] [ 28%] Building CXX object src/ioslaves/ftp/CMakeFiles/kio_ftp.dir/kio_ftp_autogen/mocs_compilation.cpp.o[2019-06-22T11:44:50.118Z] Scanning dependencies of target kio_trash[2019-06-22T11:44:50.118Z] [ 28%] Building CXX object src/ioslaves/trash/CMakeFiles/kio_trash.dir/kio_trash_autogen/mocs_compilation.cpp.o[2019-06-22T11:44:50.391Z] [ 28%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/fdsender.cpp.o[2019-06-22T11:44:50.650Z] [ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.o[2019-06-22T11:44:50.650Z] [ 28%] Linking CXX shared module ../../../bin/kf5/kio/file.so[2019-06-22T11:44:50.650Z] [ 28%] Built target kio_file[2019-06-22T11:44:50.650Z] [ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/main.cpp.o[2019-06-22T11:44:50.650Z] /usr/home/jenkins/workspace/Frameworks/kio/kf5-qt5 FreeBSDQt5.12/src/ioslaves/file/kauth/filehelper.cpp:68:25: warning: missing field 'st_ino' initializer [-Wmissing-field-initializers][2019-06-22T11:44:50.650Z] struct stat buf = {0};[2019-06-22T11:44:50.650Z] ^[2019-06-22T11:44:50.650Z] /usr/home/jenkins/workspace/Frameworks/kio/kf5-qt5 FreeBSDQt5.12/src/ioslaves/file/kauth/filehelper.cpp:135:59: error: use of undeclared identifier 'O_PATH'[2019-06-22T11:44:50.650Z] if ((parent_fd = open(parentDir.data(), O_DIRECTORY | O_PATH | 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 136 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/136/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 22 Jun 2019 11:32:25 +
 Build duration:
8 min 52 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report61%
(22/36)64%
(259/402)64%
(259/402)53%
(32618/61156)38%
(16640/44036)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9400/9856)48%
(4327/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8358/14465)50%
(4649/9232)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4512/8223)41%
(1955/4767)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file0%
(0/7)0%
(0/7)0%
(0/1194)0%
(0/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4291)36%
(1314/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 126 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/126/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Jun 2019 11:32:25 +
 Build duration:
7 min 23 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/402)66%
(266/402)55%
(33387/61180)39%
(17051/44039)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9400/9856)48%
(4325/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8489/14478)51%
(4709/9235)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4514/8223)41%
(1955/4767)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1206)39%
(370/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4291)36%
(1314/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4fb959b910bf: Show feedback inline when creating new 
files or folders (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21907?vs=60299=60329

REVISION DETAIL
  https://phabricator.kde.org/D21907

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #vdg, #frameworks, shubham, filipf, meven
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21986: RFC: Change initial size of the config dialog

[Nathaniel Graham]

ngraham added a comment.


  In D21986#484013 , @aacid wrote:
  
  > How hard is to make the size be related to the contents instead of a magic 
number?
  
  
  +1, this would probably involve basing the size on the `StackView`'s child 
items and bubbling that up to the top, rather than setting a hardcoded size at 
the top and making all the child items do `anchors.fill: parent`
  
  If that's ridiculously difficult due to other bugs though, this is a 
reasonable improvement as-is.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21986

To: nicolasfella, #vdg, apol, ngraham
Cc: aacid, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21989: Don't show error message if sharing is cancelled by the user

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  noerror

REVISION DETAIL
  https://phabricator.kde.org/D21989

To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:71cbb548e0ad: Proof of concept of a wayland protocol to 
allow the keystate dataengine to work (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20191?vs=55913=60325#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20191?vs=55913=60325

REVISION DETAIL
  https://phabricator.kde.org/D20191

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/keystate.cpp
  src/client/keystate.h
  src/client/protocols/keystate.xml
  src/client/registry.cpp
  src/client/registry.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/keystate_interface.cpp
  src/server/keystate_interface.h

To: apol, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21989: Don't show error message if sharing is cancelled by the user

[Nicolas Fella]

nicolasfella marked an inline comment as done.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21989

To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21989: Don't show error message if sharing is cancelled by the user

[Nicolas Fella]

nicolasfella updated this revision to Diff 60321.
nicolasfella added a comment.


  - use KIO::ERR_USER_CANCELED

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21989?vs=60317=60321

BRANCH
  noerror

REVISION DETAIL
  https://phabricator.kde.org/D21989

AFFECTED FILES
  src/fileitemactionplugin/sharefileitemaction.cpp
  src/widgets/JobDialog.qml
  src/widgets/menu.h

To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21986: RFC: Change initial size of the config dialog

[Albert Astals Cid]

aacid added a comment.


  How hard is to make the size be related to the contents instead of a magic 
number?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21986

To: nicolasfella, #vdg, apol, ngraham
Cc: aacid, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21989: Don't show error message if sharing is cancelled by the user

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> sharefileitemaction.cpp:55
> +// error == 0 means no error, error == 1 means cancelled by the user
> +if (error <= 1) {
>  if (output.contains(QLatin1String("url")))

If possible use `KIO::ERR_USER_CANCELED`, otherwise don't bother, comment's fine

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21989

To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21989: Don't show error message if sharing is cancelled by the user

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: apol, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Cancelling a share is usually intentional and should not result in a scary 
looking error message

TEST PLAN
  Cancel a share from Dolphin, don't get an error message any more

REPOSITORY
  R495 Purpose Library

BRANCH
  noerror

REVISION DETAIL
  https://phabricator.kde.org/D21989

AFFECTED FILES
  src/fileitemactionplugin/sharefileitemaction.cpp
  src/widgets/menu.h

To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/49/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 22 Jun 2019 10:26:26 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D21986: RFC: Change initial size of the config dialog

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21986

To: nicolasfella, #vdg, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21986: RFC: Change initial size of the config dialog

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: VDG, apol, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The dialog is larger than it needs to be

REPOSITORY
  R495 Purpose Library

BRANCH
  size

REVISION DETAIL
  https://phabricator.kde.org/D21986

AFFECTED FILES
  src/widgets/JobDialog.qml

To: nicolasfella, #vdg, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20443: Move to runtime the decision to use x11 or not

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R273:0fe2990dbad9: Move to runtime the decision to use x11 or 
not (authored by apol).

REPOSITORY
  R273 KGuiAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20443?vs=60135=60306

REVISION DETAIL
  https://phabricator.kde.org/D20443

AFFECTED FILES
  src/CMakeLists.txt
  src/util/kmodifierkeyinfo.cpp
  src/util/kmodifierkeyinfoprovider.cpp
  src/util/kmodifierkeyinfoprovider_dummy.cpp
  src/util/kmodifierkeyinfoprovider_p.h
  src/util/kmodifierkeyinfoprovider_x11.cpp
  src/util/kmodifierkeyinfoprovider_xcb.cpp
  src/util/kmodifierkeyinfoprovider_xcb.h

To: apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Re: KInit - Current state and benchmarks

[David Edmundson]

Benchmarks of dolphin on a low end ARM laptop:
 Dolphin via QProcess: 1233ms
 Dolphin via Kinit: 1144ms

again a consistent saving in the order of ~7%

Initially I had wanted to scrap it, I'm now very conflicted.

I'll try to port all of plasma services to use it properly again and
see what difference that makes across a broad context over a wider
range of services.

David

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R300:0ae8718ff331: Downgrade KDEWebKit from Tier 3 to Porting 
Aids (authored by vkrause).

REPOSITORY
  R300 KDEWebKit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21400?vs=58645=60303

REVISION DETAIL
  https://phabricator.kde.org/D21400

AFFECTED FILES
  metainfo.yaml

To: vkrause, apol, cullmann
Cc: cullmann, apol, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D20526: fix extracting of some properties to match what was writen

[Matthieu Gallien]

mgallien added a comment.


  In D20526#483910 , @astippich 
wrote:
  
  > @mgallien Are you going to update? There are bug reports which will also be 
fixed by this, so it would be nice to get this in.
  >  Or do you mind if I take over?
  
  
  I would like but I am quite busy with real life. If you feel like working on 
this, that would be really great.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21907: Show feedback inline when creating new files or folders

[Méven Car]

meven accepted this revision.
meven added a comment.


  This is look good to me !

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf, meven
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D20526: fix extracting of some properties to match what was writen

[Alexander Stippich]

astippich added a comment.


  @mgallien Are you going to update? There are bug reports which will also be 
fixed by this, so it would be nice to get this in.
  Or do you mind if I take over?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: fix extracting of some properties to match what was writen

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham marked 2 inline comments as done.

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> meven wrote in knewfilemenu.cpp:1099
> Shouldn't we disable the ok button here ?

No, because this isn't an error condition (it's just a warning).

> meven wrote in knewfilemenu.cpp:1122
> Same here

No, because this isn't an error condition (it's just a warning).

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham updated this revision to Diff 60299.
ngraham marked 4 inline comments as done.
ngraham added a comment.


  Disable Ok button for all error conditions (but not for warning conditions)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21907?vs=60137=60299

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 125 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/125/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Jun 2019 09:39:17 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/402)66%
(266/402)55%
(33371/61150)39%
(17058/44025)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9400/9856)48%
(4330/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8493/14478)51%
(4714/9235)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4488/8193)41%
(1952/4753)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1206)39%
(370/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4291)36%
(1314/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 124 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/124/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 21 Jun 2019 15:47:07 +
 Build duration:
17 hr and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestFailed: projectroot.autotests.kiocore_threadtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/402)66%
(265/402)55%
(33352/61151)39%
(17041/44025)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(56/57)98%
(56/57)95%
(9367/9855)47%
(4315/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8518/14480)51%
(4710/9235)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4488/8193)41%
(1952/4753)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1206)39%
(369/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1789/4291)36%
(1316/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

D14467: Auth Support: Drop privileges if target is not owned by root

[Ben Cooksley]

bcooksley added a comment.


  It would appear that the commit of this change disturbed somethng with 
FreeBSD builds - see 
https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/135/
  
  Could someone take a look into that please?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: bcooksley, maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 109 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/109/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 22 Jun 2019 09:30:05 +
 Build duration:
2 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltestFailed: projectroot.autotests.menutest

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 108 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/108/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 22 Jun 2019 09:25:41 +
 Build duration:
44 sec and counting
   CONSOLE OUTPUT
  [...truncated 187 lines...][2019-06-22T09:26:17.020Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-22T09:26:17.020Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-22T09:26:17.020Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-22T09:26:17.020Z] PROMPT= '$P$G'[2019-06-22T09:26:17.020Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-22T09:26:17.020Z] PUBLIC= 'C:\Users\Public'[2019-06-22T09:26:17.020Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/108/display/redirect?page=changes'[2019-06-22T09:26:17.020Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/108/display/redirect'[2019-06-22T09:26:17.020Z] STAGE_NAME= 'Configuring Build'[2019-06-22T09:26:17.020Z] SYSTEMDRIVE   = 'C:'[2019-06-22T09:26:17.020Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-22T09:26:17.020Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T09:26:17.020Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T09:26:17.020Z] UCRTVERSION   = '10.0.17763.0'[2019-06-22T09:26:17.020Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T09:26:17.020Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-22T09:26:17.020Z] USERNAME  = 'Jenkins'[2019-06-22T09:26:17.020Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-22T09:26:17.020Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-22T09:26:17.020Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-22T09:26:17.020Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-22T09:26:17.020Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-22T09:26:17.020Z] VCTOOLSVERSION= '14.16.27023'[2019-06-22T09:26:17.020Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-22T09:26:17.021Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-22T09:26:17.021Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-22T09:26:17.021Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-22T09:26:17.021Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-22T09:26:17.021Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-22T09:26:17.021Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-22T09:26:17.021Z] VSCMD_VER = '16.0.3'[2019-06-22T09:26:17.021Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-22T09:26:17.021Z] WINDIR= 'C:\WINDOWS'[2019-06-22T09:26:17.021Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-22T09:26:17.021Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-22T09:26:17.021Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T09:26:17.021Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-22T09:26:17.021Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-22T09:26:17.021Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-22T09:26:17.021Z] WORKSPACE = 'C:\CI\workspace\Frameworks\purpose\kf5-qt5 WindowsMSVCQt5.11'[2019-06-22T09:26:17.021Z] __DOTNET_ADD_64BIT= '1'[2019-06-22T09:26:17.021Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-22T09:26:17.021Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-22T09:26:17.021Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\purpose;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\dev-utils'[2019-06-22T09:26:17.021Z] QT_PLUGIN_PATH= 'C:\CI\Software 

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> kmodifierkeyinfo.cpp:34-44
> +#ifdef WITH_XCB
> +if (qGuiApp->platformName() == QLatin1String("xcb"))
> +return new KModifierKeyInfoProviderXcb;
> +else
> +#endif
> +#ifdef WITH_WAYLAND
> +if (qGuiApp->platformName() == QLatin1String("wayland"))

You don't need `else`s, e.g.

  static KModifierKeyInfoProvider *createProvider()
  {
  #ifdef WITH_XCB
  if (qGuiApp->platformName() == QLatin1String("xcb")) {
  return new KModifierKeyInfoProviderXcb;
  }
  #endif
  #ifdef WITH_WAYLAND
  if (qGuiApp->platformName() == QLatin1String("wayland")) {
  return new KModifierKeyInfoProviderWayland;
  }
  #endif
  return new KModifierKeyInfoProvider;
  }

> kmodifierkeyinfoprovider.cpp:90
> +{
> +auto  = m_modifierStates[key];
> +if (newState != state) {

Abuse of `auto`.

> kmodifierkeyinfoprovider.cpp:92
> +if (newState != state) {
> +const auto difference = (newState ^ state);
> +state = newState;

Same here.

> dfaure wrote in kmodifierkeyinfoprovider_wayland.cpp:36
> static

Needs to be a static function instead.

> kmodifierkeyinfoprovider_wayland.cpp:38-45
> +switch(state) {
> +case state_unlocked:
> +return KModifierKeyInfoProvider::Nothing;
> +case state_latched:
> +return KModifierKeyInfoProvider::Latched;
> +case state_locked:
> +return KModifierKeyInfoProvider::Locked;

https://techbase.kde.org/Policies/Frameworks_Coding_Style#Switch_Statements

> kmodifierkeyinfoprovider_wayland.h:29
>  {
> -}
> +Q_OBJECT
> +public:

Indent it.

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol, romangg, dfaure
Cc: zzag, romangg, dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 107 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/107/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 22 Jun 2019 09:22:59 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 187 lines...][2019-06-22T09:23:34.418Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-22T09:23:34.418Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-22T09:23:34.418Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-22T09:23:34.418Z] PROMPT= '$P$G'[2019-06-22T09:23:34.418Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-22T09:23:34.418Z] PUBLIC= 'C:\Users\Public'[2019-06-22T09:23:34.418Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/107/display/redirect?page=changes'[2019-06-22T09:23:34.418Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/107/display/redirect'[2019-06-22T09:23:34.418Z] STAGE_NAME= 'Configuring Build'[2019-06-22T09:23:34.418Z] SYSTEMDRIVE   = 'C:'[2019-06-22T09:23:34.418Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-22T09:23:34.418Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T09:23:34.418Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T09:23:34.418Z] UCRTVERSION   = '10.0.17763.0'[2019-06-22T09:23:34.418Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T09:23:34.418Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-22T09:23:34.418Z] USERNAME  = 'Jenkins'[2019-06-22T09:23:34.418Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-22T09:23:34.418Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-22T09:23:34.418Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-22T09:23:34.418Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-22T09:23:34.418Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-22T09:23:34.418Z] VCTOOLSVERSION= '14.16.27023'[2019-06-22T09:23:34.418Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-22T09:23:34.418Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-22T09:23:34.419Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-22T09:23:34.419Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-22T09:23:34.419Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-22T09:23:34.419Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-22T09:23:34.419Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-22T09:23:34.419Z] VSCMD_VER = '16.0.3'[2019-06-22T09:23:34.419Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-22T09:23:34.419Z] WINDIR= 'C:\WINDOWS'[2019-06-22T09:23:34.419Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-22T09:23:34.419Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-22T09:23:34.419Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T09:23:34.419Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-22T09:23:34.419Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-22T09:23:34.419Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-22T09:23:34.419Z] WORKSPACE = 'C:\CI\workspace\Frameworks\purpose\kf5-qt5 WindowsMSVCQt5.11'[2019-06-22T09:23:34.419Z] __DOTNET_ADD_64BIT= '1'[2019-06-22T09:23:34.419Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-22T09:23:34.419Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-22T09:23:34.419Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\purpose;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\dev-utils'[2019-06-22T09:23:34.419Z] QT_PLUGIN_PATH= 'C:\CI\Software 

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 106 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/106/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 22 Jun 2019 09:07:11 +
 Build duration:
4 min 33 sec and counting
   CONSOLE OUTPUT
  [...truncated 189 lines...][2019-06-22T09:11:36.292Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-22T09:11:36.292Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-22T09:11:36.292Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-22T09:11:36.292Z] PROMPT= '$P$G'[2019-06-22T09:11:36.292Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-22T09:11:36.292Z] PUBLIC= 'C:\Users\Public'[2019-06-22T09:11:36.292Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/106/display/redirect?page=changes'[2019-06-22T09:11:36.292Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/106/display/redirect'[2019-06-22T09:11:36.292Z] STAGE_NAME= 'Configuring Build'[2019-06-22T09:11:36.292Z] SYSTEMDRIVE   = 'C:'[2019-06-22T09:11:36.292Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-22T09:11:36.292Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T09:11:36.292Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T09:11:36.292Z] UCRTVERSION   = '10.0.17763.0'[2019-06-22T09:11:36.292Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T09:11:36.292Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-22T09:11:36.292Z] USERNAME  = 'Jenkins'[2019-06-22T09:11:36.292Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-22T09:11:36.292Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-22T09:11:36.292Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-22T09:11:36.292Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-22T09:11:36.292Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-22T09:11:36.292Z] VCTOOLSVERSION= '14.16.27023'[2019-06-22T09:11:36.292Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-22T09:11:36.292Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-22T09:11:36.292Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-22T09:11:36.292Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-22T09:11:36.292Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-22T09:11:36.292Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-22T09:11:36.292Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-22T09:11:36.292Z] VSCMD_VER = '16.0.3'[2019-06-22T09:11:36.292Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-22T09:11:36.292Z] WINDIR= 'C:\WINDOWS'[2019-06-22T09:11:36.292Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-22T09:11:36.292Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-22T09:11:36.292Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T09:11:36.292Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-22T09:11:36.292Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-22T09:11:36.292Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-22T09:11:36.292Z] WORKSPACE = 'C:\CI\workspace\Frameworks\purpose\kf5-qt5 WindowsMSVCQt5.11'[2019-06-22T09:11:36.292Z] __DOTNET_ADD_64BIT= '1'[2019-06-22T09:11:36.292Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-22T09:11:36.292Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-22T09:11:36.292Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\purpose;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\dev-utils'[2019-06-22T09:11:36.292Z] QT_PLUGIN_PATH= 'C:\CI\Software 

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 54 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/54/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Jun 2019 09:04:20 +
 Build duration:
3 min 0 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)21%
(461/2244)18%
(175/996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)58%
(58/100)src100%
(8/8)100%
(8/8)69%
(226/329)49%
(88/180)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
   

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 53 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/53/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Jun 2019 08:58:39 +
 Build duration:
5 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 236 lines...][2019-06-22T09:04:12.187Z] BUILD_NUMBER  = '53'[2019-06-22T09:04:12.187Z] _ = '/usr/bin/python3'[2019-06-22T09:04:12.187Z] XKEYSYMDB = '/usr/X11R6/lib/X11/XKeysymDB'[2019-06-22T09:04:12.187Z] BUILD_DISPLAY_NAME= '#53'[2019-06-22T09:04:12.187Z] XNLSPATH  = '/usr/X11R6/lib/X11/nls'[2019-06-22T09:04:12.187Z] HOME  = '/home/jenkins/'[2019-06-22T09:04:12.187Z] JENKINS_URL   = 'https://build.kde.org/'[2019-06-22T09:04:12.187Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.12'[2019-06-22T09:04:12.187Z] OSTYPE= 'linux'[2019-06-22T09:04:12.187Z] JOB_NAME  = 'Frameworks/purpose/kf5-qt5 SUSEQt5.12'[2019-06-22T09:04:12.187Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-06-22T09:04:12.187Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/53/display/redirect'[2019-06-22T09:04:12.187Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2019-06-22T09:04:12.187Z] WORKSPACE = '/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.12'[2019-06-22T09:04:12.187Z] HUDSON_URL= 'https://build.kde.org/'[2019-06-22T09:04:12.187Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-06-22T09:04:12.187Z] NODE_NAME = 'Docker Swarm-57d1f02f989e'[2019-06-22T09:04:12.187Z] HOST  = '57d1f02f989e'[2019-06-22T09:04:12.187Z] LESSOPEN  = 'lessopen.sh %s'[2019-06-22T09:04:12.187Z] USER  = 'jenkins'[2019-06-22T09:04:12.187Z] MORE  = '-sl'[2019-06-22T09:04:12.187Z] CSHEDIT   = 'emacs'[2019-06-22T09:04:12.187Z] SHLVL = '2'[2019-06-22T09:04:12.187Z] BUILD_TAG = 'jenkins-Frameworks-purpose-kf5-qt5 SUSEQt5.12-53'[2019-06-22T09:04:12.187Z] WINDOWMANAGER = 'xterm'[2019-06-22T09:04:12.187Z] PAGER = 'less'[2019-06-22T09:04:12.187Z] EXECUTOR_NUMBER   = '0'[2019-06-22T09:04:12.187Z] CVS_RSH   = 'ssh'[2019-06-22T09:04:12.187Z] LIBGL_DEBUG   = 'quiet'[2019-06-22T09:04:12.187Z] STAGE_NAME= 'Configuring Build'[2019-06-22T09:04:12.187Z] NODE_LABELS   = 'Docker Swarm-57d1f02f989e SUSEQt5.12'[2019-06-22T09:04:12.187Z] XCURSOR_THEME = 'DMZ-Black'[2019-06-22T09:04:12.187Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-06-22T09:04:12.187Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-06-22T09:04:12.187Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-06-22T09:04:12.187Z] PROFILEREAD   = 'true'[2019-06-22T09:04:12.187Z] MAIL  = '/var/mail/jenkins'[2019-06-22T09:04:12.187Z] HOSTTYPE  = 'x86_64'[2019-06-22T09:04:12.187Z] BUILD_ID  = '53'[2019-06-22T09:04:12.187Z] LESSKEY   = '/etc/lesskey.bin'[2019-06-22T09:04:12.187Z] OLDPWD= '/home/jenkins'[2019-06-22T09:04:12.187Z] LC_CTYPE  = 'C.UTF-8'[2019-06-22T09:04:12.187Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-06-22T09:04:12.187Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-06-22T09:04:12.187Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-06-22T09:04:12.187Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-06-22T09:04:12.187Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-06-22T09:04:12.187Z] QT_SELECT = 'qt5'[2019-06-22T09:04:12.187Z] LANG  = 'en_US.UTF-8'[2019-06-22T09:04:12.187Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-06-22T09:04:12.187Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-06-22T09:04:12.187Z] [2019-06-22T09:04:12.187Z] [2019-06-22T09:04:12.187Z] == Commencing Configuration:[2019-06-22T09:04:12.187Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.12"[2019-06-22T09:04:14.536Z] -- The C compiler identification is GNU 

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 59 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/59/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 22 Jun 2019 09:01:29 +
 Build duration:
1 min 53 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)21%
(461/2244)18%
(175/996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)58%
(58/100)src100%
(8/8)100%
(8/8)69%
(226/329)49%
(88/180)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
  

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 105 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/105/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 22 Jun 2019 09:01:30 +
 Build duration:
54 sec and counting
   CONSOLE OUTPUT
  [...truncated 187 lines...][2019-06-22T09:02:15.372Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-22T09:02:15.372Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-22T09:02:15.372Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-22T09:02:15.372Z] PROMPT= '$P$G'[2019-06-22T09:02:15.372Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-22T09:02:15.372Z] PUBLIC= 'C:\Users\Public'[2019-06-22T09:02:15.372Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/105/display/redirect?page=changes'[2019-06-22T09:02:15.372Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/105/display/redirect'[2019-06-22T09:02:15.372Z] STAGE_NAME= 'Configuring Build'[2019-06-22T09:02:15.372Z] SYSTEMDRIVE   = 'C:'[2019-06-22T09:02:15.372Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-22T09:02:15.372Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T09:02:15.372Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T09:02:15.372Z] UCRTVERSION   = '10.0.17763.0'[2019-06-22T09:02:15.372Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T09:02:15.372Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-22T09:02:15.372Z] USERNAME  = 'Jenkins'[2019-06-22T09:02:15.372Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-22T09:02:15.372Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-22T09:02:15.372Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-22T09:02:15.372Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-22T09:02:15.372Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-22T09:02:15.372Z] VCTOOLSVERSION= '14.16.27023'[2019-06-22T09:02:15.372Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-22T09:02:15.372Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-22T09:02:15.372Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-22T09:02:15.372Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-22T09:02:15.372Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-22T09:02:15.372Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-22T09:02:15.372Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-22T09:02:15.372Z] VSCMD_VER = '16.0.3'[2019-06-22T09:02:15.372Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-22T09:02:15.372Z] WINDIR= 'C:\WINDOWS'[2019-06-22T09:02:15.372Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-22T09:02:15.372Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-22T09:02:15.372Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T09:02:15.372Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-22T09:02:15.372Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-22T09:02:15.372Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-22T09:02:15.372Z] WORKSPACE = 'C:\CI\workspace\Frameworks\purpose\kf5-qt5 WindowsMSVCQt5.11'[2019-06-22T09:02:15.372Z] __DOTNET_ADD_64BIT= '1'[2019-06-22T09:02:15.372Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-22T09:02:15.372Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-22T09:02:15.372Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\purpose;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\dev-utils'[2019-06-22T09:02:15.372Z] QT_PLUGIN_PATH= 'C:\CI\Software 

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.12 - Build # 59 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/59/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 22 Jun 2019 09:01:29 +
 Build duration:
1 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 104 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/104/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 22 Jun 2019 08:58:39 +
 Build duration:
1 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 187 lines...][2019-06-22T08:59:34.925Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-22T08:59:34.925Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-22T08:59:34.925Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-22T08:59:34.925Z] PROMPT= '$P$G'[2019-06-22T08:59:34.925Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-22T08:59:34.925Z] PUBLIC= 'C:\Users\Public'[2019-06-22T08:59:34.925Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/104/display/redirect?page=changes'[2019-06-22T08:59:34.925Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/104/display/redirect'[2019-06-22T08:59:34.925Z] STAGE_NAME= 'Configuring Build'[2019-06-22T08:59:34.925Z] SYSTEMDRIVE   = 'C:'[2019-06-22T08:59:34.925Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-22T08:59:34.925Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T08:59:34.925Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-22T08:59:34.925Z] UCRTVERSION   = '10.0.17763.0'[2019-06-22T08:59:34.925Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T08:59:34.925Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-22T08:59:34.925Z] USERNAME  = 'Jenkins'[2019-06-22T08:59:34.925Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-22T08:59:34.925Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-22T08:59:34.925Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-22T08:59:34.925Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-22T08:59:34.925Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-22T08:59:34.925Z] VCTOOLSVERSION= '14.16.27023'[2019-06-22T08:59:34.925Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-22T08:59:34.925Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-22T08:59:34.925Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-22T08:59:34.925Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-22T08:59:34.925Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-22T08:59:34.925Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-22T08:59:34.925Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-22T08:59:34.925Z] VSCMD_VER = '16.0.3'[2019-06-22T08:59:34.925Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-22T08:59:34.925Z] WINDIR= 'C:\WINDOWS'[2019-06-22T08:59:34.925Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-22T08:59:34.925Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-22T08:59:34.925Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-22T08:59:34.925Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-22T08:59:34.925Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-22T08:59:34.925Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-22T08:59:34.925Z] WORKSPACE = 'C:\CI\workspace\Frameworks\purpose\kf5-qt5 WindowsMSVCQt5.11'[2019-06-22T08:59:34.925Z] __DOTNET_ADD_64BIT= '1'[2019-06-22T08:59:34.925Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-22T08:59:34.925Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-22T08:59:34.925Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\purpose;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\dev-utils'[2019-06-22T08:59:34.925Z] QT_PLUGIN_PATH= 'C:\CI\Software 

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 58 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/58/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 22 Jun 2019 08:58:39 +
 Build duration:
41 sec and counting
   CONSOLE OUTPUT
  [...truncated 236 lines...][2019-06-22T08:59:19.947Z] BUILD_NUMBER  = '58'[2019-06-22T08:59:19.947Z] _ = '/usr/bin/python3'[2019-06-22T08:59:19.947Z] XKEYSYMDB = '/usr/X11R6/lib/X11/XKeysymDB'[2019-06-22T08:59:19.947Z] BUILD_DISPLAY_NAME= '#58'[2019-06-22T08:59:19.947Z] XNLSPATH  = '/usr/X11R6/lib/X11/nls'[2019-06-22T08:59:19.947Z] HOME  = '/home/jenkins/'[2019-06-22T08:59:19.947Z] JENKINS_URL   = 'https://build.kde.org/'[2019-06-22T08:59:19.947Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.10'[2019-06-22T08:59:19.947Z] OSTYPE= 'linux'[2019-06-22T08:59:19.947Z] JOB_NAME  = 'Frameworks/purpose/kf5-qt5 SUSEQt5.10'[2019-06-22T08:59:19.947Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-06-22T08:59:19.947Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/58/display/redirect'[2019-06-22T08:59:19.947Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/display/redirect'[2019-06-22T08:59:19.947Z] WORKSPACE = '/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.10'[2019-06-22T08:59:19.947Z] HUDSON_URL= 'https://build.kde.org/'[2019-06-22T08:59:19.947Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-06-22T08:59:19.947Z] NODE_NAME = 'Docker Swarm-1fd6631344df'[2019-06-22T08:59:19.947Z] HOST  = '1fd6631344df'[2019-06-22T08:59:19.947Z] LESSOPEN  = 'lessopen.sh %s'[2019-06-22T08:59:19.947Z] USER  = 'jenkins'[2019-06-22T08:59:19.947Z] MORE  = '-sl'[2019-06-22T08:59:19.947Z] CSHEDIT   = 'emacs'[2019-06-22T08:59:19.947Z] SHLVL = '2'[2019-06-22T08:59:19.947Z] BUILD_TAG = 'jenkins-Frameworks-purpose-kf5-qt5 SUSEQt5.10-58'[2019-06-22T08:59:19.947Z] WINDOWMANAGER = 'xterm'[2019-06-22T08:59:19.947Z] PAGER = 'less'[2019-06-22T08:59:19.947Z] EXECUTOR_NUMBER   = '0'[2019-06-22T08:59:19.947Z] CVS_RSH   = 'ssh'[2019-06-22T08:59:19.947Z] LIBGL_DEBUG   = 'quiet'[2019-06-22T08:59:19.947Z] STAGE_NAME= 'Configuring Build'[2019-06-22T08:59:19.947Z] NODE_LABELS   = 'Docker Swarm-1fd6631344df SUSEQt5.10'[2019-06-22T08:59:19.947Z] XCURSOR_THEME = 'DMZ-Black'[2019-06-22T08:59:19.947Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-06-22T08:59:19.947Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-06-22T08:59:19.947Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-06-22T08:59:19.947Z] PROFILEREAD   = 'true'[2019-06-22T08:59:19.947Z] MAIL  = '/var/mail/jenkins'[2019-06-22T08:59:19.947Z] HOSTTYPE  = 'x86_64'[2019-06-22T08:59:19.947Z] BUILD_ID  = '58'[2019-06-22T08:59:19.947Z] LESSKEY   = '/etc/lesskey.bin'[2019-06-22T08:59:19.947Z] OLDPWD= '/home/jenkins'[2019-06-22T08:59:19.947Z] LC_CTYPE  = 'C.UTF-8'[2019-06-22T08:59:19.947Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-06-22T08:59:19.947Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-06-22T08:59:19.947Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-06-22T08:59:19.947Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-06-22T08:59:19.947Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-06-22T08:59:19.947Z] QT_SELECT = 'qt5'[2019-06-22T08:59:19.947Z] LANG  = 'en_US.UTF-8'[2019-06-22T08:59:19.947Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-06-22T08:59:19.947Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-06-22T08:59:19.947Z] [2019-06-22T08:59:19.947Z] [2019-06-22T08:59:19.947Z] == Commencing Configuration:[2019-06-22T08:59:19.947Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.10"[2019-06-22T08:59:19.947Z] -- The C compiler identification is GNU 

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.12 - Build # 58 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/58/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 22 Jun 2019 08:58:40 +
 Build duration:
1 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 169 lines...][Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[2019-06-22T08:59:41.214Z] + python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project purpose --branchGroup kf5-qt5 --platform FreeBSDQt5.12 --installTo /home/jenkins/install-prefix/[2019-06-22T08:59:41.215Z] == Using the following environment to perform the build:[2019-06-22T08:59:41.215Z] JOB_NAME  = 'Frameworks/purpose/kf5-qt5 FreeBSDQt5.12'[2019-06-22T08:59:41.215Z] BUILD_NUMBER  = '58'[2019-06-22T08:59:41.215Z] LOGNAME   = 'jenkins'[2019-06-22T08:59:41.215Z] LANG  = 'en_US.UTF-8'[2019-06-22T08:59:41.215Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2019-06-22T08:59:41.215Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/display/redirect'[2019-06-22T08:59:41.215Z] MAIL  = '/var/mail/jenkins'[2019-06-22T08:59:41.215Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/58/display/redirect?page=changes'[2019-06-22T08:59:41.215Z] JENKINS_URL   = 'https://build.kde.org/'[2019-06-22T08:59:41.215Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-06-22T08:59:41.215Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.12'[2019-06-22T08:59:41.215Z] HUDSON_HOME   = '/home/production/data'[2019-06-22T08:59:41.215Z] BUILD_ID  = '58'[2019-06-22T08:59:41.215Z] OLDPWD= '/usr/home/jenkins'[2019-06-22T08:59:41.215Z] PWD   = '/usr/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 FreeBSDQt5.12'[2019-06-22T08:59:41.215Z] _ = '/usr/local/bin/java'[2019-06-22T08:59:41.215Z] TERM  = 'su'[2019-06-22T08:59:41.215Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.12'[2019-06-22T08:59:41.215Z] BUILD_TAG = 'jenkins-Frameworks-purpose-kf5-qt5 FreeBSDQt5.12-58'[2019-06-22T08:59:41.215Z] BUILD_DISPLAY_NAME= '#58'[2019-06-22T08:59:41.215Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/58/display/redirect'[2019-06-22T08:59:41.215Z] USER  = 'jenkins'[2019-06-22T08:59:41.215Z] HOME  = '/home/jenkins'[2019-06-22T08:59:41.215Z] BUILD_URL = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/58/'[2019-06-22T08:59:41.215Z] JOB_URL   = 'https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/'[2019-06-22T08:59:41.215Z] HUDSON_URL= 'https://build.kde.org/'[2019-06-22T08:59:41.215Z] SHELL = '/usr/local/bin/bash'[2019-06-22T08:59:41.215Z] WORKSPACE = '/usr/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 FreeBSDQt5.12'[2019-06-22T08:59:41.215Z] MM_CHARSET= 'UTF-8'[2019-06-22T08:59:41.215Z] STAGE_NAME= 'Configuring Build'[2019-06-22T08:59:41.215Z] NODE_NAME = 'FreeBSD Builder 1'[2019-06-22T08:59:41.215Z] BLOCKSIZE = 'K'[2019-06-22T08:59:41.215Z] EXECUTOR_NUMBER   = '0'[2019-06-22T08:59:41.215Z] SHLVL = '0'[2019-06-22T08:59:41.215Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-06-22T08:59:41.215Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-06-22T08:59:41.215Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-06-22T08:59:41.215Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-06-22T08:59:41.215Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-06-22T08:59:41.215Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-06-22T08:59:41.215Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-06-22T08:59:41.215Z] QT_SELECT = 'qt5'[2019-06-22T08:59:41.215Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-06-22T08:59:41.215Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-06-22T08:59:41.215Z] [2019-06-22T08:59:41.215Z] [2019-06-22T08:59:41.215Z] == Commencing Configuration:[2019-06-22T08:59:41.215Z] cmake 

D21967: Fix warning when reading plugin metadata

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:3d3af03052d0: Fix warning when reading plugin metadata 
(authored by nicolasfella, committed by aacid).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21967?vs=60248=60288

REVISION DETAIL
  https://phabricator.kde.org/D21967

AFFECTED FILES
  src/alternativesmodel.cpp

To: nicolasfella, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> knewfilemenu.cpp:1099
> +m_messageWidget->setMessageType(KMessageWidget::Information);
> +m_messageWidget->animatedShow();
> +}

Shouldn't we disable the ok button here ?

> knewfilemenu.cpp:1109
> +m_messageWidget->setMessageType(KMessageWidget::Error);
> +m_messageWidget->animatedShow();
> +}

Shouldn't we disable the ok button here too ?

> knewfilemenu.cpp:1114
> +m_messageWidget->setMessageType(KMessageWidget::Error);
> +m_messageWidget->animatedShow();
> +}

Same here

> knewfilemenu.cpp:1122
> +m_messageWidget->setMessageType(KMessageWidget::Warning);
> +m_messageWidget->animatedShow();
> +}

Same here

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21959: Fix selectedNameFilter() multiple matches

[Robert Hoffmann]

hoffmannrobert marked an inline comment as done.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D21959

To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21959: Fix selectedNameFilter() multiple matches

[Robert Hoffmann]

hoffmannrobert updated this revision to Diff 60286.
hoffmannrobert added a comment.


  - Remove redundant condition

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21959?vs=60217=60286

BRANCH
  fix_selectedNameFilter

REVISION DETAIL
  https://phabricator.kde.org/D21959

AFFECTED FILES
  autotests/kfiledialog_unittest.cpp
  src/platformtheme/kdeplatformfiledialogbase_p.h
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  src/platformtheme/kdeplatformfiledialoghelper.h
  src/platformtheme/kdirselectdialog.cpp
  src/platformtheme/kdirselectdialog_p.h

To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham added a comment.


  If there are no formal objections, I'd like to land this.

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21959: Fix selectedNameFilter() multiple matches

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D21959

To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.

INLINE COMMENTS

> slavebase.cpp:1511
> +KIO_DATA << d->m_warningCaption << d->m_warningMessage << 
> privilegeOperationDetails;
> +send(INF_PRIVILEGE_CONF, data);
> +if (waitForAnswer(INF_PRIVILEGE_CONF, 0, data) != -1) {

INF is for one-way information, isn't it? Why isn't this MSG_ like the one 
above?

> slavebase.h:964
>  
> +QString privilegeOperationDetails;
> +

Missing "m" prefix like the other members, but wait isn't this BIC? Adding 
a new member to an exported class certainly is. This needs to go into the 
SlaveBasePrivate class instead.

> file_unix.cpp:85
> +switch(actionType) {
> +case CHMOD: {
> +action = i18n("Change File Permissions");

all those { ... } braces are unnecessary in this switch, which doesn't define 
any new variables

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21882: RFC: [CopyJob] Batch reporting processed amount

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  OK in principle, but it might be that a setProcessedAmount(Bytes, totalSize) 
is missing at the end of the last file, so we don't end up with a progress 
dialog that looks like things are 99% done. Whether it's a real issue or not 
depends on the progress dialog implementation, but this code shouldn't make 
assumptions on that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21882

To: broulik, #frameworks, dfaure, chinmoyr, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21959: Fix selectedNameFilter() multiple matches

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  +1 for the included unittest.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:80
>   */
> -static QString kde2QtFilter(const QStringList , const QString )
> +static QString kde2QtFilter(const QStringList , const QString , 
> const QString )
>  {

(hehe I keep thinking this is about KDE-2 stuff... what a dinosaur I am)

> kdeplatformfiledialoghelper.cpp:90
> +(QLatin1Char(')') == (*it)[pos + kde.length()] || 
> QLatin1Char(' ') == (*it)[pos + kde.length()]) &&
> +(filterText.isEmpty() || (!filterText.isEmpty() && 
> it->startsWith(filterText {
>  return *it;

the `!filterText.isEmpty() &&` part is redundant.
In this part of the condition, we know it's not empty, otherwise shortcut 
evaluation happened after isEmpty returns true.

  blue or (not blue and green)

is really the same as

  blue or green

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D21959

To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> keystate.xml:22
> +  
> +xxx
> +  

Interesting description. Does the number of 'x' mean anything? ;)

> kmodifierkeyinfoprovider_wayland.cpp:36
> +
> +KModifierKeyInfoProvider::ModifierState toState(state state)
> +{

static

> kmodifierkeyinfoprovider_wayland.cpp:50
> +
> +Qt::Key toKey(key key)
> +{

static

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol, romangg, dfaure
Cc: romangg, dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns