D22387: Allow KAutostart to be constructed using an absolute path
This revision was automatically updated to reflect the committed changes. Closed by commit R309:93107a9532e9: Allow KAutostart to be constructed using an absolute path (authored by apol). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22387?vs=61535=61559 REVISION DETAIL https://phabricator.kde.org/D22387 AFFECTED FILES src/services/kautostart.cpp src/services/kautostart.h To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22387: Allow KAutostart to be constructed using an absolute path
apol added a dependent revision: D22390: ksmserver/autostart: remove qstandardpaths queries. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22387 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 11 Jul 2019 02:17:05 + Build duration: 2 min 19 sec and counting JUnit Tests Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
D7820: man ioslave: spurious numbers included in clang(1) man page
ltoscano added a comment. Apologize for the long delay - I can't reproduce the issue with the current master. The mentioned structure of the clang man page seems to be the same (clang 8). Adding @mkoller too. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7820 To: marten, #plasma, kfm-devel, mkoller Cc: ltoscano, kde-frameworks-devel, plasma-devel, fprice, LeGast00n, jraleigh, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, spoorun, navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, himcesjf, emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, apol, mart
D7820: man ioslave: spurious numbers included in clang(1) man page
ltoscano added a reviewer: mkoller. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7820 To: marten, #plasma, kfm-devel, mkoller Cc: kde-frameworks-devel, plasma-devel, fprice, LeGast00n, jraleigh, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, spoorun, navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, himcesjf, emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, apol, mart
D9033: man ioslave: asserts trying to display pam(8)
ltoscano added a comment. Apologize for the long delay. It looks like that the fix still applies and works according the comment. I added @mkoller, the historical maintainer of kio-man, who can probably validate the change better than me, but let's try to push this for the upcoming KDE Applications 19.04. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma, kfm-devel, mkoller Cc: ltoscano, kde-frameworks-devel, apol, plasma-devel, fprice, LeGast00n, jraleigh, gennad, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, spoorun, navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, skadinna, himcesjf, emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, mart
D9033: man ioslave: asserts trying to display pam(8)
ltoscano added a reviewer: mkoller. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma, kfm-devel, mkoller Cc: kde-frameworks-devel, apol, plasma-devel, fprice, LeGast00n, jraleigh, gennad, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, spoorun, navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, skadinna, himcesjf, emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, mart
D22387: Allow KAutostart to be constructed using an absolute path
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22387 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D21760: Add KListOpenFiles::listProcessesWithOpenFiles
ngraham added reviewers: bruns, Plasma. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22387: Allow KAutostart to be constructed using an absolute path
apol retitled this revision from "Allow the instance to be constructed using an absolute path" to "Allow KAutostart to be constructed using an absolute path". REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D22387 To: apol, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
kossebau added inline comments. INLINE COMMENTS > kbusyindicatorwidget.h:40 > + * is more specific. > + */ > +class KWIDGETSADDONS_EXPORT KBusyIndicatorWidget : public QWidget Any chance of getting some samples how this class is supposed to be used? Sounds one should show & hide the complete widget when needed? How to best integrate in one's layout? As overlay? BTW, the KDE HIG does not mention such a spinner. So the purpose from a KDE developer following the HIG raises a question with me wearing my naive hat :) https://hig.kde.org/components/assistance/progress.html > kbusyindicatorwidget.h:57-58 > +private: > +class Private; > +Private *const d; > +}; You can make this a non-nested class by implcitly forward declaring here: class KBusyIndicatorWidgetPrivate *const d; This allows not needing the Q_DECL_HIDDEN for the symbols of the then no longe nested private class. Even more fancy: QScopedPointer const d; No longer the need to delete the d explicitely :) Though perhaps not familiar in look of cod too many. > kbusyindicatorwidgettest.cpp:31 > +w.setBaseSize(128, 128); > +w.show(); > + Could this test be somehow extended to cover repeated show & hide? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck Cc: kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22387: Allow the instance to be constructed using an absolute path
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY If we already have found the service we need to autostart, it's a waste to strip the full path to have it located again. TEST PLAN tests still pass, works with my plasma-workspace patch REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22387 AFFECTED FILES src/services/kautostart.cpp src/services/kautostart.h To: apol, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D21760: Add KListOpenFiles::listProcessesWithOpenFiles
cfeck resigned from this revision. cfeck added a comment. You wrote "ported from Device Notifier". I haven't check in detail yet, but do other copyright holders need to be mentioned? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 7 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/7/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 10 Jul 2019 17:27:29 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report33% (6/18)36% (45/126)36% (45/126)27% (3629/13386)18% (1823/9896)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests86% (12/14)86% (12/14)55% (612/1119)29% (315/1090)src.declarativeimports.calendar0% (0/6)0% (0/6)0% (0/471)0% (0/243)src.declarativeimports.core31% (5/16)31% (5/16)14% (314/2281)6% (92/1479)src.declarativeimports.plasmacomponents0% (0/6)0% (0/6)0% (0/518)0% (0/207)src.declarativeimports.plasmaextracomponents0% (0/3)0% (0/3)0% (0/42)0% (0/22)src.declarativeimports.platformcomponents0% (0/3)0% (0/3)0% (0/58)0% (0/14)src.declarativeimports.platformcomponents.utils0% (0/2)0% (0/2)0% (0/14)0% (0/2)src.plasma64% (14/22)64% (14/22)41% (1419/3490)28% (794/2841)src.plasma.packagestructure0% (0/7)0% (0/7)0% (0/134)0% (0/12)src.plasma.private50% (9/18)50% (9/18)43% (679/1580)29% (301/1048)src.plasma.scripting0% (0/3)0% (0/3)0% (0/171)0% (0/113)src.plasmapkg0% (0/1)0% (0/1)0% (0/45)0% (0/40)src.plasmaquick33% (4/12)33% (4/12)28% (574/2019)18% (316/1727)src.plasmaquick.private50% (1/2)50% (1/2)29% (31/106)36% (5/14)src.scriptengines.qml.plasmoid0% (0/6)0% (0/6)0% (0/1183)0%
KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 130 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/130/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Jul 2019 17:27:30 + Build duration: 7 min 57 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report33% (6/18)36% (45/126)36% (45/126)27% (3633/13387)18% (1824/9896)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests86% (12/14)86% (12/14)55% (612/1119)29% (315/1090)src.declarativeimports.calendar0% (0/6)0% (0/6)0% (0/471)0% (0/243)src.declarativeimports.core31% (5/16)31% (5/16)14% (314/2281)6% (92/1479)src.declarativeimports.plasmacomponents0% (0/6)0% (0/6)0% (0/518)0% (0/207)src.declarativeimports.plasmaextracomponents0% (0/3)0% (0/3)0% (0/42)0% (0/22)src.declarativeimports.platformcomponents0% (0/3)0% (0/3)0% (0/58)0% (0/14)src.declarativeimports.platformcomponents.utils0% (0/2)0% (0/2)0% (0/14)0% (0/2)src.plasma64% (14/22)64% (14/22)41% (1419/3490)28% (794/2841)src.plasma.packagestructure0% (0/7)0% (0/7)0% (0/134)0% (0/12)src.plasma.private50% (9/18)50% (9/18)43% (679/1580)29% (301/1048)src.plasma.scripting0% (0/3)0% (0/3)0% (0/171)0% (0/113)src.plasmapkg0% (0/1)0% (0/1)0% (0/45)0% (0/40)src.plasmaquick33% (4/12)33% (4/12)29% (578/2020)18% (317/1727)src.plasmaquick.private50% (1/2)50% (1/2)29% (31/106)36% (5/14)src.scriptengines.qml.plasmoid0% (0/6)0% (0/6)0% (0/1183)0%
KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/3/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 10 Jul 2019 17:27:29 + Build duration: 4 min 7 sec and counting JUnit Tests Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)
JJRcop added a comment. After some quick research I should have done a while ago, I have determined that KFormat is not nearly the same as what KUnitConversion does. KFormat can take an input number and output a string with the input formatted properly to the desired unit. KUnitConversion defines objects for various units with functions to convert between them. You can instantiate these objects using a number and unit type. There are a few objects, some defining the Unit itself, and some defining an instance of a Value in a certain Unit. Both of these objects have methods to convert an input into another Unit, which return either an output number or Value object in the new Unit. I am not able to use KFormat because KFormat takes an input number and only outputs a formatted string. This is exactly what it's designed for and doesn't need any changes, but is just not compatible with what KUnitConversion does as it handles numbers. https://api.kde.org/frameworks/kunitconversion/html/index.html https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html I believe no further changes are required for this patch. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)
JJRcop updated this revision to Diff 61526. JJRcop added a comment. Update version number to 5.60 REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20181?vs=59308=61526 REVISION DETAIL https://phabricator.kde.org/D20181 AFFECTED FILES README.md src/CMakeLists.txt src/binary_data.cpp src/binary_data_p.h src/converter.cpp src/unit.h To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
D22362: Port keystates to use QtWayland's generator
davidedmundson added a comment. As some background: At a recent Plasma sprint, one comment was that adding protocols to KWayland was an absolute pain involving writing a tonne of boiler plate. My experience adding a protocol to Qt was relatively painless. We said we'd try on a really simple protocol. IMHO this looks encouraging. Obviously having a mix of styles isn't great, but something has to be first. One thing we need to resolve is QtWaylandServer::org_kde_kwin_keystate will call init which will call wl_global_create Global::Private will call wl_global_create Calling that twice is wrong. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22362 To: apol, #kwin Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
sitter updated this revision to Diff 61522. sitter marked 14 inline comments as done. sitter added a comment. - running property gone since we have no use case + simplified code since we no longer account for it - dropped superfluous virtual keywords - bumped duration to 1.5s - moved to qvariantanimation + alloc animation on stack - now has minimumsizehint based on PM_SmallIconSize I am actually not sure about what needs overriding for best sizehiniting, I figure minimumsizehint is the bare minimum? Should we also set a sizehint? REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22375?vs=61506=61522 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22375 AFFECTED FILES src/CMakeLists.txt src/kbusyindicatorwidget.cpp src/kbusyindicatorwidget.h tests/CMakeLists.txt tests/kbusyindicatorwidgettest.cpp To: sitter, cfeck Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22235: PoC: asynchronous initialization of Solid::UDisks backend
apol abandoned this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22235 To: apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
cfeck added inline comments. INLINE COMMENTS > sitter wrote in kbusyindicatorwidget.h:48 > Mimics the QML API, haven't given it any thought TBH. You can have the > spinner visible but paused, I am not sure why exactly you'd want a paused > spinner but that's what the property does anyway. > > i.e. > > - you can have a visible but !running spinner which would simply be the > spinner at whatever the last rotation update was. > - a visibile and running spinner = animation > - a running but !visible spinner = effectively noop > > That said, **I** have no use case for it so we can remove it for the time > being if you'd prefer. Please remove it unless you find a justification. I don't like its name either (the widget isn't running). > kbusyindicatorwidget.h:72 > +class Private; > +Private *d; > +}; `*const d` REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
sitter added inline comments. INLINE COMMENTS > broulik wrote in kbusyindicatorwidget.cpp:111 > How about `PM_LargeIconSize` Oh, that would work! > cfeck wrote in kbusyindicatorwidget.h:48 > Why is this property needed? If the (parent) widget is no longer busy, this > spinner needs to be hidden anyway. Mimics the QML API, haven't given it any thought TBH. You can have the spinner visible but paused, I am not sure why exactly you'd want a paused spinner but that's what the property does anyway. i.e. - you can have a visible but !running spinner which would simply be the spinner at whatever the last rotation update was. - a visibile and running spinner = animation - a running but !visible spinner = effectively noop That said, **I** have no use case for it so we can remove it for the time being if you'd prefer. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
cfeck added inline comments. INLINE COMMENTS > kbusyindicatorwidget.h:48 > + */ > +Q_PROPERTY(bool running READ running WRITE setRunning NOTIFY > runningChanged) > +public: Why is this property needed? If the (parent) widget is no longer busy, this spinner needs to be hidden anyway. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
cfeck added a comment. Ideally you can create it with any size as an overlay to an existing widgets (also to block input there), but the spinner itself is only rendered at a smaller centered position. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
broulik added inline comments. INLINE COMMENTS > sitter wrote in kbusyindicatorwidget.cpp:111 > I was thinking about it, and honestly I am not sure. I don't think we have > access to anything to do with icon units, so we could hardcode some > dimensions (22,22 I guess) but that's about it. How about `PM_LargeIconSize` REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
sitter added inline comments. INLINE COMMENTS > broulik wrote in kbusyindicatorwidget.cpp:111 > Does this widget need a `sizeHint` of a button or default icon size or > something? I was thinking about it, and honestly I am not sure. I don't think we have access to anything to do with icon units, so we could hardcode some dimensions (22,22 I guess) but that's about it. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
broulik added a comment.
Cool!
INLINE COMMENTS
> kbusyindicatorwidget.cpp:28
> +
> +class KBusyIndicatorWidget::Private : public QObject
> +{
`Q_DECL_HIDDEN`
> kbusyindicatorwidget.cpp:31
> +Q_OBJECT
> +Q_PROPERTY(qreal rotation MEMBER rotation WRITE setRotation)
> +public:
You probably want to be using `QVariantAnimation` instead of going through the
property system for that. Then your private also probably doesn't need to be a
`QObject`
> kbusyindicatorwidget.cpp:38
> +animation->setLoopCount(-1);
> +animation->setDuration(1000);
> +animation->setStartValue(0);
Plasma's `BusyIndicator` uses 1500ms
> kbusyindicatorwidget.cpp:62
> +QPropertyAnimation *animation = nullptr;
> +QIcon icon = QIcon::fromTheme(QStringLiteral("view-refresh"));
> +qreal rotation = 0;
Is that legal in the C++ standard allowed by frameworks?
> kbusyindicatorwidget.cpp:103
> +{
> +d->maybeToggleAnimation();
> +QWidget::hideEvent(event);
is `q->isVisible()` checked in this method already updated at this point or
should the `hideEvent` be processed before? Likewise for `showEvent`
> kbusyindicatorwidget.cpp:111
> +
> +d->paintCenter = QPointF(event->size().width() / 2.0,
> + event->size().height() / 2.0);
Does this widget need a `sizeHint` of a button or default icon size or
something?
> kbusyindicatorwidget.h:51
> +explicit KBusyIndicatorWidget(QWidget *parent = nullptr);
> +virtual ~KBusyIndicatorWidget();
> +
`override` instead
> kbusyindicatorwidget.h:65
> +protected:
> +virtual void showEvent(QShowEvent *event) override;
> +virtual void hideEvent(QHideEvent *event) override;
`override` is enough
> kbusyindicatorwidget.h:65
> +protected:
> +virtual void showEvent(QShowEvent *event) override;
> +virtual void hideEvent(QHideEvent *event) override;
I heard for good measure one should always re-implement the generic `event`
just in case
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D22375
To: sitter, cfeck
Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator
sitter created this revision. sitter added a reviewer: cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this mimics QQC's BusyIndicator and more specifically our styling of it. KBIW loads an icon from the icon theme, scales it to the widget size and rotates it 360 degrees every second for as long as it is running. the intent here is to give an easy to use spinner implementation that looks like and feels (to the developer) like the one seen in plasma/kirigami. this does however somewhat infringe on the business of kpixmapsequence, so here's why KBIW is better for this specific use case: - not pixmap based - because it's not pixmap based scaling works much better for SVGs - since we paint a QIcon directly we don't have to manually faff about with pixmap copies/segments - more robust as themes may incorrectly or not at all implement the animation icon spec (which is rather offhandedly specified really). KBIW takes care of the animation so the theme need only supply a very standard icon and there is no change for things to go wrong more or less - because this fully leverages QIcon/KIconThemes we get full advantage of SVG coloring. i.e. when using a dark theme the icon is correctly using a contrasting color - users of KBIW no longer need to explicitly use KIconLoader to resolve a pixmap path TEST PLAN widget works. not sure an autotest is worth here, there's not much to assert. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22375 AFFECTED FILES src/CMakeLists.txt src/kbusyindicatorwidget.cpp src/kbusyindicatorwidget.h tests/CMakeLists.txt tests/kbusyindicatorwidgettest.cpp To: sitter, cfeck Cc: kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
D22370: Simplify previous-/nextActivity code in kactivities-cli
This revision was automatically updated to reflect the committed changes. Closed by commit R6:c450f09e8921: Simplify previous-/nextActivity code in kactivities-cli (authored by muesli). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22370?vs=61499=61502 REVISION DETAIL https://phabricator.kde.org/D22370 AFFECTED FILES src/cli/main.cpp To: muesli, ivan, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)
leinir updated this revision to Diff 61500. leinir added a comment. - Add a downloaditemssheet to the entry details page REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=61341=61500 BRANCH knsquick-feature-parity-with-kns (branched from master) REVISION DETAIL https://phabricator.kde.org/D21721 AFFECTED FILES src/attica/atticaprovider.cpp src/attica/atticaprovider_p.h src/core/CMakeLists.txt src/core/author.cpp src/core/author.h src/core/commentsmodel.cpp src/core/commentsmodel.h src/core/engine.cpp src/core/engine.h src/core/entryinternal.cpp src/core/installation.cpp src/core/itemsmodel.cpp src/core/itemsmodel.h src/core/provider.h src/core/question.h src/qtquick/CMakeLists.txt src/qtquick/author.cpp src/qtquick/author.h src/qtquick/categoriesmodel.cpp src/qtquick/categoriesmodel.h src/qtquick/qml/ConditionalLoader.qml src/qtquick/qml/EntryCommentDelegate.qml src/qtquick/qml/EntryCommentsPage.qml src/qtquick/qml/EntryScreenshots.qml src/qtquick/qml/GridTileDelegate.qml src/qtquick/qml/NewStuffButton.qml src/qtquick/qml/NewStuffDialog.qml src/qtquick/qml/NewStuffDialogContent.qml src/qtquick/qml/NewStuffDownloadItemsSheet.qml src/qtquick/qml/NewStuffEntryDetails.qml src/qtquick/qml/NewStuffPage.qml src/qtquick/qml/NewStuffQuestionAsker.qml src/qtquick/qml/Rating.qml src/qtquick/qml/Shadow.qml src/qtquick/qmldir src/qtquick/qmlplugin.cpp src/qtquick/quickengine.cpp src/qtquick/quickengine.h src/qtquick/quickitemsmodel.cpp src/qtquick/quickitemsmodel.h src/qtquick/quickquestionlistener.cpp src/qtquick/quickquestionlistener.h tests/CMakeLists.txt tests/khotnewstuff-dialog-ui/main.qml tests/khotnewstuff-dialog.cpp To: leinir Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
KDE CI: Frameworks » frameworkintegration » kf5-qt5 SUSEQt5.13 - Build # 4 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20SUSEQt5.13/4/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 10 Jul 2019 10:37:29 + Build duration: 3 min 24 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5FrameworkIntegration-5.60.0.xmlcompat_reports/KF5FrameworkIntegration_compat_report.htmllogs/KF5FrameworkIntegration/5.60.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report40% (2/5)33% (2/6)33% (2/6)17% (75/452)10% (31/319)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (1/1)100% (1/1)92% (24/26)50% (4/8)src.integrationplugin0% (0/2)0% (0/2)0% (0/70)0% (0/106)src.kpackage-install-handlers.kns0% (0/1)0% (0/1)0% (0/84)0% (0/40)src.kstyle100% (1/1)100% (1/1)21% (51/248)16% (27/165)tests0% (0/1)0% (0/1)0% (0/24)100% (0/0)
D22370: Simplify previous-/nextActivity code in kactivities-cli
apol accepted this revision. REPOSITORY R6 KActivities BRANCH kactivities-cli-simplify (branched from master) REVISION DETAIL https://phabricator.kde.org/D22370 To: muesli, ivan, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22370: Simplify previous-/nextActivity code in kactivities-cli
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH kactivities-cli-simplify (branched from master) REVISION DETAIL https://phabricator.kde.org/D22370 To: muesli, ivan, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22370: Simplify previous-/nextActivity code in kactivities-cli
muesli added a reviewer: ivan. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D22370 To: muesli, ivan Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22370: Simplify previous-/nextActivity code in kactivities-cli
muesli created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. muesli requested review of this revision. REVISION SUMMARY Removed unnecessary bool found and directly return from inner loop. REPOSITORY R6 KActivities BRANCH kactivities-cli-simplify (branched from master) REVISION DETAIL https://phabricator.kde.org/D22370 AFFECTED FILES src/cli/main.cpp To: muesli Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22365: KNotification macOS native support by NSNotificationCenter
Inoki created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Inoki requested review of this revision. REVISION SUMMARY Add macOS native support to KNotification REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22365 AFFECTED FILES src/CMakeLists.txt src/knotificationmanager.cpp src/notifybymacosnotificationcenter.h src/notifybymacosnotificationcenter.mm To: Inoki Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
