D22339: Make sure solid backends are reentrant

[Stefan Brüns]

bruns added a comment.


  This is inacceptable!

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D22339

To: apol, #frameworks, davidedmundson, bruns
Cc: bruns, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22339: Make sure solid backends are reentrant

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:00abb4839abe: Make sure solid backends are reentrant 
(authored by apol).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22339?vs=61408=61684

REVISION DETAIL
  https://phabricator.kde.org/D22339

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/hal/halfstabhandling.cpp
  src/solid/devices/backends/hal/halstorageaccess.cpp
  src/solid/devices/backends/udisks2/udisksdevicebackend.cpp
  src/solid/devices/backends/udisks2/udisksdevicebackend.h
  src/solid/devices/backends/udisks2/udisksopticaldisc.cpp
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: apol, #frameworks, davidedmundson, bruns
Cc: bruns, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22425: personsmodel: Add phoneNumber

[Aleix Pol Gonzalez]

apol added a comment.


  Other than that LGTM

INLINE COMMENTS

> personsmodel.h:60
> +UserRole = Qt::UserRole + 0x1000, ///< in case it's needed to 
> extend, use this one to start from
> +PhoneNumberRole
>  };

Put it after GroupsRole

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22425

To: jbbgameich, #plasma:_mobile, #kde_pim, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/2/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 13 Jul 2019 00:42:27 +
 Build duration:
6 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D22425: personsmodel: Add phoneNumber

[Bhushan Shah]

bshah added a reviewer: apol.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22425

To: jbbgameich, #plasma:_mobile, #kde_pim, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: New framework: KCalCore

[Allen Winter]

On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote:
> With the 19.08 release approaching (and thus the deadline for incompatible 
> changes if we go ahead with this plan), I'd like to raise this again for 
> getting to a decision :)
> 
> Summary of what happened in the past weeks:
> - the Person/Attendee slicing issue was fixed by making both independent types
> - several "leaf" types were turned into implicitly shared value types rather 
> than being used heap-allocated inside shared pointers
> - the dependency on the Akonadi supertrait.h header file was removed
> - the virtual_hook usage in the incidence de/serialization code was replaced 
> by new virtual methods
> 
> Unless I missed something, the remaining unaddressed feedback is down to:
> - Rename KCalCore to something else. I'm ok with executing the rename, but 
> somebody needs to tell me the new name :)

I don't remember the reason for changing the name.
I vote for not changing the name. KCalCore is as good as any, imo

> - Alexander P's fundamental objections to the current KCalCore API
> 
> How do we proceed?
> 
> Thanks,
> Volker
> 
> On Sunday, 7 April 2019 14:45:09 CEST Volker Krause wrote:
> > Hi,
> > 
> > I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> > 
> > KCalCore is an implementation of the iCalendar standard based on libical,
> > covering the data model, input/output and the rather complex recurrence
> > algorithms defined in that standard. It's used outside of KDE PIM as well,
> > e.g. by Zanshin or the Plasma Mobile calendar app.
> > 
> > KCalCore depends on Qt and libical only, making it a Tier 1 functional
> > framework.
> > 
> > KCalCore used to be part of part of kdepimlibs in the KDE4 era, so it's well
> > prepared for complying with the API and ABI guarantees.
> > 
> > I'd suggest the same timeline as proposed for KContacts [1]. During the PIM
> > sprint we did a number of fixes and cleanups as part of the review for KF5
> > that make 19.08 the earliest release after which we can switch as well, so
> > we are looking at a switch in Sep/Oct this year.
> > 
> > 
> > Thanks,
> > Volker
> > 
> > [1]
> > https://mail.kde.org/pipermail/kde-frameworks-devel/2019-April/084057.html
> 
> 

D22425: personsmodel: Add phoneNumber

[Jonah Brüchert]

jbbgameich added a reviewer: KDE PIM.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22425

To: jbbgameich, #plasma:_mobile, #kde_pim
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22425: personsmodel: Add phoneNumber

[Jonah Brüchert]

jbbgameich added a reviewer: Plasma: Mobile.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22425

To: jbbgameich, #plasma:_mobile
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22425: personsmodel: Add phoneNumber

[Jonah Brüchert]

jbbgameich updated this revision to Diff 61671.
jbbgameich added a comment.


  fix indentation

REPOSITORY
  R307 KPeople

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22425?vs=61670=61671

BRANCH
  personsmodel-phoneNumber (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22425

AFFECTED FILES
  src/personsmodel.cpp
  src/personsmodel.h

To: jbbgameich
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22425: personsmodel: Add phoneNumber

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  This is intended to provide shared code for plasma-phone-components and 
spacebar.

TEST PLAN
  The phoneNumber can be retrieved from the model

REPOSITORY
  R307 KPeople

BRANCH
  personsmodel-phoneNumber (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22425

AFFECTED FILES
  src/personsmodel.cpp
  src/personsmodel.h

To: jbbgameich
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22421: generate list of data files on the fly

[Olivier Churlaud]

ochurlaud accepted this revision.
ochurlaud added a comment.
This revision is now accepted and ready to land.


  Nice! Thx Harald!

REPOSITORY
  R264 KApiDox

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22421

To: sitter, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, sbergeron, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

Re: New framework: KCalCore

[Volker Krause]

With the 19.08 release approaching (and thus the deadline for incompatible 
changes if we go ahead with this plan), I'd like to raise this again for 
getting to a decision :)

Summary of what happened in the past weeks:
- the Person/Attendee slicing issue was fixed by making both independent types
- several "leaf" types were turned into implicitly shared value types rather 
than being used heap-allocated inside shared pointers
- the dependency on the Akonadi supertrait.h header file was removed
- the virtual_hook usage in the incidence de/serialization code was replaced 
by new virtual methods

Unless I missed something, the remaining unaddressed feedback is down to:
- Rename KCalCore to something else. I'm ok with executing the rename, but 
somebody needs to tell me the new name :)
- Alexander P's fundamental objections to the current KCalCore API

How do we proceed?

Thanks,
Volker

On Sunday, 7 April 2019 14:45:09 CEST Volker Krause wrote:
> Hi,
> 
> I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> 
> KCalCore is an implementation of the iCalendar standard based on libical,
> covering the data model, input/output and the rather complex recurrence
> algorithms defined in that standard. It's used outside of KDE PIM as well,
> e.g. by Zanshin or the Plasma Mobile calendar app.
> 
> KCalCore depends on Qt and libical only, making it a Tier 1 functional
> framework.
> 
> KCalCore used to be part of part of kdepimlibs in the KDE4 era, so it's well
> prepared for complying with the API and ABI guarantees.
> 
> I'd suggest the same timeline as proposed for KContacts [1]. During the PIM
> sprint we did a number of fixes and cleanups as part of the review for KF5
> that make 19.08 the earliest release after which we can switch as well, so
> we are looking at a switch in Sep/Oct this year.
> 
> 
> Thanks,
> Volker
> 
> [1]
> https://mail.kde.org/pipermail/kde-frameworks-devel/2019-April/084057.html



signature.asc
Description: This is a digitally signed message part.

D22419: Fix cant enter directory error on Android FTP servers

[NXiss7]

nxiss7 edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D16882#494702 , @rjvbb wrote:
  
  > Please check the earlier discussion; IIRC there is a reliability problem 
with that signal, and I did try reverting to its use before coming up with the 
current solution.
  
  
  I read indeed the very discussion before, a few times even (see also that I 
fixed the link to the blog post in the commit message of mine) :)
  Initially I hoped we could just go with your patch and be done, but I wanted 
to understand the problem in details first, to not have to rely on IIRC and 
vague commit messages and historic situations .And when doing so I found 
nothing which actually prevent to use that signal, but rather some issue in the 
original commit which tried to use it. So please take some time to read the 
text about that patch to understand why I rather went to propose that as 
altenativenow.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau, mwolff
Cc: mwolff, egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, 
hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, 
geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb added a comment.


  Please check the earlier discussion; IIRC there is a reliability problem with 
that signal, and I did try reverting to its use before coming up with the 
current solution.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau, mwolff
Cc: mwolff, egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, 
hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, 
geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[Friedrich W. H. Kossebau]

kossebau added a comment.


  While trying to understand the problem, I found that perhaps we could still 
revert to using the `aboutToHide` signal, with proper boundaroes.
  So alternative solution  proposal up as D22424 


REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau, mwolff
Cc: mwolff, egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, 
hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, 
geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kbusyindicatorwidget.h:52
> + *
> + * @since 5.60.0
> + */

5.61.0

> kbusyindicatorwidgettest.cpp:43
> +
> +auto toggle = new QPushButton(QStringLiteral("Toggle Visibile"), 
> );
> +

typo

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
sbergeron, michaelh, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Harald Sitter]

sitter updated this revision to Diff 61659.
sitter added a comment.


  - add simple example code + image
  - add @since tag
  - override event

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22375?vs=61603=61659

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22375

AFFECTED FILES
  docs/pics/kbusyindicatorwidget.png
  src/CMakeLists.txt
  src/kbusyindicatorwidget.cpp
  src/kbusyindicatorwidget.h
  tests/CMakeLists.txt
  tests/kbusyindicatorwidgettest.cpp

To: sitter, cfeck, apol
Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
sbergeron, michaelh, bruns

D22421: generate list of data files on the fly

[Harald Sitter]

sitter added a reviewer: ochurlaud.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D22421

To: sitter, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, sbergeron, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D22421: generate list of data files on the fly

[Harald Sitter]

sitter created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the previous list was woefully insufficent and not including half the
  things necessary for generating a working apidoc from the installed
  kapidox (css, 3drdparty etc. were missing)

TEST PLAN
  installing and then using kapidox_generate actually generates fully themed 
docs

REPOSITORY
  R264 KApiDox

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22421

AFFECTED FILES
  setup.py

To: sitter
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, sbergeron, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D22419: Fix cant enter directory error on Android FTP servers

[NXiss7]

nxiss7 added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix cant enter directory error on Android FTP servers

[NXiss7]

nxiss7 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nxiss7 requested review of this revision.

REVISION SUMMARY
  Some Android FTP server applications don't implement lower-case "list" 
command thus KIO can't connect to server and fail with error "Can't enter 
directory."
  Sending upper-case "LIST" command works.
  
  BUG: 409740

TEST PLAN
  This patch is really small and I've been using this for over a year, it seems 
okay.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22419

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: nxiss7
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

[Nicolas Fella]

nicolasfella requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> CMakeLists.txt:40
> +if (NOT ANDROID)
> +find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus)
> +else ()

Move it down to the audio logic, the if check is the same

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D21660_1

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

[Piyush Aggarwal]

brute4s99 retitled this revision from "remove dbus and change audio dep logic" 
to "remove dbus for windows build and change audio dep logic".

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D21660_1

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21660: remove dbus and change audio dep logic

[Piyush Aggarwal]

brute4s99 retitled this revision from "change audio dep logic wrt win32" to 
"remove dbus and change audio dep logic".
brute4s99 edited the summary of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D21660_1

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21660: change audio dep logic wrt win32

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 61639.
brute4s99 added a comment.


  no more dbus on Windows build of KNotifications

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21660?vs=61422=61639

BRANCH
  arcpatch-D21660_1

REVISION DETAIL
  https://phabricator.kde.org/D21660

AFFECTED FILES
  CMakeLists.txt
  src/knotificationmanager.cpp

To: brute4s99, broulik, nicolasfella
Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21660: change audio dep logic wrt win32

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> nicolasfella wrote in CMakeLists.txt:38
> But this is KNotifications, not KDE Connect. So we need DBus for 
> KNotifications on Windows?

ah, yeah we could bypass DBus on Windows in KNotifications

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D21660

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 61638.
leinir added a comment.


  - A small spacer item for the entry details page
  - Documentation++
  - Show a passive notification in the dialog when messages are posted

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=61500=61638

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D22414: Fix build due to missing QVector include

[Daniel Vrátil]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:886f7f4004e5: Fix build due to missing QVector include 
(authored by dvratil).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22414?vs=61631=61634

REVISION DETAIL
  https://phabricator.kde.org/D22414

AFFECTED FILES
  src/kpackage/private/versionparser.cpp

To: dvratil, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22414: Fix build due to missing QVector include

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22414

To: dvratil, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22413: Fix build after 0b2fe3cf21

[Daniel Vrátil]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:95e9d5f22ea3: Fix build after 0b2fe3cf21 (authored by 
dvratil).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22413?vs=61628=61633

REVISION DETAIL
  https://phabricator.kde.org/D22413

AFFECTED FILES
  src/lib/text/kstringhandler.cpp

To: dvratil, dfaure, broulik
Cc: broulik, kde-frameworks-devel, mlaurent, LeGast00n, michaelh, ngraham, bruns

D22413: Fix build after 0b2fe3cf21

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kstringhandler.cpp:346
>  int length = 0;
>  auto chrs = text.toUcs4();
>  for (auto chr : chrs) {

for the reference, `toUcs4()` returns a `QVector`

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22413

To: dvratil, dfaure, broulik
Cc: broulik, kde-frameworks-devel, mlaurent, LeGast00n, michaelh, ngraham, bruns

D22414: Fix build due to missing QVector include

[Daniel Vrátil]

dvratil created this revision.
dvratil added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  I get 'implicit instantiation of undefined template 'QVector'
  when building against Qt 5.12.4 without this change.

TEST PLAN
  Builds against Qt 5.12.4

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22414

AFFECTED FILES
  src/kpackage/private/versionparser.cpp

To: dvratil, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22413: Fix build after 0b2fe3cf21

[Daniel Vrátil]

dvratil created this revision.
dvratil added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  QVector is not unused in kstringhandler.cpp

TEST PLAN
  kcoreaddons master builds against Qt 5.12.4

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22413

AFFECTED FILES
  src/lib/text/kstringhandler.cpp

To: dvratil, dfaure
Cc: kde-frameworks-devel, mlaurent, LeGast00n, michaelh, ngraham, bruns