D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Hallas]

hallas added a comment.


  One thing, when this is ready to land I will address the Windows support so 
that we do not get broken builds :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Hallas]

hallas updated this revision to Diff 64973.
hallas marked 2 inline comments as done.
hallas added a comment.


  Review comments

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21760?vs=64911=64973

BRANCH
  add_list_processes_with_open_files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21760

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/klistopenfilestest.cpp
  autotests/klistopenfilestest.h
  src/lib/CMakeLists.txt
  src/lib/util/klistopenfiles.cpp
  src/lib/util/klistopenfiles.h

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Hallas]

hallas added a comment.


  @dfaure  - Overall, what do you think about the approach of subclassing KJob? 
Did it turn out like you had thought? And is this the solution we should go 
with, or was one of the other solutions better?

INLINE COMMENTS

> dfaure wrote in klistopenfiles.cpp:29
> I wonder if this actually needs to be a QObject, given that you use 
> connect-to-pointer-to-member-function?

The primary motivation was memory-management, but I could also just make the 
d-pointer in ListOpenFilesJob a QScopedPointer, would that be better?

> dfaure wrote in klistopenfiles.cpp:44
> KIO::ERR_DOES_NOT_EXIST would fit well here, but that's in kio...
> 
> I suggest adding enum { ERR_DOES_NOT_EXIST = KJob::UserDefinedError + 11 }
> in the header file for this job and using that here.
> 
> And yes, you should do something like
> 
>   setErrorText(i18n("Directory does not exist: %1", path));

I have added the error enum entries, but I am a little hesitant to add to error 
texts since KCoreAddons doesn't today depend on KDE::I18n and this would 
introduce that dependency, do we really want that? When I look at the KIO 
classes then they usually set som non-translated string as the error text, 
would that be an option?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 105 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/105/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 30 Aug 2019 03:18:34 +
 Build duration:
9 min 27 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.62.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)21%
(461/2245)18%
(178/999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)60%
(60/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/43/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 30 Aug 2019 03:17:49 +
 Build duration:
9 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23464: Add breeze icons for ROOT cern files

[TrickyRicky]

trickyricky26 added a comment.


  My thoughts on your submission:
  
  For the 16px and 22px designs, I would with the designs @ndavis proposed here:
  
  In D23464#521662 , @ndavis wrote:
  
  > F7290924: mimetypes.tar.gz 
  
  
  Yes, the symbol there has the same thickness throughout the root sign, which 
differs from the original branding, but this makes the icon much more 
discernable and it's not like you could make out that difference at that size 
anyway.
  As @noahdvs mentioned above, the white background should be removed and the 
entire symbol should be made up of one filled path with no outline (!). This is 
important to keep the icon looking as intended with the Qt SVG renderer.
  
  As for the 32px and 64px designs, I would much prefer using only two colors 
by placing white variants of the smaller icons on top of a blue document 
background. 
  Example for the 32px icon:
  F7293342: application-x-root-32.png 
  
  I think this fits much better with other Breeze mimetype icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23515: Format class: add functions to know if XML files set style attributes

[Christoph Cullmann]

cullmann added a comment.


  As we have already members like
  
  hasX
  
  would it make sense to have
  
  hasItalicOverride()
  
  to be more consistent?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23515

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23515: Format class: add functions to know if XML files set style attributes

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  What I currently dislike is that `definitionHasXyz` implies the Definition 
class has something, which is not correct, since it's about whether the Format 
has an override. I would very much prefer: bool overridesBold, overridesItalic, 
overridesTextColor.
  
  Can we agree on this?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23515

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23515: Format class: add functions to know if XML files set style attributes

[Christoph Cullmann]

cullmann added a comment.


  Shall we go with the definitionHasX style or change it?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23515

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23500: Support for native Matlab strings

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:20e4bb60aa40: Support for native Matlab strings (authored 
by bbuch, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23500?vs=64926=64969

REVISION DETAIL
  https://phabricator.kde.org/D23500

AFFECTED FILES
  autotests/input/test.m
  data/syntax/matlab.xml

To: bbuch, cullmann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D23500: Support for native Matlab strings

[Christoph Cullmann]

cullmann added a comment.


  I see, there is already some highlight.m test, I will just add your test case 
to that stuff.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  arcpatch-D23500

REVISION DETAIL
  https://phabricator.kde.org/D23500

To: bbuch, cullmann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D23500: Support for native Matlab strings

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks, this seems ok for me, will add the needed test references myself 
(make test complaints about missing ones).

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  arcpatch-D23500

REVISION DETAIL
  https://phabricator.kde.org/D23500

To: bbuch, cullmann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

[Christoph Cullmann]

cullmann abandoned this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23498

To: cullmann, bbuch
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann edited reviewers, added: bbuch; removed: cullmann.
cullmann added a comment.


  Ok, then we can abandon this one.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23498

To: cullmann, bbuch
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

[Ben Cooksley]

bcooksley removed a subscriber: fsitter.

REPOSITORY
  R320 KIO Extras

BRANCH
  fixSFTP (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: bcooksley, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov, fsitter

D23381: Allow splitting lists using ;

[Ben Cooksley]

bcooksley removed a subscriber: fsitter.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23381

To: apol, #frameworks
Cc: bcooksley, dfaure, kossebau, sitter, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns, fsitter

D23262: disable autouic again - it breaks builds

[Ben Cooksley]

bcooksley removed a subscriber: fusitter.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23262

To: sitter, apol, nicolasfella, cullmann
Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns, fusitter

D23344: assert slave command finality

[Ben Cooksley]

bcooksley removed a subscriber: fsitter.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23344

To: sitter, dfaure
Cc: bcooksley, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, 
fsitter

D16395: Update the "About KDE" text

[Ben Cooksley]

bcooksley removed a subscriber: fusitter.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: bcooksley, valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, 
abetts, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, 
fusitter

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Ben Cooksley]

bcooksley removed a subscriber: fsitter.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter
Cc: bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns, fsitter

D22968: Make it possible to modify contacts

[Aleix Pol Gonzalez]

apol marked an inline comment as done.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22968

To: apol, #frameworks, jbbgameich, bshah
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

[Aleix Pol Gonzalez]

apol updated this revision to Diff 64963.
apol added a comment.


  Don't get creative naming classes on the qml plugin

REPOSITORY
  R307 KPeople

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22968?vs=64834=64963

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22968

AFFECTED FILES
  src/backends/CMakeLists.txt
  src/backends/abstractcontact.cpp
  src/backends/abstractcontact.h
  src/backends/abstracteditablecontact.cpp
  src/backends/abstracteditablecontact.h
  src/backends/basepersonsdatasource.cpp
  src/backends/basepersonsdatasource.h
  src/declarative/peopleqmlplugin.cpp
  src/global.h
  src/persondata.cpp
  src/persondata.h
  src/personmanager_p.h
  src/personpluginmanager.cpp
  src/personpluginmanager.h

To: apol, #frameworks, jbbgameich, bshah
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23555: Add @since 5.62 for newly added setters

[Méven Car]

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> kossebau wrote in query.h:101
> One issue here: for doxygen to pick this up and thus add to generated docs, 
> the comment has to start with `/**`. Fixing myself this time, as I have the 
> code in front of me now :)

Thanks

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D23555

To: meven, ivan, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

[Jonah Brüchert]

jbbgameich added inline comments.

INLINE COMMENTS

> peopleqmlplugin.cpp:64
>  qmlRegisterUncreatableType(uri, 1, 0, "ActionType", 
> QStringLiteral("You cannot create ActionType"));
> +qmlRegisterSingletonType(uri, 1, 0, 
> "Manager", [] (QQmlEngine*, QJSEngine*) -> QObject* { return new 
> DeclarativeKPeopleManager; });
>  }

Not sure whether this should follow the Person(s) naming scheme as well..

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22968

To: apol, #frameworks, jbbgameich, bshah
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

[Fu Sitter]

fusitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: fusitter, valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, 
abetts, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

[Fu Sitter]

fusitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: fusitter, ngraham, rikmills, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D22805: set autorcc and autouic by default

[Fu Sitter]

fusitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22805

To: sitter, apol, nicolasfella
Cc: fusitter, cullmann, nicolasfella, cgiboudeaux, vkrause, kossebau, apol, 
kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, 
ngraham, bruns

D23262: disable autouic again - it breaks builds

[Fu Sitter]

fusitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23262

To: sitter, apol, nicolasfella, cullmann
Cc: fusitter, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D23381: Allow splitting lists using ;

[Fuk Sitter]

fsitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23381

To: apol, #frameworks
Cc: fsitter, dfaure, kossebau, sitter, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Fuk Sitter]

fsitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter
Cc: fsitter, ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

[Fuk Sitter]

fsitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R320 KIO Extras

BRANCH
  fixSFTP (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: fsitter, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D23344: assert slave command finality

[Fuk Sitter]

fsitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23344

To: sitter, dfaure
Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

[Fuk Sitter]

fsitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R320 KIO Extras

BRANCH
  fixSFTP (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: fsitter, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D23537: extend state verification to open connection commands

[Fuk Sitter]

fsitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23537

To: sitter, dfaure
Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

[Fuk Sitter]

fsitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R320 KIO Extras

BRANCH
  fixSFTP (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: fsitter, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D23552: ECM: remove set_package_properties from FindCanberra

[Fuk Sitter]

fsitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23552

To: dfaure, cgiboudeaux, sitter
Cc: fsitter, kossebau, kde-buildsystem, kde-frameworks-devel, apol, aacid, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23344: assert slave command finality

[Fuk Sitter]

fsitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23344

To: sitter, dfaure
Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde added a comment.


  > The 16 and 22 px versions aren't supposed to have backgrounds and the root 
symbols are pretty faint.
  
  Rethinking it, I think it's wrong. The white background belongs to the logo 
and should not be removed as the white circle and the root symbol belong 
together, even
  if it is against the Breeze guide line. ;)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: detect the Qt version KF5 frameworks were built against in CMake?

[René J . V . Bertin]

Friedrich W. H. Kossebau wrote:

> Can you specifiy some more what you mean by "pull in"?

Adding indirect dependencies of the target framework needed for it to link 
successfully, as you deduced below.

> It also assumes you use compatible build flags for Qt and do not have e.g.

Of course, the usual "all other things being equal" (or at least compatible).

> find_package(KFFoo). Those ensure that required dependencies for the public
> interface are found as well, by having lines like
> 
> find_dependency(Qt5Core "5.9.0")

Those aren't required on all platforms, btw; on Mac you can leave those out 
(possibly because dependencies on shared libraries are registered with the full 
path to said dependency).

> This find_dependency() call will find whatever Qt is to be found first in the
> environment where find_package(KF5Foo) is called. So not necessarily the Qt
> installation which was used to build KF5Foo.

Hmmm, direct calls of the type `find_package(qt5 ...)` in the project cmake 
files 
do indeed find the Qt version I'm trying to build against. But I still end up 
with references to Qt components that I am not using directly, those can only 
come from KF5 framework dependencies.

CMake should find the requested Qt components in the intended version, indeed. 
Apparently it doesn't, and Qt5 cmake files evidently reference only resources 
from the version (install) to which they belong.

BTW, the problem here is not so much with libraries but with headers.

> Talking about, this actually could be also wrong sometimes, both in case
> someone accidentally combines an older, yet old enough for the minimum Qt
> version, which would fail only at link/load time then if symbols only
> available in the newer Qt version had been used before.

I don't really want to do that mind exercise :) but I think it wouldn't hurt to 
set a CMake constant containing the Qt version against which a framework was 
built.

> And the question would be, what is your actual case you need the info for?

What I am doing ATM can be compared to simulating a Qt5 upgrade (using an "out-
of-prefix" Qt install) without rebuilding all frameworks, and then rebuilding a 
3rd party application that uses some KF5 frameworks.

> version was build against. So perhaps your need could/should be solved some
> other way.

Not wrong. The actual thing that I was tinkering with that led to this question 
was simulating a *downgrade* (rather, I wanted to check if some issue occurred 
with Qt 5.8 as it does with Qt 5.9). The software where the link failure 
occurred builds against Qt 5.8 so I was very surprised when I saw that a 
QT_VERSION > 5.8 test succeeded. It is then that I saw noticed the -I arguments 
pointing to my Qt 5.9 install, for components like QtNetwork only used in the 
framework dependencies, not in the code I was building.
I did try to include qglobal.h hoping it would be found in the target Qt 
directory, but no such luck.

Of course this is not officially supported, bound to fail at runtime, so I gave 
up and disabled the part of the build depending on KDE. But the question seemed 
valid.

An equivalent error as the one I was seeing could arise when the (say) Qt 5.9 
version of the code uses a deprecated method no longer available in (say) Qt 
5.12. Just like in my case the QT_VERSION check ended up using a function from 
the *newer* Qt version (= the one used to build the KF5 frameworks), the 
QT_VERSION test could also go awry and use a deprecated method no longer 
available in Qt 5.12 .

D23555: Add @since 5.62 for newly added setters

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> query.h:101
>  void addUrlFilters(const QStringList );
> +/*
> + * @since 5.62

One issue here: for doxygen to pick this up and thus add to generated docs, the 
comment has to start with `/**`. Fixing myself this time, as I have the code in 
front of me now :)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D23555

To: meven, ivan, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde updated this revision to Diff 64946.
alexde added a comment.


  Add new 32px icons.
  
  The root is now less faint and uses the original color.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=64944=64946

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> meven wrote in CMakeLists.txt:68
> See D23556 

Thanks for the quick fixes :)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: kossebau, broulik, dhaumann, elvisangelaccio, kde-frameworks-devel, 
kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> leinir wrote in atticaprovider.cpp:355
> That'd be good, except the rest of the KNewStuff API is all QList based. 
> It'll want doing for KF6, but since QList is being deprecated for that 
> anyway, i'm thinking we'll end up with a general QList->QVector porting 
> effort for that time anyway, and right now it'd just be introducing a 
> different API style for seemingly no reason... Otherwise yes :)

Fair enough. I do try to make sure to use vectors as much as possible in new 
API, but consistency is also a good argument. :)

> leinir wrote in Dialog.qml:76
> Because a changedEntries property would logically be for the lifetime of the 
> component instance, where dialogFinished is for this specific time the dialog 
> was opened... The property would reasonably also be useful, but it would be 
> semantically different (unless it's documented as being cleared when the 
> dialog is shown, and then filled with whatever's changed once the dialog has 
> been closed... which we could do, but kind of feels uglier than this signal)

It would match with the FileDialog API 
(https://doc.qt.io/qt-5/qml-qtquick-dialogs-filedialog.html#fileUrls-prop) 
however, which also has this behaviour. My main problem with signal parameters 
is that you cannot bind to them, so using the result gets trickier.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde updated this revision to Diff 64944.
alexde added a comment.


  Also add the new 64px breeze icon.
  Add new 22 px icons. Transparent background, less faint, original color.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=64935=64944

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde added a comment.


  In D23464#521662 , @ndavis wrote:
  
  > I think we should use `#1ed4e5` for the color instead since that's what the 
official logo uses. Normally, I'd say to use a similar Breeze-like color, but 
mimetype icons are a mess anyway and I don't think it's worth worrying too much 
about unless Breeze's official color palette is expanded.
  
  
  I have changed the color  for the 64px version. I think we can keep the blue 
background color as this is indeed the offical background color.
  
  > The 16 and 22 px versions aren't supposed to have backgrounds and the root 
symbols are pretty faint.
  
  Uh, I will make them somehow less faint, though I am not sure how to keep 
their original character in this case.
  
  >   I've remade these for you:
  > 
  > F7290924: mimetypes.tar.gz 
  
  Thanks, but the root you created does not resemble the original one any 
longer. However, I will rework them as well.
  
  > The 32px version isn't lined up with the grid and the emblem in the middle 
is faint. Generally, one should avoid placing objects on half pixels.
  
  I will see what I can do about it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde updated this revision to Diff 64935.
alexde added a comment.


  Improve the root logo layout and change the root's color to the offical color 
1ED4E5

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=64668=64935

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 64934.
leinir added a comment.


  - Debug--
  - Ensure data is actually loaded properly, also from cache
  - Include the right header
  - Adapt the Discover comments delegate (and add a nesting indicator)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=64855=64934

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  CMakeLists.txt
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/commentsmodel.cpp
  src/qtquick/commentsmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D23344: assert slave command finality

[David Faure]

dfaure added a comment.


  LOL, so even the joke (about you writing buggy code) was buggy, good one ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23344

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski marked 5 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski marked 4 inline comments as done.
mdlubakowski added a comment.


  First of all, sorry for the mess I made here with Arcanist. My SSD died 
recently and I lost original repository with those changes, so I used `arc 
patch` to pull it back, updated the code and pushed here with `arc diff 
--update`. I'm not sure if it affects anything though, I tested on fresh 
repository and it can be patched with this revision without problem.
  In response to the feedback, I ditched my original dialog - it is now shared 
with that from `makeServiceExecutable` helper function (the one that shows for 
.desktop files), and its code is moved to `showUntrustedProgramWarning` method. 
Code for setting executable bit is also moved, from `makeFileExecutable` to 
`setExecuteBit`.
  Desktop and script files also show another type of dialog, one which ask user 
whether to open or execute the file, but I decided not to use it here with 
executables since I don't think anyone needs to open executables with external 
programs.

INLINE COMMENTS

> dfaure wrote in krun.cpp:1105
> This can be removed now that isExecutableFile returns true for desktop files.

isExecutableFile will return false if the file doesn't have +x bit, which will 
result in prompt not being show, so I dont think this should be removed.

> dfaure wrote in krun.cpp:1389
> is *an* executable
> 
> (otherwise this sentence is very confusing)

This line is now removed

> dfaure wrote in krun.cpp:1390
> What happens for desktop files? Won't this go into this code, before going 
> into the existing code to make desktop files executable?

Moved all the code to KRun::runUrl instead, so it doesnt intercept anything

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D7446: [Places panel] Revamp the Recently Saved section

[Nicolas Fella]

nicolasfella removed a reviewer: markg.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski updated this revision to Diff 64930.
mdlubakowski added a comment.


  Incorporated feedback

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22510?vs=61918=64930

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/42/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 29 Aug 2019 10:49:31 +
 Build duration:
8 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23559: Incorporated feedback

[Marcin Dłubakowski]

mdlubakowski created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mdlubakowski requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D23559

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h

To: mdlubakowski
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23344: assert slave command finality

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:830c56744f2b: assert slave command finality (authored by 
sitter).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23344?vs=64826=64928

REVISION DETAIL
  https://phabricator.kde.org/D23344

AFFECTED FILES
  CMakeLists.txt
  src/core/config-kiocore.h.cmake
  src/core/slavebase.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23344: assert slave command finality

[Harald Sitter]

sitter added a comment.


  Shoes! I meant shoes! 

REPOSITORY
  R241 KIO

BRANCH
  assert

REVISION DETAIL
  https://phabricator.kde.org/D23344

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 64927.
meven added a comment.


  Adapt kio tests to changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=64880=64927

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

[Benjamin Buch]

bbuch added a comment.


  Added changes to D23500 .

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23498

To: bbuch, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23500: Support for native Matlab strings

[Benjamin Buch]

bbuch updated this revision to Diff 64926.
bbuch added a comment.


  Highlighting of keywords, variables and operators as such for Matlab source 
files
  
  Currently, Matlab source files display keywords, variables, and operators as
  normal text. So they don't get any special highlighting and their presentation
  can't be varied by themes. Especially for keywords this is very annoying.
  
  The patch assigns them to the appropriate theme category to fix this.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23500?vs=64854=64926

BRANCH
  arcpatch-D23500

REVISION DETAIL
  https://phabricator.kde.org/D23500

AFFECTED FILES
  autotests/input/test.m
  data/syntax/matlab.xml

To: bbuch, cullmann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.12 - Build # 36 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.12/36/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 29 Aug 2019 09:23:21 +
 Build duration:
4 min 4 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5IconThemes-5.62.0.xmlcompat_reports/KF5IconThemes_compat_report.htmllogs/KF5IconThemes/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)68%
(15/22)68%
(15/22)53%
(1468/2770)40%
(703/1749)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)99%
(500/502)49%
(187/380)src80%
(8/10)80%
(8/10)46%
(968/2105)38%
(516/1357)src.tools.kiconfinder0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/6)tests0%
(0/4)0%
(0/4)0%
(0/146)0%
(0/6)

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.12 - Build # 35 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 29 Aug 2019 05:31:01 +
 Build duration:
3 hr 48 min and counting
   CONSOLE OUTPUT
  [...truncated 389 lines...][2019-08-29T05:34:05.347Z] [ 26%] Automatic MOC for target kiconengine_unittest[2019-08-29T05:34:05.847Z] [ 26%] Built target kiconengine_unittest_autogen[2019-08-29T05:34:05.847Z] Scanning dependencies of target kicontheme_unittest_autogen[2019-08-29T05:34:05.847Z] [ 27%] Automatic MOC for target kicontheme_unittest[2019-08-29T05:34:06.351Z] [ 27%] Built target kicontheme_unittest_autogen[2019-08-29T05:34:06.351Z] Scanning dependencies of target kiconloader_resourcethemetest_autogen[2019-08-29T05:34:06.351Z] [ 28%] Automatic MOC for target kiconloader_resourcethemetest[2019-08-29T05:34:06.867Z] [ 28%] Built target kiconloader_resourcethemetest_autogen[2019-08-29T05:34:06.867Z] Scanning dependencies of target kicondialog_unittest_autogen[2019-08-29T05:34:06.867Z] [ 29%] Automatic MOC for target kicondialog_unittest[2019-08-29T05:34:06.867Z] [ 29%] Built target kicondialog_unittest_autogen[2019-08-29T05:34:07.378Z] Scanning dependencies of target kiconloader_unittest_autogen[2019-08-29T05:34:07.378Z] [ 30%] Automatic MOC for target kiconloader_unittest[2019-08-29T05:34:07.887Z] [ 30%] Built target kiconloader_unittest_autogen[2019-08-29T05:34:07.887Z] Scanning dependencies of target kiconloader_rcctest_autogen[2019-08-29T05:34:07.887Z] [ 32%] Automatic MOC for target kiconloader_rcctest[2019-08-29T05:34:07.887Z] [ 32%] Built target kiconloader_rcctest_autogen[2019-08-29T05:34:08.395Z] Scanning dependencies of target kiconloader_benchmark_autogen[2019-08-29T05:34:08.395Z] [ 33%] Automatic MOC for target kiconloader_benchmark[2019-08-29T05:34:08.395Z] [ 33%] Built target kiconloader_benchmark_autogen[2019-08-29T05:34:08.395Z] Scanning dependencies of target KIconEnginePlugin[2019-08-29T05:34:08.395Z] [ 34%] Building CXX object src/CMakeFiles/KIconEnginePlugin.dir/KIconEnginePlugin_autogen/mocs_compilation.cpp.o[2019-08-29T05:34:08.903Z] [ 35%] Building CXX object src/CMakeFiles/KIconEnginePlugin.dir/kiconengineplugin.cpp.o[2019-08-29T05:34:11.246Z] [ 36%] Linking CXX shared module ../bin/KIconEnginePlugin.so[2019-08-29T05:34:11.749Z] [ 36%] Built target KIconEnginePlugin[2019-08-29T05:34:11.749Z] Scanning dependencies of target kiconfinder5[2019-08-29T05:34:11.749Z] [ 38%] Building CXX object src/tools/kiconfinder/CMakeFiles/kiconfinder5.dir/kiconfinder5_autogen/mocs_compilation.cpp.o[2019-08-29T05:34:11.750Z] [ 39%] Building CXX object src/tools/kiconfinder/CMakeFiles/kiconfinder5.dir/kiconfinder.cpp.o[2019-08-29T05:34:14.120Z] [ 40%] Linking CXX executable ../../../bin/kiconfinder5[2019-08-29T05:34:14.618Z] [ 40%] Built target kiconfinder5[2019-08-29T05:34:14.618Z] [ 41%] Generating qrc_designerplugin.cpp[2019-08-29T05:34:14.618Z] Scanning dependencies of target kiconthemeswidgets[2019-08-29T05:34:14.618Z] [ 42%] Building CXX object src/designer/CMakeFiles/kiconthemeswidgets.dir/kiconthemeswidgets_autogen/mocs_compilation.cpp.o[2019-08-29T05:34:14.618Z] [ 44%] Building CXX object src/designer/CMakeFiles/kiconthemeswidgets.dir/kiconthemeswidgets_ECMQtDesignerPlugin/designerplugin.cpp.o[2019-08-29T05:34:17.738Z] [ 45%] Building CXX object src/designer/CMakeFiles/kiconthemeswidgets.dir/qrc_designerplugin.cpp.o[2019-08-29T05:34:17.738Z] [ 46%] Linking CXX shared module ../../bin/kiconthemes5widgets.so[2019-08-29T05:34:18.238Z] [ 46%] Built target kiconthemeswidgets[2019-08-29T05:34:18.737Z] Scanning dependencies of target kicondialogtest[2019-08-29T05:34:18.737Z] [ 47%] Building CXX object tests/CMakeFiles/kicondialogtest.dir/kicondialogtest_autogen/mocs_compilation.cpp.o[2019-08-29T05:34:18.737Z] [ 48%] Building CXX object tests/CMakeFiles/kicondialogtest.dir/kicondialogtest.cpp.o[2019-08-29T05:34:21.081Z] [ 50%] Linking CXX executable ../bin/kicondialogtest[2019-08-29T05:34:21.586Z] [ 50%] Built target kicondialogtest[2019-08-29T05:34:22.085Z] Scanning dependencies of target kiconbuttontest[2019-08-29T05:34:22.085Z] [ 51%] Building CXX object tests/CMakeFiles/kiconbuttontest.dir/kiconbuttontest_autogen/mocs_compilation.cpp.o[2019-08-29T05:34:22.085Z] [ 52%] Building CXX object tests/CMakeFiles/kiconbuttontest.dir/kiconbuttontest.cpp.o[2019-08-29T05:34:24.445Z] [ 53%] Linking CXX executable ../bin/kiconbuttontest[2019-08-29T05:34:25.499Z] [ 53%] Built target kiconbuttontest[2019-08-29T05:34:25.499Z] Scanning dependencies of target kiconloadertest[2019-08-29T05:34:25.499Z] [ 54%] Building CXX object tests/CMakeFiles/kiconloadertest.dir/kiconloadertest_autogen/mocs_compilation.cpp.o[2019-08-29T05:34:25.499Z] [ 55%] Building CXX object tests/CMakeFiles/kiconloadertest.dir/kiconloadertest.cpp.o[2019-08-29T05:34:27.847Z] [ 57%] Linking CXX executable ../bin/kiconloadertest[2019-08-29T05:34:28.346Z] [ 57%] 

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23556: Add version requirement to dependency KActivitiesStats

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:bca85c1c50c1: Add version requirement to dependency 
KActivitiesStats (authored by meven).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23556?vs=64918=64923

REVISION DETAIL
  https://phabricator.kde.org/D23556

AFFECTED FILES
  CMakeLists.txt

To: meven, #frameworks, kossebau, ivan
Cc: kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23555: Add @since 5.62 for newly added setters

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R159:91f28c34cf74: Add @since 5.62 for newly added setters 
(authored by meven).

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23555?vs=64917=64924

REVISION DETAIL
  https://phabricator.kde.org/D23555

AFFECTED FILES
  src/query.h

To: meven, ivan, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> klistopenfiles.cpp:29
> +
> +class ListOpenFilesJobPrivate : public QObject
> +{

I wonder if this actually needs to be a QObject, given that you use 
connect-to-pointer-to-member-function?

> hallas wrote in klistopenfiles.cpp:44
> Should I also set an error string here? And what about defining custom error 
> codes, is that how we usually do?

KIO::ERR_DOES_NOT_EXIST would fit well here, but that's in kio...

I suggest adding enum { ERR_DOES_NOT_EXIST = KJob::UserDefinedError + 11 }
in the header file for this job and using that here.

And yes, you should do something like

  setErrorText(i18n("Directory does not exist: %1", path));

> klistopenfiles.cpp:53
> +{
> +job->setError(KJob::UserDefinedError);
> +job->emitResult();

+setErrorText()

> klistopenfiles.h:41
> +public:
> +explicit ListOpenFilesJob(QDir path);
> +~ListOpenFilesJob() override;

const QDir &  --- or actually, we use const QString & everywhere else for paths.

> klistopenfiles.h:51
> + * @param processInfoList The list of processes with open files in path
> + * @since 5.62
> + */

The @since should go into the (missing) class documentation, given that the 
whole class is new.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23552: ECM: remove set_package_properties from FindCanberra

[David Faure]

dfaure abandoned this revision.
dfaure added a comment.


  Ah, I didn't realize there was no warning if calling set_package_properties 
with different properties.
  
  Good idea. Done in 
https://commits.kde.org/knotifications/06f5a4a6f8622913cb9cecd89b98cf762a489823

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23552

To: dfaure, cgiboudeaux, sitter
Cc: kossebau, kde-buildsystem, kde-frameworks-devel, apol, aacid, LeGast00n, 
GB_2, bencreasy, michaelh, ngraham, bruns

D23555: Add @since 5.62 for newly added setters

[Ivan Čukić]

ivan accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23555

To: meven, ivan, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23556: Add version requirement to dependency KActivitiesStats

[Ivan Čukić]

ivan accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23556

To: meven, #frameworks, kossebau, ivan
Cc: kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

[Méven Car]

meven marked 2 inline comments as done.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D23399

To: meven, ivan
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven marked 2 inline comments as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: kossebau, broulik, dhaumann, elvisangelaccio, kde-frameworks-devel, 
kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> kossebau wrote in CMakeLists.txt:68
> Please add a min version, as the code seems to rely on new API only added 
> recently:
> 
>   find_package(KF5ActivitiesStats 5.62.0 QUIET)

See D23556 

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: kossebau, broulik, dhaumann, elvisangelaccio, kde-frameworks-devel, 
kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D23556: Add version requirement to dependency KActivitiesStats

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, kossebau.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23556

AFFECTED FILES
  CMakeLists.txt

To: meven, #frameworks, kossebau
Cc: kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

[Méven Car]

meven marked 2 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> kossebau wrote in query.h:101
> "5.62" of course :)

Thanks D23555 

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D23399

To: meven, ivan
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23555: Add @since 5.62 for newly added setters

[Méven Car]

meven created this revision.
meven added reviewers: ivan, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23555

AFFECTED FILES
  src/query.h

To: meven, ivan, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I think we should use `#1ed4e5` for the color instead since that's what the 
official logo uses. Normally, I'd say to use a similar Breeze-like color, but 
mimetype icons are a mess anyway and I don't think it's worth worrying too much 
about unless Breeze's official color palette is expanded.
  
  The 16 and 22 px versions aren't supposed to have backgrounds and the root 
symbols are pretty faint. I've remade these for you:
  
  F7290924: mimetypes.tar.gz 
  
  The 32px version isn't lined up with the grid and the emblem in the middle is 
faint. Generally, one should avoid placing objects on half pixels.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23552: ECM: remove set_package_properties from FindCanberra

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  I'd do the opposite, remove `DESCRIPTION` and `URL` from knotification's 
CMakeLists.txt and only leave the `PURPOSE` line.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23552

To: dfaure, cgiboudeaux, sitter
Cc: kossebau, kde-buildsystem, kde-frameworks-devel, apol, aacid, LeGast00n, 
GB_2, bencreasy, michaelh, ngraham, bruns