D23791: ECMAddQch: add INCLUDE_DIRS argument

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ee4c3fd91eea: ECMAddQch: add INCLUDE_DIRS argument 
(authored by kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23791?vs=65657=66099

REVISION DETAIL
  https://phabricator.kde.org/D23791

AFFECTED FILES
  modules/ECMAddQch.cmake
  modules/ECMQchDoxygen.config.in

To: kossebau, #build_system, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Nathaniel Graham]

ngraham added a comment.


  Two things with this patch series:
  
  1. Now there's no way to lock widgets without entering panel edit mode. Feels 
like we might as well just get rid of unlocked mode entirely. Or are more 
patches coming? Did we ever come to a conclusion in T10190 
?
  
  2. Since this is a Frameworks change and will/would land in 5.63, we can't 
depend on having it for Plasma 5.17. If D23950 
 does not work without this frameworks 
change, then here are our options:
- Delay D23950  until Plasma 5.18 
(maybe for the best if the final UX is not clear yet)
- Ask Frameworks packagers to re-spin plasma-framework for 5.62 to include 
this change once it's accepted
- Do it anyway and hope no discrete release distros decide to ship Plasma 
5.17 with Frameworks 5.62 for years and years

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 23:13:16 +
 Build duration:
2 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 87 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/87/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 14 Sep 2019 22:35:16 +
 Build duration:
25 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33707/61253)39%
(17296/44156)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9385/9837)47%
(4350/9246)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8639/14487)51%
(4784/9313)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4646/8277)42%
(2049/4831)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(676/1209)40%
(382/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4290)36%
(1327/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 220 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/220/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 14 Sep 2019 22:35:16 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33709/61252)39%
(17292/44160)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9387/9837)47%
(4353/9246)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8640/14487)51%
(4780/9313)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4651/8277)42%
(2054/4835)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(676/1209)40%
(382/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1799/4290)36%
(1325/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/76/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 22:35:17 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

[Nicolas Fella]

nicolasfella added a comment.


  This fixed it for me, thanks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23944

To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

[David Faure]

dfaure added a comment.


  It built for me; but I pushed a missing include.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23944

To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli added a comment.


  I spent some time with modifying CopyJob but didn't make much progress and 
it's too deep into KIO internals - a lot one has to familiarize himself with. 
Maybe it's best someone who already did work on KIO to add the batch stuff. 
Once that is done and merged we can resume over here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, 
ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 added a dependency: D23950: Only show "Add Widgets..." and "Lock Widgets" 
panel context menu options in panel edit mode.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  See M144  and T10047 
. This makes the panel customization 
options much more discoverable. This is how it looks like together with 
PATCH_HERE:
  
  Unlocked Widgets: F7352335: Improved Panel Context Menu Widgets Unlocked.png 

  
  Locked Widgets: F7352331: Improved Panel Context Menu Widgets Locked.png 


TEST PLAN
  Open the panel context menu

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23586: Improve code that detects useful elements in an Svg file

[Frederik Gladhorn]

gladhorn added inline comments.

INLINE COMMENTS

> svg.cpp:103
>  while (!reader.atEnd()) {
> -if (reader.readNext() == QXmlStreamReader::StartElement &&
> +const auto t = reader.readNext();
> +if (t == QXmlStreamReader::StartElement) {

Maybe use "element" instead of "t" as variable name?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23586

To: apol, #plasma, #frameworks
Cc: gladhorn, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

[Nibaldo González]

nibags marked an inline comment as done.
nibags added inline comments.

INLINE COMMENTS

> dhaumann wrote in katemodemenulist.cpp:175
> QStringLiteral("") us discouraged and should simply be QString().

Fixed in 3aa9c13f5a8b 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23935

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

[Kai Uwe Broulik]

broulik added a comment.


  This breaks the build: 
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/219/
  
 /home/jenkins/workspace/Frameworks/kio/kf5-qt5 
SUSEQt5.12/src/widgets/krun_p.h:97:10: error: ���unique_ptr��� in namespace 
���std��� does not name a template type
21:32:46 97 | std::unique_ptr m_process;

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23944

To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23667: Add == and != operators to KIO::UDSEntry

[Méven Car]

meven added a comment.


  @pino if this is fine for you...

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23667

REVISION DETAIL
  https://phabricator.kde.org/D23667

To: meven, #frameworks, ngraham
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

[Méven Car]

meven updated this revision to Diff 66086.
meven added a comment.


  Update @since references

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23667?vs=65705=66086

BRANCH
  arcpatch-D23667

REVISION DETAIL
  https://phabricator.kde.org/D23667

AFFECTED FILES
  autotests/udsentrytest.cpp
  autotests/udsentrytest.h
  src/core/udsentry.cpp
  src/core/udsentry.h
  tests/udsentrybenchmark.cpp

To: meven, #frameworks, ngraham
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Nathaniel Graham]

ngraham added a dependent revision: D23868: [kfontinst] Port to use icons from 
the icon theme.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 19:27:00 +
 Build duration:
7 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 219 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/219/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 14 Sep 2019 19:27:00 +
 Build duration:
5 min 52 sec and counting
   CONSOLE OUTPUT
  [...truncated 1196 lines...][2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.cpp:256:49: warning: ���virtual QFileDialog* KUrlRequester::fileDialog() const��� is deprecated [-Wdeprecated-declarations][2019-09-14T19:32:46.038Z]   256 | QFileDialog *dlg = m_parent->fileDialog();[2019-09-14T19:32:46.038Z]   | ^[2019-09-14T19:32:46.038Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.cpp:20:[2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.h:184:48: note: declared here[2019-09-14T19:32:46.038Z]   184 | virtual KIOWIDGETS_DEPRECATED QFileDialog *fileDialog() const;[2019-09-14T19:32:46.038Z]   |^~[2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.cpp: In lambda function:[2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.cpp:474:52: warning: ���virtual QFileDialog* KUrlRequester::fileDialog() const��� is deprecated [-Wdeprecated-declarations][2019-09-14T19:32:46.038Z]   474 | applyFileMode(m_parent->fileDialog(), fileDialogMode, fileDialogAcceptMode);[2019-09-14T19:32:46.038Z]   |^[2019-09-14T19:32:46.038Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.cpp:20:[2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.h:184:48: note: declared here[2019-09-14T19:32:46.038Z]   184 | virtual KIOWIDGETS_DEPRECATED QFileDialog *fileDialog() const;[2019-09-14T19:32:46.038Z]   |^~[2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.cpp: In lambda function:[2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.cpp:481:52: warning: ���virtual QFileDialog* KUrlRequester::fileDialog() const��� is deprecated [-Wdeprecated-declarations][2019-09-14T19:32:46.038Z]   481 | applyFileMode(m_parent->fileDialog(), fileDialogMode, fileDialogAcceptMode);[2019-09-14T19:32:46.038Z]   |^[2019-09-14T19:32:46.038Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.cpp:20:[2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/kurlrequester.h:184:48: note: declared here[2019-09-14T19:32:46.038Z]   184 | virtual KIOWIDGETS_DEPRECATED QFileDialog *fileDialog() const;[2019-09-14T19:32:46.038Z]   |^~[2019-09-14T19:32:46.038Z] [ 50%] Linking CXX executable ../bin/dataprotocoltest[2019-09-14T19:32:46.038Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/krun.cpp:23:[2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/krun_p.h:97:10: error: ���unique_ptr��� in namespace ���std��� does not name a template type[2019-09-14T19:32:46.038Z]97 | std::unique_ptr m_process;[2019-09-14T19:32:46.038Z]   |  ^~[2019-09-14T19:32:46.038Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/krun_p.h:33:1: note: ���std::unique_ptr��� is defined in header ��; did you forget to ���#include ���?[2019-09-14T19:32:46.038Z]32 | #include "kstartupinfo.h"[2019-09-14T19:32:46.038Z]   +++ |+#include [2019-09-14T19:32:46.038Z]33 | [2019-09-14T19:32:46.540Z] [ 51%] Building CXX object autotests/CMakeFiles/http_jobtest.dir/httpserver_p.cpp.o[2019-09-14T19:32:46.540Z] [ 51%] Linking CXX executable ../bin/upurltest[2019-09-14T19:32:46.540Z] [ 51%] Built target dataprotocoltest[2019-09-14T19:32:46.540Z] Scanning dependencies of target privilegejobtest[2019-09-14T19:32:46.540Z] [ 51%] Building CXX object autotests/CMakeFiles/privilegejobtest.dir/privilegejobtest_autogen/mocs_compilation.cpp.o[2019-09-14T19:32:47.046Z] [ 51%] Linking CXX executable ../bin/kmountpointtest[2019-09-14T19:32:47.046Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/krun.cpp: In constructor ���KProcessRunner::KProcessRunner(const KService&, const QList&, WId, KRun::RunFlags, const QString&, const QByteArray&)���:[2019-09-14T19:32:47.046Z] 

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Nathaniel Graham]

ngraham added a comment.


  I still feel like I'd prefer the checkmark to be green. I also feel like I 
understand the argument that red isn't the best color to use for disabling 
something since it isn't destructive. Maybe we should use the orange color for 
that?
  
  Definitely need clarification in the HIG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 86 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/86/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 14 Sep 2019 19:27:00 +
 Build duration:
3 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 1203 lines...][2019-09-14T19:30:01.787Z]   |^~[2019-09-14T19:30:01.787Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/kurlrequester.cpp: In lambda function:[2019-09-14T19:30:01.787Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/kurlrequester.cpp:481:52: warning: ���virtual QFileDialog* KUrlRequester::fileDialog() const��� is deprecated [-Wdeprecated-declarations][2019-09-14T19:30:01.787Z]   481 | applyFileMode(m_parent->fileDialog(), fileDialogMode, fileDialogAcceptMode);[2019-09-14T19:30:01.787Z]   |^[2019-09-14T19:30:01.788Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/kurlrequester.cpp:20:[2019-09-14T19:30:01.788Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/kurlrequester.h:184:48: note: declared here[2019-09-14T19:30:01.788Z]   184 | virtual KIOWIDGETS_DEPRECATED QFileDialog *fileDialog() const;[2019-09-14T19:30:01.788Z]   |^~[2019-09-14T19:30:01.788Z] [ 48%] Built target jobremotetest[2019-09-14T19:30:01.788Z] [ 48%] Building CXX object autotests/CMakeFiles/http_jobtest.dir/http_jobtest.cpp.o[2019-09-14T19:30:01.788Z] Scanning dependencies of target kmountpointtest[2019-09-14T19:30:01.788Z] [ 48%] Building CXX object autotests/CMakeFiles/kmountpointtest.dir/kmountpointtest_autogen/mocs_compilation.cpp.o[2019-09-14T19:30:02.044Z] Scanning dependencies of target upurltest[2019-09-14T19:30:02.044Z] [ 49%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest_autogen/mocs_compilation.cpp.o[2019-09-14T19:30:02.044Z] [ 49%] Built target ktcpsockettest[2019-09-14T19:30:02.044Z] [ 50%] Building CXX object autotests/CMakeFiles/kmountpointtest.dir/kmountpointtest.cpp.o[2019-09-14T19:30:02.044Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/krun.cpp: In function ���int showUntrustedProgramWarning(const QString&, QWidget*)���:[2019-09-14T19:30:02.044Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/krun.cpp:301:56: warning: ���QWidget* QDesktopWidget::screen(int)��� is deprecated: Use QScreen [-Wdeprecated-declarations][2019-09-14T19:30:02.044Z]   301 | QSize screenSize = QApplication::desktop()->screen()->size();[2019-09-14T19:30:02.044Z]   |^[2019-09-14T19:30:02.044Z] In file included from /usr/include/qt5/QtWidgets/QDesktopWidget:1,[2019-09-14T19:30:02.044Z]  from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/krun.cpp:41:[2019-09-14T19:30:02.044Z] /usr/include/qt5/QtWidgets/qdesktopwidget.h:77:45: note: declared here[2019-09-14T19:30:02.044Z]77 | QT_DEPRECATED_X("Use QScreen") QWidget *screen(int screen = -1);[2019-09-14T19:30:02.044Z]   | ^~[2019-09-14T19:30:02.044Z] [ 50%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest.cpp.o[2019-09-14T19:30:02.301Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/krun.cpp: In constructor ���KProcessRunner::KProcessRunner(const KService&, const QList&, WId, KRun::RunFlags, const QString&, const QByteArray&)���:[2019-09-14T19:30:02.301Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/krun.cpp:1563:7: error: class ���KProcessRunner��� does not have any field named ���m_process���[2019-09-14T19:30:02.301Z]  1563 | : m_process{new KProcess},[2019-09-14T19:30:02.301Z]   |   ^[2019-09-14T19:30:02.301Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/krun.cpp:1575:6: error: ���m_process��� was not declared in this scope; did you mean ���KProcess���?[2019-09-14T19:30:02.301Z]  1575 | *m_process << args;[2019-09-14T19:30:02.301Z]   |  ^[2019-09-14T19:30:02.301Z]   |  KProcess[2019-09-14T19:30:02.301Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/krun.cpp:1601:37: warning: ���QString KService::path() const��� is deprecated [-Wdeprecated-declarations][2019-09-14T19:30:02.301Z]  1601 | QString workingDir(service.path());[2019-09-14T19:30:02.301Z]   | ^[2019-09-14T19:30:02.301Z] In file included from /home/jenkins/install-prefix/include/KF5/KService/kmimetypetrader.h:23,[2019-09-14T19:30:02.301Z]  from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/widgets/krun.cpp:54:[2019-09-14T19:30:02.301Z] 

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23944

To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe added a comment.


  @ndavis can you give review? thanks!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.


  Now it's good!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe added a comment.


  Changed to `currentColor`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe updated this revision to Diff 66083.
guoyunhe added a comment.


  Remove hardcoded colors

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66080=66083

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/font-enable.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 added a comment.


  In D23942#531364 , @guoyunhe wrote:
  
  > @GB_2 is it correct now?
  
  
  There's still a hardcoded `style="fill:#da4453"` in the `disable` icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe added a comment.


  @GB_2 is it correct now?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe updated this revision to Diff 66080.
guoyunhe added a comment.


  Add inline styles

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66077=66080

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/font-enable.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 added a comment.


  In D23942#531349 , @guoyunhe wrote:
  
  > I was asked to remove the hard code color like: `fill="currentColor"` and 
`fill="#da4453"`. But I see other icons have something like 
`style="fill:currentColor"`. Can anyone tell me correct way of applying colors?
  
  
  Just `fill="currentColor"` is correct.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe added a comment.


  I was asked to remove the hard code color like: `fill="currentColor"` and 
`fill="#da4453"`. But I see other icons have something like 
`style="fill:currentColor"`. Can anyone tell me correct way of applying colors?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 added a comment.


  In D23942#531347 , @guoyunhe wrote:
  
  > @ndavis it looks strange when I removed the inline style
  >
  >   {F7351830}
  
  
  The inline style needs to be included, how it is now.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe added a comment.


  @ndavis it looks strange when I removed the inline style
  
  F7351830: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.


  Then it's fine.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe added a comment.


  I just followed the email icons' color: check mark is black/white, disable 
mark is red.
  
  F7351796: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Noah Davis]

ndavis added a comment.


  In D23942#531337 , @GB_2 wrote:
  
  > In D23942#531330 , @ngraham 
wrote:
  >
  > > Shouldn't the checkmark be green?
  >
  >
  > FWIW, both should be black/white. Disabling is not a destructive action 
like removing.
  
  
  We use red for disabling as well. Perhaps we need to work on this a bit. One 
of the problems with only using black and white is that the emblems become 
harder to notice.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Björn Feber]

GB_2 added a comment.


  In D23942#531330 , @ngraham wrote:
  
  > Shouldn't the checkmark be green?
  
  
  FWIW, both should be black/white. Disabling is not a destructive action like 
removing.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23915: Improve documentation

[Frederik Gladhorn]

gladhorn updated this revision to Diff 66078.
gladhorn retitled this revision from "Improve documentation

Some of the documentation did not say what the purpose of the
respective class was, but rather gave a tautology.
For people new to the code base it helps to mention that
DPMS is power management.

That DataDevice is for copy..." to "Improve documentation".
gladhorn edited the summary of this revision.
gladhorn added a comment.


  Thank you arc for messing up my commit message XD

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23915?vs=66026=66078

BRANCH
  arcpatch-D23915_1

REVISION DETAIL
  https://phabricator.kde.org/D23915

AFFECTED FILES
  src/client/datadevice.h
  src/client/dpms.h
  src/server/datadevice_interface.h
  src/server/dpms_interface.h

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Nathaniel Graham]

ngraham added a comment.


  Shouldn't the checkmark be green?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe updated this revision to Diff 66077.
guoyunhe added a comment.


  Remove hardcoded colors

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66071=66077

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/font-enable.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Noah Davis]

ndavis added a comment.


  In D23942#531279 , @guoyunhe wrote:
  
  > @ndavis, @broulik, @ngraham, I made some change. Can you have another look?
  
  
  I just noticed that the "No" symbol is backwards. Once you fix that and the 
hardcoded colors, this patch will be ready to land.

INLINE COMMENTS

> font-disable.svg:11
> + fill="currentColor"/>
> +
> +

Hardcoded color

> font-disable.svg:10
> +
> + fill="#da4453"/>
> +

Hardcoded color

> font-disable.svg:11
> + fill="currentColor"/>
> +
> +

Hardcoded color

> font-disable.svg:10
> +
> + fill="#da4453"/>
> +

Hardcoded color

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23946: Remove dependency on kdesignerplugin

[Friedrich W. H. Kossebau]

kossebau added a comment.


  The current macro does not check for the existence, so the dep is hard IMHO.
  
  One could change that, but myself no energy left to work on/review such 
patch, all my energy would be spent to get of kdelibs4support completely in 
general :)

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D23946

To: arojas, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23902: [KCoreDirLister] replace deprecated foreach with range-for

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kcoredirlister.cpp:1044
> It's generally considered bad practice to return a const value, because the 
> caller makes a copy anyway, so this doesn't guarantee anything. And it 
> removes the benefits of rvalues that can be moved, since C++11.
> 
> I can see how range-for actually benefits from this, though.
> 
> It just seems that the generally agreed solution is to return non-const (for 
> the other benefits) and use a local const variable as intermediary when using 
> this in a range-for.

Noted.

> dfaure wrote in kcoredirlister.cpp:1960
> const

(Note to self, "we need a copy" doesn't necessarily mean a non-const copy).

> dfaure wrote in kcoredirlister.cpp:2073
> `holders.count()`, to match what the orig code was doing

Ouch, right.

> dfaure wrote in kcoredirlister.cpp:
> Why not just `qAsConst(listDirs)`? Did you identify a risk that the body of 
> the for loop modifies lstDirs?

I thought that way it doesn't get cast (with qAsConst) twice, as lstDirs is 
used in another for loop a couple of lines down. But I was wrong, qAsConst 
doesn't copy its arguments, so qAsConst is better suited.

However this loop doesn't look like it modifies lstDirs.

> kcoredirlister.cpp:2237
>  
> -Q_FOREACH (const QUrl , lstDirs) {
> +for (const QUrl  : dirs) {
>  KFileItemList deletedItems;

But this one might change lstDirs, as itemsDeleted is emitted, which calls 
deleteDir() and forgetDirs(); I am not sure though. I'll use a const var for 
this loop.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23902

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23902: [KCoreDirLister] replace deprecated foreach with range-for

[Ahmad Samir]

ahmadsamir updated this revision to Diff 66073.
ahmadsamir marked 7 inline comments as done.
ahmadsamir retitled this revision from "[KCoreDirLister] replace foreach with 
range-for" to "[KCoreDirLister] replace deprecated foreach with range-for".
ahmadsamir added a comment.


  Fix stuff mentioned in code review

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23902?vs=65910=66073

BRANCH
  ahmad/foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23902

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23946: Remove dependency on kdesignerplugin

[Antonio Rojas]

arojas added a comment.


  Does that really justify a hard dependency? It would make more sense for the 
dependency to be moved to the projects that do use the macro. 
extra-cmake-modules ships macros that call sip or doxygen and it doesn't hard 
depend on them.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D23946

To: arojas, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe added a comment.


  @ndavis, @broulik, @ngraham, I made some change. Can you have another look?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe updated this revision to Diff 66071.
guoyunhe added a comment.


  Add 16px icons for font-enable and font-disable

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66067=66071

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/font-enable.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23946: Remove dependency on kdesignerplugin

[Friedrich W. H. Kossebau]

kossebau added a comment.


  PS: That''s also the reason why I gave up on porting kdelibs4support away 
from it, given the tool is leaked in the public interface by this macro (cmp. 
comment D22776#503175 )

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D23946

To: arojas, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23946: Remove dependency on kdesignerplugin

[Friedrich W. H. Kossebau]

kossebau added a comment.


  It's there because one of the cmake macros kdelibs4support installs depends 
on its existance, see
  
https://phabricator.kde.org/source/kdelibs4support/browse/master/src/KDEUIMacros.cmake$166

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D23946

To: arojas, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23946: Remove dependency on kdesignerplugin

[Antonio Rojas]

arojas created this revision.
arojas added a reviewer: kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Not sure what the reason was to have it here in the first place, but it 
doesn't seem to make sense nowadays. It adds an unnecesary build dependency on 
kdesignerplugin for all packages that depend on kdelibs4support.

TEST PLAN
  Builds

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D23946

AFFECTED FILES
  KF5KDELibs4SupportConfig.cmake.in

To: arojas, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  1_kprocesrunner

REVISION DETAIL
  https://phabricator.kde.org/D23944

To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe updated this revision to Diff 66067.
guoyunhe added a comment.


  Reduce space between A and marks

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66050=66067

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> katemodemenulist.cpp:175
> +// which will remain hidden and will only be shown when necessary.
> +createSectionList(QStringLiteral(""), false);
> +m_list->setRowHidden(0, true);

QStringLiteral("") us discouraged and should simply be QString().

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23935

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14707: autotests: skip '/' fstab check with zfs

[David Faure]

dfaure added a reviewer: adridg.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14707

To: dfaure, adridg
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

[David Faure]

dfaure created this revision.
dfaure added reviewers: vkrause, nicolasfella, broulik.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  - Make that functionality QWidget-independent
  - Emit errors as a signal rather than a messagebox. KRun still connects
  
  to the signal and shows messageboxes, so there's no behaviour change for
  KRun users.
  
  This is one more step in the direction of OpenUrlJob+KProcessRunner,
  both in KIOGui.
  
  Next steps: turning it into a KJob, then renaming it to
  e.g. KIO::ProcessLauncherJob

TEST PLAN
  I'll write a unittest after conversion to KJob.
  For now I used the GUI `kruntest` program.

REPOSITORY
  R241 KIO

BRANCH
  1_kprocesrunner

REVISION DETAIL
  https://phabricator.kde.org/D23944

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: dfaure, vkrause, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 14:21:37 +
 Build duration:
1 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23939: [KService] add workingDirectory(), deprecate path().

[David Faure]

dfaure closed this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D23939

To: dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe updated this revision to Diff 66050.
guoyunhe edited the summary of this revision.
guoyunhe added a comment.


  Rename enablefont and disablefont icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66043=66050

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Noah Davis]

ndavis added a comment.


  Oof, all of the font icons that contain an 'A' need to be cleaned up someday. 
The 'A's aren't even 16px tall and the line thickness and alignment is all over 
the place. I guess that's something for another patch. For now, we should 
maintain consistency with the existing font icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe added a comment.


  In D23942#531086 , @broulik wrote:
  
  > Please use a more hierarchical name, e.g. "font-enable" and "font-disable", 
to match the other font icons we have such as "font-size-up" and "font-face"
  
  
  OK. Then need to update kfontinst, too.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  There's a bit too much space around the checkmark.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Kai Uwe Broulik]

broulik added a comment.


  Please use a more hierarchical name, e.g. "font-enable" and "font-disable", 
to match the other font icons we have such as "font-size-up" and "font-face"

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/74/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 14:03:31 +
 Build duration:
8 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23943: HiDPI support

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R311:1147829e8ea8: HiDPI support (authored by Guo Yunhe 
i...@guoyunhe.me).

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23943?vs=66047=66048

REVISION DETAIL
  https://phabricator.kde.org/D23943

AFFECTED FILES
  src/runtime/kwalletd/main.cpp

To: guoyunhe, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23943: HiDPI support

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23943

To: guoyunhe, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23943: HiDPI support

[Yunhe Guo]

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D23943

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23943: HiDPI support

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Make the change password pop up sharp in HiDPI display, which is a part of 
kwalletd.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23943

AFFECTED FILES
  src/runtime/kwalletd/main.cpp

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kunitconversion » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20WindowsMSVCQt5.13/5/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sat, 14 Sep 2019 11:41:57 +
 Build duration:
2 hr 6 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

[Christoph Feck]

cfeck added a comment.


  I somehow knew autotest would fail on FreeBSD ... I cannot investigate why it 
fails, maybe too old MIME database?

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D23811

To: cfeck, #frameworks, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, 
huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns

D23939: [KService] add workingDirectory(), deprecate path().

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23939

To: dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/8/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 12:09:48 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe edited the summary of this revision.
guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23902: [KCoreDirLister] replace foreach with range-for

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcoredirlister.cpp:285
>  {
> -Q_FOREACH (CachedItemsJob *job, m_cachedItemsJobs) {
> +for (CachedItemsJob *job : qAsConst(m_cachedItemsJobs)) {
>  if (job->url() == url) {

The method is const, so this qAsConst isn't needed.

> kcoredirlister.cpp:1044
>  
> -QList KCoreDirListerCache::directoriesForCanonicalPath(const QUrl 
> ) const
> +const QList KCoreDirListerCache::directoriesForCanonicalPath(const 
> QUrl ) const
>  {

It's generally considered bad practice to return a const value, because the 
caller makes a copy anyway, so this doesn't guarantee anything. And it removes 
the benefits of rvalues that can be moved, since C++11.

I can see how range-for actually benefits from this, though.

It just seems that the generally agreed solution is to return non-const (for 
the other benefits) and use a local const variable as intermediary when using 
this in a range-for.

> kcoredirlister.cpp:1474
>  // TODO: make this a separate method?
> -foreach (KCoreDirLister *kdl, listers + holders) {
> +for (KCoreDirLister *kdl : listers + holders) {
>  if (kdl->d->rootFileItem.isNull() && kdl->d->url == newUrl) {

I guess this needs a local const var to hold listers+holders, so that the 
container that we're iterating on, is const?

> kcoredirlister.cpp:1492
>  // emit old items: listers, holders
> -foreach (KCoreDirLister *kdl, listers + holders) {
> +for (KCoreDirLister *kdl : listers + holders) {
>  if (kdl->d->rootFileItem.isNull() && kdl->d->url == newUrl) {

same here

> kcoredirlister.cpp:1960
>  // we need a copy because stop modifies the list
>  QList listers = (*dit).listersCurrentlyListing;
> +for (KCoreDirLister *kdl : listers) {

const

> kcoredirlister.cpp:1968
>  // we need a copy because forgetDirs modifies the list
>  QList holders = (*dit).listersCurrentlyHolding;
> +for (KCoreDirLister *kdl : holders) {

const

> kcoredirlister.cpp:2073
>  }
> -qCDebug(KIO_CORE_DIRLISTER) << "  " << dit.key() << 
> (*dit).listersCurrentlyHolding.count() << "holders:" << list;
> +qCDebug(KIO_CORE_DIRLISTER) << "  " << dit.key() << holders << 
> "holders:" << list;
>  }

`holders.count()`, to match what the orig code was doing

> kcoredirlister.cpp:
> +const QList dirs = lstDirs;
> +for (const QUrl  : dirs) {
> +const QList *itemList = 
> kDirListerCache()->itemsForDir(dir);

Why not just `qAsConst(listDirs)`? Did you identify a risk that the body of the 
for loop modifies lstDirs?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23902

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 11:43:30 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/22/disablefont.svg
  icons-dark/actions/22/enablefont.svg
  icons/actions/22/disablefont.svg
  icons/actions/22/enablefont.svg

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 61 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/61/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 14 Sep 2019 11:42:09 +
 Build duration:
52 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.63.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSurface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)89%
(239/268)89%
(239/268)82%
(26107/31978)51%
(10408/20534)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)93%
(11652/12522)47%
(6145/13037)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)84%
(6249/7459)64%
(1804/2828)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)83%
(7752/9340)62%
(2282/3678)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/16/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 11:42:09 +
 Build duration:
49 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 16 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  fix_unittest_if_lsof_is_not_installed

REVISION DETAIL
  https://phabricator.kde.org/D23884

To: hallas, dfaure
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23523

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/28/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 11:41:38 +
 Build duration:
35 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/9/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 11:41:19 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/15/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 11:40:54 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/73/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 11:39:46 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R287:68bb1a0ee7f9: Port HDR (Radiance RGBE) image loader to 
Qt5 (authored by cfeck).

REPOSITORY
  R287 KImageFormats

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23811?vs=65784=66041

REVISION DETAIL
  https://phabricator.kde.org/D23811

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/read/hdr/rgb.hdr
  autotests/read/hdr/rgb.png
  src/imageformats/CMakeLists.txt
  src/imageformats/hdr.cpp
  src/imageformats/hdr.json
  src/imageformats/hdr_p.h

To: cfeck, #frameworks, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, 
huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 80 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/80/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 14 Sep 2019 11:37:33 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.63.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6880/9069)43%
(10760/24785)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2866/2956)48%
(6161/12707)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/789)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(994/1215)50%
(1017/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 6 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/6/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sat, 14 Sep 2019 11:36:57 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarktest

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Quick update:
  Currently still busy trying to get unit tests done, half-way through that. 
ETA begin of upcoming week.
  Next plan: see how only having the 3-arg-`FOO_DEPRECATED_VERSION(major. 
minor, message)` would work by using that in the experimental patches done for 
some KF repos.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
GB_2, bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/26/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 11:38:04 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/8/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 11:38:15 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 11:37:33 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D23939: [KService] add workingDirectory(), deprecate path().

[David Faure]

dfaure created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Reading code like service->path() is confusing, because it looks like
  the path to the .desktop file (which is in fact entryPath(), most
  likely because path() was already taken).
  
  The key in the desktop file is called Path (and that won't change),
  but in the C++ API, workingDirectory() is much clearer.

TEST PLAN
  Builds

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23939

AFFECTED FILES
  src/services/kservice.cpp
  src/services/kservice.h
  src/services/kservice_p.h

To: dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23791: ECMAddQch: add INCLUDE_DIRS argument

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I don't know doxygen very well, but the cmake change seems sensible.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  supoortincludedirsinaddqch

REVISION DETAIL
  https://phabricator.kde.org/D23791

To: kossebau, #build_system, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D23937: [KDeclarative] Port away from deprecated QWheelEvent methods

[David Faure]

dfaure created this revision.
dfaure added reviewers: davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This finishes the work to make kdeclarative compile with Qt 5.14,
  when disabling deprecated methods.
  
  Note that the orientation property will have the hardcoded value
  Vertical (it's really surprising that EventGenerator::sendWheelEvent,
  i.e. the conversion in the other direction, was hardcoding it to Horizontal)

TEST PLAN
  Builds

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23937

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp

To: dfaure, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/72/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 10:10:44 +
 Build duration:
7 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

[David Faure]

dfaure closed this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23894

To: dfaure, mart, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/71/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 10:00:40 +
 Build duration:
9 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23898

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns