D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added 1 blocking reviewer(s): Plasma.
This revision now requires review to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 232 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/232/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 27 Sep 2019 00:56:41 +
 Build duration:
9 min 30 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33893/61357)39%
(17180/43920)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9499/9948)47%
(4403/9346)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8675/14484)51%
(4604/8983)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4669/8276)43%
(2062/4835)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1799/4290)36%
(1325/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 101 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/101/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 27 Sep 2019 00:56:41 +
 Build duration:
8 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24150: Fix crash on exit in kio_file

[David Faure]

dfaure closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D24150

To: hwti, cfeck, dfaure, broulik
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24150: Fix crash on exit in kio_file

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Ah, I see, OK.

REVISION DETAIL
  https://phabricator.kde.org/D24150

To: hwti, cfeck, dfaure, broulik
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24254: [KCollapsibleGroupBox] Fix QTimeLine::start warning at runtime

[David Faure]

dfaure created this revision.
dfaure added reviewers: cfeck, ngraham, elvisangelaccio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  KCollapsibleGroupBox::overrideFocusPolicy calls toggle();toggle()
  which starts the same QTimeLine twice before it has a change to end.
  This prints out an annoying runtime warning.

TEST PLAN
  kdialog --detailedsorry foo blah
  This no longer shows
  
  WARNING: QTimeLine::start: already running

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  2019_09_fix_qtimeline_warning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24254

AFFECTED FILES
  src/kcollapsiblegroupbox.cpp

To: dfaure, cfeck, ngraham, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

[David Faure]

dfaure updated this revision to Diff 66932.
dfaure retitled this revision from "Make OK button configurable in 
KMessageBox::detailedSorry" to "Make OK button configurable in 
KMessageBox::sorry/detailedSorry".
dfaure added a comment.


  also add this to sorry(); fix inconsistency with Options arg, that one can 
still have a default value

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24252?vs=66930=66932

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24252

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h
  tests/kmessageboxtest.cpp

To: dfaure, cfeck, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  squiggle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24253

AFFECTED FILES
  icons-dark/actions/22/format-text-underline-squiggle.svg
  icons/actions/22/format-text-underline-squiggle.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24220: [src/ioslaves/*] replace deprecated foreach with range for

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/foreach-ioslaves2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24220

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24252: Make OK button configurable in KMessageBox::detailedSorry

[David Faure]

dfaure created this revision.
dfaure added reviewers: cfeck, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  A `kdialog` user requested being able to set it to e.g. "Abort",
  and indeed it's weird that yes/no buttons are configurable for other
  diaog types but not OK.

TEST PLAN
  Updated test program

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24252

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h
  tests/kmessageboxtest.cpp

To: dfaure, cfeck, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24179: Fix skipOffset with dynamic RegExpr

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:d6b1e02ad4da: Fix skipOffset with dynamic RegExpr 
(authored by jpoelen).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24179?vs=66788=66928#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24179?vs=66788=66928

REVISION DETAIL
  https://phabricator.kde.org/D24179

AFFECTED FILES
  autotests/folding/d399388_dynamic_RegExpr.dyInclRl.fold
  autotests/html/d399388_dynamic_RegExpr.dyInclRl.html
  autotests/input/d399388_dynamic_RegExpr.dyInclRl
  autotests/input/syntax/d399388_dynamic_RegExpr.xml
  autotests/reference/d399388_dynamic_RegExpr.dyInclRl.ref
  src/lib/rule.cpp

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D2545: Cleanup KSharedUiServerProxy before qApp exists

[Christoph Cullmann]

cullmann added a comment.


  Ok, ah, no longer applies cleanly, must redo some things it seems.
  Will create a new patch for submission.

REVISION DETAIL
  https://phabricator.kde.org/D2545

To: kfunk, vonreth, dfaure
Cc: cullmann, thiago, albertvaka, mutlaqja, arrowd, #frameworks

D2545: Cleanup KSharedUiServerProxy before qApp exists

[David Faure]

dfaure added a comment.


  I don't mind, go ahead.

REVISION DETAIL
  https://phabricator.kde.org/D2545

To: kfunk, vonreth, dfaure
Cc: cullmann, thiago, albertvaka, mutlaqja, arrowd, #frameworks

D23857: Honor global animation speed factor

[Nathaniel Graham]

ngraham added a task: T11315: Global Animation Slider.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23857

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21721#538404 , @cfeck wrote:
  
  > I would suggest to commit it either sooner, or after 5.63 is tagged. If you 
commit on 3rd, there are only two days to test and decide how to improve or 
revert before tars are made.
  
  
  Ow, that's indeed soon, somehow i was under the impression it was later than 
that, not sure why... right, in that case it'll want to be tomorrow, with an 
allowance for panic-reverting in case of explosions (which i don't see how 
would happen, but you never know)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: cfeck, davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Christoph Feck]

cfeck added a comment.


  I would suggest to commit it either sooner, or after 5.63 is tagged. If you 
commit on 3rd, there are only two days to test and decide how to improve or 
revert before tars are made.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: cfeck, davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D2545: Cleanup KSharedUiServerProxy before qApp exists

[Christoph Cullmann]

cullmann added a comment.


  David, could we apply this patch, even with the workaround in the Qt patch in 
craft to have a better experience for people not patching their Qt?

REVISION DETAIL
  https://phabricator.kde.org/D2545

To: kfunk, vonreth, dfaure
Cc: cullmann, thiago, albertvaka, mutlaqja, arrowd, #frameworks

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added a comment.


  DBus is an internal dependency for KAuth. With the wrapper users don't have 
to link with QtDBus.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 186 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/186/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 26 Sep 2019 17:54:10 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.63.0.xmlacc/KF5PlasmaQuick-5.63.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_themetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)35%
(44/124)35%
(44/124)35%
(4575/13230)26%
(2490/9653)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)93%
(860/920)50%
(429/852)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(775/2299)26%
(395/1495)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/59)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1503/3492)33%
(943/2853)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)47%
(746/1573)37%
(382/1044)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)7%
(7/105)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(591/2033)19%
(324/1710)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1195)0%
(0/1016)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%

D24245: Add support for passing Unix file descriptors

[Albert Astals Cid]

aacid added a reviewer: security-team.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox 
is open.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D24239: make editMode a corona global property

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c621ebe5726f: make editMode a corona global property 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24239?vs=66904=66910

REVISION DETAIL
  https://phabricator.kde.org/D24239

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 removed a dependency: D24246: Only show panel toolbox when desktop toolbox 
is open.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D24239: make editMode a corona global property

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Never mind, that's not in this patch.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22365: KNotification macOS native support by NSNotificationCenter

[Weixuan Xiao]

Inoki added a comment.


  In D22365#538245 , @lnj wrote:
  
  > There's something for notifications for iOS and macOS here: 
https://developer.apple.com/documentation/foundation/nsnotification
  >  Would this patch already work on iOS or could a common API for both be 
used?
  >
  > (I have no experiences with iOS or macOS, but we (Kaidan) would like to 
support notifications on iOS in the future.)
  
  
  Yes, I use NSNotification API and in theory, it works on iOS but I have no 
idea how to test.
  
  One more thing: Apple plans to mark NSNotification as Deprecated and uses 
UserNotification API in the newer macOS(10.15+) and iOS(13+). It will be nice 
to use that set of APIs for Apple's platform

REVISION DETAIL
  https://phabricator.kde.org/D22365

To: Inoki, rjvbb, nicolasfella
Cc: lnj, nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  Unfortunately, this breaks public API and ABI by modifying KAuth::ActionReply.
  
  I'm not sure whether there has to be any compatibility for the DBus API, but 
I guess not (logging out and back in should suffice to make sure the backend 
used is the same).
  
  I wonder why you made a wrapper around `QDBusUnixFileDescriptor`, does it not 
work inside a `QVariant` OOTB?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox 
is open.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D24239: make editMode a corona global property

[Björn Feber]

GB_2 added a dependent revision: D24246: Only show panel toolbox when desktop 
toolbox is open.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg
Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24239: make editMode a corona global property

[Nathaniel Graham]

ngraham added a comment.


  Could we put the word "wallpaper" somewhere in the global edit mode toolbox 
to improve wallpaper changing discoverability? I recall this in a mockup shown 
at the Plasma & Usability & Productivity sprint.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg
Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

[Alexander Volkov]

volkov added a comment.
Herald added a subscriber: kde-frameworks-devel.


  Passing file descriptors with KAuth: D24245 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6709

To: chinmoyr, thiago, #frameworks, dfaure
Cc: kde-frameworks-devel, volkov, awilcox, dfaure, davidedmundson, 
elvisangelaccio, shortstheory, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Nathaniel Graham]

ngraham added reviewers: fvogt, chinmoyr, cfeck, Frameworks.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D5394: KAuth integration in document saving - vol. 2

[Alexander Volkov]

volkov added a comment.


  D24245  - support for passing Unix file 
descriptors in KAuth.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5394

To: martinkostolny, #ktexteditor, fvogt
Cc: kde-frameworks-devel, volkov, elvisangelaccio, aacid, ivan, lbeltrame, 
fvogt, apol, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, 
davidedmundson, palant, kwrite-devel, dfaure, LeGast00n, szutmael, GB_2, 
domson, michaelh, ngraham, bruns, demsking, head7, kfunk, sars

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Introduce UnixFileDescriptor class, which holds a copy of a file
  descriptor. Actually it's a wrapper around QDBusUnixFileDescriptor.
  
  Currently arguments to/from a helper are passed as QVariantMap,
  encoded as QByteArray. To support passing of file descriptors,
  separate them into their own QVariantMap, and pass arguments as
  QVariantList consisting of the QByteArray blob of data arguments
  and the file descriptors map (HelperProxy::{un}packedArguments()).
  
  Remove operator<<(QDataStream &, const ActionReply &) and
  operator>>(QDataStream &, ActionReply &) as they don't make
  sense with file descriptors and used only internally in
  ActionReply::serialized() and ActionReply::deserialize()
  methods. Modify these methods to work with QVariantList
  instead of QByteArray blobs.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24245

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/HelperProxy.cpp
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/kauth.h
  src/kauthactionreply.cpp
  src/kauthactionreply.h
  src/kauthunixfiledescriptor.cpp
  src/kauthunixfiledescriptor.h

To: volkov
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22365: KNotification macOS native support by NSNotificationCenter

[Linus Jahn]

lnj added a comment.


  There's something for notifications for iOS and macOS here: 
https://developer.apple.com/documentation/foundation/nsnotification
  Would this patch already work on iOS or could a common API for both be used?
  
  (I have no experiences with iOS or macOS, but we (Kaidan) would like to 
support notifications on iOS in the future.)

REVISION DETAIL
  https://phabricator.kde.org/D22365

To: Inoki, rjvbb, nicolasfella
Cc: lnj, nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24239: make editMode a corona global property

[Marco Martin]

mart updated this revision to Diff 66904.
mart added a comment.


  - global actions needed for new edit mode toolbox

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24239?vs=66885=66904

BRANCH
  phab/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24239

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: mart, #plasma, #vdg
Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24171: [src/filewidgets/*] replace deprecated foreach with range for

[Ahmad Samir]

ahmadsamir updated this revision to Diff 66899.
ahmadsamir added a comment.


  More implicit sharing detach prevention

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24171?vs=66698=66899

BRANCH
  ahmad/foreach-filewidgets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24171

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilecopytomenu.cpp
  src/filewidgets/kfilepreviewgenerator.cpp
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/knewfilemenu.cpp
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigatorprotocolcombo.cpp

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23835: Add TabKCM

[Marco Martin]

mart added a comment.


  as background it should probably use a Frame component (which atm in the 
style is just a simple Rectangle.. si i should fix that and make it draw the 
proper raised frame;)
  
  also, sadly, it will have to look good-ish also with other styles, like omg, 
oxygen

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24185: Add format-text-underline-squiggle actions icons

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:477729808ef6: Add format-text-underline-squiggle actions 
icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24185?vs=66827=66897

REVISION DETAIL
  https://phabricator.kde.org/D24185

AFFECTED FILES
  icons-dark/actions/16/format-text-underline-squiggle.svg
  icons-dark/actions/22/format-text-underline-squiggle.svg
  icons/actions/16/format-text-underline-squiggle.svg
  icons/actions/22/format-text-underline-squiggle.svg

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24220: [src/ioslaves/*] replace deprecated foreach with range for

[Ahmad Samir]

ahmadsamir updated this revision to Diff 66895.
ahmadsamir added a comment.


  Use const local var for implicilty shared qstringlist's to prevent detaching

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24220?vs=66815=66895

BRANCH
  ahmad/foreach-ioslaves2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24220

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/http/http_cache_cleaner.cpp
  src/ioslaves/http/httpauthentication.cpp
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/ioslaves/http/kcookiejar/kcookieserver.cpp
  src/ioslaves/trash/trashimpl.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24185: Add format-text-underline-squiggle actions icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  All right, ship it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24185

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24239: make editMode a corona global property

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg
Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24220: [src/ioslaves/*] replace deprecated foreach with range for

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in http.cpp:2612
> Right. A temporary; but since it's a qstringlist it's implicitly shared.

Yes it is, so non-const begin() will detach and make a full copy.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24220

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Alrighty, quick chat somewhere else, and i'm going to have to call silent 
agreement on this one - unless i hear things to the contrary, i'm going to 
merge this next week (that is, 2nd or 3rd of October 2019) so we can get a bit 
more wide-spread testing done on it before the next release rolls around. 
Thanks to those who reviewed already :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24220: [src/ioslaves/*] replace deprecated foreach with range for

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in http.cpp:2612
> need to move that function call into a const local variable

Right. A temporary; but since it's a qstringlist it's implicitly shared.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24220

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 added a comment.


  In D24185#537880 , @ngraham wrote:
  
  > Now the butt ends are gone again. :)
  
  
  Yes, I think it makes more sense for this underline to be a visual crop of a 
longer one as they would appear in eg. LibreOffice Writer. It should also make 
for a tiny bit more contrast at the ends at 100%

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24185

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 100 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/100/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 26 Sep 2019 10:30:39 +
 Build duration:
8 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24239: make editMode a corona global property

[Björn Feber]

GB_2 added a comment.


  Thanks!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg
Cc: GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24239: make editMode a corona global property

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in containmentinterface.cpp:416
> I think you should check for `SystemImmutable` here (KIOSK)

m_containment->corona()->setEditMode(edit) will fail if the immutability isn't 
mutable. so both systemimmutable and userimmutable

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24239: make editMode a corona global property

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> broulik wrote in containmentinterface.cpp:416
> I think you should check for `SystemImmutable` here (KIOSK)

Nevermind, it just moved :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24239: make editMode a corona global property

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> containmentinterface.cpp:416
> -
> -if (m_containment->immutability() != Plasma::Types::Mutable) {
> -return;

I think you should check for `SystemImmutable` here (KIOSK)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24239: make editMode a corona global property

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  The plans are to switch on/off the whole plasma shell into edit mode.
  For this it needs to be a global corona property, rather then just
  containmentInterface.
  Plasmashell would expose a dbus call to set it from systemsettings

TEST PLAN
  plasmoid.editMode=true still works

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24239

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 99 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/99/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 26 Sep 2019 10:07:20 +
 Build duration:
19 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.13’Ready to run at Thu Sep 26 10:26:46 UTC 2019Resuming build at Thu Sep 26 10:26:46 UTC 2019 after Jenkins restartRunning on FreeBSD Builder 2 in /usr/home/jenkins/workspace/Frameworks/kio/kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2019-09-26T10:26:56.064Z] No credentials specified[Pipeline] }[Pipeline] // stage[2019-09-25T21:35:23.257Z] Cloning repository git://anongit.kde.org/kio[2019-09-25T21:35:23.289Z]  > git init /usr/home/jenkins/workspace/Frameworks/kio/kf5-qt5 FreeBSDQt5.13 # timeout=10[2019-09-25T21:35:23.373Z] Fetching upstream changes from git://anongit.kde.org/kio[2019-09-25T21:35:23.374Z]  > git --version # timeout=10[2019-09-25T21:35:23.428Z]  > git fetch --tags --force --progress git://anongit.kde.org/kio +refs/heads/*:refs/remotes/origin/* # timeout=120[Pipeline] }[2019-09-26T10:26:56.799Z] java.lang.Exception: Resume after a restart not supported for non-blocking synchronous steps[2019-09-26T10:26:56.799Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.onResume(SynchronousNonBlockingStepExecution.java:75)[2019-09-26T10:26:56.799Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185)[2019-09-26T10:26:56.799Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)[2019-09-26T10:26:56.799Z] 	at com.google.common.util.concurrent.Futures$6.run(Futures.java:975)[2019-09-26T10:26:56.799Z] 	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)[2019-09-26T10:26:56.799Z] 	at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)[2019-09-26T10:26:56.799Z] 	at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)[2019-09-26T10:26:56.799Z] 	at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:170)[2019-09-26T10:26:56.799Z] 	at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)[2019-09-26T10:26:56.799Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:1011)[2019-09-26T10:26:56.799Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:989)[2019-09-26T10:26:56.799Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:907)[2019-09-26T10:26:56.799Z] 	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:37)[2019-09-26T10:26:56.799Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-09-26T10:26:56.799Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-09-26T10:26:56.799Z] 	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)[2019-09-26T10:26:56.799Z] 	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)[2019-09-26T10:26:56.799Z] 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)[2019-09-26T10:26:56.799Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-09-26T10:26:56.799Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-09-26T10:26:56.799Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-09-26T10:26:56.799Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-09-26T10:26:56.799Z] 	at java.lang.Thread.run(Thread.java:748)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D23667: Add == and != operators to KIO::UDSEntry

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f893784ea4f1: Add == and != operators to KIO::UDSEntry 
(authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23667?vs=66086=66883

REVISION DETAIL
  https://phabricator.kde.org/D23667

AFFECTED FILES
  autotests/udsentrytest.cpp
  autotests/udsentrytest.h
  src/core/udsentry.cpp
  src/core/udsentry.h
  tests/udsentrybenchmark.cpp

To: meven, #frameworks, ngraham, dfaure
Cc: dfaure, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 66876.
leinir added a comment.


  Ping @Frameworks - new cycle, chunky thing, be good to get it in early :)
  
  - Since 5.63 now that 5.62 is out the door

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=66529=66876

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  CMakeLists.txt
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.cpp
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/commentsmodel.cpp
  src/qtquick/commentsmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24220: [src/ioslaves/*] replace deprecated foreach with range for

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> http.cpp:2612
>  qCDebug(KIO_HTTP) << " Sending Header:";
> -Q_FOREACH (const QString , header.split(QStringLiteral("\r\n"), 
> QString::SkipEmptyParts)) {
> +for (const QString  : header.split(QStringLiteral("\r\n"), 
> QString::SkipEmptyParts)) {
>  qCDebug(KIO_HTTP) << s;

need to move that function call into a const local variable

> httpauthentication.cpp:548
>  
> -Q_FOREACH (const QByteArray , valueForKey(m_challenge, 
> "domain").split(' ')) {
> +for (const QByteArray  : valueForKey(m_challenge, "domain").split(' 
> ')) {
>  QUrl u = m_resource.resolved(QUrl(QString::fromUtf8(path)));

same here

> kcookiejar.cpp:348
>  if (updateWindowId) {
> -Q_FOREACH (WId windowId, cookie.windowIds()) {
> +for (WId windowId : cookie.windowIds()) {
>  if (windowId && 
> (!cookiePtr.windowIds().contains(windowId))) {

[that one actually returns a reference so it's actually fine until someone 
changes that...]

> kcookiejar.cpp:1413
>  bool ok;
> -QStringList portList = str.mid(index + 1).split(QL1C(','));
> -Q_FOREACH (const QString , portList) {
> +for ( const QString  : str.mid(index + 1).split(QL1C(',')) ) 
> {
>  const int portNum = portStr.toInt();

Keeps the separate variable, make it const.

Otherwise this will detach.

> kcookieserver.cpp:392
>  QStringList result;
> -Q_FOREACH (const QString , mCookieJar->getDomainList()) {
> +for (const QString  : mCookieJar->getDomainList()) {
>  // Ignore domains that have policy set for but contain

[ok, returns a ref]

> trashimpl.cpp:717
>  filesDir += QLatin1String("/files");
> -Q_FOREACH (const QString , listDir(filesDir)) {
> +for (const QString  : listDir(filesDir)) {
>  if (fileName == QLatin1Char('.') || fileName == 
> QLatin1String("..")) {

needs local var

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24220

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns