D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for your reply, Christian :)
  
  In D23789#538876 , @chehrlic wrote:
  
  > In D23789#536338 , @kossebau 
wrote:
  >
  > > Actual questions I have:
  > >
  > > - why is QT_DEPRECATED_WARNINGS_SINCE not officially documented? like, 
any plans to change that macro to something else?
  >
  >
  > Just forgot it (and also the reviewers) I would guess. There is no plan to 
change it, at least none I'm aware of. I'm looking for an automatic generation 
of this macro.
  
  
  Okay. So will keep it documented as part of public API here then.
  
  > Since Qt6 switches to CMake I can maybe borrow some stuff from you ;)
  
  Sure :) As others commented and what I think as well, this should be even 
candidate for being added to upstream in some variant, once it has proven to 
work out.
  
  >> - why has all Qt code not yet been adapted to 
QT_DEPRECATED_VERSION/QT_DEPRECATED_VERSION_X, are there places where those 
macros should not be used, but the version-less ones?
  > 
  > Because noone wanted to do the work and it was added late in the Qt5 
lifetime -> A lot of stuff was deprecated for a long time already (in Qt4 
times) and there is was a replacement since Qt5.0.0 so the macro was not needed 
(even though a lot of people got very angry about it). I added it for some new 
signals which created a lot of discussion since the old ones are widely used.
  
  Can you point to those discussions? Would be curious to learn what people's 
thought are.
  
  >> - why did you go for both QT_DEPRECATED_VERSION & QT_DEPRECATED_VERSION_X, 
are there places where no message will be wanted?
  > 
  > Just for consistency - we've QT_DEPRECATED and QT_DEPRECATED_X but I think 
QT_DEPRECATED should be deprecated by itself. I hope no reviewer will accept a 
QT_DEPRECATED anymore.
  
  So you would also think that message-less variants will not be needed I 
understand. Okay. From what I tested with experimentally deploying the macros 
on some KF modules I almost always could add a useful message, so running short 
of reasons for keeping a message-less variant :)
  
  > The main problem with the macro is that you have to create a new one for 
each version so it will become lengthy. But I could not find a better solution 
somewhere - in the end it's only macro magic from the 80s... :(
  
  Also had no better idea, but then I am also nowhere a C++ macro magician, I 
operate by manual mostly :) Thankfully with the proposed cmake-generated 
approach here it's more a matter of adding another version to the 
`DEPRECATION_VERSIONS` list, and nobody looks into generated code anyway.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

[David Faure]

dfaure updated this revision to Diff 66975.
dfaure added a comment.


  perl -pi -e 's/buttonOK/buttonOk/g' kmessagebox.*

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24252?vs=66932=66975

BRANCH
  2019_09_okbutton_configurable

REVISION DETAIL
  https://phabricator.kde.org/D24252

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h
  tests/kmessageboxtest.cpp

To: dfaure, cfeck, vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov edited the summary of this revision.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov updated this revision to Diff 66968.
volkov added a comment.


  moved dbus stuff to DBusHelperProxy

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24245?vs=66946=66968

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24245

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/kauth.h
  src/kauthunixfiledescriptor.cpp
  src/kauthunixfiledescriptor.h

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> aacid wrote in HelperProxy.cpp:25
> i don't think we should have dbus stuff in HelperProxy, dbus stuff should be 
> in DBusHelperProxy, no?

yes, thanks

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added a comment.


  yes, thanks

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> HelperProxy.cpp:25
> +
> +#include 
> +#include 

i don't think we should have dbus stuff in HelperProxy, dbus stuff should be in 
DBusHelperProxy, no?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Christian Ehrlicher]

chehrlic added a comment.


  In D23789#536338 , @kossebau wrote:
  
  > Actual questions I have:
  >
  > - why is QT_DEPRECATED_WARNINGS_SINCE not officially documented? like, any 
plans to change that macro to something else?
  
  
  Just forgot it (and also the reviewers) I would guess. There is no plan to 
change it, at least none I'm aware of. I'm looking for an automatic generation 
of this macro. Since Qt6 switches to CMake I can maybe borrow some stuff from 
you ;)
  
  > - why has all Qt code not yet been adapted to 
QT_DEPRECATED_VERSION/QT_DEPRECATED_VERSION_X, are there places where those 
macros should not be used, but the version-less ones?
  
  Because noone wanted to do the work and it was added late in the Qt5 lifetime 
-> A lot of stuff was deprecated for a long time already (in Qt4 times) and 
there is was a replacement since Qt5.0.0 so the macro was not needed (even 
though a lot of people got very angry about it). I added it for some new 
signals which created a lot of discussion since the old ones are widely used.
  
  > - why did you go for both QT_DEPRECATED_VERSION & QT_DEPRECATED_VERSION_X, 
are there places where no message will be wanted?
  
  Just for consistency - we've QT_DEPRECATED and QT_DEPRECATED_X but I think 
QT_DEPRECATED should be deprecated by itself. I hope no reviewer will accept a 
QT_DEPRECATED anymore.
  
  The main problem with the macro is that you have to create a new one for each 
version so it will become lengthy. But I could not find a better solution 
somewhere - in the end it's only macro magic from the 80s... :(
  But for a library such a macro should be mandatory - your blog post explains 
the problem very good.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24263: edit mode action

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> corona.cpp:406
> +} else {
> +editAction->setText(i18n("Edit Widgets"));
> +}

This isn't just editing editing widgets; maybe "Enter Edit Mode" ? That would 
make the name better correspond with the text of the opposite state too.

Alternatives:

- Edit Layout and Widgets/Freeze Layout and Widgets
- Configure Layout and Widgets/Freeze Layout and Widgets
- Configure Layout and Widgets/Finish Configuring Layout and Widgets
- Customize Layout/Finish Customizing Layout

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24263: edit mode action

[Nathaniel Graham]

ngraham added a dependent revision: D24265: support global edit mode.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw added a comment.


  > 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd 
want to do something more like this:
  > 
  > 
  > 
  >   if (plugin == "details"  /* this is pseudocode */) {
  >   q->insertPluginAt(plugin, 1);
  >   } else {
  >   q->insertPlugin(plugin);
  >   }
  > 
  > 
  > I'm actually not sure how to check for what the plugin is though. Maybe 
someone from #frameworks  can help.
  
  This is mostly done but we still need to do this the check, but neither me 
nor @ngraham know how to do it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D24253: Make 22px squiggle more like 16px squiggle

[Noah Davis]

ndavis added a comment.


  In D24253#538662 , @trickyricky26 
wrote:
  
  > Visually I think this is fine and a good improvement.
  >
  > I wonder why your SVGs have two seperate paths as opposed to unifying them 
into one path (as I usually do)? Just curious if there is any benefit to using 
one approach above the other.
  >  Also, judging by the MDN Page 
 I don't 
think the `fill-rule="evenodd"` does anything here.
  
  
  Sometimes the optimizers prefer to group rather than combine. These days, 
optimization is used to keep diffs readable so I can find mistakes and to cut 
down the size most of the way. Optimizing down to the last byte we can get rid 
of is not necessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24239: make editMode a corona global property

[Nathaniel Graham]

ngraham added tasks: T10190: (Re)define modes when editing panels and widgets, 
T11094: Improve discoverability of widget configuration, T10402: The Desktop 
Toolbox.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24239

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

[Nathaniel Graham]

ngraham added tasks: T11094: Improve discoverability of widget configuration, 
T10402: The Desktop Toolbox.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D24263: edit mode action

[Nathaniel Graham]

ngraham added tasks: T10190: (Re)define modes when editing panels and widgets, 
T11094: Improve discoverability of widget configuration, T10402: The Desktop 
Toolbox.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24263: edit mode action

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  needed for the context menu entry

TEST PLAN
  with the p-w- portion the action shows in the context menu

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24262: Modernize code: use range-based loops & algorithms in more places

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  GIT_SILENT

TEST PLAN
  Tests pass, KParts-based apps work as before.

REPOSITORY
  R306 KParts

BRANCH
  morerangebased

REVISION DETAIL
  https://phabricator.kde.org/D24262

AFFECTED FILES
  src/browseropenorsavequestion.cpp
  src/partbase.h
  src/partmanager.cpp
  src/plugin.cpp
  src/scriptableextension.cpp
  src/statusbarextension.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D24252

To: dfaure, cfeck, vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24261: Modernize code: use range-based for loop in more places

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  GIT_SILENT

TEST PLAN
  Test pass, KXMLGUI-based apps showed no regressions incl. editing of
  toolbars & shortcuts

REPOSITORY
  R263 KXmlGui

BRANCH
  morerangebasedforloops

REVISION DETAIL
  https://phabricator.kde.org/D24261

AFFECTED FILES
  src/kaboutapplicationpersonmodel_p.cpp
  src/kedittoolbar.cpp
  src/kgesture.cpp
  src/kmainwindow.cpp
  src/kshortcutseditor.cpp
  src/kswitchlanguagedialog_p.cpp
  src/ktoolbar.cpp
  src/ktoolbarhandler.cpp
  src/kxmlguiclient.cpp
  src/kxmlguifactory_p.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24259: WIP: Save file directly if possible when root privileges are required

[Alexander Volkov]

volkov added a dependency: D24245: Add support for passing Unix file 
descriptors.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24259

To: volkov
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added a dependent revision: D24259: WIP: Save file directly if possible 
when root privileges are required.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24259: WIP: Save file directly if possible when root privileges are required

[Alexander Volkov]

volkov created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
volkov requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24259

AFFECTED FILES
  src/buffer/katesecuretextbuffer.cpp
  src/buffer/katesecuretextbuffer_p.h
  src/buffer/katetextbuffer.cpp
  src/buffer/org.kde.ktexteditor.katetextbuffer.actions

To: volkov
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov updated this revision to Diff 66946.
volkov added a comment.


  fix breaking API and ABI of KAuth::ActionReply

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24245?vs=66905=66946

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24245

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/HelperProxy.cpp
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/kauth.h
  src/kauthunixfiledescriptor.cpp
  src/kauthunixfiledescriptor.h

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D24253: Make 22px squiggle more like 16px squiggle

[TrickyRicky]

trickyricky26 added a comment.


  Visually I think this is fine and a good improvement.
  
  I wonder why your SVGs have two seperate paths as opposed to unifying them 
into one path (as I usually do)? Just curious if there is any benefit to using 
one approach above the other.
  Also, judging by the MDN Page 
 I don't 
think the `fill-rule="evenodd"` does anything here.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:140c0d0b7be8: Bring KNewStuffQuick to feature parity with 
KNewStuff(Widgets) (authored by leinir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21721?vs=66876=66944#toc

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=66876=66944

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.cpp
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/commentsmodel.cpp
  src/qtquick/commentsmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: cfeck, davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

[Christoph Feck]

cfeck added a comment.


  I think it needs to be named 'buttonOk' instead of 'buttonOK'.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D24252

To: dfaure, cfeck, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24254: [KCollapsibleGroupBox] Fix QTimeLine::start warning at runtime

[Christoph Feck]

cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  2019_09_fix_qtimeline_warning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24254

To: dfaure, cfeck, ngraham, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Right, unless i hear otherwise, i'm going to push this 13:00 CEST (that is, 
in three hours). I realise this is short notice, but the patch has also been 
sitting here since before Akademy.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: cfeck, davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns