KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.12 - Build # 5 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 04 Oct 2019 05:13:16 +
 Build duration:
9 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Contacts-5.63.0.xmlcompat_reports/KF5Contacts_compat_report.htmllogs/KF5Contacts/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.kcontacts_testroundtrip
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)83%
(68/82)83%
(68/82)78%
(8574/11054)52%
(2985/5784)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(32/32)100%
(32/32)99%
(4298/4308)52%
(1033/1974)src82%
(31/38)82%
(31/38)65%
(3605/5569)51%
(1527/3001)src.converter100%
(2/2)100%
(2/2)73%
(331/455)57%
(221/386)src.generator0%
(0/3)0%
(0/3)0%
(0/153)0%
(0/76)src.vcardparser100%
(3/3)100%
(3/3)86%
(340/397)79%
(204/259)tests0%
(0/4)0%
(0/4)0%
(0/172)0%
(0/88)

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 5 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/5/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 04 Oct 2019 05:13:16 +
 Build duration:
6 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Contacts-5.63.0.xmlcompat_reports/KF5Contacts_compat_report.htmllogs/KF5Contacts/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.kcontacts_testroundtrip
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)83%
(68/82)83%
(68/82)78%
(8574/11054)52%
(2985/5784)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(32/32)100%
(32/32)99%
(4298/4308)52%
(1033/1974)src82%
(31/38)82%
(31/38)65%
(3605/5569)51%
(1527/3001)src.converter100%
(2/2)100%
(2/2)73%
(331/455)57%
(221/386)src.generator0%
(0/3)0%
(0/3)0%
(0/153)0%
(0/76)src.vcardparser100%
(3/3)100%
(3/3)86%
(340/397)79%
(204/259)tests0%
(0/4)0%
(0/4)0%
(0/172)0%
(0/88)

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.13/5/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 04 Oct 2019 05:13:16 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.kcontacts_testroundtrip

D24318: Make 32px document-save icon colorful

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

[Nathaniel Graham]

ngraham updated this revision to Diff 67298.
ngraham added a comment.


  Use a nicer color for the label

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24318?vs=67263=67298

BRANCH
  colorful-32px-save-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24318

AFFECTED FILES
  icons-dark/actions/32/document-save.svg
  icons/actions/32/document-save.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24354: Mustache/Handlebars: minor fixes

[Nibaldo González]

nibags added a comment.


  As the delimiters in WordDetect rules were changed in D24378 
, I updated this diff only by making minor 
fixes in the Mustache/Handlebars definition.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: minor fixes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: minor fixes

[Nibaldo González]

nibags retitled this revision from "Mustache/Handlebars: fix delimiters in HTML 
tags" to "Mustache/Handlebars: minor fixes".

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Nibaldo González]

nibags updated this revision to Diff 67297.
nibags added a comment.


  Minor corrections:
  
  - Restore WordDetect rules
  - Use **kateversion="5.44"** (WordDetect with insensitive).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24354?vs=67161=67297

BRANCH
  fix-delimiters-mustache

REVISION DETAIL
  https://phabricator.kde.org/D24354

AFFECTED FILES
  autotests/folding/test.mustache.fold
  autotests/html/test.mustache.html
  autotests/input/test.mustache
  autotests/reference/test.mustache.ref
  data/syntax/mustache.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24378

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24400: Make hours qint64

[Ömer Fadıl Usta]

usta added inline comments.

INLINE COMMENTS

> kformatprivate.cpp:339
>  
> -int hours = ms / MSecsInHour;
> +const qint64 hours = ms / MSecsInHour;
>  ms = ms % MSecsInHour;

why dont we use quint64  in here ?

> kformatprivate.cpp:470
>  quint64 ms = msecs;
>  int days = ms / MSecsInDay;
>  ms = ms % (MSecsInDay);

same problem here ( quint64 days and hours ) ( maybe not days but hours )
also days, hours , minutes  and seconds also can be conts in here too

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24400

To: aacid
Cc: usta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24010: Fix generating properties that start with an uppercase letter

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:a23acd2f1535: Fix generating properties that start with 
an uppercase letter (authored by apol).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24010?vs=67204=67294

REVISION DETAIL
  https://phabricator.kde.org/D24010

AFFECTED FILES
  autotests/kconfig_compiler/test13.cpp.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test13.kcfg
  src/kconfig_compiler/kconfig_compiler.cpp

To: apol, #frameworks, davidedmundson
Cc: ngraham, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Luigi Toscano]

ltoscano added a comment.


  Can you please at least remove the steam example from the commit message, as 
it is not relevant (it is a downstream change) and remove the reference to the 
bug?
  Does it also mean that kf5-toys.directory is not used anymore? (not sure 
whether it can't be removed anyway for compatibility?)

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Albert Astals Cid]

aacid added a comment.


  I don't appreciate the flippant and dismissive attitude in that comment. I 
would ask that you interact with more respectfulness. Thanks.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D24384#541646 , @aacid wrote:
  
  > Really? toys are only for children and adults should be ashamed to play 
with toys? Come on, i thought we were past that.
  
  
  Maybe it's different in your native language and country. But in English, and 
in the USA, there's a clear stigma to describing something not designed to be a 
children's plaything as a toy.
  
  I don't appreciate the flippant and dismissive attitude in that comment. I 
would ask that you interact with more respectfulness. Thanks.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24402: [PlasmaComponents3] Fix checkable toolbutton background

[Nathaniel Graham]

ngraham added a dependent revision: D24407: Increase UI commonality between KCM 
and applet.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24402

To: ngraham, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24406: Small performance improvements suggested by clang tidy

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24406

AFFECTED FILES
  src/externalextractor.cpp
  src/externalwriter.cpp
  src/extractorcollection.cpp
  src/mimeutils.cpp

To: aacid
Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24405: Small performance improvements suggested by clang-tidy

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24405

AFFECTED FILES
  src/engine/enginequery.cpp
  src/engine/enginequery.h
  src/engine/idtreedb.cpp
  src/engine/idtreedb.h

To: aacid
Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24404: Small performance improvements suggested by clang-tidy

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
aacid requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24404

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: aacid
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24010: Fix generating properties that start with an uppercase letter

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24010

To: apol, #frameworks, davidedmundson
Cc: ngraham, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24403: Small performance improvements suggested by clang-tidy

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
aacid requested review of this revision.

REVISION SUMMARY
  As far as i can see none of the modified .h files is actually public so
  that shouldn't be a BC problem

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24403

AFFECTED FILES
  src/completion/expandingtree/expandingwidgetmodel.cpp
  src/completion/katecompletionmodel.cpp
  src/completion/katecompletionmodel.h
  src/completion/katecompletionwidget.cpp
  src/document/editorconfig.cpp
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/render/katerenderrange.cpp
  src/render/katetextlayout.cpp
  src/schema/katestyletreewidget.cpp
  src/script/katecommandlinescript.cpp
  src/script/katecommandlinescript.h
  src/search/katesearchbar.cpp
  src/utils/attribute.cpp
  src/utils/katecmd.cpp
  src/utils/kateglobal.cpp
  src/utils/variable.cpp
  src/view/katemessagewidget.cpp
  src/view/katestatusbar.cpp
  src/view/katetextanimation.cpp
  src/view/kateview.cpp
  src/view/kateviewinternal.cpp
  src/vimode/command.cpp
  src/vimode/command.h
  src/vimode/modes/modebase.cpp
  src/vimode/modes/modebase.h

To: aacid
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24402: [PlasmaComponents3] Fix checkable toolbutton background

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This fixed the background of a checkable PC3 ToolButton not being visible 
when checked.
  The PC3 Button and PC2 ToolButton did not suffer from the issue, but the PC3 
one did.

TEST PLAN
  Checkable PC3 ToolButtons now look checked when checked
  
  No change for non-checkable PC3 ToolButtons

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-checkable-pc3-toolbutton-background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24402

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: ngraham, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/36/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 03 Oct 2019 21:19:17 +
 Build duration:
2 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D24399: Pass QDir by const & instead of copy

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24399

To: aacid, dhaumann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 107 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/107/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 03 Oct 2019 21:07:05 +
 Build duration:
9 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys

D24399: Pass QDir by const & instead of copy

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24399

To: aacid, dhaumann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24401: Use exposed DBus methods to switch activities in CLI

[Christian Muehlhaeuser]

muesli added a comment.


  Careful: we must _not_ land this before the next Plasma release.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D24401

To: muesli, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24401: Use exposed DBus methods to switch activities in CLI

[Christian Muehlhaeuser]

muesli created this revision.
muesli added a reviewer: ivan.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
muesli requested review of this revision.

REVISION SUMMARY
  Since https://phabricator.kde.org/D22381 has landed kactivitymanagerd
  now exposes methods to switch to the previous/next activity via DBus.
  
  We can call them from kactivities-cli and remove some duplicated code.

REPOSITORY
  R6 KActivities

BRANCH
  cli-nextprev-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24401

AFFECTED FILES
  src/cli/main.cpp
  src/lib/controller.cpp
  src/lib/controller.h

To: muesli, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24400: Make hours qint64

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  msec is qint64 and pretty sure the biggest qint64 / 360 still doesn't fit 
in an integer

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24400

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24399: Pass QDir by const & instead of copy

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24399

AFFECTED FILES
  src/lib/util/klistopenfilesjob_unix.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Dominik Haumann]

dhaumann added a comment.


  @graesslin pong? One year passed.

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Dominik Haumann]

dhaumann added a comment.


  I think it's fine as is. The docbook says:
  
Detect an exact string but additionally require word boundaries
such as a dot '.' or a whitespace on the beginning
and the end of the word. Think of \bstring\b
in terms of a regular expression, but it is faster than the rule 
RegExpr.
  
  Imo `\bstring\b` implies that if a string 
itself starts/ends with a \b character, then this should match as well. And 
given our unit tests do not show any changes, I think we are good to go.
  
  Please commit.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-worddetect

REVISION DETAIL
  https://phabricator.kde.org/D24378

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24398: Rewrite ugly for with pointer arithmetic into range for

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24398

To: aacid, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23266: Export Plasma core lib log category, add a category to a qWarning

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  Go for it, can change later too.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D23266

REVISION DETAIL
  https://phabricator.kde.org/D23266

To: meven, #frameworks, broulik, davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24398: Rewrite ugly for with pointer arithmetic into range for

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24398

To: aacid, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[René J . V . Bertin]

rjvbb added a comment.


  And my point is that you are doing 720 translations and 360 rotations per 
cycle, with subsequent smoothing of an image, continuously and with sufficient 
temporal resolution to get a fluid animation that is completely overkill here. 
Indicating a busy state (a two-state entity) is not the same as indicating 
progress and could be done by something like a stoplight changing colour.
  
  User experience ... do you seriously expect anyone to judge KDE on this sort 
of thing (that'd be like judging a service provider on the waiting music they 
stuff down your ears while you're on hold). Maybe among the angry teenager 
crowd who spend most of their computer time customising the looks of their 
desktops ... and possibly the designers of the fake interfaces you see in yet 
another CSI-like series.
  
  In my book an interface shouldn't get in the way, neither in its use of space 
nor in terms of required computing resources, and should continue to be 
responsive even if the system is swamped doing the actual work I gave it t do. 
FWIW, even Apple have made more and more of the the animations introduced after 
iOS 6 optional because they killed the actual user experience on all but the 
latest iDevices (as well as battery life).
  
  I'm not blaming Q*Animation, and I don't think anything is inherently wrong 
with it (apart possibly from an apparent lack of control over 
granularity/temporal resolution). That lack does make it the wrong tool IMHO.
  
  I'm tinkering with an implementation that follows my idea of storing the 
calculated rotated icons in a QVector, using the answer to this question 
(https://stackoverflow.com/questions/4665606/rotate-image-in-qt). That should 
remove the computational overhead after the first animation cycle and give the 
same wonderful user experience as the current implementation. If it doesn't 
decrease the CPU overhead then maybe indeed there's a problem with Q*Animation 
in the Qt version I'm using.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Albert Astals Cid]

aacid added a comment.


  Lol it's opensuse being silly, oh well.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Albert Astals Cid]

aacid added a comment.


  Really? toys are only for children and adults should be ashamed to play with 
toys? Come on, i thought we were past that.
  
  Anyway, i'm really confused now, does your Stream have the Amusement category?
  
  Because the steam.desktop from 
http://repo.steampowered.com/steam/pool/steam/s/steam/steam_1.0.0.61.tar.gz says
  
Categories=Network;FileTransfer;Game;
  
  Which Steam version are you running?
  
  No, i don't know of any app that we have (or otherwise) that uses the 
Amusement category

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24389: Fix klistopenfilesjob header file not being installed

[David Faure]

dfaure added a comment.


  `git tag` doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so 
this commit will be included.
  
  (I do that on the first Saturday of the month)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  I agree with @guoyunhe. "Toys" isn't an appropriate word to use in the 
context of computers and software. From a native English speaker's perspective 
here, a toy is something physical that you give to children. Using the word to 
describe something anything else is actually insulting to that thing ("don't 
use that app, it's a toy compared to this other one") and by extension, the 
people who created it.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24390: Add more file and directories to exclude filters

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ognarb wrote in fileexcludefilters.cpp:137
> This directory contains only pure PHP code, so not possible by filename or 
> minetype. Maybe we could use the fact that a composer.json is always included 
> in the same directory?

PHP source code files are already supposed to be getting excluded though 
(search for `application/x-php` in this file). Are the PHP files in question 
using a different mime type?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24390

To: ognarb, #baloo, ngraham
Cc: ngraham, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24398: Rewrite ugly for with pointer arithmetic into range for

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24398

AFFECTED FILES
  src/gui/kstandardshortcut.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Yunhe Guo]

guoyunhe added a comment.


  In D24384#541589 , @aacid wrote:
  
  > Have you contacted Valve to tell them amusement is the wrong category for 
Steam?
  >
  > Because the spec says Amusement - > a simple amusement
  >
  > And that's not what steam is
  >
  > IMHO this patch is wrong and steam is what needs fixing.
  
  
  Dispite what Steam belongs to, "a simple amusement" should not be named 
"toys". Do we have any applications or games that are "toys"?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/35/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 03 Oct 2019 17:15:18 +
 Build duration:
1 min 59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D24389: Fix klistopenfilesjob header file not being installed

[David Hallas]

hallas added a comment.


  In D24389#541539 , @ngraham wrote:
  
  > Please land this ASAP so it gets into Frameworks 5.63.
  
  
  Landed it now, is there anything else I need to do so that it makes the 5.63 
release?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24389: Fix klistopenfilesjob header file not being installed

[David Hallas]

hallas closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24395: Add some std::move in setter functions

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Looks good :) If you could pop in a TODO KF6 comment, so it's not forgotten 
when we can, in fact, fix it properly, that'd be great :)

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24395

To: aacid, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24395: Add some std::move in setter functions

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  typically we pass the param as const &, but here we forgot, we can fix
  that problem by adding an std::move and have a very similar effect to if
  we had declared the params as const &

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24395

AFFECTED FILES
  src/comment.cpp
  src/content.cpp
  src/forum.cpp
  src/knowledgebaseentry.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23266: Export Plasma core lib log category, add a category to a qWarning

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D23266

REVISION DETAIL
  https://phabricator.kde.org/D23266

To: meven, #frameworks, broulik, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23266: Export Plasma core lib log category, add a category to a qWarning

[Méven Car]

meven added a comment.


  ping @apol

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23266

To: meven, #frameworks, broulik
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Albert Astals Cid]

aacid added a comment.


  Have you contacted Valve to tell them amusement is the wrong category for 
Steam?
  
  Because the spec says Amusement - > a simple amusement
  
  And that's not what steam is
  
  IMHO this patch is wrong and steam is what needs fixing.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24388: Mark technology propertie as constant to avoid warning

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:edb12de9490e: Mark technology propertie as constant to 
avoid warning (authored by meven).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24388?vs=67260=67266

REVISION DETAIL
  https://phabricator.kde.org/D24388

AFFECTED FILES
  src/solid/devices/frontend/battery.h

To: meven, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24390: Add more file and directories to exclude filters

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> ngraham wrote in fileexcludefilters.cpp:137
> This one makes me a little nervous since it's a not-very-uncommon English 
> word, not something implicitly technical that we can be safe excluding.
> 
> Is there any other way we could exclude the contents of these folders? Maybe 
> by filename, mimetype, or the naming of sub-folders?

This directory contains only pure PHP code, so not possible by filename or 
minetype. Maybe we could use the fact that a composer.json is always included 
in the same directory?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24390

To: ognarb, #baloo, ngraham
Cc: ngraham, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24389: Fix klistopenfilesjob header file not being installed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Please land this ASAP so it gets into Frameworks 5.63.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24390: Add more file and directories to exclude filters

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fileexcludefilters.cpp:109
>  
>  const int s_defaultFileExcludeFiltersVersion = 5;
>  

Gotta bump this number whenever you change `s_defaultFileExcludeFilters`

> fileexcludefilters.cpp:137
>  "nbproject",
> +"vendor", // composer installed php libs default directory
>  

This one makes me a little nervous since it's a not-very-uncommon English word, 
not something implicitly technical that we can be safe excluding.

Is there any other way we could exclude the contents of these folders? Maybe by 
filename, mimetype, or the naming of sub-folders?

> fileexcludefilters.cpp:147
>  
>  const int s_defaultFolderExcludeFiltersVersion = 2;
>  

Gotta bump this number whenever you change `s_defaultFolderExcludeFilters`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24390

To: ognarb, #baloo, ngraham
Cc: ngraham, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24390: Add more file and directories to exclude filters

[Carl Schwan]

ognarb added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24390

To: ognarb, #baloo
Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24390: Add more file and directories to exclude filters

[Carl Schwan]

ognarb created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
ognarb requested review of this revision.

TEST PLAN
  None for the moment

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24390

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ognarb
Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24389: Fix klistopenfilesjob header file not being installed

[Méven Car]

meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24389: Fix klistopenfilesjob header file not being installed

[David Hallas]

hallas created this revision.
hallas added reviewers: dfaure, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  The header file KListOpenFilesJob and klistopenfilesjob.h was not being
  installed

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24389

AFFECTED FILES
  src/lib/CMakeLists.txt

To: hallas, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/22/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 03 Oct 2019 14:27:28 +
 Build duration:
1 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D24318: Make 32px document-save icon colorful

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

[Nathaniel Graham]

ngraham updated this revision to Diff 67263.
ngraham added a comment.


  Update according to review comments

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24318?vs=67083=67263

BRANCH
  colorful-32px-save-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24318

AFFECTED FILES
  icons-dark/actions/32/document-save.svg
  icons/actions/32/document-save.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24388: Mark technology propertie as constant to avoid warning

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24388

To: meven, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24388: Mark technology propertie as constant to avoid warning

[Méven Car]

meven created this revision.
meven added reviewers: davidedmundson, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  To avoid output such as :
  
QQmlExpression: Expression 
file:///home/meven/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/main.qml:479:29
 depends on non-NOTIFYable properties:
Solid::Battery::technology
  
  Similar to D23598 

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24388

AFFECTED FILES
  src/solid/devices/frontend/battery.h

To: meven, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Harald Sitter]

sitter added a comment.


  My point is that your lamentations have nothing to do with this class but 
with Q*Animation on your system. So you need to find out what's wrong and talk 
to Qt. I am 100% against a workaround that degrades the user experience when 
the bug isn't even in this class.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
GB_2, michaelh, bruns

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-worddetect

REVISION DETAIL
  https://phabricator.kde.org/D24378

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Christoph Cullmann]

cullmann added a comment.


  Seems reasonable, do we need some doc updates? Or some more verbose 
description in the XSD?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24378

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24387: improve error reporting for when kpasswdserver is unreachable

[Nathaniel Graham]

ngraham added reviewers: Frameworks, dfaure.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D24387

To: sitter, #frameworks, dfaure
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24387: improve error reporting for when kpasswdserver is unreachable

[Harald Sitter]

sitter created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously we'd not forward the errors coming out of the password dialog
  helper and instead eventually end up on generic access denied errors.
  seeing as the access denied is likely because we couldn't query auth info
  that is fairly misleading.
  
  checkPassword is now returning an error code instead of a bool. when we
  actually consider checkPassword an error we'll now raise this error
  instead of the generic access denied errors. when the user canceled
  the query we'll continue to raise the more topical error from smb (e.g.
  "access denied")
  
  primarily these errors appear when kiod/kpasswdserver is defunct
  or not installed meaning query functionality will not work at all.

TEST PLAN
  1. broken kiod
  2. remove dbus service file
  3. kill
  4. dolphin smb://host
  5. no auth query
  6. error about broken dialog
  
  1. cancel
  2. repair kiod
  3. dolphin smb://host
  4. auth query
  5. cancel
  6. auth query
  7. cancel
  8. error about access denied (because refused to authenticate)

REPOSITORY
  R320 KIO Extras

BRANCH
  Applications/19.08

REVISION DETAIL
  https://phabricator.kde.org/D24387

AFFECTED FILES
  smb/kio_smb.h
  smb/kio_smb_auth.cpp
  smb/kio_smb_browse.cpp
  smb/kio_smb_mount.cpp

To: sitter
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[René J . V . Bertin]

rjvbb added a comment.


  In D22375#541399 , @sitter wrote:
  
  > The demo doesn't even use this widget
  
  
  That wasn't the question I answered by referring to oxygen-demo
  
  > breeze
  >  F7506213: Peek 2019-10-03 13-46.gif 
  > 
  > oxygen
  >  F7506215: Peek 2019-10-03 13-45.gif 
  
  The fact you are seeing much lower loads on your machine doesn't mean that no 
machine is going to be slowed down by this widget or other comparably "useful" 
animations. For all we know you have a rig with 256 cores so you're not going 
to notice if one of those is  used at even near 100% for a bit of eye candy.
  
  Also, I prefer to use lower level measuring tools that interfere less with 
the system being measured than a fancy tool like ksysguard - and guess what: 
top gives me a completely different reading:
  F7506717: sysload1.png 
  
  I'd do the same snapshot for `kbusyindicatorwidgettest` but I'd have to 
recompile KWidgetsAddons without my tweak first :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
GB_2, michaelh, bruns

D24263: edit mode action

[Björn Feber]

GB_2 resigned from this revision.
This revision now requires review to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24012: Supress mouse events in KCMs causing window moves

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit R295:8f0858eb79a9: Supress mouse events in KCMs causing window 
moves (authored by davidedmundson).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24012?vs=66274=67253

REVISION DETAIL
  https://phabricator.kde.org/D24012

AFFECTED FILES
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: davidedmundson, #plasma, romangg
Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Harald Sitter]

sitter added a comment.


  The demo doesn't even use this widget
  
  breeze
  F7506213: Peek 2019-10-03 13-46.gif 
  
  oxygen
  F7506215: Peek 2019-10-03 13-45.gif 

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
GB_2, michaelh, bruns

D24263: edit mode action

[Björn Feber]

GB_2 accepted this revision as: VDG, GB_2.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

[Björn Feber]

GB_2 added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Dominik Haumann]

dhaumann added a comment.


  This looks good to me and as mentioned in D24354 
 WordDetect is better than RegExpr.
  
  +1, but I'd like another review by @cullmann or @vkrause.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24378

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24384: Move Amusement to Games directory instead of Games > Toys

[Yunhe Guo]

guoyunhe updated this revision to Diff 67252.
guoyunhe added a comment.


  Fix tabs

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67251=67252

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Yunhe Guo]

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  The Amusement category doesn't mean it is about toys. For example, Steam, the 
gaming platform and store, isn't about toys.
  
  BUG 412553

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[René J . V . Bertin]

rjvbb added a comment.


  >   Does it happen with every code that uses QPropertyAnimation, or just with 
this KBusyIndicator?
  
  I don't know, neither for QVariantAnimation (which is used here).
  
  Testing just now (on the N3150 machine) with the Sliders page of the 
oxygen-demo app I get between 30% and 35% CPU (!) with Fusion, Breeze and 
Oxygen (which all use something based on QAbstractAnimation). QtCurve uses an 
internal, QTimer-based implementation that uses about half that (still too much 
I realise now).
  
  I should add that I use a traditional icon theme, pixmap instead of svg 
based. Rotating pixmaps is maybe much more expensive than rotating and svg, and 
both probably depend on how much of it is done in vector intrinsics.
  
  Traditionally, this kind of animation used either pre-calculated frames (cf. 
the busy cursors) or else colourmap animation (which is *very* cheap). The 
latter is not going to be feasible here but building table (QVector?) of a 
reasonable number of pre-rotated pixmaps and looping over that should be 
possible (can even be done "online" by caching the frames as you display them). 
Of course my current workaround is a lot easier and should be fine a long as 
the animation doesn't run on the same thread as the actually busy one.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
GB_2, michaelh, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Harald Sitter]

sitter added a comment.


  F7505620: Peek 2019-10-03 12-23.gif 

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
GB_2, michaelh, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Christoph Feck]

cfeck added a comment.


  Does it happen with every code that uses QPropertyAnimation, or just with 
this KBusyIndicator?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
GB_2, michaelh, bruns

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24382

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24294

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  The implementation is still done in terms of KSslError, swapping that is
  one of the next steps.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24382

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslcertificatemanager.h

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 114 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/114/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 03 Oct 2019 08:20:59 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/7/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 03 Oct 2019 08:26:42 +
 Build duration:
9 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: 

D24160: [KIO] Modernize the code to use range-for in more places

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24160

To: dfaure, bruns, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[René J . V . Bertin]

rjvbb added a comment.


  I'll repeat here what I muttered on the associated commit page:
  
  This widget adds a lot of CPU overhead, too much IMHO: the dedicated test 
tool runs at a bit over 10%CPU, and that is not counting the additional 
overhead from the displaying layers (X server, the Mac WindowServer, etc). This 
overhead appears to scale with the CPU: it's in the same order of magnitude on 
my lowly N3150 Linux machine as on my (older but still) much faster Mac that 
has an i7.
  
  Adding a simple
  
animation.thread()->mSleep(250);
  
  after the `q->update();` line does make the animation a bit choppier but 
reduces the test tool's CPU load to under 1%.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
GB_2, michaelh, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 67242.
meven marked 4 inline comments as done.
meven added a comment.


  Better variable naming

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=67241=67242

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 67241.
meven added a comment.


  Make bookmarkForUrl const, add context to translate Recent

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=67203=67241

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Nibaldo González]

nibags updated this revision to Diff 67238.
nibags added a comment.


  - Add comment

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24378?vs=67237=67238

BRANCH
  fix-worddetect

REVISION DETAIL
  https://phabricator.kde.org/D24378

AFFECTED FILES
  autotests/folding/delimiters_WordDetect.delWordDetect.fold
  autotests/html/delimiters_WordDetect.delWordDetect.html
  autotests/input/delimiters_WordDetect.delWordDetect
  autotests/input/syntax/delimiters_WordDetect.xml
  autotests/reference/delimiters_WordDetect.delWordDetect.ref
  data/syntax/elm.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  src/lib/rule.cpp

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Nibaldo González]

nibags added a comment.


  i did it in: D24378 

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, 
vkrause, jpoelen.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  In WordDetect rules, verify delimiter characters also on the right and left 
edges inside the string.
  
  For example:
  

  
  In the past, this rule was equivalent to `\bhttps://phabricator.kde.org/D24378

AFFECTED FILES
  autotests/folding/delimiters_WordDetect.delWordDetect.fold
  autotests/html/delimiters_WordDetect.delWordDetect.html
  autotests/input/delimiters_WordDetect.delWordDetect
  autotests/input/syntax/delimiters_WordDetect.xml
  autotests/reference/delimiters_WordDetect.delWordDetect.ref
  data/syntax/elm.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  src/lib/rule.cpp

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24326: Add syntax highlighting for RenPy (.rpy)

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  renpy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24326

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Dominik Haumann]

dhaumann added a comment.


  Thanks a lot!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann