KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 117 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/117/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 05 Oct 2019 05:43:45 +
 Build duration:
8 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_kfileplacesmodeltestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#542055 , @ngraham wrote:
  
  > I think you can go for it. :) Tagging is tomorrow, so please do!
  
  
  Just landed ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e65bf3bc541a: [Places panel] Revamp the Recently Saved 
section (authored by ngraham, committed by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=67242=67333

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 116 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/116/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 05 Oct 2019 03:13:09 +
 Build duration:
8 min 23 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 05 Oct 2019 03:12:44 +
 Build duration:
4 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D24415: Add standard icons to support to all entries in QDialogButtonBox

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> kstyle.cpp:428
> +case QStyle::SP_DialogSaveAllButton:
> +return QIcon::fromTheme(QStringLiteral("document-save"));
> +case QStyle::SP_DialogAbortButton:

why not `document-save-all`?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24416: Declare Calendar::Ptr as metatype

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, vkrause.
nicolasfella requested review of this revision.

REVISION SUMMARY
  I need this for usage in Calindori

BRANCH
  metatype

REVISION DETAIL
  https://phabricator.kde.org/D24416

AFFECTED FILES
  autotests/createref.sh
  autotests/createtestcases.pl
  autotests/runsingletestcase.pl
  src/calendar.h

To: nicolasfella, #frameworks, vkrause

Re: Framework for encrypted storage for apps

[Albert Astals Cid]

El divendres, 4 d’octubre de 2019, a les 18:53:15 CEST, Johan Ouwerkerk va 
escriure:
> Hi all,
> 
> Bhushan asked me to kick off a discussion on frameworks-devel about a
> problem we face for otpclient. We are looking for help in deciding how
> to best implement storage of the secrets which are needed by the app.
> Any insights from people who are more familiar with frameworks would
> be much appreciated!

Would qca be something like what you're looking for?

I.e. something you do cryptography in-app?

Cheers,
  Albert

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 108 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/108/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 04 Oct 2019 21:56:38 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D24403: Small performance improvements suggested by clang-tidy

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24403

To: aacid, cullmann, dhaumann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

D24403: Small performance improvements suggested by clang-tidy

[Albert Astals Cid]

aacid requested review of this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Ok, i'll commit it then :)

INLINE COMMENTS

> cullmann wrote in modebase.cpp:333
> Hmm, given that is a local var on the stack, I don't see an issue with this.
> This would only be problematic with some static var, or?

right is a local var ^_^ i got confused by a similar-ish patch in qtbase where 
the qregexp was passed in.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24403

To: aacid, cullmann, dhaumann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

D24415: Add standard icons to support to all entries in QDialogButtonBox

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> kstyle.cpp:422
>  }
> +#if QT_VERSION >= 0x050E00 // Check if Qt version >= 5.14
> +case QStyle::SP_DialogYesToAllButton:

Instead of 0x050E00 you could use the macro QT_VERSION_CHECK(5, 14, 0). This 
would be a bit more self explanatory.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24403: Small performance improvements suggested by clang-tidy

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.


  I also think it's fine. A next patch could convert the QRegExp to a 
QRegularExpression.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24403

To: aacid, cullmann, dhaumann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

Framework for encrypted storage for apps

[Johan Ouwerkerk]

Hi all,

Bhushan asked me to kick off a discussion on frameworks-devel about a
problem we face for otpclient. We are looking for help in deciding how
to best implement storage of the secrets which are needed by the app.
Any insights from people who are more familiar with frameworks would
be much appreciated!

To give a bit of context: otpclient is an app (flatpak) to generate
two factor authentication login codes, similar to Google
Authenticator. One thing the app needs to do is to store the 'secret'
associated with each configured account securely, because the security
of the 2FA relies on it. Effectively, this bit of data is just as
sensitive as the main password to the account.

Right now otpclient does not yet implement this (securely) and one
reason for that is we are still not sure how we should do this in a
KDE context. I suppose from our perspective the main questions are:

 1. What Qt or KDE framework is appropriate for this?
 2. If there is no such framework, then what KDE technology could
possibly serve as the basis for such a library? And should it become
part of frameworks?
 3. How should this work? In particular in the context of apps such as flatpaks?

We are aware that KWallet ant Qt Keychain exist but we have some concerns there:

 1. (On KDE) these libraries wind up calling dbus. We would like to
avoid plain text out-of-process communication of secrets, especially
communication through a 'shared' channel (for obvious reasons).
 2. In particular with KDE Wallet it was suggested that the wallet
itself may, in fact, not be encrypted.

Another possible contender is Plasma Vault, but we don't really know
how that would work in the context of an app, especially a flatpak
app.

Ideally we could use something that offers the following:

 1. Operating on encrypted files, which are encrypted and decrypted on
the fly. This would facilitate an easy import/export scheme for the
app (backups!), and should also work in the context of flatpaks.
 2. Ideally while being unopinionated about what is stored "inside"
the encrypted file
 3. Easy to present to the user in terms of UX. It should not be
necessary to do some kind of local setup first before being able to
use the app, the otpclient should work as secure as we can make it out
of the box.
 4. Consumed as a library which does not need to 'talk' over unsecured
channels. This would help avoid leaking secrets and make it easier for
otpclient to control the lifetime of secrets held in memory. I.e. we
would be able to flush secrets if we detect that the computer is about
to suspend or on idling for too long.

In particular we do not need lots of system integration, and we do not
necessarily have to be super portable yet.

So with all that said: what do you think? How should we tackle this?
Can KDE offer framework level support for this? And if so, what would
be the framework for that?

D24415: Add standard icons to support to all entries in QDialogButtonBox

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 398973
  Implement the new enumarations introduced in Qt 5.14: 
https://codereview.qt-project.org/c/qt/qtbase/+/254494/

TEST PLAN
  Can't really test since Qt 5.14 is not released yet, but QDialogButtonBox 
buttons should now all have icons.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: GB_2, #frameworks, #vdg
Cc: #vdg, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

[Björn Feber]

GB_2 added a reviewer: davidedmundson.
GB_2 added a subscriber: davidedmundson.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, #vdg, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24403: Small performance improvements suggested by clang-tidy

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  I think this is ok to merge, I don't see the issue with the QRegExp. (I 
understand that it stores it result in mutable data in the object, but that 
patch didn't alter this, just avoids the copying of the regex before this 
happens, or do I misread the diff?)

INLINE COMMENTS

> aacid wrote in modebase.cpp:333
> This is wrong, QRegExp is broken and lastIndexIn modifies the object even if 
> the function is marked as const

Hmm, given that is a local var on the stack, I don't see an issue with this.
This would only be problematic with some static var, or?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24403

To: aacid, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D24404: Small performance improvements suggested by clang-tidy

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24404

To: aacid, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24405: Small performance improvements suggested by clang-tidy

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24405

To: aacid, meven
Cc: meven, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D24400: Make hours qint64

[Albert Astals Cid]

aacid planned changes to this revision.
aacid added inline comments.

INLINE COMMENTS

> usta wrote in kformatprivate.cpp:339
> why dont we use quint64  in here ?

because its unnecessary, qint64 / number don't need a quint64 to store it.

> usta wrote in kformatprivate.cpp:470
> same problem here ( quint64 days and hours ) ( maybe not days but hours )
> also days, hours , minutes  and seconds also can be conts in here too

true, i wonder why the checker didn't complain for this one, will update

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24400

To: aacid
Cc: usta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24406: Small performance improvements suggested by clang tidy

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:f510f3eca6a0: Small performance improvements suggested by 
clang tidy (authored by aacid).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24406?vs=67291=67328

REVISION DETAIL
  https://phabricator.kde.org/D24406

AFFECTED FILES
  src/externalextractor.cpp
  src/externalwriter.cpp
  src/extractorcollection.cpp
  src/mimeutils.cpp

To: aacid, mgallien
Cc: mgallien, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D24412: Add edit-line-width icons

[Noah Davis]

ndavis added a comment.


  I think something similar to this line width icon would work well: F6304104: 
Lines.png 
  Inkscape uses a similar icon, but for all line styles: F7517386: 
Screenshot_20191004_143517.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  I think you can go for it. :) Tagging is tomorrow, so please do!

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  Any new feedback ?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "RFC: Add ECMGenerateExportHeaders, for 
improved handling of deprecated API" to "Add ECMGenerateExportHeaders, for 
improved handling of deprecated API".

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23902: [KCoreDirLister] replace deprecated foreach with range-for

[Ahmad Samir]

ahmadsamir added a comment.


  In D23902#542046 , @dfaure wrote:
  
  > In D23902#542037 , @ahmadsamir 
wrote:
  >
  > > In D23902#542026 , @dfaure 
wrote:
  > >
  > > > For the record, JFBastien was actually wrong. Calling .begin() on a 
const return value does call the const overload. Testcase 
http://www.davidfaure.fr/kde/const_retval.cpp
  > >
  > >
  > > That looks like a failure in communication, either one of you _assumed_ 
something but didn't tell the other. :D
  >
  >
  > You and I are both entitled to our own opinion, I know what I asked and 
what the reply was :-P
  >  (I tried to reach him afterwards via linkedin and cppcon slack, no success)
  >
  > >> But returning const QList would inhibit move semantics, e.g. `QList 
mylist = foo();` copies instead of moving.
  > >>  So yeah, better not do that.
  > > 
  > > And it would detach (I don't know why it feels like detaching for Qt 
containers is like a sword hanging over all, especially new, developers' heads; 
so implicit sharing is great, except you have to worry about the container 
detaching for the rest of its natural life... :)).
  >
  > No, a copy doesn't detach. A non-const method call on a copy detaches.
  
  
  See? I actually was talking about calling a non-const method, begin(), on a 
non-const Qt container (or a copy of it), that would make it detach even if it 
never gets actually modified in the loop, that's what I was thinking in my 
head. So I _assumed_ it got the point across but because I posted that right 
under your post about move semantics that kicked the point out the window; so 
you assumed I was talking about move semantics. Assumptions are bad, man I am 
telling you :)
  
  > And usually you don't have to worry about that. Detaching happens when it 
should, i.e. when modifying a copy, that's intended. The problem is range-for, 
which came up later, and which throws ease-of-use a little bit out of the 
window indeed.
  
  Well, I _guess_ the devs who wrote the range for code did that with STL 
containers in mind, where you're OK if you don't change the container _size_ 
(IIUC). They probably weren't thinking about the implicitly shared containers 
created by the Qt devs?
  
  Anyway, thanks for sharing.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23902

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24404: Small performance improvements suggested by clang-tidy

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24404

To: aacid, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24318: Make 32px document-save icon colorful

[Noah Davis]

ndavis added a comment.


  In D24318#541952 , @churaev wrote:
  
  > In D24318#541839 , @ndavis wrote:
  >
  > > How about this?
  > >  F7513643: document-save.svg 
  > >  F7513644: montage.png 
  >
  >
  > Should the metal tab on the top cast a shadow this long? It looks strange 
to me.
  >
  > The tab is normally perfectly flush with the non-indented region of the 
cover (picture 
).
  
  
  Yeah, that was a feature of the original icon that I didn't remove. I wasn't 
so sure about it either.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24318: Make 32px document-save icon colorful

[Noah Davis]

ndavis added a comment.


  In D24318#542043 , @ngraham wrote:
  
  > @ndavis You wanna just submit a patch with that and I'll abandon this?
  
  
  Alright

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D23902: [KCoreDirLister] replace deprecated foreach with range-for

[David Faure]

dfaure added a comment.


  In D23902#542037 , @ahmadsamir 
wrote:
  
  > In D23902#542026 , @dfaure wrote:
  >
  > > For the record, JFBastien was actually wrong. Calling .begin() on a const 
return value does call the const overload. Testcase 
http://www.davidfaure.fr/kde/const_retval.cpp
  >
  >
  > That looks like a failure in communication, either one of you _assumed_ 
something but didn't tell the other. :D
  
  
  You and I are both entitled to our own opinion, I know what I asked and what 
the reply was :-P
  (I tried to reach him afterwards via linkedin and cppcon slack, no success)
  
  >> But returning const QList would inhibit move semantics, e.g. `QList 
mylist = foo();` copies instead of moving.
  >>  So yeah, better not do that.
  > 
  > And it would detach (I don't know why it feels like detaching for Qt 
containers is like a sword hanging over all, especially new, developers' heads; 
so implicit sharing is great, except you have to worry about the container 
detaching for the rest of its natural life... :)).
  
  No, a copy doesn't detach. A non-const method call on a copy detaches.
  
  And usually you don't have to worry about that. Detaching happens when it 
should, i.e. when modifying a copy, that's intended. The problem is range-for, 
which came up later, and which throws ease-of-use a little bit out of the 
window indeed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23902

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 115 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/115/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 04 Oct 2019 15:40:40 +
 Build duration:
7 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

[EMAIL WAS STILL DRAFT] Re: Version-based deprecation macros for KDE Frameworks API: execution plan

[Friedrich W. H. Kossebau]

Am Freitag, 4. Oktober 2019, 17:37:12 CEST schrieb Friedrich W. H. Kossebau:
> Hi,
> 
> for those who missed things so far, quick recap first:

Premature send due to Shift+Backspace becoming press of Shift+Return key and 
instant email sending while still drafting :)

Well, please do the recap for now then if needed, final email will come later 
tonight :)

Cheers
Friedrich

D24308: [DataProtocol] compile without implicit coversion from ascii

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3b98d91436f5: [DataProtocol] compile without implicit 
coversion from ascii (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24308?vs=67125=67327

REVISION DETAIL
  https://phabricator.kde.org/D24308

AFFECTED FILES
  src/core/dataprotocol.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Version-based deprecation macros for KDE Frameworks API: execution plan

[Friedrich W. H. Kossebau]

Hi,

for those who missed things so far, quick recap first:

To better assist users of KDE Frameworks in dealing with its deprecated API, 
we might want to give them more control over visibility of such API to the 
compiler when building their software or if deprecation warnings are emitted.

For some weeks there has been work on a cmake-based technique which uses the 
usually already present generated export macros header (e.g. foo_export.h) as 
injector for new respective C++ prepocessor macros which enable to mark 
deprecated API like this:

#if FOO_ENABLE_DEPRECATED_SINCE(5, 0)
/**
 * @deprecated Since 5.0. Use bar(). // Sadly doxygen needs data duplicated
 */
FOO_DEPRECATED_VERSION(5, 0, "Use bar()")
void foo();
#endif

Which then allows users of the API to control visibility or warnings by macro 
flags like
-DFOO_DISABLE_DEPRECATED_BEFORE_AND_AT=0xXYZ
-DFOO_DEPRECATED_WARNINGS_SINCE=0xXYZ
-DFOO_NO_DEPRECATED (short for:FOO_DISABLE_DEPRECATED_BEFORE_AND_AT=latest)
-DFOO_NO_DEPRECATED_WARNINGS (short for: FOO_DEPRECATED_WARNINGS_SINCE=0)
similar to what we know from Qt.

Next to that, the developed solution also supports:
* optional group default flags, so users can easily control settings for
  groups of libraries (like all the KDE Frameworks)
* disabling build of implementation code of deprecated API (like useful for
  bundled shared libraries)

This solution is ECMGenerateExportHeader, up for review process at
https://phabricator.kde.org/D23789

There are also patches for two KDE Frameworks modules as examples:
KCoreAddons: https://phabricator.kde.org/D23800
KService: https://phabricator.kde.org/D23802

See also related blog post for some more details:
https://frinring.wordpress.com/2019/09/09/more-control-over-warnings-for-and-visibility-of-deprecated-library-api-via-generated-export-macro-header/

Cheers
Friedrich

D24318: Make 32px document-save icon colorful

[Nathaniel Graham]

ngraham added a comment.


  @ndavis You wanna just submit a patch with that and I'll abandon this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D23902: [KCoreDirLister] replace deprecated foreach with range-for

[Ahmad Samir]

ahmadsamir added a comment.


  In D23902#542026 , @dfaure wrote:
  
  > For the record, JFBastien was actually wrong. Calling .begin() on a const 
return value does call the const overload. Testcase 
http://www.davidfaure.fr/kde/const_retval.cpp
  
  
  That looks like a failure in communication, either one of you _assumed_ 
something but didn't tell the other. :D
  
  > But returning const QList would inhibit move semantics, e.g. `QList 
mylist = foo();` copies instead of moving.
  >  So yeah, better not do that.
  
  And it would detach (I don't know why it feels like detaching for Qt 
containers is like a sword hanging over all, especially new, developers' heads; 
so implicit sharing is great, except you have to worry about the container 
detaching for the rest of its natural life... :)).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23902

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23902: [KCoreDirLister] replace deprecated foreach with range-for

[David Faure]

dfaure added a comment.


  For the record, JFBastien was actually wrong. Calling .begin() on a const 
return value does call the const overload. Testcase 
http://www.davidfaure.fr/kde/const_retval.cpp
  
  But returning const QList would inhibit move semantics, e.g. `QList 
mylist = foo();` copies instead of moving.
  So yeah, better not do that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23902

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67324.
kossebau added a comment.


  - extend unit tests to cover library group macro variants
  
  Sadly blows up by all combinations unit test time to >1 min on old machine

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23789?vs=67220=67324

BRANCH
  addgenerateexportheader

REVISION DETAIL
  https://phabricator.kde.org/D23789

AFFECTED FILES
  docs/module/ECMGenerateExportHeader.rst
  modules/ECMGenerateExportHeader.cmake
  tests/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/main.cpp
  
tests/ECMGenerateExportHeaderTest/consumer/testAPI_DISABLE_DEPRECATED_BEFORE_AND_AT.cmake
  tests/ECMGenerateExportHeaderTest/consumer/testAPI_NO_DEPRECATED.cmake
  tests/ECMGenerateExportHeaderTest/format_version/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/format_version/main.cpp
  tests/ECMGenerateExportHeaderTest/library/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/library/library.cpp
  tests/ECMGenerateExportHeaderTest/library/library.hpp
  tests/ECMGenerateExportHeaderTest/library/main.cpp

To: kossebau
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[René J . V . Bertin]

rjvbb added a comment.


  A little tinker tool:
  
  github.com/RJVB/kbusygadget.
  
  An inter-frame freeze duration of 75ms already decreases CPU load (according 
to `top`) to approx. 3.6% (= almost 4x). I cannot really say if I notice the 
effect of this short a freeze on the rotation smoothness or speed.
  
  I will use this to "take things up wit Qt" as suggested - i.e. on the 
interest ML.
  
  R.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
GB_2, michaelh, bruns

D24387: improve error reporting for when kpasswdserver is unreachable

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kio_smb_mount.cpp:72
>   {
> finished();
> return;

(pre-existing: shouldn't this call `error` rather than `finished`?)

REPOSITORY
  R320 KIO Extras

BRANCH
  Applications/19.08

REVISION DETAIL
  https://phabricator.kde.org/D24387

To: sitter, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D24412: Add edit-line-width icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-line-width-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24412

AFFECTED FILES
  icons-dark/actions/16/edit-line-width.svg
  icons-dark/actions/22/edit-line-width.svg
  icons/actions/16/edit-line-width.svg
  icons/actions/22/edit-line-width.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Igor Poboiko]

poboiko updated this revision to Diff 67318.
poboiko added a comment.


  Minor optimization: change check order (filesize / extractor property)
  
  Also, it should be better check by "Id" instead of "Name"

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23787?vs=66805=67318

BRANCH
  improve-large-text-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23787

AFFECTED FILES
  src/file/extractor/app.cpp

To: poboiko, #baloo, bruns, ngraham
Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Igor Poboiko]

poboiko marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> app.cpp:173
> -if (fileInfo.size() >= 10 * 1024 * 1024) {
> -tr->removePhaseOne(id);
> -return;

This original line seemed very very wrong.

Just because we won't want to index phase 2 isn't a reason to remove the 
filename indexing - it'll just keep running phase 1 on itself again and again.

So +1 on that

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> poboiko wrote in app.cpp:185
> I though users might actually want to know if file was excluded (and the 
> reasoning behind it).
> I can make its severity less, i.e. `qCDebug`. Or you think it should be 
> completely removed?

Users don't read log files. :)

Then again if the default log level is error rather than warning, then this 
isn't actually a logspam problem either.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Igor Poboiko]

poboiko added inline comments.

INLINE COMMENTS

> bruns wrote in app.cpp:185
> Users will love us for spammig the logs ...

I though users might actually want to know if file was excluded (and the 
reasoning behind it).
I can make its severity less, i.e. `qCDebug`. Or you think it should be 
completely removed?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Igor Poboiko]

poboiko added a comment.


  In D23787#537891 , @bruns wrote:
  
  > Can you please provide an example which:
  >
  > - is currently indexed though it should be skipped due to size
  > - is skipped after this change
  
  
  Sure. Any mimetype inherited from "text/plain", but starting with "text/" 
counts. I've made an actual list:
  F7515259: list.txt 
  (using simple python script, which iterates over 
`QMimeDatabase().allMimeTypes()`, checks if `type.inherits("text/plain")` and 
is not already excluded by default Baloo config from 
`file/fileexcludefilters.cpp`)
  
  By looking at list, I see that some of them might be pretty heavy (and 
useless to index). For example, `application/x-valgrind-massif`, or 
`application/sql` (I know, SQL dumps are excluded by extension `*.sql`, but 
someone might simply use another extension like `.dump`). It's also pretty easy 
to imagine large Wolfram Mathematica file, i.e. containing pictures (that 
corresponds to `application/mathematica` from the list; although on my computer 
those are detected as `application/vnd.wolfram.nb`, which for some reason do 
not inherit `text/plain`, although it's plaintext-based).
  
  We can do our best to exclude undesired types, but I'm not sure we will be 
able to cover all of them. And some files might be of desirable type, but 
simply too large (RSS feeds `application/rss+xml`, LyX files for some books 
`application/x-lyx`, mailboxes `message/rfc822` or `application/mbox`).
  
  > and another example which:
  > 
  > - is currently skipped though it should be indexed
  > - is indexed after this change
  
  There shouldn't be any. I mean, "PlaintextExtractor" should be inside 
`exList` for anything that starts with `text/`...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D24387: improve error reporting for when kpasswdserver is unreachable

[Harald Sitter]

sitter edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D24387

To: sitter, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D24318: Make 32px document-save icon colorful

[Nathaniel Graham]

ngraham added a comment.


  Heh that's a ton better than mine. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24318: Make 32px document-save icon colorful

[Nikita Churaev]

churaev added a comment.


  In D24318#541839 , @ndavis wrote:
  
  > How about this?
  >  F7513643: document-save.svg 
  >  F7513644: montage.png 
  
  
  Should the metal tab on the top cast a shadow this long? It looks strange to 
me.
  
  The tab is normally perfectly flush with the non-indented region of the cover 
(picture 
).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24387: improve error reporting for when kpasswdserver is unreachable

[Nathaniel Graham]

ngraham added a comment.


  Nice, +1

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D24387

To: sitter, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D24363: Fix several build system errors

[Alexey Min]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:731b85008c21: Fix several build system errors (authored 
by alexeymin).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67233=67314

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  alexeymin/fix-cmake-errors

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24405: Small performance improvements suggested by clang-tidy

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Makes sense

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24405

To: aacid, meven
Cc: meven, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D24384: Move Amusement to Games directory instead of Games > Toys

[Yunhe Guo]

guoyunhe added a comment.


  If I install amor, it would be shown in both Games and Games > Toys. This 
patch will let it only shows in Games.
  
  Another situation is that, if the application is 
`Categories=Multimedia;Amusement;`, it will not fit Games or Games>Toys. This 
patch can also help to always follow the primary category. (Amusement is an 
additional/secondary category)

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Yunhe Guo]

guoyunhe updated this revision to Diff 67310.
guoyunhe added a comment.


  In case Amusement is under other primary category, let it be placed in its 
actually primary category, rather than force it in Games.

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67304=67310

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

[Yunhe Guo]

guoyunhe added a comment.


  In RPM package groups, **Amusement** is a top level category and **Game** is 
its child category. So a game can be categorized as **Amusement/Game/Other**.
  
  However, in freedesktop.org specification, **Game** is primary category. 
**Amusement** is secondary category but not under **Game**.
  
  I searched through all KDE apps to find **Amusement** category in desktop 
files. And find the only one :
  
  amor - Amusing Misuse of Resources animation that sits on top of the curent 
window. Categories=Qt;KDE;Game;Amusement;
  
  F7514185: image.png 

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24354: Mustache/Handlebars: minor fixes

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24384: Move Amusement to Games directory instead of Games > Toys

[Yunhe Guo]

guoyunhe edited the summary of this revision.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24403: Small performance improvements suggested by clang-tidy

[Albert Astals Cid]

aacid planned changes to this revision.
aacid added inline comments.

INLINE COMMENTS

> modebase.cpp:333
> -
> -QRegExp endOfWORD(endOfWORDPattern);
>  

This is wrong, QRegExp is broken and lastIndexIn modifies the object even if 
the function is marked as const

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24403

To: aacid
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24384: Move Amusement to Games directory instead of Games > Toys

[Yunhe Guo]

guoyunhe updated this revision to Diff 67304.
guoyunhe added a comment.


  Update description

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67252=67304

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24318: Make 32px document-save icon colorful

[Björn Feber]

GB_2 added a comment.


  In D24318#541839 , @ndavis wrote:
  
  > How about this?
  >  F7513643: document-save.svg 
  >  F7513644: montage.png 
  
  
  I love it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

[Noah Davis]

ndavis added a comment.


  How about this?
  F7513643: document-save.svg 
  F7513644: montage.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23266: Export Plasma core lib log category, add a category to a qWarning

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5f6996ee50f8: Export Plasma core lib log category, add a 
category to a qWarning (authored by meven).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23266?vs=64060=67300#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23266?vs=64060=67300

REVISION DETAIL
  https://phabricator.kde.org/D23266

AFFECTED FILES
  CMakeLists.txt
  plasma-framework.categories

To: meven, #frameworks, broulik, davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24354: Mustache/Handlebars: minor fixes

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-delimiters-mustache

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24406: Small performance improvements suggested by clang tidy

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24406

To: aacid, mgallien
Cc: mgallien, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 04 Oct 2019 06:06:48 +
 Build duration:
9 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Contacts-5.63.0.xmlcompat_reports/KF5Contacts_compat_report.htmllogs/KF5Contacts/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)83%
(68/82)83%
(68/82)78%
(8570/11053)52%
(2987/5790)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(32/32)100%
(32/32)99%
(4294/4308)52%
(1030/1974)src82%
(31/38)82%
(31/38)65%
(3605/5569)51%
(1532/3007)src.converter100%
(2/2)100%
(2/2)73%
(331/455)57%
(221/386)src.generator0%
(0/3)0%
(0/3)0%
(0/153)0%
(0/76)src.vcardparser100%
(3/3)100%
(3/3)86%
(340/396)79%
(204/259)tests0%
(0/4)0%
(0/4)0%
(0/172)0%
(0/88)

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 04 Oct 2019 05:58:46 +
 Build duration:
8 min 0 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Contacts-5.63.0.xmlcompat_reports/KF5Contacts_compat_report.htmllogs/KF5Contacts/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.kcontacts_testroundtrip
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)83%
(68/82)83%
(68/82)78%
(8574/11053)52%
(2991/5790)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(32/32)100%
(32/32)99%
(4298/4308)52%
(1033/1974)src82%
(31/38)82%
(31/38)65%
(3605/5569)51%
(1533/3007)src.converter100%
(2/2)100%
(2/2)73%
(331/455)57%
(221/386)src.generator0%
(0/3)0%
(0/3)0%
(0/153)0%
(0/76)src.vcardparser100%
(3/3)100%
(3/3)86%
(340/396)79%
(204/259)tests0%
(0/4)0%
(0/4)0%
(0/172)0%
(0/88)

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/7/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 04 Oct 2019 06:02:31 +
 Build duration:
4 min 31 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Contacts-5.63.0.xmlcompat_reports/KF5Contacts_compat_report.htmllogs/KF5Contacts/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)83%
(68/82)83%
(68/82)78%
(8570/11053)52%
(2987/5790)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(32/32)100%
(32/32)99%
(4294/4308)52%
(1030/1974)src82%
(31/38)82%
(31/38)65%
(3605/5569)51%
(1532/3007)src.converter100%
(2/2)100%
(2/2)73%
(331/455)57%
(221/386)src.generator0%
(0/3)0%
(0/3)0%
(0/153)0%
(0/76)src.vcardparser100%
(3/3)100%
(3/3)86%
(340/396)79%
(204/259)tests0%
(0/4)0%
(0/4)0%
(0/172)0%
(0/88)

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.13/7/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 04 Oct 2019 06:01:33 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/6/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 04 Oct 2019 05:58:46 +
 Build duration:
3 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Contacts-5.63.0.xmlcompat_reports/KF5Contacts_compat_report.htmllogs/KF5Contacts/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.kcontacts_testroundtrip
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)83%
(68/82)83%
(68/82)78%
(8574/11053)52%
(2991/5790)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(32/32)100%
(32/32)99%
(4298/4308)52%
(1033/1974)src82%
(31/38)82%
(31/38)65%
(3605/5569)51%
(1533/3007)src.converter100%
(2/2)100%
(2/2)73%
(331/455)57%
(221/386)src.generator0%
(0/3)0%
(0/3)0%
(0/153)0%
(0/76)src.vcardparser100%
(3/3)100%
(3/3)86%
(340/396)79%
(204/259)tests0%
(0/4)0%
(0/4)0%
(0/172)0%
(0/88)

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.13/6/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 04 Oct 2019 05:58:46 +
 Build duration:
1 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.kcontacts_testroundtrip