dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > kio_smb_mount.cpp:72 > { > finished(); > return; (pre-existing: shouldn't this call `error` rather than `finished`?) REPOSITORY R320 KIO Extras BRANCH Applications/19.08 REVISION DETAIL https://phabricator.kde.org/D24387 To: sitter, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov