D24773: kio_trash: Add size, modification, access and create date for trash:/

[Nathaniel Graham]

ngraham added a comment.


  Works great. Not sure creation date makes sense to show for the trash (if 
it's available) though. Can we suppress that?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24350: [src/kpac/*] replace deprecated foreach with range for

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in script.cpp:157
> Why not just change this one to return `const &` and then use it in all 
> range-fors?
> 
> [note that returning a const ref is bad in public API, but this is an 
> internal method so we can always change it again if needed]

Because I didn't pay attention to public v.s. private API :)

Fixing.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24350

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 88 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/88/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 20 Oct 2019 21:05:22 +
 Build duration:
6 hr 3 min and counting
   JUnit Tests
  Name: projectroot Failed: 9 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.inlinenote_testFailed: projectroot.autotests.katedocument_testFailed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testCstyleFailed: projectroot.autotests.kateindenttest_testRubyFailed: projectroot.autotests.katetextbuffertestFailed: projectroot.autotests.kateview_testFailed: projectroot.autotests.messagetestFailed: projectroot.autotests.movingrange_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D24350: [src/kpac/*] replace deprecated foreach with range for

[Ahmad Samir]

ahmadsamir updated this revision to Diff 68395.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  In private API we can have a method return a const &, as it can be
  changed later without side-effects.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24350?vs=67152&id=68395

BRANCH
  ahmad/foreach-kpac (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24350

AFFECTED FILES
  src/kpac/script.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24811: tests: fix macos build failure

[Kurt Hindenburg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R159:196b04531764: tests: fix macos build failure (authored by 
hindenburg).

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24811?vs=68384&id=68394

REVISION DETAIL
  https://phabricator.kde.org/D24811

AFFECTED FILES
  tests/model/CMakeLists.txt

To: hindenburg, cullmann
Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 118 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/118/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 20 Oct 2019 19:48:15 +
 Build duration:
3 hr 28 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D24671: Use ECMGenerateExportHeader to manage deprecated API better

[Aleix Pol Gonzalez]

apol added a comment.


  👍 sorry about slow reviews. The patch looks good.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D24671

To: kossebau, #frameworks, #plasma, mart, apol
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24350: [src/kpac/*] replace deprecated foreach with range for

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  sorry, missed this one. thanks for the ping.

INLINE COMMENTS

> script.cpp:157
>  
>  QList addresses() const
>  {

Why not just change this one to return `const &` and then use it in all 
range-fors?

[note that returning a const ref is bad in public API, but this is an internal 
method so we can always change it again if needed]

> script.cpp:162
>  
> +const QList &addressesList() const
> +{

it's just weird to have two methods that do the same thing, with a different 
name.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24350

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 87 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/87/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 20 Oct 2019 15:29:02 +
 Build duration:
5 hr 35 min and counting
   CONSOLE OUTPUT
  [...truncated 392 lines...][2019-10-20T21:04:14.086Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5ConfigWidgets.tags" found for KF5ConfigWidgets_QCH when calling ecm_add_qch().[2019-10-20T21:04:14.086Z] CMake Warning at C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-20T21:04:14.086Z]   No linking to API dox of KF5ConfigWidgets_QCH.[2019-10-20T21:04:14.086Z] Call Stack (most recent call first):[2019-10-20T21:04:14.086Z]   C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-20T21:04:14.086Z]   src/CMakeLists.txt:341 (ecm_add_qch)[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5SonnetUi.tags" found for KF5SonnetUi_QCH when calling ecm_add_qch().[2019-10-20T21:04:14.086Z] CMake Warning at C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-20T21:04:14.086Z]   No linking to API dox of KF5SonnetUi_QCH.[2019-10-20T21:04:14.086Z] Call Stack (most recent call first):[2019-10-20T21:04:14.086Z]   C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-20T21:04:14.086Z]   src/CMakeLists.txt:341 (ecm_add_qch)[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5I18n.tags" found for KF5I18n_QCH when calling ecm_add_qch().[2019-10-20T21:04:14.086Z] CMake Warning at C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-20T21:04:14.086Z]   No linking to API dox of KF5I18n_QCH.[2019-10-20T21:04:14.086Z] Call Stack (most recent call first):[2019-10-20T21:04:14.086Z]   C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-20T21:04:14.086Z]   src/CMakeLists.txt:341 (ecm_add_qch)[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2019-10-20T21:04:14.086Z] -- No such target Qt5Gui_QCH defined when calling ecm_add_qch(), ignored.[2019-10-20T21:04:14.086Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5Codecs.tags" found for KF5Codecs_QCH when calling ecm_add_qch().[2019-10-20T21:04:14.086Z] CMake Warning at C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-20T21:04:14.086Z]   No linking to API dox of KF5Codecs_QCH.[2019-10-20T21:04:14.086Z] Call Stack (most recent call first):[2019-10-20T21:04:14.086Z]   C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-20T21:04:14.086Z]   src/CMakeLists.txt:341 (ecm_add_qch)[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5Auth.tags" found for KF5Auth_QCH when calling ecm_add_qch().[2019-10-20T21:04:14.086Z] CMake Warning at C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-20T21:04:14.086Z]   No linking to API dox of KF5Auth_QCH.[2019-10-20T21:04:14.086Z] Call Stack (most recent call first):[2019-10-20T21:04:14.086Z]   C:/CI/Software Installs/ktexteditor/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-20T21:04:14.086Z]   src/CMakeLists.txt:341 (ecm_add_qch)[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] -- Looking for fdatasync[2019-10-20T21:04:14.086Z] -- Looking for fdatasync - not found[2019-10-20T21:04:14.086Z] -- The following features have been enabled:[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] -- The following OPTIONAL packages have been found:[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z]  * PkgConfig[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z] -- The following REQUIRED packages have been found:[2019-10-20T21:04:14.086Z] [2019-10-20T21:04:14.086Z]  * ECM (required version >= 5.63.0), Extra CMake Modules., [2019-10-20T21:04:14.086Z]  * Qt5Gui (required version >= 5.13.0)[2019-10-20T21:04:14.086Z]  * Qt5Widgets[2019-10-20T21:04:14.086Z]  * Qt5Network (required version >= 5.13.0)[2019-10-20T21:04:14.086Z]  * Qt5Qml[2019-10-20T21:04:14.086Z]  * Qt5PrintSupport[2019-10-20T21:04:14.086Z]  * Qt5Xml[2019-10-20T21:04:14.086Z]

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added a comment.


  Volker Ok'd it that I used that on the co-maintained KSyntaxHighlighting 
framework, too.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24620: Windows MSVC compile fix

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R159:1ea2058a09c9: Windows MSVC compile fix (authored by 
cullmann).

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24620?vs=67869&id=68393

REVISION DETAIL
  https://phabricator.kde.org/D24620

AFFECTED FILES
  src/resultset.h
  src/resultset_iterator.cpp
  src/utils/lazy_val.h

To: cullmann, #frameworks, dhaumann
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24575: Updates from CMake 3.16

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:dbd14c404867: Updates from CMake 3.16 (authored by 
cullmann).
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24575?vs=67752&id=68392

REVISION DETAIL
  https://phabricator.kde.org/D24575

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D24811: tests: fix macos build failure

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Why not ;=)

REPOSITORY
  R159 KActivities Statistics

BRANCH
  fix-tests-model-boost-include (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24811

To: hindenburg, cullmann
Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24350: [src/kpac/*] replace deprecated foreach with range for

[Ahmad Samir]

ahmadsamir added a comment.


  Ping...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24350

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 26 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/26/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 17 Oct 2019 15:35:04 +
 Build duration:
3 days 4 hr and counting

D24261: Modernize code: use range-based for loop in more places

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:3836ef74bc2c: Modernize code: use range-based for loop in 
more places (authored by kossebau).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24261?vs=67047&id=68389

REVISION DETAIL
  https://phabricator.kde.org/D24261

AFFECTED FILES
  src/kaboutapplicationpersonmodel_p.cpp
  src/kedittoolbar.cpp
  src/kgesture.cpp
  src/kmainwindow.cpp
  src/kshortcutseditor.cpp
  src/kswitchlanguagedialog_p.cpp
  src/ktoolbar.cpp
  src/ktoolbarhandler.cpp
  src/kxmlguiclient.cpp
  src/kxmlguifactory_p.cpp

To: kossebau, dfaure
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 117 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/117/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 20 Oct 2019 15:29:03 +
 Build duration:
4 hr 19 min and counting
   CONSOLE OUTPUT
  [...truncated 187 lines...][2019-10-20T19:48:04.999Z] -- The C compiler identification is Clang 6.0.1[2019-10-20T19:48:05.267Z] -- The CXX compiler identification is Clang 6.0.1[2019-10-20T19:48:05.267Z] -- Check for working C compiler: /usr/bin/cc[2019-10-20T19:48:05.267Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-20T19:48:05.267Z] -- Detecting C compiler ABI info[2019-10-20T19:48:05.526Z] -- Detecting C compiler ABI info - done[2019-10-20T19:48:05.526Z] -- Detecting C compile features[2019-10-20T19:48:05.789Z] -- Detecting C compile features - done[2019-10-20T19:48:05.789Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-20T19:48:06.048Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-10-20T19:48:06.048Z] -- Detecting CXX compiler ABI info[2019-10-20T19:48:06.048Z] -- Detecting CXX compiler ABI info - done[2019-10-20T19:48:06.048Z] -- Detecting CXX compile features[2019-10-20T19:48:06.622Z] -- Detecting CXX compile features - done[2019-10-20T19:48:06.622Z] -- [2019-10-20T19:48:06.622Z] [2019-10-20T19:48:06.622Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for KTextEditor.[2019-10-20T19:48:06.622Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-10-20T19:48:06.622Z] -- Looking for __GLIBC__[2019-10-20T19:48:06.892Z] -- Looking for __GLIBC__ - not found[2019-10-20T19:48:06.892Z] -- Performing Test _OFFT_IS_64BIT[2019-10-20T19:48:06.892Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-10-20T19:48:06.892Z] -- Performing Test HAVE_DATE_TIME[2019-10-20T19:48:07.166Z] -- Performing Test HAVE_DATE_TIME - Success[2019-10-20T19:48:07.166Z] CMake Error at CMakeLists.txt:19 (include):[2019-10-20T19:48:07.166Z]   include could not find load file:[2019-10-20T19:48:07.166Z] [2019-10-20T19:48:07.166Z] KDEClangFormat[2019-10-20T19:48:07.166Z] [2019-10-20T19:48:07.166Z] [2019-10-20T19:48:07.166Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2019-10-20T19:48:07.166Z] -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.6.1") [2019-10-20T19:48:07.742Z] -- Found LibGit2: /usr/local/lib/libgit2.so (found suitable version "0.28.1", minimum required is "0.22.0") [2019-10-20T19:48:07.742Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-10-20T19:48:08.006Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-10-20T19:48:08.006Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-10-20T19:48:08.279Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-10-20T19:48:08.279Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-10-20T19:48:08.541Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-10-20T19:48:08.541Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot [2019-10-20T19:48:08.541Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2019-10-20T19:48:08.541Z] -- No such target Qt5DBus_QCH defined when calling ecm_add_qch(), ignored.[2019-10-20T19:48:08.801Z] -- Looking for fdatasync[2019-10-20T19:48:08.801Z] -- Looking for fdatasync - found[2019-10-20T19:48:08.801Z] -- The following features have been enabled:[2019-10-20T19:48:08.801Z] [2019-10-20T19:48:08.801Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-10-20T19:48:08.801Z] [2019-10-20T19:48:08.801Z] -- The following OPTIONAL packages have been found:[2019-10-20T19:48:08.801Z] [2019-10-20T19:48:08.801Z]  * PkgConfig[2019-10-20T19:48:08.801Z]  * LibGit2 (required version >= 0.22.0), A plain C library to interface with the git version control system., [2019-10-20T19:48:08.801Z] [2019-10-20T19:48:08.801Z] -- The following REQUIRED packages have been found:[2019-10-20T19:48:08.801Z] [2019-10-20T19:48:08.801Z]  * ECM (required version >= 5.63.0), Extra CMake Modules., [2019-10-20T19:48:08.801Z]  * Qt5Gui (required version >= 5.13.0)[2019-10-20T19:48:08.801Z]  * Qt5Widgets[2019-10-20T19:48:08.801Z]  * Qt5Network (required version >= 5.13.0)[2019-10-20T19:48:08.801Z]  * Qt5Qml[2019-10-20T19:48:08.801Z]  * Qt5PrintSupport[2019-10-20T19:48:08.801Z]  * Qt5Xml[2019-10-20T19:48:08.801Z]  * KF5Archive (required version >= 5.63.0)[2019-10-20T19:48:08.801Z]  * KF5Config (required version >= 5.63.0)[2019-10-20T19:48:08.801Z]  * KF5GuiAddons (required version >= 5.63.0)[2019-10-20T19:48:08.801Z]  * Gettext[2019-10-20T19:48:08.801Z]  * KF5I18n (required version >= 5.63.0)[2019-10-20T19:48:08.801Z]  * KF5KIO (required version >= 5.63.0)[2019-10-20T19:48:08.801Z]  * KF5P

D24807: Fix incorrect rendering of 22px edit-opacity icon

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2b218ddc6327: Fix incorrect rendering of 22px 
edit-opacity icon (authored by Rafael Brandmaier 
).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24807?vs=68375&id=68387

REVISION DETAIL
  https://phabricator.kde.org/D24807

AFFECTED FILES
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26, #vdg, simgunz
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24620: Windows MSVC compile fix

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Imo we should simply try: We have another two weeks for testing.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D24620

To: cullmann, #frameworks, dhaumann
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 120 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/120/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 20 Oct 2019 19:07:46 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.64.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(263/298)88%
(263/298)68%
(33343/49082)50%
(14949/29886)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4832/5131)49%
(1805/3654)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5504/5546)58%
(970/1680)src.buffer88%
(15/17)88%
(15/17)90%
(1702/1894)75%
(1103/1472)src.completion100%
(11/11)100%
(11/11)57%
(1787/3134)41%
(993/2397)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/852)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1939/3166)48%
(1424/2955)src.export0%
(0/4)0%
(0/4)0%
(0/117)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)92%
(207/226)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(194/306)51%
(39/77)src.mode88%
(7/8)88%
(7/8)37%
(349/942)17%
(133/803)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(946/1222)67%
(611/914)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)69%
(717/1039)56%
(226/403)src.search100%
(7/7)100%

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 119 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/119/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 20 Oct 2019 15:29:03 +
 Build duration:
3 hr 38 min and counting
   CONSOLE OUTPUT
  [...truncated 261 lines...][2019-10-20T19:07:38.634Z] -- [2019-10-20T19:07:38.634Z] [2019-10-20T19:07:38.634Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.13/build/prefix.sh to set the environment for KTextEditor.[2019-10-20T19:07:38.634Z] -- Looking for __GLIBC__[2019-10-20T19:07:38.896Z] -- Looking for __GLIBC__ - found[2019-10-20T19:07:38.896Z] -- Performing Test _OFFT_IS_64BIT[2019-10-20T19:07:38.896Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-10-20T19:07:38.896Z] -- Performing Test HAVE_DATE_TIME[2019-10-20T19:07:39.168Z] -- Performing Test HAVE_DATE_TIME - Success[2019-10-20T19:07:39.168Z] CMake Error at CMakeLists.txt:19 (include):[2019-10-20T19:07:39.168Z]   include could not find load file:[2019-10-20T19:07:39.168Z] [2019-10-20T19:07:39.168Z] KDEClangFormat[2019-10-20T19:07:39.168Z] [2019-10-20T19:07:39.168Z] [2019-10-20T19:07:39.168Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2019-10-20T19:07:39.444Z] -- Found PkgConfig: /usr/bin/pkg-config (found version "1.6.3") [2019-10-20T19:07:39.703Z] -- Could NOT find LibGit2 (missing: LIBGIT2_LIBRARY LIBGIT2_INCLUDE_DIR) (Required is at least version "0.22.0")[2019-10-20T19:07:39.703Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-10-20T19:07:39.964Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-10-20T19:07:39.964Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-10-20T19:07:40.228Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-10-20T19:07:40.228Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-10-20T19:07:40.228Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-10-20T19:07:40.228Z] -- Found Doxygen: /usr/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot [2019-10-20T19:07:40.228Z] -- Found QHelpGenerator executable: /usr/lib64/qt5/bin/qhelpgenerator[2019-10-20T19:07:40.228Z] -- No such target Qt5Widgets_QCH defined when calling ecm_add_qch(), ignored.[2019-10-20T19:07:40.228Z] -- No such target Qt5Network_QCH defined when calling ecm_add_qch(), ignored.[2019-10-20T19:07:40.228Z] -- No such target Qt5Xml_QCH defined when calling ecm_add_qch(), ignored.[2019-10-20T19:07:40.228Z] -- No such target Qt5DBus_QCH defined when calling ecm_add_qch(), ignored.[2019-10-20T19:07:40.228Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2019-10-20T19:07:40.228Z] -- No such target Qt5Gui_QCH defined when calling ecm_add_qch(), ignored.[2019-10-20T19:07:40.484Z] -- Looking for fdatasync[2019-10-20T19:07:40.484Z] -- Looking for fdatasync - found[2019-10-20T19:07:40.484Z] -- The following features have been enabled:[2019-10-20T19:07:40.484Z] [2019-10-20T19:07:40.484Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-10-20T19:07:40.484Z] [2019-10-20T19:07:40.484Z] -- The following OPTIONAL packages have been found:[2019-10-20T19:07:40.484Z] [2019-10-20T19:07:40.484Z]  * PkgConfig[2019-10-20T19:07:40.484Z] [2019-10-20T19:07:40.484Z] -- The following REQUIRED packages have been found:[2019-10-20T19:07:40.484Z] [2019-10-20T19:07:40.484Z]  * ECM (required version >= 5.63.0), Extra CMake Modules., [2019-10-20T19:07:40.484Z]  * Qt5Qml[2019-10-20T19:07:40.484Z]  * Qt5PrintSupport[2019-10-20T19:07:40.484Z]  * KF5Archive (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5GuiAddons (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5Service (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5Bookmarks (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5Completion (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5ItemViews (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5JobWidgets (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5Solid (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * Qt5Network (required version >= 5.11.0)[2019-10-20T19:07:40.484Z]  * Gettext[2019-10-20T19:07:40.484Z]  * KF5I18n (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5TextWidgets (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5Codecs (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * Qt5Xml (required version >= 5.11.0)[2019-10-20T19:07:40.484Z]  * KF5Config (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5WidgetsAddons (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5ConfigWidgets (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5XmlGui (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5Parts (required version >= 5.63.0)[2019-10-20T19:07:40.484Z]  * KF5Sonnet (

D24811: tests: fix macos build failure

[Kurt Hindenburg]

hindenburg created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hindenburg requested review of this revision.

REVISION SUMMARY
  Add boost include similiar to autotests/CMakeLists.txt

TEST PLAN
  make && make tests
  bin/KActivitiesStatsTestApp.app/Contents/MacOS/KActivitiesStatsTestApp

REPOSITORY
  R159 KActivities Statistics

BRANCH
  fix-tests-model-boost-include (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24811

AFFECTED FILES
  tests/model/CMakeLists.txt

To: hindenburg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24663#550883 , @romangg wrote:
  
  > It's ok that you pushed. Can you give a link to your preferred resource for 
me to read up on ECMGenerateExportHeader? Not too comprehensive if possible.
  
  
  For one there are the API docs at 
https://api.kde.org/ecm/module/ECMGenerateExportHeader.html
  
  For the bigger picture, please see T11490 
 (also cmp. 
https://mail.kde.org/pipermail/kde-frameworks-devel/2019-October/094708.html)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24620: Windows MSVC compile fix

[Christoph Cullmann]

cullmann added a comment.


  Can I just push that? Then we no longer need to patch just this one framework 
for Windows.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D24620

To: cullmann, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Roman Gilg]

romangg added a comment.


  It's ok that you pushed. Can you give a link to your preferred resource for 
me to read up on ECMGenerateExportHeader?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added a comment.


  Ok, I pushed this now.
  
  I will use that myself in KTextEditor and Kate instead of my old file and 
shell script.
  
  We can think about what to do with other frameworks now.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
cullmann marked an inline comment as done.
Closed by commit R240:235fcabf5018: Provide clang-format target with a KDE 
Frameworks style file (authored by cullmann).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24568?vs=68369&id=68380

REVISION DETAIL
  https://phabricator.kde.org/D24568

AFFECTED FILES
  kde-modules/KDEClangFormat.cmake
  kde-modules/clang-format.cmake

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 150 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/150/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 20 Oct 2019 14:12:33 +
 Build duration:
3 hr 18 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24807: Fix incorrect rendering of 22px edit-opacity icon

[Simone Gaiarin]

simgunz accepted this revision.
simgunz added a comment.
This revision is now accepted and ready to land.


  The icon is now rendered correctly in Okular and cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-edit-opacity-22px-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24807

To: trickyricky26, #vdg, simgunz
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24807: Fix incorrect rendering of 22px edit-opacity icon

[TrickyRicky]

trickyricky26 added reviewers: VDG, simgunz.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24807

To: trickyricky26, #vdg, simgunz
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24807: Fix incorrect rendering of 22px edit-opacity icon

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REVISION SUMMARY
  This patch should fix the incorrect rendering of the new 22px `edit-opacity` 
icon added in D24753 .
  The preview in Dolphin and Ikona no longer shows renders the file 
incorrectly, so should also resolve the issue for viewing in Okular and 
Cuttlefish.
  While optimizing the file, `svgo` altered some paths, which apparently 
resulted in the file rendering incorrectly in the Qt SVG Renderer, but not in 
Inkscape.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-edit-opacity-22px-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24807

AFFECTED FILES
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_trash.cpp:500
>  KIO::UDSEntry entry;
> +entry.clear();
>  createTopLevelDirEntry(entry);

why?

> trashimpl.cpp:1088
>  
> +KIO::UDSEntry TrashImpl::trashUDSEntry()
> +{

This method could be const, right?

> trashimpl.cpp:1104
> +// compute dir size if needed
> +KIO::DirectorySizeJob *job = 
> KIO::directorySize(QUrl::fromLocalFile(info.physicalPath));
> +connect(job, &KIO::DirectorySizeJob::result, this, [&size, job] 
> (){

This looks very slow. We have a cache for the size usage. See 
`TrashImpl::trashSpaceInfo`.

But anyway, we never return recursive directory size in the UDS_SIZE field, in 
no ioslave.
If someone wants to know the size of a directory, they can use the properties 
dialog, which has a calculate button.

> trashimpl.cpp:
> +}
> +entry.replace(KIO::UDSEntry::UDS_SIZE, static_cast(size));
> +

Why `replace`? This is inserting into a fresh new entry, it could use 
`fastInsert`

(same for the other calls below)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added inline comments.

INLINE COMMENTS

> dfaure wrote in clang-format.cmake:75
> (b) looks good to me, and more importantly, I like the goal of being as close 
> as possible to the Qt coding style.

removed that setting, back to Webkit default of BreakBeforeTernaryOperators: 
true

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann updated this revision to Diff 68369.
cullmann added a comment.


  - keep default of BreakBeforeTernaryOperators = true

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24568?vs=68186&id=68369

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24568

AFFECTED FILES
  kde-modules/KDEClangFormat.cmake
  kde-modules/clang-format.cmake

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24685: Replace usage of SlaveBase::config()->readEntry by SlaveBase::configValue

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fa27b67d2784: Replace usage of 
SlaveBase::config()->readEntry by SlaveBase::configValue (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24685?vs=68020&id=68366

REVISION DETAIL
  https://phabricator.kde.org/D24685

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven removed a dependent revision: D24774: Allow non-local directories to 
provide UDS_SIZE.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven marked 2 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in trashimpl.cpp:1091
> Is this really needed? We just created `entry`.

It was done previously in void TrashProtocol::createTopLevelDirEntry to save 
some memory, so I just kept it here and line 500.
Although it is not very useful.

> elvisangelaccio wrote in trashimpl.cpp:1094
> coding style: local variables never start with an uppercase.

TrashedFileInfoList is the type of TrashedFileInfoList, no issue with codding 
style.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 added a comment.


  In D24753#550676 , @simgunz wrote:
  
  > First, thanks for the excellent work on the new icons for Okular. I really 
like them.
  >
  > I have noticed that the edit-opacity icon does not render correctly in some 
cases:
  >
  > F7636237: Screenshot_20191020_150623.png 

  >  Preview in Cuttlefish.
  >
  > F7636244: Screenshot_20191020_150857.png 

  >  Okular annotation toolbar
  
  
  Huh, I noticed that when copying the files in Dolphin, the preview also 
showed this exact distortion of the 22px icon (but not the 16px one). I'll see 
if I can make this work.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham, ndavis
Cc: simgunz, ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D21235: Add handling of fuseiso filesystem type

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:301
> +
> +QStringList Solid::Backends::Fstab::FstabHandling::currentMountPoints(const 
> QString &device)
> +{

Please keep these functions at their current position, just adds unnecessary 
noise in the diff.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[Simone Gaiarin]

simgunz added a comment.


  First, thanks for the excellent work on the new icons for Okular. I really 
like them.
  
  I have noticed that the edit-opacity icon does not render correctly in some 
cases:
  
  F7636237: Screenshot_20191020_150623.png 

  Preview in Cuttlefish.
  
  F7636244: Screenshot_20191020_150857.png 

  Okular annotation toolbar

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham, ndavis
Cc: simgunz, ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 36 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/36/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 20 Oct 2019 08:54:19 +
 Build duration:
3 hr 49 min and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.64.0.xmllogs/KF5WindowSystem/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindoweffectstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7258/9597)55%
(3523/6351)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3078/3164)53%
(1295/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(826/1380)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3347/4695)60%
(1924/3197)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[David Faure]

dfaure added a comment.


  Thanks for the information.
  
  https://community.kde.org/Schedules doesn't have a 19.12 schedule so I guess 
there's no freeze yet :-)

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

To: meven, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D24799: Port away from deprecated SmallIcon method

[Volker Krause]

vkrause added a task: T11654: Deprecate 
SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of 
KIconLoader or QIcon API.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24799

To: vkrause, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24799: Port away from deprecated SmallIcon method

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24799

To: vkrause, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24799: Port away from deprecated SmallIcon method

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24799

AFFECTED FILES
  src/ksettings/componentsdialog.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D24686#550533 , @dfaure wrote:
  
  > I never know when it's OK to increase the KF5 version dependency from 
applications modules, though.
  >
  > I have a ton of pending patches (to port away from KWindowSystem deprecated 
API) which require a KF5 version dep upgrade too...
  
  
  It's always ok to bump the KF5 version as long as you do it before the 
dependency freeze day set by the release team.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

To: meven, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Elvis Angelaccio]

elvisangelaccio added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1

INLINE COMMENTS

> trashimpl.cpp:1091
> +KIO::UDSEntry entry;
> +entry.clear();
> +

Is this really needed? We just created `entry`.

> trashimpl.cpp:1094
> +// refresh list of trashes and get the list of files in them
> +const TrashedFileInfoList fileInfoList = list();
> +

coding style: local variables never start with an uppercase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I never know when it's OK to increase the KF5 version dependency from 
applications modules, though.
  
  I have a ton of pending patches (to port away from KWindowSystem deprecated 
API) which require a KF5 version dep upgrade too...

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

To: meven, dfaure
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24685: Replace usage of SlaveBase::config()->readEntry by SlaveBase::configValue

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24685

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> cullmann wrote in clang-format.cmake:75
> I have no strong opinion on that, we can remove that or keep it.

(b) looks good to me, and more importantly, I like the goal of being as close 
as possible to the Qt coding style.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24752: WIP: Use a separate worker thread to run the actual deletion of files

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  `slotReport` isn't the only problem, all of the subjob handling etc. seems 
very racy to me.
  
  I suggest to start from scratch and write the smallest possible worker, whose 
only job is to delete a list of files, and report progress/completion via 
signal/slots or invokeMethod.

INLINE COMMENTS

> deletejob.cpp:161
> +connect(d_func()->m_reportTimer, &QTimer::timeout, this, [this] () {
> +d_func()->slotReport();
> +});

This calls slotReport in the main thread, where it will read many values from 
the worker. Those values are written by the worker, from a secondary thread. 
This is the very definition of a race condition.

I thought the plan (in the task's pseudo-code) was to move into a worker, as 
little data as possible. And to never access that data from two concurrent 
threads.

In this patch, almost all of the members are moved to the worker, which creates 
race conditions all around.

I'm updating my "thread sanitizer" build of Qt and KIO to prove it, but I'm 
pretty sure :-)

> deletejob.cpp:180
> +ownThread = QThread::currentThread();
> +m_ioThread = new QThread();
> +ioWorker.moveToThread(m_ioThread);

Where is the corresponding `delete` statement?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24752

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24261: Modernize code: use range-based for loop in more places

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  morerangebasedforloops

REVISION DETAIL
  https://phabricator.kde.org/D24261

To: kossebau, dfaure
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24793: [Konqueror] Remove KonqView::setActiveComponent()

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R226 Konqueror

BRANCH
  ahmad/setactiveComponent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24793

To: ahmadsamir, dfaure, stefanocrocco
Cc: kde-frameworks-devel

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas marked 3 inline comments as done.
hallas added a comment.


  @bruns - I have now refactored the patch so that it uses the `getmntent` 
functions for parsing the mtab file, so I think this patch is pretty much ready 
for a serious review ;)
  
  Also - please take a look at the strings that the end user sees, I am not 
sure if they are optimal.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas updated this revision to Diff 68324.
hallas added a comment.


  Rewrite to use the getmntent function for parsing the mtab file

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21235?vs=68230&id=68324

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns