date:20191122

KDE CI: Frameworks » kglobalaccel » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Fixed!

2019-11-22 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 05:16:13 +
 Build duration:
1 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kxmlgui » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Fixed!

2019-11-22 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20FreeBSDQt5.13/53/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 05:16:12 +
 Build duration:
1 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Failing!

2019-11-22 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/32/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 05:16:12 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 170 lines...][2019-11-23T05:17:03.955Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-11-23T05:17:03.955Z] -- Looking for __GLIBC__[2019-11-23T05:17:03.955Z] -- Looking for __GLIBC__ - not found[2019-11-23T05:17:03.955Z] -- Performing Test _OFFT_IS_64BIT[2019-11-23T05:17:04.498Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-11-23T05:17:04.498Z] -- Performing Test HAVE_DATE_TIME[2019-11-23T05:17:04.498Z] -- Performing Test HAVE_DATE_TIME - Success[2019-11-23T05:17:04.757Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2019-11-23T05:17:04.757Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/kpackage/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for KPackage.[2019-11-23T05:17:04.757Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-11-23T05:17:04.757Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-11-23T05:17:04.757Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-11-23T05:17:05.030Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-11-23T05:17:05.030Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-11-23T05:17:05.030Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-11-23T05:17:05.030Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot [2019-11-23T05:17:05.298Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2019-11-23T05:17:05.298Z] -- The following features have been enabled:[2019-11-23T05:17:05.298Z] [2019-11-23T05:17:05.298Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-11-23T05:17:05.298Z] [2019-11-23T05:17:05.298Z] -- The following OPTIONAL packages have been found:[2019-11-23T05:17:05.298Z] [2019-11-23T05:17:05.298Z]  * KF5DocTools (required version >= 5.64.0), Tools to generate documentation[2019-11-23T05:17:05.298Z] [2019-11-23T05:17:05.298Z] -- The following REQUIRED packages have been found:[2019-11-23T05:17:05.298Z] [2019-11-23T05:17:05.298Z]  * Qt5DBus[2019-11-23T05:17:05.298Z]  * Qt5 (required version >= 5.11.0)[2019-11-23T05:17:05.298Z]  * KF5Archive (required version >= 5.64.0)[2019-11-23T05:17:05.298Z]  * Gettext[2019-11-23T05:17:05.298Z]  * KF5I18n (required version >= 5.64.0)[2019-11-23T05:17:05.298Z]  * KF5CoreAddons (required version >= 5.64.0)[2019-11-23T05:17:05.298Z]  * ECM (required version >= 1.6.0), Extra CMake Modules., [2019-11-23T05:17:05.298Z]  * Doxygen (required version >= 1.8.13)[2019-11-23T05:17:05.298Z]Needed for API dox QCH file generation[2019-11-23T05:17:05.298Z]  * QHelpGenerator, Part of Qt5 tools[2019-11-23T05:17:05.298Z]Needed for API dox QCH file generation[2019-11-23T05:17:05.298Z]  * Qt5Core[2019-11-23T05:17:05.298Z]  * Qt5Test (required version >= 5.11.0)[2019-11-23T05:17:05.298Z]Required for tests[2019-11-23T05:17:05.298Z] [2019-11-23T05:17:05.298Z] -- Configuring done[2019-11-23T05:17:05.298Z] CMake Warning (dev) in src/kpackage/CMakeLists.txt:[2019-11-23T05:17:05.298Z]   AUTOMOC: CMAKE_AUTOMOC_RELAXED_MODE is deprecated an will be removed in the[2019-11-23T05:17:05.298Z]   future.  Consider disabling it and converting the target KF5Package to[2019-11-23T05:17:05.298Z]   regular mode.[2019-11-23T05:17:05.298Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2019-11-23T05:17:05.298Z] [2019-11-23T05:17:05.558Z] -- Generating done[2019-11-23T05:17:05.558Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kpackage/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-11-23T05:17:07.259Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2019-11-23T05:17:07.519Z] Scanning dependencies of target testpackage-rcc[2019-11-23T05:17:07.519Z] Scanning dependencies of target Qt5Core_QCH[2019-11-23T05:17:07.519Z] Scanning dependencies of target KF5Package_autogen[2019-11-23T05:17:07.519Z] Scanning dependencies of target mockhandler_autogen[2019-11-23T05:17:07.519Z] Scanning dependencies of target docs-kpackagetool-kpackagetool5-1[2019-11-23T05:17:07.519Z] Scanning dependencies of target KF5CoreAddons_QCH[2019-11-23T05:17:07.519Z] [  1%] Automatic MOC for target KF5Package[2019-11-23T05:17:07.519Z] [  1%] Built target Qt5Core_QCH[2019-11-23T05:17:07.519Z] [  4%] Automatic MOC for target mockhandler[2019-11-23T05:17:07.519Z] [  4%] Generating

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 330 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/330/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 Nov 2019 04:25:05 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32525/61669)37%
(16023/43574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9335/10107)46%
(4361/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8319/14553)49%
(4320/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4667/8289)43%
(2023/4745)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 214 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/214/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 23 Nov 2019 04:25:06 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32518/61669)37%
(16009/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9335/10107)46%
(4360/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8317/14553)49%
(4310/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4672/8289)43%
(2024/4741)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(676/1208)40%
(381/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 199 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/199/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 04:25:06 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/43/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 22 Nov 2019 21:47:00 +
 Build duration:
4 min 56 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D25315: KDirModel: implement showing "/" as a root node, optionally

2019-11-22 Thread David Faure

dfaure updated this revision to Diff 70183.
dfaure added a comment.


  Add ShowRoot flag, excellent idea!

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25315?vs=69778=70183

BRANCH
  2019_11_kdirmodel_root

REVISION DETAIL
  https://phabricator.kde.org/D25315

AFFECTED FILES
  autotests/kdirmodeltest.cpp
  autotests/kdirmodeltest.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kdirmodeltest_gui.cpp

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 213 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/213/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 22 Nov 2019 19:31:03 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32528/61670)37%
(16034/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9335/10107)46%
(4364/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8317/14553)49%
(4325/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4667/8289)43%
(2021/4741)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 329 - Still unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/329/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 22 Nov 2019 19:31:03 +
 Build duration:
8 min 28 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32513/61669)37%
(16029/43574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9335/10107)46%
(4367/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8304/14552)49%
(4313/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4671/8289)43%
(2025/4745)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 198 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/198/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 22 Nov 2019 19:31:03 +
 Build duration:
8 min 25 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread David Faure

dfaure added a comment.


  Thanks for the notification. Fixed in 
https://commits.kde.org/kio/7b28a8326717c1afea05ff97e528fe014afd16d2

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25446

To: nicolasfella, #frameworks, dfaure
Cc: bcooksley, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25315: KDirModel: implement showing "/" as a root node, optionally

2019-11-22 Thread Méven Car

meven added inline comments.

INLINE COMMENTS

> kdirmodel.h:78
> + * Otherwise, this is equivalent to dirLister()->openUrl(url, flags)
> + * @param url   the URL of the directory whose contents should be 
> listed. The item for this directory will NOT be shown, the model starts at 
> its children.
> + *  If the URL is an empty QUrl, the model will display a 
> root "/" node.

Would it make sense to instead of interpreting QUrl(), OpenUrlFlag would 
include a ShowRoot flag ?
I really like enums are they are explicit from the callee perspective.
Then it could call expandAllParentsUntil directly, this would allow in a single 
call to openUrl with a shown root node.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread Ben Cooksley

bcooksley added a comment.


  This change is incompatible with Qt 5.12 - see 
https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/326/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25446

To: nicolasfella, #frameworks, dfaure
Cc: bcooksley, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 66 - Fixed!

2019-11-22 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/66/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 22 Nov 2019 18:39:32 +
 Build duration:
3 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.65.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6887/9083)43%
(10774/24837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2873/2966)48%
(6172/12735)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(869/1298)36%
(1002/2811)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 61 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/61/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 22 Nov 2019 18:39:32 +
 Build duration:
1 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Méven Car

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:8f1952ecb156: Add a descriptive warning when 
inotify_add_watch returned ENOSPC (authored by meven).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25460?vs=70171=70172

REVISION DETAIL
  https://phabricator.kde.org/D25460

AFFECTED FILES
  src/lib/io/kdirwatch.cpp

To: meven, #frameworks, ngraham, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Méven Car

meven updated this revision to Diff 70171.
meven added a comment.


  Improve messange : ENOSPC for inotify_add_watch only when inotify_add_watch 
was reached

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25460?vs=70150=70171

BRANCH
  arcpatch-D25460

REVISION DETAIL
  https://phabricator.kde.org/D25460

AFFECTED FILES
  src/lib/io/kdirwatch.cpp

To: meven, #frameworks, ngraham, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Nathaniel Graham

ngraham accepted this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25460

To: meven, #frameworks, ngraham, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Aleix Pol Gonzalez

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25460

To: meven, #frameworks, ngraham, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 212 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/212/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 22 Nov 2019 16:55:36 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32496/61669)37%
(15961/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9335/10107)46%
(4366/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8311/14553)49%
(4290/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8289)43%
(2020/4741)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(660/1208)37%
(353/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 197 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/197/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 22 Nov 2019 16:55:35 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 328 - Still Failing!

2019-11-22 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/328/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 22 Nov 2019 16:55:35 +
 Build duration:
1 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 1275 lines...][2019-11-22T16:57:11.242Z]   708 | return KSslKey(d->sock.privateKey());[2019-11-22T16:57:11.242Z]   |^[2019-11-22T16:57:11.242Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp:20:[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.h:47:71: note: declared here[2019-11-22T16:57:11.242Z]47 | class KIOCORE_DEPRECATED_VERSION(5, 65, "Use QSslKey") KIOCORE_EXPORT KSslKey[2019-11-22T16:57:11.242Z]   |   ^~~[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp: At global scope:[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp:711:40: warning: ���KSslCipher��� is deprecated: Since 5.65. Use QSslCipher [-Wdeprecated-declarations][2019-11-22T16:57:11.242Z]   711 | KSslCipher KTcpSocket::sessionCipher() const[2019-11-22T16:57:11.242Z]   |^[2019-11-22T16:57:11.242Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp:20:[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.h:79:74: note: declared here[2019-11-22T16:57:11.242Z]79 | class KIOCORE_DEPRECATED_VERSION(5, 65, "Use QSslCipher") KIOCORE_EXPORT KSslCipher[2019-11-22T16:57:11.242Z]   |  ^~[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp: In member function ���KSslCipher KTcpSocket::sessionCipher() const���:[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp:713:46: warning: ���KSslCipher��� is deprecated: Since 5.65. Use QSslCipher [-Wdeprecated-declarations][2019-11-22T16:57:11.242Z]   713 | return KSslCipher(d->sock.sessionCipher());[2019-11-22T16:57:11.242Z]   |  ^[2019-11-22T16:57:11.242Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp:20:[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.h:79:74: note: declared here[2019-11-22T16:57:11.242Z]79 | class KIOCORE_DEPRECATED_VERSION(5, 65, "Use QSslCipher") KIOCORE_EXPORT KSslCipher[2019-11-22T16:57:11.242Z]   |  ^~[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp: At global scope:[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp:724:41: warning: ���KSslCipher��� is deprecated: Since 5.65. Use QSslCipher [-Wdeprecated-declarations][2019-11-22T16:57:11.242Z]   724 | void KTcpSocket::setCiphers(const QList )[2019-11-22T16:57:11.242Z]   | ^~[2019-11-22T16:57:11.242Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp:20:[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.h:79:74: note: declared here[2019-11-22T16:57:11.242Z]79 | class KIOCORE_DEPRECATED_VERSION(5, 65, "Use QSslCipher") KIOCORE_EXPORT KSslCipher[2019-11-22T16:57:11.242Z]   |  ^~[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp: In member function ���void KTcpSocket::setCiphers(const QList&)���:[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp:729:28: warning: ���KSslCipher��� is deprecated: Since 5.65. Use QSslCipher [-Wdeprecated-declarations][2019-11-22T16:57:11.242Z]   729 | for (const KSslCipher  : ciphers) {[2019-11-22T16:57:11.242Z]   |^[2019-11-22T16:57:11.242Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.cpp:20:[2019-11-22T16:57:11.242Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.h:79:74: note: declared here[2019-11-22T16:57:11.242Z]79 | class KIOCORE_DEPRECATED_VERSION(5, 65, "Use QSslCipher") KIOCORE_EXPORT KSslCipher[2019-11-22T16:57:11.242Z]   |

D25465: [DropJob] Minor grammar fix in API docs

2019-11-22 Thread Ahmad Samir

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:81167ec94f8d: [DropJob] Minor grammar fix in API docs 
(authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25465?vs=70167=70169

REVISION DETAIL
  https://phabricator.kde.org/D25465

AFFECTED FILES
  src/widgets/dropjob.h

To: ahmadsamir, #frameworks, dfaure, apol, dhaumann
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25465: [DropJob] Minor grammar fix in API docs

2019-11-22 Thread Dominik Haumann

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Lgtm.

REPOSITORY
  R241 KIO

BRANCH
  l-grammar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25465

To: ahmadsamir, #frameworks, dfaure, apol, dhaumann
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25465: [DropJob] Minor grammar fix in API docs

2019-11-22 Thread Ahmad Samir

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  l-grammar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25465

AFFECTED FILES
  src/widgets/dropjob.h

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25461: [KCM GridDelegate] Use non-attached ToolTip

2019-11-22 Thread Nathaniel Graham

ngraham added a comment.


  This works for you? I still see that the tooltip for KCM grid delegates 
disappears almost immediately with this patch.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25461

To: broulik, #plasma, mart
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/34/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 22 Nov 2019 14:26:57 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 15 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 81 - Fixed!

2019-11-22 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/81/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 22 Nov 2019 14:26:57 +
 Build duration:
9 min 39 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.65.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(240/268)90%
(240/268)85%
(27194/32075)53%
(10952/20609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12503/12574)50%
(6590/13095)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6344/7481)64%
(1829/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)84%
(7893/9364)64%
(2356/3687)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread John Hayes

jhayes added a comment.


  arc amend is not allowing me to correct the typo, it just shows it and then
  back to command line.

REPOSITORY
  R267 Oxygen Icons

BRANCH
  ebn-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25448

To: jhayes, apol
Cc: meven, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread John Hayes

jhayes added a comment.


  No I don't have a commit account yet
  
  John Hayes

REPOSITORY
  R267 Oxygen Icons

BRANCH
  ebn-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25448

To: jhayes, apol
Cc: meven, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 196 - Still unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/196/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 22 Nov 2019 11:40:23 +
 Build duration:
1 hr 22 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23579: port ftp slave to new error reporting system

2019-11-22 Thread David Faure

dfaure added a comment.


  @sitter The unittest just failed on CI, the test can't connect to the local 
FTP server, can you look into it?
  
  
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/211/testReport/junit/projectroot/autotests/kiocore_ftptest/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23579

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25461: [KCM GridDelegate] Use non-attached ToolTip

2019-11-22 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Then it can just follow the style's delay and timeout.

TEST PLAN
  - Hovered grid delegate which had a tooltip, showed after a short delay, 
stated for like 10 seconds
  - Hovered grid delegate without one, didn't get any tooltip

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25461

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-22 Thread Méven Car

meven added a comment.

  In D25117#565877 , @dfaure wrote:

  > Nice, I didn't realize the slave had 5 seconds to cleanup after being 
killed, I thought it died immediately
  >  (genericsig_handler in slavebase.cpp).

  I didn't realize there was a timeout somewhere.

  > Hmm, the Windows code is probably a no-op then, there's no signal handler 
there to call setKillFlags(), so no opportunity to cleanup before dying.
  >  Some research indicates that we'd have to use `SetConsoleCtrlHandler` on 
Windows for similar behaviour. 
  >  
https://stackoverflow.com/questions/2007516/is-there-a-posix-sigterm-alternative-on-windows-a-gentle-kill-for-console-ap
  >  
https://danielkaes.wordpress.com/2009/06/04/how-to-catch-kill-events-with-python/

  I did not realize that.

  > OK so at least it seems feasible, so I won't object to the commit even if 
it doesn't implement it on Windows.

  This would be a regression in Windows, because of the code removal in 
`filecopyjob.cpp`.
  I need to implement signal handling for windows starting at 
`KIOPrivate::sendTerminateSignal` in `kioglobal_p_win.cpp`. currently it simply 
kills directly the process. and use `SetConsoleCtrlHandler` as you suggested to 
fix this.
  Or add a `#ifdef Q_OS_WIN` block in filecopyjob.cpp.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread Méven Car

meven added a comment.


  Please run `arc amend` to fix the typo in the commit message before landing.

REPOSITORY
  R267 Oxygen Icons

BRANCH
  ebn-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25448

To: jhayes, apol
Cc: meven, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread Méven Car

meven retitled this revision from "EBN cleanup of autests transfer protocal" to 
"EBN cleanup of autests transfer protocol".

REPOSITORY
  R267 Oxygen Icons

BRANCH
  ebn-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25448

To: jhayes, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 211 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/211/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 22 Nov 2019 11:40:21 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32519/61669)37%
(16017/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9335/10107)46%
(4361/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8314/14553)49%
(4316/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8289)43%
(2020/4741)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 327 - Still Failing!

2019-11-22 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/327/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 22 Nov 2019 11:40:21 +
 Build duration:
5 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 799 lines...][2019-11-22T11:44:30.760Z]   |   ^[2019-11-22T11:44:30.760Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.cpp:22:[2019-11-22T11:44:30.760Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.h:167:24: note: declared here[2019-11-22T11:44:30.760Z]   167 | QT_MOC_COMPAT void aboutToCreate(KIO::Job *job, const QList );[2019-11-22T11:44:30.760Z]   |^[2019-11-22T11:44:30.760Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.cpp: In member function ���void KIO::CopyJobPrivate::slotResultCopyingFiles(KJob*)���:[2019-11-22T11:44:30.760Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.cpp:1341:51: warning: ���void KIO::CopyJob::aboutToCreate(KIO::Job*, const QList&)��� is deprecated: Since 5.2. To be removed due to no known users [-Wdeprecated-declarations][2019-11-22T11:44:30.760Z]  1341 | emit q->aboutToCreate(q, files);[2019-11-22T11:44:30.760Z]   |   ^[2019-11-22T11:44:30.760Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.cpp:22:[2019-11-22T11:44:30.760Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.h:167:24: note: declared here[2019-11-22T11:44:30.760Z]   167 | QT_MOC_COMPAT void aboutToCreate(KIO::Job *job, const QList );[2019-11-22T11:44:30.760Z]   |^[2019-11-22T11:44:30.760Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.cpp: In member function ���void KIO::CopyJobPrivate::slotResultErrorCopyingFiles(KJob*)���:[2019-11-22T11:44:30.760Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.cpp:1527:39: warning: ���void KIO::CopyJob::aboutToCreate(KIO::Job*, const QList&)��� is deprecated: Since 5.2. To be removed due to no known users [-Wdeprecated-declarations][2019-11-22T11:44:30.760Z]  1527 | emit q->aboutToCreate(q, files);[2019-11-22T11:44:30.760Z]   |   ^[2019-11-22T11:44:30.760Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.cpp:22:[2019-11-22T11:44:30.760Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/copyjob.h:167:24: note: declared here[2019-11-22T11:44:30.760Z]   167 | QT_MOC_COMPAT void aboutToCreate(KIO::Job *job, const QList );[2019-11-22T11:44:30.760Z]   |^[2019-11-22T11:44:34.100Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filejob.cpp.o[2019-11-22T11:44:35.500Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mkdirjob.cpp.o[2019-11-22T11:44:36.910Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mkpathjob.cpp.o[2019-11-22T11:44:38.859Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kpasswdserverloop.cpp.o[2019-11-22T11:44:39.808Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kpasswdserverclient.cpp.o[2019-11-22T11:44:43.142Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kremoteencoding.cpp.o[2019-11-22T11:44:43.735Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/sessiondata.cpp.o[2019-11-22T11:44:45.168Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slavebase.cpp.o[2019-11-22T11:44:48.483Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/dataslave.cpp.o[2019-11-22T11:44:49.414Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/dataprotocol.cpp.o[2019-11-22T11:44:50.787Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/desktopexecparser.cpp.o[2019-11-22T11:44:52.160Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/emptytrashjob.cpp.o[2019-11-22T11:44:53.547Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/authinfo.cpp.o[2019-11-22T11:44:54.931Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slaveinterface.cpp.o[2019-11-22T11:44:56.323Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slave.cpp.o[2019-11-22T11:44:58.226Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job_error.cpp.o[2019-11-22T11:44:59.624Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job.cpp.o[2019-11-22T11:45:01.005Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filecopyjob.cpp.o[2019-11-22T11:45:02.916Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/listjob.cpp.o[2019-11-22T11:45:04.841Z] [ 15%] Building CXX

D25438: Ftp ioslave: Fix ProxyUrls parameter passing

2019-11-22 Thread Méven Car

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:04edc7738cc3: Ftp ioslave: Fix ProxyUrls parameter 
passing (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25438?vs=70104=70152

REVISION DETAIL
  https://phabricator.kde.org/D25438

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: meven, trufanov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Méven Car

meven created this revision.
meven added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  CCBUG: 387663

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25460

AFFECTED FILES
  src/lib/io/kdirwatch.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25442: Set application name and version on the knshandler tool

2019-11-22 Thread Dan Leinir Turthra Jensen

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:06bd561dceb1: Set application name and version on the 
knshandler tool (authored by leinir).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25442?vs=70113=70148

REVISION DETAIL
  https://phabricator.kde.org/D25442

AFFECTED FILES
  src/kpackage-install-handlers/kns/CMakeLists.txt
  src/kpackage-install-handlers/kns/knshandlerversion.h.in
  src/kpackage-install-handlers/kns/main.cpp

To: leinir, #frameworks, #plasma, starbuck, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25442: Set application name and version on the knshandler tool

2019-11-22 Thread Dan Leinir Turthra Jensen

leinir added a comment.


  Thanks :)
  
  In D25442#566050 , @apol wrote:
  
  > Is the store having a big impact from this handler?
  
  
  We think it might very possibly - specifically, look and feel is under 
suspicion, but... suspicions are just that without proof, and being able to 
work it out properly is just handy in general :)

REPOSITORY
  R252 Framework Integration

BRANCH
  set-knshandler-name-and-version (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25442

To: leinir, #frameworks, #plasma, starbuck, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25442: Set application name and version on the knshandler tool

2019-11-22 Thread Aleix Pol Gonzalez

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Is the store having a big impact from this handler?

REPOSITORY
  R252 Framework Integration

BRANCH
  set-knshandler-name-and-version (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25442

To: leinir, #frameworks, #plasma, starbuck, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25448: EBN cleanup of autests transfer protocal

2019-11-22 Thread Aleix Pol Gonzalez

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Do you have a commit account?

REPOSITORY
  R267 Oxygen Icons

BRANCH
  ebn-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25448

To: jhayes, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25429: JavaScript/TypeScript React: rename syntax definitions

2019-11-22 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:503dab974d34: JavaScript/TypeScript React: rename syntax 
definitions (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25429?vs=70079=70145

REVISION DETAIL
  https://phabricator.kde.org/D25429

AFFECTED FILES
  autotests/html/test.jsx.html
  autotests/html/test.tsx.html
  autotests/syntaxrepository_test.cpp
  data/syntax/html.xml
  data/syntax/javascript-react.xml
  data/syntax/markdown.xml
  data/syntax/typescript-react.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25443: [chmodjob] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella

nicolasfella updated this revision to Diff 70143.
nicolasfella added a comment.


  - Use stack

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25443?vs=70138=70143

BRANCH
  ll

REVISION DETAIL
  https://phabricator.kde.org/D25443

AFFECTED FILES
  src/core/chmodjob.cpp

To: nicolasfella, #frameworks
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-11-22 Thread David Faure

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.

  In D25010#565502 , @meven wrote:

  > Funny thing is that statx includes always the name, down to syscall we can 
save at most STATX_SIZE , STATX_TYPE fields in NoDetails case.

  But this isn't only about configuring the statx call. If we are not 
interested in the name, we save the QFile::decodeName() call (8 bit to 16 bit 
conversion, triggering also a memory allocation).

  > I updated kdiroperator.cpp to use it line 748 since it only checks if a 
file exists.
  >  This code path is not run for local files anyway.

  Right -- at some point we should also use the details stuff in other ioslaves 
:-)

  > Another thing comes to mind
  >  If we allow not to fill KIO::UDSEntry::UDS_LINK_DEST but when 
KIO::ResolveSymlink is passed, we can save the second STAT by not passing 
AT_SYMLINK_NOFOLLOW to the first statx.

  Interesting, but given that statx isn't always available, I fear this will 
make the code quite complex?

  > So perhaps we want to expose a detail for this use case : that is add a 
IncludeLinkDest to KIO::StatDetail removing this field for StatDetail::Basic.
  >  I am not sure we have any use case currently though.

  I need to think more about this, gotta go.

INLINE COMMENTS

> kossebau wrote in directorysizejob.cpp:137
> More correct would be KIOCORE_BUILD_DEPRECATED_SINCE(5, 65)., not ENABLE here 
> and in the other cpp files.

Now that I look at this again, we do NOT want to follow symlinks here.

This was a bug in the existing code.

In Dolphin we want to display the size of the target file (more useful 
information than the size of the symlink itself), but when calculating 
directory size, we do NOT want to follow the symlink, the target size does not 
count.

These new flags allow to fix this long-standing bug.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25435: [Network Ioslave] Add Display name to network:/

2019-11-22 Thread Méven Car

meven added inline comments.

INLINE COMMENTS

> ltoscano wrote in Messages.sh:2
> This does not work as it is, because it does not look into the 
> subdirectories. Hint for testing:
> https://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-to-create.html
> 
> I'm going to fix it (replace *.cpp with $(find . -name '*.cpp') )

Thanks I may the wrong assumption $XGETTEXT was recursive.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: ltoscano, broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

Re: kconfig-elektra

2019-11-22 Thread David Faure

On samedi 16 novembre 2019 12:22:08 CET k...@markus-raab.org wrote:
> >> 2. If Elektra finds a merge conflict between the KConfig objects and the
> >> 
> >>configuration files on the disc, should we then do a 3-way merge
> >>which prefers "ours" or should we ask the user with a KDialog how to
> >>proceed?
> > 
> > what's the scenario that might lead to this happening?
> 
> Someone presses "save" in a configuration dialog but this change would
> overwrite another change in the configuration file done by another
> process (e.g. another application (instance), some CM tool, manual
> modification of the INI file, ...).
> 
> Steps to reproduce such an issue:
> 1. Start the application, let us assume this is the only point in time
>where the application reads the configuration.
> 2. Modify the INI file of the application externally.
> 3. Press save in the configuration dialog of the application.

(IIRC) what KConfig does in such a case, at step 3, is to reload the file from 
disk but without touching the entries marked as dirty (i.e. modified by the 
configuration dialog), and then save the result.
I.e. this will overwrite entries modified by both, but preserve entries 
modified externally and not modified by the application.

The comment at the top of KConfigIniBackend::parseConfig (and near the call to 
that method) confirms this.

I can't pinpoint the actual logic in the code itself though (I don't know it 
in full details).

I strongly suggest that the elektra backend has the same logic, it has worked 
well for 20 years.

> > It sounds to me like a dialog would bother the
> > user with low-level technical things that they won't understand nor know
> > how to resolve.
> 
> In the case the person had manually edited the INI file (or used Elektra
> to modify the configuration) him/herself, he/she would understand. If
> some other tool changed the INI file, it would be exactly as you say.

Yep, and we have no way to know which one it is, so let's play it safe.

> > If you can describe how this can happen, then we can conclude what
> > should be happening automatically to fix the situation.
> 
> Unfortunately, we cannot know if the "other change" happened by the user
> him/herself or by some script the user is not aware of.
> 
> The current situation is that *all* changes some other process did are
> lost. 

Not good, worse than the INI backend.

> In Elektra and automatic 3-way merging in favor of "ours", you
> will only lose changes in which there are actually conflicts.

Sounds good.

> So it will
> already be an improvement -- even without a dialog. If you do not want
> to lose *any* changes, an interaction is needed (like "git merge" has).

I don't think we need this. If I check a checkbox in a dialog, then I want 
that option to be ON, I don't need to confirm that again in a different 
(merge) dialog.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 195 - Failure!

2019-11-22 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/195/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 22 Nov 2019 09:10:10 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   CONSOLE OUTPUT
  [...truncated 11912 lines...][2019-11-22T09:23:22.596Z] 48/60 Test #48: kiofilewidgets-kfilecustomdialogtest .   Passed5.13 sec[2019-11-22T09:23:22.596Z]   Start 49: kiofilewidgets-knewfilemenutest[2019-11-22T09:23:28.388Z] 49/60 Test #49: kiofilewidgets-knewfilemenutest ..   Passed5.71 sec[2019-11-22T09:23:28.388Z]   Start 50: kiofilewidgets-kfilecopytomenutest[2019-11-22T09:23:31.191Z] 50/60 Test #50: kiofilewidgets-kfilecopytomenutest ...   Passed2.73 sec[2019-11-22T09:23:31.191Z]   Start 51: kiofilewidgets-kfileplacesmodeltest[2019-11-22T09:23:36.811Z] 51/60 Test #51: kiofilewidgets-kfileplacesmodeltest ..   Passed5.12 sec[2019-11-22T09:23:36.811Z]   Start 52: kiofilewidgets-kfileplacesviewtest[2019-11-22T09:23:40.430Z] 52/60 Test #52: kiofilewidgets-kfileplacesviewtest ...   Passed4.51 sec[2019-11-22T09:23:40.430Z]   Start 53: kiofilewidgets-kurlrequestertest[2019-11-22T09:23:43.970Z] 53/60 Test #53: kiofilewidgets-kurlrequestertest .   Passed3.47 sec[2019-11-22T09:23:43.970Z]   Start 54: kiocore-ksambashareprivatetest[2019-11-22T09:23:44.282Z] 54/60 Test #54: kiocore-ksambashareprivatetest ...   Passed0.18 sec[2019-11-22T09:23:44.282Z]   Start 55: kioslave-httpheadertokenizetest[2019-11-22T09:23:44.593Z] 55/60 Test #55: kioslave-httpheadertokenizetest ..   Passed0.46 sec[2019-11-22T09:23:44.593Z]   Start 56: kioslave-httpheaderdispositiontest[2019-11-22T09:23:44.911Z] 56/60 Test #56: kioslave-httpheaderdispositiontest ...   Passed0.35 sec[2019-11-22T09:23:44.911Z]   Start 57: kioslave-httpauthenticationtest[2019-11-22T09:23:45.526Z] 57/60 Test #57: kioslave-httpauthenticationtest ..   Passed0.58 sec[2019-11-22T09:23:45.526Z]   Start 58: kioslave-httpobjecttest[2019-11-22T09:23:46.156Z] 58/60 Test #58: kioslave-httpobjecttest ..   Passed0.57 sec[2019-11-22T09:23:46.156Z]   Start 59: httpfiltertest[2019-11-22T09:23:46.156Z] 59/60 Test #59: httpfiltertest ...   Passed0.10 sec[2019-11-22T09:23:46.156Z]   Start 60: kioslave-kcookiejartest[2019-11-22T09:23:47.214Z] 60/60 Test #60: kioslave-kcookiejartest ..   Passed0.96 sec[2019-11-22T09:23:47.214Z] [2019-11-22T09:23:47.214Z] 93% tests passed, 4 tests failed out of 60[2019-11-22T09:23:47.214Z] [2019-11-22T09:23:47.214Z] Total Test time (real) = 394.28 sec[2019-11-22T09:23:47.214Z] [2019-11-22T09:23:47.214Z] The following tests FAILED:[2019-11-22T09:23:47.214Z] 	  5 - kiocore-kmountpointtest (Failed)[2019-11-22T09:23:47.214Z] 	 23 - kiocore-http_jobtest (Child aborted)[2019-11-22T09:23:47.214Z] 	 32 - kiowidgets-kdirlistertest (Failed)[2019-11-22T09:23:47.214Z] 	 33 - kiowidgets-kdirmodeltest (Failed)[2019-11-22T09:23:47.523Z] Errors while running CTest[2019-11-22T09:23:47.856Z] XIO:  fatal IO error 4 (Interrupted system call) on X server ":90"[2019-11-22T09:23:47.856Z]   after 50962 requests (50962 known processed) with 0 events remaining.[Pipeline] junit[2019-11-22T09:23:48.578Z] Recording test results[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Capturing Installation)[Pipeline] sh[2019-11-22T09:23:50.546Z] + python3 -u ci-tooling/helpers/capture-install.py --product Frameworks --project kio --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.13 --divertedTo '/usr/home/jenkins/workspace/Frameworks/kio/kf5-qt5 FreeBSDQt5.13/install-divert/' --installedTo /home/jenkins/install-prefix/[2019-11-22T09:23:56.149Z] Exception: Error reading SSH protocol banner[2019-11-22T09:23:56.149Z] Traceback (most recent call last):[2019-11-22T09:23:56.149Z]   File "/usr/local/lib/python3.6/site-packages/paramiko/transport.py", line 2211, in _check_banner[2019-11-22T09:23:56.149Z] buf = self.packetizer.readline(timeout)[2019-11-22T09:23:56.149Z]   File

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 210 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/210/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 22 Nov 2019 09:10:11 +
 Build duration:
7 min 12 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/404)66%
(266/404)54%
(33154/61685)38%
(16554/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)93%
(9361/10107)46%
(4386/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)58%
(8423/14566)49%
(4358/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8289)43%
(2020/4741)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 326 - Failure!

2019-11-22 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/326/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 22 Nov 2019 09:10:11 +
 Build duration:
2 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 1273 lines...][2019-11-22T09:12:08.483Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.h:24,[2019-11-22T09:12:08.483Z]  from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp:21:[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.h:110:73: note: declared here[2019-11-22T09:12:08.483Z]   110 | class KIOCORE_DEPRECATED_VERSION(5, 65, "Use QSslError") KIOCORE_EXPORT KSslError[2019-11-22T09:12:08.483Z]   | ^[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp:148:24: warning: ���void KSslCertificateRule::setIgnoredErrors(const QList&)��� is deprecated: Since 5.64. Use KSslCertificateRule::setIgnoredErrors(const QList &) [-Wdeprecated-declarations][2019-11-22T09:12:08.483Z]   148 | setIgnoredErrors(el);[2019-11-22T09:12:08.483Z]   |^[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp:129:6: note: declared here[2019-11-22T09:12:08.483Z]   129 | void KSslCertificateRule::setIgnoredErrors(const QList )[2019-11-22T09:12:08.483Z]   |  ^~~[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp: In member function ���QList KSslCertificateRule::filterErrors(const QList&) const���:[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp:185:34: warning: ���bool KSslCertificateRule::isErrorIgnored(KSslError::Error) const��� is deprecated: Since 5.64. Use KSslCertificateRule::isErrorIgnored(QSslError::SslError) [-Wdeprecated-declarations][2019-11-22T09:12:08.483Z]   185 | if (!isErrorIgnored(error)) {[2019-11-22T09:12:08.483Z]   |  ^[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp:115:6: note: declared here[2019-11-22T09:12:08.483Z]   115 | bool KSslCertificateRule::isErrorIgnored(KSslError::Error error) const[2019-11-22T09:12:08.483Z]   |  ^~~[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp: At global scope:[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp:192:7: warning: ���KSslError��� is deprecated: Since 5.65. Use QSslError [-Wdeprecated-declarations][2019-11-22T09:12:08.483Z]   192 | QList KSslCertificateRule::filterErrors(const QList ) const[2019-11-22T09:12:08.483Z]   |   ^[2019-11-22T09:12:08.483Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.h:24,[2019-11-22T09:12:08.483Z]  from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp:21:[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.h:110:73: note: declared here[2019-11-22T09:12:08.483Z]   110 | class KIOCORE_DEPRECATED_VERSION(5, 65, "Use QSslError") KIOCORE_EXPORT KSslError[2019-11-22T09:12:08.483Z]   | ^[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp:192:64: warning: ���KSslError��� is deprecated: Since 5.65. Use QSslError [-Wdeprecated-declarations][2019-11-22T09:12:08.483Z]   192 | QList KSslCertificateRule::filterErrors(const QList ) const[2019-11-22T09:12:08.483Z]   |^[2019-11-22T09:12:08.483Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.h:24,[2019-11-22T09:12:08.483Z]  from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ksslcertificatemanager.cpp:21:[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/core/ktcpsocket.h:110:73: note: declared here[2019-11-22T09:12:08.483Z]   110 | class KIOCORE_DEPRECATED_VERSION(5, 65, "Use QSslError") KIOCORE_EXPORT KSslError[2019-11-22T09:12:08.483Z]   | ^[2019-11-22T09:12:08.483Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:521453d71075: [kcoredirlister] Port away from QLinkedList 
(authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25446?vs=70137=70142

REVISION DETAIL
  https://phabricator.kde.org/D25446

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25454: Prevent a crash when deleting a device Interface

2019-11-22 Thread Méven Car

meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Double free of DeviceInterfacePrivate::m_backendObject
  
  BUG: 414200
  FIXED-IN: 5.65
  
  #7  QPointer::data (this=0x28) at 
/usr/include/x86_64-linux-gnu/qt5/QtCore/qpointer.h:85
  #8  Solid::DeviceInterfacePrivate::backendObject (this=0x20) at 
/home/meven/kde/src/solid/src/solid/devices/frontend/deviceinterface.cpp:110
  #9  0x7efd423e4cbd in Solid::DevicePrivate::~DevicePrivate 
(this=0x55b4921e4820, __in_chrg=) at 
/home/meven/kde/src/solid/src/solid/devices/frontend/device.cpp:222
  #10 0x7efd423e4e2d in Solid::DevicePrivate::~DevicePrivate 
(this=0x55b4921e4820, __in_chrg=) at 
/home/meven/kde/src/solid/src/solid/devices/frontend/device.cpp:219
  #11 0x7efd423e6437 in Solid::DeviceManagerPrivate::~DeviceManagerPrivate 
(this=0x55b4921c93e0, __in_chrg=) at 
/usr/include/c++/9/bits/atomic_base.h:413
  #12 0x7efd423e80ad in Solid::DeviceManagerPrivate::~DeviceManagerPrivate 
(this=0x55b4921c93e0, __in_chrg=) at 
/home/meven/kde/src/solid/src/solid/devices/frontend/devicemanager.cpp:49

REPOSITORY
  R245 Solid

BRANCH
  prevent-crash

REVISION DETAIL
  https://phabricator.kde.org/D25454

AFFECTED FILES
  src/solid/devices/frontend/device.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread David Faure

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  kdili

REVISION DETAIL
  https://phabricator.kde.org/D25446

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25443: [chmodjob] Port away from QLinkedList

2019-11-22 Thread David Faure

dfaure added a comment.


  Indeed there's no reserve for std::list.
  
  And std::queue is FIFO, not LIFO.
  
  std::stack would be a more appropriate container here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham

D25389: Verify modes of the session config file

2019-11-22 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:911b7fa44f2a: Verify modes of the session config file 
(authored by nibags, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25389?vs=69969=70139

REVISION DETAIL
  https://phabricator.kde.org/D25389

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25443: [chmodjob] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella

nicolasfella marked 3 inline comments as done.
nicolasfella added inline comments.

INLINE COMMENTS

> bruns wrote in chmodjob.cpp:115
> For efficiency, probably do a
> `m_infos.reserve(m_infos.capacity() + m_lstItems.size());`
> here.

Does that make sense with a linked list?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham

D25443: [chmodjob] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella

nicolasfella updated this revision to Diff 70138.
nicolasfella added a comment.


  - Move

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25443?vs=70114=70138

BRANCH
  ll

REVISION DETAIL
  https://phabricator.kde.org/D25443

AFFECTED FILES
  src/core/chmodjob.cpp

To: nicolasfella, #frameworks
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham

D25435: [Network Ioslave] Add Display name to network:/

2019-11-22 Thread Luigi Toscano

ltoscano added inline comments.

INLINE COMMENTS

> Messages.sh:2
> +#! /usr/bin/env bash
> +$XGETTEXT *.cpp -o $podir/kio5_network.pot

This does not work as it is, because it does not look into the subdirectories. 
Hint for testing:
https://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-to-create.html

I'm going to fix it (replace *.cpp with $(find . -name '*.cpp') )

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: ltoscano, broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 325 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/325/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 22 Nov 2019 08:30:40 +
 Build duration:
9 min 30 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/404)66%
(266/404)54%
(33157/61685)38%
(16550/43574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)93%
(9359/10107)46%
(4384/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)58%
(8433/14567)49%
(4360/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8289)43%
(2022/4745)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella

nicolasfella updated this revision to Diff 70137.
nicolasfella added a comment.


  - Remove reserver

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25446?vs=70117=70137

BRANCH
  kdili

REVISION DETAIL
  https://phabricator.kde.org/D25446

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 209 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/209/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 22 Nov 2019 08:30:40 +
 Build duration:
8 min 26 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/404)66%
(266/404)54%
(33164/61686)38%
(16552/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)93%
(9361/10107)46%
(4384/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)58%
(8434/14567)49%
(4360/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4671/8289)43%
(2023/4741)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 194 - Still Unstable!

2019-11-22 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/194/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 22 Nov 2019 08:30:40 +
 Build duration:
7 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25429: JavaScript/TypeScript React: rename syntax definitions

2019-11-22 Thread Christoph Cullmann

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok for me :=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  rename-def-jsx

REVISION DETAIL
  https://phabricator.kde.org/D25429

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25445: [copyjob] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ddedd87456c9: [copyjob] Port away from QLinkedList 
(authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25445?vs=70116=70136

REVISION DETAIL
  https://phabricator.kde.org/D25445

AFFECTED FILES
  src/core/copyjob.cpp

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

67 matches

Mail list logo