D14218: Introduce a test to make sure we're not offering duplicated icons

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  Doesn't seem relevant anymore

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: dfaure, ngraham, andreask, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25727: Expose enum to the metaobject compiler

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R307 KPeople

BRANCH
  arcpatch-D25727

REVISION DETAIL
  https://phabricator.kde.org/D25727

To: apol, jbbgameich, davidedmundson
Cc: lnj, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25727: Expose enum to the metaobject compiler

[Aleix Pol Gonzalez]

apol updated this revision to Diff 70997.
apol added a comment.


  Alternative approach without Q_NAMESPACE_EXPORT, which is too new

REPOSITORY
  R307 KPeople

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25727?vs=70895&id=70997

BRANCH
  arcpatch-D25727

REVISION DETAIL
  https://phabricator.kde.org/D25727

AFFECTED FILES
  src/declarative/CMakeLists.txt
  src/declarative/peopleqmlplugin.cpp
  src/widgets/actions.h

To: apol, jbbgameich
Cc: lnj, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D8773: Improve discoverability of drag-and-drop of toolbar actions

[Nathaniel Graham]

ngraham added a comment.


  Haha yes almost exactly like that! Maybe today I'd use a sheet instead of a 
separate dialog window. But I have great faith that the 2019 David is able to 
conquer the challenges of 2009. :)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D8773

To: elvisangelaccio, #frameworks, #vdg, dfaure, ngraham
Cc: davidedmundson, kde-frameworks-devel, broulik, ngraham, colomar, abetts, 
apol, LeGast00n, GB_2, michaelh, bruns

D8773: Improve discoverability of drag-and-drop of toolbar actions

[David Edmundson]

davidedmundson added a comment.


  > That is excellent!
  
  That was from my very first PlanetKDE blog post back in 2009 :D
  
  And from what I recall, I hit that exact issue you're describing and gave up.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D8773

To: elvisangelaccio, #frameworks, #vdg, dfaure, ngraham
Cc: davidedmundson, kde-frameworks-devel, broulik, ngraham, colomar, abetts, 
apol, LeGast00n, GB_2, michaelh, bruns

D25720: Fix shortcut conflict between Cut and Delete File

[Albert Astals Cid]

aacid added a comment.


  > Trying to assign anything to Shift+Delete shows the "conflicting shortcuts" 
error dialog.
  
  But that's fine, no?
  
  I mean this is the user assigning a shortcut that already exists, not any 
different than the user trying to assign Ctrl+C somewhere. If he doesn't like 
the conflict, she can go to the other one and remove it, no?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25720

To: ngraham, #frameworks, cfeck
Cc: aspotashev, bcooksley, davidedmundson, aacid, apol, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D8773: Improve discoverability of drag-and-drop of toolbar actions

[David Faure]

dfaure added a comment.


  That is excellent! But in the implementation, mind the "multiple 
kxmlgui-clients" use case, like konqueror or kdevelop (or kate I guess). It can 
make things tricky...
  (you drop between two clients, how do you know which one should memorize the 
action into its kxmlgui file?)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D8773

To: elvisangelaccio, #frameworks, #vdg, dfaure, ngraham
Cc: davidedmundson, kde-frameworks-devel, broulik, ngraham, colomar, abetts, 
apol, LeGast00n, GB_2, michaelh, bruns

D25755: Replace iterators with range-based for

[Albert Astals Cid]

aacid added a comment.


  https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html
  
  is something you can use if you feel bored, i made it mandatory in poppler

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D25755

To: nicolasfella, #frameworks
Cc: dhaumann, dfaure, ahmadsamir, broulik, aacid, apol, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D8773: Improve discoverability of drag-and-drop of toolbar actions

[David Edmundson]

davidedmundson added a comment.


  @ngraham 
  Like this: http://static.davidedmundson.co.uk/toolbars_change_01.ogv ?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D8773

To: elvisangelaccio, #frameworks, #vdg, dfaure, ngraham
Cc: davidedmundson, kde-frameworks-devel, broulik, ngraham, colomar, abetts, 
apol, LeGast00n, GB_2, michaelh, bruns

D25767: KAutoSaveFile: add a unit test to check max. filename length

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kautosavefiletest.cpp:84
> +// In KAutoSaveFilePrivate::tempFile() the name of the kautosavefile 
> that's going to be created
> +// is concatinated in the form:
> +// fileName + junk.truncated + protocol + _ + path.truncated + junk

typo: concatenated

> kautosavefiletest.cpp:95
> +QString s;
> +s = s.fill(QLatin1Char('b'), 80);
> +// create a long path that:

`fill` modifies the string, no need for `s = `

> kautosavefiletest.cpp:98
> +// - exceeds NAME_MAX (255)
> +// - is less than the maximum allowed path length, PATH_MAX (4096)
> +//   see e.g. /usr/include/linux/limits.h

Let's hope none of the supported OSes have a smaller PATH_MAX :)
FreeBSD, Windows, macOS, who knows what limits they have.

> kautosavefiletest.cpp:108
> +QFile file;
> +file.setFileName(path + QLatin1Char('/') + 
> QLatin1String("testFile.txt"));
> +

merge with previous line using the QFile(QString) constructor

> kautosavefiletest.cpp:110
> +
> +qInfo() << "The lenght of the whole path to the file:" << 
> file.fileName().size();
> +

Doesn't belong in unittests

> kautosavefiletest.cpp:112
> +
> +QUrl normalFile = 
> QUrl::fromLocalFile(QFileInfo(file).absoluteFilePath());
> +

Why the QFileInfo::absoluteFilePath call? It's already an absolute path.

REPOSITORY
  R244 KCoreAddons

BRANCH
  l-kautosave-unittest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25767

To: ahmadsamir, #frameworks, mpyne, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D8774: Show Configure Toolbars dialog as modal

[Nathaniel Graham]

ngraham added a comment.


  Oops, sorry! I added comments to D8773 .

REPOSITORY
  R263 KXmlGui

BRANCH
  modal-toolbar-dialog

REVISION DETAIL
  https://phabricator.kde.org/D8774

To: elvisangelaccio, #frameworks, dfaure
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D8773: Improve discoverability of drag-and-drop of toolbar actions

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: kde-frameworks-devel.


  In D8773#167625 , @colomar wrote:
  
  > In D8773#167607 , @broulik wrote:
  >
  > > What I would like to see is that when you open the "Edit Toolbar" dialog 
that you then can drag around tool bar buttons and drag them from and to the 
dialog, like Firefox does it and how @colomar suggested. Given you can already 
re-arrange toolbar buttons whilst said dialog is open, what needs to be added 
is the ability to drag those from and to the dialog.
  >
  >
  > Yes, exactly. The closer to Firefox' "Customize" UX, the better. No more 
separate dialogs, just one mode where you configure your UI.
  
  
  Yeah. macOS also does something similar, showing a sheet of items that can be 
dragged-and-dropped to and from the toolbar:
  F7801420: Finder toolbar customization.jpg 

  
  I think we should do something like that here. It would be a huge usability 
improvement.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D8773

To: elvisangelaccio, #frameworks, #vdg, dfaure, ngraham
Cc: kde-frameworks-devel, broulik, ngraham, colomar, abetts, apol, LeGast00n, 
GB_2, michaelh, bruns

D24489: KAutosaveFile not respecting maximum filename length

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Why is this not in the same commit as the related unittest, as is common 
practice?

INLINE COMMENTS

> kautosavefile.cpp:70
>  const QString protocol(managedFile.scheme());
> -const QString path(managedFile.adjusted(QUrl::RemoveFilename | 
> QUrl::StripTrailingSlash).path());
> -QString name(managedFile.fileName());
> +const QString 
> path(QString::fromLatin1(QUrl::toPercentEncoding(managedFile.adjusted(QUrl::RemoveFilename
>  | QUrl::StripTrailingSlash).path()).constData()));
> +QString 
> name(QString::fromLatin1(QUrl::toPercentEncoding(managedFile.fileName()).constData()));

That's one long line, hard to read. Extract a `const QByteArray encodedPath = 
QUrl::toPercentEncoding()` ?

[pre-existing: I would personally call this `QByteArray encodedDirectory` and 
`QString directory`, to my eyes path is a full path including filename. At 
least it's ambiguous, unlike directory]

Also check if you can remove the .constData(). `QString::fromLatin1(const 
QByteArray &str)` was added in Qt 5.0, this code is probably older than that.

> kautosavefile.cpp:71
> +const QString 
> path(QString::fromLatin1(QUrl::toPercentEncoding(managedFile.adjusted(QUrl::RemoveFilename
>  | QUrl::StripTrailingSlash).path()).constData()));
> +QString 
> name(QString::fromLatin1(QUrl::toPercentEncoding(managedFile.fileName()).constData()));
>  

and a `const QByteArray encodedFileName = ...`, for symmetry.

Simpler than toPercentEncoding: use `QUrl::fileName(QUrl::FullyEncoded)`.
However this wouldn't work for `encodedDirectory` above, because it wouldn't 
encode '/'.

> kautosavefile.cpp:76
>  // Subtract 1 for the _ char, 3 for the padding separator, 5 is for the 
> .lock
> -int pathLengthLimit = FILENAME_MAX - NamePadding - name.size() - 
> protocol.size() - 9;
> +int pathLengthLimit = NAME_MAX - NamePadding - name.size() - 
> protocol.size() - 9;
>  

(while changing this line: prepend `const`)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D8774: Show Configure Toolbars dialog as modal

[David Faure]

dfaure added a comment.


  The description says this depends on D8773 
 which isn't approved.

REPOSITORY
  R263 KXmlGui

BRANCH
  modal-toolbar-dialog

REVISION DETAIL
  https://phabricator.kde.org/D8774

To: elvisangelaccio, #frameworks, dfaure
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D25775: Check cursor_open return value

[David Edmundson]

davidedmundson created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This will only fail if something else has already gone wrong, but I was 
  hitting a crash in the baloo runner on the first cursor fetch.
  
  We may as well catch it and handle it gracefully with the right error message.

TEST PLAN
  Unit tests

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25775

AFFECTED FILES
  src/engine/postingdb.cpp

To: davidedmundson
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/49/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 05 Dec 2019 22:17:13 +
 Build duration:
3 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D25743: Expose IndexerState enum to QML

[Nathaniel Graham]

ngraham added a comment.


  Thanks, now it compiles! I'm not sure it's working perfectly though. I 
updated D25447  to use this, but it's 
claiming that my indexer is suspended, while ` balooctl status` disagrees.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25743

To: davidedmundson, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/46/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Dec 2019 21:14:24 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/81/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Dec 2019 21:14:24 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D25753: EBN extra-cmake-modules transport cleanup

[Allen Winter]

winterz added a comment.


  please send me a list of urls that don't have https:  and I'll add them to 
the whitelist

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25753

To: jhayes, apol, cgiboudeaux
Cc: winterz, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
GB_2, bencreasy, michaelh, ngraham, bruns

D25770: Several enhancements to gitolite syntax definition.

[Michael Hansen]

zrax updated this revision to Diff 70989.
zrax added a comment.


  Fix "+" in keywords to not act as a word break.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25770?vs=70974&id=70989

BRANCH
  gitolite-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25770

AFFECTED FILES
  autotests/folding/gitolite.conf.fold
  autotests/html/gitolite.conf.html
  autotests/input/gitolite.conf
  autotests/reference/gitolite.conf.ref
  data/syntax/gitolite.xml

To: zrax, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D14218: Introduce a test to make sure we're not offering duplicated icons

[Nathaniel Graham]

ngraham added a comment.


  @apol we have a duplicate test in breeze-icons now; is this still relevant?

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: dfaure, ngraham, andreask, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25753: EBN extra-cmake-modules transport cleanup

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:f082ed20e6a8: EBN extra-cmake-modules transport cleanup 
(authored by jhayes, committed by cgiboudeaux).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25753?vs=70973&id=70986#toc

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25753?vs=70973&id=70986

REVISION DETAIL
  https://phabricator.kde.org/D25753

AFFECTED FILES
  cmake/FindSphinx.cmake
  find-modules/FindLibExiv2.cmake
  find-modules/FindOpenEXR.cmake
  kde-modules/clang-format.cmake

To: jhayes, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D25753: EBN extra-cmake-modules transport cleanup

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  ebn-transport-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25753

To: jhayes, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D25743: Expose IndexerState enum to QML

[David Edmundson]

davidedmundson updated this revision to Diff 70985.
davidedmundson edited the summary of this revision.
davidedmundson added a comment.


  redo without the export

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25743?vs=70906&id=70985

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25743

AFFECTED FILES
  src/file/indexerstate.h
  src/qml/experimental/CMakeLists.txt
  src/qml/experimental/baloomonitorplugin.cpp
  src/qml/experimental/monitor.h

To: davidedmundson, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D8774: Show Configure Toolbars dialog as modal

[Nathaniel Graham]

ngraham added a comment.
Herald added a subscriber: kde-frameworks-devel.


  Can this land?

REPOSITORY
  R263 KXmlGui

BRANCH
  modal-toolbar-dialog

REVISION DETAIL
  https://phabricator.kde.org/D8774

To: elvisangelaccio, #frameworks, dfaure
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D24433: Move URL parsing methods from kioslave to query object

[Nathaniel Graham]

ngraham added a comment.


  @bruns, is this good to go now?

REPOSITORY
  R293 Baloo

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven, ngraham, astippich
Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 215 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/215/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 05 Dec 2019 20:33:35 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23730: Add new protocol for 7z archives

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:f3e66c240d1e: Add new protocol for 7z archives (authored 
by nhiga, committed by ngraham).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23730?vs=65416&id=70982

REVISION DETAIL
  https://phabricator.kde.org/D23730

AFFECTED FILES
  archive/CMakeLists.txt
  archive/kio_archive.cpp
  archive/kio_archivebase.cpp
  archive/sevenz.protocol

To: nhiga, meven, ngraham, dfaure, pino, cfeck
Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, pberestov, 
iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D23780: Add new protocol for 7z archives

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:58800b4d2abd: Add new protocol for 7z archives (authored 
by nhiga, committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23780?vs=65622&id=70980

REVISION DETAIL
  https://phabricator.kde.org/D23780

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: nhiga, #frameworks, cfeck, pino, dfaure, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25755: Replace iterators with range-based for

[Dominik Haumann]

dhaumann added a comment.


  >>> Do we dislike iterators now?
  >> 
  >> We don't, and they still make sense for when you need the `key`, but range 
for is just much nier to look at :)
  > 
  > I'm fine with that statement. But are we going to be reviewing changing all 
the KDE code from iterators to range for? Feels like an overkill to me.
  
  It's much more than just the fact "it's nicer to look at". It' i) more 
compact, but more importantly, it's ii) simpler to reason about. When having 
iterator-based loops you cannot immediately say "we iterate over all items". It 
could be that the iterator is not increased, or it is increased in the body 
scope multiple times. Contrary, with range-based for loops you know what you 
*always* iterate over all items (except if there is a shortcut break/return 
statement).
  
  The only nitpick is: In the Qt world this is sometimes tricky when using 
range-based for loops over non-const Qt containers, which leads to a detach. So 
review is typically necessary.
  
  PS: Yes, it should be `const QString &dir` and `const QString &directory`, 
i.e. references and not copies.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D25755

To: nicolasfella, #frameworks
Cc: dhaumann, dfaure, ahmadsamir, broulik, aacid, apol, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D25770: Several enhancements to gitolite syntax definition.

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good. But does the highlighting work for `RW+CD`? I am wondering 
whether `+` needs to be added to the weakDeliminator list?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  gitolite-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25770

To: zrax, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D25770: Several enhancements to gitolite syntax definition.

[Michael Hansen]

zrax created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
zrax requested review of this revision.

REVISION SUMMARY
  - Add more keywords, including access modes
  - Highlight include directives properly
  - Fix group highlighting to not match email addresses
  - Minor default style tweaks
  - Add unit tests for gitolite syntax

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  gitolite-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25770

AFFECTED FILES
  autotests/folding/gitolite.conf.fold
  autotests/html/gitolite.conf.html
  autotests/input/gitolite.conf
  autotests/reference/gitolite.conf.ref
  data/syntax/gitolite.xml

To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25753: EBN extra-cmake-modules transport cleanup

[John Hayes]

jhayes updated this revision to Diff 70973.
jhayes added a comment.


  - Corrected URL as review comments
  
  Corrected url to http://www.sphinx-doc.org

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25753?vs=70958&id=70973

BRANCH
  ebn-transport-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25753

AFFECTED FILES
  cmake/FindSphinx.cmake
  find-modules/FindLibExiv2.cmake
  find-modules/FindOpenEXR.cmake
  kde-modules/clang-format.cmake

To: jhayes, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D25753: EBN extra-cmake-modules transport cleanup

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work 
without www)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25753

To: jhayes, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

[Ahmad Samir]

ahmadsamir added a comment.


  Unit test added in D25767 . AFAICS, both 
points addressed in this diff are needed to fix the referenced bug.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

[Ahmad Samir]

ahmadsamir added a reviewer: mpyne.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25767: KAutoSaveFile: add a unit test to check max. filename length

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, mpyne.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  In KAutoSaveFilePrivate::tempFile() the name of the kautosavefile that's
  going to be created is generated using the filename and the absolute path
  and some other bits (e.g. a string generated using KRandom). The problem
  with that approach is that sometimes really long filenames can get created.
  This unit test ensures that the checks in tempFile() work correctly and
  generate filenames that don't exceed NAME_MAX (255 bytes/chars for Linux),
  otherwise the files can't be opened.
  
  Depends on D24489 
  
  References:
  /usr/include/linux/limits.h
  https://www.gnu.org/software/libc/manual/html_node/Limits-for-Files.html
  https://www.kernel.org/doc/Documentation/filesystems/path-lookup.rst

TEST PLAN
  - Running `ctest -R autosavefiletest` fails with current master
  - Apply the patch from D24489 , and the 
test should pass

REPOSITORY
  R244 KCoreAddons

BRANCH
  l-kautosave-unittest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25767

AFFECTED FILES
  autotests/kautosavefiletest.cpp
  autotests/kautosavefiletest.h

To: ahmadsamir, #frameworks, mpyne
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

[Ahmad Samir]

ahmadsamir added a dependent revision: D25767: KAutoSaveFile: add a unit test 
to check max. filename length.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

[Nathaniel Graham]

ngraham added a comment.


  In D25720#572326 , @aacid wrote:
  
  > Apps that need both should be aware of it and remove the secondary Cut 
shortcut.
  >
  > Or if you want to be mega fancy you can make kactioncollection (or 
something in xmlgui) do that
  
  
  I don't think we should make apps work around problems in a framework. You 
can also see the issue in System Setting itself. Trying to assign anything to 
Shift+Delete shows the "conflicting shortcuts" error dialog.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25720

To: ngraham, #frameworks, cfeck
Cc: aspotashev, bcooksley, davidedmundson, aacid, apol, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D25755: Replace iterators with range-based for

[Ahmad Samir]

ahmadsamir added a subscriber: dfaure.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D25755

To: nicolasfella, #frameworks
Cc: dfaure, ahmadsamir, broulik, aacid, apol, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25755: Replace iterators with range-based for

[Ahmad Samir]

ahmadsamir added a comment.


  If we're going to iterate over a whole container, from cbegin() to cend(), 
and the container isn't going to change in the loop, then IMHO (H for humble 
:)) range-for would convey the intention better and make the code slightly 
easier to read/look cleaner.
  
  Kind of like one of the main reasons foreach was used (in, as we're finding 
out now that we're removing it from KDE code, many many places) instead of 
iterator/index based for loops, to begin with.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D25755

To: nicolasfella, #frameworks
Cc: ahmadsamir, broulik, aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25753: EBN extra-cmake-modules transport cleanup

[John Hayes]

jhayes updated this revision to Diff 70958.
jhayes added a comment.


  - Corrections made per review comments.
  
  Reverted some non-working URL's back to http and updated one URL to the 
correct address

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25753?vs=70925&id=70958

BRANCH
  ebn-transport-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25753

AFFECTED FILES
  find-modules/FindLibExiv2.cmake
  find-modules/FindOpenEXR.cmake
  kde-modules/clang-format.cmake

To: jhayes, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

Re: D25448: EBN cleanup of autotests transfer protocol

[John Hayes]

I don't have commit access, could someone land this for me?

On Sat, 23 Nov 2019, 9:07 am John Hayes, 
wrote:

> jhayes updated this revision to Diff 70220.
> jhayes retitled this revision from "EBN cleanup of autests transfer
> protocol" to "EBN cleanup of autotests transfer protocol".
> jhayes added a comment. View Revision 
>
> Corrected summary typo
>
> *REPOSITORY*
> R267 Oxygen Icons
>
> *CHANGES SINCE LAST UPDATE*
> https://phabricator.kde.org/D25448?vs=70121&id=70220
>
> *BRANCH*
> ebn-cleanup (branched from master)
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D25448
>
> *AFFECTED FILES*
> autotests/newlinetest.cpp
>
> *To: *jhayes, apol
> *Cc: *meven, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
> ngraham, bruns
>

D25755: Replace iterators with range-based for

[Aleix Pol Gonzalez]

apol added a comment.


  In D25755#572575 , @broulik wrote:
  
  > In D25755#572418 , @apol wrote:
  >
  > > Do we dislike iterators now?
  >
  >
  > We don't, and they still make sense for when you need the `key`, but range 
for is just much nier to look at :)
  
  
  I'm fine with that statement. But are we going to be reviewing changing all 
the KDE code from iterators to range for? Feels like an overkill to me.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D25755

To: nicolasfella, #frameworks
Cc: broulik, aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

feverfew added a comment.


  Thanks for the reviews everyone! I'll update the diff and respond to the 
comments no later than Tuesday

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, 
LeGast00n, GB_2, michaelh, bruns

D25755: Replace iterators with range-based for

[Kai Uwe Broulik]

broulik added a comment.


  In D25755#572418 , @apol wrote:
  
  > Do we dislike iterators now?
  
  
  We don't, and they still make sense for when you need the `key`, but range 
for is just much nier to look at :)

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D25755

To: nicolasfella, #frameworks
Cc: broulik, aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25755: Replace iterators with range-based for

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> kded.cpp:622
>  const QStringList dirs = 
> QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, 
> QStringLiteral("kconf_update"), QStandardPaths::LocateDirectory);
> -for (QStringList::ConstIterator it = dirs.begin();
> -it != dirs.end();
> -++it) {
> -QString path = *it;
> +for (const QString dir : dirs) {
> +QString path = dir;

& for dir

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D25755

To: nicolasfella, #frameworks
Cc: aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25757: EBN purpose constructor cleanup

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  ebn-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25757

To: jhayes, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

[Ahmad Samir]

ahmadsamir added a comment.


  FWIW, this still doesn't work:
  
  - Open a pdf in okular
  - Invoke save as, navigate via the keyboard, highlight/select a dir, Enter, 
the file is saved inside that dir and the dialog closes

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25420

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[Arjen Hiemstra]

ahiemstra added a comment.


  Sure, I can land it after saturday.

REPOSITORY
  R275 KItemModels

BRANCH
  columnheadersmodel

REVISION DETAIL
  https://phabricator.kde.org/D25311

To: ahiemstra, davidedmundson
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Though maybe we should wait till after tagging (Saturday) ?

REPOSITORY
  R275 KItemModels

BRANCH
  columnheadersmodel

REVISION DETAIL
  https://phabricator.kde.org/D25311

To: ahiemstra, davidedmundson
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[Arjen Hiemstra]

ahiemstra marked an inline comment as done.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25311

To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 70948.
ahiemstra added a comment.


  - Add missing layoutChanged/reset signals

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25311?vs=70437&id=70948

BRANCH
  columnheadersmodel

REVISION DETAIL
  https://phabricator.kde.org/D25311

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kcolumnheadersmodeltest.cpp
  src/core/CMakeLists.txt
  src/core/kcolumnheadersmodel.cpp
  src/core/kcolumnheadersmodel.h
  src/qml/plugin.cpp
  tests/qml/columnheaders.qml

To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dfaure wrote in desktopexecparser.cpp:356
> This blocks.
> 
> I don't mind much myself, but I know some people had a mandate to remove as 
> many blocking calls as possible from KRun and related code. Or was that only 
> avoiding blocking I/O because of network mounts? [which this patch is all 
> about adding more of...]. @broulik ?

Blocking IO is worse than blocking DBus, still not nice, especially given the 
"job"-like nature of `KRun` I would expect it to be fully async.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, 
LeGast00n, GB_2, michaelh, bruns

D25493: EBN kmoretools cleanup transport protocol

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:19bbe83f5527: EBN kmoretools cleanup transport protocol 
(authored by jhayes, committed by cgiboudeaux).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25493?vs=70226&id=70943

REVISION DETAIL
  https://phabricator.kde.org/D25493

AFFECTED FILES
  tests/kmoretools/kmoretoolstest_interactive.cpp

To: jhayes, dhaumann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R283:49ed872608fa: Install .pri file for KAuthCore (authored 
by volkov, committed by cgiboudeaux).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25397?vs=69987&id=70944

REVISION DETAIL
  https://phabricator.kde.org/D25397

AFFECTED FILES
  src/CMakeLists.txt

To: volkov, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 229 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/229/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Dec 2019 09:42:23 +
 Build duration:
7 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.65.0.xmlacc/KF5PlasmaQuick-5.65.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)35%
(44/124)35%
(44/124)35%
(4615/13302)26%
(2515/9661)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(873/920)52%
(439/852)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(772/2302)26%
(395/1491)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/59)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1532/3561)33%
(956/2894)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)48%
(749/1576)37%
(384/1045)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)7%
(7/105)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(589/2038)19%
(324/1700)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1187)0%
(0/996)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 100 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/100/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 05 Dec 2019 09:42:24 +
 Build duration:
4 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 107 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/107/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Dec 2019 09:42:23 +
 Build duration:
4 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.65.0.xmlacc/KF5PlasmaQuick-5.65.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)35%
(44/124)35%
(44/124)35%
(4611/13301)26%
(2514/9661)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(873/920)52%
(439/852)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(772/2302)26%
(395/1491)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/59)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1532/3561)33%
(956/2894)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)48%
(749/1576)37%
(384/1045)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)7%
(7/105)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(585/2037)19%
(323/1700)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1187)0%
(0/996)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

D25742: move backgroundhints managment in Applet

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:af861eb2a438: move backgroundhints managment in Applet 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25742?vs=70907&id=70941

REVISION DETAIL
  https://phabricator.kde.org/D25742

AFFECTED FILES
  src/plasma/applet.cpp
  src/plasma/applet.h
  src/plasma/private/applet_p.h
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/appletinterface.h

To: mart, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 80 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/80/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Dec 2019 09:37:46 +
 Build duration:
3 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/45/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Dec 2019 09:37:46 +
 Build duration:
3 min 25 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D25752: EBN extra-cmake-modules comments spelling cleanup

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:9f441190a36a: EBN extra-cmake-modules comments spelling 
cleanup (authored by jhayes, committed by cgiboudeaux).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25752?vs=70924&id=70940

REVISION DETAIL
  https://phabricator.kde.org/D25752

AFFECTED FILES
  find-modules/rules_engine.py
  find-modules/sip_generator.py
  modules/ECMGenerateExportHeader.cmake
  tests/ECMGenerateExportHeaderTest/CMakeLists.txt

To: jhayes, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25448: EBN cleanup of autotests transfer protocol

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R267:b86aa2b10f7d: EBN cleanup of autotests transfer protocol 
(authored by jhayes, committed by cgiboudeaux).

REPOSITORY
  R267 Oxygen Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25448?vs=70220&id=70939

REVISION DETAIL
  https://phabricator.kde.org/D25448

AFFECTED FILES
  autotests/newlinetest.cpp

To: jhayes, apol
Cc: meven, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25719: EBN KActivites transfer protocol cleanup

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R6:8c0352356062: EBN KActivites transfer protocol cleanup 
(authored by jhayes, committed by cgiboudeaux).

REPOSITORY
  R6 KActivities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25719?vs=70840&id=70938

REVISION DETAIL
  https://phabricator.kde.org/D25719

AFFECTED FILES
  src/lib/libKActivities.pc.cmake
  tests/imports/plasma-applet-org.kde.listactivitiestest.desktop

To: jhayes, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25721: EBN kdeclarative transfer protocol cleanup

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:342a575c0dd5: EBN kdeclarative transfer protocol cleanup 
(authored by jhayes, committed by cgiboudeaux).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25721?vs=70856&id=70937

REVISION DETAIL
  https://phabricator.kde.org/D25721

AFFECTED FILES
  CMakeLists.txt
  src/quickaddons/configmodule.h
  src/quickaddons/managedconfigmodule.h

To: jhayes, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25753: EBN extra-cmake-modules transport cleanup

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindCanberra.cmake:98
>  DESCRIPTION "Event sound library"
> -URL "http://0pointer.de/lennart/projects/libcanberra";
> +URL "https://0pointer.de/lennart/projects/libcanberra";
>  )

redirects to http://0pointer.net/ which is probably wrong.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25753

To: jhayes, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D25753: EBN extra-cmake-modules transport cleanup

[Christophe Giboudeaux]

cgiboudeaux requested changes to this revision.
cgiboudeaux added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:35
>  PROPERTIES
> -URL "http://sphinx-doc.org/";
> +URL "https://sphinx-doc.org/";
>  DESCRIPTION "Tool to generate documentation."

404. Please check

> FindCanberra.cmake:98
>  DESCRIPTION "Event sound library"
> -URL "http://0pointer.de/lennart/projects/libcanberra";
> +URL "https://0pointer.de/lennart/projects/libcanberra";
>  )

redirects to http://http://0pointer.net/ which is probably wrong.

> KDEInstallDirs.cmake:250
>  #  - we are on a 64 bits system
> -# reason is: amd64 ABI: http://www.x86-64.org/documentation/abi.pdf
> +# reason is: amd64 ABI: https://www.x86-64.org/documentation/abi.pdf
>  # For Debian with multiarch, use 'lib/${CMAKE_LIBRARY_ARCHITECTURE}' if

expired certificate, I recommend keeping http

> clang-format.cmake:29
>  
> -# base is WebKit coding style: http://www.webkit.org/coding/coding-style.html
> +# base is WebKit coding style: 
> https://www.webkit.org/coding/coding-style.html
>  # below are only things set that diverge from this style!

This address is now redirected to https://webkit.org/code-style-guidelines/

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25753

To: jhayes, apol, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns