D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

2019-12-26 Thread David Faure 
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kshorturifilter.cpp:437
> +// URLs using Qt's QRegularExpression class. This is hard-coded for 
> now.
>  // TODO: Make configurable at some point...
>  for (const URLHint  : qAsConst(m_urlHints)) {

(before I forget: this todo should be removed, `KShortUriFilter::configure()` 
does exactly that)

> kshorturifilter.h:101
>  URLHint(const QString , const QString , KUriFilterData::UriTypes 
> t = KUriFilterData::NetProtocol)
> -: regexp(QRegExp(r))
> +: hintRe(QRegularExpression(r))
>  , prepend(p)

(pre-existing) `hintRe(r)` would be enough

REPOSITORY
  R241 KIO

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26236

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26071: Avoid unwanted horizontal scrolling

2019-12-26 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable, thanks for taking care + happy x-mas ;=)

REPOSITORY
  R39 KTextEditor

BRANCH
  avoid-unwanted-horizontal-scrolling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26071

To: sars, #kate, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

2019-12-26 Thread Albert Astals Cid 
El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H. 
Kossebau va escriure:
> Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker Krause:
> > On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann wrote:
> > > Hi all,
> > > 
> > > in any case, maybe the discussed points should go to the KF6 workboard?
> > > https://phabricator.kde.org/project/view/310/
> > > 
> > > I indeed believe that consistency in the KF5 world is an important
> > > feature,
> > > so Friedrich does have a point here. Other framework additions had to
> > > adapt
> > > as well (what comes to my mind is renaming of KQuickCharts or
> > > KCalendarCore).
> > 
> > There is one important difference between KCalendarCore/KQuickCharts/etc and
> > Grantlee/QKeychain/etc though. The former had no previous release promising
> > a public API and therefore only KDE-internal users. The latter have such
> > releases and guarantees, and a significant KDE-external user base. That's
> > what makes me consider a transitional pragmatic exemption from certain
> > conventions, if we assume it would help to grow our external user base, and
> > thus the pool of potential contributors.
> 
> Having to make exemptions shows a principal design flaw though: if the idea 
> is 
> to pull in more libraries into KF, incl. some with previous releases & thus 
> existing userbase hoping on longer-term stable ABI, the same will also happen 
> in the KF6 series. And even for the currently discussed two libs Grantlee & 
> QKeychain it means at least 1 1/2 years & longer (assuming KF 6.0.0 is coming 
> then, and see how long kdelibs4 survived) for being just "exemptions".
> It's rather that the "exemptions" become part of the rules that way.

Which kind of exceptions are we speaking about?

ABI stability? or?

Cheers,
  Albert

> 
> And this would add exceptions which have to be found out about on a case-by-
> case base, as nothing in the individual name suggests which KF modules follow 
> all KF patterns and which not. Who in some wees remembers which modules are 
> exceptions and which not? So this makes things also for current KF modules 
> more complex and thus KF a worse meta-product.
> More complex and worse for all of users, support people & contributors.
> 
> Ruining the current consistent rules for some hunt on some bigger numbers of 
> "external user base" of KF by adding more libraries might result in a net 
> loss 
> of users though, as KF would get more confusing and thus less interesting.
> I guess at least I am not the only one who prefers simple & thus easy things 
> to create solutions from :)
> 
> So, IMHO if libraries do not follow KF rules, they should not use the 
> "KF"/"KDE Frameworks" label. Anything else just blurs the concepts and lowers 
> the quality of this meta-product.
> 
> My 2 cents as mainly KF user and only casual contributor :)
> 
> Cheers
> Friedrich
> 
> PS: And yes, even current KF set of libs has some pattern issues which 
> confuse 
> and thus steal time & joy now and then, so ideally would be fixed.
> Like KSyntaxHighlighting having a non-pattern repo name "syntax-highlighting" 
> still, where one expects it to be "ksyntaxhighlighting".
> Or modemmanager-qt/networkmanager-qt/bluez-qt being off the KDE naming 
> pattern, setting them apart a bit, not feeling full kdeframeworkish.
> 
> 
>

D26099: Port QRegExp to QRegularExpression

2019-12-26 Thread Ahmad Samir 
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26099

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26118: Port QRegExp to QRegularExpression

2019-12-26 Thread Ahmad Samir 
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D26118

To: ahmadsamir, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

2019-12-26 Thread Ahmad Samir 
ahmadsamir added a task: T12279: Port frameworks away from QRegExp.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26236

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread Ahmad Samir 
ahmadsamir added a task: T12279: Port frameworks away from QRegExp.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26226

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 83 - Still Unstable!

2019-12-26 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/83/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 26 Dec 2019 17:21:47 +
 Build duration:
2 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 135 - Failure!

2019-12-26 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/135/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 26 Dec 2019 17:21:47 +
 Build duration:
1 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 361 lines...][2019-12-26T17:22:50.081Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.o[2019-12-26T17:22:50.339Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.o[2019-12-26T17:22:50.917Z] [ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.o[2019-12-26T17:22:51.192Z] [ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginloader.cpp.o[2019-12-26T17:22:52.156Z] [ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginmetadata.cpp.o[2019-12-26T17:22:52.156Z] [ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/desktopfileparser.cpp.o[2019-12-26T17:22:52.156Z] [ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandom.cpp.o[2019-12-26T17:22:52.156Z] [ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandomsequence.cpp.o[2019-12-26T17:22:52.156Z] [ 17%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander.cpp.o[2019-12-26T17:22:52.415Z] [ 17%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kstringhandler.cpp.o[2019-12-26T17:22:53.805Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/ktexttohtml.cpp.o[2019-12-26T17:22:53.805Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4migration.cpp.o[2019-12-26T17:22:53.805Z] [ 19%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4configmigrator.cpp.o[2019-12-26T17:22:53.805Z] [ 19%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformat.cpp.o[2019-12-26T17:22:53.805Z] [ 20%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformatprivate.cpp.o[2019-12-26T17:22:54.077Z] [ 20%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kosrelease.cpp.o[2019-12-26T17:22:55.490Z] [ 21%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kprocesslist.cpp.o[2019-12-26T17:22:55.759Z] [ 21%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kshell.cpp.o[2019-12-26T17:22:55.759Z] [ 22%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/caching/kshareddatacache.cpp.o[2019-12-26T17:22:56.019Z] [ 22%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander_unix.cpp.o[2019-12-26T17:22:56.019Z] [ 23%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/klistopenfilesjob_unix.cpp.o[2019-12-26T17:22:56.287Z] [ 23%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kuser_unix.cpp.o[2019-12-26T17:22:56.560Z] [ 24%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kshell_unix.cpp.o[2019-12-26T17:22:56.560Z] [ 24%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kprocesslist_unix.cpp.o[2019-12-26T17:22:56.820Z] [ 25%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/ECMQmLoader-kcoreaddons5_qt.cpp.o[2019-12-26T17:22:56.820Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/text/kmacroexpander_unix.cpp:48:53: note: #pragma message: TODO: Import these methods into Qt[2019-12-26T17:22:56.820Z]48 | #pragma message("TODO: Import these methods into Qt")[2019-12-26T17:22:56.820Z]   | ^[2019-12-26T17:22:57.077Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/util/klistopenfilesjob_unix.cpp: In member function ���void KListOpenFilesJobPrivate::lsofFinished(int, QProcess::ExitStatus)���:[2019-12-26T17:22:57.077Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/util/klistopenfilesjob_unix.cpp:69:35: error: variable ���const QVector pidList��� has initializer but incomplete type[2019-12-26T17:22:57.077Z]69 | const QVector pidList = out.splitRef(QRegularExpression(QStringLiteral("\\s+")), QString::SkipEmptyParts);[2019-12-26T17:22:57.077Z]   |   ^~~[2019-12-26T17:22:57.077Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/util/klistopenfilesjob_unix.cpp:69:125: error: invalid use of incomplete type ���class QVector���[2019-12-26T17:22:57.077Z]69 | const QVector pidList = out.splitRef(QRegularExpression(QStringLiteral("\\s+")), QString::SkipEmptyParts);[2019-12-26T17:22:57.077Z]   | ^[2019-12-26T17:22:57.077Z] In file included from /usr/include/qt5/QtCore/qglobal.h:1204,[2019-12-26T17:22:57.077Z]  from

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread Ahmad Samir 
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:4bcf55e06c2f: [KListOpenFilesJob] Use QString::splitRef() 
(authored by ahmadsamir).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26226?vs=72207=72216

REVISION DETAIL
  https://phabricator.kde.org/D26226

AFFECTED FILES
  src/lib/util/klistopenfilesjob_unix.cpp

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  l-splitref (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26226

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

2019-12-26 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 72213.
ahmadsamir retitled this revision from "Port QRegExp to QRegularExpression (and 
some QStringRef) optimisation" to "Port QRegExp to QRegularExpression (and some 
QStringRef optimisation)".
ahmadsamir added a comment.


  Fix commit message typo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26236?vs=72209=72213

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26236

AFFECTED FILES
  autotests/kurifiltertest.cpp
  src/core/kprotocolmanager.cpp
  src/core/krecentdocument.cpp
  src/ioslaves/help/kio_help.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/kpac/script.cpp
  src/urifilters/localdomain/localdomainurifilter.cpp
  src/urifilters/localdomain/localdomainurifilter.h
  src/urifilters/shorturi/kshorturifilter.cpp
  src/urifilters/shorturi/kshorturifilter.h
  src/widgets/jobuidelegate.cpp
  src/widgets/kurlcompletion.cpp
  src/widgets/previewjob.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-26 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> asemke wrote in kcolorschememanager.cpp:107
> Yes, was also wrong in LabPlot. Just corrected 
> https://invent.kde.org/kde/labplot/commit/262f37b59193ed88bf680b155dc6ecd37bd11419.
> 
> We should have maybe in this class only one public function KActionMenu 
> *createSchemeSelectionMenu(QObject *parent) which internally sets the string 
> to "Color Scheme" and the icon to "preferences-desktop-color". With this we'd 
> enforce a consistent look. Or this is menu is automatically created for 
> KXmlGuiWindow applications...

> Or this is menu is automatically created for KXmlGuiWindow applications...

That's what I was thinking of, yeah.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26236: Port QRegExp to QRegularExpression (and some QStringRef) optimisation

2019-12-26 Thread Ahmad Samir 
ahmadsamir added inline comments.

INLINE COMMENTS

> kurlcompletion.cpp:503
>  // no protocol.  (QUrl does this only for absolute paths)
> -if (protocol_regex.indexIn(url_copy) == 0) {
> +if (protocol_regex.match(url_copy).hasMatch()) {
>  m_kurl = QUrl(url_copy);

hasMatch() is enough here because the pattern will only match at the beginning 
of the subject string because of ^ anchor.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26236

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26236: Port QRegExp to QRegularExpression (and some QStringRef) optimisation

2019-12-26 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  First pass.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26236

AFFECTED FILES
  autotests/kurifiltertest.cpp
  src/core/kprotocolmanager.cpp
  src/core/krecentdocument.cpp
  src/ioslaves/help/kio_help.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/kpac/script.cpp
  src/urifilters/localdomain/localdomainurifilter.cpp
  src/urifilters/localdomain/localdomainurifilter.h
  src/urifilters/shorturi/kshorturifilter.cpp
  src/urifilters/shorturi/kshorturifilter.h
  src/widgets/jobuidelegate.cpp
  src/widgets/kurlcompletion.cpp
  src/widgets/previewjob.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 72207.
ahmadsamir added a comment.


  Make it const... :/

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26226?vs=72206=72207

BRANCH
  l-splitref (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26226

AFFECTED FILES
  src/lib/util/klistopenfilesjob_unix.cpp

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26133: Enable Auto Save

2019-12-26 Thread Kevin Ottens 
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> apol wrote in test_signal.h.ref:137
> How about having `isSaveNeededChanged(bool)`? It could be in 
> KCoreConfigSkeleton.

Damn, and I was wondering which better name we could use... it was already 
there all along since KCoreConfigSkeleton has isSaveNeeded indeed... Thanks 
Aleix! :-)

Note this means the logic will need to be adjusted though since it'll also need 
being emitted only when the value changes. AFAICT currently it does emit always 
on property change while only the first change would be necessary... also it 
won't emit again on load() calls when it's most likely we're rolling back.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26133

To: tcanabrava, ervin
Cc: ervin, GB_2, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread David Faure 
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> klistopenfilesjob_unix.cpp:69
>  const QString out(QString::fromLocal8Bit(lsofProcess.readAll()));
> -QStringList pidList = 
> out.split(QRegularExpression(QStringLiteral("\\s+")), 
> QString::SkipEmptyParts);
> -pidList.removeDuplicates();
> +QVector pidList = 
> out.splitRef(QRegularExpression(QStringLiteral("\\s+")), 
> QString::SkipEmptyParts);
>  for (const auto& pidStr : qAsConst(pidList)) {

Now you can make it `const` and remove the `qAsConst` on the next line.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26226

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26177: Port QRegExp to QRegularExpression

2019-12-26 Thread Kevin Ottens 
ervin accepted this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26177

To: ahmadsamir, #frameworks, dfaure, ervin, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread Ahmad Samir 
ahmadsamir added a comment.


  One more thing, since this is `lsof -t` it's only 52 entries on my system 
(not +10 of `lsof`), so it's not as big of an optimisation as I first 
thought (see D26226  for context).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26226

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 72206.
ahmadsamir added a comment.


  Remove the call to std::unique:
  
  - It doesn't work like that
  - it's not needed as `lsof -t` already produces a sorted and unique list of 
pid's

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26226?vs=72188=72206

BRANCH
  l-splitref (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26226

AFFECTED FILES
  src/lib/util/klistopenfilesjob_unix.cpp

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread Ahmad Samir 
ahmadsamir planned changes to this revision.
ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in klistopenfilesjob_unix.cpp:71
> This does not work the way you think it does.
> 
> "A call to std::unique is typically followed by a call to a container's erase 
> method, which erases the unspecified values and reduces the physical size of 
> the container to match its new logical size."
> 
> Also, note that unlike removeDuplicates(), std::unique requires the container 
> to be sorted (or at least the duplicates to be consecutive). But AFAICS the 
> output of lsof is already sorted? In fact in all my tests I don't manage to 
> see it output duplicates... Are you sure this can happen?

Ouch, right; I should have read up fully on unique before using it (I skimmed 
the docs, always a stupid idea with a new tool).

removeDuplicates() was in the original code; and `lsof` would have duplicate 
pids, but I missed that the code actually uses `lsof -t` which is both sorted 
and unique.

I'll investigate some more and update the diff.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26226

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26071: Avoid unwanted horizontal scrolling

2019-12-26 Thread Kåre Särs 
sars added reviewers: Kate, dhaumann, cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D26071

To: sars, #kate, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D26184: QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But QMultiHash::unite was added in qt5.13

2019-12-26 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R276:6634451a6279: QHash::unite is deprecated in qt5.15. We 
need to port to QMultiHash.But… (authored by mlaurent).

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26184?vs=72068=72194

REVISION DETAIL
  https://phabricator.kde.org/D26184

AFFECTED FILES
  src/kextendableitemdelegate.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-26 Thread Alexander Semke 
asemke added inline comments.

INLINE COMMENTS

> ngraham wrote in kcolorschememanager.cpp:107
> "Default" is probably fine.
> 
> FWIW the parent menu item is actually mis-named, at least in Kate. It's 
> called "Color Theme" when it should be "Color Scheme"
> 
> Also this menu should be universal, and not re-implemented on a per-app basis.

Yes, was also wrong in LabPlot. Just corrected 
https://invent.kde.org/kde/labplot/commit/262f37b59193ed88bf680b155dc6ecd37bd11419.

We should have maybe in this class only one public function KActionMenu 
*createSchemeSelectionMenu(QObject *parent) which internally sets the string to 
"Color Scheme" and the icon to "preferences-desktop-color". With this we'd 
enforce a consistent look. Or this is menu is automatically created for 
KXmlGuiWindow applications...

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26197: Display fully qualified class/namespace name as page header

2019-12-26 Thread Olivier Churlaud 
ochurlaud added a comment.


  One minor correction then you can ship it

INLINE COMMENTS

> generator.py:456
> +else:
> +mapping['classname'] = mapping['fullname'] = None
>  

Prefer the use of 2 settings to None instead of this double one. It's more 
explicit for people not coming from python (majority here).

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26197

To: davidre, ochurlaud
Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna

D26044: Set breeze as default theme when reading from configuration file

2019-12-26 Thread Benjamin Port 
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:ed86f4f37c6b: Set breeze as default theme when reading 
from configuration file (authored by bport).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26044?vs=71955=72193

REVISION DETAIL
  https://phabricator.kde.org/D26044

AFFECTED FILES
  src/kiconloader.cpp
  src/kicontheme.cpp

To: bport, #plasma, ervin, crossi, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26227: Port to QRandomGenerator

2019-12-26 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D26227

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26227: Port to QRandomGenerator

2019-12-26 Thread Laurent Montel 
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QRandomGenerator

TEST PLAN
  autotest ok

REPOSITORY
  R283 KAuth

BRANCH
  port_to_QRandomGenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26227

AFFECTED FILES
  autotests/HelperTest.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26184: QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But QMultiHash::unite was added in qt5.13

2019-12-26 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R276 KItemViews

BRANCH
  port_qhash_deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26184

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread David Faure 
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> klistopenfilesjob_unix.cpp:71
> +// remove duplicates
> +std::unique(pidList.begin(), pidList.end());
>  for (const auto& pidStr : qAsConst(pidList)) {

This does not work the way you think it does.

"A call to std::unique is typically followed by a call to a container's erase 
method, which erases the unspecified values and reduces the physical size of 
the container to match its new logical size."

Also, note that unlike removeDuplicates(), std::unique requires the container 
to be sorted (or at least the duplicates to be consecutive). But AFAICS the 
output of lsof is already sorted? In fact in all my tests I don't manage to see 
it output duplicates... Are you sure this can happen?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26226

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26184: QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But QMultiHash::unite was added in qt5.13

2019-12-26 Thread Laurent Montel 
mlaurent added a comment.


  ping ?:)

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D26184

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-26 Thread Ahmad Samir 
ahmadsamir requested review of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26226

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns