D27562: [kcmcontrols] Respect header/footer visibility

[Nicolas Fella]

nicolasfella retitled this revision from "[scrollviewkcm] Respect header/footer 
visibility" to "[kcmcontrols] Respect header/footer visibility".

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27562

To: nicolasfella, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27562: [kcmcontrols] Respect header/footer visibility

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27562

To: nicolasfella, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27562: [scrollviewkcm] Respect header/footer visibility

[Nicolas Fella]

nicolasfella updated this revision to Diff 76136.
nicolasfella added a comment.


  - Do same for GridViewKCM

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27562?vs=76135&id=76136

BRANCH
  rhv

REVISION DETAIL
  https://phabricator.kde.org/D27562

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml

To: nicolasfella, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27562: [scrollviewkcm] Respect header/footer visibility

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Same as 1270e357a96f1e78281c0335b1bd05e5c9c3e3c6 
 but 
for scrollviewkcm

REPOSITORY
  R296 KDeclarative

BRANCH
  rhv

REVISION DETAIL
  https://phabricator.kde.org/D27562

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml

To: nicolasfella, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Dominik Haumann]

dhaumann added a comment.


  Definitely a +1 for using a QIcon here.
  
  Still, I wonder whether we should postpone adding the MarkInterfaceV2 until 
the KF6 branch. Then we have it properly fixed in KF6.
  
  Or do you think we also need this in KF5 days to properly support e.g. hidpi ?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

Re: Banning QNetworkAccessManager

[Ben Cooksley]

On Thu, Feb 20, 2020 at 9:57 PM Volker Krause  wrote:
>
> On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote:
> > On Wed, Feb 19, 2020 at 9:30 PM Volker Krause  wrote:
> > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote:
> > > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause  wrote:
> > > > > I agree on the problem of QNAM's default, see also
> > > > > https://conf.kde.org/en/
> > > > > akademy2019/public/events/135 on that subject.
> > > > >
> > > > > On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote:
> > > > > [...]
> > > > >
> > > > > > Prior to now, i've taken the approach of advertising that
> > > > > > QNetworkAccessManager is broken and needs a flag set within
> > > > > > applications when used, however unfortunately this seems to have
> > > > > > been
> > > > > > an ineffective approach and cases of broken behaviour continue to
> > > > > > appear (despite this brokeness being known about and advertised
> > > > > > since
> > > > > > back in the Qt 4.x series when this class was introduced)
> > > > > >
> > > > > > Therefore, given the Qt Project is unlikely to change their position
> > > > >
> > > > > > on this, I would like to propose the following:
> > > > > The Qt Project is actually in favor of changing at least the
> > > > > redirection
> > > > > default to exactly what we want it to be.
> > > > > https://codereview.qt-project.org/c/qt/qtbase/+/273175 has the change,
> > > > > and
> > > > > got approval both by Lars and one of the maintainers. It is merely
> > > > > stuck
> > > > > in dealing with the unit test fallout in Qt's CI that somebody has to
> > > > > take care of. Doesn't immediately help us of course, but claiming Qt
> > > > > is
> > > > > unwilling to change this is simply wrong.
> > > > >
> > > > > > 1) That effective immediately, QNetworkAccessManager and it's
> > > > > > children
> > > > > > classes be banned and prohibited within KDE software, to be enforced
> > > > > > by server side hooks.
> > > > > > 2) That we fork QNetworkAccessManager and the associated classes
> > > > > > within the appropriate Framework (to be determined), where the
> > > > > > defective behaviour can then be corrected.
> > > > >
> > > > > While this might solve the redirection problem, it brings us yet
> > > > > another
> > > > > then unmaintained HTTP implementation next to the one in KIO, which is
> > > > > a
> > > > > far bigger problem long term. We need less of those, not more.
> > > > >
> > > > > To address the problem of people not using the correct defaults, I did
> > > > > propose a much less extreme approach in the above mentioned talk at
> > > > > Akademy, namely having a KNetworkAccessManager as a sub-class of QNAM
> > > > > in
> > > > > a low-tier frameworks that essentially just enables redirects and
> > > > > HSTS.
> > > > > QNAM's implementation isn't the problem after all, the defaults are.
> > > > >
> > > > > Commit hooks warning about QNAM usage might still be a good idea, but
> > > > > as a
> > > > > warning only. Hard blocking QNAM-using code would block at least three
> > > > > repos I spend a lot of time on currently, none of which even talks to
> > > > > KDE
> > > > > servers.
> > > > >
> > > > > If you need to take more drastic measures against code not doing this
> > > > > correctly regardless, you can do that my dropping the server-side
> > > > > workarounds. Yes, that would break the affected application possibly,
> > > > > but
> > > > > at least it would not cause massive collateral damage for the people
> > > > > using this correctly.
> > > > >
> > > > > It would also help to know where specifically we have that problem, so
> > > > > we
> > > > > can actually solve it, and so we can figure out why we failed to fix
> > > > > this
> > > > > there earlier.
> > > >
> > > > Just bringing this up again - it seems we've not had much movement on
> > > > this aside from the Wiki page.
> > > >
> > > > Examining that Qt merge request, it not only is targeted at just Qt
> > > > 6.x, it also hasn't had any movement since the start of October 2019 -
> > > > 4 months ago.
> > > > Given that we are going to be on Qt 5.x for some time, that merge
> > > > request can't be considered to be the 'fix' for this issue.
> > >
> > > The targeting of Qt6 is due to this aiming at dev when that was still Qt
> > > 5.x, but you are right of course, somebody needs to do the work there to
> > > drive this to completion, no matter in which version it will actually
> > > land.
> >
> > Indeed.
> >
> > > > We need a solution that will ensure software released today doesn't
> > > > cause us pain in several years time, because as I illustrated in an
> > > > earlier email to this thread, software has a habit of remaining in use
> > > > for an extremely long amount of time (August 2014 being the release
> > > > date of the Marble versions in question hitting that old URL).
> > > >
> > > > The easiest path forward is to simply ban QNetworkAccessManager.
> > >
> > > That might b

D27557: Auto-generate 24px monochrome icons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> generate-24px-versions.sh:45
> +fi
> +done

comment to make this file visible for reviewers

> CMakeLists.txt:26
> +endif()
> +
>  gtk_update_icon_cache(${BREEZE_INSTALL_DIR})

comment to make the file visible for reviewers

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

D27557: Auto-generate 24px monochrome icons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, ndavis, Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now we have 24px monochrome icons for compatibility with GTK apps, 
which use icons
  of this size. However they are visually identical to the 22px versions, with 
one pixel of
  padding on all sides. Manually creating them is tedious busywork.
  
  This patch automatically generates 24px monochrome icons from the 22px 
versions for
  action, device, places, and status icons by editing the SVG files to increase 
the size
  of the viewbox and apply a (1,1) translation to the content.
  
  That way I implemented this seems to work pretty reliably on the icon 
generation side.
  However I am less sure about how it is integrated into the CMake files. It 
works, but if
  I did it wrong, let me know.

TEST PLAN
  Delete `~/kde/usr/share/icons/{breeze,breeze-dark}` (or wherever your icons 
live)
  Apply patch and build
  Look in 
`~/kde/usr/share/icons/{breeze,breeze-dark}/{devices,actions,places,status}/24`
  Open Cuttlefish
  
  See that everything is awesome

REPOSITORY
  R266 Breeze Icons

BRANCH
  autogenerate-24px-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27557

AFFECTED FILES
  generate-24px-versions.sh
  icons-dark/CMakeLists.txt
  icons-dark/actions/24/acrobat.svg
  icons-dark/actions/24/activities.svg
  icons-dark/actions/24/address-book-new.svg
  icons-dark/actions/24/align-horizontal-baseline.svg
  icons-dark/actions/24/align-horizontal-bottom-out.svg
  icons-dark/actions/24/align-horizontal-center.svg
  icons-dark/actions/24/align-horizontal-left-out.svg
  icons-dark/actions/24/align-horizontal-left-to-anchor.svg
  icons-dark/actions/24/align-horizontal-left.svg
  icons-dark/actions/24/align-horizontal-node.svg
  icons-dark/actions/24/align-horizontal-right-out.svg
  icons-dark/actions/24/align-horizontal-right-to-anchor.svg
  icons-dark/actions/24/align-horizontal-right.svg
  icons-dark/actions/24/align-horizontal-top-out.svg
  icons-dark/actions/24/align-vertical-baseline.svg
  icons-dark/actions/24/align-vertical-bottom-out.svg
  icons-dark/actions/24/align-vertical-bottom-to-anchor.svg
  icons-dark/actions/24/align-vertical-bottom.svg
  icons-dark/actions/24/align-vertical-center.svg
  icons-dark/actions/24/align-vertical-node.svg
  icons-dark/actions/24/align-vertical-top-out.svg
  icons-dark/actions/24/align-vertical-top-to-anchor.svg
  icons-dark/actions/24/align-vertical-top.svg
  icons-dark/actions/24/amarok_cart_view.svg
  icons-dark/actions/24/application-exit.svg
  icons-dark/actions/24/application-menu.svg
  icons-dark/actions/24/appointment-new.svg
  icons-dark/actions/24/archive-extract.svg
  icons-dark/actions/24/archive-insert-directory.svg
  icons-dark/actions/24/archive-insert.svg
  icons-dark/actions/24/archive-remove.svg
  icons-dark/actions/24/arrow-down-double.svg
  icons-dark/actions/24/arrow-down.svg
  icons-dark/actions/24/arrow-left-double.svg
  icons-dark/actions/24/arrow-left.svg
  icons-dark/actions/24/arrow-right-double.svg
  icons-dark/actions/24/arrow-right.svg
  icons-dark/actions/24/arrow-up-double.svg
  icons-dark/actions/24/arrow-up.svg
  icons-dark/actions/24/audio-volume-high.svg
  icons-dark/actions/24/audio-volume-low.svg
  icons-dark/actions/24/audio-volume-medium.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons-dark/actions/24/auto-scale-all.svg
  icons-dark/actions/24/auto-scale-x.svg
  icons-dark/actions/24/auto-scale-y.svg
  icons-dark/actions/24/autocorrection.svg
  icons-dark/actions/24/bookmark-new-list.svg
  icons-dark/actions/24/bookmark-new.svg
  icons-dark/actions/24/bookmark-toolbar.svg
  icons-dark/actions/24/bookmarks-organize.svg
  icons-dark/actions/24/bookmarks.svg
  icons-dark/actions/24/bordertool.svg
  icons-dark/actions/24/call-start.svg
  icons-dark/actions/24/call-stop.svg
  icons-dark/actions/24/character-set.svg
  icons-dark/actions/24/checkbox.svg
  icons-dark/actions/24/chronometer-lap.svg
  icons-dark/actions/24/chronometer-pause.svg
  icons-dark/actions/24/chronometer-reset.svg
  icons-dark/actions/24/chronometer-start.svg
  icons-dark/actions/24/chronometer.svg
  icons-dark/actions/24/class-or-package.svg
  icons-dark/actions/24/code-block.svg
  icons-dark/actions/24/code-class.svg
  icons-dark/actions/24/code-context.svg
  icons-dark/actions/24/code-function.svg
  icons-dark/actions/24/code-typedef.svg
  icons-dark/actions/24/code-variable.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/color-fill.svg
  icons-dark/actions/24/color-gradient.svg
  icons-dark/actions/24/color-management.svg
  icons-dark/actions/24/color-picker-black.svg
  icons-dark/actions/24/color-picker-grey.svg
  icons-dark/actions/24/color-picker-white.svg
  icons-dark/actions/24/color-picker.svg
  icons-dark/actions/24/colormanagement.svg
  icons-dark/acti

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham added a revision: Unknown Object (Differential Revision).

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

D27528: Adapt action numbering in Android to work like in KNotifications

[Nicolas Fella]

nicolasfella added a comment.


  To apply the changes made in the web interface to your local commit you use 
`arc amend` I think.
  
  To upload new changes you do `arc diff --update D27528`
  
  > Once the diff is landed, it will be commited with the email address you set 
up in your KDE Identity account afaik.
  
  It does not. It uses whatever authorship info is in the uploaded patch, which 
may be empty if the patch was uploaded via the web interface. Always check that 
if you are landing other people's patches!

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[Jonah Brüchert]

jbbgameich added a comment.


  Once the diff is landed, it will be commited with the email address you set 
up in your KDE Identity account afaik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau marked an inline comment as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 76127.
kossebau added a comment.


  Switch to QIcon::paint, leaving all vodoo with devicePixelRatioF to QIcon
  logic
  Also results in better handling of pixmaps when they would be oversampled.
  
  Tested with QT_SCALE_FACTOR

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27533?vs=76075&id=76127

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/include/ktexteditor/markinterface.h
  src/search/katesearchbar.cpp
  src/view/kateviewhelpers.cpp

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27552: Have kai the knotifications maintainer

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:224cc7382e63: Have kai the knotifications maintainer 
(authored by apol).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27552?vs=76121&id=76125

REVISION DETAIL
  https://phabricator.kde.org/D27552

AFFECTED FILES
  metainfo.yaml

To: apol, #frameworks, broulik, nicolasfella
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27552: Have kai the knotifications maintainer

[Nicolas Fella]

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27552

To: apol, #frameworks, broulik, nicolasfella
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27478: Add a --replace option to kded5

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R297:bb604f05b0bd: Add a --replace option to kded5 (authored 
by apol).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27478?vs=75918&id=76123

REVISION DETAIL
  https://phabricator.kde.org/D27478

AFFECTED FILES
  src/kded.cpp

To: apol, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27552: Have kai the knotifications maintainer

[Nathaniel Graham]

ngraham added a comment.


  +1 :)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27552

To: apol, #frameworks, broulik
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[David Edmundson]

davidedmundson added a comment.


  This is a nice simple example of something with a version bump: 
https://phabricator.kde.org/D27535 for where to change registry.
  
  I was wrong about display, there is a number you need to change, but 
apparently it's on v9 already, so you don't need to do anything.

INLINE COMMENTS

> plasmawindowmanagement_interface.cpp:129
>  
>  const quint32 PlasmaWindowManagementInterface::Private::s_version = 9;
>  

how is this 9 already?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Carson Black]

cblack added a comment.


  In D27464#614479 , @davidedmundson 
wrote:
  
  > Good start. The direction makes sense.
  >
  > display.cpp and registry.cpp need updating to the new version number. 
Otherwise we won't be able to use this new method.
  >
  > It'd be great if you could update the unit test too.
  
  
  Pardon, but I don't see anything in display/registry.cpp that looks like it 
takes a version number for the org_kde_plasma_window interface. I only see 
okp_windowmanagement in registry.cpp. Am I missing something?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Re: Taking over KNotifications maintainership

[Aleix Pol]

https://phabricator.kde.org/D27552

On Mon, Feb 17, 2020 at 12:35 PM Aleix Pol  wrote:
>
>
>
> El dl., 17 de febr. 2020, 12:19, Kai Uwe Broulik  va 
> escriure:
>>
>> Hi all,
>>
>> I propose to make me the official maintainer of KNotifications given
>> that's pretty much what I've been doing for quite some time already anyway.
>>
>> It still lists Martin Klapetek as maintainer who unfortunately isn't
>> very active anymore.
>>
>> Cheers
>> Kai Uwe
>
>
> +1
>
> Makes sense, you have been acting as such in practice already.
>
> Aleix

D27552: Have kai the knotifications maintainer

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  As discussed in the mailing list

TEST PLAN
  :D

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27552

AFFECTED FILES
  metainfo.yaml

To: apol, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27550: Support Qt 5.14 on Android

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kcatalog.cpp:121
>  
> +#ifdef Q_OS_ANDROID
> +static QString androidUnpackCatalog(const QString &relpath)

`#if defined(Q_OS_ANDROID) && QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)`

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27550

To: vkrause, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[David Faure]

dfaure added a comment.


  kfileitemtest still passes?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27550: Support Qt 5.14 on Android

[Volker Krause]

vkrause added a task: T12520: Qt 5.14.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27550

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27550: Support Qt 5.14 on Android

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  With Qt 5.14 asset files are no longer extracted into the filesystem, they
  are only available via assert: or qrc: URLs. Those however aren't supported
  by libintl, so copy catalogs to the cache folder on demand.
  
  Not ideal (libintl using the assert manager NDK API directly would probably
  be more efficient), but it's still better than 5.13, as unused catalogs
  aren't copied.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27550

AFFECTED FILES
  src/kcatalog.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27350: Port away from Title and towards level 1 Heading

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6b8f1142840f: Port away from Title and towards level 1 
Heading (authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27350?vs=75556&id=76113

REVISION DETAIL
  https://phabricator.kde.org/D27350

AFFECTED FILES
  examples/applets/bugreport/contents/ui/main.qml
  examples/applets/testcomponents/contents/ui/DialogContent.qml
  examples/applets/testcomponents/contents/ui/DialogsPage.qml
  examples/applets/testcomponents/contents/ui/DragPage.qml
  examples/applets/testcomponents/contents/ui/IconsPage.qml
  examples/applets/testcomponents/contents/ui/MousePage.qml
  examples/applets/testcomponents/contents/ui/ThemePage.qml
  examples/applets/testtheme/contents/ui/FontTest.qml
  examples/applets/testtheme/contents/ui/ScalePage.qml
  examples/applets/testtheme/contents/ui/UnitsPage.qml
  examples/applets/widgetgallery/contents/ui/Typography.qml
  examples/developerguide/basic/contents/ui/main.qml
  src/declarativeimports/plasmaextracomponents/qml/Heading.qml
  src/declarativeimports/plasmaextracomponents/qml/Paragraph.qml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper/package/contents/ui/main.qml

To: ngraham, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27350: Port away from Title and towards level 1 Heading

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port-away-from-title (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27350

To: ngraham, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25682: add initial wsdiscovery support

[Harald Sitter]

sitter added a comment.


  Yay. 1.9 is out.
  I've poked our CI maintainers about including kdsoap 1.9 and have high hopes 
at least suse is done by Monday. I am kinda leaning towards landing the diff on 
Monday regardless as I'd rather have this get more exposure sooner rather than 
later.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D25682

REVISION DETAIL
  https://phabricator.kde.org/D25682

To: sitter, dfaure, #frameworks, #dolphin, ngraham
Cc: winterz, meven, schmeisser, bcooksley, ngraham, caspermeijn, 
davidedmundson, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin added a comment.


  In D27540#615132 , @davidre wrote:
  
  > They stick around because as you said the settings differ from the defaults.
  
  
  Right, so "not a bug" (as in that's what's the patch is intended to do so 
far).
  
  > The pen for me conveys the meaning that something was edited that's the 
reason I would only show it for unsaved changes. But let's others weigh in what 
they think
  
  Right, I picked visual indicators which came to mind, I'm totally open to 
suggestions on which would be better suited.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin added a comment.


  In D27540#615156 , @ngraham wrote:
  
  > Please add screenshots to the Test Plan section for patches that change the 
UI. :) Also it would be nice to indicate how someone can test this. Which apps? 
System Settings? Where? How?
  
  
  Well, second part I pointed out a few kcms you can test with. ;-)

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27540: Status indicator for individual widgets in KCModule

[Nathaniel Graham]

ngraham added a comment.


  Please add screenshots to the Test Plan section for patches that change the 
UI. :) Also it would be nice to indicate how someone can test this. Which apps? 
System Settings? Where? How?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven updated this revision to Diff 76106.
meven added a comment.


  use QStringLitteral

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27539?vs=76088&id=76106

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27539

AFFECTED FILES
  src/core/global.cpp

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27527: Add new `smiley-add` icons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:4daac191fb33: Add new `smiley-add` icons (authored by 
ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27527?vs=76063&id=76105

REVISION DETAIL
  https://phabricator.kde.org/D27527

AFFECTED FILES
  icons-dark/actions/16/smiley-add.svg
  icons-dark/actions/22/smiley-add.svg
  icons/actions/16/smiley-add.svg
  icons/actions/22/smiley-add.svg

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27535: Add XdgOutputV1 version 2

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in xdgoutput_interface.cpp:319
> noob question: what would happen if you didn't have this check?

If a client that only knew version1 connected and we sent this event, the 
client would raise a protocol error and quit.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27535

To: davidedmundson, #kwin, zzag
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27527: Add new `smiley-add` icons

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  smiley-add-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27527

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  I've changed 417069 to CCBUG only, there's more to that issue than just the 
bogus fallback in this function.
  
  Diff LGTM, besides one minor comment about not keeping that QLatin1String.

INLINE COMMENTS

> global.cpp:227
>  if (url.scheme().isEmpty()) { // empty URL or relative URL (e.g. '~')
> -return unknown;
> +return QLatin1String ("unknown");
>  }

I think we can QStringLiteral this. QLatin1String has no performance advantage 
when it gets type converted to QString anyway.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Harald Sitter]

sitter edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

[David Redondo]

davidre added a comment.


  In D27540#615129 , @ervin wrote:
  
  > In D27540#615105 , @davidre 
wrote:
  >
  > > In D27540#615092 , @ervin 
wrote:
  > >
  > > > In D27540#615061 , @davidre 
wrote:
  > > >
  > > > > How does it look? Will this be opt in for other users of 
KConfigDialogManager?
  > > >
  > > >
  > > > I'd say you should try it. ;-)
  > > >  I really need wider feedback on how it behaves in different context. 
Currently the patch makes it mandatory for everyone.
  > >
  > >
  > > I use KConfigDialogManager to manage the settings in Spectacle MainWindow 
which are instant apply by 
  > >  `connect(mConfigManager, &KConfigDialogManager::widgetModified, 
mConfigManager, &KConfigDialogManager::updateSettings);` and I don't like it 
that they appear there too
  >
  >
  > You mean they appear and stick around? Or they appear/disappear immediately?
  >  If they stick around I'd indeed have to check why the state isn't 
recomputed on the updateSettings call...
  >
  > > F8117881: grafik.png 
  > > 
  > >> a setting which is currently dirty or which differs from default value.
  > > 
  > > What is your idea behind this? After first seeing this patch my intuition 
was that it would show for unsaved changes. But then I was confused when I open 
a SettingsDialog that there were already marks even though I changed nothing! I 
would expect them only for unsaved changes, I don't know how other platforms 
handle this if they have something similiar?
  >
  > Currently it helps the user find out the unsaved changes (the least useful 
in some way, or your immediate memory is not good) but it also helps the user 
find out which of her settings differ from the default values (and that's 
indeed something you will forget over time and wonder "why the hell is the 
defaults button enabled").
  >
  > Hope the extra context helps.
  
  
  They stick around because as you said the settings differ from the defaults.
  
  The pen for me conveys the meaning that something was edited that's the 
reason I would only show it for unsaved changes. But let's others weigh in what 
they think

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin added a comment.


  In D27540#615105 , @davidre wrote:
  
  > In D27540#615092 , @ervin wrote:
  >
  > > In D27540#615061 , @davidre 
wrote:
  > >
  > > > How does it look? Will this be opt in for other users of 
KConfigDialogManager?
  > >
  > >
  > > I'd say you should try it. ;-)
  > >  I really need wider feedback on how it behaves in different context. 
Currently the patch makes it mandatory for everyone.
  >
  >
  > I use KConfigDialogManager to manage the settings in Spectacle MainWindow 
which are instant apply by 
  >  `connect(mConfigManager, &KConfigDialogManager::widgetModified, 
mConfigManager, &KConfigDialogManager::updateSettings);` and I don't like it 
that they appear there too
  
  
  You mean they appear and stick around? Or they appear/disappear immediately?
  If they stick around I'd indeed have to check why the state isn't recomputed 
on the updateSettings call...
  
  > F8117881: grafik.png 
  > 
  >> a setting which is currently dirty or which differs from default value.
  > 
  > What is your idea behind this? After first seeing this patch my intuition 
was that it would show for unsaved changes. But then I was confused when I open 
a SettingsDialog that there were already marks even though I changed nothing! I 
would expect them only for unsaved changes, I don't know how other platforms 
handle this if they have something similiar?
  
  Currently it helps the user find out the unsaved changes (the least useful in 
some way, or your immediate memory is not good) but it also helps the user find 
out which of her settings differ from the default values (and that's indeed 
something you will forget over time and wonder "why the hell is the defaults 
button enabled").
  
  Hope the extra context helps.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

[David Redondo]

davidre added a reviewer: VDG.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27540: Status indicator for individual widgets in KCModule

[David Redondo]

davidre added a comment.


  In D27540#615092 , @ervin wrote:
  
  > In D27540#615061 , @davidre 
wrote:
  >
  > > How does it look? Will this be opt in for other users of 
KConfigDialogManager?
  >
  >
  > I'd say you should try it. ;-)
  >  I really need wider feedback on how it behaves in different context. 
Currently the patch makes it mandatory for everyone.
  
  
  I use KConfigDialogManager to manage the settings in Spectacle MainWindow 
which are instant apply by 
  `connect(mConfigManager, &KConfigDialogManager::widgetModified, 
mConfigManager, &KConfigDialogManager::updateSettings);` and I don't like it 
that they appear there too
  F8117881: grafik.png 
  
  > a setting which is currently dirty or which differs from default value.
  
  What is your idea behind this? After first seeing this patch my intuition was 
that it would show for unsaved changes. But then I was confused when I open a 
SettingsDialog that there were already marks even though I changed nothing! I 
would expect them only for unsaved changes, I don't know how other platforms 
handle this if they have something similiar?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27540: Status indicator for individual widgets in KCModule

[David Redondo]

davidre added a comment.


  The editmarks should probably respect the visibility of the associated 
widget. In this picture I use a invisble lineedit to manage the settings of the 
QButtonGroup beneath (QButtonGroup isn't supported by KCOnfigDialogManager)
  F8117874: grafik.png 

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin added a comment.


  In D27540#615091 , @davidre wrote:
  
  > The editmarks should probably respect the visibility of the associated 
widget. In this picture I use a invisble lineedit to manage the settings of the 
QButtonGroup beneath (QButtonGroup isn't supported by KCOnfigDialogManager)
  >  F8117874: grafik.png 
  
  
  Very good point!

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin added a comment.


  In D27540#615061 , @davidre wrote:
  
  > How does it look? Will this be opt in for other users of 
KConfigDialogManager?
  
  
  I'd say you should try it. ;-)
  I really need wider feedback on how it behaves in different context. 
Currently the patch makes it mandatory for everyone.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> meven wrote in kconfigdialogmanager_p.h:60
> I would have named those with s : indicatorWidgets, knownWidgets, buddyWidgets

Not gonna rename those though, I'm merely moving code around (apart from 
indicatorWidget I could at least rename that one indeed).

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 61 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/61/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 21 Feb 2020 11:55:10 +
 Build duration:
6 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.68.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27290/32233)53%
(11010/20685)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12525/12598)50%
(6596/13087)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6332/7469)65%
(1836/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7979/9510)64%
(2401/3771)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/55/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 21 Feb 2020 11:55:10 +
 Build duration:
5 min 38 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D27538: Registry: don't destroy the callback on globalsync

[Daniel Vrátil]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:4ceb35672dfa: Registry: don't destroy the callback 
on globalsync (authored by dvratil).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27538?vs=76084&id=76097

REVISION DETAIL
  https://phabricator.kde.org/D27538

AFFECTED FILES
  src/client/registry.cpp

To: dvratil, #kwin, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27544: Fix update scenarios with no explicit downloadlink selected

[Dan Leinir Turthra Jensen]

leinir added reviewers: KNewStuff, Frameworks, Plasma.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27544

To: leinir, #knewstuff, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27544: Fix update scenarios with no explicit downloadlink selected

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  The old downloadwidget's update system would explicitly require a user
  to pick which download item to use for updating if there was more than
  one available. This work is an attempt at implementing this at the
  engine level, while also allowing for there to be no requirement to
  make an active choice, unless there is no way to deduce which of
  the various potential download items is the one we are trying to
  update.
  
  The current heuristics are:
  
  - If there is one downloaditem, that's what we're updating
  - If there are more, first try and see if one has the precise url as the 
previously installed payload
  - If that fails, check for filename matches (without the rest of the url)
  - Only if that fails, present the user with a choice
  
  Add an explicit update function in the QtQuick items model
  
  Fix erroneous uses of installItem, and use updateItem for updates
  in the QtQuick components
  
  BUG:417510

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27544

AFFECTED FILES
  src/core/engine.cpp
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

[David Redondo]

davidre added a comment.


  How does it look? Will this be opt in for other users of KConfigDialogManager?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Harald Sitter]

sitter added a comment.


  LGTM.
  I do wonder if the new deprecation annotations should be used for the the 
deprecation though: https://api.kde.org/ecm/module/ECMGenerateExportHeader.html

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, bruns

D27540: Status indicator for individual widgets in KCModule

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kconfigdialogmanager_p.h:60
> +QHash buddyWidget;
> +QHash indicatorWidget;
> +QSet allExclusiveGroupBoxes;

I would have named those with s : indicatorWidgets, knownWidgets, buddyWidgets

> settingsstatusindicator_p.h:41
> +bool isDefaulted() const;
> +void setDefaulted(bool defaulted);
> +

Make setChanged and setDefaulted as slots to ease the reuse of this class 
outside of KConfigDialogManager

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: ngraham, davidedmundson, meven, crossi, bport.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REVISION SUMMARY
  Extend KConfigDialogManager internals to insert a small
  SettingsStatusIndicator widget next to widgets representing a setting
  which is currently dirty or which differs from default value.

TEST PLAN
  Tested it with several widgets based KCMs, namely: qtquicksettings,
  desktoppath and screenlocker. Those three have different situations
  in term of layouts. Worst case scenario is desktoppath which leads
  to the right hand side of the fields moving a bit to fit the indicators
  but that's the price to pay for the feature I guess while keeping
  things readable.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

AFFECTED FILES
  src/CMakeLists.txt
  src/kconfigdialogmanager.cpp
  src/kconfigdialogmanager.h
  src/kconfigdialogmanager_p.h
  src/settingsstatusindicator.cpp
  src/settingsstatusindicator_p.h

To: ervin, ngraham, davidedmundson, meven, crossi, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27538: Registry: don't destroy the callback on globalsync

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Thanks.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27538

To: dvratil, #kwin, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven added reviewers: dfaure, broulik.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven updated this revision to Diff 76088.
meven added a comment.


  Clean code further

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27539?vs=76087&id=76088

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27539

AFFECTED FILES
  src/core/global.cpp

To: meven, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto added a comment.


  I added a summary here.
  
  I also wanted to fix it directly in the commit. Besides, I didn't set the 
committer e-mail address correctly, so I'd like to fix that as well.
  How can I edit the commit with `arc`? Or can I just `git commit --amend` and 
push?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven edited the summary of this revision.
meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven updated this revision to Diff 76087.
meven added a comment.


  Simplify

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27539?vs=76086&id=76087

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27539

AFFECTED FILES
  src/core/global.cpp

To: meven, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven created this revision.
meven added reviewers: ngraham, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 417922
  BUG: 417921
  BUG: 417069 
  FIXED-IN: 5.68

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27539

AFFECTED FILES
  src/core/global.cpp

To: meven, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto edited the summary of this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27538: Registry: don't destroy the callback on globalsync

[Daniel Vrátil]

dvratil edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27538

To: dvratil, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27538: Registry: don't destroy the callback on globalsync

[Daniel Vrátil]

dvratil created this revision.
dvratil added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  Instead just unref it, because the wl_display_dispatch_queue_pending
  will try to destroy the callback afterwards as well, leading to
  invalid read/write.
  
  Fixes Valgrind warnings when running KScreen tests:
  
  460922== Invalid read of size 4
  ---
  
  460922==at 0x5CE5B34: wl_proxy_unref (wayland-client.c:230)
  ---
  
  460922==by 0x5CE5C33: destroy_queued_closure (wayland-client.c:292)
  ---
  
  460922==by 0x5CE74AB: dispatch_queue (wayland-client.c:1591)
  
  
  460922==by 0x5CE74AB: wl_display_dispatch_queue_pending 
(wayland-client.c:1833)
  
---
  
  460922==by 0x4E0240D: KWayland::Client::EventQueue::dispatch() 
(src/frameworks/kwayland/src/client/event_queue.cpp:96)
  
--
  
  g==460922==  Address 0x17233aac is 44 bytes inside a block of size 80 free'd
  
  460922==at 0x483B9F5: free (vg_replace_malloc.c:540)
  
  
  460922==by 0x4E15B60: destroy 
(src/frameworks/kwayland/src/client/wayland_pointer_p.h:63)
  
-
  
  460922==by 0x4E15B60: 
KWayland::Client::Registry::Private::globalSync(void*, wl_callback*, unsigned 
int) (src/frameworks/kwayland/src/client/registry.cpp:548)
  
--
  
  ...
  
  460922==by 0x5CE74AB: dispatch_queue (wayland-client.c:1591)
  
  
  460922==by 0x5CE74AB: wl_display_dispatch_queue_pending 
(wayland-client.c:1833)
  
---
  
  460922==by 0x4E0240D: KWayland::Client::EventQueue::dispatch() 
(src/frameworks/kwayland/src/client/event_queue.cpp:96)
  
--

TEST PLAN
  Run testkwaylandbackend from libkscreen under Valgrind - no more invalid reads

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27538

AFFECTED FILES
  src/client/registry.cpp

To: dvratil, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27535: Add XdgOutputV1 version 2

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27535

To: davidedmundson, #kwin, zzag
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns