D27152: Introduce FilesystemEntry class

[David Hallas]

hallas updated this revision to Diff 76990.
hallas marked 7 inline comments as done.
hallas added a comment.


  Review comments

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27152?vs=76898=76990

BRANCH
  introduce_filesystem_entry

REVISION DETAIL
  https://phabricator.kde.org/D27152

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/filesystem_entry_test.cpp
  autotests/filesystem_entry_test.h
  autotests/filesystem_type_test.cpp
  autotests/filesystem_type_test.h
  src/solid/devices/backends/fstab/CMakeLists.txt
  src/solid/devices/backends/fstab/filesystem_entry.cpp
  src/solid/devices/backends/fstab/filesystem_entry.h
  src/solid/devices/backends/fstab/filesystem_type.cpp
  src/solid/devices/backends/fstab/filesystem_type.h
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27152: Introduce FilesystemEntry class

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> bruns wrote in filesystem_entry.cpp:31
> This is a behavioral change:
> 
> - overlayfs is no longer handled
> - fuse.cryfs is no longer handled
> 
> - encfs gets an extra '@', and the prefix is changed from  to 
> 
> The identifier is API, don't change it. E.g. dolphin may reference it.

I have added handling of overlayfs and CryFs and removed the '@' separator. 
Actually I don't know why I added the '@', I was sure that I had seen it 
somewhere in the code, but I guess that is not the case ;)

I tried to do a solid-hardware5 list details and compare the before and after 
output, and it should be the same now. I tested with both encfs and cryfs 
filesystems.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Nathaniel Graham]

ngraham added a comment.


  Sorry, I was busy at a hackathon this weekend and am only just now catching 
up on KDE stuff. Thanks for the hotfix.
  
  To echo what Noah said, we'll be more careful in the future. This script 
probably needs to be rewritten in Python and the loop moved into CMake, as 
@sitter suggested--or do you think it would be possible to do the whole thing 
in CMake? It looks like there are facilities to copy files and create symlinks. 
But to be honest, I find CMake to be pretty frustrating and unfriendly to work 
with. :(

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: usta, davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 42 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/42/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 05 Mar 2020 03:51:12 +
 Build duration:
6 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 153 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/153/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 05 Mar 2020 03:51:12 +
 Build duration:
3 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 159 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/159/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Mar 2020 03:51:12 +
 Build duration:
4 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 267 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/267/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Mar 2020 03:51:12 +
 Build duration:
2 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 41 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/41/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 05 Mar 2020 03:40:27 +
 Build duration:
2 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.scalable

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 266 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/266/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Mar 2020 03:40:27 +
 Build duration:
2 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.scalableFailed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(241/300)62%
(113/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)82%
(201/245)63%
(103/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 152 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/152/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 05 Mar 2020 03:40:27 +
 Build duration:
1 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.scalableFailed: projectroot.autotests.symlink

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 158 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/158/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Mar 2020 03:40:27 +
 Build duration:
2 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.scalableFailed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(241/300)62%
(113/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)82%
(201/245)63%
(103/164)

D27617: [breeze-icons] Add telegram-desktop tray icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:27740ce26135: [breeze-icons] Add telegram-desktop tray 
icons (authored by rocka, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27617?vs=76987=76988

REVISION DETAIL
  https://phabricator.kde.org/D27617

AFFECTED FILES
  icons-dark/apps/22/telegram-attention-panel.svg
  icons-dark/apps/22/telegram-mute-panel.svg
  icons-dark/apps/22/telegram-panel.svg
  icons/apps/22/telegram-attention-panel.svg
  icons/apps/22/telegram-mute-panel.svg
  icons/apps/22/telegram-panel.svg

To: rocka, #vdg, Fuchs, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

[Noah Davis]

ndavis updated this revision to Diff 76987.
ndavis edited the test plan for this revision.
ndavis added a comment.


  Update author info

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27617?vs=76946=76987

BRANCH
  arcpatch-D27617_1

REVISION DETAIL
  https://phabricator.kde.org/D27617

AFFECTED FILES
  icons-dark/apps/22/telegram-attention-panel.svg
  icons-dark/apps/22/telegram-mute-panel.svg
  icons-dark/apps/22/telegram-panel.svg
  icons/apps/22/telegram-attention-panel.svg
  icons/apps/22/telegram-mute-panel.svg
  icons/apps/22/telegram-panel.svg

To: rocka, #vdg, Fuchs, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27842: [breeze-icons] New 48px telegram icon

[Noah Davis]

ndavis added a comment.


  In D27842#622396 , @rocka wrote:
  
  > Yes, I submitted it via the Web UI.
  
  
  :/ that happens when people submit via the web UI for whatever reason. It'll 
no longer be an issue when we move KF5 to GitLab, but try to use arcanist 
(`arc`) in the future.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27842

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27842: [breeze-icons] New 48px telegram icon

[Rocket Aaron]

rocka added a comment.


  Yes, I submitted it via the Web UI.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27842

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 265 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/265/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Mar 2020 03:18:42 +
 Build duration:
2 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 157 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/157/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Mar 2020 03:18:42 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

D27842: [breeze-icons] New 48px telegram icon

[Noah Davis]

ndavis added a comment.


  That's weird. It should say authored by @rocka, not me. @rocka, how did you 
submit this patch? Did you submit it via the web UI?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27842

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27842: [breeze-icons] New 48px telegram icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:38dc1aa148d7: [breeze-icons] New 48px telegram icon 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27842?vs=76956=76986

REVISION DETAIL
  https://phabricator.kde.org/D27842

AFFECTED FILES
  icons-dark/apps/48/telegram.svg
  icons/apps/48/telegram.svg

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  You're pretty good at this. Most newbies struggle with all the little things 
that can bite you when making breeze icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27842: [breeze-icons] New 48px telegram icon

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27842

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D25827: kcodecs EBN transport protocol cleanup

[John Hayes]

jhayes abandoned this revision.

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D25827

To: jhayes, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25757: EBN purpose constructor cleanup

[John Hayes]

jhayes abandoned this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D25757

To: jhayes, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26096: kio filewidgets EBN constructor cleanup

[John Hayes]

jhayes abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26096

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26089: baloo EBN transport protocol cleanup

[John Hayes]

jhayes abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26089

To: jhayes, ngraham, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D25865: kfilemetadata EBN transport protocol cleanup

[John Hayes]

jhayes abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25865

To: jhayes
Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D25407: EBN cleanup to change quotes and transport protocol

[John Hayes]

jhayes abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25407

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27848: Remove the panel tooltip icon

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27838: Port to new QML Connections syntax

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Yes, can't be done until 5.14 is required in frameworks.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27838

To: jbbgameich, #frameworks, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

[Aleix Pol Gonzalez]

apol added a comment.


  What's the use-case?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27833

To: meven, ervin, bport, crossi, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27854: [Debug] Correct output of *::toTestMap(), silence non-error

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  MDB_NOTFOUND is the mdb_cursor_get(.., MDB_NEXT) break condition, not
  an actual error.
  
  Correct class name for error output.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27854

AFFECTED FILES
  src/engine/documentdb.cpp
  src/engine/idtreedb.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27855: [Debug] Improve readability of positioninfo debug format

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The docId in hex is shorter and can be better compared with the
  serialized data. Also remove extra whitespace.
  
  No functional changes.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27855

AFFECTED FILES
  src/engine/positioninfo.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27765: [FileContentIndexer] Remove duplicate condition check for loop break

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:ed8cdf3d32f1: [FileContentIndexer] Remove duplicate 
condition check for loop break (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27765?vs=76733=76981

REVISION DETAIL
  https://phabricator.kde.org/D27765

AFFECTED FILES
  src/file/filecontentindexer.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27853: [WriteTransactionTest] Test removal of positions only

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Test keeping the term, but removing all associated positions.
  
  Depends on D27772 .

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27853

AFFECTED FILES
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27772: [WriteTransaction] Extend position test case

[Stefan Brüns]

bruns added a dependent revision: D27853: [WriteTransactionTest] Test removal 
of positions only.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27772

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27851: Add rss icons in action

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:861f6ab52dc3: Add rss icons in action (authored by 
ognarb).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27851?vs=76976=76979

REVISION DETAIL
  https://phabricator.kde.org/D27851

AFFECTED FILES
  icons-dark/actions/22/rss.svg
  icons/actions/22/rss.svg

To: ognarb, #vdg, #breeze, ndavis
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 264 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/264/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Mar 2020 00:06:28 +
 Build duration:
3 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 150 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/150/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 05 Mar 2020 00:06:28 +
 Build duration:
2 min 49 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 156 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/156/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Mar 2020 00:06:28 +
 Build duration:
2 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

D17205: Build kio_nfs against standalone libtirpc

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:1029148d9ca7: Build kio_nfs against standalone libtirpc 
(authored by asturmlechner).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17205?vs=46374=76978#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17205?vs=46374=76978

REVISION DETAIL
  https://phabricator.kde.org/D17205

AFFECTED FILES
  CMakeLists.txt
  nfs/CMakeLists.txt

To: asturmlechner, #dolphin, dfaure, rdieter, sitter
Cc: meven, sitter, kde-frameworks-devel, cgiboudeaux, arojas, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D27851: Add rss icons in action

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D27851#622296 , @cblack wrote:
  
  > SVG-wise, optimization here seems suboptimal. There's excess elements that 
could be removed.
  >
  > Visually, the icon looks like the RSS icon, which is about all you need out 
of an RSS icon.
  >
  > I do believe we need at least 16px and 22px for monochromatic actions, 
though.
  
  
  The main reason we optimize is to make the code readable, not to make it as 
small as possible. The current version is fine.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, #vdg, #breeze, ndavis
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carson Black]

cblack added a comment.


  SVG-wise, optimization here seems suboptimal. There's excess elements that 
could be removed.
  
  Visually, the icon looks like the RSS icon, which is about all you need out 
of an RSS icon.
  
  I do believe we need at least 16px and 22px for monochromatic actions, though.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, #vdg, #breeze
Cc: cblack, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carson Black]

cblack edited reviewers, added: VDG, Breeze; removed: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, #vdg, #breeze, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carl Schwan]

ognarb edited the test plan for this revision.
ognarb added a reviewer: ndavis.
ognarb added a project: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carl Schwan]

ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

TEST PLAN
  Soon

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27851

AFFECTED FILES
  icons-dark/actions/22/rss.svg
  icons/actions/22/rss.svg

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27765: [FileContentIndexer] Remove duplicate condition check for loop break

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh so it does!

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27765

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27544: Fix update scenarios with no explicit downloadlink selected

[Nathaniel Graham]

ngraham added a comment.


  As an aside, I'm somewhat dissatisfied with the current UX when there are 
multiple files. :( I converted a friend of mine to Plasma the other day and he 
was very confused by the multiple items available when he was downloading new 
stuff using the new GHNS window. I know that some of this is the fault of 
content uploaders, but if so, there has to be a way to guide them to upload 
only one file, or to mark a specific file as the real/primary one, and to label 
everything properly etc.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27544

To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, 
#discover_software_store
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27765: [FileContentIndexer] Remove duplicate condition check for loop break

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> filecontentindexer.cpp:69
>  #else
>  if (idList.isEmpty() || m_stop.loadRelaxed()) {
>  #endif

@ngraham - you mean this condition, which comes immediately after?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27765

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27765: [FileContentIndexer] Remove duplicate condition check for loop break

[Nathaniel Graham]

ngraham added a comment.


  Hmm, changing the loop to `while (true)` would seem to reduce some safety if 
none of the break conditions are reached.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27765

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 448 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/448/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 04 Mar 2020 22:02:22 +
 Build duration:
9 min 35 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34838/62064)40%
(17686/43818)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9730/10191)47%
(4542/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8735/14617)51%
(4522/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8328)43%
(2078/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 314 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/314/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 04 Mar 2020 22:02:23 +
 Build duration:
8 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 323 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/323/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 04 Mar 2020 22:02:23 +
 Build duration:
6 min 39 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34827/62064)40%
(17671/43814)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9728/10191)47%
(4540/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8726/14617)51%
(4512/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8328)43%
(2076/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D27848: Remove the panel tooltip icon

[Nathaniel Graham]

ngraham added a comment.


  If the #plasma  people accept, this 
would need to wait until Frameworks 5.70 to land or else rolling release 
distros will lose icons in half their tooltips, but not the rest.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27848: Remove the panel tooltip icon

[Nathaniel Graham]

ngraham retitled this revision from "Remove the tooltip icon" to "Remove the 
panel tooltip icon".

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27848: Remove the tooltip icon

[Niccolò Venerandi]

niccolove accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27846: Fix KNewFileMenuTest

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b40856730534: Fix KNewFileMenuTest (authored by 
ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27846?vs=76968=76973

REVISION DETAIL
  https://phabricator.kde.org/D27846

AFFECTED FILES
  autotests/knewfilemenutest.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27848: Remove the tooltip icon

[Carson Black]

cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  Visually, LGTM.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27848: Remove the tooltip icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  As discussed in T12778 , the icon can 
never be in a correct state: either it's
  redundant with the icon you're hovering over that made the tooltip appear, or
  else it's different from the icon you're hovering over, which is inconsistent.
  
  Since either case is undesirable, let's just remove the icon from the tooltip
  entirely. This reduces the visual noise in the tooltip and solves the entire
  class of bugs automatically.

TEST PLAN
  F8150019: Widget.png 
  F8150017: Systray item.png 
  F8150021: Icon-less tooltips.webm 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

AFFECTED FILES
  src/declarativeimports/core/private/DefaultToolTip.qml

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27846: Fix KNewFileMenuTest

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R241 KIO

BRANCH
  l-KNewFileMenuTest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27846

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27846: Fix KNewFileMenuTest

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Commit ebbfe14309c54476fac 
 
changed the text from "Basic link" to
  "Basic Link", change the unit test accordingly.

REPOSITORY
  R241 KIO

BRANCH
  l-KNewFileMenuTest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27846

AFFECTED FILES
  autotests/knewfilemenutest.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27802: smb: fix ipv6 support

[Christoph Feck]

cfeck added a comment.


  Should this be in 19.12 branch? I am doing a respin of kio-extras anyway.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: cfeck, thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D27802: smb: fix ipv6 support

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27839: Properly name the content of the kcmcontrols project

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27839

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27839: Properly name the content of the kcmcontrols project

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27839

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27842: [breeze-icons] New 48px telegram icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: ndavis.
ngraham added a comment.
This revision is now accepted and ready to land.


  This looks great to me! IMO it's definitely better than the original, but in 
subtle ways.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27842

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27727: Remove empty/unused private classes on internal types

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R280:10054afd8243: Remove empty/unused private classes on 
internal types (authored by vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27727?vs=76657=76965

REVISION DETAIL
  https://phabricator.kde.org/D27727

AFFECTED FILES
  src/lib/code39barcode.cpp
  src/lib/code39barcode.h
  src/lib/code93barcode.cpp
  src/lib/code93barcode.h
  src/lib/datamatrixbarcode.cpp
  src/lib/datamatrixbarcode.h
  src/lib/qrcodebarcode.cpp
  src/lib/qrcodebarcode.h

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27801: smb: add a unit test for smburl

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest

REVISION DETAIL
  https://phabricator.kde.org/D27801

To: sitter, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27844: Store and fetch complete view config in and from session config

[Friedrich W. H. Kossebau]

kossebau added a comment.


  I am a bit surprised this was not already done before? Did I miss something?
  
  Settings like color scheme & zoom are not yet covered, but they might want to 
be restored as well fpr completeness, or? If someone changed them from the 
general settings, they might have had a reason, and that might still be present 
after session restore.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27844: Store and fetch complete view config in and from session config

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Kate, loh.tar, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The manual "Dynamic Word Wrap" config key is also the key used by the
  generic config for this parameter, so config-backward-compatible change.

TEST PLAN
  Saving & loading a KDevelop session now restores more of the view settings,
  like which borders are shown.

REPOSITORY
  R39 KTextEditor

BRANCH
  fullviewconfigsessionsupport

REVISION DETAIL
  https://phabricator.kde.org/D27844

AFFECTED FILES
  src/view/kateview.cpp

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27730: Add API to check whether a barcode is one- or two-dimensional

[Sune Vuorela]

svuorela requested changes to this revision.
svuorela added a comment.
This revision now requires changes to proceed.


  I'm not sure I like the implementation. The current AbstractBarcode can also 
be implemented, at least theoretically, by software providing other barcodes 
that forever reason isn't available here. I have at least done that for some 
PoC ports of other things.
  
  I suggest instead having a 
  enum class BarcodeDimensions { 1d, 2d, 3d, 4d } ; 
  perhaps with better names, and then just a barcodeDimensions() method on 
AbstractBarcode that can be switched over.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27730

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27727: Remove empty/unused private classes on internal types

[Sune Vuorela]

svuorela accepted this revision.
svuorela added a comment.
This revision is now accepted and ready to land.


  These are leftovers from when all constructor was public.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27727

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Nathaniel Graham]

ngraham added a comment.


  Maybe run it through an SVG optimizer; See 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Scour

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27777: Fix clicking thumb-only delegate

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-thumbnail-only-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2

To: leinir, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27794: Fix symlink problem because of using relative path instead of full path

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.


  Yes, the generation of relative symlinks is intentional and necessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27794

To: usta, ngraham, kossebau, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27730: Add API to check whether a barcode is one- or two-dimensional

[Volker Krause]

vkrause added a reviewer: svuorela.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27730

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27727: Remove empty/unused private classes on internal types

[Volker Krause]

vkrause added a reviewer: svuorela.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27727

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27842: [breeze-icons] New 48px telegram icon

[Rocket Aaron]

rocka created this revision.
rocka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rocka requested review of this revision.

REVISION SUMMARY
  Since 48px telegram icon was removed in D27787 
, I made a new one following the official 
icon.

TEST PLAN
  256x256 PNG:
  
  F8149657: out.png 
  
  In panel with other icons:
  
  F8149659: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27842

AFFECTED FILES
  icons-dark/apps/48/telegram.svg
  icons/apps/48/telegram.svg

To: rocka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27152: Introduce FilesystemEntry class

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filesystem_entry_test.h:6
> + *   it under the terms of the GNU General Public License as published by  *
> + *   the Free Software Foundation; either version 2 of the License, or *
> + *   (at your option) any later version.   *

For tests LGPL is preferred as well. Also see D27742 
.

> filesystem_entry.cpp:31
> +case Solid::Backends::Fstab::FilesystemType::FuseEncFs:
> +return device + QLatin1Char('@') + mountPoint;
> +case Solid::Backends::Fstab::FilesystemType::Unknown:

This is a behavioral change:

- overlayfs is no longer handled
- fuse.cryfs is no longer handled

- encfs gets an extra '@', and the prefix is changed from  to 

The identifier is API, don't change it. E.g. dolphin may reference it.

> filesystem_entry.h:5
> + *   This program is free software; you can redistribute it and/or modify  *
> + *   it under the terms of the GNU General Public License as published by  *
> + *   the Free Software Foundation; either version 2 of the License, or *

This has to be LGPL.

Regarding wording, please have a look at D27742 
 for how it should look like.

Applies to other files as well.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

[Kevin Ottens]

ervin added a dependent revision: D27841: Port desktoptheme, icons and 
workspace KCMs to SettingStateBinding.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

[Kevin Ottens]

ervin edited the summary of this revision.
ervin added reviewers: Frameworks, Plasma, VDG.
ervin added a dependency: D27840: Introduce SettingState* elements to ease KCM 
writing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27841

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27840: Introduce SettingState* elements to ease KCM writing

[Kevin Ottens]

ervin edited the summary of this revision.
ervin added reviewers: Frameworks, Plasma.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27838: Port to new QML Connections syntax

[Jonah Brüchert]

jbbgameich added a reviewer: Frameworks.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27838

To: jbbgameich, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27839: Properly name the content of the kcmcontrols project

[Kevin Ottens]

ervin added reviewers: Frameworks, Plasma.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27839

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: crossi, hchain, meven, bport, davidedmundson, mart, 
ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This is the QML based counterpart of D27540 
. Unlike with the KCModule
  case, this is not automatically propagated to the ConfigModules, they
  will all have to be adapted to make use of it.
  
  I will provide another patch which ports a few ConfigModule to see
  how it looks.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/CMakeLists.txt
  src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp
  src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml
  src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir
  src/qmlcontrols/kcmcontrols/settingstateproxy.cpp
  src/qmlcontrols/kcmcontrols/settingstateproxy.h

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27839: Properly name the content of the kcmcontrols project

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: crossi, hchain, meven, bport, davidedmundson, mart, 
ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REVISION SUMMARY
  Looks like it was copied from dragandrop, finish to properly rename
  everything.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27839

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/CMakeLists.txt

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27804: smb: add hack to support spaces in workgroup names

[Harald Sitter]

sitter added a comment.


  In D27804#621970 , @thiago wrote:
  
  > Still want to see that round-trip.
  
  
  But why? Converting an smbcUrl to a QUrl would literally be useless code.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27804

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, thiago, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove added a comment.


  Two questions:
  
  - I know we should not assume it's a Layout, but margins should be defined 
inside the file as they compensate the inset; is it possible to both define 
them with Layout and anchors, or something that would work with both?
  - Is code on line 51 fine? Lines are a bit long there

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27787: Remove 48px telegram icons

[Nathaniel Graham]

ngraham added a comment.


  Here's one problem from simply removing the existing Breeze theme SVG icons: 
the icons shipped in Telegram are raster .pngs which can scale poorly, and the 
circular effect seems quite badly done for the 48px version in particular. For 
example here's how Telegram's icon now looks in my 60px thickness panel with an 
IOTM:
  
  F8149572: Screenshot_20200304_090413.png 

  
  This is Telegram's fault, of course. But it's still gonna bite our users 
until they fix it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27787

To: ndavis, #vdg
Cc: ngraham, rocka, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76947.
niccolove added a comment.


  Moved TopArea to PlasmoidHeading and various fixes in it

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76862=76947

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27804: smb: add hack to support spaces in workgroup names

[Thiago Macieira]

thiago added a comment.


  Still want to see that round-trip.

INLINE COMMENTS

> smburltest.cpp:112
> +// % character - run through .url() to simulate behavior of our 
> listDir()
> +
> QCOMPARE(SMBUrl(QUrl(QUrl("smb://?kio-workgroup=HAX%MAX").url())).toSmbcUrl(),
> + "smb://HAX%25MAX/");

Please don't use QUrl's URL-correction in the constructor. This is not a valid 
URL. Use %25 here.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27804

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, thiago, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27802: smb: fix ipv6 support

[Thiago Macieira]

thiago added a comment.


  looks good to me.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27617: [breeze-icons] Add telegram-desktop tray icons

[Rocket Aaron]

rocka updated this revision to Diff 76946.
rocka added a comment.


  Fix attention dot color and remove accidentally added patch file

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27617?vs=76942=76946

REVISION DETAIL
  https://phabricator.kde.org/D27617

AFFECTED FILES
  icons-dark/apps/22/telegram-attention-panel.svg
  icons-dark/apps/22/telegram-mute-panel.svg
  icons-dark/apps/22/telegram-panel.svg
  icons/apps/22/telegram-attention-panel.svg
  icons/apps/22/telegram-mute-panel.svg
  icons/apps/22/telegram-panel.svg

To: rocka, #vdg, Fuchs
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

[Rocket Aaron]

rocka updated this revision to Diff 76942.
rocka edited the test plan for this revision.
rocka added a comment.


  I've re-make the distinguishing part of the icons following the official one, 
it would be easy to recognize now. See the "Update" part in "Test Plan".
  
  Since the name for tray icons are `telegram-{,attention-,mute-}panel`, it 
would not affect the application icon elsewhere, whose name is 
`telegram-desktop`.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27617?vs=76267=76942

REVISION DETAIL
  https://phabricator.kde.org/D27617

AFFECTED FILES
  icons-dark/apps/22/telegram-attention-panel.svg
  icons-dark/apps/22/telegram-mute-panel.svg
  icons-dark/apps/22/telegram-panel.svg
  icons/apps/22/telegram-attention-panel.svg
  icons/apps/22/telegram-mute-panel.svg
  icons/apps/22/telegram-panel.svg
  telegram-panel-breeze.patch

To: rocka, #vdg, Fuchs
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27835: sftp: fix free space query for urls with empty path

[Méven Car]

meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-free-path

REVISION DETAIL
  https://phabricator.kde.org/D27835

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27835: sftp: fix free space query for urls with empty path

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  e.g. `sftp://localhost` has an empty path
  
  fall back to assume it means '/'

TEST PLAN
  free space correctly listed on sftp://localhost

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-free-path

REVISION DETAIL
  https://phabricator.kde.org/D27835

AFFECTED FILES
  sftp/kio_sftp.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

[Méven Car]

meven retitled this revision from "Add an accessor to get the last load value 
for KConfigSkeletonItem" to "Add an accessor to get the last loaded value for 
KConfigSkeletonItem".

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27833

To: meven, ervin, bport, crossi, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

[Méven Car]

meven updated this revision to Diff 76938.
meven added a comment.


  Clean qDebug traces

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27833?vs=76937=76938

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27833

AFFECTED FILES
  autotests/kconfigloadertest.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: meven, ervin, bport, crossi, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

[Méven Car]

meven updated this revision to Diff 76937.
meven added a comment.


  Avoid some space changes

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27833?vs=76936=76937

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27833

AFFECTED FILES
  autotests/kconfigloadertest.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: meven, ervin, bport, crossi, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

[Méven Car]

meven added a comment.


  Inspired by 4c3d3751968422ff5cba56b5da2036a1bceba314 


REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27833

To: meven, ervin, bport, crossi, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

[Méven Car]

meven created this revision.
meven added reviewers: ervin, bport, crossi, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  It allows to know the last load values from KConfig, for some edge case where 
is is needed to be accessed directly.

TEST PLAN
  build && ctest

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27833

AFFECTED FILES
  autotests/kconfigloadertest.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: meven, ervin, bport, crossi, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns