D28088: Fix warnings

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> containmentactions.cpp:138
>  #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)
> +int o = 
> QObject::staticQtMetaObject.indexOfEnumerator("Orientations");
> +QMetaEnum orient = QObject::staticQtMetaObject.enumerator(o);

const ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28088

To: apol, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27416: Add small icons for KeePassXC

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.


  Since this is a systray icon, you don't actually need to do the 16px version, 
but I guess there's no harm in having a 16px version.
  
  As @cblack said, this needs some work on the pixel alignment. If you don't do 
the 16px version, it'll be significantly less work.
  
  The orange X should be a lock emblem instead. See the `firewall-applet-panic` 
icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27416

To: wsdfhjxc, #vdg, cblack, ndavis
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27416: Add small icons for KeePassXC

[Carson Black]

cblack requested changes to this revision.
cblack added a comment.
This revision now requires changes to proceed.


  The key in both icons should be pixel aligned to prevent blurry edges at the 
size it's going to be rendered at.
  
  F8180107: image.png 
  
  This should also be in `status/` instead of `apps/` as it's a tray icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27416

To: wsdfhjxc, #vdg, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28088: Fix warnings

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28088

AFFECTED FILES
  src/plasma/containmentactions.cpp
  src/plasma/private/storagethread.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27871: sftp: fix seekPos + file resuming when part file is of size 11

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Let's land this now as-is and make that change universally in a separate 
patch before we bikeshed it to death. :)

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-seekpos

REVISION DETAIL
  https://phabricator.kde.org/D27871

To: sitter, ngraham, feverfew
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
emmanuelp, mikesomov

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis added a comment.


  In D25815#628429 , @ngraham wrote:
  
  > Does this have to live in the plasma theme? Could it live in the Breeze 
icon theme?
  
  
  yes, I think I'll move this patch to breeze-icons since there is no longer a 
name conflict

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: ndavis, #vdg, ngraham, vinzenzv
Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, 
cblack, fbampaloukas, GB_2, trickyricky26, michaelh, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  Ping :)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27428: KItemViews: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  Gently "ping", does anybody has a little bit of time to review this?

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D27428

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 109 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/109/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 16 Mar 2020 18:58:14 +
 Build duration:
7 min 47 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27288/32251)53%
(11006/20689)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12526/12599)50%
(6595/13087)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6329/7478)65%
(1833/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7979/9518)64%
(2401/3775)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/61/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Mar 2020 18:58:14 +
 Build duration:
6 min 50 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 68 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/68/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 16 Mar 2020 18:58:14 +
 Build duration:
5 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27288/32250)53%
(11009/20689)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12523/12598)50%
(6594/13087)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6332/7478)65%
(1837/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7979/9518)64%
(2401/3775)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D28056: KWindowSystem: Convert license headers to SPDX expressions

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:d67cc57cf067: KWindowSystem: Convert license headers to 
SPDX expressions (authored by cordlandwehr).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28056?vs=77655=1

REVISION DETAIL
  https://phabricator.kde.org/D28056

AFFECTED FILES
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/MIT.txt
  autotests/compositingenabled_test.cpp
  autotests/dontcrashmapviewport.cpp
  autotests/fixx11h_test.cpp
  autotests/fixx11h_test2.cpp
  autotests/helper/wayland_platform.cpp
  autotests/kkeyserver_x11_unittest.cpp
  autotests/kmanagerselectiontest.cpp
  autotests/kmanagerselectiontest.h
  autotests/kstartupinfo_unittest.cpp
  autotests/kwindoweffectstest.cpp
  autotests/kwindowinfox11test.cpp
  autotests/kwindowsystem_platform_wayland_test.cpp
  autotests/kwindowsystem_threadtest.cpp
  autotests/kwindowsystemx11test.cpp
  autotests/kxmessages_unittest.cpp
  autotests/netrootinfotestwm.cpp
  autotests/nettesthelper.h
  autotests/netwininfotestclient.cpp
  autotests/netwininfotestwm.cpp
  src/kkeyserver.cpp
  src/kkeyserver.h
  src/kstartupinfo.cpp
  src/kstartupinfo.h
  src/kusertimestamp.cpp
  src/kusertimestamp.h
  src/kwindoweffects.cpp
  src/kwindoweffects.h
  src/kwindoweffects_dummy.cpp
  src/kwindoweffects_dummy_p.h
  src/kwindoweffects_p.h
  src/kwindowinfo.cpp
  src/kwindowinfo.h
  src/kwindowinfo_dummy_p.h
  src/kwindowinfo_p.h
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystem.cpp
  src/kwindowsystem.h
  src/kwindowsystem_dummy_p.h
  src/kwindowsystem_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/netwm_def.h
  src/platforms/osx/kkeyserver.cpp
  src/platforms/osx/kkeyserver_mac.h
  src/platforms/osx/kwindowinfo.cpp
  src/platforms/osx/kwindowinfo_mac_p.h
  src/platforms/osx/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem_p_wayland.h
  src/platforms/wayland/plugin.cpp
  src/platforms/wayland/plugin.h
  src/platforms/windows/kkeyserver.cpp
  src/platforms/windows/kkeyserver_win.h
  src/platforms/windows/kwindowinfo.cpp
  src/platforms/windows/kwindowsystem.cpp
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/fixx11h.h
  src/platforms/xcb/kkeyserver.cpp
  src/platforms/xcb/kkeyserver_x11.h
  src/platforms/xcb/kselectionowner.cpp
  src/platforms/xcb/kselectionowner.h
  src/platforms/xcb/kselectionwatcher.cpp
  src/platforms/xcb/kselectionwatcher.h
  src/platforms/xcb/kwindoweffects.cpp
  src/platforms/xcb/kwindoweffects_x11.h
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/kwindowsystem.cpp
  src/platforms/xcb/kwindowsystem_p_x11.h
  src/platforms/xcb/kxerrorhandler.cpp
  src/platforms/xcb/kxerrorhandler_p.h
  src/platforms/xcb/kxmessages.cpp
  src/platforms/xcb/kxmessages.h
  src/platforms/xcb/kxutils.cpp
  src/platforms/xcb/kxutils_p.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h
  src/platforms/xcb/netwm_p.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h
  tests/backgroundcontrasttest.cpp
  tests/blurbehindtest.cpp
  tests/createpixmapfromhandletest.cpp
  tests/icontest.cpp
  tests/setmainwindowtest.cpp

To: cordlandwehr, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28058: KWayland: Convert license headers to SPDX

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:09147becf9b1: KWayland: Convert license headers to SPDX 
(authored by cordlandwehr).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28058?vs=77657=0

REVISION DETAIL
  https://phabricator.kde.org/D28058

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/MIT-CMU.txt
  LICENSES/MIT.txt
  autotests/client/test_compositor.cpp
  autotests/client/test_datadevice.cpp
  autotests/client/test_datasource.cpp
  autotests/client/test_drag_drop.cpp
  autotests/client/test_error.cpp
  autotests/client/test_fake_input.cpp
  autotests/client/test_idle.cpp
  autotests/client/test_plasma_virtual_desktop.cpp
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_pointer_constraints.cpp
  autotests/client/test_remote_access.cpp
  autotests/client/test_selection.cpp
  autotests/client/test_server_side_decoration.cpp
  autotests/client/test_server_side_decoration_palette.cpp
  autotests/client/test_shadow.cpp
  autotests/client/test_shm_pool.cpp
  autotests/client/test_text_input.cpp
  autotests/client/test_wayland_appmenu.cpp
  autotests/client/test_wayland_blur.cpp
  autotests/client/test_wayland_connection_thread.cpp
  autotests/client/test_wayland_contrast.cpp
  autotests/client/test_wayland_filter.cpp
  autotests/client/test_wayland_fullscreen_shell.cpp
  autotests/client/test_wayland_output.cpp
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  autotests/client/test_wayland_region.cpp
  autotests/client/test_wayland_registry.cpp
  autotests/client/test_wayland_seat.cpp
  autotests/client/test_wayland_shell.cpp
  autotests/client/test_wayland_slide.cpp
  autotests/client/test_wayland_subcompositor.cpp
  autotests/client/test_wayland_subsurface.cpp
  autotests/client/test_wayland_surface.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  autotests/client/test_xdg_decoration.cpp
  autotests/client/test_xdg_foreign.cpp
  autotests/client/test_xdg_output.cpp
  autotests/client/test_xdg_shell.cpp
  autotests/client/test_xdg_shell.h
  autotests/client/test_xdg_shell_stable.cpp
  autotests/client/test_xdg_shell_v5.cpp
  autotests/client/test_xdg_shell_v6.cpp
  autotests/server/surfaceextension_helper.cpp
  autotests/server/test_display.cpp
  autotests/server/test_no_xdg_runtime_dir.cpp
  autotests/server/test_qt_surface_extension.cpp
  autotests/server/test_seat.cpp
  cmake/Modules/FindWaylandProtocols.cmake
  src/client/appmenu.cpp
  src/client/appmenu.h
  src/client/blur.cpp
  src/client/blur.h
  src/client/buffer.cpp
  src/client/buffer.h
  src/client/buffer_p.h
  src/client/compositor.cpp
  src/client/compositor.h
  src/client/connection_thread.cpp
  src/client/connection_thread.h
  src/client/contrast.cpp
  src/client/contrast.h
  src/client/datadevice.cpp
  src/client/datadevice.h
  src/client/datadevicemanager.cpp
  src/client/datadevicemanager.h
  src/client/dataoffer.cpp
  src/client/dataoffer.h
  src/client/datasource.cpp
  src/client/datasource.h
  src/client/dpms.cpp
  src/client/dpms.h
  src/client/event_queue.cpp
  src/client/event_queue.h
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/fullscreen_shell.cpp
  src/client/fullscreen_shell.h
  src/client/idle.cpp
  src/client/idle.h
  src/client/idleinhibit.cpp
  src/client/idleinhibit.h
  src/client/keyboard.cpp
  src/client/keyboard.h
  src/client/keystate.cpp
  src/client/keystate.h
  src/client/output.cpp
  src/client/output.h
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/outputmanagement.cpp
  src/client/outputmanagement.h
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmavirtualdesktop.cpp
  src/client/plasmavirtualdesktop.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/pointer.cpp
  src/client/pointer.h
  src/client/pointerconstraints.cpp
  src/client/pointerconstraints.h
  src/client/pointergestures.cpp
  src/client/pointergestures.h
  src/client/protocols/appmenu.xml
  src/client/protocols/blur.xml
  src/client/protocols/contrast.xml
  src/client/protocols/dpms.xml
  src/client/protocols/fake-input.xml
  src/client/protocols/idle.xml
  src/client/protocols/keystate.xml
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/protocols/plasma-effects.xml
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-virtual-desktop.xml
  src/client/protocols/plasma-window-management.xml
  src/client/protocols/remote-access.xml
  

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Kevin Ottens]

ervin accepted this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Fwd: KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Still Failing!

[Ben Cooksley]

Hi Aleix and Harald,

The below appears to have been caused by recent changes you've made to Dr
Konqi and KCrash - mind taking a look?

Note that FreeBSD is also affected by this breakage.

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Tue, 17 Mar 2020, 6:42 AM
Subject: KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 13
- Still Failing!
To: , , 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/13/
Project: kf5-qt5 WindowsMSVCQt5.14
Date of build: Mon, 16 Mar 2020 17:41:10 +
Build duration: 1 min 11 sec and counting
* CONSOLE OUTPUT *
[...truncated 346 lines...]
[2020-03-16T17:42:12.886Z] * KF5JobWidgets (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KF5KIO (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KF5Crash (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KF5Completion (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KF5WidgetsAddons (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KF5Wallet (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KF5Notifications (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KF5IdleTime (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KF5WindowSystem (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KF5 (required version >= 5.61.0)
[2020-03-16T17:42:12.886Z] * KDEWin
[2020-03-16T17:42:12.886Z] * Qt5Test
[2020-03-16T17:42:12.886Z]
[2020-03-16T17:42:12.886Z] -- The following features have been disabled:
[2020-03-16T17:42:12.886Z]
[2020-03-16T17:42:12.886Z] * DrKonqiIntegrationTesting, Needs Ruby,
functional atspi gem, gdb, as well as xvfb-run.
[2020-03-16T17:42:12.886Z]
[2020-03-16T17:42:12.886Z] -- The following RECOMMENDED packages have not
been found:
[2020-03-16T17:42:12.886Z]
[2020-03-16T17:42:12.886Z] * Qt5X11Extras (required version >= 5.12.0)
[2020-03-16T17:42:12.886Z] Recommended for better integration on X11.
[2020-03-16T17:42:12.886Z]
[2020-03-16T17:42:12.886Z] -- Configuring done
[2020-03-16T17:42:13.832Z] -- Generating done
[2020-03-16T17:42:13.832Z] -- Build files have been written to: C:/CI/Job
Build/build
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Compiling)
[Pipeline] bat
[2020-03-16T17:42:14.953Z]
[2020-03-16T17:42:14.953Z] C:\CI\Job Build>call "C:/Program Files
(x86)/Microsoft Visual
Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat"
[2020-03-16T17:42:14.953Z]
**
[2020-03-16T17:42:14.953Z] ** Visual Studio 2019 Developer Command Prompt
v16.4.3
[2020-03-16T17:42:14.953Z] ** Copyright (c) 2019 Microsoft Corporation
[2020-03-16T17:42:14.953Z]
**
[2020-03-16T17:42:15.890Z] [vcvarsall.bat] Environment initialized for:
'x64'
[2020-03-16T17:42:15.890Z] [1/149] Automatic MOC for target crashtest
[2020-03-16T17:42:16.150Z] [2/149] Building CXX object
src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest_autogen\mocs_compilation.cpp.obj
[2020-03-16T17:42:16.150Z] [3/149] Automatic MOC for target
drkonqi_backtrace_parser
[2020-03-16T17:42:16.150Z] [4/149] Automatic MOC for target qbugzilla
[2020-03-16T17:42:16.150Z] [5/149] Automatic MOC for target kdbgwin
[2020-03-16T17:42:17.090Z] [6/149] Building CXX object
src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserlldb.cpp.obj
[2020-03-16T17:42:17.090Z] [7/149] Building CXX object
src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_backtrace_parser_autogen\mocs_compilation.cpp.obj
[2020-03-16T17:42:17.090Z] [8/149] Building CXX object
src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsernull.cpp.obj
[2020-03-16T17:42:17.090Z] [9/149] Building CXX object
src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsercdb.cpp.obj
[2020-03-16T17:42:17.090Z] [10/149] Building CXX object
src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserkdbgwin.cpp.obj
[2020-03-16T17:42:17.090Z] [11/149] Building CXX object
src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla.cpp.obj
[2020-03-16T17:42:17.090Z] [12/149] Building CXX object
src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_parser_debug.cpp.obj
[2020-03-16T17:42:17.090Z] [13/149] Building CXX object
src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\connection.cpp.obj
[2020-03-16T17:42:17.350Z] [14/149] Building CXX object
src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsergdb.cpp.obj
[2020-03-16T17:42:17.350Z] [15/149] Building CXX object
src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\apijob.cpp.obj
[2020-03-16T17:42:17.350Z] [16/149] Building CXX object
src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparser.cpp.obj
[2020-03-16T17:42:17.611Z] [17/149] Building CXX object
src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest.cpp.obj
[2020-03-16T17:42:17.875Z] [18/149] Building CXX object

D25679: Implement writing of front cover in taglibwriter

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibwriter.cpp:78
>  
> +TagLib::String determineMimeTypeOfPicture(const QByteArray )
> +{

https://doc.qt.io/qt-5/qmimedatabase.html#mimeTypeForData

> taglibwriter.cpp:85
> +   pictureData.startsWith(QByteArray::fromHex("FFD8FFEE")) ||
> +   pictureData.startsWith(QByteArray::fromHex("FFD8FFE1"))) {
> +return TagLib::String("image/jpeg");

This list is incomplete - there are also plain jpegs which start with a 
huffmann table, and Adobe apparent writes ones which start with an FFEE 
application marker.

REPOSITORY
  R286 KFileMetaData

BRANCH
  tagLibBinaryWrite

REVISION DETAIL
  https://phabricator.kde.org/D25679

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/65/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Mar 2020 17:34:12 +
 Build duration:
3 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D25679: Implement writing of front cover in taglibwriter

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  tagLibBinaryWrite

REVISION DETAIL
  https://phabricator.kde.org/D25679

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77754.
ahmadsamir added a comment.


  Tweak comment

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28079?vs=77753=77754

BRANCH
  l-mainglobpattern (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28079

AFFECTED FILES
  keditfiletype/filetypedetails.cpp
  keditfiletype/mimetypedata.cpp
  keditfiletype/tests/filetypestest.cpp

To: ahmadsamir, #plasma, dfaure, davidedmundson, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, dfaure, davidedmundson, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  QMimeDatabase re-adds/prepends the "main" glob pattern (the first one
  in the system-wide xml file) to the glob patterns list, even if the user
  has previously removed it e.g. via the filetypes kcm, as a result of that:
  
  - Don't change the sort order of m_patterns. It seems the list returned by 
QMimeType::globPatterns() is "ordered". Also no need to sort() the patterns 
list in the unit test or in MimeTypeData::isMimeTypeDirty()
  - Disable the "Remove" button for the first entry in the glob patterns list 
view
  
  Fix filetypetest (unit test), use "*.inf" instead of "*.txt", the latter
  was always re-added by QMimeDatabase, which made the test fail.

TEST PLAN
  Before applying the diff:
  
- Open the filetypes kcm, and remove the first glob pattern, "*.mp3" from 
audio/mpeg, apply, restart, note that it's been added back to the top of the 
list.
  - Go to text/plain mimetype, the first entry isn't "*.txt"
  
  
  
  
  - Apply the diff then try again, the "Remove" button should be disabled when 
you select the first row in the patterns list view.
  - Select a different entry, "Remove" button should become enabled.
  - Go to text/plain mimetype, "*.txt" is the first entry.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  l-mainglobpattern (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28079

AFFECTED FILES
  keditfiletype/filetypedetails.cpp
  keditfiletype/mimetypedata.cpp
  keditfiletype/tests/filetypestest.cpp

To: ahmadsamir, #plasma, dfaure, davidedmundson, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich added a comment.


  ping @bruns
  this has now been open and unanswered for month!
  Same for the dependent patches

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.13 - Build # 95 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.13/95/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 16 Mar 2020 16:29:24 +
 Build duration:
1 min 21 sec and counting
   CONSOLE OUTPUT
  [...truncated 370 lines...][2020-03-16T16:30:41.764Z] [  1%] Generating fileindexerinterface.cpp, fileindexerinterface.h[2020-03-16T16:30:41.764Z] Warning: Unable to find service type for service "KDEDModule" listed in "/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.13/src/kioslaves/kded/baloosearchmodule.desktop" (/home/jenkins/workspace/Administration/Dependency Build Frameworks kf5-qt5 SUSEQt5.13/kcoreaddons/src/lib/plugin/desktopfileparser.cpp:573, bool DesktopFileParser::convert(const QString&, const QStringList&, QJsonObject&, QString*))[2020-03-16T16:30:41.764Z] [  1%] Built target KF5BalooCodecs_autogen[2020-03-16T16:30:41.764Z] Unknown property type for key "X-KDE-Kded-autoload" -> falling back to string[2020-03-16T16:30:41.764Z] Unknown property type for key "X-KDE-Kded-load-on-demand" -> falling back to string[2020-03-16T16:30:41.764Z] Unknown property type for key "X-KDE-Kded-phase" -> falling back to string[2020-03-16T16:30:41.764Z] Generated  "/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.13/build/src/kioslaves/kded/baloosearchmodule.json"[2020-03-16T16:30:41.764Z] Scanning dependencies of target KF5Baloo_QCH[2020-03-16T16:30:41.764Z] [  2%] Automatic MOC for target baloosearchmodule[2020-03-16T16:30:41.764Z] [  3%] Generating schedulerinterface.moc[2020-03-16T16:30:41.764Z] [  4%] Generating src/lib/KF5Baloo.qch, src/lib/KF5Baloo.tags[2020-03-16T16:30:41.764Z] [  4%] Generating maininterface.moc[2020-03-16T16:30:41.764Z] [  4%] Generating fileindexerinterface.moc[2020-03-16T16:30:42.023Z] [  4%] Built target BalooDBusInterfaces[2020-03-16T16:30:42.023Z] Scanning dependencies of target KF5BalooCodecs[2020-03-16T16:30:42.023Z] [  5%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/KF5BalooCodecs_autogen/mocs_compilation.cpp.o[2020-03-16T16:30:42.023Z] [  5%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/doctermscodec.cpp.o[2020-03-16T16:30:42.023Z] [  5%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/positioncodec.cpp.o[2020-03-16T16:30:42.023Z] [  5%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/postingcodec.cpp.o[2020-03-16T16:30:42.023Z] [  6%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/coding.cpp.o[2020-03-16T16:30:42.288Z] Building up file structure...[2020-03-16T16:30:42.288Z] Insert custom filters...[2020-03-16T16:30:42.288Z] Insert help data for filter section (1 of 1)...[2020-03-16T16:30:42.288Z] Insert files...[2020-03-16T16:30:42.288Z] Insert contents...[2020-03-16T16:30:42.288Z] Insert indices...[2020-03-16T16:30:42.288Z] Documentation successfully generated.[2020-03-16T16:30:42.288Z] [  6%] Built target KF5Baloo_QCH[2020-03-16T16:30:42.288Z] [  6%] Built target baloosearchmodule_autogen[2020-03-16T16:30:42.288Z] [  6%] Built target advancedqueryparsertest_autogen[2020-03-16T16:30:42.288Z] Scanning dependencies of target baloosearchmodule[2020-03-16T16:30:42.288Z] [  6%] Building CXX object src/kioslaves/kded/CMakeFiles/baloosearchmodule.dir/baloosearchmodule_autogen/mocs_compilation.cpp.o[2020-03-16T16:30:42.552Z] [  6%] Building CXX object src/kioslaves/kded/CMakeFiles/baloosearchmodule.dir/baloosearchmodule.cpp.o[2020-03-16T16:30:42.552Z] Scanning dependencies of target advancedqueryparsertest[2020-03-16T16:30:42.553Z] [  6%] Building CXX object autotests/unit/lib/CMakeFiles/advancedqueryparsertest.dir/advancedqueryparsertest_autogen/mocs_compilation.cpp.o[2020-03-16T16:30:42.553Z] [  6%] Building CXX object autotests/unit/lib/CMakeFiles/advancedqueryparsertest.dir/advancedqueryparsertest.cpp.o[2020-03-16T16:30:42.553Z] [  7%] Building CXX object autotests/unit/lib/CMakeFiles/advancedqueryparsertest.dir/__/__/__/src/lib/advancedqueryparser.cpp.o[2020-03-16T16:30:42.553Z] [  7%] Building CXX object autotests/unit/lib/CMakeFiles/advancedqueryparsertest.dir/__/__/__/src/lib/term.cpp.o[2020-03-16T16:30:42.823Z] In file included from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.13/src/codecs/positioncodec.cpp:22:[2020-03-16T16:30:42.823Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.13/src/engine/positioninfo.h: In function ���QDebug Baloo::operator<<(QDebug, const Baloo::PositionInfo&)���:[2020-03-16T16:30:42.823Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.13/src/engine/positioninfo.h:51:26: error: ���hex��� is not a member of ���Qt���[2020-03-16T16:30:42.823Z]51 | dbg.nospace() << Qt::hex << "(" << pos.docId << ": "[2020-03-16T16:30:42.823Z]   |  ^~~[2020-03-16T16:30:42.823Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.13/src/engine/positioninfo.h:51:26: note: suggested alternatives:[2020-03-16T16:30:42.823Z] In file 

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 214 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/214/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 16 Mar 2020 16:28:13 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 370 lines...][2020-03-16T16:29:07.179Z] Warning: Unable to find service type for service "KDEDModule" listed in "/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/kioslaves/kded/baloosearchmodule.desktop" (/home/jenkins/workspace/Administration/Dependency Build Frameworks kf5-qt5 SUSEQt5.12/kcoreaddons/src/lib/plugin/desktopfileparser.cpp:573, bool DesktopFileParser::convert(const QString&, const QStringList&, QJsonObject&, QString*))[2020-03-16T16:29:07.179Z] Unknown property type for key "X-KDE-Kded-autoload" -> falling back to string[2020-03-16T16:29:07.179Z] Unknown property type for key "X-KDE-Kded-load-on-demand" -> falling back to string[2020-03-16T16:29:07.179Z] Unknown property type for key "X-KDE-Kded-phase" -> falling back to string[2020-03-16T16:29:07.179Z] Generated  "/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/build/src/kioslaves/kded/baloosearchmodule.json"[2020-03-16T16:29:07.179Z] [  2%] Automatic MOC for target baloosearchmodule[2020-03-16T16:29:07.179Z] [  2%] Generating schedulerinterface.cpp, schedulerinterface.h[2020-03-16T16:29:07.179Z] [  2%] Generating maininterface.moc[2020-03-16T16:29:07.179Z] [  2%] Generating fileindexerinterface.moc[2020-03-16T16:29:07.179Z] [  2%] Built target KF5BalooCodecs_autogen[2020-03-16T16:29:07.179Z] [  3%] Generating schedulerinterface.moc[2020-03-16T16:29:07.179Z] Scanning dependencies of target KF5Baloo_QCH[2020-03-16T16:29:07.179Z] Scanning dependencies of target KF5BalooCodecs[2020-03-16T16:29:07.179Z] [  3%] Built target BalooDBusInterfaces[2020-03-16T16:29:07.179Z] [  4%] Generating src/lib/KF5Baloo.qch, src/lib/KF5Baloo.tags[2020-03-16T16:29:07.499Z] [  5%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/KF5BalooCodecs_autogen/mocs_compilation.cpp.o[2020-03-16T16:29:07.499Z] [  5%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/doctermscodec.cpp.o[2020-03-16T16:29:07.499Z] [  5%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/positioncodec.cpp.o[2020-03-16T16:29:07.499Z] [  5%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/postingcodec.cpp.o[2020-03-16T16:29:07.499Z] [  6%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/coding.cpp.o[2020-03-16T16:29:07.499Z] [  6%] Built target advancedqueryparsertest_autogen[2020-03-16T16:29:07.499Z] [  6%] Built target baloosearchmodule_autogen[2020-03-16T16:29:07.499Z] Scanning dependencies of target advancedqueryparsertest[2020-03-16T16:29:07.499Z] Scanning dependencies of target baloosearchmodule[2020-03-16T16:29:07.499Z] [  6%] Building CXX object autotests/unit/lib/CMakeFiles/advancedqueryparsertest.dir/advancedqueryparsertest_autogen/mocs_compilation.cpp.o[2020-03-16T16:29:07.499Z] [  6%] Building CXX object autotests/unit/lib/CMakeFiles/advancedqueryparsertest.dir/advancedqueryparsertest.cpp.o[2020-03-16T16:29:07.768Z] [  6%] Building CXX object src/kioslaves/kded/CMakeFiles/baloosearchmodule.dir/baloosearchmodule_autogen/mocs_compilation.cpp.o[2020-03-16T16:29:07.768Z] [  6%] Building CXX object src/kioslaves/kded/CMakeFiles/baloosearchmodule.dir/baloosearchmodule.cpp.o[2020-03-16T16:29:07.768Z] [  7%] Building CXX object autotests/unit/lib/CMakeFiles/advancedqueryparsertest.dir/__/__/__/src/lib/advancedqueryparser.cpp.o[2020-03-16T16:29:07.768Z] [  7%] Building CXX object autotests/unit/lib/CMakeFiles/advancedqueryparsertest.dir/__/__/__/src/lib/term.cpp.o[2020-03-16T16:29:07.768Z] Building up file structure...[2020-03-16T16:29:07.768Z] Insert custom filters...[2020-03-16T16:29:07.768Z] Insert help data for filter section (1 of 1)...[2020-03-16T16:29:07.768Z] Insert files...[2020-03-16T16:29:07.768Z] Insert contents...[2020-03-16T16:29:07.768Z] Insert indices...[2020-03-16T16:29:07.768Z] Documentation successfully generated.[2020-03-16T16:29:07.768Z] [  7%] Built target KF5Baloo_QCH[2020-03-16T16:29:08.351Z] In file included from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/codecs/positioncodec.cpp:22:[2020-03-16T16:29:08.351Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/engine/positioninfo.h: In function ���QDebug Baloo::operator<<(QDebug, const Baloo::PositionInfo&)���:[2020-03-16T16:29:08.351Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/engine/positioninfo.h:51:26: error: ���hex��� is not a member of ���Qt���[2020-03-16T16:29:08.351Z]51 | dbg.nospace() << Qt::hex << "(" << pos.docId << ": "[2020-03-16T16:29:08.351Z]   |  ^~~[2020-03-16T16:29:08.351Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/engine/positioninfo.h:51:26: note: suggested alternatives:[2020-03-16T16:29:08.351Z] In file included from 

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 90 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/90/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Mar 2020 16:28:34 +
 Build duration:
32 sec and counting
   CONSOLE OUTPUT
  [...truncated 284 lines...][2020-03-16T16:29:00.404Z] [2020-03-16T16:29:00.404Z] -- Configuring done[2020-03-16T16:29:01.342Z] -- Generating done[2020-03-16T16:29:01.342Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-16T16:29:02.457Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project baloo --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-03-16T16:29:02.457Z] Scanning dependencies of target BalooDBusInterfaces[2020-03-16T16:29:02.457Z] Scanning dependencies of target KF5FileMetaData_QCH[2020-03-16T16:29:02.457Z] Scanning dependencies of target KF5CoreAddons_QCH[2020-03-16T16:29:02.457Z] Scanning dependencies of target KF5BalooCodecs_autogen[2020-03-16T16:29:02.457Z] Scanning dependencies of target baloosearchmodule_autogen[2020-03-16T16:29:02.457Z] Scanning dependencies of target Qt5Core_QCH[2020-03-16T16:29:02.457Z] [  0%] Built target KF5FileMetaData_QCH[2020-03-16T16:29:02.457Z] [  0%] Generating org.kde.baloo.main.xml[2020-03-16T16:29:02.457Z] [  0%] Built target KF5CoreAddons_QCH[2020-03-16T16:29:02.457Z] [  0%] Automatic MOC for target KF5BalooCodecs[2020-03-16T16:29:02.457Z] [  0%] Generating baloosearchmodule.json[2020-03-16T16:29:02.457Z] [  0%] Built target Qt5Core_QCH[2020-03-16T16:29:02.457Z] Warning: Unable to find service type for service "KDEDModule" listed in "/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.13/src/kioslaves/kded/baloosearchmodule.desktop" (/usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/src/lib/plugin/desktopfileparser.cpp:573, bool DesktopFileParser::convert(const QString &, const QStringList &, QJsonObject &, QString *))[2020-03-16T16:29:02.457Z] [  1%] Generating org.kde.baloo.scheduler.xml[2020-03-16T16:29:02.457Z] Unknown property type for key "X-KDE-Kded-autoload" -> falling back to string[2020-03-16T16:29:02.457Z] Unknown property type for key "X-KDE-Kded-load-on-demand" -> falling back to string[2020-03-16T16:29:02.457Z] Unknown property type for key "X-KDE-Kded-phase" -> falling back to string[2020-03-16T16:29:02.457Z] Generated  "/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.13/build/src/kioslaves/kded/baloosearchmodule.json"[2020-03-16T16:29:02.718Z] Scanning dependencies of target advancedqueryparsertest_autogen[2020-03-16T16:29:02.718Z] [  1%] Generating org.kde.baloo.fileindexer.xml[2020-03-16T16:29:02.718Z] [  1%] Automatic MOC for target baloosearchmodule[2020-03-16T16:29:02.718Z] [  2%] Automatic MOC for target advancedqueryparsertest[2020-03-16T16:29:02.718Z] Scanning dependencies of target KF5Baloo_QCH[2020-03-16T16:29:02.718Z] [  2%] Generating maininterface.cpp, maininterface.h[2020-03-16T16:29:02.718Z] [  2%] Generating src/lib/KF5Baloo.qch, src/lib/KF5Baloo.tags[2020-03-16T16:29:02.718Z] [  2%] Generating schedulerinterface.cpp, schedulerinterface.h[2020-03-16T16:29:02.718Z] [  2%] Built target KF5BalooCodecs_autogen[2020-03-16T16:29:02.718Z] [  2%] Generating fileindexerinterface.cpp, fileindexerinterface.h[2020-03-16T16:29:02.718Z] [  2%] Generating maininterface.moc[2020-03-16T16:29:02.718Z] [  3%] Generating schedulerinterface.moc[2020-03-16T16:29:02.718Z] [  3%] Generating fileindexerinterface.moc[2020-03-16T16:29:02.718Z] [  3%] Built target BalooDBusInterfaces[2020-03-16T16:29:02.718Z] Scanning dependencies of target KF5BalooCodecs[2020-03-16T16:29:02.718Z] [  3%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/doctermscodec.cpp.o[2020-03-16T16:29:02.718Z] [  4%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/KF5BalooCodecs_autogen/mocs_compilation.cpp.o[2020-03-16T16:29:02.718Z] [  4%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/positioncodec.cpp.o[2020-03-16T16:29:02.718Z] [  4%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/postingcodec.cpp.o[2020-03-16T16:29:03.308Z] [  4%] Built target baloosearchmodule_autogen[2020-03-16T16:29:03.308Z] [  4%] Built target advancedqueryparsertest_autogen[2020-03-16T16:29:03.579Z] [  5%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/coding.cpp.o[2020-03-16T16:29:03.579Z] Scanning dependencies of target baloosearchmodule[2020-03-16T16:29:03.579Z] [  5%] Building CXX object src/kioslaves/kded/CMakeFiles/baloosearchmodule.dir/baloosearchmodule_autogen/mocs_compilation.cpp.o[2020-03-16T16:29:03.579Z] Scanning dependencies of target advancedqueryparsertest[2020-03-16T16:29:03.837Z] [  5%] Building CXX object 

D27855: [Debug] Improve readability of positioninfo debug format

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:d3d5cda0e462: [Debug] Improve readability of positioninfo 
debug format (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27855?vs=76983=77751

REVISION DETAIL
  https://phabricator.kde.org/D27855

AFFECTED FILES
  src/engine/positioninfo.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27853: [WriteTransactionTest] Test removal of positions only

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:be8ae0f34689: [WriteTransactionTest] Test removal of 
positions only (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27853?vs=76980=77749

REVISION DETAIL
  https://phabricator.kde.org/D27853

AFFECTED FILES
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27772: [WriteTransaction] Extend position test case

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:bcdaa6c9a029: [WriteTransaction] Extend position test 
case (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27772?vs=76743=77748

REVISION DETAIL
  https://phabricator.kde.org/D27772

AFFECTED FILES
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27854: [Debug] Correct output of *::toTestMap(), silence non-error

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b3217e3cb31d: [Debug] Correct output of *::toTestMap(), 
silence non-error (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27854?vs=76982=77750

REVISION DETAIL
  https://phabricator.kde.org/D27854

AFFECTED FILES
  src/engine/documentdb.cpp
  src/engine/idtreedb.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27771: [WriteTransaction] Avoid growing m_pendingOperations twice on replace

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b0b32093524f: [WriteTransaction] Avoid growing 
m_pendingOperations twice on replace (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27771?vs=76742=77747

REVISION DETAIL
  https://phabricator.kde.org/D27771

AFFECTED FILES
  src/engine/writetransaction.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28078: guard against duplicated service discoveries

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-no-dupes

REVISION DETAIL
  https://phabricator.kde.org/D28078

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25421: [kio_tags] improve log message when the database can't be opened

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25421

To: ahmadsamir, #baloo, astippich, ngraham, bruns
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25517: Add an option to extract image data and add front cover property

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  I agree, let's get this in now and refactor it later.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  What @meven said about the typo, otherwise LGTM indeed.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson, ervin
Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27502: Create ConfigView an unmanaged ConfigWidget

[Kevin Ottens]

ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27502

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25815: Transmission-Qt tray icon added

[Nathaniel Graham]

ngraham added a comment.


  Does this have to live in the plasma theme? Could it live in the Breeze icon 
theme?

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: ndavis, #vdg, ngraham, vinzenzv
Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, 
cblack, fbampaloukas, GB_2, trickyricky26, michaelh, bruns

D28078: guard against duplicated service discoveries

[Harald Sitter]

sitter added a comment.


  FTR: this could technically still dupe with smbc native NT1 listing, except 
smbc would list workgroups while we list services, so this should generally not 
be duplicative information.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28078

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

[Friedrich W. H. Kossebau]

Am Montag, 16. März 2020, 10:39:39 CET schrieb Ben Cooksley:
> On Mon, Mar 16, 2020 at 10:24 PM David Edmundson
> 
>  wrote:
> > There is not a SIC. KIO is fine
> > 
> > It's merely this crap again:
> > 
> > if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
> > 
> >add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06)
> >add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06)
> > 
> > endif()
> 
> May I suggest that we tweak this macro so that passing 0x06 makes
> it no-op and fail open (disabling nothing)?

We could only tweak the macros handling K*_DISABLE_DEPRECATED_BEFORE_AND_AT, 
though those are complicated enough and this would also just be a work-around 
for a usage currently not favoured by many (it will be wanted at KF6 
preparation/porting times though).

Instead we should finally create the policy everywhere to use 
QT_DISABLE_DEPRECATED_BEFORE & KF_DISABLE_DEPRECATED_BEFORE_AND_AT only with 
numbers of released versions that have been checked against. And not use those 
with version numbers of the future to trigger failing builds for developers 
once further API in use is deprecated, to force people into working on usage 
of deprecated API instantly.

Some thought doing 0x06 would be still acceptable with master branches. 
Though this would need active avoiding to have this setup on creating new 
stable branches being copied into those. Which seems not cared for though.
And myself I am among the people who think also for master being forced into 
deprecated API work is overdoing - it is good to do things as early as 
possible, to "flatten the curve" of Qt6/KF6 porting work. But that is what 
warnings are for.

Laurent,
could you do the favour to change all the usages of 
*DISABLE_DEPRECATED_BEFORE_AND_AT you introduced to a version matching to the 
latest released version you are sure works fine? (or organize such a change by 
people working on those repos). And this should be done for stable as well 
(sadly 20.04 was just branched :/ ).
The "if (EXISTS "${CMAKE_SOURCE_DIR}/.git")" should be removed as well then, 
no longer being needed, and to also ensure released tarballs are built with 
same flags as developer builds (might e.g. affect overloaded methods).

Yes, this will break your personal workflow of your deprecated API usage work 
(which IMHO is very valuable, sadly of the kind nobody will really notice due 
to Qt6/KF6 porting life being easier for them without knowing how bad it would 
have been, you will stay an unsung hero).
I have no simple idea yet how to enable a similar approach yet again. Passing 
"-Werror=deprecated-declarations" to the build configurations via env vars is 
not targeted only at Qt & KF, so might have undesired sideeffects.

Cheers
Friedrich

D28078: guard against duplicated service discoveries

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  if both dnssd and wsdiscovery have the same server on offer we'd create
  duplicated entries. instead keep track of the discovered names and only
  use the first discovery. notably happens when using wsdd on linux where
  samba would also register itself on dnssd.
  
  for ease of access and to not have to roundtrip through udsentry, discovery
  objects now have a udsName function that is meant to be the exact name
  used for the udsentry.

TEST PLAN
  - have samba
  - run wsdd.py from https://github.com/christgau/wsdd
  - server only shows up once

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-no-dupes

REVISION DETAIL
  https://phabricator.kde.org/D28078

AFFECTED FILES
  smb/discovery.h
  smb/dnssddiscoverer.cpp
  smb/dnssddiscoverer.h
  smb/kio_smb_browse.cpp
  smb/wsdiscoverer.cpp
  smb/wsdiscoverer.h

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D23457: Port the search interface from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23457

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28061: Reduce unneeded dependencies

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:aa2ea5059e02: Reduce unneeded dependencies (authored by 
apol).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28061?vs=77678=77732

REVISION DETAIL
  https://phabricator.kde.org/D28061

AFFECTED FILES
  src/tests/crashtest/CMakeLists.txt
  src/tests/crashtest/crashtest.cpp

To: apol, #frameworks, davidedmundson, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

[Méven Car]

meven abandoned this revision.
meven added a comment.


  This is not needed anymore.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27833

To: meven, ervin, bport, crossi, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27804: smb: add hack to support spaces in workgroup names

[Harald Sitter]

sitter added a comment.


  Yep. I'm 100% certain of this. The library in fact has no API that returns a 
complete URL or anything near a complete URL. It's using dirent-inspired API to 
let us iterate/stat paths and only ever returns paths relative to whatever 
input it got, from those paths we then compose the actual output URLs again.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27804

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, thiago, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27520: add readdirplus2 support for samba>=4.12

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:ec40cd6ef3f4: add readdirplus2 support for samba=4.12 
(authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27520?vs=76048=77717#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27520?vs=76048=77717

REVISION DETAIL
  https://phabricator.kde.org/D27520

AFFECTED FILES
  smb/CMakeLists.txt
  smb/config-smb.h.cmake
  smb/kio_smb.h
  smb/kio_smb_browse.cpp

To: sitter, ngraham, asn
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27804: smb: add hack to support spaces in workgroup names

[Thiago Macieira]

thiago added a comment.


  In D27804#621988 , @sitter wrote:
  
  > In D27804#621970 , @thiago wrote:
  >
  > > Still want to see that round-trip.
  >
  >
  > But why? Converting an smbcUrl to a QUrl would literally be useless code.
  
  
  Are you saying you never convert the URL coming from the library so it can be 
displayed in KIO/Dolphin? Are you sure you always decompose its parts and 
recompose a QUrl from it?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27804

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, thiago, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27872: sftp: fix partial transfer resuming when copying to local

[Harald Sitter]

sitter added a comment.


  ping

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27872

To: sitter, ngraham, feverfew, bruns
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
emmanuelp, mikesomov

D27873: sftp: do not show creation time when we do not know it

[Harald Sitter]

sitter added a comment.


  ping

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27873

To: sitter, ngraham, bruns
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
emmanuelp, mikesomov

D27902: smb: figure out the best host to use for the UDS_URL

[Harald Sitter]

sitter added a comment.


  ping

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27902

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27804: smb: add hack to support spaces in workgroup names

[Harald Sitter]

sitter added a comment.


  In D27804#621988 , @sitter wrote:
  
  > In D27804#621970 , @thiago wrote:
  >
  > > Still want to see that round-trip.
  >
  >
  > But why? Converting an smbcUrl to a QUrl would literally be useless code.
  
  
  @thiago ^

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27804

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, thiago, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28014: smb: do not double finish

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:8252861157a2: smb: do not double finish (authored by 
sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28014?vs=77502=77714

REVISION DETAIL
  https://phabricator.kde.org/D28014

AFFECTED FILES
  smb/kio_smb_mount.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28061: Reduce unneeded dependencies

[Harald Sitter]

sitter accepted this revision.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28061

To: apol, #frameworks, davidedmundson, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

[Ben Cooksley]

On Mon, Mar 16, 2020 at 10:24 PM David Edmundson
 wrote:
>
> There is not a SIC. KIO is fine
>
> It's merely this crap again:
>
> if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
>add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06)
>add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06)
> endif()

May I suggest that we tweak this macro so that passing 0x06 makes
it no-op and fail open (disabling nothing)?
We have had way too many build failures due to this.

>
> in kreversi
>
> In plasma I ported all these to:
>add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT= kf5 version we 
> depend on at time of release
>
> on kossebau's suggestion
>
> David

Cheers,
Ben

Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

[David Edmundson]

There is not a SIC. KIO is fine

It's merely this crap again:

if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
   add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06)
   add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06)
endif()

in kreversi

In plasma I ported all these to:
   add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT= kf5 version we
depend on at time of release

on kossebau's suggestion

David

Fwd: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

[Ben Cooksley]

This appears to be yet more fallout due to the regression within KIO.

I'm therefore treating this as a Source Incompatibie Change to KIO, and
will be reverting that change in 24 hours unless someone has an alternative
solution.

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Mon, Mar 16, 2020 at 9:51 PM
Subject: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build #
26 - Still Failing!
To: , 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Applications/job/kreversi/job/kf5-qt5%20FreeBSDQt5.13/26/
Project: kf5-qt5 FreeBSDQt5.13
Date of build: Mon, 16 Mar 2020 08:50:05 +
Build duration: 40 sec and counting
* CONSOLE OUTPUT *
[...truncated 277 lines...]
[2020-03-16T08:50:35.165Z] * Qt5Quick (required version >= 5.12.0)
[2020-03-16T08:50:35.165Z] * ECM (required version >= 1.6.0)
[2020-03-16T08:50:35.165Z] * KF5Declarative (required version >= 5.30.0)
[2020-03-16T08:50:35.165Z] * KF5IconThemes (required version >= 5.30.0)
[2020-03-16T08:50:35.165Z] * KF5KIO (required version >= 5.30.0)
[2020-03-16T08:50:35.165Z] * KF5XmlGui (required version >= 5.30.0)
[2020-03-16T08:50:35.165Z] * KF5 (required version >= 5.30.0)
[2020-03-16T08:50:35.165Z] * Qt5Network (required version >= 5.9.0)
[2020-03-16T08:50:35.165Z] * Qt5QuickWidgets (required version >= 5.9.0)
[2020-03-16T08:50:35.165Z] * Qt5Qml (required version >= 5.9.0)
[2020-03-16T08:50:35.165Z] * Gettext
[2020-03-16T08:50:35.165Z] * KF5I18n (required version >= 5.46.0)
[2020-03-16T08:50:35.165Z] * KF5CoreAddons (required version >= 5.68.0)
[2020-03-16T08:50:35.165Z] * KF5Auth (required version >= 5.68.0)
[2020-03-16T08:50:35.165Z] * KF5Codecs (required version >= 5.68.0)
[2020-03-16T08:50:35.165Z] * KF5WidgetsAddons (required version >= 5.68.0)
[2020-03-16T08:50:35.165Z] * KF5ConfigWidgets (required version >= 5.46.0)
[2020-03-16T08:50:35.165Z] * Qt5Widgets (required version >= 5.12.0)
[2020-03-16T08:50:35.165Z] * KF5Completion (required version >= 5.46.0)
[2020-03-16T08:50:35.165Z] * KF5KDEGames (required version >= 4.9.0)
[2020-03-16T08:50:35.165Z] * Qt5Core
[2020-03-16T08:50:35.165Z]
[2020-03-16T08:50:35.165Z] -- Configuring done
[2020-03-16T08:50:35.165Z] -- Generating done
[2020-03-16T08:50:35.444Z] -- Build files have been written to:
/usr/home/jenkins/workspace/Applications/kreversi/kf5-qt5
FreeBSDQt5.13/build
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Compiling)
[Pipeline] sh
[2020-03-16T08:50:36.359Z] + python3 -u ci-tooling/helpers/compile-build.py
--product Applications --project kreversi --branchGroup kf5-qt5 --platform
FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/
[2020-03-16T08:50:36.621Z] Scanning dependencies of target kreversi_autogen
[2020-03-16T08:50:36.621Z] Scanning dependencies of target
doc-index-cache-bz2
[2020-03-16T08:50:36.621Z] [ 7%] Automatic MOC for target kreversi
[2020-03-16T08:50:36.621Z] [ 7%] Generating index.cache.bz2
[2020-03-16T08:50:38.123Z] [ 7%] Built target doc-index-cache-bz2
[2020-03-16T08:50:38.827Z] [ 7%] Built target kreversi_autogen
[2020-03-16T08:50:38.827Z] [ 11%] Generating qrc_kreversi.cpp
[2020-03-16T08:50:38.827Z] [ 15%] Generating ui_startgamedialog.h
[2020-03-16T08:50:38.827Z] [ 19%] Generating preferences.h, preferences.cpp
[2020-03-16T08:50:39.130Z] Scanning dependencies of target kreversi
[2020-03-16T08:50:39.131Z] [ 23%] Building CXX object
CMakeFiles/kreversi.dir/kreversi_autogen/mocs_compilation.cpp.o
[2020-03-16T08:50:39.131Z] [ 26%] Building CXX object
CMakeFiles/kreversi.dir/commondefs.cpp.o
[2020-03-16T08:50:39.131Z] [ 30%] Building CXX object
CMakeFiles/kreversi.dir/colorscheme.cpp.o
[2020-03-16T08:50:39.131Z] [ 34%] Building CXX object
CMakeFiles/kreversi.dir/kreversiview.cpp.o
[2020-03-16T08:50:39.131Z] [ 38%] Building CXX object
CMakeFiles/kreversi.dir/kreversigame.cpp.o
[2020-03-16T08:50:39.131Z] [ 42%] Building CXX object
CMakeFiles/kreversi.dir/kreversihumanplayer.cpp.o
[2020-03-16T08:50:39.131Z] [ 46%] Building CXX object
CMakeFiles/kreversi.dir/kreversicomputerplayer.cpp.o
[2020-03-16T08:50:39.411Z] [ 50%] Building CXX object
CMakeFiles/kreversi.dir/kreversiplayer.cpp.o
[2020-03-16T08:50:39.411Z] [ 53%] Building CXX object
CMakeFiles/kreversi.dir/Engine.cpp.o
[2020-03-16T08:50:39.411Z] [ 57%] Building CXX object
CMakeFiles/kreversi.dir/startgamedialog.cpp.o
[2020-03-16T08:50:39.411Z] [ 61%] Building CXX object
CMakeFiles/kreversi.dir/kexthighscore.cpp.o
[2020-03-16T08:50:39.411Z] [ 65%] Building CXX object
CMakeFiles/kreversi.dir/highscores.cpp.o
[2020-03-16T08:50:42.110Z] [ 69%] Building CXX object
CMakeFiles/kreversi.dir/kexthighscore_gui.cpp.o
[2020-03-16T08:50:42.110Z] [ 73%] Building CXX object
CMakeFiles/kreversi.dir/kexthighscore_internal.cpp.o
[2020-03-16T08:50:42.110Z] [ 76%] Building CXX object
CMakeFiles/kreversi.dir/kexthighscore_item.cpp.o
[2020-03-16T08:50:42.110Z] [ 80%] Building CXX object
CMakeFiles/kreversi.dir/kexthighscore_tab.cpp.o
[2020-03-16T08:50:42.110Z] [ 84%] Building CXX object