D28355: Introduce function ecm_install_configured_file

[Friedrich W. H. Kossebau]

kossebau added a comment.


  A  .rst file in the docs/module/ directory is needed, otherwise the 
documentation generation will not pick up this, as it runs only over docs/.
  Please enable the documentation generation in your ecm build and check for 
yourself, by e.g. ensuring `BUILD_HTML_DOCS` is `ON` and browsing the generated 
html in the build dir.
  
  That might also show that leaving empty lines without leading # as treated as 
limit for the documentation IIRC, so all lines which should belong to processed 
docs need a leading #, other than what the current patch does.
  
  Next I wonder why ".cmake.in" is an expected suffix here. That seems 2x 
suffixes used for input files. Usually in build systems input files have the 
suffix ".in", while with cmake there has also been a pattern of ".cmake" 
introduced, for whatever reason not liking `.in`. Having both suffixes at the 
same time is surprising and odd to me, what do I miss?
  IMHO the code should rather support both ".in" and ".cmake" (first test the 
one, otherwise the other), and perhaps for covering Plasma  needs additionally 
".cmake.in" first, if you have too many files already with that pattern to fix 
this with the actual files instead rather.
  
  For the actual macro signatur, I wonder if something like
  
ecm_install_configured_file(TEMPLATES  [ [...]] DESTINATION 
 [COPYONLY] [ESCAPE_QUOTES] [@ONLY] [COMPONENT ])
  
  would not be better:
  
  - allows to handle multiple files if needed in one go
  - argument block names (TEMPLATES, DESTINATION) makes the code easier to read 
where the macro is used IMHO, and also allows extensibility in the future, if 
more arguments are found to be useful.
  - enabling to pass `COPYONLY`, `ESCAPE_QUOTES`, `@ONLY`on to 
`configure_file()` might be wanted as well
  - COMPONENT is underused, but some use it, so wanted to be passed on to 
`install()`
  
  Would be interesting to see actual examples where you made use of this new 
macro and how it improves things.
  
  Also missing; unit test (sorry) :)

INLINE COMMENTS

> ECMConfiguredInstall.cmake:12
> +# .. code-block:: cmake
> +#   ecm_install_configured_file(foo.txt.cmake.in ${KDE_INSTALL_FULL_DATADIR})
> +

The 'FULL' variants are not meant to be used usually, only where really needed, 
so for consistency better to leave out from the example and just use 
`KDE_INSTALL_DATADIR`, so people have recommended code to copy, and also do not 
wonder where the `FULL` variant is different from what they see elsewhere.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

D25315: KDirModel: implement showing a root node for the requested URL

[Raphael Rosch]

rrosch added a comment.


  Tested, no crashes, it works as intended, and it is beautiful! Thank you!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28355: Introduce function ecm_install_configured_file

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ECMConfiguredInstall.cmake:46-48
> Maybe.
> 
> My rationale for not forcing a suffix is sometimes we do this configure dance 
> for .desktop files and there we have to be a bit careful with scripty.
> 
> But generally it's neater and easier to use when a suffix is used. Currently 
> Plasma is all over the place with what suffix to have, so I picked one at 
> random.

No problem either way. My idea is that if a precise suffix is required, then 
setting it //before// this function is merged is better, otherwise doing it 
once it is already in use means breaking potential (mis)users.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D28355: Introduce function ecm_install_configured_file

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> pino wrote in ECMConfiguredInstall.cmake:46-48
> considering we are documenting the input file as `.cmake.in`, should we 
> enforce this here and ignore any file not ending like that?

Maybe.

My rationale for not forcing a suffix is sometimes we do this configure dance 
for .desktop files and there we have to be a bit careful with scripty.

But generally it's neater and easier to use when a suffix is used. Currently 
Plasma is all over the place with what suffix to have, so I picked one at 
random.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 
50% transparency, while rating has 100% opacity? That makes my compare script 
go wild, and I think it doesn’t look intended.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D28367: KServiceAction: store parent service

[David Faure]

dfaure added a dependent revision: D28268: KDesktopFileActions: port from 
KRun::run to KIO::ApplicationLauncherJob.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D28367

To: dfaure, broulik, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28268: KDesktopFileActions: port from KRun::run to KIO::ApplicationLauncherJob

[David Faure]

dfaure added a dependency: D28367: KServiceAction: store parent service.

REPOSITORY
  R241 KIO

BRANCH
  kdesktopfileactions

REVISION DETAIL
  https://phabricator.kde.org/D28268

To: dfaure, davidedmundson, apol, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28268: KDesktopFileActions: port from KRun::run to KIO::ApplicationLauncherJob

[David Faure]

dfaure updated this revision to Diff 78710.
dfaure edited the summary of this revision.
dfaure added a comment.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.


  Rebase on D28367 , remove KService::Ptr 
arg

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28268?vs=78421=78710

BRANCH
  kdesktopfileactions

REVISION DETAIL
  https://phabricator.kde.org/D28268

AFFECTED FILES
  src/gui/applicationlauncherjob.cpp
  src/gui/applicationlauncherjob.h
  src/widgets/kdesktopfileactions.cpp

To: dfaure, davidedmundson, apol, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28367: KServiceAction: store parent service

[David Faure]

dfaure created this revision.
dfaure added reviewers: broulik, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This allows KIO::ApplicationLauncherJob to find the icon and name of
  the parent service when executing a KServiceAction.

TEST PLAN
  test passes, kio port works

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28367

AFFECTED FILES
  autotests/kservicetest.cpp
  src/services/kservice.cpp
  src/services/kserviceaction.cpp
  src/services/kserviceaction.h

To: dfaure, broulik, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 502 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/502/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 27 Mar 2020 21:32:54 +
 Build duration:
5 min 50 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)56%
(35266/62554)40%
(17763/43978)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(9989/10458)47%
(4625/9870)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8757/14649)51%
(4538/8837)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8334)43%
(2078/4816)src.gui100%
(5/5)100%
(5/5)81%
(328/407)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)52%
(675/1286)37%
(380/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1806/4287)36%
(1312/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob

[David Faure]

dfaure added a reviewer: broulik.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28266

To: dfaure, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  Cannot reproduce, it looks like what's in the screenshots to me. Just for 
sure, I also added the dep on Nate's patch as that improves legibility. I 
totally agree on your points seen what you got, that'd be extreme. With what 
I'm actually trying to propose (I don't know if the problem is on my or your 
side), the change looks like the screenshot I added. I also added screenshots 
with fullscreen windows, as that's important as well. E.g., with the default 
wallpaper, left panel and maximized white window it looks like this, which is 
good enough IMO since master is not perfect either: 
  F8202189: Screenshot_20200327_221948.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

[David Faure]

dfaure added a comment.


  Makes sense.
  
  But in many places, having to provide both is problematic. E.g. when the 
KServiceAction is the value<>() of a QAction.
  I'll look into storing the KService::Ptr inside the KServiceAction. If this 
works out, we can remove the KService::Ptr argument from this class...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28285

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a dependency: D28317: Adjust default color scheme and titlebar 
appearance for Tools Area.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Kevin Ottens]

ervin updated this revision to Diff 78703.
ervin added a comment.


  As advised by Kai and David on D27840 , 
switch to using tool buttons and fix RTL handling.

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27540?vs=78468=78703

REVISION DETAIL
  https://phabricator.kde.org/D27540

AFFECTED FILES
  src/CMakeLists.txt
  src/kconfigdialogmanager.cpp
  src/kconfigdialogmanager.h
  src/kconfigdialogmanager_p.h
  src/settingsstatusindicator.cpp
  src/settingsstatusindicator_p.h

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Kevin Ottens]

ervin added a reviewer: broulik.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D28362: Fix stylesheet linking in 8 icons

[David Hurka]

davidhurka updated this revision to Diff 78702.
davidhurka added a comment.


  - Fix spelling

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28362?vs=78701=78702

BRANCH
  fix-some-style-attributes

REVISION DETAIL
  https://phabricator.kde.org/D28362

AFFECTED FILES
  icons/actions/16/distribute-vertical-center.svg
  icons/actions/16/edit-clear-locationbar-ltr.svg
  icons/actions/16/mail-reply-all.svg
  icons/actions/22/distribute-vertical-center.svg
  icons/actions/22/edit-clear-locationbar-ltr.svg
  icons/actions/22/kstars_supernovae.svg
  icons/actions/symbolic/list-remove-symbolic.svg
  icons/devices/16/network-wireless-connected-25.svg

To: davidhurka
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28362: Fix stylesheet linking in 8 icons

[David Hurka]

davidhurka updated this revision to Diff 78701.
davidhurka added a subscriber: ndavis.
davidhurka added a comment.


  @ndavis

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28362?vs=78700=78701

BRANCH
  fix-some-style-attributes

REVISION DETAIL
  https://phabricator.kde.org/D28362

AFFECTED FILES
  icons/actions/16/distribute-vertical-center.svg
  icons/actions/16/edit-clear-locationbar-ltr.svg
  icons/actions/16/mail-reply-all.svg
  icons/actions/22/distribute-vertical-center.svg
  icons/actions/22/edit-clear-locationbar-ltr.svg
  icons/actions/22/kstars_supernovae.svg
  icons/actions/symbolic/list-remove-symbolic.svg
  icons/devices/16/network-wireless-connected-25.svg

To: davidhurka
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28362: Fix stylesheet linking in 8 icons

[David Hurka]

davidhurka created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  These 8 icons were (partially) not recolored by the stylesheet, because their 
elements were either not linked to the stylesheet, or had contradicting style 
information.
  This adds the missing class attributes and removes the wrong color 
definitions in the style attributes.
  
  Furthermore, I would like to know why 
icons/actions/symbolic/list-remove-symbolic.svg has an additional stylesheet 
“current-color-scheme-6”. Is that information available?

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-some-style-attributes

REVISION DETAIL
  https://phabricator.kde.org/D28362

AFFECTED FILES
  icons/actions/16/distribute-vertical-center.svg
  icons/actions/16/edit-clear-locationbar-ltr.svg
  icons/actions/16/mail-reply-all.svg
  icons/actions/22/distribute-vertical-center.svg
  icons/actions/22/edit-clear-locationbar-ltr.svg
  icons/actions/22/kstars_supernovae.svg
  icons/actions/symbolic/list-remove-symbolic.svg
  icons/devices/16/network-wireless-connected-25.svg

To: davidhurka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

[Kevin Ottens]

ervin updated this revision to Diff 78698.
ervin marked 10 inline comments as done.
ervin added a comment.


  Addresses Kai and David comments.

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27840?vs=78469=78698

REVISION DETAIL
  https://phabricator.kde.org/D27840

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/CMakeLists.txt
  src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp
  src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml
  src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir
  src/qmlcontrols/kcmcontrols/settingstatebindingprivate.cpp
  src/qmlcontrols/kcmcontrols/settingstatebindingprivate.h
  src/qmlcontrols/kcmcontrols/settingstateproxy.cpp
  src/qmlcontrols/kcmcontrols/settingstateproxy.h

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27840: Introduce SettingState* elements to ease KCM writing

[Kevin Ottens]

ervin marked 15 inline comments as done.
ervin added inline comments.

INLINE COMMENTS

> broulik wrote in SettingStateBinding.qml:58
> This description didn't really help me in understanding what it does until I 
> read the code further down.

Went for something much more verbose, but at least it says what it does.

> broulik wrote in SettingStateBinding.qml:75
> Can you explain this.
> Can't you
> 
>   indicatorComponent.createObject(target, {
>   settingsState: settingsState
>   });

Good point.

> broulik wrote in SettingStateBinding.qml:91
> We could also bind `parent: target` instead?

Tried it and QQuickItem was very angry at me, I didn't push further. :-)

> broulik wrote in SettingStateBinding.qml:97
> Please check if this works with right-to-left languages (run with `-reverse` 
> argument to test)

Again that's one of those comments I'd have appreciated on the widgets version 
a little while ago. ;-)

> davidedmundson wrote in SettingStateIndicator.qml:30
> This is a faux-button.
> 
> Which means it needs all the relevant:
> Accessible.blah
> 
> roles to be manually added
> 
> Should it be in the tab focus chain?
> 
> (or we could just inherit ToolButton)

Note this is the case for the QtWidgets implementation as well. I switched to 
ToolButton here but I likely need to do something similar in my other patch... 
would have been nice to have this comment earlier there (it's been ready a bit 
longer), you guys have a bias against widgets based patches. ;-)

I think it shouldn't temper with focus at all though, this is almost impossible 
to get correct in that context I think, so it'll simply reject focus (not too 
much of an issue in that context IMHO).

> broulik wrote in SettingStateIndicator.qml:40
> Perhaps bind to `icon.valid`?

Done completely differently with ToolButton anyway.

> broulik wrote in SettingStateIndicator.qml:48
> You could make the `root` `Item` a `MouseArea` instead.
> Also, I think this should get some kind of hover and/or pressed indication?
> Also, what about `Accessible` and keyboard focus? Should this be a proper 
> `ToolButton` control instead?

See my reply to @davidedmundson above, I switched to ToolButton.

> broulik wrote in settingstatebindingprivate.cpp:30
> Odd. Wouldn't we just get `QQuickRowLayout` et al? Or is that if you do a 
> custom item with a `Layout` as a base?

Or if you make something like Kirigami.FormLayout which has Item as base... 
obviously it's mostly an heuristic so can't be 100% perfect.

> broulik wrote in settingstatebindingprivate.cpp:82
> Too bad `QQuickItemChangeListener` is private.
> 
> Also, does any of this need event compression?

That really didn't feel like it required event compression to be honest at 
least I couldn't perceive any visible impact.

> broulik wrote in settingstatebindingprivate.cpp:90
> Check if it actually changed before emitting

Well it will have changed in 90% of the cases and checking means doing the 
computation anyway, which will happen when the getter is called. We'd pay the 
price twice.

An option is of course to cache the result of the getter to the price of higher 
complexity. Again I didn't perceive any visible impact on use. Should I go for 
it anyway?

Note I'm not at all denying this implementation is in some way inefficient, I'm 
just pointing out the trade off in term of readability and maintainability of 
the system.

> broulik wrote in settingstatebindingprivate.cpp:107
> Check if it actually changed before emitting

Same answer than the previous such case.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28359: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze-Icons

[Paul McAuley]

paulm added a task: T12793: 'Classik' KDE1-like titlebar button icon style 
replacing Breeze's unorthodox 'Oxygen' style.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28359

To: paulm, #vdg, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28355: Introduce function ecm_install_configured_file

[Pino Toscano]

pino added a comment.


  Nice one! I cannot test right now though, I might do it over the weekend (do 
not hold on me though).
  
  I took the liberty of doing some formatting changes to the header of the new 
file, what do you think?
  
#.rst:
# ECMConfiguredInstall
# 
#
# Take as ``.cmake.in`` file, runs ``configure_file`` and installs it in the
# given location.
#
# ::
#
#   ecm_install_configured_file( )
#
# Example usage:
#
# .. code-block:: cmake
#
#   ecm_install_configured_file(foo.txt.cmake.in 
${KDE_INSTALL_FULL_DATADIR})
#
# This will install the file as ``foo.txt`` with any cmake replacements made
# into the data directory.
#
# Since 5.69.0.


#=
# Copyright 2020  David Edmundson 
  
  Also, not sure whether you need a .rst file in the docs/module/ directory.

INLINE COMMENTS

> ECMConfiguredInstall.cmake:46-48
> +# strip .cmake.in from the end
> +# if that isn't there, we continue as-is
> +string(REGEX REPLACE ".cmake.in$"  "" _name ${_name})

considering we are documenting the input file as `.cmake.in`, should we enforce 
this here and ignore any file not ending like that?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D28355: Introduce function ecm_install_configured_file

[David Edmundson]

davidedmundson updated this revision to Diff 78693.
davidedmundson added a comment.


  Good idea. Done

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28355?vs=78678=78693

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28355

AFFECTED FILES
  modules/ECMConfiguredInstall.cmake

To: davidedmundson
Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi updated this revision to Diff 78691.
trmdi added a comment.


  Improve the logic a bit.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=78427=78691

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  Bug! It should look like this: 
  F8201997: Screenshot_20200327_191850.png 

  Let me check again.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28324: [Inotify] Remove dead/duplicate code

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> pino wrote in kinotify.cpp:350
> no, an assert is sort of "program by contract": you make it clear that this 
> situation ought to not happen, and it if does, at least some people may 
> notice that
> 
> > Anyone touching the code should and has to read the man pages etc anyway.
> 
> and an explicit mention/comment in the code never killed anyone, nor made the 
> code "cluttered"; also what is valid today might change in the future, so 
> writing down why a check/assert was added make sure that people reading the 
> changed documentation know why it made sense when it was added

After two years of maintaining baloo (and other software for much longer) I can 
assure you you are wrong.

If we checked all the conditions which are guaranteed by the API (null 
termination of strings, only complete events, bounds check of event->len ...) 
here and everywhere else, the could would be cluttered. And just picking an 
arbitrary condition to be more equal is nonsense.

This is kernel API, it does not change.

Comments are useful when some code is not obvious. Copying an explicitly 
spelled out condition from the man page does clutter the code. Otherwise we 
would have to copy the whole man page to have the code covered in its entirety.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28324

To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28359: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze-Icons

[Paul McAuley]

paulm created this revision.
paulm added reviewers: VDG, Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
paulm requested review of this revision.

REVISION SUMMARY
  As described in T12793  , this patch 
applies the KDE1-style 'Classik' titlebar icon styles to Breeze.
  
  In D28356 , for Breeze, it modifies both 
kdecoration and kstyle so that there will be consistency when titlebar-like 
buttons are used within applications.
  
  In D28358  , for Breeze-GTK both new SVG 
files are added (affecting GTK applications with client-side-decorations in the 
titlebar like gedit), and the python script has been updated to generate new 
.png files with Cairo (affecting applications like Chromium).
  
  In this diff, for Breeze-Icons, the action icons for window operations have 
been updated to match the 'Classik' style.
  
  Screenshot from before applying patch:
  F8201866: before_with_Breeze-oxygen.png 
  
  Screenshot from after applying patch:
  F8201868: after_with_Classik.png 
  
  Annotated version of previous screenshot, labelled in red with which modules 
are rendering which icons:
  F8201871: Classik_mods_annotated.png 
  
  Another screenshot showing all the titlebar icons after the patch:
  F8201885: Classic_Breeze_buttons_2160.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28359

AFFECTED FILES
  icons-dark/actions/16/window-close.svg
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/16/window-maximize.svg
  icons-dark/actions/16/window-minimize.svg
  icons-dark/actions/16/window-restore.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/22/window-maximize.svg
  icons-dark/actions/22/window-minimize.svg
  icons-dark/actions/22/window-restore.svg
  icons-dark/actions/32/window-close.svg
  icons/actions/16/window-close.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/16/window-maximize.svg
  icons/actions/16/window-minimize.svg
  icons/actions/16/window-restore.svg
  icons/actions/22/window-close.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/22/window-maximize.svg
  icons/actions/22/window-minimize.svg
  icons/actions/22/window-restore.svg
  icons/actions/32/window-close.svg

To: paulm, #vdg, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Carson Black]

cblack requested changes to this revision.
cblack added a comment.


  I've changed my mind to agree with @ngraham here—this is too transparent.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28324: [Inotify] Remove dead/duplicate code

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> bruns wrote in kinotify.cpp:350
> asserts are IMHO pointless, nobody enables them, but it clutters the code. 
> Anyone touching the code should and has to read the man pages etc anyway.

no, an assert is sort of "program by contract": you make it clear that this 
situation ought to not happen, and it if does, at least some people may notice 
that

> Anyone touching the code should and has to read the man pages etc anyway.

and an explicit mention/comment in the code never killed anyone, nor made the 
code "cluttered"; also what is valid today might change in the future, so 
writing down why a check/assert was added make sure that people reading the 
changed documentation know why it made sense when it was added

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28324

To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I see some problems here.
  
  To be honest, the level of transparency is way too high. I know aesthetics 
are subjective, but it just doesn't look good to me. Even with our default 
wallpaper, something about it feels off:
  
  F8201901: Screenshot_20200327_113312.png 

  
  F8201902: Screenshot_20200327_113351.png 

  
  In addition, on the usability side, every transparent surface has worse 
contrast than it did before. And while your screenshots look appealing enough 
when there are no windows on the screen or the wallpaper is otherwise visible. 
But that's not really how people use their machines, right? people tend to 
maximize their windows (novice users or those with small screens) or tile 
everything (advanced users) or have a dozen or more un-maximized, un-tiled 
windows in a huge jumble taking up every pixel of the screen (messy users).
  
  The effect produced when a very transparent popup appears over window content 
of the type that any of these users will be looking at just looks really bad to 
me; the background becomes an ugly gray:
  
  F8201876: Screenshot_20200327_112832.png 

  
  F8201884: Screenshot_20200327_112920.png 

  
  F8201862: Screenshot_20200327_112300.png 

  
  Also the pop-up still doesn't match the panel background: F8201861: 
Screenshot_20200327_112208.png . Is there 
another patch I'm missing that implement this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28324: [Inotify] Remove dead/duplicate code

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> pino wrote in kinotify.cpp:350
> then add an assert for this case, referencing the documentation?

asserts are IMHO pointless, nobody enables them, but it clutters the code. 
Anyone touching the code should and has to read the man pages etc anyway.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28324

To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28355: Introduce function ecm_install_configured_file

[Pino Toscano]

pino added a comment.


  Can you please adapt it so `_template` can be an absolute path?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D28221: Don't write default value to configuration file when default value came from /etc/* file

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.

INLINE COMMENTS

> kconfigskeletontest.cpp:25
>  
> +static inline QString kdeGlobalsPath() {
> +return 
> QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) + 
> "/kdeglobals";

{ should be on its own line

> kconfigskeletontest.cpp:29
> +
> +static inline QString kdeSystemGlobalsPath() {
> +return 
> QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) + 
> "/system.kdeglobals";

ditto

> kconfigskeletontest.cpp:190
> +{
> +// This test ensure we don't override default value when this one came 
> from a file
> +// system.kdeglobals is a global file and can provide default

s/ensure/ensures/

> kconfigskeletontest.cpp:218
> +QCOMPARE(item->value(), 30);
> +}

More comments welcome in that test as well.

> kcoreconfigskeleton.cpp:13
>  #include 
> +#include 
>  

Looks like this include is unused

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28221

To: bport, ervin, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Carson Black]

cblack added a comment.


  In D28353#636183 , @niccolove 
wrote:
  
  > In D28353#636164 , @cblack wrote:
  >
  > > Looks visually appealing to me, with one question: How does this look on 
low-end hardware where there's compositing but no blur?
  >
  >
  > Before:
  >  F8201840: Screenshot_20200327_180214.png 

  > After:
  >  F8201842: Screenshot_20200327_180258.png 

  >
  > It is more grayish, but that will no longer be as soon as D28317 
 lands
  
  
  Looks like a downgrade in legibility, but it wasn't too great before either. 
I wouldn't consider it a blocker.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#636164 , @cblack wrote:
  
  > Looks visually appealing to me, with one question: How does this look on 
low-end hardware where there's compositing but no blur?
  
  
  Before:
  F8201840: Screenshot_20200327_180214.png 

  After:
  F8201842: Screenshot_20200327_180258.png 

  
  It is more grayish, but that will no longer be as soon as D28317 
 lands

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28355: Introduce function ecm_install_configured_file

[David Edmundson]

davidedmundson created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This, as the name suggests, configures a file and installs it.
  
  It's not very complicated but it's a repeated pattern in plasma that
  gets quite messy dealing with temporary files.

TEST PLAN
  Used in a project

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28355

AFFECTED FILES
  modules/ECMConfiguredInstall.cmake

To: davidedmundson
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D28327: [Inotify] Start the MoveFrom expire timer at most once per inotify batch

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:1e7145ac06c0: [Inotify] Start the MoveFrom expire timer 
at most once per inotify batch (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28327?vs=78603=78677

REVISION DETAIL
  https://phabricator.kde.org/D28327

AFFECTED FILES
  src/file/kinotify.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Carson Black]

cblack accepted this revision as: VDG, cblack.
cblack added a comment.
This revision is now accepted and ready to land.


  Looks visually appealing to me, with one question: How does this look on 
low-end hardware where there's compositing but no blur?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Carson Black]

cblack added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove abandoned this revision.
niccolove added a comment.


  in favor of https://phabricator.kde.org/D28353

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, dmenig, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove updated this revision to Diff 78675.
niccolove added a comment.


  Fix breeze dark values

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28353?vs=78668=78675

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

AFFECTED FILES
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28352: [BasicIndexingJob] Remove unused include

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5c8e44d6f0f8: [BasicIndexingJob] Remove unused include 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28352?vs=78661=78674

REVISION DETAIL
  https://phabricator.kde.org/D28352

AFFECTED FILES
  src/file/basicindexingjob.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28326: [UnindexedFileIndexer] Only mark file for content indexing when needed

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:0912abcaa1c9: [UnindexedFileIndexer] Only mark file for 
content indexing when needed (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28326?vs=78602=78673

REVISION DETAIL
  https://phabricator.kde.org/D28326

AFFECTED FILES
  src/file/unindexedfileindexer.cpp

To: bruns, #baloo, ngraham, davidedmundson
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28200: Enable wrapping of error messages which use KMessageWidget

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d9bf6f53a036: Enable wrapping of error messages which use 
KMessageWidget (authored by develoot, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28200?vs=78220=78671

REVISION DETAIL
  https://phabricator.kde.org/D28200

AFFECTED FILES
  kcms/activities/imports/dialog.cpp
  kcms/hardware/joystick/joywidget.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp

To: develoot, #vdg, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28325: [Inotify] Call QFile::decode only in a single place

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b071a8b53fdb: [Inotify] Call QFile::decode only in a 
single place (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28325?vs=78606=78672#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28325?vs=78606=78672

REVISION DETAIL
  https://phabricator.kde.org/D28325

AFFECTED FILES
  src/file/kinotify.cpp

To: bruns, #baloo, ngraham
Cc: kossebau, apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D28200: Enable wrapping of error messages which use KMessageWidget

[Nathaniel Graham]

ngraham added a comment.


  In D28200#636071 , @develoot wrote:
  
  > In D28200#633124 , @ngraham 
wrote:
  >
  > > Anyway, @develoot, could you provide your email address so we can land 
this patch with proper authorship information?
  >
  >
  > My email address is devel...@gmail.com. thanks.
  >  Is there anyway to provide email address automatically?
  
  
  Yeah, if you set up the `arc` command-line tool and use that to submit 
patches, your email address will be preserved in the patch.
  
  Thanks for the patch! May it be the first of many. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28200

To: develoot, #vdg, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> metadata.desktop.cmake:99
> -contrast=0.2
> -#intensity is disabled, in order to auto adjust to the chosen theme color
> -#intensity=2.0

I changed this because: simply put, it doesn't work. I opened a bug about it 
https://bugs.kde.org/show_bug.cgi?id=416699. It results in weird colors that 
have nothing to do with the background. If I understood it correctly, it's 
supposed to tweak the value based on the background darkness in order to make 
the background more light in those cases and preserving readability, but that 
does not seem to work either as there are some places in the 'before' 
screenshots that look way too dark, and are instead much more readable with 
this patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> kconfigtest.cpp:1953
> +
> +void KConfigTest::testKdeglobalsVSDefault()
> +{

Seeing how this test confuses everyone (including me and I knew the problem 
before hand...), I think it'd benefit greatly from getting comments at the most 
important points in its execution (similarly to other tests in that file).

> kconfigtest.h:76
>  
> +void testKdeglobalsVSDefault();
> +

nitpick: should be "Vs"

> kconfigdata.cpp:105
> +if (e.bGlobal && !(options & EntryGlobal) && !k.bDefault)
> +{
> +e.bOverridesGlobal = true;

Should be at the end of the previous line

> kconfigdata.h:63
> +/**
> + * Entry will need to be written on a not global file even if it matches 
> default value
> + */

nitpick: I think I'd write "non global" rather than "not global"

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  (gimme a sec to edit with screenshots)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

AFFECTED FILES
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  I'll make this patch again, as much has change since then, there are things 
I'd do differently, and I'm not a fan of rebasing svg files. I will post the 
progress I did there.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: trmdi, cblack, ndavis, filipf, ngraham, davidedmundson, 
kde-frameworks-devel, dmenig, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, 
michaelh, crozbo, ZrenBot, firef, bruns, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D28200: Enable wrapping of error messages which use KMessageWidget

[Kitae Kim]

develoot added a comment.


  In D28200#633124 , @ngraham wrote:
  
  > Anyway, @develoot, could you provide your email address so we can land this 
patch with proper authorship information?
  
  
  My email address is devel...@gmail.com. thanks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28200

To: develoot, #vdg, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/2/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:45:48 +
 Build duration:
31 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.69.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6933/9120)43%
(10802/24851)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2901/2996)49%
(6197/12734)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/800)42%
(956/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D28352: [BasicIndexingJob] Remove unused include

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  GIT_SILENT

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28352

AFFECTED FILES
  src/file/basicindexingjob.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28352: [BasicIndexingJob] Remove unused include

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28352

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28351: Fix a warning, remove outdated #pragma

[Méven Car]

meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28351

AFFECTED FILES
  src/lib/io/kbackup.cpp
  src/lib/io/kdirwatch.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:15 +
 Build duration:
38 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.69.0.xmllogs/KF5TextEditor/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testAdaFailed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(32994/49187)49%
(14794/30096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4785/5127)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1082/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1934/3176)48%
(1417/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/222)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(947/1224)67%
(612/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)67%
(698/1038)53%

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:18 +
 Build duration:
37 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 47 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27731/32767)53%
(11167/21009)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12604/12679)50%
(6637/13173)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6357/7491)65%
(1836/2834)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8171/9796)63%
(2461/3903)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kglobalaccel » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:19 +
 Build duration:
35 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5GlobalAccel-5.69.0.xmllogs/KF5GlobalAccel/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)20%
(4/20)20%
(4/20)18%
(282/1611)12%
(121/977)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)50%
(124/248)22%
(30/138)src33%
(2/6)33%
(2/6)39%
(158/407)37%
(91/243)src.runtime0%
(0/11)0%
(0/11)0%
(0/815)0%
(0/479)src.runtime.plugins.xcb0%
(0/1)0%
(0/1)0%
(0/141)0%
(0/117)

KDE CI: Frameworks » threadweaver » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:19 +
 Build duration:
35 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ThreadWeaver-5.69.0.xmllogs/KF5ThreadWeaver/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(2/7)71%
(55/78)71%
(55/78)73%
(2430/3328)41%
(2467/6066)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)99%
(1219/1224)51%
(1738/3434)benchmarks0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/60)examples.HelloInternet0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/264)examples.HelloWorld0%
(0/1)0%
(0/1)0%
(0/3)100%
(0/0)examples.HelloWorldRaw0%
(0/1)0%
(0/1)0%
(0/13)100%
(0/0)examples.ThumbNailer0%
(0/14)0%
(0/14)0%
(0/458)0%
(0/880)src98%
(42/43)98%
(42/43)87%
(1211/1387)51%
(729/1428)

KDE CI: Frameworks » khtml » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:15 +
 Build duration:
33 min and counting
   BUILD ARTIFACTS
  acc/KF5KHtml-5.69.0.xmllogs/KF5KHtml/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report58%
(15/26)9%
(57/610)9%
(57/610)3%
(2377/92566)2%
(2205/143316)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)93%
(50/54)48%
(21/44)src41%
(12/29)41%
(12/29)10%
(893/8679)4%
(697/18401)src.css9%
(2/22)9%
(2/22)0%
(20/7603)0%
(8/11768)src.dom15%
(6/39)15%
(6/39)1%
(34/6302)0%
(14/4726)src.ecma2%
(1/46)2%
(1/46)0%
(3/9275)0%
(0/17926)src.editing29%
(2/7)29%
(2/7)1%
(18/1958)0%
(5/4266)src.html0%
(0/49)0%
(0/49)0%
(0/10860)0%
(0/16059)src.imload11%
(3/28)11%
(3/28)3%
(23/773)2%
(14/619)src.imload.decoders80%
(4/5)80%
(4/5)2%
(13/598)1%
(8/654)src.java0%
(0/12)0%
(0/12)0%
(0/1371)0%
(0/2841)src.kmultipart0%
(0/3)0%
(0/3)0%
(0/297)0%
(0/405)src.misc38%
(10/26)38%
(10/26)23%
(821/3628)14%
(696/4979)src.platform0%
(0/1)0%
(0/1)0%
(0/2)100%
(0/0)src.platform.graphics0%
(0/16)0%
(0/16)0%
(0/517)0%
(0/286)src.platform.graphics.qt0%
(0/7)0%
(0/7)0%
(0/225)0%
(0/176)src.platform.text0%
(0/1)0%
(0/1)0%
(0/7)0%
(0/4)src.rendering5%
(5/93)5%
(5/93)0%
(19/23308)0%
(4/32272)src.svg1%
(1/146)1%
(1/146)7%
 

KDE CI: Frameworks » kguiaddons » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kguiaddons/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:18 +
 Build duration:
33 min and counting
   BUILD ARTIFACTS
  acc/KF5GuiAddons-5.69.0.xmllogs/KF5GuiAddons/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)45%
(9/20)45%
(9/20)38%
(469/1221)36%
(236/664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)99%
(195/196)67%
(91/136)src.colors60%
(3/5)60%
(3/5)38%
(120/318)34%
(47/138)src.fonts0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/26)src.text50%
(1/2)50%
(1/2)48%
(97/203)51%
(83/164)src.util33%
(2/6)33%
(2/6)16%
(57/350)9%
(15/166)tests0%
(0/3)0%
(0/3)0%
(0/116)0%
(0/34)

KDE CI: Frameworks » kholidays » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:17 +
 Build duration:
33 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Holidays-5.69.0.xmllogs/KF5Holidays/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(15/17)88%
(15/17)71%
(1577/2225)59%
(858/1462)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(5/5)100%
(5/5)99%
(341/343)63%
(80/128)src100%
(7/7)100%
(7/7)78%
(621/797)70%
(472/675)src.declarative0%
(0/2)0%
(0/2)0%
(0/28)0%
(0/8)src.parsers100%
(2/2)100%
(2/2)45%
(318/705)34%
(137/406)src.parsers.plan2100%
(1/1)100%
(1/1)84%
(297/352)69%
(169/245)

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:16 +
 Build duration:
33 min and counting
   BUILD ARTIFACTS
  acc/KF5NetworkManagerQt-5.69.0.xmllogs/KF5NetworkManagerQt/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 37 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(6/6)53%
(164/311)53%
(164/311)58%
(8150/14126)36%
(1960/5410)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)100%
(239/239)47%
(108/232)autotests.settings100%
(37/37)100%
(37/37)99%
(1907/1915)76%
(254/336)src25%
(26/102)25%
(26/102)26%
(966/3646)21%
(418/1966)src.dbus20%
(16/80)20%
(16/80)9%
(86/920)100%
(0/0)src.fakenetwork75%
(6/8)75%
(6/8)75%
(502/673)46%
(52/114)src.settings94%
(76/81)94%
(76/81)66%
(4450/6733)41%
(1128/2762)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:17 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(239/305)60%
(110/184)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)80%
(199/250)60%
(100/166)

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:16 +
 Build duration:
33 min and counting
   BUILD ARTIFACTS
  acc/KF5Baloo-5.69.0.xmllogs/KF5Baloo/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 34 test(s), Skipped: 0 test(s), Total: 34 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)68%
(116/171)68%
(116/171)59%
(6174/10381)42%
(2325/5601)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)93%
(466/500)78%
(206/264)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(799/799)56%
(236/424)autotests.unit.file100%
(12/12)100%
(12/12)98%
(1076/1097)53%
(338/632)autotests.unit.lib100%
(6/6)100%
(6/6)99%
(408/414)60%
(96/160)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine92%
(35/38)92%
(35/38)77%
(1763/2298)53%
(695/1315)src.file69%
(27/39)69%
(27/39)53%
(1011/1910)42%
(462/1105)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/181)0%
(0/70)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/35)0%
(0/30)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/88)0%
(0/18)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/274)0%
(0/231)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/256)0%
(0/131)src.lib55%
(6/11)55%
(6/11)41%
(393/965)37%
(212/577)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%

KDE CI: Frameworks » frameworkintegration » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:15 +
 Build duration:
32 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FrameworkIntegration-5.69.0.xmllogs/KF5FrameworkIntegration/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)33%
(2/6)33%
(2/6)15%
(71/459)10%
(31/302)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)92%
(24/26)50%
(4/8)src.integrationplugin0%
(0/2)0%
(0/2)0%
(0/70)0%
(0/106)src.kpackage-install-handlers.kns0%
(0/1)0%
(0/1)0%
(0/86)0%
(0/40)src.kstyle100%
(1/1)100%
(1/1)19%
(47/253)18%
(27/148)tests0%
(0/1)0%
(0/1)0%
(0/24)100%
(0/0)

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:16 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)100%
(4/4)100%
(4/4)77%
(60/78)57%
(26/46)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)77%
(60/78)57%
(26/46)

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:15 +
 Build duration:
31 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Declarative-5.69.0.xmllogs/KF5Declarative/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(5/15)18%
(11/60)18%
(11/60)15%
(501/3358)11%
(202/1923)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)91%
(195/214)38%
(99/259)src.calendarevents0%
(0/3)0%
(0/3)0%
(0/63)0%
(0/2)src.kdeclarative75%
(3/4)75%
(3/4)49%
(149/307)36%
(50/140)src.kdeclarative.private100%
(2/2)100%
(2/2)19%
(6/31)0%
(0/18)src.kpackagelauncherqml0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/18)src.qmlcontrols.draganddrop0%
(0/7)0%
(0/7)0%
(0/362)0%
(0/170)src.qmlcontrols.kcmcontrols0%
(0/1)0%
(0/1)0%
(0/3)0%
(0/2)src.qmlcontrols.kconfig0%
(0/2)0%
(0/2)0%
(0/11)0%
(0/2)src.qmlcontrols.kcoreaddons0%
(0/4)0%
(0/4)0%
(0/85)0%
(0/66)src.qmlcontrols.kioplugin0%
(0/2)0%
(0/2)0%
(0/20)0%
(0/24)src.qmlcontrols.kquickcontrols.private0%
(0/4)0%
(0/4)0%
(0/321)0%
(0/226)src.qmlcontrols.kquickcontrolsaddons7%
(1/15)7%
(1/15)5%
(65/1377)4%
(30/756)src.qmlcontrols.kwindowsystemplugin0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/36)src.quickaddons14%
(1/7)14%
(1/7)21%
(86/414)11%
(23/202)tests0%
(0/2)0%
(0/2)0%
(0/27)0%
(0/2)

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:15 +
 Build duration:
30 min and counting
   BUILD ARTIFACTS
  acc/KF5QuickCharts-5.69.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kquickcharts.kf5-qt5_SUSEQt514 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)67%
(22/33)67%
(22/33)46%
(926/2017)29%
(248/857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(56/56)64%
(27/42)controls0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/4)src100%
(9/9)100%
(9/9)54%
(312/581)40%
(81/204)src.datasource44%
(4/9)44%
(4/9)21%
(79/376)18%
(42/234)src.decorations0%
(0/4)0%
(0/4)0%
(0/392)0%
(0/199)src.scenegraph88%
(7/8)88%
(7/8)81%
(479/595)56%
(98/174)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:14 +
 Build duration:
30 min and counting
   BUILD ARTIFACTS
  acc/KF5KDE4Support-5.69.0.xmlacc/KF5KDELibs4Support-5.69.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21566/45930)38%
(13018/34241)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11346/11737)50%
(7172/14369)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9470/17858)48%
(5538/11439)src.kdeui19%
(13/67)19%
(13/67)8%
(740/9665)6%
(307/5368)src.kio7%
(2/27)7%
(2/27)0%
(10/2260)0%
(1/1242)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/855)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/186)0%
(0/87)src.solid-networkstatus.kded0%
(0/7)0%
(0/7)0%
(0/220)0%
(0/102)tests0%
(0/34)0%
(0/34)0%
(0/1530)0%
(0/487)

KDE CI: Frameworks » kwallet » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:15 +
 Build duration:
30 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wallet-5.69.0.xmllogs/KF5Wallet/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(2/9)8%
(3/36)8%
(3/36)4%
(132/3587)1%
(48/3871)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(21/21)57%
(8/14)examples.asynchronous_app0%
(0/2)0%
(0/2)0%
(0/50)0%
(0/38)src.api.KWallet0%
(0/1)0%
(0/1)0%
(0/448)0%
(0/287)src.runtime.kwallet-query.src0%
(0/3)0%
(0/3)0%
(0/170)0%
(0/96)src.runtime.kwalletd0%
(0/8)0%
(0/8)0%
(0/1374)0%
(0/2594)src.runtime.kwalletd.backend20%
(2/10)20%
(2/10)9%
(111/1253)7%
(40/574)src.runtime.kwalletd.backend.tests0%
(0/3)0%
(0/3)0%
(0/77)0%
(0/30)tests.KWallet0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/150)tests.kwalletd0%
(0/7)0%
(0/7)0%
(0/139)0%
(0/88)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 174 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/174/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 27 Mar 2020 14:45:48 +
 Build duration:
5 min 38 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.69.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6934/9121)43%
(10807/24857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2902/2996)49%
(6201/12736)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/801)42%
(957/2273)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kdbusaddons » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdbusaddons/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:15 +
 Build duration:
29 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5DBusAddons-5.69.0.xmllogs/KF5DBusAddons/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)45%
(5/11)45%
(5/11)59%
(293/497)34%
(78/230)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(3/4)75%
(3/4)85%
(177/209)53%
(39/74)src40%
(2/5)40%
(2/5)47%
(116/249)30%
(39/132)src.tools.kquitapp0%
(0/1)0%
(0/1)0%
(0/29)0%
(0/8)tests0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/16)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:15 +
 Build duration:
28 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.69.0.xmllogs/KF5Service/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)85%
(75/88)85%
(75/88)71%
(5909/8305)48%
(2546/5276)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)96%
(1654/1728)50%
(702/1397)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services100%
(31/31)100%
(31/31)63%
(1973/3122)42%
(774/1830)src.sycoca83%
(24/29)83%
(24/29)76%
(2086/2747)61%
(1018/1677)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:14 +
 Build duration:
27 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WebKit-5.69.0.xmllogs/KF5WebKit/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/1)0%
(0/6)0%
(0/6)0%
(0/752)0%
(0/709)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/6)0%
(0/6)0%
(0/752)0%
(0/709)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:12 +
 Build duration:
27 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)56%
(35289/62556)40%
(17806/43974)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(9989/10457)47%
(4617/9870)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8747/14649)51%
(4551/8837)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8336)43%
(2076/4812)src.gui100%
(5/5)100%
(5/5)81%
(328/407)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)40%
(418/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kxmlgui » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:14 +
 Build duration:
25 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5XmlGui-5.69.0.xmllogs/KF5XmlGui/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)44%
(34/77)44%
(34/77)42%
(4100/9673)34%
(1808/5297)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)99%
(1389/1400)48%
(428/888)src50%
(27/54)50%
(27/54)37%
(2711/7358)32%
(1380/4284)src.ksendbugmail0%
(0/4)0%
(0/4)0%
(0/271)0%
(0/67)tests0%
(0/10)0%
(0/10)0%
(0/584)0%
(0/46)tests.krichtexteditor0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/12)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/2/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 27 Mar 2020 14:45:49 +
 Build duration:
2 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kdesignerplugin » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdesignerplugin/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:14 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5DesignerPlugin-5.69.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(3/3)100%
(3/3)98%
(239/243)52%
(69/132)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(139/139)49%
(56/114)src100%
(1/1)100%
(1/1)96%
(100/104)72%
(13/18)

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:14 +
 Build duration:
25 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Syndication-5.69.0.xmllogs/KF5Syndication/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)86%
(78/91)86%
(78/91)63%
(2455/3895)32%
(2793/8833)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)65%
(106/162)38%
(212/562)src83%
(20/24)83%
(20/24)71%
(471/661)43%
(597/1390)src.atom91%
(10/11)91%
(10/11)49%
(342/700)22%
(411/1885)src.mapper100%
(16/16)100%
(16/16)90%
(454/504)51%
(362/712)src.rdf87%
(20/23)87%
(20/23)67%
(839/1244)36%
(1010/2776)src.rss270%
(7/10)70%
(7/10)42%
(243/578)14%
(201/1418)tests0%
(0/1)0%
(0/1)0%
(0/46)0%
(0/90)

KDE CI: Frameworks » kactivities » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kactivities/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:13 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Activities-5.69.0.xmllogs/KF5Activities/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/33)0%
(0/33)0%
(0/1533)0%
(0/1562)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.common0%
(0/2)0%
(0/2)0%
(0/46)0%
(0/86)autotests.core0%
(0/4)0%
(0/4)0%
(0/185)0%
(0/422)src.cli0%
(0/2)0%
(0/2)0%
(0/182)0%
(0/150)src.common.dbus0%
(0/2)0%
(0/2)0%
(0/29)0%
(0/4)src.imports0%
(0/5)0%
(0/5)0%
(0/327)0%
(0/159)src.lib0%
(0/11)0%
(0/11)0%
(0/613)0%
(0/709)src.utils0%
(0/5)0%
(0/5)0%
(0/95)0%
(0/24)tests.activities-model0%
(0/2)0%
(0/2)0%
(0/56)0%
(0/8)

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:14 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.69.0.xmllogs/KF5ItemModels/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)60%
(49/81)60%
(49/81)73%
(6826/9359)57%
(3066/5366)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)99%
(2616/2633)61%
(1160/1889)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1757/2543)54%
(651/1211)src.core82%
(18/22)82%
(18/22)80%
(2370/2961)65%
(1237/1908)src.qml100%
(3/3)100%
(3/3)58%
(83/144)35%
(18/52)tests0%
(0/1)0%
(0/1)0%
(0/23)0%
(0/8)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1055)0%
(0/298)

D28349: Fix Warnings

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:fcdf263339b4: Fix Warnings (authored by meven).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28349?vs=78655=78656

REVISION DETAIL
  https://phabricator.kde.org/D28349

AFFECTED FILES
  autotests/kprocesstest_helper.cpp
  src/lib/caching/kshareddatacache.cpp
  src/lib/io/kdirwatch.cpp

To: meven, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:13 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.69.0.xmllogs/KF5WindowSystem/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)79%
(44/56)79%
(44/56)73%
(7315/9970)54%
(3556/6557)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3091/3178)52%
(1293/2466)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src86%
(12/14)86%
(12/14)53%
(823/1548)42%
(302/722)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(16/17)94%
(16/17)69%
(3394/4886)59%
(1958/3317)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kitemviews » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:14 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemViews-5.69.0.xmllogs/KF5ItemViews/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)11%
(2/18)11%
(2/18)5%
(98/2049)3%
(36/1052)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(22/22)55%
(12/22)src7%
(1/14)7%
(1/14)4%
(76/1778)2%
(24/974)tests0%
(0/3)0%
(0/3)0%
(0/249)0%
(0/56)

KDE CI: Frameworks » kactivities-stats » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kactivities-stats/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:13 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ActivitiesStats-5.69.0.xmllogs/KF5ActivitiesStats/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/35)0%
(0/35)0%
(0/2355)0%
(0/1933)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/5)0%
(0/5)0%
(0/600)0%
(0/410)autotests.common0%
(0/2)0%
(0/2)0%
(0/17)0%
(0/20)autotests.quickcheck.tables0%
(0/4)0%
(0/4)0%
(0/64)0%
(0/26)src0%
(0/11)0%
(0/11)0%
(0/973)0%
(0/1020)src.common.database0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/98)src.common.database.schema0%
(0/1)0%
(0/1)0%
(0/50)0%
(0/14)src.utils0%
(0/7)0%
(0/7)0%
(0/82)0%
(0/43)tests.model0%
(0/3)0%
(0/3)0%
(0/441)0%
(0/302)

D28349: Fix Warnings

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28349

To: meven, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:13 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5IconThemes-5.69.0.xmllogs/KF5IconThemes/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)68%
(15/22)68%
(15/22)53%
(1484/2774)41%
(721/1763)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)99%
(504/506)49%
(188/382)src80%
(8/10)80%
(8/10)47%
(980/2105)39%
(533/1369)src.tools.kiconfinder0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/6)tests0%
(0/4)0%
(0/4)0%
(0/146)0%
(0/6)

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:13 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5DocTools-5.69.0.xmllogs/KF5DocTools/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)83%
(5/6)83%
(5/6)68%
(336/491)43%
(115/267)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc83%
(5/6)83%
(5/6)68%
(336/491)43%
(115/267)

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:12 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextWidgets-5.69.0.xmllogs/KF5TextWidgets/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(18/22)82%
(18/22)50%
(1504/3022)39%
(552/1431)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)97%
(608/625)60%
(129/215)src.dialogs0%
(0/1)0%
(0/1)0%
(0/40)0%
(0/4)src.findreplace100%
(7/7)100%
(7/7)63%
(581/918)51%
(250/490)src.widgets67%
(4/6)67%
(4/6)22%
(315/1428)24%
(173/720)tests0%
(0/1)0%
(0/1)0%
(0/11)0%
(0/2)

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:12 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Codecs-5.69.0.xmllogs/KF5Codecs/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)85%
(50/59)85%
(50/59)76%
(2926/3825)59%
(1308/2199)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(662/669)61%
(113/184)src81%
(13/16)81%
(13/16)74%
(1488/2006)62%
(835/1338)src.probers84%
(31/37)84%
(31/37)67%
(776/1150)53%
(360/677)

KDE CI: Frameworks » kidletime » kf5-qt5 SUSEQt5.14 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kidletime/job/kf5-qt5%20SUSEQt5.14/1/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 27 Mar 2020 14:22:13 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5IdleTime-5.69.0.xmllogs/KF5IdleTime/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/9)0%
(0/9)0%
(0/380)0%
(0/204)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples0%
(0/2)0%
(0/2)0%
(0/28)0%
(0/6)src0%
(0/5)0%
(0/5)0%
(0/191)0%
(0/121)src.plugins.xscreensaver0%
(0/1)0%
(0/1)0%
(0/23)0%
(0/2)src.plugins.xsync0%
(0/1)0%
(0/1)0%
(0/138)0%
(0/75)