D28128: Add force save behavior to KEntryMap

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28421: Add static method to check start condition

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> dfaure wrote in kautostart.h:289
> This is new public API, it's missing @since 5.69

Added.
https://commits.kde.org/kservice/ce83ae51bfc88be77573745ed8a4434393b2f9f1

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D28421

To: hchain, davidedmundson, broulik, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27455: FileWidgets: Ignore Return events from KDirOperator

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D27455

REVISION DETAIL
  https://phabricator.kde.org/D27455

To: meven, dfaure, ngraham, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28421: Add static method to check start condition

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kautostart.h:289
> + */
> +static bool isStartConditionMet(const QString );
> +

This is new public API, it's missing @since 5.69

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D28421

To: hchain, davidedmundson, broulik, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/30/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 03 Apr 2020 22:53:11 +
 Build duration:
7 min 40 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[David Faure]

dfaure added a comment.


  You could create a subdir of a QTemporaryDir with a fixed name like "abc 
def", copy `cp` or `copy.exe` in there, and then run that with an absolute path?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Alexander Saoutkin]

feverfew added a comment.


  Ok so I've updated the code as can be seen. Mucked around with 
disconnecting/connecting, no issues on my side at least.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28535: [KIO-MTP] Fix null pointer dereference

[Alexander Saoutkin]

feverfew updated this revision to Diff 79252.
feverfew added a comment.


  - Don't try to release device in get method

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28535?vs=79198=79252

BRANCH
  fixNullPtr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28535

AFFECTED FILES
  mtp/kiod_module/mtpdevice.cpp

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28542: Add 16px LibreOffice icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:4cdcd11c07da: Add 16px LibreOffice icons (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28542?vs=79232=79251

REVISION DETAIL
  https://phabricator.kde.org/D28542

AFFECTED FILES
  icons-dark/apps/16/libreoffice-base.svg
  icons-dark/apps/16/libreoffice-calc.svg
  icons-dark/apps/16/libreoffice-draw.svg
  icons-dark/apps/16/libreoffice-impress.svg
  icons-dark/apps/16/libreoffice-main.svg
  icons-dark/apps/16/libreoffice-math.svg
  icons-dark/apps/16/libreoffice-writer.svg
  icons/apps/16/libreoffice-base.svg
  icons/apps/16/libreoffice-calc.svg
  icons/apps/16/libreoffice-draw.svg
  icons/apps/16/libreoffice-impress.svg
  icons/apps/16/libreoffice-main.svg
  icons/apps/16/libreoffice-math.svg
  icons/apps/16/libreoffice-writer.svg

To: manueljlin, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28542: Add 16px LibreOffice icons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28542

To: manueljlin, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28542: Add 16px LibreOffice icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: ndavis.
ngraham added a comment.
This revision is now accepted and ready to land.


  @ndavis, you good with this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28542

To: manueljlin, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a dependency: D27439: Replaced isDock check with !hasDecoration.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Nathaniel Graham]

ngraham added a comment.


  The second image definitely looks better than the first. However I wonder if 
we could even combine them into just one row. For toolbars with nothing but 
icons-only buttons, they kind of feel like they're screaming out to be 
integrated into the header.
  
  For toolbars with controls that have labels, yeah, those should probably be 
on a second row.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: manueljlin, ahiemstra, ndavis, ngraham, mart, davidedmundson, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28295: Introduce KNotificationJobUiDelegate

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in knotificationjobuidelegate.cpp:24
> I don't remember any past discussion about this, but as I discovered in KIO 
> commit 3d2330968b 
> , 
> nested Private classes have the problem that you can't forward-declare them 
> elsewhere in order to make them friends of another class.
> 
> What would be the arguments in favour of nested Private classes?
> All I see is the risk of forgetting Q_DECL_HIDDEN, incompatibility with 
> Q_D/Q_Q macros and more generally, inconsistency with Qt, plus the friend 
> problem above.

Someone should update the part about the nested Private classes 
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C++#Using_a_d-Pointer

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: ahmadsamir, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/16/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 03 Apr 2020 17:07:10 +
 Build duration:
1 min 3 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

[Harald Sitter]

sitter updated this revision to Diff 79234.
sitter added a comment.


  chop instead of convoluted remove

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28513?vs=79220=79234

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

AFFECTED FILES
  smb/kio_smb_browse.cpp
  smb/wsdiscoverer.cpp

To: sitter, ngraham, meven
Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, 
fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27504: smb faster copy to local

[Harald Sitter]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:46b5fb425c14: smb: fast copy (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27504?vs=77343=79233

REVISION DETAIL
  https://phabricator.kde.org/D27504

AFFECTED FILES
  smb/CMakeLists.txt
  smb/autotests/CMakeLists.txt
  smb/autotests/transfertest.cpp
  smb/kio_smb.h
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/transfer.cpp
  smb/transfer.h

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, 
kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D27504: smb faster copy to local

[Harald Sitter]

sitter edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, 
kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D28542: Add 16px LibreOffice icons

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Mainly in context menus and small panels. On most apps it isn't really 
needed, but the LibreOffice icons use 1px lines everywhere and that tends to 
look quite blurry
  F8213441: image.png 
  I think it's a good idea to add more variations to breeze icons in general to 
make icons look sharp everywhere

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28542

To: manueljlin, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28542: Add 16px LibreOffice icons

[Nathaniel Graham]

ngraham added a comment.


  LGTM visually. What are these needed for though?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28542

To: manueljlin, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/15/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 03 Apr 2020 16:15:24 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_keynavigation.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_listskeynavigation.qml

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> kossebau wrote in kio_smb_browse.cpp:239
> `QString::remove()` operates on the object itself, no need to assign back to 
> host.
> 
> Besides, why not use `QString::chop(wsdSuffix.size())` ?

Mh. Good point indeed, I'll move to chop. Thanks!

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, 
fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28542: Add 16px LibreOffice icons

[Manuel Jesús de la Fuente]

manueljlin retitled this revision from "Adds 16px LibreOffice icons" to "Add 
16px LibreOffice icons".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28542

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28542: Adds 16px LibreOffice icons

[Manuel Jesús de la Fuente]

manueljlin edited the summary of this revision.
manueljlin added a reviewer: VDG.
manueljlin set the repository for this revision to R266 Breeze Icons.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28542

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28540: Fix layout in DownloadItemsSheet

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-downloaditemssheet-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28540

To: leinir, #frameworks, bugseforuns, mart, #plasma, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Fabian Vogt]

fvogt added a comment.


  I assume there is a reason why `MTPDevice::getDevice()` has code for handling 
this very specific case, so I wouldn't just remove it without figuring out why: 
../https://i.redd.it/hfnl7xo8yovy.gif
  
  If not, that would indeed be the best option.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Thanks! I will commit this tomorrow after branching as we don't typically 
change translated strings within two weeks of branding, so as to give the 
translators time to translate them.

REPOSITORY
  R304 KNewStuff

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28466: Added Page element

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8b5e09314162: Added Page element (authored by niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28466?vs=79004=79227

REVISION DETAIL
  https://phabricator.kde.org/D28466

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Page.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: niccolove, #plasma, ngraham, mart
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28540: Fix layout in DownloadItemsSheet

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.
leinir added reviewers: Frameworks, bugseforuns, mart, Plasma, KNewStuff.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28540

To: leinir, #frameworks, bugseforuns, mart, #plasma, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28540: Fix layout in DownloadItemsSheet

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  The previous code was primarily there to work around misfeatures of 
OverlaySheet which no longer exist. Consequently, we don't have to leave in the 
hacks. Nice.
  
  This further builds on the new OverlaySheet work done by Marco. The whole 
thing works much better, and with less client code. Nice.
  
  BUG:419535

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-downloaditemssheet-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28540

AFFECTED FILES
  src/qtquick/qml/DownloadItemsSheet.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28538: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:7e679b1366fc: Use more UDSEntry::reserve() calls to avoid 
reallocs on multiple inserts (authored by kossebau).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28538?vs=79221=79225

REVISION DETAIL
  https://phabricator.kde.org/D28538

AFFECTED FILES
  activities/KioActivities.cpp
  archive/kio_archivebase.cpp
  man/kio_man.cpp
  mtp/kio_mtp.cpp
  network/ioslave/networkslave.cpp
  recentdocuments/recentdocuments.cpp
  settings/kio_settings.cpp
  sftp/kio_sftp.cpp
  smb/dnssddiscoverer.cpp
  smb/wsdiscoverer.cpp

To: kossebau, #frameworks, sitter, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28538: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems hard to miss cases like for `// +1 for UDS_DISPLAY_NAME` but I will 
trust you did enough review to be confident for all those cases.
  A missing one will just cause an allocation anyway which is what this is 
fixing in the first place, so no arm done basically.

REPOSITORY
  R320 KIO Extras

BRANCH
  usemoreudsentryreserve

REVISION DETAIL
  https://phabricator.kde.org/D28538

To: kossebau, #frameworks, sitter, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28535: [KIO-MTP] Fix null pointer dereference

[Alexander Saoutkin]

feverfew added a comment.


  In D28535#640703 , @anthonyfieroni 
wrote:
  
  > In D28535#640699 , @feverfew 
wrote:
  >
  > > So to be succinct, the only correct fix here is to change `getDevice()` 
to `return m_mtpdevice`?
  >
  >
  > Yes, then check if it's crash, in all other places `LIBMTP_xxx` should take 
care of and return false or nullptr depend of function returning value.
  
  
  What do you mean by "then check if it's crash"? Surely we should do nothing 
and let LIBMTP sort out printing errors and stuff? Eventually the device should 
be reclaimed by the daemon anyway via the help of `Solid::deviceRemoved()`. I 
agree with everything after the comma though, `LIBMTP_mtpdevice_t *` should 
never be freed unless we explicitly do so ourselves.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kio_smb_browse.cpp:239
> +QString host = m_current_url.host();
> +host = host.remove(host.size() - wsdSuffix.size(), wsdSuffix.size());
> +const QString dnssd(host + ".local");

`QString::remove()` operates on the object itself, no need to assign back to 
host.

Besides, why not use `QString::chop(wsdSuffix.size())` ?

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, 
fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28538: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, sitter, meven.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  usemoreudsentryreserve

REVISION DETAIL
  https://phabricator.kde.org/D28538

AFFECTED FILES
  activities/KioActivities.cpp
  archive/kio_archivebase.cpp
  man/kio_man.cpp
  mtp/kio_mtp.cpp
  network/ioslave/networkslave.cpp
  recentdocuments/recentdocuments.cpp
  settings/kio_settings.cpp
  sftp/kio_sftp.cpp
  smb/dnssddiscoverer.cpp
  smb/wsdiscoverer.cpp

To: kossebau, #frameworks, sitter, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

[Harald Sitter]

sitter updated this revision to Diff 79220.
sitter added a comment.


  reshuffle: instead of using .local directly use a fake .kio-disocvery-wsd 
suffix. look for that at listing time and redirect to name.local or name as 
appropriate
  
  this prevents dnssd results form incorrectly getting run through the query 
branch AND has a 100% fallback chance for the llmnr/netbios name if the dnssd 
name isn't resolvable for wsdiscoveries

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28513?vs=79132=79220

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

AFFECTED FILES
  smb/kio_smb_browse.cpp
  smb/wsdiscoverer.cpp

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

[Harald Sitter]

sitter retitled this revision from "smb: use prettyname.local for hostname of 
wsdiscoveries" to "smb: use prettyname.kio-discovery-wsd for hostname of 
wsdiscoveries".
sitter edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 29 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/29/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 03 Apr 2020 13:36:59 +
 Build duration:
7 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28537: [krun] Removed no longer used internal method resolveURLs()

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:abf920c33ff6: [krun] Removed no longer used internal 
method resolveURLs() (authored by kossebau).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28537?vs=79213=79214

REVISION DETAIL
  https://phabricator.kde.org/D28537

AFFECTED FILES
  src/widgets/krun.cpp

To: kossebau, #frameworks, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28537: [krun] Removed no longer used internal method resolveURLs()

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  removeunusedresolveURLs

REVISION DETAIL
  https://phabricator.kde.org/D28537

To: kossebau, #frameworks, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27451: Drop KToolInvocation support from KRun::runService

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> krun.cpp:757
> -// Resolve urls if needed, depending on what the app supports
> -const QList urls = resolveURLs(_urls, _service);
> -

Compiler now complains nothing uses `resolveURLS()`after this.
Clean up  proposed by D28537 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27451

To: davidedmundson, dfaure
Cc: kossebau, ervin, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28537: [krun] Removed no longer used internal method resolveURLs()

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, davidedmundson, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Follow-up to f7cf3b676a4ed491effde0e31fd18c09e913dfe5 

  GIT_SILENT

REPOSITORY
  R241 KIO

BRANCH
  removeunusedresolveURLs

REVISION DETAIL
  https://phabricator.kde.org/D28537

AFFECTED FILES
  src/widgets/krun.cpp

To: kossebau, #frameworks, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D28535#640699 , @feverfew wrote:
  
  > So to be succinct, the only correct fix here is to change `getDevice()` to 
`return m_mtpdevice`?
  
  
  Yes, then check if it's crash, in all other place `LIBMTP_xxx` should take 
care of and return false or nullptr depend of function returning value.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28528: UDSEntry: add constructor variant with std::initializer_list

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 79210.
kossebau added a comment.


  Update to latest master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28528?vs=79182=79210

BRANCH
  udsentryinitlistconstructor

REVISION DETAIL
  https://phabricator.kde.org/D28528

AFFECTED FILES
  autotests/udsentrytest.cpp
  autotests/udsentrytest.h
  src/core/slavebase.cpp
  src/core/udsentry.cpp
  src/core/udsentry.h
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/widgets/renamedialog.cpp
  tests/udsentrybenchmark.cpp

To: kossebau, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Alexander Saoutkin]

feverfew added a comment.


  If you want to, feel free, I'm a bit tight on time. But I will say this. the 
whole `getDevice()` function confuses me. I'm not entirely sure why this `if` 
check is necessary at all. The lifetime of devices and its children (i.e 
storage) should be managed by the KMTPD daemon AFAICT. A device shouldn't be 
trying to re-open itself anywhere IMO. To me the getDevice() function should 
simply be a simple return to avoid this NULL issue happening. Even if a device 
doesn't exist anymore, no segfaults should happen when passing an "invalid" 
`LIBMTP_device_T` to any other `LIBMTP` function?
  
  So to be succinct, the only correct fix here is to change `getDevice()` to 
`return m_mtpdevice`?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b878cb30d36a: Use more UDSEntry::reserve() calls to avoid 
reallocs on multiple inserts (authored by kossebau).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28521?vs=79157=79209

REVISION DETAIL
  https://phabricator.kde.org/D28521

AFFECTED FILES
  src/core/slavebase.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/remote/remoteimpl.cpp
  src/ioslaves/trash/kio_trash.cpp
  src/widgets/renamedialog.cpp

To: kossebau, #frameworks, dfaure
Cc: apol, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28520: Fix lifetime of slot in KIO-MTP

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  slotLifetime (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28520

To: feverfew, akrutzler, dfaure, elvisangelaccio, apol
Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Aleix Pol Gonzalez]

apol added a comment.


  In D28521#640685 , @kossebau wrote:
  
  > @apol So okay if I land this one for now?
  >  The initlist approach does not cover all cases anyway, and until that one 
is reviewed by enough experienced developers (e.g. who can tell if alignment of 
data works as hoped), this here should save resources across the globe already 
:) (even more as std::vector does not know about 
`Q_DECLARE_TYPEINFO(KIO::UDSEntry, Q_MOVABLE_TYPE);` and on each resize does a 
full copy of all items.
  
  
  sure, go for it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28521

To: kossebau, #frameworks, dfaure
Cc: apol, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28510: [kprocessrunner] Escape hyphen characters in scope names

[Henri Chain]

hchain added a comment.


  The full systemd escape code is here: 
https://github.com/systemd/systemd/blob/master/src/basic/unit-name.c#L294

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28510

To: davidedmundson, apol
Cc: hchain, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Anthony Fieroni]

anthonyfieroni added a comment.


  @feverfew are you gonna try what i'm writing about or i should do it? Just 
use cached device, do not reopen since it'll return nullptr.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @apol So okay if I land this one for now?
  The initlist approach does not cover all cases anyway, and until that one is 
reviewed by enough experienced developers (e.g. who can tell if alignment of 
data works as hoped), this here should save resources across the globe already 
:) (even more as std::vector does not know about 
`Q_DECLARE_TYPEINFO(KIO::UDSEntry, Q_MOVABLE_TYPE);` and on each resize does a 
full copy of all items.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28521

To: kossebau, #frameworks, dfaure
Cc: apol, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Fabian Vogt]

fvogt added a comment.


  In D28535#640682 , @feverfew wrote:
  
  > In D28535#640674 , @fvogt wrote:
  >
  > > What you're suggesting is to change `MTPDevice::getDevice` to return the 
old device if reopening fails - but reopening without releasing might not work.
  >
  >
  > This seems to be a robust solution IMO, why do you suspect this might not 
work?
  
  
  Because there can only be a single libusb session per device. So you have to 
release the old one before opening again.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28535: [KIO-MTP] Fix null pointer dereference

[Alexander Saoutkin]

feverfew added a comment.


  In D28535#640674 , @fvogt wrote:
  
  > What you're suggesting is to change `MTPDevice::getDevice` to return the 
old device if reopening fails - but reopening without releasing might not work.
  
  
  This seems to be a robust solution IMO, why do you suspect this might not 
work?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28498: [xdgoutput] Explicitly set version of server interface

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in display.h:297
> You can't introduce another createXdgOutputManager() because it's not 
> overloaded. You probably need to rename this method, e.g. 
> createXdgOutputManager2.

As you've pasted, it is BC, which is what frameworks promises.
It's something that we definitely do currently.

It's also SC for literally every conceivable invocation, and we know how the 
only user of this class is using it.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Fabian Vogt]

fvogt added a comment.


  In D28535#640680 , @anthonyfieroni 
wrote:
  
  > I see we don't speak in same language :)
  >  `LIBMTP_Open_Raw_Device_Uncached(_rawdevice);`
  >  returns nullptr that's normal since device is inaccessible, i mean it does 
not need to call `LIBMTP_Release_Device` using `m_mtpdevice` is safe it's not 
nullptr, it's just a disconnected device and libmtp knows that.
  
  
  Yes, and until that point everything is fine.
  Only after `m_mtpdevice = LIBMTP_Open_Raw_Device_Uncached(_rawdevice);`, 
which sets `m_mtpdevice` to nullptr it goes down the path I outlined.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28535: [KIO-MTP] Fix null pointer dereference

[Anthony Fieroni]

anthonyfieroni added a comment.


  I see we don't speak in same language :)
  `LIBMTP_Open_Raw_Device_Uncached(_rawdevice);`
  returns nullptr that's normal since device is inaccessible, i mean it does 
not need to call `LIBMTP_Release_Device` using `m_mtpdevice` is safe it's not 
nullptr, it's just a disconnected device and libmtp knows that.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28033: Create ExpandableListItem

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Tagging is tomorrow, don't merge before then.

INLINE COMMENTS

> ExpandableListItem.qml:491
> +Item {
> +height: actionsList.height
> +width: mainRowLayout.width

not contentHeight?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28513: smb: use prettyname.local for hostname of wsdiscoveries

[Harald Sitter]

sitter added a comment.


  Stable was the plan, yes.
  
  I've thought of some complications with this approach though. Actually a 
combination of two
  
  1. the .local match also applies to dnssd
  2. all linux VMs I've checked wouldn't be able to resolve netbios names 
natively as the relevant modules are simply not loaded by default. meaning the 
netbios fallback will never be hit because 'foo' cannot ever be resolved (well, 
unless the user manually enables nmbd or lllmnr resolution)
  
  to mitigate 2 we could just always fall back to netbios regardless of its 
resolvability, but that has the problem that we can then discover DNSSD 
services on bar.local have that fall back to bar and somewhat unexpected report 
that 'bar' was not resolvable (when in fact the intended and wanted resolution 
is bar.local for the DNSSD scenario). I'm not sure it's a huge problem, but it 
certainly irks me a bit because very practically libsmbc's resolution may be 
way more flexible than the regular libc/nss resolution.
  
  OTOH fixing both would require yet more URL hackery to carry more context 
from the discovery into the list call. by either making the hostname 
`foo.kio-discovery-wsd` instead of `foo.local` or putting the discovery method 
into a query `smb://foo?kio-discovery=wsd`. I find both a bit meh. but then 
dnssd can be entirely unaffected by any of this

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28535: [KIO-MTP] Fix null pointer dereference

[Fabian Vogt]

fvogt added a comment.


  There is no such thing as an "invalid device" at that point anymore. There's 
only nullptr.
  
LIBMTP_mtpdevice_t *MTPDevice::getDevice()
{
if (!m_mtpdevice->storage) {
qCDebug(LOG_KIOD_KMTPD) << "no storage found: reopen mtpdevice";
LIBMTP_Release_Device(m_mtpdevice);
m_mtpdevice = LIBMTP_Open_Raw_Device_Uncached(_rawdevice);
}

return m_mtpdevice;
}
  
  What you're suggesting is to change `MTPDevice::getDevice` to return the old 
device if reopening fails - but reopening without releasing might not work.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28535: [KIO-MTP] Fix null pointer dereference

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D28535#640672 , @fvogt wrote:
  
  > If `getDevice()` returns nullptr, this means that `MTPDevice::getDevice()` 
returns nullptr. This can only happen if `m_mtpdevice` is nullptr, which will 
crash in `MTPDevice::~MTPDevice` sooner or later anyway.
  
  
  I don't think so, libmtp knows device is not available then 
`LIBMTP_Release_Device` (invalid device) will not crash. So i prefer to cache 
device in storage as well so libmtp will just return false on invalid device.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28535: [KIO-MTP] Fix null pointer dereference

[Fabian Vogt]

fvogt added a comment.


  In D28535#640656 , @anthonyfieroni 
wrote:
  
  > You're right about bug report, but it can fail in any other place, just in 
particular version it happen in  `updateStorageInfo` Can we cache `getDevice` 
in m_device (in constructor) then use it everywhere. I think libmtp has guard 
against disconnected device and will not crash.
  
  
  `MTPDevice` already does that.
  
  If `getDevice()` returns nullptr, this means that `MTPDevice::getDevice()` 
returns nullptr. This can only happen if `m_mtpdevice` is nullptr, which will 
crash in `MTPDevice::~MTPDevice` sooner or later anyway.
  
  So this patch will at most just delay the crash.
  
  AFAICT `MTPDevice` is supposed to be destroyed in `KMTPd::deviceRemoved` on 
disconnection, but this is obviously racy.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 27 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/27/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 03 Apr 2020 11:25:34 +
 Build duration:
5 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28535: [KIO-MTP] Fix null pointer dereference

[Anthony Fieroni]

anthonyfieroni added a comment.


  You're right about bug report, but it can fail in any other place, just in 
particular version it happen in  `updateStorageInfo` Can we cache `getDevice` 
in m_device (in constructor) then use it everywhere. I think libmtp has guard 
against disconnected device and will not crash.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D28510: [kprocessrunner] Escape hyphen characters in scope names

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6fba90325237: [kprocessrunner] Escape hyphen characters 
in scope names (authored by davidedmundson).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28510?vs=79125=79202

REVISION DETAIL
  https://phabricator.kde.org/D28510

AFFECTED FILES
  src/gui/kprocessrunner.cpp

To: davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Alexander Saoutkin]

feverfew created this revision.
feverfew added reviewers: akrutzler, dfaure, elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  A null pointer can be returned from getDevice() if a device is disconnected.
  Passing NULL into LIBMTP_Get_Storage() results in a NULL pointer dereference.
  
  BUG: 405838

TEST PLAN
  Compiles. I couldn't reproduce this as described in the bug report, but from
  reading the attached stacktrace in the bug report it's obvious what went wrong
  here.

REPOSITORY
  R320 KIO Extras

BRANCH
  fixNullPtr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28535

AFFECTED FILES
  mtp/kiod_module/mtpstorage.cpp

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D28520: Fix lifetime of slot in KIO-MTP

[Alexander Saoutkin]

feverfew added a comment.


  @apol just found another one where this occurs, forgot about it but noticed 
it earlier as well. This doesn't affect KIOFuse as much though (as we don't 
listen to the processedSize() signal).
  
  I'll wait for another approval, or before 20.04 tagging, whichever comes 
first :P

REPOSITORY
  R320 KIO Extras

BRANCH
  slotLifetime (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28520

To: feverfew, akrutzler, dfaure, elvisangelaccio, apol
Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D28520: Fix lifetime of slot in KIO-MTP

[Alexander Saoutkin]

feverfew updated this revision to Diff 79196.
feverfew added a comment.


  - Fix another slot lifetime

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28520?vs=79154=79196

BRANCH
  slotLifetime (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28520

AFFECTED FILES
  mtp/kio_mtp.cpp

To: feverfew, akrutzler, dfaure, elvisangelaccio, apol
Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D28466: Added Page element

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28466

To: niccolove, #plasma, ngraham, mart
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28532: Introduce more user-visible error reporting for installations

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 79195.
leinir added a comment.


  - Address @pino's comment re i18n overload usage

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28532?vs=79191=79195

BRANCH
  more-installation-error-handling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28532

AFFECTED FILES
  src/core/engine.cpp
  src/core/installation.cpp
  src/core/installation.h
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/ErrorDisplayer.qml
  src/qtquick/qml/private/MessageBoxSheet.qml

To: leinir, #knewstuff, #plasma, ngraham, #frameworks
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28532: Introduce more user-visible error reporting for installations

[Pino Toscano]

pino added a comment.


  Please fix the i18n() calls, as the values of placeholders are passed as 
parameter to it instead of using .arg():
  
i18n("foo %1").arg(foo)  // WRONG
i18n("foo %1", foo)  // correct

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28532

To: leinir, #knewstuff, #plasma, ngraham, #frameworks
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28531

To: broulik, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

[Dan Leinir Turthra Jensen]

leinir edited the test plan for this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28532

To: leinir, #knewstuff, #plasma, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.
leinir added reviewers: KNewStuff, Plasma, ngraham, Frameworks.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28532

To: leinir, #knewstuff, #plasma, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Prior to this, we did have error reporting, but only in the way of
  writing errors out on the command line (through qCCritical). While
  this is fine for debugging purposes, it is unfortunate when errors
  can be expected to occur in day to day use (as we are dealing with
  a wide range of things that can (and often do) go wrong), and giving
  proper feedback to the user as to why, for example, their new icons
  aren't showing up when they seem to have installed just fine would
  seem a reasonable thing to do.
  
  - Add a signal to Installation fired when there's a critical error
  - Forward the installer errors through KNSCore::Engine
  - Add the MessageBoxSheet component from kaccounts-integration
  - Add a component for displaying errors from the engine
  - Use the ErrorDisplayer component (only show on the current page)

REPOSITORY
  R304 KNewStuff

BRANCH
  more-installation-error-handling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28532

AFFECTED FILES
  src/core/engine.cpp
  src/core/installation.cpp
  src/core/installation.h
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/ErrorDisplayer.qml
  src/qtquick/qml/private/MessageBoxSheet.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages

[Kai Uwe Broulik]

broulik retitled this revision from "[KNotificationJobUiDelegate] Prepend 
"Failed" for error messages" to "[KNotificationJobUiDelegate] Append "Failed" 
for error messages".

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28531

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28498: [xdgoutput] Explicitly set version of server interface

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> apol wrote in display.h:296
> Passing an enum as const& is wrong although it doesn't make much of a 
> difference in practice.
> 
> `You can't introduce another createXdgOutputManager() because it's not 
> overloaded`. He's adding an overload, I don't understand.

> He's adding an overload, I don't understand.

Bad wording, my bad. We are allowed to overload only methods that are already 
overloaded.

From https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

> You cannot...
> 
> For existing functions of any type:
> 
> add an overload (BC, but not SC: makes  ambiguous), adding overloads to 
> already overloaded functions is ok (any use of  already needed a cast).

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27760: WIP | Added BatchMoveJob

[Emirald Mateli]

emateli added inline comments.

INLINE COMMENTS

> batchmovejobtest.cpp:89
> +KIO::Job *job = KIO::batchMove(items);
> +
> KIO::FileUndoManager::self()->recordJob(KIO::FileUndoManager::CommandType::BatchMove,
>  QList{}, QUrl(), job);
> +job->setUiDelegate(nullptr);

@dfaure How do I correctly register this job so I can undo it in one operation 
(In the undo call a few lines below)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27760

To: emateli, dfaure, ngraham
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28499: [LauncherJobs] Emit description

[Kai Uwe Broulik]

broulik added a comment.


  Given we don't add elippsis after any other KIO Job (e.g. "Copying") probably 
shouldn't do it here either?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28499

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28531: [KNotificationJobUiDelegate] Prepend "Failed" for error messages

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Makes the resulting error notification resemble one like a KJobTracker 
failure as if I had copied a file.

TEST PLAN
  - Failed to launch an app, got "Launching foo... (Failed)"

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28531

AFFECTED FILES
  src/knotificationjobuidelegate.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[Kai Uwe Broulik]

broulik added a comment.


  Not sure how I would test running a command with a space in it.. putting a 
shell script in running it through QFINDTESTDATA? Not sure how to make that 
sort of stuff work on Windows

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[Kai Uwe Broulik]

broulik updated this revision to Diff 79189.
broulik edited the test plan for this revision.
broulik added a comment.


  - Quote executable in commandline
  - Add unittest

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28515?vs=79136=79189

REVISION DETAIL
  https://phabricator.kde.org/D28515

AFFECTED FILES
  autotests/commandlauncherjobtest.cpp
  autotests/commandlauncherjobtest.h
  src/gui/commandlauncherjob.cpp
  src/gui/commandlauncherjob.h

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.14 - Build # 16 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.14/16/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 03 Apr 2020 07:27:24 +
 Build duration:
4 min 32 sec and counting
   BUILD ARTIFACTS
  acc/KF5Baloo-5.69.0.xmllogs/KF5Baloo/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 34 test(s), Skipped: 0 test(s), Total: 34 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)68%
(116/171)68%
(116/171)60%
(6257/10447)42%
(2419/5697)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)94%
(496/530)79%
(227/286)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(845/845)61%
(294/484)autotests.unit.file100%
(12/12)100%
(12/12)98%
(1076/1097)53%
(338/632)autotests.unit.lib100%
(6/6)100%
(6/6)99%
(425/431)60%
(99/164)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine92%
(35/38)92%
(35/38)77%
(1730/2247)54%
(694/1291)src.file69%
(27/39)69%
(27/39)53%
(1015/1921)42%
(466/1121)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/72)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/35)0%
(0/30)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/88)0%
(0/18)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/274)0%
(0/231)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/256)0%
(0/131)src.lib55%
(6/11)55%
(6/11)42%
(412/973)37%
(221/591)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
 

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/24/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 03 Apr 2020 07:27:23 +
 Build duration:
2 min 55 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 237 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/237/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 Apr 2020 07:27:23 +
 Build duration:
2 min 0 sec and counting
   BUILD ARTIFACTS
  acc/KF5Baloo-5.69.0.xmllogs/KF5Baloo/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 34 test(s), Skipped: 0 test(s), Total: 34 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)68%
(116/171)68%
(116/171)60%
(6261/10447)43%
(2422/5697)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)94%
(496/530)79%
(227/286)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(845/845)61%
(294/484)autotests.unit.file100%
(12/12)100%
(12/12)98%
(1076/1097)53%
(338/632)autotests.unit.lib100%
(6/6)100%
(6/6)99%
(425/431)60%
(99/164)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine92%
(35/38)92%
(35/38)77%
(1730/2247)54%
(694/1291)src.file69%
(27/39)69%
(27/39)53%
(1019/1921)42%
(469/1121)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/72)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/35)0%
(0/30)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/88)0%
(0/18)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/274)0%
(0/231)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/256)0%
(0/131)src.lib55%
(6/11)55%
(6/11)42%
(412/973)37%
(221/591)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
 

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 51 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/51/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 03 Apr 2020 07:27:23 +
 Build duration:
55 sec and counting

D28530: newServicePath(): Docs say add prefix but it's actually suffix

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  In newServicePath() when a service with the suggestedName already exists
  a suffix is added. Make the docs clearer on that point.

REPOSITORY
  R309 KService

BRANCH
  l-docs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28530

AFFECTED FILES
  src/services/kservice.h

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns