D28902: CopyJob: when stat'ing the dest, use StatBasic.

[Méven Car]

meven added a comment.


  Fix and test coming

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28902

To: dfaure, meven
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

[Méven Car]

meven added a comment.


  In D28902#671260 , @ngraham wrote:
  
  > @dfaure git bisect says this caused 
https://bugs.kde.org/show_bug.cgi?id=421213.
  >
  > After fixing, maybe we should get a test for that use case?
  
  
  I see the issue, because we don't resolve the symlink here, we don't figure 
out dest is a folder and hence copyjob acts as if moving file to dest file, 
instead of to dest dir.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28902

To: dfaure, meven
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D27844: Store and fetch complete view config in and from session config

[Dominik Haumann]

dhaumann added a comment.


  I suggest to revert, and send a notification with the change to 
kde-distro-packa...@kde.org to avoid that many users break their configuration.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

[Nathaniel Graham]

ngraham added a comment.


  In D29711#670503 , @ltoscano wrote:
  
  > If the scope of this change is just about Plasma applet, of course 
systemsettings is going to be around.
  
  
  Yes the scope of this change is purely for Plasma applets; look at the 
dependent patches.
  
  > But are you sure you want to kill kcmshell? KCMs are not for Plasma only. 
Opening them outside Plasma would still require a minimal shell.
  > 
  > Regarding this change, I guess you may have discussed it already, but 
wouldn't it be possible to find out whether systemsettings is available (and 
then kinfocenter) and use it, without adding a new function?
  
  We didn't kill kcmshell, it's explicitly still around.
  
  I can't add new behaviors to the existing function because of the reasons 
listed in the description section of this patch.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29483

To: ngraham, #frameworks, #vdg, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

[Gustavo Carneiro]

araujoluis added a reviewer: VDG.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  named_color_support

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham, #vdg
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

[Nathaniel Graham]

ngraham added a comment.


  @dfaure git bisect says this caused 
https://bugs.kde.org/show_bug.cgi?id=421213.
  
  After fixing, maybe we should get a test for that use case?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28902

To: dfaure, meven
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I have to say, I'm very impressed overall. There are a few things I'd like to 
see changed though:
  
  folder-documents should use a single page, not the copy icon F8320517: 
Screenshot_20200514_153157.png  I suppose 
they should all have the corner at the top right, but that can be done another 
time.
  
  folder-network is using a different style F8320527: 
Screenshot_20200514_153705.png 
  
  folder-scripts is using a different style F8320536: 
Screenshot_20200514_154402.png 
  
  panel elements in user-desktop should be more like the 32px version F8320540: 
Screenshot_20200514_154711.png  The 64px 
version should be changed too, but that can be done another time.
  
  Other observations (not required, just documenting them so they aren't 
forgotten)
  
=
  
  folder-games inner symbol looks a bit small, but that's going to be extra 
work, so I won't fault you if you'd rather do that later. The 16px version that 
you reused for the 48px symbol is a bit too small at 16px anyway, so that can 
be done another time.
  F8320524: Screenshot_20200514_153422.png 

  
  Interestingly, document-print uses a different style for the smallest printer 
icon size. I think I prefer the document-print version, but that change can be 
done another time.
  F8320530: Screenshot_20200514_153936.png 
 F8320532: Screenshot_20200514_154148.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

[Noah Davis]

ndavis added a comment.


  In D29740#671221 , @filipf wrote:
  
  > The more I think about this the more it feels like a workaround. Presuming 
QQC2's behavior of leaving a pressed button focused after press is correct, 
perhaps we are at fault for providing the same svg for `focus-background` and 
`pressed`.
  
  
  That was one of the issues I was trying to fix while working on a new style 
for buttons in the QStyle.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-remain-pressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma, ngraham
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

[Filip Fila]

filipf added a comment.


  The more I think about this the more it feels like a workaround. Presuming 
QQC2's behavior of leaving a pressed button focused after press is correct, 
perhaps we are at fault for providing the same svg for `focus-background` and 
`pressed`.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-remain-pressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks fantastic to me. All good now, @ndavis?

REPOSITORY
  R266 Breeze Icons

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/105/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 14 May 2020 18:26:34 +
 Build duration:
6 min 57 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report69%
(25/36)67%
(278/414)67%
(278/414)55%
(34439/62885)39%
(17488/44546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(57/59)97%
(57/59)86%
(9095/10583)42%
(4279/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8457/14375)50%
(4402/8718)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1791/4287)36%
(1311/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 603 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/603/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 May 2020 18:26:34 +
 Build duration:
6 min 9 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report69%
(25/36)67%
(278/414)67%
(278/414)55%
(34437/62884)39%
(17488/44550)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(57/59)97%
(57/59)86%
(9095/10584)42%
(4283/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8447/14374)50%
(4397/8718)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 113 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/113/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 14 May 2020 18:26:34 +
 Build duration:
4 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6452a34cf01d: Fix service file specifying Run in 
terminal giving an error code 100 (authored by marten).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29738?vs=82823=82874

REVISION DETAIL
  https://phabricator.kde.org/D29738

AFFECTED FILES
  src/core/desktopexecparser.cpp
  src/gui/kprocessrunner.cpp

To: marten, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Everything should be good now, I think

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin updated this revision to Diff 82873.
manueljlin marked 2 inline comments as done.
manueljlin added a comment.


  Made 64x64 scalable again and tweaked the comments.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29739?vs=82866=82873

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/places/48/certificate-server.svg
  icons-dark/places/48/desktop.svg
  icons-dark/places/48/favorites.svg
  icons-dark/places/48/folder-activities.svg
  icons-dark/places/48/folder-black.svg
  icons-dark/places/48/folder-blue.svg
  icons-dark/places/48/folder-bookmark.svg
  icons-dark/places/48/folder-brown.svg
  icons-dark/places/48/folder-cloud.svg
  icons-dark/places/48/folder-cyan.svg
  icons-dark/places/48/folder-decrypted.svg
  icons-dark/places/48/folder-development.svg
  icons-dark/places/48/folder-documents.svg
  icons-dark/places/48/folder-download.svg
  icons-dark/places/48/folder-downloads.svg
  icons-dark/places/48/folder-dropbox.svg
  icons-dark/places/48/folder-encrypted.svg
  icons-dark/places/48/folder-favorites.svg
  icons-dark/places/48/folder-games.svg
  icons-dark/places/48/folder-gdrive.svg
  icons-dark/places/48/folder-green.svg
  icons-dark/places/48/folder-grey.svg
  icons-dark/places/48/folder-html.svg
  icons-dark/places/48/folder-image-people.svg
  icons-dark/places/48/folder-image.svg
  icons-dark/places/48/folder-images.svg
  icons-dark/places/48/folder-important.svg
  icons-dark/places/48/folder-locked.svg
  icons-dark/places/48/folder-magenta.svg
  icons-dark/places/48/folder-mail.svg
  icons-dark/places/48/folder-music.svg
  icons-dark/places/48/folder-network.svg
  icons-dark/places/48/folder-onedrive.svg
  icons-dark/places/48/folder-open.svg
  icons-dark/places/48/folder-orange.svg
  icons-dark/places/48/folder-owncloud.svg
  icons-dark/places/48/folder-picture.svg
  icons-dark/places/48/folder-pictures.svg
  icons-dark/places/48/folder-print.svg
  icons-dark/places/48/folder-public.svg
  icons-dark/places/48/folder-publicshare.svg
  icons-dark/places/48/folder-recent.svg
  icons-dark/places/48/folder-red.svg
  icons-dark/places/48/folder-remote.svg
  icons-dark/places/48/folder-root.svg
  icons-dark/places/48/folder-script.svg
  icons-dark/places/48/folder-sound.svg
  icons-dark/places/48/folder-tar.svg
  icons-dark/places/48/folder-temp.svg
  icons-dark/places/48/folder-templates.svg
  icons-dark/places/48/folder-text.svg
  icons-dark/places/48/folder-txt.svg
  icons-dark/places/48/folder-unlocked.svg
  icons-dark/places/48/folder-video.svg
  icons-dark/places/48/folder-videos.svg
  icons-dark/places/48/folder-violet.svg
  icons-dark/places/48/folder-yellow.svg
  icons-dark/places/48/folder.svg
  icons-dark/places/48/folder_html.svg
  icons-dark/places/48/library-music.svg
  icons-dark/places/48/network-server.svg
  icons-dark/places/48/network-workgroup.svg
  icons-dark/places/48/stock_folder.svg
  icons-dark/places/48/user-desktop.svg
  icons-dark/places/48/user-home.svg
  icons/index.theme
  icons/places/48/certificate-server.svg
  icons/places/48/desktop.svg
  icons/places/48/favorites.svg
  icons/places/48/folder-activities.svg
  icons/places/48/folder-black.svg
  icons/places/48/folder-blue.svg
  icons/places/48/folder-bookmark.svg
  icons/places/48/folder-brown.svg
  icons/places/48/folder-cloud.svg
  icons/places/48/folder-cyan.svg
  icons/places/48/folder-decrypted.svg
  icons/places/48/folder-development.svg
  icons/places/48/folder-documents.svg
  icons/places/48/folder-download.svg
  icons/places/48/folder-downloads.svg
  icons/places/48/folder-dropbox.svg
  icons/places/48/folder-encrypted.svg
  icons/places/48/folder-favorites.svg
  icons/places/48/folder-games.svg
  icons/places/48/folder-gdrive.svg
  icons/places/48/folder-green.svg
  icons/places/48/folder-grey.svg
  icons/places/48/folder-html.svg
  icons/places/48/folder-image-people.svg
  icons/places/48/folder-image.svg
  icons/places/48/folder-images.svg
  icons/places/48/folder-important.svg
  icons/places/48/folder-locked.svg
  icons/places/48/folder-magenta.svg
  icons/places/48/folder-mail.svg
  icons/places/48/folder-music.svg
  icons/places/48/folder-network.svg
  icons/places/48/folder-onedrive.svg
  icons/places/48/folder-open.svg
  icons/places/48/folder-orange.svg
  icons/places/48/folder-owncloud.svg
  icons/places/48/folder-picture.svg
  icons/places/48/folder-pictures.svg
  icons/places/48/folder-print.svg
  icons/places/48/folder-public.svg
  icons/places/48/folder-publicshare.svg
  icons/places/48/folder-recent.svg
  icons/places/48/folder-red.svg
  icons/places/48/folder-remote.svg
  icons/places/48/folder-root.svg
  icons/places/48/folder-script.svg
  icons/places/48/folder-sound.svg
  icons/places/48/folder-tar.svg
  icons/places/48/folder-temp.svg
  icons/places/48/folder-templates.svg
  icons/places/48/folder-text.svg
  

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D29747#671169 , @svuorela wrote:
  
  > I think we should wait a bit with formally deprecating. I like add the new, 
wait a bit, then deprecate.
  
  
  So you propose to also remove the `@deprecated` from the API dox?
  
  And wait, for what to happen?

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D29747

To: kossebau, #frameworks, svuorela, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

[Sune Vuorela]

svuorela added a comment.


  I think we should wait a bit with formally deprecating. I like add the new, 
wait a bit, then deprecate.
  
  Also, while I might be a unconventional developer, but given this is a tier 1 
library, I'm often hand patching the required ECM version to a much lower 
version to test stuff when I know it will work. So I'd say. Yes. nice patch, 
but let's wait a month or two with submitting it.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D29747

To: kossebau, #frameworks, svuorela, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> index.theme:477
>  
>  #32x32 - Scalable - For folder icons >!!!ONLY!!!< - Scalable to the 
> following sizes: 64x64 (default), 32x32, 128x128, 256x256 - 
> DO_NOT_USE_ANYWHERE_ELSE - Color
>  [places/32]

This and the other comments should probably be changed, but I don't actually 
understand the original purpose anyway.

> index.theme:493
>  Context=Places
> -Type=Scalable
> -MinSize=32
> -MaxSize=256
> +Type=Fixed
>  

This should be put back the way it was since phabricator mislead you.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis added a comment.


  In D29739#671163 , @manueljlin 
wrote:
  
  > should line 495 "## Status" actually be removed?
  
  
  No. Phabricator doesn't keep the original context for those comments if you 
change the code they were referring to. I think GitLab doesn't have that 
problem.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  should line 495 "## Status" actually be removed?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Nice! In addition to the bugfix, calling resultingArguments() only once is a 
definite improvement, given everything that happens in there. I didn't realize 
we were calling it twice.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29738

To: marten, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29034: Add systemd user service file for kded

[Kai Uwe Broulik]

broulik updated this revision to Diff 82868.
broulik added a comment.


  - fix exec
  - add slice

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29034?vs=80722=82868

REVISION DETAIL
  https://phabricator.kde.org/D29034

AFFECTED FILES
  src/CMakeLists.txt
  src/plasma-kded.service.in

To: broulik, #plasma, #frameworks
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin updated this revision to Diff 82866.
manueljlin added a comment.


  Oops. Actually set 64x64 to fixed and remove MinSize and MaxSize

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29739?vs=82865=82866

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/places/48/certificate-server.svg
  icons-dark/places/48/desktop.svg
  icons-dark/places/48/favorites.svg
  icons-dark/places/48/folder-activities.svg
  icons-dark/places/48/folder-black.svg
  icons-dark/places/48/folder-blue.svg
  icons-dark/places/48/folder-bookmark.svg
  icons-dark/places/48/folder-brown.svg
  icons-dark/places/48/folder-cloud.svg
  icons-dark/places/48/folder-cyan.svg
  icons-dark/places/48/folder-decrypted.svg
  icons-dark/places/48/folder-development.svg
  icons-dark/places/48/folder-documents.svg
  icons-dark/places/48/folder-download.svg
  icons-dark/places/48/folder-downloads.svg
  icons-dark/places/48/folder-dropbox.svg
  icons-dark/places/48/folder-encrypted.svg
  icons-dark/places/48/folder-favorites.svg
  icons-dark/places/48/folder-games.svg
  icons-dark/places/48/folder-gdrive.svg
  icons-dark/places/48/folder-green.svg
  icons-dark/places/48/folder-grey.svg
  icons-dark/places/48/folder-html.svg
  icons-dark/places/48/folder-image-people.svg
  icons-dark/places/48/folder-image.svg
  icons-dark/places/48/folder-images.svg
  icons-dark/places/48/folder-important.svg
  icons-dark/places/48/folder-locked.svg
  icons-dark/places/48/folder-magenta.svg
  icons-dark/places/48/folder-mail.svg
  icons-dark/places/48/folder-music.svg
  icons-dark/places/48/folder-network.svg
  icons-dark/places/48/folder-onedrive.svg
  icons-dark/places/48/folder-open.svg
  icons-dark/places/48/folder-orange.svg
  icons-dark/places/48/folder-owncloud.svg
  icons-dark/places/48/folder-picture.svg
  icons-dark/places/48/folder-pictures.svg
  icons-dark/places/48/folder-print.svg
  icons-dark/places/48/folder-public.svg
  icons-dark/places/48/folder-publicshare.svg
  icons-dark/places/48/folder-recent.svg
  icons-dark/places/48/folder-red.svg
  icons-dark/places/48/folder-remote.svg
  icons-dark/places/48/folder-root.svg
  icons-dark/places/48/folder-script.svg
  icons-dark/places/48/folder-sound.svg
  icons-dark/places/48/folder-tar.svg
  icons-dark/places/48/folder-temp.svg
  icons-dark/places/48/folder-templates.svg
  icons-dark/places/48/folder-text.svg
  icons-dark/places/48/folder-txt.svg
  icons-dark/places/48/folder-unlocked.svg
  icons-dark/places/48/folder-video.svg
  icons-dark/places/48/folder-videos.svg
  icons-dark/places/48/folder-violet.svg
  icons-dark/places/48/folder-yellow.svg
  icons-dark/places/48/folder.svg
  icons-dark/places/48/folder_html.svg
  icons-dark/places/48/library-music.svg
  icons-dark/places/48/network-server.svg
  icons-dark/places/48/network-workgroup.svg
  icons-dark/places/48/stock_folder.svg
  icons-dark/places/48/user-desktop.svg
  icons-dark/places/48/user-home.svg
  icons/index.theme
  icons/places/48/certificate-server.svg
  icons/places/48/desktop.svg
  icons/places/48/favorites.svg
  icons/places/48/folder-activities.svg
  icons/places/48/folder-black.svg
  icons/places/48/folder-blue.svg
  icons/places/48/folder-bookmark.svg
  icons/places/48/folder-brown.svg
  icons/places/48/folder-cloud.svg
  icons/places/48/folder-cyan.svg
  icons/places/48/folder-decrypted.svg
  icons/places/48/folder-development.svg
  icons/places/48/folder-documents.svg
  icons/places/48/folder-download.svg
  icons/places/48/folder-downloads.svg
  icons/places/48/folder-dropbox.svg
  icons/places/48/folder-encrypted.svg
  icons/places/48/folder-favorites.svg
  icons/places/48/folder-games.svg
  icons/places/48/folder-gdrive.svg
  icons/places/48/folder-green.svg
  icons/places/48/folder-grey.svg
  icons/places/48/folder-html.svg
  icons/places/48/folder-image-people.svg
  icons/places/48/folder-image.svg
  icons/places/48/folder-images.svg
  icons/places/48/folder-important.svg
  icons/places/48/folder-locked.svg
  icons/places/48/folder-magenta.svg
  icons/places/48/folder-mail.svg
  icons/places/48/folder-music.svg
  icons/places/48/folder-network.svg
  icons/places/48/folder-onedrive.svg
  icons/places/48/folder-open.svg
  icons/places/48/folder-orange.svg
  icons/places/48/folder-owncloud.svg
  icons/places/48/folder-picture.svg
  icons/places/48/folder-pictures.svg
  icons/places/48/folder-print.svg
  icons/places/48/folder-public.svg
  icons/places/48/folder-publicshare.svg
  icons/places/48/folder-recent.svg
  icons/places/48/folder-red.svg
  icons/places/48/folder-remote.svg
  icons/places/48/folder-root.svg
  icons/places/48/folder-script.svg
  icons/places/48/folder-sound.svg
  icons/places/48/folder-tar.svg
  icons/places/48/folder-temp.svg
  icons/places/48/folder-templates.svg
  icons/places/48/folder-text.svg
  icons/places/48/folder-txt.svg
  

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin updated this revision to Diff 82865.
manueljlin marked 7 inline comments as done.
manueljlin added a comment.


  Fixed the issues from the comments

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29739?vs=82861=82865

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/places/48/certificate-server.svg
  icons-dark/places/48/desktop.svg
  icons-dark/places/48/favorites.svg
  icons-dark/places/48/folder-activities.svg
  icons-dark/places/48/folder-black.svg
  icons-dark/places/48/folder-blue.svg
  icons-dark/places/48/folder-bookmark.svg
  icons-dark/places/48/folder-brown.svg
  icons-dark/places/48/folder-cloud.svg
  icons-dark/places/48/folder-cyan.svg
  icons-dark/places/48/folder-decrypted.svg
  icons-dark/places/48/folder-development.svg
  icons-dark/places/48/folder-documents.svg
  icons-dark/places/48/folder-download.svg
  icons-dark/places/48/folder-downloads.svg
  icons-dark/places/48/folder-dropbox.svg
  icons-dark/places/48/folder-encrypted.svg
  icons-dark/places/48/folder-favorites.svg
  icons-dark/places/48/folder-games.svg
  icons-dark/places/48/folder-gdrive.svg
  icons-dark/places/48/folder-green.svg
  icons-dark/places/48/folder-grey.svg
  icons-dark/places/48/folder-html.svg
  icons-dark/places/48/folder-image-people.svg
  icons-dark/places/48/folder-image.svg
  icons-dark/places/48/folder-images.svg
  icons-dark/places/48/folder-important.svg
  icons-dark/places/48/folder-locked.svg
  icons-dark/places/48/folder-magenta.svg
  icons-dark/places/48/folder-mail.svg
  icons-dark/places/48/folder-music.svg
  icons-dark/places/48/folder-network.svg
  icons-dark/places/48/folder-onedrive.svg
  icons-dark/places/48/folder-open.svg
  icons-dark/places/48/folder-orange.svg
  icons-dark/places/48/folder-owncloud.svg
  icons-dark/places/48/folder-picture.svg
  icons-dark/places/48/folder-pictures.svg
  icons-dark/places/48/folder-print.svg
  icons-dark/places/48/folder-public.svg
  icons-dark/places/48/folder-publicshare.svg
  icons-dark/places/48/folder-recent.svg
  icons-dark/places/48/folder-red.svg
  icons-dark/places/48/folder-remote.svg
  icons-dark/places/48/folder-root.svg
  icons-dark/places/48/folder-script.svg
  icons-dark/places/48/folder-sound.svg
  icons-dark/places/48/folder-tar.svg
  icons-dark/places/48/folder-temp.svg
  icons-dark/places/48/folder-templates.svg
  icons-dark/places/48/folder-text.svg
  icons-dark/places/48/folder-txt.svg
  icons-dark/places/48/folder-unlocked.svg
  icons-dark/places/48/folder-video.svg
  icons-dark/places/48/folder-videos.svg
  icons-dark/places/48/folder-violet.svg
  icons-dark/places/48/folder-yellow.svg
  icons-dark/places/48/folder.svg
  icons-dark/places/48/folder_html.svg
  icons-dark/places/48/library-music.svg
  icons-dark/places/48/network-server.svg
  icons-dark/places/48/network-workgroup.svg
  icons-dark/places/48/stock_folder.svg
  icons-dark/places/48/user-desktop.svg
  icons-dark/places/48/user-home.svg
  icons/index.theme
  icons/places/48/certificate-server.svg
  icons/places/48/desktop.svg
  icons/places/48/favorites.svg
  icons/places/48/folder-activities.svg
  icons/places/48/folder-black.svg
  icons/places/48/folder-blue.svg
  icons/places/48/folder-bookmark.svg
  icons/places/48/folder-brown.svg
  icons/places/48/folder-cloud.svg
  icons/places/48/folder-cyan.svg
  icons/places/48/folder-decrypted.svg
  icons/places/48/folder-development.svg
  icons/places/48/folder-documents.svg
  icons/places/48/folder-download.svg
  icons/places/48/folder-downloads.svg
  icons/places/48/folder-dropbox.svg
  icons/places/48/folder-encrypted.svg
  icons/places/48/folder-favorites.svg
  icons/places/48/folder-games.svg
  icons/places/48/folder-gdrive.svg
  icons/places/48/folder-green.svg
  icons/places/48/folder-grey.svg
  icons/places/48/folder-html.svg
  icons/places/48/folder-image-people.svg
  icons/places/48/folder-image.svg
  icons/places/48/folder-images.svg
  icons/places/48/folder-important.svg
  icons/places/48/folder-locked.svg
  icons/places/48/folder-magenta.svg
  icons/places/48/folder-mail.svg
  icons/places/48/folder-music.svg
  icons/places/48/folder-network.svg
  icons/places/48/folder-onedrive.svg
  icons/places/48/folder-open.svg
  icons/places/48/folder-orange.svg
  icons/places/48/folder-owncloud.svg
  icons/places/48/folder-picture.svg
  icons/places/48/folder-pictures.svg
  icons/places/48/folder-print.svg
  icons/places/48/folder-public.svg
  icons/places/48/folder-publicshare.svg
  icons/places/48/folder-recent.svg
  icons/places/48/folder-red.svg
  icons/places/48/folder-remote.svg
  icons/places/48/folder-root.svg
  icons/places/48/folder-script.svg
  icons/places/48/folder-sound.svg
  icons/places/48/folder-tar.svg
  icons/places/48/folder-temp.svg
  icons/places/48/folder-templates.svg
  icons/places/48/folder-text.svg
  icons/places/48/folder-txt.svg
  

D29739: Add 48px places icons

[Noah Davis]

ndavis added a comment.


  I just noticed, the new auto-generated 24px places icons aren't being used 
because the places/24 folder isn't in the index.theme files, but that's outside 
the scope of this patch.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis added a comment.


  comments apply to both files

INLINE COMMENTS

> index.theme:105
>  
>  
> Directories=actions/12,actions/16,actions/22,actions/24,actions/32,actions/64,animations/16,animations/22,apps/16,apps/22,apps/32,apps/48,preferences/32,applets/22,applets/48,applets/64,applets/128,applets/256,categories/32,devices/16,devices/22,devices/64,emblems/8,emblems/16,emblems/22,emotes/22,mimetypes/16,mimetypes/22,mimetypes/32,mimetypes/64,places/16,places/22,places/32,places/64,status/16,status/22,status/24,status/32,status/64,actions/symbolic,devices/symbolic,emblems/symbolic,places/symbolic,status/symbolic
>  
> ScaledDirectories=actions/16@2x,actions/22@2x,actions/24@2x,actions/32@2x,animations/16@2x,apps/16@2x,apps/22@2x,devices/16@2x,devices/22@2x,emblems/16@2x,emblems/22@2x,emotes/22@2x,mimetypes/16@2x,mimetypes/22@2x,places/16@2x,places/22@2x,status/16@2x,status/22@2x

You also need to add the new folder here

> index.theme:481
>  Context=Places
>  Type=Scalable
>  MinSize=24

This should be changed to Fixed

> index.theme:482
>  Type=Scalable
>  MinSize=24
>  MaxSize=48

Delete

> index.theme:483
>  MinSize=24
>  MaxSize=48
>  

Delete

> index.theme:489
> +Context=Places
> +Type=Scalable
> +MinSize=32

Scalable -> Fixed

> index.theme:490
> +Type=Scalable
> +MinSize=32
> +MaxSize=256

Delete

> index.theme:491
> +MinSize=32
> +MaxSize=256
> +

Delete

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin updated this revision to Diff 82861.
manueljlin added a comment.


  Include places/48

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29739?vs=82824=82861

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/places/48/certificate-server.svg
  icons-dark/places/48/desktop.svg
  icons-dark/places/48/favorites.svg
  icons-dark/places/48/folder-activities.svg
  icons-dark/places/48/folder-black.svg
  icons-dark/places/48/folder-blue.svg
  icons-dark/places/48/folder-bookmark.svg
  icons-dark/places/48/folder-brown.svg
  icons-dark/places/48/folder-cloud.svg
  icons-dark/places/48/folder-cyan.svg
  icons-dark/places/48/folder-decrypted.svg
  icons-dark/places/48/folder-development.svg
  icons-dark/places/48/folder-documents.svg
  icons-dark/places/48/folder-download.svg
  icons-dark/places/48/folder-downloads.svg
  icons-dark/places/48/folder-dropbox.svg
  icons-dark/places/48/folder-encrypted.svg
  icons-dark/places/48/folder-favorites.svg
  icons-dark/places/48/folder-games.svg
  icons-dark/places/48/folder-gdrive.svg
  icons-dark/places/48/folder-green.svg
  icons-dark/places/48/folder-grey.svg
  icons-dark/places/48/folder-html.svg
  icons-dark/places/48/folder-image-people.svg
  icons-dark/places/48/folder-image.svg
  icons-dark/places/48/folder-images.svg
  icons-dark/places/48/folder-important.svg
  icons-dark/places/48/folder-locked.svg
  icons-dark/places/48/folder-magenta.svg
  icons-dark/places/48/folder-mail.svg
  icons-dark/places/48/folder-music.svg
  icons-dark/places/48/folder-network.svg
  icons-dark/places/48/folder-onedrive.svg
  icons-dark/places/48/folder-open.svg
  icons-dark/places/48/folder-orange.svg
  icons-dark/places/48/folder-owncloud.svg
  icons-dark/places/48/folder-picture.svg
  icons-dark/places/48/folder-pictures.svg
  icons-dark/places/48/folder-print.svg
  icons-dark/places/48/folder-public.svg
  icons-dark/places/48/folder-publicshare.svg
  icons-dark/places/48/folder-recent.svg
  icons-dark/places/48/folder-red.svg
  icons-dark/places/48/folder-remote.svg
  icons-dark/places/48/folder-root.svg
  icons-dark/places/48/folder-script.svg
  icons-dark/places/48/folder-sound.svg
  icons-dark/places/48/folder-tar.svg
  icons-dark/places/48/folder-temp.svg
  icons-dark/places/48/folder-templates.svg
  icons-dark/places/48/folder-text.svg
  icons-dark/places/48/folder-txt.svg
  icons-dark/places/48/folder-unlocked.svg
  icons-dark/places/48/folder-video.svg
  icons-dark/places/48/folder-videos.svg
  icons-dark/places/48/folder-violet.svg
  icons-dark/places/48/folder-yellow.svg
  icons-dark/places/48/folder.svg
  icons-dark/places/48/folder_html.svg
  icons-dark/places/48/library-music.svg
  icons-dark/places/48/network-server.svg
  icons-dark/places/48/network-workgroup.svg
  icons-dark/places/48/stock_folder.svg
  icons-dark/places/48/user-desktop.svg
  icons-dark/places/48/user-home.svg
  icons/index.theme
  icons/places/48/certificate-server.svg
  icons/places/48/desktop.svg
  icons/places/48/favorites.svg
  icons/places/48/folder-activities.svg
  icons/places/48/folder-black.svg
  icons/places/48/folder-blue.svg
  icons/places/48/folder-bookmark.svg
  icons/places/48/folder-brown.svg
  icons/places/48/folder-cloud.svg
  icons/places/48/folder-cyan.svg
  icons/places/48/folder-decrypted.svg
  icons/places/48/folder-development.svg
  icons/places/48/folder-documents.svg
  icons/places/48/folder-download.svg
  icons/places/48/folder-downloads.svg
  icons/places/48/folder-dropbox.svg
  icons/places/48/folder-encrypted.svg
  icons/places/48/folder-favorites.svg
  icons/places/48/folder-games.svg
  icons/places/48/folder-gdrive.svg
  icons/places/48/folder-green.svg
  icons/places/48/folder-grey.svg
  icons/places/48/folder-html.svg
  icons/places/48/folder-image-people.svg
  icons/places/48/folder-image.svg
  icons/places/48/folder-images.svg
  icons/places/48/folder-important.svg
  icons/places/48/folder-locked.svg
  icons/places/48/folder-magenta.svg
  icons/places/48/folder-mail.svg
  icons/places/48/folder-music.svg
  icons/places/48/folder-network.svg
  icons/places/48/folder-onedrive.svg
  icons/places/48/folder-open.svg
  icons/places/48/folder-orange.svg
  icons/places/48/folder-owncloud.svg
  icons/places/48/folder-picture.svg
  icons/places/48/folder-pictures.svg
  icons/places/48/folder-print.svg
  icons/places/48/folder-public.svg
  icons/places/48/folder-publicshare.svg
  icons/places/48/folder-recent.svg
  icons/places/48/folder-red.svg
  icons/places/48/folder-remote.svg
  icons/places/48/folder-root.svg
  icons/places/48/folder-script.svg
  icons/places/48/folder-sound.svg
  icons/places/48/folder-tar.svg
  icons/places/48/folder-temp.svg
  icons/places/48/folder-templates.svg
  icons/places/48/folder-text.svg
  icons/places/48/folder-txt.svg
  icons/places/48/folder-unlocked.svg
  icons/places/48/folder-video.svg
 

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

[Victor Dodon]

printesoi added a comment.


  @zzag yes, but as per the 
https://doc.qt.io/qt-5/qscreen.html#availableGeometry-prop, it does not work on 
setups with multiple displays :)

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D29569

To: printesoi, davidedmundson, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29738

To: marten, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Nathaniel Graham]

ngraham added a comment.


  Nice work!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-remain-pressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis added a comment.


  You'll also need to update the index.theme files to include places/48

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29745: look for kded as runtime dep

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  kded

REVISION DETAIL
  https://phabricator.kde.org/D29745

To: sitter, dfaure, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29743: sftp: map sftp_open error to kio error

[Alexander Saoutkin]

feverfew accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  release/20.04

REVISION DETAIL
  https://phabricator.kde.org/D29743

To: sitter, feverfew
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D27844: Store and fetch complete view config in and from session config

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Seems this change has some sideeffects I did not experience when I played 
with this, but which are now uncovering as it hits people usinjg KF 5.70 :
  config seems to write any settings, also the ones inherited from global 
defaults, as view-specific settings, and when reading them in again on session 
restart, they all become view-specific overrides, thus no longer influencable 
by global settings. Is that due to some other change elsewhere, or did I just 
completely miss this?
  
  Possibly though this was mentioned before though:
  
  In D27844#624950 , @dhaumann wrote:
  
  > I guess we can give this a try. As I understand, though, with this patch 
you will never be able to use e.g. a global zoom once you change the zoom of a 
view. This was different before this patch.
  
  
  If so, I did not get the message, as I was focussed on the property itself, 
"zoom", which is not covered by the settings handled here.
  
  So, what to do? I would argue that revert would be the best option for now, 
as the sideeffects are more grave than what this patch tried to solve.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29745: look for kded as runtime dep

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  kded

REVISION DETAIL
  https://phabricator.kde.org/D29745

To: sitter, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 72 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/72/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 14 May 2020 13:27:18 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_keynavigation.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_listskeynavigation.qml

Re: Request for plasma framework patch release

[David Faure]

On jeudi 14 mai 2020 15:24:57 CEST David Faure wrote:
> On jeudi 14 mai 2020 13:56:50 CEST David Edmundson wrote:
> > We seem to have a common crasher newly introduced in plasma-framework. A
> > dozen reports in a few days.
> > 
> > Can I ask for a plasma-framework 5.70.1. with
> > c215c54eced5bd0b195c208dd72bb580e65f8fe4 cherry-picked.
> > 
> > Sorry.
> 
> Here you go.
> 
> plasma-framework v5.70.1
> bfea43379bc364bc1bb0719d9a1a73a57284214d
> e28884da2e3389513d96794f71fdfa22a8b4ba62396b7d061b4f18d9b5549d19 
> sources/plasma-framework-5.70.1.tar.xz

+ mention added to https://kde.org/info/kde-frameworks-5.70.0.php

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> abstractbarcode.h:69
>   */
> +PRISON_DEPRECATED_VERSION_BELATED(5, 71, 5, 69, "Use preferredSize() or 
> trueMinimumSize()")
>  QSizeF minimumSize() const;

D29573  bringing _BELATED only landed a few 
days ago, but can already serve here for another case :)

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D29747

To: kossebau, #frameworks, svuorela, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, svuorela, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R280 Prison

BRANCH
  fullydeprecateminimumsize

REVISION DETAIL
  https://phabricator.kde.org/D29747

AFFECTED FILES
  autotests/aztecbarcodetest.cpp
  autotests/code128barcodetest.cpp
  src/lib/CMakeLists.txt
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  tests/barcodeexamplewidget.cpp

To: kossebau, #frameworks, svuorela, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Request for plasma framework patch release

[David Faure]

On jeudi 14 mai 2020 13:56:50 CEST David Edmundson wrote:
> We seem to have a common crasher newly introduced in plasma-framework. A
> dozen reports in a few days.
> 
> Can I ask for a plasma-framework 5.70.1. with
> c215c54eced5bd0b195c208dd72bb580e65f8fe4 cherry-picked.
>
> Sorry.

Here you go.

plasma-framework v5.70.1
bfea43379bc364bc1bb0719d9a1a73a57284214d
e28884da2e3389513d96794f71fdfa22a8b4ba62396b7d061b4f18d9b5549d19  
sources/plasma-framework-5.70.1.tar.xz

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D29745: look for kded as runtime dep

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  kded is called over dbus to talk to the proxyscout, and also to track
  uidelegate windows it seems.
  this codifies this relationship on a cmake level allowing distributions
  and user to actually be aware.

TEST PLAN
  reported as RUNTIME package in cmake summary

REPOSITORY
  R241 KIO

BRANCH
  kded

REVISION DETAIL
  https://phabricator.kde.org/D29745

AFFECTED FILES
  CMakeLists.txt

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27989: Add a new set of barcode size functions

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D27989#670659 , @vkrause wrote:
  
  > There's two remaining users in everything covered by lxr, the Plasma 
clipboard (patch in review: https://phabricator.kde.org/D29478) and KDE PIM 
(which now depends on a sufficiently new KF5 version to actually do the 
migration). Both ways can be argued of course, I optimized for "helps me" (the 
warnings for things I can't change yet don't), and "migration is my problem" 
rather than "migration is somebody else's problem" (which is my understanding 
of how we are supposed to be doing KF deprecations to ease the 6 transition).
  
  
  For projects who cannot/do not want yet to adapt to deprecated API (e.g. 
because they do not fancy #if version #else #endif), they can make use of the 
built-in features with the deprecation system to deactivate warnings for any 
API which was set as deprecated initially only after a certain version:
  
  - QT_DEPRECATED_WARNINGS_SINCE (as in, show warnings for API deprecated at 
least since or already in older versions)
  - KF_DEPRECATED_WARNINGS_SINCE (same as above, KF_ being the group default, 
with KFOO_ allowing to fine-tune per module)
  
  Both are by default set to the number of the current version (so all warnings 
are shown), but if using QT_DISABLE_DEPRECATED_BEFORE or 
KF_DISABLE_DEPRECATED_BEFORE_AND_AT (& KFOO_DISABLE_DEPRECATED_BEFORE_AND_AT) 
those are defaulting instead to the version given in those macro, so 
automatically disabling any warnings for API deprecated in newer versions. One 
has to actively overwrite that to see warnings again (like e..g done for KF 
modules gloibally in 
https://phabricator.kde.org/source/extra-cmake-modules/browse/master/kde-modules/KDEFrameworkCompilerSettings.cmake$68
  
add_definitions(
-DQT_DEPRECATED_WARNINGS_SINCE=0x06
-DKF_DEPRECATED_WARNINGS_SINCE=0x06
)
  
  So the idea here is to allow to disable warnings for API deprecations one 
does not want to care about (yet). So unwanted noise should be design not be a 
reason here to delay adding the compiler warning macro and the compiler 
visibility wrapper. Note: Qt is lacking a bit here and there, some deprecations 
are not properly tagged to support that. KF instead shines there :)
  
  For being silent about the warnings while still doing patches all yourself: 
while of course it is nice/recommended to help all KDE projects to adapt to 
some new API by the persons who introduced it, it also is good to get some real 
world feedback by having people with other mindsets who try to make use of the 
new API, and who thus might discover issues with the new API or its 
documentation. And some people are just fine to help out for their own projects 
to jump to latest best API as well, so they would be happy to learn about as 
early as possible by having the compiler points things out.
  
  See e.g. how KRun is deprecated currently. Are people upset about the 
approach? I do not think so. Because they see David going around and helping 
with the ports. And they see how the new async API is better.
  
  So, no harm here in having the compiler from day one inform interested 
developers about the deprecation. IMHO, but also covered by what is done 
elsewhere :) Actually, it is part of the design with the control about compiler 
warnings by version.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27989

To: vkrause, svuorela
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29743: sftp: map sftp_open error to kio error

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: feverfew.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  sftp gives out more relevant errors such as SSH_FX_PERMISSION_DENIED,
  let's forward them as KIO errors instead of using the general cannot open
  error.

TEST PLAN
  hoping for the best! bad permissions on the remote now actually raise 
suitable kio errors, functionally that seems to make little difference 
unfortunately

REPOSITORY
  R320 KIO Extras

BRANCH
  release/20.04

REVISION DETAIL
  https://phabricator.kde.org/D29743

AFFECTED FILES
  sftp/kio_sftp.cpp

To: sitter, feverfew
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29634: sftp: break large writes into multiple requests

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:1df6174834bb: sftp: break large writes into multiple 
requests (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29634?vs=82723=82834

REVISION DETAIL
  https://phabricator.kde.org/D29634

AFFECTED FILES
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h

To: sitter, ngraham, meven, feverfew
Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

Request for plasma framework patch release

[David Edmundson]

We seem to have a common crasher newly introduced in plasma-framework. A
dozen reports in a few days.

Can I ask for a plasma-framework 5.70.1. with
c215c54eced5bd0b195c208dd72bb580e65f8fe4 cherry-picked.

Sorry.

David

D29742: Avoid potential disconnect of all signals in IconItem

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c215c54eced5: Avoid potential disconnect of all signals 
in IconItem (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29742?vs=82830=82833

REVISION DETAIL
  https://phabricator.kde.org/D29742

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: davidedmundson, #plasma, ahiemstra
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29742: Avoid potential disconnect of all signals in IconItem

[Arjen Hiemstra]

ahiemstra accepted this revision.
ahiemstra added a comment.
This revision is now accepted and ready to land.


  This fixes bug 421170 for me.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29742

To: davidedmundson, #plasma, ahiemstra
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29742: Avoid potential disconnect of all signals in IconItem

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  m_svgIcon can be null.
  
  disconnect(q, nullptr, nullptr, nullptr); would have pretty catastrophic
  consequences as it disconnects everything. Anyone listening for
  QObject::destroyed of IconItem for cleanup would no longer get anything.
  That could lead to obscure conditions.
  
  ShaderEffectSource watches for the source being destroyed for cleanup
  and we have a newly introduced crash with ShaderEffectSource that seems
  to come from this patch.
  
  CCBUG: 421170

TEST PLAN
  Uploading for someone to reproduce to test

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29742

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

[Filip Fila]

filipf added a dependent revision: D29741: [Logout] Port to QQC2 and PC3.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

[Filip Fila]

filipf edited the summary of this revision.
filipf edited the test plan for this revision.
filipf added reviewers: davidedmundson, mart, Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

[Filip Fila]

filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We have two interfering button background items right now:
  
  - surfaceNormal when it has activeFocus and is using using the 
"focus-background" item
  - surfacePressed
  
  After a button is pressed surfacePressed correctly disappears but 
surfaceNormal remains in the "focus-background" state, thereby making the 
button still look pressed.
  
  The problem is that the button still has activeFocus even after a press.
  
  To solve this we switch the "focus-background" to only show up on 
visualFocus. Per Qt documentation on visual Focus:
  "In general, for visualizing key focus, this property is preferred over 
Item::activeFocus. This ensures that key focus is only visualized when 
interacting with keys - not when interacting via touch or mouse."
  
  Given that we have surfacePressed for focus accomplished with a mouse or 
touch, visualFocus will only detect tabbing and therefore the button no longer 
remains pressed after a press and behaves like its PC2 counterpart.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-remain-pressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29740

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml

To: filipf
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin created this revision.
manueljlin added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
manueljlin requested review of this revision.

REVISION SUMMARY
  Everything added except for both trash icons because
  I couldn't figure out how to use svg cleaner without
  keeping the gradient. Fixes BUG: 421144

REPOSITORY
  R266 Breeze Icons

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

AFFECTED FILES
  icons-dark/places/48/certificate-server.svg
  icons-dark/places/48/desktop.svg
  icons-dark/places/48/favorites.svg
  icons-dark/places/48/folder-activities.svg
  icons-dark/places/48/folder-black.svg
  icons-dark/places/48/folder-blue.svg
  icons-dark/places/48/folder-bookmark.svg
  icons-dark/places/48/folder-brown.svg
  icons-dark/places/48/folder-cloud.svg
  icons-dark/places/48/folder-cyan.svg
  icons-dark/places/48/folder-decrypted.svg
  icons-dark/places/48/folder-development.svg
  icons-dark/places/48/folder-documents.svg
  icons-dark/places/48/folder-download.svg
  icons-dark/places/48/folder-downloads.svg
  icons-dark/places/48/folder-dropbox.svg
  icons-dark/places/48/folder-encrypted.svg
  icons-dark/places/48/folder-favorites.svg
  icons-dark/places/48/folder-games.svg
  icons-dark/places/48/folder-gdrive.svg
  icons-dark/places/48/folder-green.svg
  icons-dark/places/48/folder-grey.svg
  icons-dark/places/48/folder-html.svg
  icons-dark/places/48/folder-image-people.svg
  icons-dark/places/48/folder-image.svg
  icons-dark/places/48/folder-images.svg
  icons-dark/places/48/folder-important.svg
  icons-dark/places/48/folder-locked.svg
  icons-dark/places/48/folder-magenta.svg
  icons-dark/places/48/folder-mail.svg
  icons-dark/places/48/folder-music.svg
  icons-dark/places/48/folder-network.svg
  icons-dark/places/48/folder-onedrive.svg
  icons-dark/places/48/folder-open.svg
  icons-dark/places/48/folder-orange.svg
  icons-dark/places/48/folder-owncloud.svg
  icons-dark/places/48/folder-picture.svg
  icons-dark/places/48/folder-pictures.svg
  icons-dark/places/48/folder-print.svg
  icons-dark/places/48/folder-public.svg
  icons-dark/places/48/folder-publicshare.svg
  icons-dark/places/48/folder-recent.svg
  icons-dark/places/48/folder-red.svg
  icons-dark/places/48/folder-remote.svg
  icons-dark/places/48/folder-root.svg
  icons-dark/places/48/folder-script.svg
  icons-dark/places/48/folder-sound.svg
  icons-dark/places/48/folder-tar.svg
  icons-dark/places/48/folder-temp.svg
  icons-dark/places/48/folder-templates.svg
  icons-dark/places/48/folder-text.svg
  icons-dark/places/48/folder-txt.svg
  icons-dark/places/48/folder-unlocked.svg
  icons-dark/places/48/folder-video.svg
  icons-dark/places/48/folder-videos.svg
  icons-dark/places/48/folder-violet.svg
  icons-dark/places/48/folder-yellow.svg
  icons-dark/places/48/folder.svg
  icons-dark/places/48/folder_html.svg
  icons-dark/places/48/library-music.svg
  icons-dark/places/48/network-server.svg
  icons-dark/places/48/network-workgroup.svg
  icons-dark/places/48/stock_folder.svg
  icons-dark/places/48/user-desktop.svg
  icons-dark/places/48/user-home.svg
  icons/places/48/certificate-server.svg
  icons/places/48/desktop.svg
  icons/places/48/favorites.svg
  icons/places/48/folder-activities.svg
  icons/places/48/folder-black.svg
  icons/places/48/folder-blue.svg
  icons/places/48/folder-bookmark.svg
  icons/places/48/folder-brown.svg
  icons/places/48/folder-cloud.svg
  icons/places/48/folder-cyan.svg
  icons/places/48/folder-decrypted.svg
  icons/places/48/folder-development.svg
  icons/places/48/folder-documents.svg
  icons/places/48/folder-download.svg
  icons/places/48/folder-downloads.svg
  icons/places/48/folder-dropbox.svg
  icons/places/48/folder-encrypted.svg
  icons/places/48/folder-favorites.svg
  icons/places/48/folder-games.svg
  icons/places/48/folder-gdrive.svg
  icons/places/48/folder-green.svg
  icons/places/48/folder-grey.svg
  icons/places/48/folder-html.svg
  icons/places/48/folder-image-people.svg
  icons/places/48/folder-image.svg
  icons/places/48/folder-images.svg
  icons/places/48/folder-important.svg
  icons/places/48/folder-locked.svg
  icons/places/48/folder-magenta.svg
  icons/places/48/folder-mail.svg
  icons/places/48/folder-music.svg
  icons/places/48/folder-network.svg
  icons/places/48/folder-onedrive.svg
  icons/places/48/folder-open.svg
  icons/places/48/folder-orange.svg
  icons/places/48/folder-owncloud.svg
  icons/places/48/folder-picture.svg
  icons/places/48/folder-pictures.svg
  icons/places/48/folder-print.svg
  icons/places/48/folder-public.svg
  icons/places/48/folder-publicshare.svg
  icons/places/48/folder-recent.svg
  icons/places/48/folder-red.svg
  icons/places/48/folder-remote.svg
  icons/places/48/folder-root.svg
  icons/places/48/folder-script.svg
  icons/places/48/folder-sound.svg
  icons/places/48/folder-tar.svg
  icons/places/48/folder-temp.svg
  

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

[Jonathan Marten]

marten created this revision.
marten added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.

REVISION SUMMARY
  https://bugs.kde.org/show_bug.cgi?id=421374 describes how a service file 
specified to run in a terminal gives an error saying that it cannot find 
'konsole' or the user's configured terminal program.
  
  The problem is that KIO::DesktopExecParser::resultingArguments(), if 
service.terminal() is true, prepends the terminal application to the command 
line.  If this is a relative path, as it is most likely to be (and will be in 
the default 'konsole' case), the "realExecutable" check in 
KProcessRunner::KProcessRunner() is triggered and the job aborts with an error 
message.
  
  This change expands the specified terminal executable into a full path in 
KIO::DesktopExecParser::resultingArguments(), and returns an error immediately 
if it cannot be found.  This is then prepended to the command line.  When 
KProcessRunner::KProcessRunner() checks the realExecutable (the first word of 
the command line) it will be an absolute path and the check will not fail.
  
  The order of the code blocks in KProcessRunner::KProcessRunner() is adjusted 
so that execParser.resultingArguments() is checked for being empty (an error 
return) before the first word of the command is accessed.  This means that the 
"realExecutable = execParser.resultingArguments().at(0)" test will not assert 
if resultingArguments() is an empty list.

TEST PLAN
  Built kio with this change, tested with the sample desktop file at 
https://bugs.kde.org/show_bug.cgi?id=421374#c8.  The command correctly runs in 
a terminal.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29738

AFFECTED FILES
  src/core/desktopexecparser.cpp
  src/gui/kprocessrunner.cpp

To: marten, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  In general, it's better to use QScreen::availableGeometry().

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D29569

To: printesoi, davidedmundson, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 141 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/141/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 14 May 2020 08:42:17 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: projectrootC_.CI.Job_Build Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectrootC_.CI.Job_Build.autotests.tst_actiontoolbar.qml

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 462 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/462/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 May 2020 08:42:17 +
 Build duration:
1 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.71.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)46%
(16/35)46%
(16/35)42%
(1709/4048)30%
(773/2599)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src60%
(12/20)60%
(12/20)40%
(1237/3065)30%
(554/1874)src.libkirigami50%
(3/6)50%
(3/6)71%
(471/660)38%
(219/571)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/314)0%
(0/154)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 66 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/66/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 14 May 2020 08:42:17 +
 Build duration:
1 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.71.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)46%
(16/35)46%
(16/35)42%
(1706/4048)30%
(768/2599)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src60%
(12/20)60%
(12/20)40%
(1234/3065)29%
(549/1874)src.libkirigami50%
(3/6)50%
(3/6)71%
(471/660)38%
(219/571)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/314)0%
(0/154)

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 70 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/70/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 14 May 2020 08:42:17 +
 Build duration:
58 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.14 - Build # 91 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.14/91/
 Project:
kf5-qt5 AndroidQt5.14
 Date of build:
Thu, 14 May 2020 08:42:17 +
 Build duration:
1 min 3 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 140 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/140/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 14 May 2020 08:38:07 +
 Build duration:
29 sec and counting
   CONSOLE OUTPUT
  [...truncated 255 lines...][2020-05-14T08:38:26.259Z] [2020-05-14T08:38:26.259Z]  * Qt5Network (required version >= 5.14.1)[2020-05-14T08:38:26.259Z]  * Qt5Qml (required version >= 5.14.1)[2020-05-14T08:38:26.259Z]  * Qt5QmlModels (required version >= 5.14.1)[2020-05-14T08:38:26.259Z]  * Qt5Quick[2020-05-14T08:38:26.259Z]  * Qt5Gui[2020-05-14T08:38:26.259Z]  * Qt5Widgets (required version >= 5.14.1)[2020-05-14T08:38:26.259Z]  * Qt5Svg[2020-05-14T08:38:26.259Z]  * Qt5QuickControls2[2020-05-14T08:38:26.259Z]  * Qt5 (required version >= 5.12.0)[2020-05-14T08:38:26.259Z]  * ECM (required version >= 5.70.0), Extra CMake Modules., [2020-05-14T08:38:26.259Z]  * Doxygen (required version >= 1.8.13)[2020-05-14T08:38:26.259Z]Needed for API dox QCH file generation[2020-05-14T08:38:26.259Z]  * QHelpGenerator, Part of Qt5 tools[2020-05-14T08:38:26.259Z]Needed for API dox QCH file generation[2020-05-14T08:38:26.259Z]  * Qt5Core[2020-05-14T08:38:26.259Z] [2020-05-14T08:38:26.259Z] -- Configuring done[2020-05-14T08:38:26.517Z] -- Generating done[2020-05-14T08:38:26.517Z] -- Build files have been written to: C:/CI/Job Build/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2020-05-14T08:38:27.444Z] [2020-05-14T08:38:27.444Z] C:\CI\Job Build>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" [2020-05-14T08:38:27.444Z] **[2020-05-14T08:38:27.444Z] ** Visual Studio 2019 Developer Command Prompt v16.4.3[2020-05-14T08:38:27.444Z] ** Copyright (c) 2019 Microsoft Corporation[2020-05-14T08:38:27.444Z] **[2020-05-14T08:38:28.380Z] [vcvarsall.bat] Environment initialized for: 'x64'[2020-05-14T08:38:28.380Z] [1/50] Automatic MOC for target qmltest[2020-05-14T08:38:28.380Z] [2/50] Automatic MOC for target applicationitemapp[2020-05-14T08:38:28.380Z] [3/50] Generating kirigami.tar.bz2[2020-05-14T08:38:28.380Z] .[2020-05-14T08:38:28.380Z] ./CMakeLists.txt[2020-05-14T08:38:28.380Z] ./kirigami-app.png[2020-05-14T08:38:28.380Z] ./kirigami.kdevtemplate[2020-05-14T08:38:28.380Z] ./org.kde.%{APPNAMELC}.appdata.xml[2020-05-14T08:38:28.380Z] ./org.kde.%{APPNAMELC}.desktop[2020-05-14T08:38:28.380Z] ./src[2020-05-14T08:38:28.380Z] ./src/CMakeLists.txt[2020-05-14T08:38:28.380Z] ./src/contents[2020-05-14T08:38:28.380Z] ./src/contents/ui[2020-05-14T08:38:28.380Z] ./src/contents/ui/main.qml[2020-05-14T08:38:28.380Z] ./src/main.cpp[2020-05-14T08:38:28.380Z] ./src/resources.qrc[2020-05-14T08:38:28.380Z] [4/50] Generating qrc_resources.cpp[2020-05-14T08:38:28.640Z] [5/50] Building CXX object autotests\CMakeFiles\qmltest.dir\qmltest_autogen\mocs_compilation.cpp.obj[2020-05-14T08:38:28.640Z] [6/50] Building CXX object examples\applicationitemapp\CMakeFiles\applicationitemapp.dir\applicationitemapp_autogen\mocs_compilation.cpp.obj[2020-05-14T08:38:28.640Z] [7/50] Building CXX object examples\applicationitemapp\CMakeFiles\applicationitemapp.dir\qrc_resources.cpp.obj[2020-05-14T08:38:28.640Z] [8/50] Automatic MOC for target KF5Kirigami2[2020-05-14T08:38:28.640Z] [9/50] Building CXX object src\libkirigami\CMakeFiles\KF5Kirigami2.dir\KF5Kirigami2_autogen\mocs_compilation.cpp.obj[2020-05-14T08:38:28.640Z] [10/50] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[2020-05-14T08:38:29.590Z] [11/50] Building CXX object src\libkirigami\CMakeFiles\KF5Kirigami2.dir\tabletmodewatcher.cpp.obj[2020-05-14T08:38:29.590Z] [12/50] Building CXX object src\libkirigami\CMakeFiles\KF5Kirigami2.dir\loggingcategory.cpp.obj[2020-05-14T08:38:29.847Z] [13/50] Building CXX object src\libkirigami\CMakeFiles\KF5Kirigami2.dir\kirigamipluginfactory.cpp.obj[2020-05-14T08:38:30.413Z] [14/50] Building CXX object src\libkirigami\CMakeFiles\KF5Kirigami2.dir\basictheme.cpp.obj[2020-05-14T08:38:30.413Z] [15/50] Building CXX object src\libkirigami\CMakeFiles\KF5Kirigami2.dir\platformtheme.cpp.obj[2020-05-14T08:38:30.673Z] [16/50] Linking CXX shared library bin\KF5Kirigami2.dll[2020-05-14T08:38:30.673Z]Creating library lib\KF5Kirigami2.lib and object lib\KF5Kirigami2.exp[2020-05-14T08:38:30.673Z]Creating library lib\KF5Kirigami2.lib and object lib\KF5Kirigami2.exp[2020-05-14T08:38:31.248Z] [17/50] Building CXX object examples\applicationitemapp\CMakeFiles\applicationitemapp.dir\main.cpp.obj[2020-05-14T08:38:31.248Z] [18/50] Automatic MOC for target kirigamiplugin[2020-05-14T08:38:31.248Z] [19/50] Generating qrc_shaders.cpp[2020-05-14T08:38:31.509Z] [20/50] Linking CXX executable bin\applicationitemapp.exe[2020-05-14T08:38:31.509Z]

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 65 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/65/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 14 May 2020 08:38:07 +
 Build duration:
46 sec and counting
   CONSOLE OUTPUT
  [...truncated 278 lines...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-05-14T08:38:47.348Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.14 --usingInstall /home/jenkins//install-prefix/[2020-05-14T08:38:47.348Z] Scanning dependencies of target KF5Kirigami2_QCH[2020-05-14T08:38:47.348Z] Scanning dependencies of target KF5Kirigami2_autogen[2020-05-14T08:38:47.348Z] Scanning dependencies of target kirigami[2020-05-14T08:38:47.348Z] Scanning dependencies of target qmltest_autogen[2020-05-14T08:38:47.348Z] Scanning dependencies of target applicationitemapp_autogen[2020-05-14T08:38:47.348Z] [  1%] Automatic MOC for target KF5Kirigami2[2020-05-14T08:38:47.348Z] [  3%] Automatic MOC for target qmltest[2020-05-14T08:38:47.348Z] [  5%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[2020-05-14T08:38:47.348Z] [  7%] Generating kirigami.tar.bz2[2020-05-14T08:38:47.348Z] [  9%] Automatic MOC for target applicationitemapp[2020-05-14T08:38:47.348Z] .[2020-05-14T08:38:47.348Z] ./org.kde.%{APPNAMELC}.appdata.xml[2020-05-14T08:38:47.348Z] ./CMakeLists.txt[2020-05-14T08:38:47.348Z] ./src[2020-05-14T08:38:47.348Z] ./src/CMakeLists.txt[2020-05-14T08:38:47.348Z] ./src/contents[2020-05-14T08:38:47.348Z] ./src/contents/ui[2020-05-14T08:38:47.348Z] ./src/contents/ui/main.qml[2020-05-14T08:38:47.348Z] ./src/main.cpp[2020-05-14T08:38:47.348Z] ./src/resources.qrc[2020-05-14T08:38:47.348Z] ./kirigami.kdevtemplate[2020-05-14T08:38:47.348Z] ./kirigami-app.png[2020-05-14T08:38:47.348Z] ./org.kde.%{APPNAMELC}.desktop[2020-05-14T08:38:47.348Z] [  9%] Built target qmltest_autogen[2020-05-14T08:38:47.348Z] [  9%] Built target kirigami[2020-05-14T08:38:47.348Z] [  9%] Built target applicationitemapp_autogen[2020-05-14T08:38:47.348Z] [ 11%] Generating qrc_resources.cpp[2020-05-14T08:38:47.348Z] Building up file structure...[2020-05-14T08:38:47.348Z] Insert custom filters...[2020-05-14T08:38:47.348Z] Insert help data for filter section (1 of 1)...[2020-05-14T08:38:47.348Z] Insert files...[2020-05-14T08:38:47.348Z] Insert contents...[2020-05-14T08:38:47.348Z] Insert indices...[2020-05-14T08:38:47.348Z] Documentation successfully generated.[2020-05-14T08:38:47.348Z] Scanning dependencies of target applicationitemapp[2020-05-14T08:38:47.348Z] [ 11%] Built target KF5Kirigami2_QCH[2020-05-14T08:38:47.348Z] [ 13%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:47.348Z] [ 15%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[2020-05-14T08:38:47.607Z] [ 17%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[2020-05-14T08:38:47.607Z] Scanning dependencies of target qmltest[2020-05-14T08:38:47.607Z] [ 19%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:47.607Z] [ 21%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest.cpp.o[2020-05-14T08:38:47.607Z] [ 21%] Built target KF5Kirigami2_autogen[2020-05-14T08:38:47.607Z] [ 23%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[2020-05-14T08:38:47.607Z] [ 25%] Generating tabletmodemanager_interface.moc[2020-05-14T08:38:47.607Z] Scanning dependencies of target KF5Kirigami2[2020-05-14T08:38:47.607Z] [ 26%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:47.607Z] [ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[2020-05-14T08:38:47.607Z] [ 30%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[2020-05-14T08:38:47.607Z] [ 32%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[2020-05-14T08:38:47.607Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[2020-05-14T08:38:47.607Z] [ 36%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[2020-05-14T08:38:47.607Z] [ 38%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[2020-05-14T08:38:48.984Z] [ 40%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[2020-05-14T08:38:49.241Z] [ 42%] Linking CXX executable ../../bin/applicationitemapp[2020-05-14T08:38:49.499Z] [ 42%] Built target KF5Kirigami2[2020-05-14T08:38:49.499Z] Scanning dependencies of target kirigamiplugin_autogen[2020-05-14T08:38:49.499Z] [ 44%] Automatic MOC for target 

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 461 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/461/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 May 2020 08:38:07 +
 Build duration:
52 sec and counting
   CONSOLE OUTPUT
  [...truncated 278 lines...][Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-05-14T08:38:52.910Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-05-14T08:38:52.911Z] Scanning dependencies of target applicationitemapp_autogen[2020-05-14T08:38:52.911Z] Scanning dependencies of target KF5Kirigami2_autogen[2020-05-14T08:38:52.911Z] Scanning dependencies of target qmltest_autogen[2020-05-14T08:38:52.911Z] Scanning dependencies of target kirigami[2020-05-14T08:38:52.911Z] Scanning dependencies of target KF5Kirigami2_QCH[2020-05-14T08:38:52.911Z] [  1%] Automatic MOC for target applicationitemapp[2020-05-14T08:38:52.911Z] [  3%] Automatic MOC for target qmltest[2020-05-14T08:38:52.911Z] [  5%] Generating kirigami.tar.bz2[2020-05-14T08:38:52.911Z] [  7%] Automatic MOC for target KF5Kirigami2[2020-05-14T08:38:52.911Z] [  9%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[2020-05-14T08:38:52.911Z] .[2020-05-14T08:38:52.911Z] ./kirigami.kdevtemplate[2020-05-14T08:38:52.911Z] ./org.kde.%{APPNAMELC}.appdata.xml[2020-05-14T08:38:52.911Z] ./src[2020-05-14T08:38:52.911Z] ./src/resources.qrc[2020-05-14T08:38:52.911Z] ./src/CMakeLists.txt[2020-05-14T08:38:52.911Z] ./src/contents[2020-05-14T08:38:52.911Z] ./src/contents/ui[2020-05-14T08:38:52.911Z] ./src/contents/ui/main.qml[2020-05-14T08:38:52.911Z] ./src/main.cpp[2020-05-14T08:38:52.911Z] ./CMakeLists.txt[2020-05-14T08:38:52.911Z] ./org.kde.%{APPNAMELC}.desktop[2020-05-14T08:38:52.911Z] ./kirigami-app.png[2020-05-14T08:38:52.911Z] [  9%] Built target kirigami[2020-05-14T08:38:52.911Z] [  9%] Built target applicationitemapp_autogen[2020-05-14T08:38:52.911Z] [  9%] Built target qmltest_autogen[2020-05-14T08:38:52.911Z] [ 11%] Generating qrc_resources.cpp[2020-05-14T08:38:52.911Z] Building up file structure...[2020-05-14T08:38:52.911Z] Insert custom filters...[2020-05-14T08:38:52.911Z] Insert help data for filter section (1 of 1)...[2020-05-14T08:38:52.911Z] Insert files...[2020-05-14T08:38:52.911Z] Insert contents...[2020-05-14T08:38:52.911Z] Insert indices...[2020-05-14T08:38:52.911Z] Documentation successfully generated.[2020-05-14T08:38:52.911Z] Scanning dependencies of target applicationitemapp[2020-05-14T08:38:52.911Z] [ 13%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:52.911Z] [ 15%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[2020-05-14T08:38:52.911Z] [ 15%] Built target KF5Kirigami2_QCH[2020-05-14T08:38:52.911Z] [ 17%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[2020-05-14T08:38:53.169Z] Scanning dependencies of target qmltest[2020-05-14T08:38:53.170Z] [ 19%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:53.170Z] [ 21%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest.cpp.o[2020-05-14T08:38:53.170Z] [ 21%] Built target KF5Kirigami2_autogen[2020-05-14T08:38:53.170Z] [ 23%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[2020-05-14T08:38:53.170Z] [ 25%] Generating tabletmodemanager_interface.moc[2020-05-14T08:38:53.170Z] Scanning dependencies of target KF5Kirigami2[2020-05-14T08:38:53.170Z] [ 26%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:53.170Z] [ 30%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[2020-05-14T08:38:53.170Z] [ 30%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[2020-05-14T08:38:53.170Z] [ 32%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[2020-05-14T08:38:53.170Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[2020-05-14T08:38:53.170Z] [ 36%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[2020-05-14T08:38:53.170Z] [ 38%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[2020-05-14T08:38:54.546Z] [ 40%] Linking CXX executable ../../bin/applicationitemapp[2020-05-14T08:38:54.803Z] [ 42%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[2020-05-14T08:38:55.060Z] [ 42%] Built target applicationitemapp[2020-05-14T08:38:55.060Z] [ 42%] Built target KF5Kirigami2[2020-05-14T08:38:55.060Z] Scanning dependencies of target kirigamiplugin_autogen[2020-05-14T08:38:55.060Z] 

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 69 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/69/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 14 May 2020 08:38:07 +
 Build duration:
23 sec and counting
   CONSOLE OUTPUT
  [...truncated 228 lines...][2020-05-14T08:38:23.414Z] [  1%] Automatic MOC for target applicationitemapp[2020-05-14T08:38:23.414Z] [  3%] Automatic MOC for target KF5Kirigami2[2020-05-14T08:38:23.414Z] [  3%] Built target Qt5Core_QCH[2020-05-14T08:38:23.414Z] [  5%] Automatic MOC for target qmltest[2020-05-14T08:38:23.414Z] [  7%] Generating kirigami.tar.bz2[2020-05-14T08:38:23.414Z] Scanning dependencies of target KF5Kirigami2_QCH[2020-05-14T08:38:23.414Z] [  9%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[2020-05-14T08:38:23.414Z] .[2020-05-14T08:38:23.414Z] ./kirigami.kdevtemplate[2020-05-14T08:38:23.414Z] ./org.kde.%{APPNAMELC}.desktop[2020-05-14T08:38:23.414Z] ./org.kde.%{APPNAMELC}.appdata.xml[2020-05-14T08:38:23.414Z] ./CMakeLists.txt[2020-05-14T08:38:23.414Z] ./kirigami-app.png[2020-05-14T08:38:23.414Z] ./src[2020-05-14T08:38:23.414Z] ./src/CMakeLists.txt[2020-05-14T08:38:23.414Z] ./src/resources.qrc[2020-05-14T08:38:23.414Z] ./src/contents[2020-05-14T08:38:23.414Z] ./src/contents/ui[2020-05-14T08:38:23.414Z] ./src/contents/ui/main.qml[2020-05-14T08:38:23.414Z] ./src/main.cpp[2020-05-14T08:38:23.414Z] [  9%] Built target kirigami[2020-05-14T08:38:23.414Z] [  9%] Built target applicationitemapp_autogen[2020-05-14T08:38:23.414Z] [  9%] Built target qmltest_autogen[2020-05-14T08:38:23.414Z] [ 11%] Generating qrc_resources.cpp[2020-05-14T08:38:23.676Z] Scanning dependencies of target applicationitemapp[2020-05-14T08:38:23.676Z] [ 13%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:23.676Z] [ 15%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[2020-05-14T08:38:23.676Z] [ 17%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[2020-05-14T08:38:23.676Z] Scanning dependencies of target qmltest[2020-05-14T08:38:23.676Z] [ 19%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:23.676Z] [ 21%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest.cpp.o[2020-05-14T08:38:23.936Z] [ 21%] Built target KF5Kirigami2_autogen[2020-05-14T08:38:23.936Z] [ 23%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[2020-05-14T08:38:23.936Z] [ 25%] Generating tabletmodemanager_interface.moc[2020-05-14T08:38:24.196Z] Scanning dependencies of target KF5Kirigami2[2020-05-14T08:38:24.197Z] [ 26%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:24.197Z] [ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[2020-05-14T08:38:24.197Z] [ 30%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[2020-05-14T08:38:24.197Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[2020-05-14T08:38:24.197Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[2020-05-14T08:38:24.197Z] [ 36%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[2020-05-14T08:38:24.197Z] [ 38%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[2020-05-14T08:38:24.197Z] Building up file structure...[2020-05-14T08:38:24.197Z] Insert custom filters...[2020-05-14T08:38:24.197Z] Insert help data for filter section (1 of 1)...[2020-05-14T08:38:24.197Z] Insert files...[2020-05-14T08:38:24.197Z] Insert contents...[2020-05-14T08:38:24.197Z] Insert indices...[2020-05-14T08:38:24.197Z] Documentation successfully generated.[2020-05-14T08:38:24.197Z] [ 38%] Built target KF5Kirigami2_QCH[2020-05-14T08:38:25.576Z] [ 40%] Linking CXX executable ../../bin/applicationitemapp[2020-05-14T08:38:25.576Z] [ 42%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[2020-05-14T08:38:25.836Z] [ 42%] Built target applicationitemapp[2020-05-14T08:38:25.836Z] [ 42%] Built target KF5Kirigami2[2020-05-14T08:38:25.836Z] Scanning dependencies of target kirigamiplugin_autogen[2020-05-14T08:38:25.836Z] [ 44%] Automatic MOC for target kirigamiplugin[2020-05-14T08:38:26.403Z] [ 46%] Linking CXX executable ../bin/qmltest[2020-05-14T08:38:26.403Z] [ 46%] Built target qmltest[2020-05-14T08:38:27.331Z] [ 46%] Built target kirigamiplugin_autogen[2020-05-14T08:38:27.331Z] [ 48%] Generating qrc_shaders.cpp[2020-05-14T08:38:27.604Z] Scanning dependencies of target kirigamiplugin[2020-05-14T08:38:27.604Z] [ 50%] Building CXX object 

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.14 - Build # 90 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.14/90/
 Project:
kf5-qt5 AndroidQt5.14
 Date of build:
Thu, 14 May 2020 08:38:07 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 241 lines...][2020-05-14T08:38:52.087Z]  * Qt5AndroidExtras (required version >= 5.12.0)[2020-05-14T08:38:52.087Z]  * Qt5Core[2020-05-14T08:38:52.087Z] [2020-05-14T08:38:52.087Z] -- The following features have been disabled:[2020-05-14T08:38:52.087Z] [2020-05-14T08:38:52.087Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2020-05-14T08:38:52.087Z] [2020-05-14T08:38:52.087Z] -- The following RUNTIME packages have not been found:[2020-05-14T08:38:52.087Z] [2020-05-14T08:38:52.087Z]  * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.[2020-05-14T08:38:52.087Z] [2020-05-14T08:38:52.087Z] -- Configuring done[2020-05-14T08:38:52.087Z] -- Generating done[2020-05-14T08:38:52.087Z] CMake Warning:[2020-05-14T08:38:52.087Z]   Manually-specified variables were not used by the project:[2020-05-14T08:38:52.087Z] [2020-05-14T08:38:52.087Z] KF5_HOST_TOOLING[2020-05-14T08:38:52.087Z] [2020-05-14T08:38:52.087Z] [2020-05-14T08:38:52.087Z] -- Build files have been written to: /home/user/workspace/Frameworks/kirigami/kf5-qt5 AndroidQt5.14/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-05-14T08:38:52.986Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform AndroidQt5.14 --usingInstall /home/user/install-prefix/[2020-05-14T08:38:52.986Z] Scanning dependencies of target applicationitemapp_autogen[2020-05-14T08:38:52.986Z] Scanning dependencies of target KF5Kirigami2_autogen[2020-05-14T08:38:52.986Z] Scanning dependencies of target qmltest_autogen[2020-05-14T08:38:52.986Z] [  2%] Automatic MOC for target applicationitemapp[2020-05-14T08:38:52.986Z] [  4%] Automatic MOC for target KF5Kirigami2[2020-05-14T08:38:52.986Z] [  6%] Automatic MOC for target qmltest[2020-05-14T08:38:52.986Z] [  6%] Built target qmltest_autogen[2020-05-14T08:38:52.986Z] [  6%] Built target applicationitemapp_autogen[2020-05-14T08:38:52.986Z] [  8%] Generating qrc_resources.cpp[2020-05-14T08:38:53.557Z] Scanning dependencies of target applicationitemapp[2020-05-14T08:38:53.557Z] [ 10%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:53.557Z] [ 12%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[2020-05-14T08:38:53.557Z] [ 14%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[2020-05-14T08:38:53.557Z] Scanning dependencies of target qmltest[2020-05-14T08:38:53.557Z] [ 17%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:53.557Z] [ 19%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest.cpp.o[2020-05-14T08:38:53.819Z] [ 19%] Built target KF5Kirigami2_autogen[2020-05-14T08:38:53.819Z] Scanning dependencies of target KF5Kirigami2[2020-05-14T08:38:53.819Z] [ 21%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:53.819Z] [ 23%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[2020-05-14T08:38:53.819Z] [ 25%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[2020-05-14T08:38:53.819Z] [ 27%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[2020-05-14T08:38:53.819Z] [ 29%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[2020-05-14T08:38:54.793Z] [ 31%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[2020-05-14T08:38:56.191Z] [ 34%] Linking CXX shared library ../../bin/libKF5Kirigami2_armeabi-v7a.so[2020-05-14T08:38:56.191Z] [ 34%] Built target KF5Kirigami2[2020-05-14T08:38:56.191Z] Scanning dependencies of target kirigamiplugin_autogen[2020-05-14T08:38:56.191Z] [ 36%] Automatic MOC for target kirigamiplugin[2020-05-14T08:38:56.766Z] [ 38%] Linking CXX executable ../../bin/applicationitemapp[2020-05-14T08:38:57.027Z] [ 38%] Built target applicationitemapp[2020-05-14T08:38:57.287Z] [ 40%] Linking CXX executable ../bin/qmltest[2020-05-14T08:38:57.287Z] [ 40%] Built target qmltest[2020-05-14T08:38:57.287Z] [ 40%] Built target kirigamiplugin_autogen[2020-05-14T08:38:57.287Z] [ 42%] Generating qrc_shaders.cpp[2020-05-14T08:38:57.549Z] Scanning dependencies of target kirigamiplugin[2020-05-14T08:38:57.549Z] [ 44%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin_autogen/mocs_compilation.cpp.o[2020-05-14T08:38:57.549Z] [ 46%] Building CXX 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 602 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/602/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 May 2020 07:47:06 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34374/62878)39%
(17453/44546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(57/59)97%
(57/59)86%
(9095/10584)42%
(4278/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8468/14369)50%
(4397/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8341)43%
(2078/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 112 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/112/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 14 May 2020 07:47:07 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 104 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/104/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 14 May 2020 07:47:07 +
 Build duration:
6 min 37 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/414)67%
(276/414)55%
(34371/62879)39%
(17461/44542)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(57/59)97%
(57/59)86%
(9095/10583)42%
(4279/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8459/14368)50%
(4399/8714)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%

D29634: sftp: break large writes into multiple requests

[Méven Car]

meven added a comment.


  In D29634#670485 , @feverfew wrote:
  
  > In D29634#670419 , @meven wrote:
  >
  > > In D29634#670377 , @ngraham 
wrote:
  > >
  > > > Nice work.
  > > >
  > > > In D29634#670159 , @feverfew 
wrote:
  > > >
  > > > > I imagine something similar should be done for FileJob::write?
  > > >
  > > >
  > > > Yeah.
  > >
  > >
  > > I guess you meant `FileProtocol::write`.
  > >  There is no need there, it uses `QIODevice::write` directly.
  >
  >
  > Sorry, I meant `kio_sftp`'s implementation of this: 
https://api.kde.org/frameworks/kio/html/classKIO_1_1FileJob.html#a481871536fb9471ccb64929792f31165
  
  
  I believe this is taken care of this patch in `SFTPInternal::write`

REPOSITORY
  R320 KIO Extras

BRANCH
  release/20.04

REVISION DETAIL
  https://phabricator.kde.org/D29634

To: sitter, ngraham, meven, feverfew
Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> file_unix.cpp:1074
>  
>  if (::rename(_src.data(), _dest.data())) {
>  if (auto err = execWithElevatedPrivilege(RENAME, {_src, _dest}, 
> errno)) {

Wouldn't it be enough to just call QFile::rename here?

The whole idea is: if QFile::rename is able to rename a file in all cases, 
including the a->A special case on FAT, then let's just delegate the renaming 
to QFile.

Then we don't need to have any special case in our code.

QFile::rename does not overwrite, though, so if the dest exists and the 
Overwrite flag is set, we might have to either delete the dest first (race 
condition, not sure it matters here), or in *that* case use ::rename() since we 
know it can't be a FAT32-case-change (FAT32 can't have both a and A).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29610

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27989: Add a new set of barcode size functions

[Volker Krause]

vkrause added a comment.


  In D27989#670416 , @kossebau wrote:
  
  > > minimumSize() becomes deprecated by this, the deprecation macros will
  > >  follow once the current users have been adjusted.
  >
  > IMHO you should add the macros from the start, otherwise it will be only 
forgotten later, as there is no mechanism to remind you. And without compiler 
warnings all the remaining users might never learn about it.
  >
  > I would expect you have prepared patches for some known users already to 
testdrive the new API for usefulness, so the set of remaining users (in KDE 
spheres) should be already small. And those not yet withzout a patch, what 
would be the plan to care for them? In the end it needs to compiler warnings to 
get other people in the game. After all API is not deprecated without a reason. 
Being too gentle with warnings does not help anyone in the end.
  
  
  There's two remaining users in everything covered by lxr, the Plasma 
clipboard (patch in review: https://phabricator.kde.org/D29478) and KDE PIM 
(which now depends on a sufficiently new KF5 version to actually do the 
migration). Both ways can be argued of course, I optimized for "helps me" (the 
warnings for things I can't change yet don't), and "migration is my problem" 
rather than "migration is somebody else's problem" (which is my understanding 
of how we are supposed to be doing KF deprecations to ease the 6 transition).

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27989

To: vkrause, svuorela
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

[Dominik Haumann]

dhaumann added a subscriber: cullmann.
dhaumann added a comment.


  @cullmann could you integrate this?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29735

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Good catch :) please commit

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29735

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, 
cullmann, vkrause, sars