D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-20 Thread David Faure 
dfaure added a comment.


  https://invent.kde.org/frameworks/kcmutils/-/merge_requests/2

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela
Cc: ahmadsamir, rikmills, wbauer, kossebau, svuorela, cblack, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-20 Thread Ahmad Samir 
ahmadsamir added a comment.


  I guess a proper fix will need to revert part of this to have the KModuleInfo 
ctor that took a KService not use KPluginInfo internally; better still, of 
course, is having the KPluginInfo ctor work for the case of 
X-KDE-ServiceTypes=SystemSettingsExternalApp, (I couldn't grok KPluginInfo 
stuff fully yet).

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela
Cc: ahmadsamir, rikmills, wbauer, kossebau, svuorela, cblack, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-20 Thread Ahmad Samir 
ahmadsamir added a comment.


  systemsettings uses KCModuleInfo::service() to check whether the moduleinfo 
is valid[1], the problem is creating a KPluginInfo from the KService based on a 
.desktop file with X-KDE-ServiceTypes=SystemSettingsExternalApp fails because 
it doesn't seem to have valid metadata. Since the KPluginInfo ctor fails, 
accessing d->pluginInfo.service() causes a crash, I've submitted a proposed fix 
at [2]. This doesn't fix the bug, but merely prevents the crash.
  
  [1] 
https://invent.kde.org/plasma/systemsettings/-/blob/master/core/ModuleView.cpp#L229
  [2] https://invent.kde.org/frameworks/kcmutils/-/merge_requests/1

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela
Cc: ahmadsamir, rikmills, wbauer, kossebau, svuorela, cblack, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-20 Thread Nicolas Fella 
nicolasfella requested changes to this revision.
nicolasfella added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> notifybyandroid.cpp:110
>  n.setField("urgency", (jint)(notification->urgency() == 
> KNotification::DefaultUrgency ? KNotification::HighUrgency : 
> notification->urgency()));
> +n.setField("visibility", 
> QAndroidJniObject::fromString(notification->hints().value(QLatin1String("visibility")).toString().toLower()).object());
>  

The hint name should be something like x-kde-visibility

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29358

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-20 Thread Rik Mills 
rikmills added a comment.


  In D28765#673191 , @wbauer wrote:
  
  > This caused a crash in openSUSE:
  >  https://bugs.kde.org/show_bug.cgi?id=421566
  
  
  The same crash can been seen in Kubuntu when trying to launch the external 
software-properties app (driver manager) via systemsettings.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela
Cc: rikmills, wbauer, kossebau, svuorela, cblack, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D29050: KRunner fix prepare/teardown signals

2020-05-20 Thread Méven Car 
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  It is hard to understand why it was wrongly placed here, that makes this hard 
to review and approve.
  But you are getting familiar with KRunner internals, so since it does seem 
benign and you tested it, I think we can merge this.
  
  Please wait a little, to see if others have something to say, before landing.

REPOSITORY
  R308 KRunner

BRANCH
  krunner_signal_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29232: Introduce the Header color set

2020-05-20 Thread Méven Car 
meven added a comment.


  @mart you have a couple of typos left and recommendation to add some doc.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack, ndavis
Cc: meven, davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-05-20 Thread Anthony Fieroni 
anthonyfieroni added a reviewer: davidedmundson.
anthonyfieroni added a comment.


  So change should be fine, 
(https://phabricator.kde.org/source/plasma-workspace/browse/master/appmenu) 
since KDED loads only modules they don't know where and when qApp is 
instantiated.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks, davidedmundson
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29793: Rename Perl6 syntax to Raku

2020-05-20 Thread Nibaldo González 
nibags abandoned this revision.
nibags added a comment.


  This is equivalent to: 
https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/1

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29793

To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29232: Introduce the Header color set

2020-05-20 Thread Marco Martin 
mart closed this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack, ndavis
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29232: Introduce the Header color set

2020-05-20 Thread Noah Davis 
ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  arcpatch-D29232

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack, ndavis
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29232: Introduce the Header color set

2020-05-20 Thread Marco Martin 
mart marked 9 inline comments as done.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29232: Introduce the Header color set

2020-05-20 Thread Marco Martin 
mart retitled this revision from "[WIP][RFC]Introduce the Header color set" to 
"Introduce the Header color set".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29232: [WIP][RFC]Introduce the Header color set

2020-05-20 Thread Marco Martin 
mart updated this revision to Diff 83090.
mart added a comment.


  - update to new colors

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29232?vs=81363=83090

BRANCH
  arcpatch-D29232

REVISION DETAIL
  https://phabricator.kde.org/D29232

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-05-20 Thread Vlad Zahorodnii 
zzag added a comment.


  In D29815#672682 , @anthonyfieroni 
wrote:
  
  > Is that KWin that set titlebar menus?
  
  
  from `#plasma` irc
  
  5:02:41 PM  kded does not load kwin
  5:03:15 PM  I believe the appmenu version where it's shown in the title 
bar is run by kded
  5:03:28 PM  kwin just triggers a qmenu shown at an explicit x,y
  5:04:42 PM  motivation at the time was to keep kwin from having too 
much random code in it... a design philosophy that hasn't aged well!

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks, zzag
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-05-20 Thread Vlad Zahorodnii 
zzag removed a reviewer: zzag.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29795: Add collaboration guide

2020-05-20 Thread Nibaldo González 
nibags abandoned this revision.
nibags added a comment.


  This is moved to 
https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/2

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29795

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-20 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma, ahiemstra
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Header color set

2020-05-20 Thread Noah Davis 
ndavis added a comment.


  Suggested colors are based on 
https://invent.kde.org/plasma/breeze/-/merge_requests/2

INLINE COMMENTS

> kcolorscheme.cpp:258
> +static const SetDefaultColors defaultHeaderColors = {
> +{  49,  54,  59 }, // Background
> +{  59,  64,  69 }, // Alternate

` 227, 229, 231 `

> kcolorscheme.cpp:259
> +{  49,  54,  59 }, // Background
> +{  59,  64,  69 }, // Alternate
> +{ 239, 240, 241 }, // Normal

` 239, 240, 241 `

> kcolorscheme.cpp:260
> +{  59,  64,  69 }, // Alternate
> +{ 239, 240, 241 }, // Normal
> +{ 175, 176, 179 }, // Inactive

`  35,  38,  41 `

> kcolorscheme.cpp:261
> +{ 239, 240, 241 }, // Normal
> +{ 175, 176, 179 }, // Inactive
> +{ 147, 206, 233 }, // Active

` 112, 125, 138 `

> kcolorscheme.cpp:262
> +{ 175, 176, 179 }, // Inactive
> +{ 147, 206, 233 }, // Active
> +{  61, 174, 230 }, // Link

`  61, 174, 233 `

> kcolorscheme.cpp:263
> +{ 147, 206, 233 }, // Active
> +{  61, 174, 230 }, // Link
> +{  61, 174, 230 }, // Visited

`  41, 128, 185 `

> kcolorscheme.cpp:264
> +{  61, 174, 230 }, // Link
> +{  61, 174, 230 }, // Visited
> +{ 231,  76,  60 }, // Negative

` 155,  89, 182 `

> kcolorscheme.cpp:265
> +{  61, 174, 230 }, // Visited
> +{ 231,  76,  60 }, // Negative
> +{ 253, 188,  75 }, // Neutral

` 218,  68,  83 `

> kcolorscheme.cpp:266
> +{ 231,  76,  60 }, // Negative
> +{ 253, 188,  75 }, // Neutral
> +{  46, 174, 230 }  // Positive

` 246, 116,   0 `

> kcolorscheme.cpp:267
> +{ 253, 188,  75 }, // Neutral
> +{  46, 174, 230 }  // Positive
> +};

`  39, 174,  96 `

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-20 Thread Nicolas Fella 
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29358

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29420: Generate DBus interface

2020-05-20 Thread Nicolas Fella 
nicolasfella closed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29420

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29420: Generate DBus interface

2020-05-20 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> notifybypopup.cpp:363
> +watcher->deleteLater();
> +QDBusPendingReply reply = *watcher;
> +notifications.insert(reply.argumentAt<0>(), notification);

I think we should do an error check and whether we got the correct argument 
count back but we previously also didn't do it, so probably fine

REPOSITORY
  R289 KNotifications

BRANCH
  geninterface

REVISION DETAIL
  https://phabricator.kde.org/D29420

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29793: Rename Perl6 syntax to Raku

2020-05-20 Thread Nibaldo González 
nibags updated this revision to Diff 83088.
nibags added a comment.


  - Fix extensions and unit tests

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29793?vs=82987=83088

BRANCH
  rename-perl6-raku

REVISION DETAIL
  https://phabricator.kde.org/D29793

AFFECTED FILES
  autotests/folding/highlight.pl6.fold
  autotests/folding/highlight.raku.fold
  autotests/html/highlight.pl6.html
  autotests/html/highlight.raku.html
  autotests/input/highlight.pl6
  autotests/input/highlight.raku
  autotests/reference/highlight.pl6.ref
  autotests/reference/highlight.raku.ref
  data/syntax/perl6.xml
  data/syntax/raku.xml

To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-20 Thread Wolfgang Bauer 
wbauer added a comment.


  This caused a crash in openSUSE:
  https://bugs.kde.org/show_bug.cgi?id=421566

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela
Cc: wbauer, kossebau, svuorela, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29795: Add collaboration guide

2020-05-20 Thread Nibaldo González 
nibags added a comment.


  I put it all in the README. I also corrected the repository, I had not 
noticed that this repository was already in GitLab!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29795

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29795: Add collaboration guide

2020-05-20 Thread Nibaldo González 
nibags updated this revision to Diff 83086.
nibags added a comment.


  - Add collaboration guide in the README file

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29795?vs=82995=83086

BRANCH
  add-collaboration-guide

REVISION DETAIL
  https://phabricator.kde.org/D29795

AFFECTED FILES
  README.md

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-20 Thread Harald Sitter 
sitter added a comment.


  Browsing the code it looks like it mmaps the file though? And when I add some 
strategic sleeping I can verify that file goes towards shared memory.
  
  Oh, I suppose the trouble is that load gets called each ::create? Simply wrap 
it in a cpp class and static scope it to something maybe?
  
  The finder by the way is still in disarray I've noticed. Please look at one 
of the more modern finds in ECM for reference. Also I think the find_library 
call is wrong, it should look for 'magic' not 'libmagic'
  
Each library name given to the NAMES option is first considered as a 
library file name and then considered with platform-specific prefixes (e.g. 
lib) and suffixes (e.g. .so).
  
  i.e. either the NAME is `libmagic.so` (which is a file) or `magic` (which 
gets platform adjusted), but probably not `libmagic` as that is neither a file 
nor will the platform adjusted `liblibmagic.so` be one.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29381

To: meven, #frameworks, sitter, ngraham
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29050: KRunner fix prepare/teardown signals

2020-05-20 Thread Alexander Lohnau 
alex edited the summary of this revision.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29050: KRunner fix prepare/teardown signals

2020-05-20 Thread Alexander Lohnau 
alex retitled this revision from "WIP KRunner fix prepare/teardown signals" to 
"KRunner fix prepare/teardown signals".

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29050: WIP KRunner fix prepare/teardown signals

2020-05-20 Thread Christoph Feck 
cfeck added a project: Plasma.
cfeck added a comment.


  If this is no longer Work-In-Progress, please remove "WIP" from the title.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-20 Thread Arjen Hiemstra 
ahiemstra accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma, ahiemstra
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 17 - Unstable!

2020-05-20 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/17/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Wed, 20 May 2020 09:06:33 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.71.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 47 test(s)Failed: projectroot.autotests.client.kwayland_testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27738/32805)53%
(11155/21001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12598/12688)50%
(6621/13155)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6356/7494)65%
(1839/2838)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8185/9822)63%
(2462/3909)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Still Unstable!

2020-05-20 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/20/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 20 May 2020 09:06:33 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-20 Thread Méven Car 
meven added a comment.


  ping dear reviewers

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns