D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> jobtest.cpp:502
> +// arguments  0:"-n" 1:"name" 2:"-v", 3:"value" 4:src
> +arguments = QStringList {"-n", "", "-v", "", "-h", src};
> +keyIndex = 1;

`std::function 
m_setXattrFormatArgs;`
...

  m_setXattrFormatArgs = [](const QString& attrName, const QString& value, 
const QString& fileName) {
  return QStringList{QLatin1String("-n"), attrName, QLatin1String("-v"), 
value, fileName};
  }

and do it when doing the path lookup, once.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29397: KPreviewJob : Support for DeviceRatioPixel

[Nathaniel Graham]

ngraham added a comment.


  Here's where the spec lives, FWIW: 
https://gitlab.freedesktop.org/xdg/xdg-specs
  
  Expanding it is mostly just a matter of writing up a reasonable proposal in 
the form of a merge request and getting enough people to agree. Discussing on 
the mailing list first can help, to gauge people's opinions.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29832: Fix Endianness issue during wallet decryption

[Nathaniel Graham]

ngraham added a reviewer: aacid.
ngraham added a comment.


  Thanks for the patch! FWIW we have moved patch review to GitLab; consider 
abandoning this and re-submitting it as a merge request at 
https://invent.kde.org/frameworks/kwallet/-/merge_requests
  
  Here's some documentation: https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29832

To: chriscz, dfaure, aacid
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/21/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 26 May 2020 00:26:58 +
 Build duration:
3 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D29832: Fix Endianness issue during wallet decryption

[Chris Coetzee]

chriscz added a comment.


  This stack overflow answer  has a more 
exhaustive approach to determining endianness. It may be worth extracting this 
code into a more appropriate header file though. Also here's the issue on the 
bugzilla tracker 

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29832

To: chriscz, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29832: Fix Endianness issue during wallet decryption

[Chris Coetzee]

chriscz created this revision.
chriscz added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chriscz requested review of this revision.

REVISION SUMMARY
  Correctly determine endianness on the specific platform using `endian.h' 
header available at least on GCC. Must be verified for other platforms and 
compilers.

TEST PLAN
  make install; killall kwalletd5; kwalletd5; kwalletmanager5
  Open wallet, enter password. Wallet now accepts my password and I can still 
see my passwords.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29832

AFFECTED FILES
  src/runtime/kwalletd/backend/blowfish.cc
  src/runtime/kwalletd/backend/sha1.cc

To: chriscz, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

[Friedrich W. H. Kossebau]

kossebau closed this revision.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D29003

To: junghans, kossebau, dfaure, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Looking at D28915 , seems you are only 
collecting to earn push rights so far :), so going to push for you with the 
author info taken from there.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D29003

To: junghans, kossebau, dfaure, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  How would we add the separator role to color scheme files if separator color 
was added to upstream Qt? Wouldn't we still need to add a separator role to 
KColorScheme so that we could map the color in the color scheme file to the 
equivalent QPalette ColorRole?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ahiemstra, broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, 
cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.12 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.12/95/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 25 May 2020 16:36:26 +
 Build duration:
2 min 33 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Runner-5.71.0.xmlcompat_reports/KF5Runner_compat_report.htmllogs/KF5Runner/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.runnercontexttest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)65%
(11/17)65%
(11/17)48%
(742/1558)33%
(264/804)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests67%
(2/3)67%
(2/3)78%
(131/167)53%
(52/98)src90%
(9/10)90%
(9/10)50%
(611/1214)35%
(212/606)src.declarative0%
(0/2)0%
(0/2)0%
(0/133)0%
(0/96)tests0%
(0/2)0%
(0/2)0%
(0/44)0%
(0/4)

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/18/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 25 May 2020 16:36:25 +
 Build duration:
2 min 59 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Runner-5.71.0.xmlcompat_reports/KF5Runner_compat_report.htmllogs/KF5Runner/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.runnercontexttest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)65%
(11/17)65%
(11/17)48%
(742/1559)33%
(265/804)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests67%
(2/3)67%
(2/3)78%
(131/167)53%
(52/98)src90%
(9/10)90%
(9/10)50%
(611/1214)35%
(213/606)src.declarative0%
(0/2)0%
(0/2)0%
(0/134)0%
(0/96)tests0%
(0/2)0%
(0/2)0%
(0/44)0%
(0/4)

KDE CI: Frameworks » krunner » kf5-qt5 FreeBSDQt5.14 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20FreeBSDQt5.14/19/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 25 May 2020 16:36:26 +
 Build duration:
1 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.runnercontexttest

D29397: KPreviewJob : Support for DeviceRatioPixel

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D29397#673830 , @ngraham wrote:
  
  > The approach makes sense then. I agree that making high DPI a part of the 
FDO spec would be nice, but IMO that shouldn't block this. The approach 
currently taken is logical and it could be submitted as an extension to the 
spec later.
  
  
  It might be seen logical to us from our current POV, but better to do as 
desktop developer generations have done before and try to get others on board 
from the start, once there is a first plan. Would we want others do just extend 
specs on their own and start to write stuff without namespacing onto common 
data grounds? I suspect: no :) So we better behave as well as we would like 
others to do.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> ngraham wrote in previewjob.cpp:401
> What about if I'm using a 250% scale factor? Maybe there should be an `@3x` 
> folder too.

or just trunate devicePixelRatio to int

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

[Nathaniel Graham]

ngraham added a comment.


  The approach makes sense then. I agree that making high DPI a part of the FDO 
spec would be nice, but IMO that shouldn't block this. The approach currently 
taken is logical and it could be submitted as an extension to the spec later.

INLINE COMMENTS

> ngraham wrote in previewjob.cpp:401
> Is this @2x suffix standardized? What happens if I'm using 125% scaling, 
> generate some previews, and then switch back to 100% (no scaling?)

What about if I'm using a 250% scale factor? Maybe there should be an `@3x` 
folder too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

[Anthony Fieroni]

anthonyfieroni added a comment.


  Wait @davidedmundson to accept it.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks, davidedmundson
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

[Christoph Cullmann]

On 2020-05-25 16:29, David Faure wrote:

Isn't this fixed by
https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911
?

(This fix happened because I reported this ktexteditor CI ASAN failure 
to

Simon Haussman, who fixed qtdeclarative)

IIUC all that's missing is a backport of the fix to 5.14.x, right?
I just left a note in the above gerrit MR to suggest such a backport.


Hi,

that could be, I did miss that report and did only find the one below.
(https://bugreports.qt.io/browse/QTBUG-84363)

From the backtrace, QTBUG-84363 looks a lot like our crash reports we 
got

in our bugs, too.

I have at the moment here no 5.15 compile/install to test that out.

Greetings
Christoph



Cheers,
David.

On samedi 23 mai 2020 15:08:28 CEST Christoph Cullmann wrote:

Hi,

I did a bit research, I think this might be

https://bugreports.qt.io/browse/QTBUG-84363

=> This makes actually Qt 5.14 completely unusable for
KTextEditor/Kate/KWrite/.

I run into this kind of crashs during normal editing, too :(

I still have no 5.15 build with the fix here, will need to investigate
that more.

Seems other users stumble on this for all parts of our products, e.g.

https://bugs.kde.org/show_bug.cgi?id=415872
https://bugs.kde.org/show_bug.cgi?id=414768

Greetings
Christoph

On 2020-05-21 13:09, CI System wrote:
> BUILD UNSTABLE
>
> Build URL
>
>https://build.kde.org/job/Frameworks/job/ktexteditor/

job/kf5-qt5%20SUSEQ

>t5.14/19/>
> Project:
>kf5-qt5 SUSEQt5.14
>
> Date of build:
>Thu, 21 May 2020 10:51:54 +
>
> Build duration:
>17 min and counting
>
> BUILD ARTIFACTS
>
>* abi-compatibility-results.yaml [1]
>* acc/KF5TextEditor-5.71.0.xml [2]
>* compat_reports/KF5TextEditor_compat_report.html [3]
>* logs/KF5TextEditor/5.71.0/log.txt [4]
>
> JUnit Tests
>
>Name: (root) Failed: 0 test(s), Passed: 1 test(s),

Skipped: 0

>
> test(s), Total: 1 test(s)
>
>Name: projectroot Failed: 3 test(s), Passed: 59

test(s), Skipped: 0

>
> test(s), Total: 62 test(s)
>
>* Failed: projectroot.autotests.bug313759
>
>* Failed: projectroot.autotests.kateindenttest_testAda
>
>* Failed: projectroot.autotests.kateindenttest_testPascal
>
>Name: projectroot.autotests.src Failed: 0 test(s),

Passed: 5

>
> test(s), Skipped: 0 test(s), Total: 5 test(s)
>
> Cobertura Report
>
> Project Coverage Summary
>
> Name
>
>Packages
>Files
>Classes
>Lines
>Conditionals
>
>Cobertura Coverage Report
>79% (22/28)
>87% (260/298)
>87% (260/298)
>67% (32994/49195)
>49% (14791/30094)
>
>Coverage Breakdown by Package
>
> Name
>
>Files
>Classes
>Lines
>Conditionals
>
>autotests.src
>97% (37/38)
>97% (37/38)
>93% (4785/5127)
>49% (1812/3680)
>
>autotests.src.vimode
>100% (9/9)
>100% (9/9)
>99% (5526/5568)
>58% (984/1708)
>
>src.buffer
>88% (15/17)
>88% (15/17)
>89% (1677/1892)
>74% (1082/1472)
>
>src.completion
>100% (11/11)
>100% (11/11)
>57% (1785/3131)
>42% (1008/2423)
>
>src.completion.expandingtree
>100% (3/3)
>100% (3/3)
>40% (182/457)
>21% (73/340)
>
>src.dialogs
>0% (0/4)
>0% (0/4)
>0% (0/858)
>0% (0/180)
>
>src.document
>100% (4/4)
>100% (4/4)
>61% (1934/3176)
>48% (1417/2977)
>
>src.export
>0% (0/4)
>0% (0/4)
>0% (0/121)
>0% (0/156)
>
>src.include.ktexteditor
>93% (14/15)
>93% (14/15)
>84% (187/222)
>55% (125/226)
>
>src.inputmode
>100% (8/8)
>100% (8/8)
>63% (192/304)
>51% (39/77)
>
>src.mode
>88% (7/8)
>88% (7/8)
>36% (378/1050)
>16% (146/897)
>
>src.part
>0% (0/1)
>0% (0/1)
>0% (0/7)
>100% (0/0)
>
>src.printing
>0% (0/4)
>0% (0/4)
>0% (0/862)
>0% (0/278)
>
>src.render
>100% (7/7)
>100% (7/7)
>77% (949/1226)
>67% (611/916)
>
>src.schema
>29% (2/7)
>29% (2/7)
>1% (19/1468)
>1% (6/625)
>
>src.script
>100% (16/16)
>

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

[Matej Mrenica]

mthw added a comment.


  Do I need to change anything or is this acceptable?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks, davidedmundson
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

[David Faure]

Isn't this fixed by
https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911
?

(This fix happened because I reported this ktexteditor CI ASAN failure to 
Simon Haussman, who fixed qtdeclarative)

IIUC all that's missing is a backport of the fix to 5.14.x, right?
I just left a note in the above gerrit MR to suggest such a backport.

Cheers,
David.

On samedi 23 mai 2020 15:08:28 CEST Christoph Cullmann wrote:
> Hi,
> 
> I did a bit research, I think this might be
> 
> https://bugreports.qt.io/browse/QTBUG-84363
> 
> => This makes actually Qt 5.14 completely unusable for
> KTextEditor/Kate/KWrite/.
> 
> I run into this kind of crashs during normal editing, too :(
> 
> I still have no 5.15 build with the fix here, will need to investigate
> that more.
> 
> Seems other users stumble on this for all parts of our products, e.g.
> 
> https://bugs.kde.org/show_bug.cgi?id=415872
> https://bugs.kde.org/show_bug.cgi?id=414768
> 
> Greetings
> Christoph
> 
> On 2020-05-21 13:09, CI System wrote:
> > BUILD UNSTABLE
> > 
> >  Build URL
> > 
> > https://build.kde.org/job/Frameworks/job/ktexteditor/
job/kf5-qt5%20SUSEQ
> > t5.14/19/>  
> >  Project:
> > kf5-qt5 SUSEQt5.14
> > 
> >  Date of build:
> > Thu, 21 May 2020 10:51:54 +
> > 
> >  Build duration:
> > 17 min and counting
> > 
> >  BUILD ARTIFACTS
> > 
> > * abi-compatibility-results.yaml [1]
> > * acc/KF5TextEditor-5.71.0.xml [2]
> > * compat_reports/KF5TextEditor_compat_report.html [3]
> > * logs/KF5TextEditor/5.71.0/log.txt [4]
> > 
> >  JUnit Tests
> > 
> > Name: (root) Failed: 0 test(s), Passed: 1 test(s), 
Skipped: 0
> > 
> > test(s), Total: 1 test(s)
> > 
> > Name: projectroot Failed: 3 test(s), Passed: 59 
test(s), Skipped: 0
> > 
> > test(s), Total: 62 test(s)
> > 
> > * Failed: projectroot.autotests.bug313759
> > 
> > * Failed: projectroot.autotests.kateindenttest_testAda
> > 
> > * Failed: projectroot.autotests.kateindenttest_testPascal
> > 
> > Name: projectroot.autotests.src Failed: 0 test(s), 
Passed: 5
> > 
> > test(s), Skipped: 0 test(s), Total: 5 test(s)
> > 
> >  Cobertura Report
> >  
> >  Project Coverage Summary
> >  
> >  Name
> > 
> > Packages
> > Files
> > Classes
> > Lines
> > Conditionals
> > 
> > Cobertura Coverage Report
> > 79% (22/28)
> > 87% (260/298)
> > 87% (260/298)
> > 67% (32994/49195)
> > 49% (14791/30094)
> > 
> > Coverage Breakdown by Package
> > 
> >  Name
> > 
> > Files
> > Classes
> > Lines
> > Conditionals
> > 
> > autotests.src
> > 97% (37/38)
> > 97% (37/38)
> > 93% (4785/5127)
> > 49% (1812/3680)
> > 
> > autotests.src.vimode
> > 100% (9/9)
> > 100% (9/9)
> > 99% (5526/5568)
> > 58% (984/1708)
> > 
> > src.buffer
> > 88% (15/17)
> > 88% (15/17)
> > 89% (1677/1892)
> > 74% (1082/1472)
> > 
> > src.completion
> > 100% (11/11)
> > 100% (11/11)
> > 57% (1785/3131)
> > 42% (1008/2423)
> > 
> > src.completion.expandingtree
> > 100% (3/3)
> > 100% (3/3)
> > 40% (182/457)
> > 21% (73/340)
> > 
> > src.dialogs
> > 0% (0/4)
> > 0% (0/4)
> > 0% (0/858)
> > 0% (0/180)
> > 
> > src.document
> > 100% (4/4)
> > 100% (4/4)
> > 61% (1934/3176)
> > 48% (1417/2977)
> > 
> > src.export
> > 0% (0/4)
> > 0% (0/4)
> > 0% (0/121)
> > 0% (0/156)
> > 
> > src.include.ktexteditor
> > 93% (14/15)
> > 93% (14/15)
> > 84% (187/222)
> > 55% (125/226)
> > 
> > src.inputmode
> > 100% (8/8)
> > 100% (8/8)
> > 63% (192/304)
> > 51% (39/77)
> > 
> > src.mode
> > 88% (7/8)
> > 88% (7/8)
> > 36% (378/1050)
> > 16% (146/897)
> > 
> > src.part
> > 0% (0/1)
> > 0% (0/1)
> > 0% (0/7)
> > 100% (0/0)
> 

D29397: KPreviewJob : Support for DeviceRatioPixel

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @meven Have you already got in contact with the other users/maintainers of he 
thumnbail cache spec about the idea to extend it with support for high dpi? If 
not, please consider to do so, so things will also work cross-toolkit/platforms 
in the future there, by being based on an agreed & formalized specification. 
Not being involved here or having full understanding of the topic, but I would 
guess your approach with the separate x2 should run into "make sense" 
responses, so the additional effort might be low for the gain of being based on 
an official spec.
  
  This would be discussed on 
https://lists.freedesktop.org/mailman/listinfo/xdg, possible best by cc:ing 
other potential parties interested in highdpi thumbnails, would need to be 
researched, possibly some Dolphin contributors know their counterparts in 
non-KDE FLOSS projects

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 52 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/52/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 25 May 2020 09:17:20 +
 Build duration:
1 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> meven wrote in device.h:99
> Well I have to make this virtual it seems so this call is dynamically 
> dispatched by `return_SOLID_CALL(Ifaces::Device *, d->backendObject(), 
> QString(), displayName());`
> I assumed this would work based on my review comments rather than on tests :/

Woops... my bad, indeed didn't notice it wasn't marked virtual anymore. It has 
to be indeed.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure, ngraham
Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven added a comment.


  The patch currently does not work.

INLINE COMMENTS

> ervin wrote in device.h:99
> Why not have a default implementation which returns descriptions()? This 
> would make for a less intrusive patch (I think it's in part what @bruns 
> suggested earlier).

Well I have to make this virtual it seems so this call is dynamically 
dispatched by `return_SOLID_CALL(Ifaces::Device *, d->backendObject(), 
QString(), displayName());`
I assumed this would work based on my review comments rather than on tests :/

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure, ngraham
Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

[Méven Car]

meven retitled this revision from "Places: For mounted volume display mount 
points instead of description" to "Places: Use Solid::Device::DisplayName for 
DisplayRole".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/27/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 25 May 2020 06:06:34 +
 Build duration:
4 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D26113: Places: For mounted volume display mount points instead of description

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:cdbfb3e799c7: Add a QString Solid::Device::displayName, 
used in Fstab Device for network… (authored by meven).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28590?vs=83128=83146

REVISION DETAIL
  https://phabricator.kde.org/D28590

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/frontend/device.cpp
  src/solid/devices/frontend/device.h
  src/solid/devices/ifaces/device.cpp
  src/solid/devices/ifaces/device.h

To: meven, #frameworks, bruns, sitter, dfaure, ngraham
Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns