Re: Notice of withdrawal of CI services: KDevelop and KDE Connect

[Ömer Fadıl USTA]

How about if we add a config flag for our ci machines and configure cmake
of these 2 project's test to ignore building/adding those problematic tests
whenever it saw those flags?
I don't know why but it doesn't sound correct to me to kill the ci build of
any project because of these types of problems.

Ömer Fadıl Usta
PGP key : 0xfd11561976b1690b
about.me/omerusta


Ben Cooksley , 16 Haz 2021 Çar, 21:57 tarihinde şunu
yazdı:

> On Thu, Jun 17, 2021 at 6:41 AM Nate Graham  wrote:
>
>> This kind of problem will be generically solved for everyone once we get
>> GitLab's pre-commit CI, which can block merging of MRs until the
>> failures are resolved--so they actually *will* be resolved. How soon can
>> we get that finally rolled out across KDE?
>>
>
> I'm afraid GitLab CI wouldn't have prevented this from occurring - because
> the pre-merge CI still needs to run somewhere.
> The problem here is that the simple act of running the build
> degrades/breaks the builders for everyone else.
>
> In terms of a timeline on this, once I have the situation with Nextcloud
> sorted out (which had to be prioritised as the version we're on goes out of
> support in the next few months) we'll hopefully be able to work on GitLab
> CI (assuming another vendor of ours doesn't go and pull another major
> dependency bump stunt like Nextcloud did)
>
>
>> Until that happens, this sort of problem will recur infinitely because
>> people will continue to miss or ignore CI failures because they send
>> emails after merge/commit rather than before, and are formatted
>> semi-incomprehensibly.
>>
>> Nate
>>
>
> Regards,
> Ben
>
>
>>
>>
>> On 6/16/21 12:28 PM, Ben Cooksley wrote:
>> > Hi all,
>> >
>> > The following is notice that I intend to withdraw CI services from the
>> > following two KDE projects due to faults in their code or build system
>> > which are having a significant adverse impact on the CI system and
>> > negatively impacting on other projects:
>> >
>> > - KDevelop
>> > - KDE Connect
>> >
>> > This withdrawal will be applied to all platforms.
>> >
>> > In the case of KDevelop, it has a series of unit tests which on FreeBSD
>> > cause gdb to hang and consume an entire CPU core indefinitely. This
>> > slows down builds for all other projects using that CI server, and also
>> > prevents KWin tests from proceeding - completely blocking it's jobs.
>> > This fault is in the debuggee_slow family of tests.
>> >
>> > As this issue has persisted for some time now despite being mentioned,
>> I
>> > require that the family of tests in question be disabled across all
>> > platforms.
>> >
>> > In the case of KDE Connect, as part of it's configure process it runs
>> an
>> > external command that results in dbus-daemon being launched. This
>> > process persists following the build and would only be cleaned up by
>> our
>> > tooling that runs tests. Should the compilation fail (as it does
>> > currently) it will result in the CI builder being broken - which is why
>> > we have had so many Windows builds fail lately.
>> >
>> > As this is an issue that has occurred previously, I require that the
>> > configure time check which is launching dbus-daemon to be expunged from
>> > KDE Connect.
>> >
>> > As a reminder to all projects, running commands that interact with
>> > dbus-daemon or kdeinit is not permitted during configure or build time.
>> >
>> > Regards,
>> > Ben Cooksley
>> > KDE Sysadmin
>>
>

T14471: Make Qt 5.15.0 to 5.15.2 for frameworks

[Ömer Fadıl Usta]

usta added a subscriber: ahmadsamir.
usta added a comment.


  @ahmadsamir

TASK DETAIL
  https://phabricator.kde.org/T14471

To: usta
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, usta, LeGast00n, cblack, 
michaelh, ngraham, bruns

T14471: Make Qt 5.15.0 to 5.15.2 for frameworks

[Ömer Fadıl Usta]

usta created this task.
usta triaged this task as "Normal" priority.
usta added a project: Frameworks.

TASK DESCRIPTION
  According to Repology[1] all distros who supply qt5.15.x already using 5.15.2 
  and because of API changes on 5.15.2, i believe it will be much
  better to switch 5.15.0 -> 5.15.2 to make things easier such as usage of 
QString append(QStringView str) [2][3]
  
  [1] https://repology.org/project/qt/badges
  [2] https://invent.kde.org/pim/kpimtextedit/-/merge_requests/11#note_233246
  [3] https://doc.qt.io/qt-5/qstring.html#append-5

TASK DETAIL
  https://phabricator.kde.org/T14471

To: usta
Cc: kde-frameworks-devel, usta, LeGast00n, cblack, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta added inline comments.

INLINE COMMENTS

> jobtest.cpp:465
> +{
> +QString writeTest = dir + "/fsXattrTestFile";
> +createTestFile(writeTest);

const ?

> file_unix.cpp:1517
>  }
>  acl = acl_from_text(ACLString.toLatin1().constData());
>  if (acl_valid(acl) == 0) { // let's be safe

isnt this ignoring acl_from_mode part ? I mean not sure but i think we need to 
check if it is nullptr or not before assigning it otherwise we will ignore the 
acl_from_mode part.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta added a comment.


  is there a KDE policy about usage of qCWarning( , qCDebug( ?
  Because afaik debug one can be ignored by system and some of those might be 
important to show to user to see
  So for example  this one looks like a warning instead of a debug info for me 
( but not sure what your opinions are) :
  qCDebug(KIO_FILE) << "libc failed to extract list of xattr from file";
   or this one :
   qCDebug(KIO_FILE) << "cant copy Extended attributes";
  other than those for me it looks ok

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28452: Fix baloo compile

[Ömer Fadıl Usta]

usta closed this revision.
usta added a comment.


  I still need to learn how to use arc land properly

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28452

To: usta, #baloo, ngraham, cblack
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28452: Fix baloo compile

[Ömer Fadıl Usta]

usta added a commit: R293:ac7f7df21366: Fix compile.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28452

To: usta, #baloo, ngraham, cblack
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28452: Fix baloo compile

[Ömer Fadıl Usta]

usta added a reviewer: ngraham.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28452

To: usta, #baloo, ngraham
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28452: Fix baloo compile

[Ömer Fadıl Usta]

usta edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28452

To: usta, #baloo
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28452: Fix baloo compile

[Ömer Fadıl Usta]

usta added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28452

To: usta, #baloo
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28452: Fix baloo compile

[Ömer Fadıl Usta]

usta created this revision.
usta added a project: Baloo.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
usta requested review of this revision.

REVISION SUMMARY
  __FUNC__ => __func__

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28452

AFFECTED FILES
  src/lib/searchstore.cpp

To: usta
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta requested changes to this revision.
usta added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jobtest.cpp:531
> +
> +QProcess xattRreader;
> +xattRreader.setProcessChannelMode(QProcess::MergedChannels);

typo :) xattRreader => xattrReader

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta requested changes to this revision.
usta added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jobtest.cpp:500
> +
> +QProcess xattrwriter;
> +xattrwriter.setProcessChannelMode(QProcess::MergedChannels);

aren't we using camelcase rules for variables in kde ? is so xattrwriter => 
xattrWriter

> jobtest.cpp:531
> +
> +QProcess xattrreader;
> +xattrreader.setProcessChannelMode(QProcess::MergedChannels);

camelCase ?  xattrreader => xattrReader

> file_unix.cpp:167
> +// Linux and MacOS return = list of null terminated string, each string 
> = [data,'\0']
> +// BSD return = list of itens, each item prepended of 1 byte size = 
> [size, data]
> +

small typo in comment : itens => items

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28151: Autotest file showing wrong File path

[Ömer Fadıl Usta]

usta closed this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28151

To: usta, meven, aacid, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

[Ömer Fadıl Usta]

usta added a commit: R237:67630e49d69c: Autotest file showing wrong File path.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28151

To: usta, meven, aacid, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

[Ömer Fadıl Usta]

usta added a reviewer: hchain.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28151

To: usta, meven, aacid, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

[Ömer Fadıl Usta]

usta created this revision.
usta added a reviewer: meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
usta requested review of this revision.

REVISION SUMMARY
  It look like this is a trivial typo but causing tests doesnt work correctly

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28151

AFFECTED FILES
  autotests/kconfig_compiler/test_param_minmax.kcfgc
  autotests/kconfig_compiler/test_properties_minmax.kcfgc

To: usta, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta requested changes to this revision.
usta added inline comments.

INLINE COMMENTS

> cochise wrote in jobtest.cpp:573
> {set,get}fattr = linux command
> {set.get}extattr = BSD command
> {set.get}xtattr = MacOS command
> 
> This command could have a little more consistency...

but you have written it as with single T , i think it must be double ( TT )

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta added inline comments.

INLINE COMMENTS

> jobtest.cpp:573
> +} else if (command == "setextattr") {
> +command = "getextatr";
> +}

I am not sure but it looks like there is a typo here
getextatr --->
getextattr
but not sure , can someone make a comment about this ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D27794: Fix symlink problem because of using relative path instead of full path

[Ömer Fadıl Usta]

usta created this revision.
usta added reviewers: ngraham, kossebau, ndavis.
usta added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
usta requested review of this revision.

REVISION SUMMARY
  generate script was trying to read the source of symlinked files base but it 
was used as a relative path which causes problems for broken new symlinks.
  This fix is getting the full path of symlink so newly created files use 
correct path instead of a broken symlink also this fixes autotests (obvious 
because that problem will be solved :) )

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27794

AFFECTED FILES
  generate-24px-versions.sh

To: usta, ngraham, kossebau, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Ömer Fadıl Usta]

usta added a comment.


  Freebsd side broken again :
  00:31:45  
./build/icons-dark/generated/devices/24/network-wired-activated.svg:14: parser 
error : Opening and ending tag mismatch: g line 8 and svg
  00:31:45  
  00:31:45^
  00:31:45  
./build/icons-dark/generated/devices/24/network-wired-activated.svg:15: parser 
error : EndTag: 'https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: usta, davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D27412: Port away from deprecated API on Qt 5.15.0

[Ömer Fadıl Usta]

usta added a comment.


  isnt this also needs #include 

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27412

To: apol, #frameworks, davidedmundson, sitter
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24400: Make hours qint64

[Ömer Fadıl Usta]

usta added inline comments.

INLINE COMMENTS

> kformatprivate.cpp:339
>  
> -int hours = ms / MSecsInHour;
> +const qint64 hours = ms / MSecsInHour;
>  ms = ms % MSecsInHour;

why dont we use quint64  in here ?

> kformatprivate.cpp:470
>  quint64 ms = msecs;
>  int days = ms / MSecsInDay;
>  ms = ms % (MSecsInDay);

same problem here ( quint64 days and hours ) ( maybe not days but hours )
also days, hours , minutes  and seconds also can be conts in here too

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24400

To: aacid
Cc: usta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[Ömer Fadıl Usta]

usta added a comment.


  In D21919#482275 , @ngraham wrote:
  
  > Maybe we should also consider renaming the KCM to be "Gaming Controller" 
since I don't know how many people are actually using standalone joysticks 
anymore. I remember that those were all the rage in the 90s, but probably these 
days people are just using their XBox controllers or whatever.
  
  
  +1 , at least GamePads or Game Controllers

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D8332: Added baloo urls into places model

[Ömer Fadıl Usta]

usta added inline comments.

INLINE COMMENTS

> kfileplacesview.cpp:1348
> +searchUrl = searchUrlForType(QStringLiteral("Video"));
> +}
> +

won't be nice to add an else statement? (for the sake of searchUrl )

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8332

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, 
ervin, mlaurent
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8332: Added baloo urls into places model

[Ömer Fadıl Usta]

usta added inline comments.

INLINE COMMENTS

> kfileplacesmodel.cpp:151
>  
> +// if baloo is enabled, add new ulrs even if the bookmark file is not 
> empty
> +if (d->fileIndexingEnabled &&

typo: ulrs

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8332

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks

Re: Review Request 119349: typo in signal names ( upowermanager )

[Ömer Fadıl Usta]

 On July 18, 2014, 12:50 p.m., Lukáš Tinkl wrote:
  Hmm, my upower (and also the newer one) has DeviceAdded/Removed signals... 
  how did you come to this conclusion? Have you done any testing?

Yes you are right, after making test the result is same. Still getting no such 
Signal erros in my .xsesssion-errors file. I will discard this patch
but there is a problem about that signal


- Ömer Fadıl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119349/#review62638
---


On July 18, 2014, 8:31 a.m., Ömer Fadıl Usta wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119349/
 ---
 
 (Updated July 18, 2014, 8:31 a.m.)
 
 
 Review request for KDE Frameworks and Solid.
 
 
 Repository: solid
 
 
 Description
 ---
 
 There were some typos for signals in upowermanager such as ;
 DeviceAdded   --   deviceAdded
 DeviceRemoved  --  deviceRemoved
 
 
 Diffs
 -
 
   src/solid/devices/backends/upower/upowermanager.cpp 53c8580 
 
 Diff: https://git.reviewboard.kde.org/r/119349/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ömer Fadıl Usta
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119349: typo in signal names ( upowermanager )

[Ömer Fadıl Usta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119349/
---

(Updated July 18, 2014, 12:58 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Solid.


Repository: solid


Description
---

There were some typos for signals in upowermanager such as ;
DeviceAdded   --   deviceAdded
DeviceRemoved  --  deviceRemoved


Diffs
-

  src/solid/devices/backends/upower/upowermanager.cpp 53c8580 

Diff: https://git.reviewboard.kde.org/r/119349/diff/


Testing
---


Thanks,

Ömer Fadıl Usta

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119349: typo in signal names ( upowermanager )

[Ömer Fadıl Usta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119349/
---

(Updated July 18, 2014, 8:31 a.m.)


Review request for KDE Frameworks and Solid.


Repository: solid


Description
---

There were some typos for signals in upowermanager such as ;
DeviceAdded   --   deviceAdded
DeviceRemoved  --  deviceRemoved


Diffs
-

  src/solid/devices/backends/upower/upowermanager.cpp 53c8580 

Diff: https://git.reviewboard.kde.org/r/119349/diff/


Testing
---


Thanks,

Ömer Fadıl Usta

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel