D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

[Alexander Volkov]

volkov added a comment.


  Why not add support for `QPlatformTheme::FontDialog` in 
`KdePlatformTheme::createPlatformDialogHelper()`?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28774

To: ahmadsamir, #frameworks, dfaure, cfeck
Cc: volkov, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

[Alexander Volkov]

volkov abandoned this revision.
volkov added a comment.


  Moved to https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/7

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D22737

To: volkov, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D16612: Connect slots explicitly instead of using auto-connections

[Alexander Volkov]

volkov abandoned this revision.
volkov added a comment.


  Moved to https://invent.kde.org/frameworks/kio/-/merge_requests/76

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16612

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D16226: Reformat library code using kde-dev-scripts/astyle-kdelibs

[Alexander Volkov]

volkov abandoned this revision.
volkov added a comment.


  Outdated and no chance it will be reviewed.

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D16226

To: volkov, #frameworks

D16251: qca-gcrypt: Add support for HKDF

[Alexander Volkov]

volkov abandoned this revision.
volkov added a comment.


  Moved to https://invent.kde.org/libraries/qca/-/merge_requests/35

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D16251

To: volkov, dfaure, iromanov, #frameworks

D26648: Improved quality of JPEG thumbnails

[Alexander Volkov]

volkov added a comment.


  `imageReader.setQuality(0);` was added in 
https://phabricator.kde.org/R320:c249f8547f2d1913e0570d78a0240c5f8865c336 when 
I ported `JpegCreator` to `QImageReader`.
  But as I mentioned there, it doesn't really influence on the decoding speed, 
and it was only needed to preserve the old behavior as much as possible.
  This change looks good to me, +1.

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26294: Allow to load widget based KCMs from kcms subdir

[Alexander Volkov]

volkov added a dependent revision: D26244: Install all kcm plugins into kcms 
subdir.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26294

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

[Alexander Volkov]

volkov updated this revision to Diff 72393.
volkov added a comment.


  change branch

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26294?vs=72392=72393

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26294

AFFECTED FILES
  src/kcmoduleloader.cpp

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26294

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REPOSITORY
  R295 KCMUtils

BRANCH
  xxx

REVISION DETAIL
  https://phabricator.kde.org/D26294

AFFECTED FILES
  src/kcmoduleloader.cpp

To: volkov
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

[Alexander Volkov]

volkov added a comment.


  Qt Core
  
> cat qt_lib_widgets.pri | grep depends
QT.widgets.depends = core gui

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D25397

To: volkov, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Alexander Volkov]

volkov added a comment.


  Fix for .pri: D25397 

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: volkov, rikmills, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

[Alexander Volkov]

volkov added a reviewer: aacid.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D25397

To: volkov, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  And fix dependencies in .pri file for KAuth.
  This commit amends 65db21c6fc5369ad498b959b08ab8de19b73c5c4 
.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25397

AFFECTED FILES
  src/CMakeLists.txt

To: volkov
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Alexander Volkov]

volkov added a comment.


  What about qmake?
  I came across the following error:
  
g++ -Wl,-z,relro -o ... /usr/lib/x86_64-linux-gnu/libQt5Gui.so 
/usr/lib/x86_64-linux-gnu/libKF5Auth.so 
/usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so 
/usr/lib/x86_64-linux-gnu/libQt5Core.so /usr/lib/x86_64-linux-gnu/libGL.so 
-lpthread   
/usr/bin/ld: ...: undefined reference to symbol '_ZN5KAuth11ActionReplyD1Ev'
/usr/bin/ld: //usr/lib/x86_64-linux-gnu/libKF5AuthCore.so.5: error adding 
symbols: DSO missing from command line

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: volkov, rikmills, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added a comment.


  It will require adding the following methods:
  
Action::setFileDescriptors()
Action::addFileDescriptor()
Action::fileDescriptors()
ActionReply::setFileDescriptors()
ActionReply::addFileDescriptor()
ActionReply::fileDescriptors()
  
  and
  
ExecuteJob::fileDescriptors()
ExecuteJob::newFileDescriptors()
  
  with the condition that for progress data they can be used only with direct 
signal-slot connections,
  because without `UnixFileDescriptor` we cannot guarantee the open state of 
file descriptors.
  It doesn't seem better than exposing this class.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added a comment.


  Without UnixFileDescriptor you could try to write
  
int fd = ...
Action action(...);
action.addArgument(QStringLiteral("fd"), fd);
  
  but then KAuth won't be able to detect that it'a file descriptor and will 
pass it to a helper as int.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added a comment.


  Yes, UnixFileDescriptor allows to use existing methods Action::setArguments() 
and ActionReply::setData().

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> aacid wrote in kauthunixfiledescriptor.h:33
> Does this class really need to be exported and its header installed?
> 
> Seems like this is implementation detail? Who would use this header?

It's needed to mark file descriptors in QVariantMap.
Usage example:

  ActionReply reply;
  QVariantMap data;
  auto variantFd = QVariant::fromValue(UnixFileDescriptor(saveFile.handle()));
  data.insert(QStringLiteral("fd"), variantFd);
  reply.setData(data);
  return reply;

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov edited the summary of this revision.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov updated this revision to Diff 66968.
volkov added a comment.


  moved dbus stuff to DBusHelperProxy

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24245?vs=66946=66968

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24245

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/kauth.h
  src/kauthunixfiledescriptor.cpp
  src/kauthunixfiledescriptor.h

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> aacid wrote in HelperProxy.cpp:25
> i don't think we should have dbus stuff in HelperProxy, dbus stuff should be 
> in DBusHelperProxy, no?

yes, thanks

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added a comment.


  yes, thanks

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24259: WIP: Save file directly if possible when root privileges are required

[Alexander Volkov]

volkov added a dependency: D24245: Add support for passing Unix file 
descriptors.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24259

To: volkov
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added a dependent revision: D24259: WIP: Save file directly if possible 
when root privileges are required.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24259: WIP: Save file directly if possible when root privileges are required

[Alexander Volkov]

volkov created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
volkov requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24259

AFFECTED FILES
  src/buffer/katesecuretextbuffer.cpp
  src/buffer/katesecuretextbuffer_p.h
  src/buffer/katetextbuffer.cpp
  src/buffer/org.kde.ktexteditor.katetextbuffer.actions

To: volkov
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov updated this revision to Diff 66946.
volkov added a comment.


  fix breaking API and ABI of KAuth::ActionReply

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24245?vs=66905=66946

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24245

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/HelperProxy.cpp
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/kauth.h
  src/kauthunixfiledescriptor.cpp
  src/kauthunixfiledescriptor.h

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov added a comment.


  DBus is an internal dependency for KAuth. With the wrapper users don't have 
to link with QtDBus.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

[Alexander Volkov]

volkov added a comment.
Herald added a subscriber: kde-frameworks-devel.


  Passing file descriptors with KAuth: D24245 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6709

To: chinmoyr, thiago, #frameworks, dfaure
Cc: kde-frameworks-devel, volkov, awilcox, dfaure, davidedmundson, 
elvisangelaccio, shortstheory, LeGast00n, GB_2, michaelh, ngraham, bruns

D5394: KAuth integration in document saving - vol. 2

[Alexander Volkov]

volkov added a comment.


  D24245  - support for passing Unix file 
descriptors in KAuth.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5394

To: martinkostolny, #ktexteditor, fvogt
Cc: kde-frameworks-devel, volkov, elvisangelaccio, aacid, ivan, lbeltrame, 
fvogt, apol, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, 
davidedmundson, palant, kwrite-devel, dfaure, LeGast00n, szutmael, GB_2, 
domson, michaelh, ngraham, bruns, demsking, head7, kfunk, sars

D24245: Add support for passing Unix file descriptors

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Introduce UnixFileDescriptor class, which holds a copy of a file
  descriptor. Actually it's a wrapper around QDBusUnixFileDescriptor.
  
  Currently arguments to/from a helper are passed as QVariantMap,
  encoded as QByteArray. To support passing of file descriptors,
  separate them into their own QVariantMap, and pass arguments as
  QVariantList consisting of the QByteArray blob of data arguments
  and the file descriptors map (HelperProxy::{un}packedArguments()).
  
  Remove operator<<(QDataStream &, const ActionReply &) and
  operator>>(QDataStream &, ActionReply &) as they don't make
  sense with file descriptors and used only internally in
  ActionReply::serialized() and ActionReply::deserialize()
  methods. Modify these methods to work with QVariantList
  instead of QByteArray blobs.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24245

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/HelperProxy.cpp
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/kauth.h
  src/kauthactionreply.cpp
  src/kauthactionreply.h
  src/kauthunixfiledescriptor.cpp
  src/kauthunixfiledescriptor.h

To: volkov
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D5394: KAuth integration in document saving - vol. 2

[Alexander Volkov]

volkov added a comment.
Herald added a project: Kate.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  Wouldn't it be better to avoid creation of a temporary file by opening an 
original file for writing in the helper and passing the file descriptor back to 
the main process?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5394

To: martinkostolny, #ktexteditor, fvogt
Cc: kde-frameworks-devel, volkov, elvisangelaccio, aacid, ivan, lbeltrame, 
fvogt, apol, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, 
davidedmundson, palant, kwrite-devel, dfaure, LeGast00n, szutmael, GB_2, 
domson, michaelh, ngraham, bruns, demsking, head7, kfunk, sars, #frameworks

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D22809

To: volkov, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

[Alexander Volkov]

volkov added a reviewer: broulik.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D22809

To: volkov, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  This restores commit 49f8718446322b1722822f99f6b9f3b975ea723e 
,
  that was reverted by mistake in commit
  20f7137145f6b6fb38d2c3dd01a8443b8315cf41 
.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22809

AFFECTED FILES
  src/kiconloader.cpp

To: volkov
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D6313: Support Icon Scale from Icon naming specification 0.13

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> broulik wrote in kiconloader.cpp:1368
> Dunno, probably oversight or forgotten to rebase..

Looks like a rebase: 
https://phabricator.kde.org/D6313?vs=31197=34779=ignore-most#toc

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: volkov, hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, 
kvermette, cfeck, davidedmundson, plasma-devel, LeGast00n, sbergeron, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> kiconloader.cpp:1368
>  
> -if (group >= 0 && group < KIconLoader::LastGroup) {
> +if (group >= 0) {
>  img = d->mpEffect.apply(img, group, state);

Why this line reverts D12002 ?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: volkov, hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, 
kvermette, cfeck, davidedmundson, plasma-devel, LeGast00n, sbergeron, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22737: xcb: Fix setStrut() for High-DPI scaling

[Alexander Volkov]

volkov updated this revision to Diff 62536.
volkov added a comment.


  fixed

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22737?vs=62531=62536

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22737

AFFECTED FILES
  src/platforms/xcb/kwindowsystem.cpp

To: volkov, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> apol wrote in kwindowsystem.cpp:75
> I don't think that it makes sense to multiply topLeft by dpr, since dpr is 
> local to the screen you're treating.
> 
> How have you tested this?

Only on a single screen. Thanks for notice.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D22737

To: volkov, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D22737

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  In addition to _NET_WM_STRUT setStrut() also sets _NET_WM_STRUT_PARTIAL,
  which requires screen's geometry in device pixels.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22737

AFFECTED FILES
  src/platforms/xcb/kwindowsystem.cpp

To: volkov
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

[Alexander Volkov]

volkov added a comment.


  I guess that there is a short period of time when UDisks daemon is in 
inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is 
removed for CD-ROM device, but the device's properties still have Optical=true.
  Adding "updateBackend(udi);" before "emit deviceAdded(udi);" gives Udisks 
time to become consistent.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham, apol
Cc: volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

[Alexander Volkov]

volkov added a comment.


  Looks like the bug is caused by removing the line "updateBackend(udi);"

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham, apol
Cc: volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

[Alexander Volkov]

volkov added a comment.


  This change causes a bug: when you eject a mounted CD from the applet, then 
CD-ROM tray closes immediately after ejecting.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham, apol
Cc: volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D16250: Use lambdas instead of std::bind()

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin, davidedmundson
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D16250: Use lambdas instead of std::bind()

[Alexander Volkov]

volkov added a comment.


  https://clang.llvm.org/extra/clang-tidy/checks/modernize-avoid-bind.html
  
  > std::bind can be hard to read and can result in larger object files and 
binaries due to type information that will not be produced by equivalent 
lambdas.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D16612: Connect slots explicitly instead of using auto-connections

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16612

To: volkov, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16612: Connect slots explicitly instead of using auto-connections

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Auto-connections is bad practice cause object renames break code
  and it can't be detected at compile time.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16612

AFFECTED FILES
  src/kcms/kio/cache.cpp
  src/kcms/kio/cache.h
  src/kcms/kio/kcookiesmanagement.cpp
  src/kcms/kio/kcookiesmanagement.h
  src/kcms/kio/kproxydlg.cpp
  src/kcms/kio/kproxydlg.h
  src/kcms/kio/useragentdlg.cpp
  src/kcms/kio/useragentdlg.h

To: volkov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16251: qca-gcrypt: Add support for HKDF

[Alexander Volkov]

volkov added reviewers: iromanov, Frameworks.

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D16251

To: volkov, dfaure, iromanov, #frameworks

D16250: Use lambdas instead of std::bind()

[Alexander Volkov]

volkov added a comment.


  @davidedmundson
  
  Lambdas are more readable.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D16250: Use lambdas instead of std::bind()

[Alexander Volkov]

volkov added a reviewer: KWin.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16250: Use lambdas instead of std::bind()

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16250

AFFECTED FILES
  src/server/idle_interface.cpp
  src/server/pointerconstraints_interface.cpp

To: volkov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15510: Introduce HKDF

[Alexander Volkov]

volkov added a comment.


  D16248 

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: bcooksley, dfaure

D16226: Reformat library code using kde-dev-scripts/astyle-kdelibs

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D16226

To: volkov, #frameworks

D15510: Introduce HKDF

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

D15510: Introduce HKDF

[Alexander Volkov]

volkov added a comment.


  BTW, should I create a review request to reformat code with astyle-kdelibs?

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

D15510: Introduce HKDF

[Alexander Volkov]

volkov updated this revision to Diff 43125.
volkov added a comment.


  more reinterpret_casts

REPOSITORY
  R486 QCA Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15510?vs=43123=43125

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15510

AFFECTED FILES
  include/QtCrypto/qca_basic.h
  include/QtCrypto/qcaprovider.h
  plugins/qca-botan/qca-botan.cpp
  plugins/qca-ossl/qca-ossl.cpp
  src/qca_basic.cpp
  unittest/kdfunittest/kdfunittest.cpp

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

D15510: Introduce HKDF

[Alexander Volkov]

volkov updated this revision to Diff 43123.
volkov added a comment.


  fixed

REPOSITORY
  R486 QCA Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15510?vs=41656=43123

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15510

AFFECTED FILES
  include/QtCrypto/qca_basic.h
  include/QtCrypto/qcaprovider.h
  plugins/qca-botan/qca-botan.cpp
  plugins/qca-ossl/qca-ossl.cpp
  src/qca_basic.cpp
  unittest/kdfunittest/kdfunittest.cpp

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

D15510: Introduce HKDF

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> dfaure wrote in qca-botan.cpp:250
> override?

it still supports build with Qt 4 and without C++ 11

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

D15510: Introduce HKDF

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks

D15420: Intialize m_lastPosition

[Alexander Volkov]

volkov accepted this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15420

To: jtamate, #ktexteditor, cullmann, volkov
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D12016: [ktexteditor] much faster positionFromCursor

[Alexander Volkov]

volkov added a comment.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.


  I get the following warning from valgrind because of this change:
  
==3621== Conditional jump or move depends on uninitialised value(s)
==3621==at 0x4FF3605: 
KateViewAccessible::positionFromCursor(KateViewInternal*, KTextEditor::Cursor 
const&) const (kateviewaccessible.h:201)
==3621==by 0x4FE41CA: 
KateViewInternal::documentTextInserted(KTextEditor::Document*, 
KTextEditor::Range const&) (kateviewinternal.cpp:3830)
==3621==by 0x967762A: call (qobjectdefs_impl.h:376)
==3621==by 0x967762A: QMetaObject::activate(QObject*, int, int, void**) 
(qobject.cpp:3754)
==3621==by 0x50C25E6: 
KTextEditor::DocumentPrivate::textInserted(KTextEditor::Document*, 
KTextEditor::Range const&) (moc_katedocument_6APBFLF6VF33HC.cpp:985)
==3621==by 0x4F498DE: KTextEditor::DocumentPrivate::editInsertText(int, 
int, QString const&) (katedocument.cpp:1235)
==3621==by 0x4F4DF67: 
KTextEditor::DocumentPrivate::insertText(KTextEditor::Cursor const&, QString 
const&, bool) (katedocument.cpp:780)
==3621==by 0x4F51838: 
KTextEditor::DocumentPrivate::typeChars(KTextEditor::ViewPrivate*, QString 
const&) (katedocument.cpp:3024)
==3621==by 0x4FE9BF4: KateViewInternal::keyPressEvent(QKeyEvent*) 
(kateviewinternal.cpp:2522)
==3621==by 0x4FF1F12: KateViewInternal::eventFilter(QObject*, QEvent*) 
(kateviewinternal.cpp:2370)
==3621==by 0x96493EC: 
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) 
(qcoreapplication.cpp:1174)
==3621==by 0x8284834: QApplicationPrivate::notify_helper(QObject*, 
QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x828D30E: QApplication::notify(QObject*, QEvent*) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==  Uninitialised value was created by a heap allocation
==3621==at 0x4C2C25F: operator new(unsigned long) (in 
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==3621==by 0x4FE3EF0: accessibleInterfaceFactory(QString const&, 
QObject*) (kateviewaccessible.h:288)
==3621==by 0x8A70D2C: QAccessible::queryAccessibleInterface(QObject*) 
(in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.0)
==3621==by 0x8A7172E: QAccessibleEvent::accessibleInterface() const (in 
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.0)
==3621==by 0x8A71BFC: 
QAccessible::updateAccessibility(QAccessibleEvent*) (in 
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.0)
==3621==by 0x82C0A72: QWidgetPrivate::show_helper() (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C3CC4: QWidget::setVisible(bool) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C0957: QWidgetPrivate::showChildren(bool) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C09DE: QWidgetPrivate::show_helper() (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C0946: QWidgetPrivate::showChildren(bool) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C09DE: QWidgetPrivate::show_helper() (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C3CC4: QWidget::setVisible(bool) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

To: jtamate, #kate, cullmann, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, volkov, anthonyfieroni, mwolff, brauch, 
cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, 
dhaumann

D15317: trash: Fix directorysizes cache parsing

[Alexander Volkov]

volkov added a comment.


  It should fix the bugs:
  https://bugs.kde.org/show_bug.cgi?id=331707
  https://bugs.kde.org/show_bug.cgi?id=386460

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15317

To: volkov, #frameworks, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15317: trash: Fix directorysizes cache parsing

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15317

To: volkov, #frameworks, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15317: trash: Fix directorysizes cache parsing

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Entries in this file have the following format:
  [size] [mtime] [percent-encoded-directory-name]
  , and TrashSizeCache::add() writes them correctly,
  but TrashSizeCache::calculateSize() reads [mtime]
  as [size] and vice versa.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15317

AFFECTED FILES
  src/ioslaves/trash/trashsizecache.cpp

To: volkov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15317: trash: Fix directorysizes cache parsing

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15317

To: volkov, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14732: Actually allow to set the refresh rate for device statistics

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D14732

To: volkov, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14732: Actually allow to set the refresh rate for device statistics

[Alexander Volkov]

volkov added reviewers: Frameworks, jgrulich.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D14732

To: volkov, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14732: Actually allow to set the refresh rate for device statistics

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Set the DBus property of the NetworkManager, not the internal
  property that doesn't affect anything.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14732

AFFECTED FILES
  src/devicestatistics.cpp

To: volkov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D9794: Provide access to data returned by helper even on error replies

[Alexander Volkov]

volkov added a comment.


  The error text is nonlocalized because a helper doesn't know a locale of a 
user process.
  With this change the helper may return data that can be composed into a 
translated message in the user process.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D9794

To: volkov, #frameworks
Cc: kde-frameworks-devel, apol, #frameworks, michaelh, ngraham, bruns

D9794: Provide access to data returned by helper even on error replies

[Alexander Volkov]

volkov added a comment.


  ping

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D9794

To: volkov, #frameworks
Cc: #frameworks, michaelh, ngraham, bruns

D11786: Fix returning of data in the helper example

[Alexander Volkov]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R283:de225f87ae11: Fix returning of data in the helper example 
(authored by volkov).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11786?vs=30857=31812

REVISION DETAIL
  https://phabricator.kde.org/D11786

AFFECTED FILES
  examples/helper.cpp
  src/kauthactionreply.h

To: volkov, #frameworks
Cc: #frameworks, michaelh, ngraham, bruns

D11786: Fix returning of data in the helper example

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D11786

To: volkov, #frameworks
Cc: #frameworks, michaelh, ngraham

D11786: Fix returning of data in the helper example

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
volkov requested review of this revision.

REVISION SUMMARY
  ActionReply::data() returns a value, not a reference, so its
  modifications will be lost. Use ActionReply::addData() instead.
  Also update the documentation.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11786

AFFECTED FILES
  examples/helper.cpp
  src/kauthactionreply.h

To: volkov
Cc: #frameworks, michaelh, ngraham

D9794: Provide access to data returned by helper even on error replies

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D9794

To: volkov, #frameworks
Cc: #frameworks

D9794: Provide access to data returned by helper even on error replies

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
volkov requested review of this revision.

REVISION SUMMARY
  Helper may provide an additional information about an error in it.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9794

AFFECTED FILES
  src/kauthexecutejob.cpp

To: volkov
Cc: #frameworks

D9348: Handle positions of LMB clicks on legacy systray icons

[Alexander Volkov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:b5e43439386e: Handle positions of LMB clicks on legacy 
systray icons (authored by volkov).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9348?vs=23963=24159

REVISION DETAIL
  https://phabricator.kde.org/D9348

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: volkov, #frameworks, mck182
Cc: ngraham, alexeymin, #frameworks

D9348: Handle positions of LMB clicks on legacy systray icons

[Alexander Volkov]

volkov added a comment.


  It can be tested on the latest kmix.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D9348

To: volkov, #frameworks, mck182
Cc: ngraham, alexeymin, #frameworks

D9348: Handle positions of LMB clicks on legacy systray icons

[Alexander Volkov]

volkov added a reviewer: mck182.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D9348

To: volkov, #frameworks, mck182
Cc: ngraham, alexeymin, #frameworks

D9348: Handle positions of LMB clicks on legacy systray icons

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D9348

To: volkov, #frameworks
Cc: #frameworks

D9348: Handle positions of LMB clicks on legacy systray icons

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9348

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: volkov
Cc: #frameworks

D9224: Deprecate KDesktopFile::sortOrder()

[Alexander Volkov]

volkov updated this revision to Diff 23553.
volkov added a comment.


  add 'since 5.42'

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9224?vs=23552=23553

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9224

AFFECTED FILES
  autotests/kdesktopfiletest.cpp
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h

To: volkov, dfaure, #frameworks
Cc: #frameworks

D9224: Deprecate KDesktopFile::sortOrder()

[Alexander Volkov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:a69d8e562b6e: Deprecate KDesktopFile::sortOrder() 
(authored by volkov).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9224?vs=23553=23554

REVISION DETAIL
  https://phabricator.kde.org/D9224

AFFECTED FILES
  autotests/kdesktopfiletest.cpp
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h

To: volkov, dfaure, #frameworks
Cc: #frameworks

D9224: Deprecate KDesktopFile::sortOrder()

[Alexander Volkov]

volkov updated this revision to Diff 23552.
volkov added a comment.


  make the test buildable with KDE_NO_DEPRECATED

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9224?vs=23551=23552

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9224

AFFECTED FILES
  autotests/kdesktopfiletest.cpp
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h

To: volkov, dfaure, #frameworks
Cc: #frameworks

D9224: Deprecate KDesktopFile::sortOrder()

[Alexander Volkov]

volkov added reviewers: dfaure, Frameworks.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D9224

To: volkov, dfaure, #frameworks
Cc: #frameworks

D9224: Deprecate KDesktopFile::sortOrder()

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The SortOrder key is deprecated by the Desktop Entry Specification:
  https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9224

AFFECTED FILES
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h

To: volkov
Cc: #frameworks

D8689: Fix the result of KDesktopFile::sortOrder()

[Alexander Volkov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:d328dd6ac725: Fix the result of KDesktopFile::sortOrder() 
(authored by volkov).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8689?vs=22018=23548

REVISION DETAIL
  https://phabricator.kde.org/D8689

AFFECTED FILES
  autotests/kdesktopfiletest.cpp
  autotests/kdesktopfiletest.h
  src/core/kdesktopfile.cpp

To: volkov, #frameworks, dfaure
Cc: dfaure, #frameworks

D8689: Fix the result of KDesktopFile::sortOrder()

[Alexander Volkov]

volkov added a comment.


  Well, at first I was planning to use this method in my project, but since 
it's not used in KDE
  and besides the SortOrder key is deprecated, I guess that 
KDesktopFile::sortOrder() should be
  marked as deprecated.
  The question is whether to fix it first?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8689

To: volkov, #frameworks
Cc: dfaure, #frameworks

D8689: Fix the result of KDesktopFile::sortOrder()

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8689

To: volkov, #frameworks
Cc: #frameworks

D8689: Fix the result of KDesktopFile::sortOrder()

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  KDesktopFile::sortOrder() returns the value of SortOrder key
  as a string whithout parsing it as a list.
  But according to Desktop Entry Specification
  
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
  it's type is "string(s)", i.e. the same type as the type of
  Actions and MimeType keys, and thus it should be read the same way.

REPOSITORY
  R237 KConfig

BRANCH
  fix-sort-order

REVISION DETAIL
  https://phabricator.kde.org/D8689

AFFECTED FILES
  autotests/kdesktopfiletest.cpp
  autotests/kdesktopfiletest.h
  src/core/kdesktopfile.cpp

To: volkov
Cc: #frameworks

D8590: KPageListView: Update width on font change

[Alexander Volkov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:525cf0666bc1: KPageListView: Update width on font change 
(authored by volkov).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8590?vs=21690=22016

REVISION DETAIL
  https://phabricator.kde.org/D8590

AFFECTED FILES
  src/kpageview_p.cpp
  src/kpageview_p.h

To: volkov, cfeck, wojnilowicz, dfaure, rkflx, broulik
Cc: #frameworks

D7787: Set KPageListView width properly

[Alexander Volkov]

volkov added a comment.


  Could you try to test it without + 5 and with the following change applied?
  https://phabricator.kde.org/D8590 ?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7787

To: wojnilowicz, #frameworks
Cc: volkov, cfeck, tbaumgart, #kmymoney

D8590: KPageListView: Update width on font change

[Alexander Volkov]

volkov added a reviewer: wojnilowicz.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8590

To: volkov, cfeck, wojnilowicz
Cc: #frameworks

D8590: KPageListView: Update width on font change

[Alexander Volkov]

volkov added a reviewer: cfeck.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8590

To: volkov, cfeck
Cc: #frameworks

D8590: KPageListView: Update width on font change

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  In particular its font can be changed by Breeze style that
  modifies bold fonts to regular when it polishes list views.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  KPageListView-updateWidth

REVISION DETAIL
  https://phabricator.kde.org/D8590

AFFECTED FILES
  src/kpageview_p.cpp
  src/kpageview_p.h

To: volkov
Cc: #frameworks

Re: Review Request 129857: Remove unused jp2.desktop

[Alexander Volkov]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129857/
---

(Updated Jan. 20, 2017, 2:22 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Alex Merry.


Repository: kimageformats


Description
---

The corresponding JPEG-2000 plugin was removed by
e5fce91de6ef72f15c7d31b16b2494f534c7157c.


Diffs
-

  src/imageformats/jp2.desktop 3d673c61edfe5624d0821697b5e9edc2d3468112 

Diff: https://git.reviewboard.kde.org/r/129857/diff/


Testing
---


Thanks,

Alexander Volkov

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

[Alexander Volkov]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/
---

(Updated Jan. 17, 2017, 4:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Changes
---

Submitted with commit 243626c27f3f27db3ec6c94f5de1e6751b56fa18 by Alexander 
Volkov to branch master.


Bugs: 286260
https://bugs.kde.org/show_bug.cgi?id=286260


Repository: kwidgetsaddons


Description
---

If the font is missing, then try to find the nearest font
family instead of just selecting the first family in the
list.

BUG: 286260


Diffs
-

  src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 

Diff: https://git.reviewboard.kde.org/r/129809/diff/


Testing
---


Thanks,

Alexander Volkov

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

[Alexander Volkov]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/
---

(Updated Jan. 16, 2017, 6:48 p.m.)


Review request for KDE Frameworks and Christoph Feck.


Bugs: 286260
https://bugs.kde.org/show_bug.cgi?id=286260


Repository: kwidgetsaddons


Description
---

If the font is missing, then try to find the nearest font
family instead of just selecting the first family in the
list.

BUG: 286260


Diffs (updated)
-

  src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 

Diff: https://git.reviewboard.kde.org/r/129809/diff/


Testing
---


Thanks,

Alexander Volkov

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

[Alexander Volkov]

> On Jan. 12, 2017, 9:08 p.m., Christoph Feck wrote:
> > src/kfontrequester.cpp, line 53
> > <https://git.reviewboard.kde.org/r/129809/diff/1/?file=488949#file488949line53>
> >
> > Please check if it is possible to use QFont::lastResortFamily() or 
> > QFont::lastResortFont().
> 
> Alexander Volkov wrote:
> As I can see in the Qt 5 code, lastResortFamily() returns hard-coded 
> "helvetica" and lastResortFont() aborts the app by qFatal()
> 
> Christoph Feck wrote:
> ouch, that's not according to the documentation. Let's hope nobody 
> notices we are hard-coding another font name.

well, lastResortFamily() seems to be a better choice than hardcoded "fixed"


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/#review101970
-------


On Jan. 13, 2017, 12:45 p.m., Alexander Volkov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129809/
> ---
> 
> (Updated Jan. 13, 2017, 12:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 286260
> https://bugs.kde.org/show_bug.cgi?id=286260
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If the font is missing, then try to find the nearest font
> family instead of just selecting the first family in the
> list.
> 
> BUG: 286260
> 
> 
> Diffs
> -
> 
>   src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 
> 
> Diff: https://git.reviewboard.kde.org/r/129809/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Volkov
> 
>

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

[Alexander Volkov]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/
---

(Updated Jan. 13, 2017, 12:45 p.m.)


Review request for KDE Frameworks and Christoph Feck.


Bugs: 286260
https://bugs.kde.org/show_bug.cgi?id=286260


Repository: kwidgetsaddons


Description
---

If the font is missing, then try to find the nearest font
family instead of just selecting the first family in the
list.

BUG: 286260


Diffs (updated)
-

  src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 

Diff: https://git.reviewboard.kde.org/r/129809/diff/


Testing
---


Thanks,

Alexander Volkov