D8705: Remove Qt5::Widgets as a dependency

[Andreas Sturmlechner]

asturmlechner added a comment.
Herald added a subscriber: kde-frameworks-devel.


  FYI, after
  
  
https://invent.kde.org/frameworks/kwindowsystem/-/commit/5cc5734b46cd3bcc2a35402718731cdae5000803
  and 
  
https://invent.kde.org/frameworks/kwindowsystem/-/commit/374a29075694f530d2d0673e33a166c836d02a84
  
  and fixing a handful of revdeps, Gentoo is shipping KF5WindowSystem >=5.82 
without Qt5::Widgets dependency.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D8705

To: apol, #frameworks, dfaure
Cc: kde-frameworks-devel, asturmlechner, graesslin, dfaure, anthonyfieroni, 
LeGast00n, cblack, michaelh, ngraham, bruns

D14967: Disable loading of translations for kformattest, which was not designed with translations

[Andreas Sturmlechner]

asturmlechner added a comment.


  Hm, I find myself disabling ever more tests because I get a report like 
kformattest when someone has translations installed. How does CI get over that?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14967

To: habacker, dfaure, aacid
Cc: asturmlechner, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

T11542: Remove KHTML

[Andreas Sturmlechner]

asturmlechner added a subtask: T13968: Port KTechlab away from KHTML.

TASK DETAIL
  https://phabricator.kde.org/T11542

To: asturmlechner
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, 
#frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, usta, 
asturmlechner, jucato, cfeck, cgiboudeaux, cullmann, vkrause, dfaure

T11542: Remove KHTML

[Andreas Sturmlechner]

asturmlechner added a subtask: T13967: Port Kopete away from KHTML.

TASK DETAIL
  https://phabricator.kde.org/T11542

To: asturmlechner
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, 
#frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, usta, 
asturmlechner, jucato, cfeck, cgiboudeaux, cullmann, vkrause, dfaure

D19338: New location for KNSRC files

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D19338#676682 , @kossebau wrote:
  
  > In D19338#676680 , 
@asturmlechner wrote:
  >
  > > Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into 
KDEInstallDirs?
  >
  >
  > On the other hand it makes sense that module-specific variables are 
provided by the CMake config file of the respective module. Which allows 
projects to use the module without having to use KDEInstallDirs, but e.g. 
GnuInstallDirs.
  
  
  That could be done with checking in KNewStuff if KDE_INSTALL_KNSRCDIR isn't 
already set, then provide a fallback value, right? Because right now it means 
just installing a .knsrc file into the right path requires KNewStuff.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19338

To: leinir, #knewstuff, apol, ngraham, fvogt
Cc: asturmlechner, kossebau, kde-frameworks-devel, #knewstuff, LeGast00n, 
cblack, michaelh, ZrenBot, ngraham, bruns

D19338: New location for KNSRC files

[Andreas Sturmlechner]

asturmlechner added a comment.


  Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into 
KDEInstallDirs?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19338

To: leinir, #knewstuff, apol, ngraham, fvogt
Cc: asturmlechner, kossebau, kde-frameworks-devel, #knewstuff, LeGast00n, 
cblack, michaelh, ZrenBot, ngraham, bruns

D17205: Build kio_nfs against standalone libtirpc

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:1029148d9ca7: Build kio_nfs against standalone libtirpc 
(authored by asturmlechner).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17205?vs=46374=76978#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17205?vs=46374=76978

REVISION DETAIL
  https://phabricator.kde.org/D17205

AFFECTED FILES
  CMakeLists.txt
  nfs/CMakeLists.txt

To: asturmlechner, #dolphin, dfaure, rdieter, sitter
Cc: meven, sitter, kde-frameworks-devel, cgiboudeaux, arojas, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D26306: Define more documentation search paths (also custom)

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D26306#585587 , @asturmlechner 
wrote:
  
  > Thanks for that, works for me!
  
  
  Correction, the tests seem to fail even though runtime is fine. See also 
https://bugs.gentoo.org/705340

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26306

To: ltoscano
Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, 
asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26596: Drop unused dependency

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:08b1eabe3f54: Drop unused dependency (authored by 
asturmlechner).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26596?vs=73318=73320

REVISION DETAIL
  https://phabricator.kde.org/D26596

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26597: Drop HAVE_X11 remnants

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D26597

To: asturmlechner, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26596: Drop unused dependency

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R252 Framework Integration

BRANCH
  unused-deps

REVISION DETAIL
  https://phabricator.kde.org/D26596

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26597: Drop HAVE_X11 remnants

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R252 Framework Integration

BRANCH
  no-have-x11

REVISION DETAIL
  https://phabricator.kde.org/D26597

AFFECTED FILES
  src/kstyle/CMakeLists.txt
  src/kstyle/config-kstyle.h.cmake
  src/kstyle/kstyle.cpp

To: asturmlechner
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26306: Define more documentation search paths (also custom)

[Andreas Sturmlechner]

asturmlechner added a comment.


  Thanks for that, works for me!

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26306

To: ltoscano
Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, 
asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations

[Andreas Sturmlechner]

asturmlechner added a reviewer: Frameworks.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25812

To: asturmlechner, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  In the end, not opening device nodes readonly just because it does not concern
  'most PCs' is not sufficient. This switch, default off, would enable us to 
drop
  per-package patchwork and still keep the informal message.
  
  Back story: https://bugzilla.gnome.org/show_bug.cgi?id=744135
  BUG: 387753

TEST PLAN
  purpose continues to configure and build fine.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  gentoo

REVISION DETAIL
  https://phabricator.kde.org/D25812

AFFECTED FILES
  modules/ECMFindQMLModule.cmake.in

To: asturmlechner
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25809: Use standard ECMQMLModules

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:8d7123896b98: Use standard ECMQMLModules (authored by 
asturmlechner).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25809?vs=71085=71087

REVISION DETAIL
  https://phabricator.kde.org/D25809

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/cmake/FindQMLModule.cmake.in
  src/plugins/cmake/QMLModules.cmake

To: asturmlechner, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25809: Use standard ECMQMLModules

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  Drop obsolete QMLModules.cmake and FindQMLModule.cmake.in
  
  Superseded by standard ECM modules.

TEST PLAN
  Build succeeds.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25809

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/cmake/FindQMLModule.cmake.in
  src/plugins/cmake/QMLModules.cmake

To: asturmlechner
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D23229

To: asturmlechner, #frameworks, ltoscano
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

[Andreas Sturmlechner]

asturmlechner marked 2 inline comments as done.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D23229

To: asturmlechner, #frameworks
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 63954.
asturmlechner added a comment.


  Use deprecated variables as fallback if defined

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23229?vs=63952=63954

BRANCH
  kdeinstalldirs

REVISION DETAIL
  https://phabricator.kde.org/D23229

AFFECTED FILES
  KF5DocToolsMacros.cmake

To: asturmlechner, #frameworks
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

[Andreas Sturmlechner]

asturmlechner added a reviewer: Frameworks.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D23229

To: asturmlechner, #frameworks
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  HTML_INSTALL_DIR -> KDE_INSTALL_DOCBUNDLEDIR
  MAN_INSTALL_DIR -> KDE_INSTALL_MANDIR
  
  BUG: 410998

TEST PLAN
  Install paths are correct by example of marble.

REPOSITORY
  R238 KDocTools

BRANCH
  kdeinstalldirs

REVISION DETAIL
  https://phabricator.kde.org/D23229

AFFECTED FILES
  KF5DocToolsMacros.cmake

To: asturmlechner
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
michaelh, ngraham, bruns, skadinna

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

[Andreas Sturmlechner]

asturmlechner added a comment.


  This should probably also be posted on release-team ML.

REPOSITORY
  R300 KDEWebKit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21400

To: vkrause, apol, cullmann
Cc: cullmann, apol, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D12761: Allow building kio-nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D12761#367223 , @arojas wrote:
  
  > @asturmlechner can you post that in a new review request? I'll abandon this 
one.
  
  
  Done, this is now in https://phabricator.kde.org/D17205

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D17205: Build kio_nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added reviewers: Dolphin, dfaure, rdieter.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  Since glibc-2.26, cmake skipped over nfs when standalone tirpc
  was installed in tirpc subdir (as done by Debian, Fedora, Arch, Gentoo...)
  
  Use FindTIRPC and make kio_nfs optional that way
  FindTIRPC taken from https://phabricator.kde.org/D12761

TEST PLAN
  Built with libtirpc successfully.

REPOSITORY
  R320 KIO Extras

BRANCH
  kio_nfs

REVISION DETAIL
  https://phabricator.kde.org/D17205

AFFECTED FILES
  CMakeLists.txt
  cmake/FindTIRPC.cmake
  nfs/CMakeLists.txt

To: asturmlechner, #dolphin, dfaure, rdieter
Cc: kde-frameworks-devel, cgiboudeaux, arojas, kfm-devel, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D12761: Allow building kio-nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in CMakeLists.txt:4
> Any solution is fine however, we now patched ours kdebase4-runtime package to 
> disable kio-nfs completely. Pick the solution you prefer.

Thanks, your FindTIRPC works for me. This is what I came up with using it: 
https://paste.pound-python.org/show/zgu3uRLCJzKqXj97mL5b/

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D12761: Allow building kio-nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner added inline comments.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.

INLINE COMMENTS

> CMakeLists.txt:175
> +   add_feature_info("NFS kioslave" RPC_H_DIR "The RPC library is needed to 
> build the NFS kioslave")
> +   if(RPC_H_DIR)
>   add_subdirectory( nfs )

I would prefer a real build option instead of automagic here, and the detection 
below that conditional. I'm aware that's more than what we have right now.

> cgiboudeaux wrote in CMakeLists.txt:4
> This won't work for openSUSE:  the tirpc headers are installed in 
> /usr/include directly.

Could you suggest an alternative? Gentoo shares a similarity with Arch there, 
because otherwise libtirpc could collide with older versions of glibc.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Andreas Sturmlechner]

asturmlechner added a comment.


  The problem with that is cmake picking the wrong dir (first in order is 
`lib`, while it should be e.g. `lib64`).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Andreas Sturmlechner]

asturmlechner added a comment.


  Not convinved it is the best way but it is some way to make it point to the 
desired multiarch libdir rather than make it choose a random one.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Andreas Sturmlechner]

asturmlechner added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13585

AFFECTED FILES
  cmake/FindLMDB.cmake

To: asturmlechner
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12696: Use the new uds implementation

[Andreas Sturmlechner]

asturmlechner added a comment.


  No crash in my case, but this commit makes links with sftp:/ inaccessible.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: asturmlechner, martinkostolny, kde-frameworks-devel, bruns, michaelh, 
ngraham

D10587: Restore KTextEditor Document Dbus bindings

[Andreas Sturmlechner]

asturmlechner added a comment.


  This change has history, for reference: 
https://git.reviewboard.kde.org/r/129398/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10587

To: lukedashjr, cullmann, dhaumann, gregormi
Cc: anthonyfieroni, #ktexteditor, #kate, asturmlechner, gregormi, dhaumann, 
cullmann, #frameworks, michaelh, kevinapavew, ngraham, demsking, head7, kfunk, 
sars

D10201: FindQtWaylandScanner.cmake: Use qmake-query for HINT

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10201

To: asturmlechner, #frameworks, #build_system, cgiboudeaux
Cc: michaelh, ngraham

D10201: FindQtWaylandScanner.cmake: Use qmake-query for HINT

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added reviewers: Frameworks, Build System, cgiboudeaux.
Restricted Application added projects: Frameworks, Build System.
asturmlechner requested review of this revision.

REVISION SUMMARY
  Instead of hardcoded /usr/lib, same solution as in 
https://phabricator.kde.org/D9116

TEST PLAN
  Works fine with kwayland 5.42.0.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10201

AFFECTED FILES
  find-modules/FindQtWaylandScanner.cmake

To: asturmlechner, #frameworks, #build_system, cgiboudeaux
Cc: michaelh, ngraham

D9116: Make sure to search for Qt5-based qmlplugindump

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:92eb3e9767cb: Make sure to search for Qt5-based 
qmlplugindump (authored by asturmlechner).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9116?vs=26253=26254

REVISION DETAIL
  https://phabricator.kde.org/D9116

AFFECTED FILES
  modules/ECMFindQMLModule.cmake.in

To: asturmlechner, apol, cgiboudeaux
Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system, michaelh, ngraham

D9116: Make sure to search for Qt5-based qmlplugindump

[Andreas Sturmlechner]

asturmlechner added a comment.


  Want me to fix FindQtWaylandScanner.cmake in the same way?

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  arcpatch-D9116

REVISION DETAIL
  https://phabricator.kde.org/D9116

To: asturmlechner, apol, cgiboudeaux
Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system, michaelh, ngraham

D9116: Make sure to search for Qt5-based qmlplugindump

[Andreas Sturmlechner]

asturmlechner edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  arcpatch-D9116

REVISION DETAIL
  https://phabricator.kde.org/D9116

To: asturmlechner, apol, cgiboudeaux
Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system, michaelh, ngraham

D9116: Make sure to search for Qt5-based qmlplugindump

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 26253.
asturmlechner added a comment.


  Use ECMQueryQmake.cmake as suggested.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9116?vs=23304=26253

BRANCH
  arcpatch-D9116

REVISION DETAIL
  https://phabricator.kde.org/D9116

AFFECTED FILES
  modules/ECMFindQMLModule.cmake.in

To: asturmlechner, apol
Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system, michaelh, ngraham

D9880: Fix build with >=attr-2.4.48

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4bbc7a2f5c77: Fix build with =attr-2.4.48 (authored 
by Lars Wendler polynomia...@gentoo.org, committed by asturmlechner).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9880?vs=25352=25492

REVISION DETAIL
  https://phabricator.kde.org/D9880

AFFECTED FILES
  cmake/FindXattr.cmake
  src/xattr_p.h

To: asturmlechner, #frameworks, mgallien

D9880: Fix build with >=attr-2.4.48

[Andreas Sturmlechner]

asturmlechner added a comment.


  In https://phabricator.kde.org/D9880#191545, @mgallien wrote:
  
  > Are you sure attr/xattr.h is deprecated ?
  
  
  Yep, it is gone in 2.4.48, but the commit that removed it is from 2015: 
http://git.savannah.nongnu.org/cgit/attr.git/commit/?id=7921157890d07858d092f4003ca4c6bae9fd2c38

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D9880

To: asturmlechner, #frameworks, mgallien

D9880: Fix build with >=attr-2.4.48

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added reviewers: Frameworks, mgallien.
Restricted Application added a project: Frameworks.
asturmlechner requested review of this revision.

REVISION SUMMARY
  It was looking for long deprecated attr/xattr.h header.

TEST PLAN
  Built fine with attr-2.4.47 and 2.4.48.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9880

AFFECTED FILES
  cmake/FindXattr.cmake
  src/xattr_p.h

To: asturmlechner, #frameworks, mgallien

D9116: Make sure to search for Qt5-based qmlplugindump

[Andreas Sturmlechner]

asturmlechner added a comment.


  Can we move forward with this?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9116

To: asturmlechner, apol
Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system

D9116: Make sure to search for Qt5-based qmlplugindump

[Andreas Sturmlechner]

asturmlechner added a comment.


  In https://phabricator.kde.org/D9116#174894, @aacid wrote:
  
  > is this a problem caused by qmlplugindump being one of those magic things 
that are "symlinks" to the qt4 or qt5 depending on the QT_SELECT env var?
  
  
  exactly

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9116

To: asturmlechner, apol
Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system

D9116: Make sure to search for Qt5-based qmlplugindump

[Andreas Sturmlechner]

asturmlechner added a comment.


  In https://phabricator.kde.org/D9116#174856, @dfaure wrote:
  
  > Which distro was this commit for? Looks like a debian/ubuntu path? If so, 
how did this go unnoticed until now?
  
  
  This is for Gentoo - now I don't do Qt packaging, but as far as I'm aware 
this is pretty vanilla.
  
  In https://phabricator.kde.org/D9116#174871, @cgiboudeaux wrote:
  
  > it's a packaging issue if executables that don't have a .desktop file are 
not in PATH. An alternative could be to use qtpaths but it adds a dependency on 
qttools (and wouldn't help if it's installed in the same dir).
  
  
  The point of this change is that ECM should not rely on the default set by 
`qtchooser/default.conf` which can be either Qt4 or Qt5. qmlplugindump is not a 
binary that is exclusive to Qt5.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9116

To: asturmlechner, apol
Cc: dfaure, cgiboudeaux, #frameworks, #build_system

D9116: Make sure to search for Qt5-based qmlplugindump

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: apol.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  Without any hint, qmlplugindump version is whatever default is set by 
qtchooser.
  Fix uses the same approach as FindQtWaylandScanner.cmake.

TEST PLAN
  ecm_find_qmlmodule now works properly for e.g. kirigami.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9116

AFFECTED FILES
  modules/ECMFindQMLModule.cmake.in

To: asturmlechner, apol
Cc: #frameworks, #build_system

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

[Andreas Sturmlechner]

asturmlechner closed this revision.
asturmlechner added a comment.


  Thanks!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D7330

To: asturmlechner, #frameworks, dfaure, mgallien

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

[Andreas Sturmlechner]

asturmlechner added a reviewer: dfaure.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D7330

To: asturmlechner, #frameworks, dfaure

D7328: Don't enter test subdirectories if BUILD_TESTING=OFF

[Andreas Sturmlechner]

asturmlechner closed this revision.
asturmlechner added a comment.


  Merged, closing manually.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7328

To: asturmlechner, #frameworks, dfaure

D7230: Save up a bunch of stat() calls on application start

[Andreas Sturmlechner]

asturmlechner accepted this revision.
asturmlechner added a comment.


  Briefly runtime tested it as well with and without translations, no issues.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7230

To: apol, #frameworks, dfaure, asturmlechner
Cc: ltoscano, aacid, dfaure, elvisangelaccio, broulik

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: Frameworks.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7330

AFFECTED FILES
  CMakeLists.txt
  src/file/extractor/CMakeLists.txt

To: asturmlechner, #frameworks

D7328: Don't enter test subdirectories if BUILD_TESTING=OFF

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  The proposed change to ECMAddTest was reverted because it led to failures
  with subsequent calls depending on then nonexisting test targets. Instead,
  just make the test subdirectories conditional on BUILD_TESTING.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7328

AFFECTED FILES
  CMakeLists.txt
  src/ioslaves/trash/CMakeLists.txt
  src/ioslaves/trash/tests/CMakeLists.txt
  src/kpasswdserver/CMakeLists.txt

To: asturmlechner, #frameworks

D7230: Save up a bunch of stat() calls on application start

[Andreas Sturmlechner]

asturmlechner added a comment.


  Sounds fine.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7230

To: apol, #frameworks, dfaure, asturmlechner
Cc: ltoscano, aacid, dfaure, elvisangelaccio, broulik

D7230: Save up a bunch of stat() calls on application start

[Andreas Sturmlechner]

asturmlechner added a comment.


  Thanks for adding me, at least Gentoo indeed supports stripping translations 
even after they were moved into the packages - so that would break.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7230

To: apol, #frameworks, dfaure, asturmlechner
Cc: ltoscano, aacid, dfaure, elvisangelaccio, broulik

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:dec4afb4145b: Use ecm_add_test and benefit from 
BUILD_TESTING awareness (authored by asturmlechner).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7213?vs=17908=17909

REVISION DETAIL
  https://phabricator.kde.org/D7213

AFFECTED FILES
  src/ioslaves/trash/tests/CMakeLists.txt

To: asturmlechner, #frameworks, kfunk
Cc: kfunk

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: Frameworks.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7213

AFFECTED FILES
  src/ioslaves/trash/tests/CMakeLists.txt

To: asturmlechner, #frameworks
Cc: kfunk

D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R274:93a2acfe2e66: Qt5DBus is only required with 
HAVE_XSCREENSAVER (authored by asturmlechner).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7156?vs=17763=17852#toc

REPOSITORY
  R274 KIdleTime

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7156?vs=17763=17852

REVISION DETAIL
  https://phabricator.kde.org/D7156

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner, #frameworks, kfunk
Cc: #frameworks

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

[Andreas Sturmlechner]

asturmlechner added a comment.


  In https://phabricator.kde.org/D7187#11, @kfunk wrote:
  
  > Anyhow, this patch tries to make it easy to build KDevelop without tests; 
trying to avoid hacky approaches like those being done in Gentoo:
  
  
  Much appreciated if we can drop those.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7187

To: kfunk
Cc: elvisangelaccio, asturmlechner, apol, #frameworks, #build_system

D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

[Andreas Sturmlechner]

asturmlechner added a reviewer: Frameworks.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D7156

To: asturmlechner, #frameworks
Cc: #frameworks

D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

TEST PLAN
  Continues to build fine.

REPOSITORY
  R274 KIdleTime

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7156

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner
Cc: #frameworks

D6493: Add KF5WindowSystem to link interface

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5033a104e226: Add KF5WindowSystem to link interface 
(authored by asturmlechner).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6493?vs=16896=16913

REVISION DETAIL
  https://phabricator.kde.org/D6493

AFFECTED FILES
  KF5PlasmaConfig.cmake.in

To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, davidedmundson, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6495: Don't list KF5::WindowSystem in public libraries

[Andreas Sturmlechner]

asturmlechner added a comment.


  Thanks, works for me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6495

To: davidedmundson, #plasma
Cc: asturmlechner, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6493: Add KF5WindowSystem to link interface

[Andreas Sturmlechner]

asturmlechner abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6493

To: asturmlechner, #plasma
Cc: davidedmundson, #frameworks

D6493: Add KF5WindowSystem to link interface

[Andreas Sturmlechner]

asturmlechner added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6493

To: asturmlechner, #plasma
Cc: #frameworks

D6493: Add KF5WindowSystem to link interface

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Otherwise, reverse-dependencies are bugged
  with finding KF5WindowSystem themselves.

TEST PLAN
  Builds fine, plasma-sdk does not need to add KF5WindowSystem anymore.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6493

AFFECTED FILES
  KF5PlasmaConfig.cmake.in
  src/plasma/CMakeLists.txt

To: asturmlechner
Cc: #frameworks

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

[Andreas Sturmlechner]

> On April 1, 2017, 7:59 p.m., David Faure wrote:
> > Makes sense to me, +1.
> 
> Andreas Sturmlechner wrote:
> Thanks, anyone else who wants to +1?
> 
> I've tried to test migration today but it didn't work. May as well have 
> nothing to do with te patch and be caused by the permanently troubled 
> migration agent though... KMail happily gets its IMAP password from kwallet5 
> though after manually export/import via XML files.
> 
> Andreas Sturmlechner wrote:
> As suspected, on my test system migration is broken regardless of with 
> these patches or not.
> 
> David Faure wrote:
> Are you planning on looking into that? ;-)
> 
> These patches are related to migration, it feels a bit wrong to commit 
> changes around migration and still leave it broken.
> 
> Andreas Sturmlechner wrote:
> I don't feel like I'm up to that task. Also, the reason for why it works 
> for some, but not all the systems, has afaik never been established.
> 
> Andreas Sturmlechner wrote:
> Could we push it to give it some testing by others until the upcoming 
> release?
> 
> René J.V. Bertin wrote:
> Was this tested, in the end?
> 
> I only became aware of the change after I installed 5.35.0 on my 
> FrankenStux box with a Plasma4 desktop and KF5 installed into /opt/local, and 
> I had to re-grant access to my wallets to all applications accessing them. 
> 
> I cannot yet vouch that my wallets were migrated completely. I think they 
> were, but how do I verify that now? Even the KDE4 kwalletmanager goes through 
> kwalletd5. It too had to be granted access.
> 
> Confusingly, it still shows the old access list, which clearly it 
> shouldn't if the information is stale.

If you see your old wallets now in kwalletd5, then migration has worked. I've 
never heard about issues with partial migration; if it does not work, it fails 
to migrate completely.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review102982
---


On May 27, 2017, 2:32 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> ---
> 
> (Updated May 27, 2017, 2:32 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> These are not my own patches, I'm creating this review request after having 
> been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
> simply rebased on top of current master (author of course preserved) to be 
> able to test it. I think it would be a great improvement over the current 
> situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 
> 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp 
> f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> ---
> 
> Migration itself was not tested so far, but a legacy application like ksirk 
> was able to create a new wallet just fine and can access it as well. I do not 
> have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/
---

(Updated May 27, 2017, 4:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Stefan Brüns.


Changes
---

Submitted with commit c2fe10e2e75304114de89aa83381cfa20e6e9734 by Andreas 
Sturmlechner on behalf of Stefan Brüns to branch master.


Repository: kwallet


Description
---

These are not my own patches, I'm creating this review request after having 
been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
simply rebased on top of current master (author of course preserved) to be able 
to test it. I think it would be a great improvement over the current situation 
that is rather confusing to the users.

The changes are organised in 5 commits:

- Check for unique applicaton instance as early as possible
Exit before KWalletD and the MigrationAgent has been initialized.
The return value is changed, but concurrent instatiation of kwalletd is
not a fault.

- Only start timer for migration agent if necessary
- Whitespace fixup
- Signal completion of migration agent
- Replace kwalletd4 after migration has finished
kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd


Diffs
-

  src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
  src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
  src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
  src/runtime/kwalletd/migrationagent.h 
0f6467c1753ef34b7f7f7e282503ec5607927db9 
  src/runtime/kwalletd/migrationagent.cpp 
f3da94743ecd83fe406e058f560d4238caec1be8 

Diff: https://git.reviewboard.kde.org/r/130058/diff/


Testing
---

Migration itself was not tested so far, but a legacy application like ksirk was 
able to create a new wallet just fine and can access it as well. I do not have 
kwalletd4 installed anymore.


Thanks,

Andreas Sturmlechner

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

[Andreas Sturmlechner]

> On April 1, 2017, 7:59 p.m., David Faure wrote:
> > Makes sense to me, +1.
> 
> Andreas Sturmlechner wrote:
> Thanks, anyone else who wants to +1?
> 
> I've tried to test migration today but it didn't work. May as well have 
> nothing to do with te patch and be caused by the permanently troubled 
> migration agent though... KMail happily gets its IMAP password from kwallet5 
> though after manually export/import via XML files.
> 
> Andreas Sturmlechner wrote:
> As suspected, on my test system migration is broken regardless of with 
> these patches or not.
> 
> David Faure wrote:
> Are you planning on looking into that? ;-)
> 
> These patches are related to migration, it feels a bit wrong to commit 
> changes around migration and still leave it broken.
> 
> Andreas Sturmlechner wrote:
> I don't feel like I'm up to that task. Also, the reason for why it works 
> for some, but not all the systems, has afaik never been established.

Could we push it to give it some testing by others until the upcoming release?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review102982
-------


On March 29, 2017, 12:52 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> ---
> 
> (Updated March 29, 2017, 12:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> These are not my own patches, I'm creating this review request after having 
> been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
> simply rebased on top of current master (author of course preserved) to be 
> able to test it. I think it would be a great improvement over the current 
> situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 
> 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp 
> f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> ---
> 
> Migration itself was not tested so far, but a legacy application like ksirk 
> was able to create a new wallet just fine and can access it as well. I do not 
> have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 122206: [kio] Make tests optional

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122206/
---

(Updated April 22, 2017, 10:35 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kio


Description
---

[kio] Make tests optional
This is a small patch to CMakeLists.txt to only depend on Qt5Test if 
BUILD_TESTING.


Diffs
-

  CMakeLists.txt c1ed03f6cac648517828aec60e896baf9fbcfd9d 

Diff: https://git.reviewboard.kde.org/r/122206/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

[Andreas Sturmlechner]

> On April 1, 2017, 7:59 p.m., David Faure wrote:
> > Makes sense to me, +1.
> 
> Andreas Sturmlechner wrote:
> Thanks, anyone else who wants to +1?
> 
> I've tried to test migration today but it didn't work. May as well have 
> nothing to do with te patch and be caused by the permanently troubled 
> migration agent though... KMail happily gets its IMAP password from kwallet5 
> though after manually export/import via XML files.
> 
> Andreas Sturmlechner wrote:
> As suspected, on my test system migration is broken regardless of with 
> these patches or not.
> 
> David Faure wrote:
> Are you planning on looking into that? ;-)
> 
> These patches are related to migration, it feels a bit wrong to commit 
> changes around migration and still leave it broken.

I don't feel like I'm up to that task. Also, the reason for why it works for 
some, but not all the systems, has afaik never been established.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review102982
-------


On March 29, 2017, 12:52 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> ---
> 
> (Updated March 29, 2017, 12:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> These are not my own patches, I'm creating this review request after having 
> been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
> simply rebased on top of current master (author of course preserved) to be 
> able to test it. I think it would be a great improvement over the current 
> situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 
> 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp 
> f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> ---
> 
> Migration itself was not tested so far, but a legacy application like ksirk 
> was able to create a new wallet just fine and can access it as well. I do not 
> have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

[Andreas Sturmlechner]

> On April 1, 2017, 7:59 p.m., David Faure wrote:
> > Makes sense to me, +1.
> 
> Andreas Sturmlechner wrote:
> Thanks, anyone else who wants to +1?
> 
> I've tried to test migration today but it didn't work. May as well have 
> nothing to do with te patch and be caused by the permanently troubled 
> migration agent though... KMail happily gets its IMAP password from kwallet5 
> though after manually export/import via XML files.

As suspected, on my test system migration is broken regardless of with these 
patches or not.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review102982
---


On March 29, 2017, 12:52 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> ---
> 
> (Updated March 29, 2017, 12:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> These are not my own patches, I'm creating this review request after having 
> been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
> simply rebased on top of current master (author of course preserved) to be 
> able to test it. I think it would be a great improvement over the current 
> situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 
> 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp 
> f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> ---
> 
> Migration itself was not tested so far, but a legacy application like ksirk 
> was able to create a new wallet just fine and can access it as well. I do not 
> have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

[Andreas Sturmlechner]

> On April 1, 2017, 7:59 p.m., David Faure wrote:
> > Makes sense to me, +1.

Thanks, anyone else who wants to +1?

I've tried to test migration today but it didn't work. May as well have nothing 
to do with te patch and be caused by the permanently troubled migration agent 
though... KMail happily gets its IMAP password from kwallet5 though after 
manually export/import via XML files.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review102982
---


On March 29, 2017, 12:52 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> ---
> 
> (Updated March 29, 2017, 12:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> These are not my own patches, I'm creating this review request after having 
> been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
> simply rebased on top of current master (author of course preserved) to be 
> able to test it. I think it would be a great improvement over the current 
> situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 
> 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp 
> f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> ---
> 
> Migration itself was not tested so far, but a legacy application like ksirk 
> was able to create a new wallet just fine and can access it as well. I do not 
> have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/
---

Review request for KDE Frameworks and Stefan Brüns.


Repository: kwallet


Description
---

These are not my own patches, I'm creating this review request after having 
been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
simply rebased on top of current master (author of course preserved) to be able 
to test it. I think it would be a great improvement over the current situation 
that is rather confusing to the users.

The changes are organised in 5 commits:

- Check for unique applicaton instance as early as possible
Exit before KWalletD and the MigrationAgent has been initialized.
The return value is changed, but concurrent instatiation of kwalletd is
not a fault.

- Only start timer for migration agent if necessary
- Whitespace fixup
- Signal completion of migration agent
- Replace kwalletd4 after migration has finished
kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd


Diffs
-

  src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
  src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
  src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
  src/runtime/kwalletd/migrationagent.h 
0f6467c1753ef34b7f7f7e282503ec5607927db9 
  src/runtime/kwalletd/migrationagent.cpp 
f3da94743ecd83fe406e058f560d4238caec1be8 

Diff: https://git.reviewboard.kde.org/r/130058/diff/


Testing
---

Migration itself was not tested so far, but a legacy application like ksirk was 
able to create a new wallet just fine and can access it as well. I do not have 
kwalletd4 installed anymore.


Thanks,

Andreas Sturmlechner

Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

[Andreas Sturmlechner]

> On Jan. 2, 2017, 10:53 p.m., Albert Astals Cid wrote:
> > I don't think this makes any sense. I understand your pain, would i'd 
> > rather improve the search of hunspell than accept it's crap and you want 
> > people to override it.

It sure ain't pretty. But then I don't know why the hunspell search is done how 
it's done now. Is it just for lack of being able to set a minimum version?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129742/#review101749
---


On Jan. 1, 2017, 11:01 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129742/
> ---
> 
> (Updated Jan. 1, 2017, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> HUNSPELL is optional, but its cmake module depends on updates on each
> future hunspell release to be found. Each time that happens, the user
> build is potentially silently missing a feature, because up to now it
> can not be reliably enabled, only disabled.
> 
> This was the least disruptive solution I could come up with.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt edac12f6cdc1fddc7f6b9df0baeb519a6c6502fb 
>   src/plugins/CMakeLists.txt 58b254c670e7e57202bbc9c889c86a48041a044e 
> 
> Diff: https://git.reviewboard.kde.org/r/129742/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129742/
---

Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: sonnet


Description
---

HUNSPELL is optional, but its cmake module depends on updates on each
future hunspell release to be found. Each time that happens, the user
build is potentially silently missing a feature, because up to now it
can not be reliably enabled, only disabled.

This was the least disruptive solution I could come up with.


Diffs
-

  CMakeLists.txt edac12f6cdc1fddc7f6b9df0baeb519a6c6502fb 
  src/plugins/CMakeLists.txt 58b254c670e7e57202bbc9c889c86a48041a044e 

Diff: https://git.reviewboard.kde.org/r/129742/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129613/
---

(Updated Dec. 15, 2016, 1:24 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 47323f431f5ccea34dd7d21668d625bd9651dfec by Andreas 
Sturmlechner to branch master.


Repository: kwallet


Description
---

GpgME-1.7.0 released > 2 months ago, KF5Gpgmepp no longer maintained.
No reason to keep the fallback any longer.

Separate commits:
- This reverts commit 60ebcad53c95ecfbe822647075f79578c3420851.
- Specify minimum required GpgME++ version 1.7.0
- Drop obsolete FindGpgme.cmake
- Messages: More QGpgME -> GpgME


Diffs
-

  cmake/FindGpgme.cmake 7a092104ba0604b0606c4662750b8b32c5c3e2c6 
  src/runtime/kwalletd/CMakeLists.txt fe72f2ef50417010a9c49b9b6dfdf6465c2e23fb 
  src/runtime/kwalletd/backend/CMakeLists.txt 
0bd312688b2cdc49be14ffe278068309ac06051c 
  src/runtime/kwalletd/knewwalletdialog.cpp 
7383b1310733c208ca269bb8c1c407cb87291c13 
  src/runtime/kwalletd/kwalletwizard.cpp 
582b5e9b0e2d625e5219fc2ac48d0dd1690448ae 
  tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 

Diff: https://git.reviewboard.kde.org/r/129613/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129613/
---

(Updated Dec. 15, 2016, 1:24 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 47323f431f5ccea34dd7d21668d625bd9651dfec by Andreas 
Sturmlechner to branch master.


Repository: kwallet


Description
---

GpgME-1.7.0 released > 2 months ago, KF5Gpgmepp no longer maintained.
No reason to keep the fallback any longer.

Separate commits:
- This reverts commit 60ebcad53c95ecfbe822647075f79578c3420851.
- Specify minimum required GpgME++ version 1.7.0
- Drop obsolete FindGpgme.cmake
- Messages: More QGpgME -> GpgME


Diffs
-

  cmake/FindGpgme.cmake 7a092104ba0604b0606c4662750b8b32c5c3e2c6 
  src/runtime/kwalletd/CMakeLists.txt fe72f2ef50417010a9c49b9b6dfdf6465c2e23fb 
  src/runtime/kwalletd/backend/CMakeLists.txt 
0bd312688b2cdc49be14ffe278068309ac06051c 
  src/runtime/kwalletd/knewwalletdialog.cpp 
7383b1310733c208ca269bb8c1c407cb87291c13 
  src/runtime/kwalletd/kwalletwizard.cpp 
582b5e9b0e2d625e5219fc2ac48d0dd1690448ae 
  tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 

Diff: https://git.reviewboard.kde.org/r/129613/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129611: Make Gpgme a required dependency if we build Gpgme interface.

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129611/#review101269
---



Is it really a possible scenario that Gpgmepp is installed, but not Gpgme? In 
the past, that call was necessary to fix build with gpgme not being in a subdir 
below /usr/include, but not anymore. I guess there would be a way to get rid of 
gpgme.h instead.

- Andreas Sturmlechner


On Dec. 4, 2016, 12:49 a.m., Sandro Knauß wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129611/
> ---
> 
> (Updated Dec. 4, 2016, 12:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Acording to the README of QGpgME, we cannot expect to be gpgme.h be 
> available, so we need to search for GpgME by our own.
> 
> See 
> https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=blob;f=lang/cpp/README;h=b9a48da15ce424a08d0e8c5d20846af8882da193;hb=HEAD#l31
> 
>   31 7. Complete abstraction of the C-API so "gpgme.h" should not
>   32be needed in your project using GpgME++.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/CMakeLists.txt 
> 5092a7e77a1ca7203827e444c11310566b2cc8b5 
> 
> Diff: https://git.reviewboard.kde.org/r/129611/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

Re: Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129613/
---

(Updated Dec. 4, 2016, 12:33 p.m.)


Review request for KDE Frameworks and David Faure.


Repository: kwallet


Description (updated)
---

GpgME-1.7.0 released > 2 months ago, KF5Gpgmepp no longer maintained.
No reason to keep the fallback any longer.

Separate commits:
- This reverts commit 60ebcad53c95ecfbe822647075f79578c3420851.
- Specify minimum required GpgME++ version 1.7.0
- Drop obsolete FindGpgme.cmake
- Messages: More QGpgME -> GpgME


Diffs (updated)
-

  cmake/FindGpgme.cmake 7a092104ba0604b0606c4662750b8b32c5c3e2c6 
  src/runtime/kwalletd/CMakeLists.txt fe72f2ef50417010a9c49b9b6dfdf6465c2e23fb 
  src/runtime/kwalletd/backend/CMakeLists.txt 
0bd312688b2cdc49be14ffe278068309ac06051c 
  src/runtime/kwalletd/knewwalletdialog.cpp 
7383b1310733c208ca269bb8c1c407cb87291c13 
  src/runtime/kwalletd/kwalletwizard.cpp 
582b5e9b0e2d625e5219fc2ac48d0dd1690448ae 
  tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 

Diff: https://git.reviewboard.kde.org/r/129613/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129613/
---

Review request for KDE Frameworks and David Faure.


Repository: kwallet


Description
---

GpgME-1.7.0 released > 2 months ago, KF5Gpgmepp no longer maintained.
No reason to keep the fallback any longer.

This reverts commit 60ebcad53c95ecfbe822647075f79578c3420851.

Specify minimum required GpgME++ version 1.7.0


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt fe72f2ef50417010a9c49b9b6dfdf6465c2e23fb 
  src/runtime/kwalletd/backend/CMakeLists.txt 
0bd312688b2cdc49be14ffe278068309ac06051c 
  tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 

Diff: https://git.reviewboard.kde.org/r/129613/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/
---

(Updated Dec. 4, 2016, 6:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit f4e1653eefe9e81adbb7ec7f8eda51e02cd58f7b by Andreas 
Sturmlechner to branch master.


Repository: kwallet


Description
---

Dropping implicit boost usage.
Also, rename HAVE_QGPGME to HAVE_GPGMEPP.


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 
  src/runtime/kwalletd/backend/CMakeLists.txt 
2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
  src/runtime/kwalletd/backend/backendpersisthandler.h 
a6682353d62fd63e88a0de6277801c624c794c74 
  src/runtime/kwalletd/backend/backendpersisthandler.cpp 
413d4cd23ef1e15b75cd366061f07f179241af58 
  src/runtime/kwalletd/backend/kwalletbackend.h 
4811a58e942685b01ed097ef15c2838e3833865c 
  src/runtime/kwalletd/backend/kwalletbackend.cc 
43f30a545d36b64b102c794de3625621a694983e 
  src/runtime/kwalletd/knewwalletdialog.h 
ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
  src/runtime/kwalletd/knewwalletdialog.cpp 
0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
  src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
  src/runtime/kwalletd/kwalletwizard.h 4cf8de424af800716e7c779d6d419eae4b54e426 
  src/runtime/kwalletd/kwalletwizard.cpp 
cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 

Diff: https://git.reviewboard.kde.org/r/129341/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/
---

(Updated Dec. 4, 2016, 11:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit f4e1653eefe9e81adbb7ec7f8eda51e02cd58f7b by Andreas 
Sturmlechner to branch master.


Repository: kwallet


Description
---

Dropping implicit boost usage.
Also, rename HAVE_QGPGME to HAVE_GPGMEPP.


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 
  src/runtime/kwalletd/backend/CMakeLists.txt 
2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
  src/runtime/kwalletd/backend/backendpersisthandler.h 
a6682353d62fd63e88a0de6277801c624c794c74 
  src/runtime/kwalletd/backend/backendpersisthandler.cpp 
413d4cd23ef1e15b75cd366061f07f179241af58 
  src/runtime/kwalletd/backend/kwalletbackend.h 
4811a58e942685b01ed097ef15c2838e3833865c 
  src/runtime/kwalletd/backend/kwalletbackend.cc 
43f30a545d36b64b102c794de3625621a694983e 
  src/runtime/kwalletd/knewwalletdialog.h 
ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
  src/runtime/kwalletd/knewwalletdialog.cpp 
0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
  src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
  src/runtime/kwalletd/kwalletwizard.h 4cf8de424af800716e7c779d6d419eae4b54e426 
  src/runtime/kwalletd/kwalletwizard.cpp 
cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 

Diff: https://git.reviewboard.kde.org/r/129341/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129426: refactor gpg finding

[Andreas Sturmlechner]

> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote:
> > CMakeLists.txt, line 37
> > <https://git.reviewboard.kde.org/r/129426/diff/1/?file=485781#file485781line37>
> >
> > that looks to me as if it does the opposite as in $description; prefer 
> > the old one to the new one.
> 
> Harald Sitter wrote:
> You take offense with an if checking whether we can build with gpg 
> support?
> 
> Andreas Sturmlechner wrote:
> It does the opposite of what you say you want in the description. 
> Preferring the new lib is the status quo.

And while I agree that the current approach can be much improved, KF5Gpgmepp is 
not here to stay anyway. 16.08.3 is its final release and with KF-5.30 it may 
as well be kicked out by simply reverting 
60ebcad53c95ecfbe822647075f79578c3420851 (which leaves the unnecessary 
duplication in test dir).


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129426/#review100933
---


On Nov. 18, 2016, 2 p.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129426/
> ---
> 
> (Updated Nov. 18, 2016, 2 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> refactor gpg finding code to be correctly taking all FOUND vars into account, 
> indicate itself as feature to cmake, prefer the new lib over the old one, not 
> be duplicated in runtime and test dir, not require excessively shitty if's to 
> be used.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6145fda8ebd8470024396b9029d1f23298d1a333 
>   src/runtime/kwalletd/CMakeLists.txt 
> 5092a7e77a1ca7203827e444c11310566b2cc8b5 
>   src/runtime/kwalletd/backend/CMakeLists.txt 
> 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
>   tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 
> 
> Diff: https://git.reviewboard.kde.org/r/129426/diff/
> 
> 
> Testing
> ---
> 
> builds and continues to link to gpg
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

Re: Review Request 129426: refactor gpg finding

[Andreas Sturmlechner]

> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote:
> > CMakeLists.txt, line 37
> > <https://git.reviewboard.kde.org/r/129426/diff/1/?file=485781#file485781line37>
> >
> > that looks to me as if it does the opposite as in $description; prefer 
> > the old one to the new one.
> 
> Harald Sitter wrote:
> You take offense with an if checking whether we can build with gpg 
> support?

It does the opposite of what you say you want in the description. Preferring 
the new lib is the status quo.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129426/#review100933
---


On Nov. 18, 2016, 2 p.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129426/
> ---
> 
> (Updated Nov. 18, 2016, 2 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> refactor gpg finding code to be correctly taking all FOUND vars into account, 
> indicate itself as feature to cmake, prefer the new lib over the old one, not 
> be duplicated in runtime and test dir, not require excessively shitty if's to 
> be used.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6145fda8ebd8470024396b9029d1f23298d1a333 
>   src/runtime/kwalletd/CMakeLists.txt 
> 5092a7e77a1ca7203827e444c11310566b2cc8b5 
>   src/runtime/kwalletd/backend/CMakeLists.txt 
> 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
>   tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 
> 
> Diff: https://git.reviewboard.kde.org/r/129426/diff/
> 
> 
> Testing
> ---
> 
> builds and continues to link to gpg
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

Re: Review Request 129426: refactor gpg finding

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129426/#review100933
---




CMakeLists.txt (line 37)
<https://git.reviewboard.kde.org/r/129426/#comment67701>

that looks to me as if it does the opposite as in $description; prefer the 
old one to the new one.


- Andreas Sturmlechner


On Nov. 18, 2016, 2 p.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129426/
> ---
> 
> (Updated Nov. 18, 2016, 2 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> refactor gpg finding code to be correctly taking all FOUND vars into account, 
> indicate itself as feature to cmake, prefer the new lib over the old one, not 
> be duplicated in runtime and test dir, not require excessively shitty if's to 
> be used.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6145fda8ebd8470024396b9029d1f23298d1a333 
>   src/runtime/kwalletd/CMakeLists.txt 
> 5092a7e77a1ca7203827e444c11310566b2cc8b5 
>   src/runtime/kwalletd/backend/CMakeLists.txt 
> 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
>   tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 
> 
> Diff: https://git.reviewboard.kde.org/r/129426/diff/
> 
> 
> Testing
> ---
> 
> builds and continues to link to gpg
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/
---

(Updated Nov. 15, 2016, 8:54 p.m.)


Review request for KDE Frameworks.


Changes
---

HAVE_QGPGME -> HAVE_GPGMEPP


Repository: kwallet


Description (updated)
---

Dropping implicit boost usage.
Also, rename HAVE_QGPGME to HAVE_GPGMEPP.


Diffs (updated)
-

  src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 
  src/runtime/kwalletd/backend/CMakeLists.txt 
2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
  src/runtime/kwalletd/backend/backendpersisthandler.h 
a6682353d62fd63e88a0de6277801c624c794c74 
  src/runtime/kwalletd/backend/backendpersisthandler.cpp 
413d4cd23ef1e15b75cd366061f07f179241af58 
  src/runtime/kwalletd/backend/kwalletbackend.h 
4811a58e942685b01ed097ef15c2838e3833865c 
  src/runtime/kwalletd/backend/kwalletbackend.cc 
43f30a545d36b64b102c794de3625621a694983e 
  src/runtime/kwalletd/knewwalletdialog.h 
ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
  src/runtime/kwalletd/knewwalletdialog.cpp 
0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
  src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
  src/runtime/kwalletd/kwalletwizard.h 4cf8de424af800716e7c779d6d419eae4b54e426 
  src/runtime/kwalletd/kwalletwizard.cpp 
cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 

Diff: https://git.reviewboard.kde.org/r/129341/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

[Andreas Sturmlechner]

> On Nov. 5, 2016, 12:56 p.m., Alexander Potashev wrote:
> > Not sure if C++11's shared_ptr can be used, at least it's not mentioned 
> > here: 
> > https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11

I'm not an expert there, but it is already used in (at least) kactivities, 
kdeclarative and syntax-highlighting as well.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/#review100597
---


On Nov. 5, 2016, 12:05 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129341/
> ---
> 
> (Updated Nov. 5, 2016, 12:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Dropping implicit boost usage.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/backend/backendpersisthandler.cpp 
> 413d4cd23ef1e15b75cd366061f07f179241af58 
>   src/runtime/kwalletd/knewwalletdialog.h 
> ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
>   src/runtime/kwalletd/knewwalletdialog.cpp 
> 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
>   src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
>   src/runtime/kwalletd/kwalletwizard.cpp 
> cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 
> 
> Diff: https://git.reviewboard.kde.org/r/129341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/
---

Review request for KDE Frameworks.


Repository: kwallet


Description
---

Dropping implicit boost usage.


Diffs
-

  src/runtime/kwalletd/backend/backendpersisthandler.cpp 
413d4cd23ef1e15b75cd366061f07f179241af58 
  src/runtime/kwalletd/knewwalletdialog.h 
ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
  src/runtime/kwalletd/knewwalletdialog.cpp 
0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
  src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
  src/runtime/kwalletd/kwalletwizard.cpp 
cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 

Diff: https://git.reviewboard.kde.org/r/129341/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129071: Use Gpgmepp from GpgME-1.7.0

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129071/
---

(Updated Oct. 8, 2016, 4:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 211e150f1ccbc1ac2a6e74575535dd6858cdbeaf by Andreas 
Sturmlechner to branch master.


Repository: kwallet


Description
---

If Gpgmepp is not found, try to use KF5Gpgmepp


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt d7e9ca2c9891db811ecf7063d15f829cf34ad52b 
  src/runtime/kwalletd/backend/CMakeLists.txt 
20bd4d95c3c1b0cfa43cbe71ce73fa699515ecfa 
  tests/kwalletd/CMakeLists.txt c84c1db6003412b6a7ac2768f171cbab380b376c 

Diff: https://git.reviewboard.kde.org/r/129071/diff/


Testing
---

Builds and links fine with either GpgME-1.7.0 or KF5Gpgmepp present.


Thanks,

Andreas Sturmlechner

Re: Review Request 129071: Use Gpgmepp from GpgME-1.7.0

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129071/
---

(Updated Oct. 8, 2016, 7:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 211e150f1ccbc1ac2a6e74575535dd6858cdbeaf by Andreas 
Sturmlechner to branch master.


Repository: kwallet


Description
---

If Gpgmepp is not found, try to use KF5Gpgmepp


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt d7e9ca2c9891db811ecf7063d15f829cf34ad52b 
  src/runtime/kwalletd/backend/CMakeLists.txt 
20bd4d95c3c1b0cfa43cbe71ce73fa699515ecfa 
  tests/kwalletd/CMakeLists.txt c84c1db6003412b6a7ac2768f171cbab380b376c 

Diff: https://git.reviewboard.kde.org/r/129071/diff/


Testing
---

Builds and links fine with either GpgME-1.7.0 or KF5Gpgmepp present.


Thanks,

Andreas Sturmlechner

Re: Review Request 129071: Use Gpgmepp from GpgME-1.7.0

[Andreas Sturmlechner]

> On Oct. 8, 2016, 4:19 p.m., David Faure wrote:
> > Oh sorry, I read the sentence "If Gpgmepp is not found, try to use 
> > KF5Gpgmepp" as if that meant the new bit was that fallback. Doh.
> > 
> > This is a good change then :-)

First commit converts to GpgME, then the second commit adds back KF5Gpgmepp. So 
when 16.12.0 is out, and/or distros have had enough time to pick up 
>=GpgME-1.7.0, dropping KF5Gpgmepp should be a simple revert.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129071/#review99853
---


On Sept. 29, 2016, 11:32 a.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129071/
> ---
> 
> (Updated Sept. 29, 2016, 11:32 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> If Gpgmepp is not found, try to use KF5Gpgmepp
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/CMakeLists.txt 
> d7e9ca2c9891db811ecf7063d15f829cf34ad52b 
>   src/runtime/kwalletd/backend/CMakeLists.txt 
> 20bd4d95c3c1b0cfa43cbe71ce73fa699515ecfa 
>   tests/kwalletd/CMakeLists.txt c84c1db6003412b6a7ac2768f171cbab380b376c 
> 
> Diff: https://git.reviewboard.kde.org/r/129071/diff/
> 
> 
> Testing
> ---
> 
> Builds and links fine with either GpgME-1.7.0 or KF5Gpgmepp present.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 129071: Use Gpgmepp from GpgME-1.7.0

[Andreas Sturmlechner]

> On Oct. 8, 2016, 3:13 p.m., David Faure wrote:
> > This seems like a reverse dependency to me, kwallet (a framework) depending 
> > on kde/pim/gpgmepp. 
> > Is it planned to turn gpgmepp into a framework?
> > If yes, then let's do that.
> > If no, then 1) it's wrongly named, the pim people have been abusing the KF5 
> > prefix for things that are not framework
> > and 2) kwallet can't depend on it.

Well, this is the status quo. ;) kwallet so far was optionally able to use 
KF5Gpgmepp, but this has now moved into GpgME, which the review addresses:

https://mail.kde.org/pipermail/release-team/2016-September/009732.html


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129071/#review99851
-------


On Sept. 29, 2016, 11:32 a.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129071/
> ---
> 
> (Updated Sept. 29, 2016, 11:32 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> If Gpgmepp is not found, try to use KF5Gpgmepp
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/CMakeLists.txt 
> d7e9ca2c9891db811ecf7063d15f829cf34ad52b 
>   src/runtime/kwalletd/backend/CMakeLists.txt 
> 20bd4d95c3c1b0cfa43cbe71ce73fa699515ecfa 
>   tests/kwalletd/CMakeLists.txt c84c1db6003412b6a7ac2768f171cbab380b376c 
> 
> Diff: https://git.reviewboard.kde.org/r/129071/diff/
> 
> 
> Testing
> ---
> 
> Builds and links fine with either GpgME-1.7.0 or KF5Gpgmepp present.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Review Request 129071: Use Gpgmepp from GpgME-1.7.0

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129071/
---

Review request for KDE Frameworks.


Repository: kwallet


Description
---

If Gpgmepp is not found, try to use KF5Gpgmepp


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt d7e9ca2c9891db811ecf7063d15f829cf34ad52b 
  src/runtime/kwalletd/backend/CMakeLists.txt 
20bd4d95c3c1b0cfa43cbe71ce73fa699515ecfa 
  tests/kwalletd/CMakeLists.txt c84c1db6003412b6a7ac2768f171cbab380b376c 

Diff: https://git.reviewboard.kde.org/r/129071/diff/


Testing
---

Builds and links fine with either GpgME-1.7.0 or KF5Gpgmepp present.


Thanks,

Andreas Sturmlechner

Re: Review Request 129012: kwallet: Add missing boost header

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129012/
---

(Updated Sept. 25, 2016, 10:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 0ae542bfa6e266ead736d6cca5f979dac75e24f2 by Andreas 
Sturmlechner to branch master.


Repository: kwallet


Description
---

Fixes build error with GpgME-1.7.0 (which was ported away from boost).

A second commit also removes a duplicate search for KF5DocTools with wrong 
version requirement (done from root CMakeLists.txt already)


Diffs
-

  docs/kwallet-query/CMakeLists.txt c4ef9c73a9fb41dbd94d237e7af90c48fdd3828f 
  src/runtime/kwalletd/kwalletwizard.cpp 
bf36f3b37795d39d0f523175dc72a7294ab9257b 

Diff: https://git.reviewboard.kde.org/r/129012/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129012: kwallet: Add missing boost header

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129012/
---

(Updated Sept. 25, 2016, 1:07 p.m.)


Review request for KDE Frameworks.


Changes
---

fixed $summary...


Summary (updated)
-

kwallet: Add missing boost header


Repository: kwallet


Description (updated)
---

Fixes build error with GpgME-1.7.0 (which was ported away from boost).

A second commit also removes a duplicate search for KF5DocTools with wrong 
version requirement (done from root CMakeLists.txt already)


Diffs
-

  docs/kwallet-query/CMakeLists.txt c4ef9c73a9fb41dbd94d237e7af90c48fdd3828f 
  src/runtime/kwalletd/kwalletwizard.cpp 
bf36f3b37795d39d0f523175dc72a7294ab9257b 

Diff: https://git.reviewboard.kde.org/r/129012/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Review Request 129012: Remove duplicate search for KF5DocTools

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129012/
---

Review request for KDE Frameworks.


Repository: kwallet


Description
---

Add missing boost header

Fixes build error with GpgME-1.7.0 (which was ported away from boost).


Diffs
-

  docs/kwallet-query/CMakeLists.txt c4ef9c73a9fb41dbd94d237e7af90c48fdd3828f 
  src/runtime/kwalletd/kwalletwizard.cpp 
bf36f3b37795d39d0f523175dc72a7294ab9257b 

Diff: https://git.reviewboard.kde.org/r/129012/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 128582: Remove unused KF5 dependencies

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128582/#review98658
---



lddtree /usr/lib64/libKF5KrossUi.so is listing all these three dependencies 
still in use.

- Andreas Sturmlechner


On Aug. 3, 2016, 2:23 a.m., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128582/
> ---
> 
> (Updated Aug. 3, 2016, 2:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> ---
> 
> Remove unused KF5 dependencies
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
> 
> Diff: https://git.reviewboard.kde.org/r/128582/diff/
> 
> 
> Testing
> ---
> 
> Still compiles successfully.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128576/#review98020
---



Works for me, thanks!

- Andreas Sturmlechner


On Aug. 2, 2016, 12:11 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128576/
> ---
> 
> (Updated Aug. 2, 2016, 12:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 362531
> https://bugs.kde.org/show_bug.cgi?id=362531
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> The Xcb implementation of KWindowSystem has two operations modes and when
> switching between the two it recreates the NETEventFilter.
> 
> This could result in the compositingChanged signal never to be emitted if:
> 1) NETEventFilter gets created before compositor is started
> 2) NETEventFilter gets recreated after compositor is started but before
>the old filter had a chance to process the XFixes event
> 
> This was the cause for e.g. plasmashell not properly detecting that a
> Compositor is running on X11.
> 
> This change ensures that the signal is emitted if the compositing state
> differs after the recreation. Also a test case is added which simulates
> the condition.
> 
> BUG: 362531
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 690c41bfe2ca981d206c590c3fbd28416d4ae401 
>   autotests/compositingenabled_test.cpp PRE-CREATION 
>   src/platforms/xcb/kwindowsystem.cpp 
> fbff381b61116c6eef47d5c7fa1fc5730857328c 
> 
> Diff: https://git.reviewboard.kde.org/r/128576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/#review93640
---



works for me, thanks!

- Andreas Sturmlechner


On March 17, 2016, 9:37 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127410/
> ---
> 
> (Updated March 17, 2016, 9:37 a.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.
> 
> 
> Bugs: 360488
> https://bugs.kde.org/show_bug.cgi?id=360488
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fix crash in rename dialog
> 
> ResizePanels must only be called in case of overwrite, all other cases 
> violate the preconditions.
> 
> @Andreas: Can you please try the patch?
> 
> 
> Diffs
> -
> 
>   src/widgets/renamedialog.cpp 2d456c7 
> 
> Diff: https://git.reviewboard.kde.org/r/127410/diff/
> 
> 
> Testing
> ---
> 
> Yes, I tried it by overwriting a file with the same file and with a different 
> file -> no crash :)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126130: [kholidays] Qt5Core should be required, not Qt5Test

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126130/
---

(Updated Nov. 22, 2015, 1:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and John Layt.


Changes
---

Submitted with commit 88b12a318bae81d5f832d46e21ca2f9b2826a677 by Andreas 
Sturmlechner to branch Applications/15.12.


Repository: kholidays


Description
---

The latter is already being searched for in autotests directory.


Diffs
-

  CMakeLists.txt e58feabf5c8067d88c349523868633f44ddd037c 

Diff: https://git.reviewboard.kde.org/r/126130/diff/


Testing
---

Built fine, autotests fine.


Thanks,

Andreas Sturmlechner

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel