Re: version numbers towards kf6

[Heiko Becker]

On Monday, 26 June 2023 17:32:18 CEST, Jos van den Oever wrote:

On 26/06/2023 17.27, Heiko Becker wrote:

On Monday, 26 June 2023 14:06:04 CEST, Jos van den Oever wrote: ...


So that the user can see that they are running a snapshot and 
not an official release and to make it easy to report the 
correct version/snapshot in bug reports. Getting users to test 
and submit useful bug reports is the goal of these snapshot 
builds.


I don't think it's possible to override PROJECT_VERSION, which for obvious 
reasons is an upstream choice and may influence other things like 
soversion.


But I think you can use the qt6 keyword to tag bug reports.

Re: version numbers towards kf6

[Heiko Becker]

On Monday, 26 June 2023 14:06:04 CEST, Jos van den Oever wrote:

On 26/06/2023 13.15, Heiko Becker wrote:

On Monday, 26 June 2023 11:13:56 CEST, Jos van den Oever wrote:
The new versions of frameworks, plasma and gear presumably 
all start with '6'. Following Fedora versioning for snapshots 
[0] gives this:


 6^20230627git5328c27e3


Like Jonathan said, versioning of snapshots is a downstream 
thing. But if I understand the ^ operator correctly, doesn't 
sort 6^20230.. *after* 6.0?


Indeed, it should be 6~20230627git5328c27e3 or 6.0.0~20230627git5328c27e3.

And no, new versions of Gear won't start with '6'. They follow 
a different versioning scheme and some projects will probably 
switch to Qt6/KF6 with 22.12, some with 23.04 or later.


I guess you mean 23.12 and 24.04. Time flies.


Yeah, indeed.


What is the best way to override the version numbers of KF6?
  cmake -DPROJECT_VERSION_MAJOR=6 ?
Since there is no suffix support this would falsely indicate 
that it's already version 6 instead of a snapshot working 
towards it.


Why do you want to override it it?

Re: version numbers towards kf6

[Heiko Becker]

On Monday, 26 June 2023 11:13:56 CEST, Jos van den Oever wrote:
The new versions of frameworks, plasma and gear presumably all 
start with '6'. Following Fedora versioning for snapshots [0] 
gives this:


 6^20230627git5328c27e3


Like Jonathan said, versioning of snapshots is a downstream thing. But if I 
understand the ^ operator correctly, doesn't sort 6^20230.. *after* 6.0?


And no, new versions of Gear won't start with '6'. They follow a different 
versioning scheme and some projects will probably switch to Qt6/KF6 with 
22.12, some with 23.04 or later.


Regards,
Heiko

D29303: Make KI18N_INSTALL() compatible to KDE_INSTALL_DIRS_NO_DEPRECATED

[Heiko Becker]

heikobecker added a comment.


  In D29303#677015 , @dfaure wrote:
  
  > So this is basically the same as https://phabricator.kde.org/D29136 except 
that D29136  gives priority to the 
non-deprecated variable. Any reason against going with D29136 
 after all?
  
  
  Not from me.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29303

To: kossebau, ilic, heikobecker
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

[Heiko Becker]

heikobecker added a comment.


  How do we move this or https://phabricator.kde.org/D29136 forward? @ilic As a 
maintainer, do you have an opinion?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29299

To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

[Heiko Becker]

heikobecker reclaimed this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29136

To: heikobecker
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

[Heiko Becker]

heikobecker abandoned this revision.
heikobecker added a comment.


  Abandoned in favour of https://phabricator.kde.org/D29136

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29136

To: heikobecker
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

[Heiko Becker]

heikobecker added a comment.


  Fixes the problem I had with marble, which prompted the creation of 
https://phabricator.kde.org/D29136. Passing the destination as an parameter 
seems indeed like a better way, so +1 from me.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29299

To: kossebau, ilic, heikobecker
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

[Heiko Becker]

heikobecker added a comment.


  > Where would you see "that the macro already used KDEInstallDirs before"? 
When it comes to "LOCALE_INSTALL_DIR", that is set to a default is not set when 
calling the macro. Ideally would be documented though. (my first approach would 
be to also allow a soft dependency here on KDEInstallDirs, checking whether 
KDE_INSTALL_LOCALEDIR is defined and picking its value), similar with 
CMAKE_INSTALL_LOCALEDIR to support GnuInstallDirs automatically).
  
  As you indicate, if one calls ki18_install() in a project which includes 
KDEInstallDirs before that call (and KDE_INSTALL_DIRS_NO_DEPRECATED isn't set) 
the value of LOCALE_INSTALL_DIR is used instead of the default "share/locale". 
I extended the same to check K_I_LOCALEDIR (line 99+). Isn't that the soft 
dependency you suggested (minus the GnuInstallDirs part, obviously?)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29136

To: heikobecker
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

[Heiko Becker]

heikobecker added a comment.


  In D29136#660270 , @kossebau wrote:
  
  > using kdeinstalldirs variables needs to ensure that KDEInstallDirs has been 
included before, also introduces ahard  dependency on ECM for any users of 
KI18n. While 99% of apps using KI18n might do this, by design idea of KDE 
Frameworks KI18n as tier1 should not pull in another dependency, even ECM (so 
someone using plain cmake & GnuInstallDirs should be still able to use tier1 
stuff). This needs some more pondering then...
  
  
  Isn't that a mere theoretical concern? At least when building ki18n yourself, 
you need ECM anyway, which is easy to install and almost infinitesimal small in 
size compared to Qt. And btw, where is the "should not pull in another 
dependency, even ECM" documentend? I only know of "Tier 1 Frameworks can depend 
only on Qt official frameworks or other system libraries" [1], which admittedly 
already creates a discrepancy with the ECM (build) requirement of ki18n itself.
  
  I'd also note that the macro already used KDEInstallDirs before, apparently 
without anybody complaining about it, even though I don't want to cargo cult 
this. Furthermore I'm not sure how to solve the bug I encountered differently, 
other than making marble stop using KDE_INSTALL_DIRS_NO_DEPRECATED (or using 
GnuInstallDirs, which possibly might break existing things).
  
  [1] https://community.kde.org/Frameworks/Policies

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29136

To: heikobecker
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

[Heiko Becker]

heikobecker updated this revision to Diff 81035.
heikobecker added a comment.


  Added missing parentheses

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29136?vs=81033=81035

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29136

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: heikobecker
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  I noticed that when installeding marble, which sets
  KDE_INSTALL_DIRS_NO_DEPRECATED, which then invalidates a possibly
  custom location set via KDEInstallIDirs, causing translations to
  land in a surprising locations.

TEST PLAN
  Marble's translations land in the desired location

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29136

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: heikobecker
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28108: Handle busybox's sed like GNU sed

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:0855a40a1131: Handle busyboxs sed like GNU sed 
(authored by heikobecker).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28108?vs=77864=77880

REVISION DETAIL
  https://phabricator.kde.org/D28108

AFFECTED FILES
  generate-24px-versions.sh

To: heikobecker, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28108: Handle busybox's sed like GNU sed

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  Otherwise it uses the POSIX-style and fails with "sed: : No such file
  or directory".

TEST PLAN
  Built fine with busybox's sed

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28108

AFFECTED FILES
  generate-24px-versions.sh

To: heikobecker, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25795: Rename kf5quickcharts_example to kquickcharts_example

[Heiko Becker]

heikobecker closed this revision.
heikobecker added a comment.


  In D25795#612749 , @ahiemstra 
wrote:
  
  > @heikobecker This patch has been open for a long time... Do you have commit 
access or do you need someone to commit it for you?
  
  
  I have and I already committed it: 
https://cgit.kde.org/kquickcharts.git/commit/?id=e3ae6f929ebc5cb5f7cc4086bb98a21f382b2119
 No idea why this wasn't closed automatically.

REVISION DETAIL
  https://phabricator.kde.org/D25795

To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

[Heiko Becker]

heikobecker added a comment.


  In D25794#612748 , @ahiemstra 
wrote:
  
  > @heikobecker This patch has been open for a long time... Do you have commit 
access or do you need someone to commit it for you?
  
  
  I have and I already committed it: 
https://cgit.kde.org/kquickcharts.git/commit/?id=d9d724b013024d3c332cc3bf9da02ff211637ebb
 No idea why this wasn't closed automatically.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25794

To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

[Heiko Becker]

heikobecker closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D25794

To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25795: Rename kf5quickcharts_example to kquickcharts_example

[Heiko Becker]

heikobecker created this revision.
heikobecker added reviewers: Frameworks, ahiemstra.
heikobecker requested review of this revision.

REVISION SUMMARY
  Matching the project name.

TEST PLAN
  exmaple is installed under the new name, runs fine

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25795

AFFECTED FILES
  examples/charts/CMakeLists.txt

To: heikobecker, #frameworks, ahiemstra

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

[Heiko Becker]

heikobecker created this revision.
heikobecker added reviewers: Frameworks, ahiemstra.
heikobecker requested review of this revision.

REVISION SUMMARY
  Allows the test to run without a display server.

TEST PLAN
  Builds, test still passes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25794

AFFECTED FILES
  autotests/ArraySourceTest.cpp

To: heikobecker, #frameworks, ahiemstra

D21695: Add FindTaglib.cmake

[Heiko Becker]

heikobecker added a comment.


  I'm not entirely sure about taglib-config on Windows and Android (can't test 
there), but similar to pkg-config I omitted the special casing. Tried to test 
this by moving taglib-config out of the way on Linux and a taglib install in 
default locations, which worked fine.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21695

To: heikobecker, kde-buildsystem, kde-frameworks-devel
Cc: LeGast00n, bencreasy, michaelh, ngraham, bruns

D21695: Add FindTaglib.cmake

[Heiko Becker]

heikobecker created this revision.
heikobecker added reviewers: kde-buildsystem, kde-frameworks-devel.
Herald added projects: Frameworks, Build System.
heikobecker requested review of this revision.

REVISION SUMMARY
  The old one from KDELibs4 times is used by several projects from
  Frameworks, KDE Applications and Extragear.
  Modernized according the current cmake coding style but it also
  keeps compatibility with the old find module for now and should be
  a drop-in replacement.

TEST PLAN
  Removed the bundled FindTaglib.cmake from kfilemetadata, kio-extras,
  juk, amarok and rename and built them successfully.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21695

AFFECTED FILES
  find-modules/FindTaglib.cmake

To: heikobecker, kde-buildsystem, kde-frameworks-devel
Cc: LeGast00n, bencreasy, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Heiko Becker]

heikobecker added a comment.


  > no, it is only used in kio internally by klauncher to start io slaves.
  
  at least kinit disagrees:
  
src/klauncher/klauncher.cpp:1021
arg_list.prepend(QLatin1String("kioslave"));

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: bcooksley, heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, 
bruns

D17650: Install kioslave as kioslave5 on Windows

[Heiko Becker]

heikobecker added a comment.


  In D17650#379396 , @habacker wrote:
  
  > I think this is unrelated - this request is to fix an issue with an 
available package on a distribution, so can anyone accept this ?
  
  
  I'd argue that the problem is with your distribution. Everybody still 
shipping qt4 is on its own anyway, seeing that it's not possible to upstream 
patches (and there are quite a few needed to keep it building) as the git repo 
is locked down. And I'm pretty sure this patch breaks at least one other 
framework. Additionally there might be future maintenance costs, so I see no 
reason to flog a dead horse and penalize everybody else for it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns

D17479: Fix build without phonon

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R305:78a1dcc794f5: Fix build without Phonon (authored by 
heikobecker).

REPOSITORY
  R305 KNotifyConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17479?vs=47283=47288

REVISION DETAIL
  https://phabricator.kde.org/D17479

AFFECTED FILES
  src/CMakeLists.txt

To: heikobecker, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17479: Fix build without phonon

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  f6d55baf5aa88eaab6b2f96c025064f081d13cea 
 
replaced ${PHONON_LIBS} with
  Phonon's imported target. This breaks in the case when Phonon isn't
  found or disabled via -DCMAKE_DISABLE_FIND_PACKAGES_Phonon4Qt5=TRUE
  because the imported target isn't known. It worked previously because
  was ${PHONON_LIBS} just empty when Phonon wasn't available.

TEST PLAN
  Building without phonon works now and and it still builds
  with phonon available and successfully links to it.

REPOSITORY
  R305 KNotifyConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17479

AFFECTED FILES
  src/CMakeLists.txt

To: heikobecker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

[Heiko Becker]

heikobecker accepted this revision.
heikobecker added a comment.
This revision is now accepted and ready to land.


  I can confirm that the crash doesn't occur anymore.

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16183

To: dfaure, heikobecker, aacid, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Heiko Becker]

heikobecker added a comment.


  In D15251#322168 , @kossebau wrote:
  
  > ...as well as request to finally enable BUILD_QCH on CI, so this is covered.
  
  
  I wondered why that's not the case. I, for one, would welcome it.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:7b2936a6d673: Fix autotests with -DBUILD_QCH:BOOL=TRUE 
(authored by heikobecker).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15251?vs=40932=41194

REVISION DETAIL
  https://phabricator.kde.org/D15251

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, kossebau, habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Heiko Becker]

heikobecker added reviewers: kossebau, habacker.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D15251

To: heikobecker, kossebau, habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  After 507415c54bd111fbb35716bd9809119d990f9a16 
 
KF5I18nQchTargets.cmake
  needs similar adjustments.

TEST PLAN
  The test passes again, KF5I18nQchTargets is still installed

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15251

AFFECTED FILES
  CMakeLists.txt

To: heikobecker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14008: Use QTEST_GUILESS_MAIN

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:3a82a775b1c3: Use QTEST_GUILESS_MAIN (authored by 
heikobecker).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14008?vs=37463=39143

REVISION DETAIL
  https://phabricator.kde.org/D14008

AFFECTED FILES
  autotests/configtest.cpp
  autotests/providertest.cpp

To: heikobecker, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14008: Use QTEST_GUILESS_MAIN

[Heiko Becker]

heikobecker added a comment.


  Ping?

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D14008

To: heikobecker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14541: ECMOptionalAddSubdirectory: Provide a bit more detail

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:59b311bcc2ed: ECMOptionalAddSubdirectory: Provide a bit 
more detail (authored by heikobecker).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14541?vs=38911=38915

REVISION DETAIL
  https://phabricator.kde.org/D14541

AFFECTED FILES
  modules/ECMOptionalAddSubdirectory.cmake

To: heikobecker, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14541: ECMOptionalAddSubdirectory: Provide a bit more detail

[Heiko Becker]

heikobecker created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
heikobecker requested review of this revision.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14541

AFFECTED FILES
  modules/ECMOptionalAddSubdirectory.cmake

To: heikobecker
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14008: Use QTEST_GUILESS_MAIN

[Heiko Becker]

heikobecker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  Allowing the tests to pass without a running X server.

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14008

AFFECTED FILES
  autotests/configtest.cpp
  autotests/providertest.cpp

To: heikobecker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12872: ScalableTest, add "scalable" plasma-browser-integration

[Heiko Becker]

heikobecker added a comment.


  +1
  
  Btw, this is BUG: 393999

REPOSITORY
  R266 Breeze Icons

BRANCH
  scalable_pbi (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12872

To: maximilianocuria, #frameworks, dfaure, andreaska, andreask
Cc: heikobecker, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
heikobecker marked an inline comment as done.
Closed by commit R249:918e304f057b: KF5I18NMacros: Dont install an empty 
dir when no po files exist (authored by heikobecker).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12905?vs=34222=35777

REVISION DETAIL
  https://phabricator.kde.org/D12905

AFFECTED FILES
  cmake/KF5I18NMacros.cmake.in

To: heikobecker, ilic, ltoscano
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Heiko Becker]

heikobecker marked an inline comment as done.
heikobecker added a comment.


  Considering the feedback I'll probably merge this in a few days if no 
objections turn up in the meantime.

INLINE COMMENTS

> ltoscano wrote in KF5I18NMacros.cmake.in:138-139
> I guess that those two lines are the critical parts (the call to file), but 
> probably it's not bad to avoid processing other instructions too.

Yes. And that was my thought as well and reason to move the rest inside the if

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Heiko Becker]

heikobecker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  I saw this happen with kdecoration from git since
  64d9f92f6a8708814f414dda0bb0d0e91c27235f 
. 
The directory passed in
  its ki18n_install call doesn't exist, resulting in an empty
  directory (LOCALE_INSTALL_DIR) getting installed, which at least
  some packaging systems don't like.

TEST PLAN
  Tested with kdecoration from git and tarballs where podir
  exists

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12905

AFFECTED FILES
  cmake/KF5I18NMacros.cmake.in

To: heikobecker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

[Heiko Becker]

heikobecker added a comment.


  In D12216#247225 , @apol wrote:
  
  > I'm unsure if it's worth re-spinning ki18n.
  
  
  It's already out, so it would need a .1, but it may be worth it as it appears 
builds are hanging otherwise.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12216

To: apol, #frameworks, arojas
Cc: heikobecker, michaelh, ngraham, bruns

D12225: Also make installation of translated docs optional

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R317:03d503362514: Also make installation of translated docs 
optional (authored by heikobecker).

REPOSITORY
  R317 Kross

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12225?vs=32186=32273

REVISION DETAIL
  https://phabricator.kde.org/D12225

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #frameworks, apol
Cc: michaelh, ngraham, bruns

D12225: Also make installation of translated docs optional

[Heiko Becker]

heikobecker created this revision.
heikobecker added reviewers: Frameworks, apol.
Restricted Application added a project: Frameworks.
heikobecker requested review of this revision.

REVISION SUMMARY
  76f3f5b541eea8128297e68bd80278e7f525c1aa 
 
made the dependency on
  KF5DocTools optional but forgot one instance when localized
  docs are installed, which will go unnoticed when one installs
  from git.

TEST PLAN
  Built with -DCMAKE_DISABLE_FIND_PACKAGE_KF5DocTools=TRUE

REPOSITORY
  R317 Kross

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12225

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #frameworks, apol
Cc: michaelh, ngraham, bruns

D10340: Clean up old, unreachable code

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R306:7387d21c4516: Clean up old, unreachable code (authored by 
heikobecker).

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10340?vs=26647=27537

REVISION DETAIL
  https://phabricator.kde.org/D10340

AFFECTED FILES
  src/CMakeLists.txt
  src/browserrun_p.h

To: heikobecker, #frameworks, dfaure
Cc: elvisangelaccio, michaelh

D10339: Drop obsolete version checks

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R306:faf16778ea6b: Drop obsolete version checks (authored by 
heikobecker).

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10339?vs=26646=26660

REVISION DETAIL
  https://phabricator.kde.org/D10339

AFFECTED FILES
  src/browserextension.h
  src/liveconnectextension.h

To: heikobecker, #frameworks, apol
Cc: michaelh, ngraham

D10340: Clean up old, unreachable code

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
heikobecker requested review of this revision.

REVISION SUMMARY
  Nepomuk is never searched for, so the removed code wasn't used in a
  long time. Furthermore Nepomuk is pretty dead.

REPOSITORY
  R306 KParts

BRANCH
  cleanupnepomuk

REVISION DETAIL
  https://phabricator.kde.org/D10340

AFFECTED FILES
  src/CMakeLists.txt
  src/browserrun_p.h

To: heikobecker, #frameworks
Cc: michaelh, ngraham

D10339: Drop obsolete version checks

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
heikobecker requested review of this revision.

REVISION SUMMARY
  Frameworks already require Qt 5.7.0.

REPOSITORY
  R306 KParts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10339

AFFECTED FILES
  src/browserextension.h
  src/liveconnectextension.h

To: heikobecker, #frameworks
Cc: michaelh, ngraham

D8672: Fix build with LibreSSL

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
heikobecker marked an inline comment as done.
Closed by commit R239:00cae452ac61: Fix build with LibreSSL (authored by 
heikobecker).

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8672?vs=23309=23310

REVISION DETAIL
  https://phabricator.kde.org/D8672

AFFECTED FILES
  src/kssl/kopenssl.cpp
  src/kssl/kopenssl.h
  src/kssl/ksslcertificate.cpp

To: heikobecker, #frameworks, #freebsd, dfaure
Cc: dfaure, asturmlechner

D8672: Fix build with LibreSSL

[Heiko Becker]

heikobecker marked an inline comment as done.
heikobecker added inline comments.

INLINE COMMENTS

> dfaure wrote in ksslcertificate.cpp:1225
> This seems to be missing parenthesis...
> 
> KSSL_HAVE_SSL && ( ... || ... )

Thanks, added.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D8672

To: heikobecker, #frameworks, #freebsd, dfaure
Cc: dfaure, asturmlechner

D8672: Fix build with LibreSSL

[Heiko Becker]

heikobecker marked an inline comment as done.
heikobecker added inline comments.

INLINE COMMENTS

> dfaure wrote in kopenssl.cpp:1047
> this syntax will lead to a preprocessor warning when LIBRESSL_VERSION_NUMBER 
> isn't defined.
> Did you mean `|| defined(...)` ?

Yeah, that's indeed better...

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D8672

To: heikobecker, #frameworks, #freebsd, dfaure
Cc: dfaure, asturmlechner

D8672: Fix build with LibreSSL

[Heiko Becker]

heikobecker updated this revision to Diff 23301.
heikobecker added a comment.


  Added define(..)

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8672?vs=21939=23301

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8672

AFFECTED FILES
  src/kssl/kopenssl.cpp
  src/kssl/kopenssl.h
  src/kssl/ksslcertificate.cpp

To: heikobecker, #frameworks, #freebsd, dfaure
Cc: dfaure, asturmlechner

D8672: Fix build with LibreSSL

[Heiko Becker]

heikobecker added a reviewer: FreeBSD.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D8672

To: heikobecker, #frameworks, #freebsd

D8672: Fix build with LibreSSL

[Heiko Becker]

heikobecker added a comment.


  Ping?

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D8672

To: heikobecker, #frameworks

D8672: Fix build with LibreSSL

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Unfortunately LibreSSL sets OPENSSL_VERSION_NUMBER to
  0x2000L and doesn't support the OpenSSL 1.1 API.

TEST PLAN
  Builds with LibreSSL

REPOSITORY
  R239 KDELibs4Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8672

AFFECTED FILES
  src/kssl/kopenssl.cpp
  src/kssl/kopenssl.h
  src/kssl/ksslcertificate.cpp

To: heikobecker, #frameworks

D7478: Escape hyphen in rest.xml regular expressions

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ad077e4045e6: Escape hyphen in rest.xml regular 
expressions (authored by heikobecker).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7478?vs=18602=18603

REVISION DETAIL
  https://phabricator.kde.org/D7478

AFFECTED FILES
  data/syntax/rest.xml

To: heikobecker, #framework_syntax_hightlighting, kfunk, vkrause
Cc: dhaumann, alexeymin, #frameworks

D7478: Escape hyphen in rest.xml regular expressions

[Heiko Becker]

heikobecker updated this revision to Diff 18602.
heikobecker added a comment.


  Increased version

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7478?vs=18584=18602

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7478

AFFECTED FILES
  data/syntax/rest.xml

To: heikobecker, #framework_syntax_hightlighting, kfunk, vkrause
Cc: dhaumann, alexeymin, #frameworks

D7478: Escape hyphen in rest.xml regular expressions

[Heiko Becker]

heikobecker added a comment.


  In https://phabricator.kde.org/D7478#138855, @alexeymin wrote:
  
  > Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ?
  
  
  Wasn't aware of the bug report, but yes. Will add a BUG: reference before 
pushing if this is accepted.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7478

To: heikobecker, #framework_syntax_hightlighting, kfunk
Cc: alexeymin, #frameworks

D7478: Escape hyphen in rest.xml regular expressions

[Heiko Becker]

heikobecker updated this revision to Diff 18584.
heikobecker added a comment.


  Removed accidentally included change.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7478?vs=18583=18584

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7478

AFFECTED FILES
  data/syntax/rest.xml

To: heikobecker, #framework_syntax_hightlighting, kfunk
Cc: #frameworks

D7478: Escape hyphen in rest.xml regular expressions

[Heiko Becker]

heikobecker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The unescaped hyphen caused a build failure with pcre2-10.30 due to a broken
  regex: 'syntax-highlighting/data/syntax/rest.xml" line 27 broken regex:
  "^\\s*\\.\\. [w-_\\.]+::(\\s|$)" problem: "range out of order in character
  class" at offset 12'.
  
  The pcre2pattern documentation says this:
  
  "Perl treats a hyphen as a literal if it appears before or after a POSIX class
  (see below) or before or after a character type escape such as as \d or \H.
  However, unless the hyphen is the last character in the class, Perl outputs a
  warning in its warning mode, as this is most likely a user error. As PCRE2 has
  no facility for warning, an error is given in these cases."

TEST PLAN
  cmake && make && make test works fine pcre2-10.30, quick look at
  http://docutils.sourceforge.net/FAQ.txt in kate seems fine.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7478

AFFECTED FILES
  CMakeLists.txt
  data/syntax/rest.xml

To: heikobecker, #framework_syntax_hightlighting, kfunk
Cc: #frameworks

D7239: Drop unused dependency

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:478b31fd1b92: Drop unused dependency (authored by 
heikobecker).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7239?vs=17984=18528

REVISION DETAIL
  https://phabricator.kde.org/D7239

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #plasma, #frameworks, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7239: Drop unused dependency

[Heiko Becker]

heikobecker added a reviewer: Frameworks.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D7239

To: heikobecker, #plasma, #frameworks
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

[Heiko Becker]

heikobecker added a comment.


  Ping? Not sure what to do with this, still would like to hear something from 
@skelly. Or should I just go ahead and use ClangConfig.cmake (meaning dropping 
the version requirement, I don't have any older clang versions around to easily 
test it.)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5289

To: heikobecker, #frameworks, #build_system, skelly, kfunk
Cc: rdieter, shaheed, kde-buildsystem, lbeltrame

D4051: kcm_useraccount is dead, long live user_manager

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:8f81a80f5dd9: kcm_useraccount is dead, long live 
user_manager (authored by heikobecker).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4051?vs=9935=14061

REVISION DETAIL
  https://phabricator.kde.org/D4051

AFFECTED FILES
  src/kbugreport.cpp

To: heikobecker, #frameworks, aacid

D4051: kcm_useraccount is dead, long live user_manager

[Heiko Becker]

heikobecker added a comment.


  Ping?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D4051

To: heikobecker, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

[Heiko Becker]

heikobecker added a comment.


  In https://phabricator.kde.org/D5413#102273, @dfaure wrote:
  
  > Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the 
user is told about the optional deps they're missing?
  >  Not sure if that works for KF5 components.
  
  
  No, OPTIONAL is the default. But I'd say that using 
set_package_properties(...) including a meaningful "DESCRIPTION" and "PURPOSE" 
(e.g. like it's done for the other optional deps) is much nicer to packagers 
and others who try to build kfilemetadata.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5413

To: mgallien
Cc: heikobecker, dfaure, #frameworks

D5274: extractorcollectiontest: Use QTEST_GUILESS_MAIN

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:6d7468be4cc6: autotests: Use QTEST_GUILESS_MAIN (authored 
by heikobecker).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5274?vs=13044=13099#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5274?vs=13044=13099

REVISION DETAIL
  https://phabricator.kde.org/D5274

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/exiv2extractortest.cpp
  autotests/externalextractortest.cpp
  autotests/externalwritertest.cpp
  autotests/extractorcollectiontest.cpp
  autotests/indexerextractortests.cpp
  autotests/mobiextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/popplerextractortest.cpp
  autotests/propertyinfotest.cpp
  autotests/taglibextractortest.cpp
  autotests/taglibwritertest.cpp

To: heikobecker, #frameworks, mgallien
Cc: mgallien

D5291: FindPyModGen: Also search for an unversioned clang++

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:47a4c068a4ec: FindPyModGen: Also search for an 
unversioned clang++ (authored by heikobecker).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5291?vs=13073=13098

REVISION DETAIL
  https://phabricator.kde.org/D5291

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: heikobecker, #frameworks, #build_system, apol

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

[Heiko Becker]

heikobecker added a comment.


  In https://phabricator.kde.org/D5289#99625, @shaheed wrote:
  
  > Fwiw, I think that a specific version check may not be needed. The original
  >  code I wrote, which I assume Steve may have simply carried forward in the
  >  cmake ecm logic, DID have a version check but only because the python
  >  bindings were newish circa libclang 3.8.
  
  
  I'm certainly open to using ClangConfig.cmake and would even prefer it, but I 
guess I'll wait for feedback from Steve about the version requirement.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5289

To: heikobecker, #frameworks, #build_system, skelly, kfunk
Cc: rdieter, shaheed, kde-buildsystem, lbeltrame

D5290: FindPyModGen: Don't hard-code share dir

[Heiko Becker]

heikobecker added a comment.


  In https://phabricator.kde.org/D5290#99713, @apol wrote:
  
  > That's not how ECM is intended to work, these find modules are supposed to 
be separate from the variables we use in KDE.
  
  
  
  
  > What problem are you trying to address?
  
  My distro uses a different approach to multiarch than e.g. Debian. We have 
use /usr/arch as prefix but arch independent files live below the prefix in 
/usr/share.
  
  Would it be acceptable to use the equivalent variable from GNUInstallDirs?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5290

To: heikobecker, #frameworks, #build_system
Cc: apol

D5291: FindPyModGen: Also search for an unversioned clang++

[Heiko Becker]

heikobecker created this revision.
Restricted Application added projects: Frameworks, Build System.

REVISION SUMMARY
  While my distro does have a versioned clang executable, it doesn't
  have a versioned clang++ executable. The versioned executable is
  still searched first, falling back to the unversioned one.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5291

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: heikobecker, #frameworks, #build_system

D5290: FindPyModGen: Don't hard-code share dir

[Heiko Becker]

heikobecker created this revision.
Restricted Application added projects: Frameworks, Build System.

REVISION SUMMARY
  ...but use KDE_INSTALL_DATAROOTDIR instead.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5290

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: heikobecker, #frameworks, #build_system

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

[Heiko Becker]

heikobecker created this revision.
Restricted Application added projects: Frameworks, Build System.

REVISION SUMMARY
  On non Debian-based systems libclang is mostly installed as
  libclang.so., evading detection by
  clang-${_LIBCLANG_FIND_VERSION}.0. Instead of specyfing and maintaing
  a list of library names I imported FindClang from KDevelop, which
  finds the correct library here and, one would assume, also works on
  Debian and distros based on it.
  
  I didn't use ClangConfig.cmake from upstream because it doesn't allow
  discovery of a certain version.

TEST PLAN
  Successfully built kconfig with Python bindings

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5289

AFFECTED FILES
  find-modules/FindClang.cmake
  find-modules/FindLLVM.cmake
  find-modules/FindPythonModuleGeneration.cmake

To: heikobecker, #frameworks, #build_system, skelly, kfunk

D5274: extractorcollectiontest: Use QTEST_GUILESS_MAIN

[Heiko Becker]

heikobecker created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Allowing the tests to pass without a running X server.

TEST PLAN
  Test still passes

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5274

AFFECTED FILES
  autotests/extractorcollectiontest.cpp

To: heikobecker, #frameworks

[Differential] [Closed] D4052: kbugreport: Remove reference to deprecated KCmdLineArgs

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:78ff1ebd4a18: kbugreport: Remove reference to deprecated 
KCmdLineArgs (authored by heikobecker).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4052?vs=9936=9945

REVISION DETAIL
  https://phabricator.kde.org/D4052

AFFECTED FILES
  src/kbugreport.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: heikobecker, #frameworks, aacid

[Differential] [Request, 4 lines] D4052: kbugreport: Remove reference to deprecated KCmdLineArgs

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4052

AFFECTED FILES
  src/kbugreport.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: heikobecker, #frameworks

Re: Shipping prison with next frameworks version

[Heiko Becker]

Hi,

sorry for writing this mail shortly before the tagging of the next
Frameworks release, but I got sidetracked by other things.

On 09/30/16 09:42, David Faure wrote:
> On dimanche 18 septembre 2016 20:03:00 CEST Sune Vuorela wrote:
>> Other than asking sysadmin to move prison from kdesupport to
>> kdeframeworks, are there other bits I'm supposed to do?
>>
>> I *think* I have followed the checklists.
> 
> I see no .yaml file in g...@git.kde.org:prison branch master.

I've added one with
https://commits.kde.org/prison/1b72429bdd256711b1f430367408abe9ddee8186,
added a README.md and a .reviewboard file and adjusted the directory
structure according to Frameworks policies.

> I still see kdesupport/prison rather than frameworks/prison in 
> kde_projects.xml
> 
> It's also missing on https://build.kde.org/view/Frameworks%20kf5-qt5/

I filed a sysadmin ticket for this: https://phabricator.kde.org/T4801

> No autotests ?

I guess one would need something to read back the generated barcodes for
meaningful autotests.

As far as I can see and after looking at
https://community.kde.org/Frameworks/CreationGuidelines and
https://community.kde.org/Frameworks/Policies everything else is ready
for becoming a framework.

Note that I'm not the maintainer. I'm just tired of packaging snapshots
after rather silly version increments because it's already treated like
a framework.

Best regards,
Heiko

Re: Review Request 129559: Also search for hunspell-1.5

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129559/
---

(Updated Nov. 26, 2016, 7:12 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
---

Submitted with commit 5fc1e9679e0607d7d918b27ee13092a234abefe6 by Heiko Becker 
to branch master.


Repository: sonnet


Description
---

Also search for hunspell-1.5


Diffs
-

  cmake/FindHUNSPELL.cmake f028abe 

Diff: https://git.reviewboard.kde.org/r/129559/diff/


Testing
---

Built against hunspell-1.5.0 and successfully ran the tests.


Thanks,

Heiko Becker

Re: Review Request 128992: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128992/
---

(Updated Nov. 25, 2016, 5:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Marco Martin.


Changes
---

Submitted with commit c75362b095fb249e8bc60743c7a3ac2ec6e9ee16 by Heiko Becker 
to branch master.


Repository: kdeclarative


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp 
351d99fc435f9ba8d58269e0b92dab3483f77580 
  src/qmlcontrols/kquickcontrolsaddons/plotter.h 
b9177690a5268c26697a7f0b37470ef0058112c6 
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 
ffcb4ee4b43f5d99f419ef0e1680064f57cb1002 

Diff: https://git.reviewboard.kde.org/r/128992/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128992: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128992/#review101113
---



Ping?

- Heiko Becker


On Sept. 21, 2016, 7:36 nachm., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128992/
> ---
> 
> (Updated Sept. 21, 2016, 7:36 nachm.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp 
> 351d99fc435f9ba8d58269e0b92dab3483f77580 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.h 
> b9177690a5268c26697a7f0b37470ef0058112c6 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 
> ffcb4ee4b43f5d99f419ef0e1680064f57cb1002 
> 
> Diff: https://git.reviewboard.kde.org/r/128992/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 129559: Also search for hunspell-1.5

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129559/
---

(Updated Nov. 25, 2016, 3:18 nachm.)


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: sonnet


Description
---

Also search for hunspell-1.5


Diffs
-

  cmake/FindHUNSPELL.cmake f028abe 

Diff: https://git.reviewboard.kde.org/r/129559/diff/


Testing (updated)
---

Built against hunspell-1.5.0 and successfully ran the tests.


Thanks,

Heiko Becker

Review Request 129559: Also search for hunspell-1.5

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129559/
---

Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: sonnet


Description
---

Also search for hunspell-1.5


Diffs
-

  cmake/FindHUNSPELL.cmake f028abe 

Diff: https://git.reviewboard.kde.org/r/129559/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 129418: Adjust directory structure to Frameworks policies

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129418/
---

(Updated Nov. 16, 2016, 6:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Sune Vuorela.


Changes
---

Submitted with commit 96d2e4e7dfe3d13b85ee37df0961d33566e8659a by Heiko Becker 
to branch master.


Repository: prison


Description
---

According to the requirements listed on
https://community.kde.org/Frameworks/Policies#Framework_directory_structure


Diffs
-

  CMakeLists.txt 37fb3a0 
  lib/CMakeLists.txt  
  lib/abstractbarcode.h  
  lib/abstractbarcode.cpp  
  lib/code39barcode.h  
  lib/code39barcode.cpp  
  lib/code93barcode.h  
  lib/code93barcode.cpp  
  lib/datamatrixbarcode.h  
  lib/datamatrixbarcode.cpp  
  lib/prison.h  
  lib/prison.cpp  
  lib/qrcodebarcode.h  
  lib/qrcodebarcode.cpp  
  src/CMakeLists.txt PRE-CREATION 
  tests/barcodeexamplewidget.cpp ef385a5 
  tests/prison.cpp a722367 
  tools/CMakeLists.txt  
  tools/prison-datamatrix.cpp 6491b76 

Diff: https://git.reviewboard.kde.org/r/129418/diff/


Testing
---

cmake .. && make


Thanks,

Heiko Becker

Re: Review Request 129417: Add metainfo.yaml

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129417/
---

(Updated Nov. 16, 2016, 5:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Sune Vuorela.


Changes
---

Submitted with commit 1b72429bdd256711b1f430367408abe9ddee8186 by Heiko Becker 
to branch master.


Repository: prison


Description
---

Striking one requirement for becoming a framework from the list.


Diffs
-

  metainfo.yaml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129417/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 129417: Add metainfo.yaml

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129417/
---

Review request for KDE Frameworks and Sune Vuorela.


Repository: prison


Description
---

Striking one requirement for becoming a framework from the list.


Diffs
-

  metainfo.yaml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129417/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 129418: Adjust directory structure to Frameworks policies

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129418/
---

Review request for KDE Frameworks and Sune Vuorela.


Repository: prison


Description
---

According to the requirements listed on
https://community.kde.org/Frameworks/Policies#Framework_directory_structure


Diffs
-

  CMakeLists.txt 37fb3a0 
  lib/CMakeLists.txt  
  lib/abstractbarcode.h  
  lib/abstractbarcode.cpp  
  lib/code39barcode.h  
  lib/code39barcode.cpp  
  lib/code93barcode.h  
  lib/code93barcode.cpp  
  lib/datamatrixbarcode.h  
  lib/datamatrixbarcode.cpp  
  lib/prison.h  
  lib/prison.cpp  
  lib/qrcodebarcode.h  
  lib/qrcodebarcode.cpp  
  src/CMakeLists.txt PRE-CREATION 
  tests/barcodeexamplewidget.cpp ef385a5 
  tests/prison.cpp a722367 
  tools/CMakeLists.txt  
  tools/prison-datamatrix.cpp 6491b76 

Diff: https://git.reviewboard.kde.org/r/129418/diff/


Testing
---

cmake .. && make


Thanks,

Heiko Becker

Re: Review Request 129351: Only search for a avatar if loginName isn't empty

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129351/
---

(Updated Nov. 6, 2016, 7:06 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Edmundson and Michael Pyne.


Changes
---

Submitted with commit d922477fc2ca03cc0a2e9ee2470f3cb4b37e0c2e by Heiko Becker 
to branch master.


Repository: kcoreaddons


Description
---

70c745d6147e465ce1e34b6037eb7dedb8e77f27 introduced fetching user
avatars via AccountsService. It's seems pointless to search for an
avatar with an empty user name, e.g. an invalid user, though.
Furthermore it makes kusertest fail with the following message if
ACCOUNTS_SERVICE_ICON_DIR exists:
'Actual (invalidKUser.faceIconPath()): "/var/lib/AccountsService/icons/"
Expected (QString())'


Diffs
-

  src/lib/util/kuser_unix.cpp d45d0a1ff20b0b93c720d4320b44f4f5e57045a6 

Diff: https://git.reviewboard.kde.org/r/129351/diff/


Testing
---

kusertest doesn't fail anymore.


Thanks,

Heiko Becker

Review Request 129351: Only search for a avatar if loginName isn't empty

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129351/
---

Review request for KDE Frameworks, David Edmundson and Michael Pyne.


Repository: kcoreaddons


Description
---

70c745d6147e465ce1e34b6037eb7dedb8e77f27 introduced fetching user
avatars via AccountsService. It's seems pointless to search for an
avatar with an empty user name, e.g. an invalid user, though.
Furthermore it makes kusertest fail with the following message if
ACCOUNTS_SERVICE_ICON_DIR exists:
'Actual (invalidKUser.faceIconPath()): "/var/lib/AccountsService/icons/"
Expected (QString())'


Diffs
-

  src/lib/util/kuser_unix.cpp d45d0a1ff20b0b93c720d4320b44f4f5e57045a6 

Diff: https://git.reviewboard.kde.org/r/129351/diff/


Testing
---

kusertest doesn't fail anymore.


Thanks,

Heiko Becker

Re: Review Request 128989: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128989/
---

(Updated Sept. 23, 2016, 12:52 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Changes
---

Submitted with commit 5fdcdff6e387b5f6285a6eb5ad0c7f7a99b8bd1a by Heiko Becker 
to branch master.


Repository: kimageformats


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/imageformats/eps.cpp e566cc41d70ff66e38d7915ef5c9d561a2c23349 

Diff: https://git.reviewboard.kde.org/r/128989/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128983: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128983/
---

(Updated Sept. 23, 2016, 12:51 vorm.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Michael Pyne.


Repository: kcoreaddons


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/desktoptojson/main.cpp 21a453c9b7565bf276ed6a09c60d923abb3426d3 

Diff: https://git.reviewboard.kde.org/r/128983/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128994: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128994/
---

(Updated Sept. 23, 2016, 12:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Gräßlin.


Changes
---

Submitted with commit f2f0b2722e2cf53d982c5ebb52425e84278140e1 by Heiko Becker 
to branch master.


Repository: kglobalaccel


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/runtime/logging.cpp 26ff7542a42e75334df6895527c12915c9a90f7c 

Diff: https://git.reviewboard.kde.org/r/128994/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128991: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128991/
---

(Updated Sept. 22, 2016, 11:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Ivan Čukić.


Changes
---

Submitted with commit 40077d52b554d5903aa53fffaba46912aa55918a by Heiko Becker 
to branch master.


Repository: kactivities


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/lib/debug_p.cpp 97e39566ceef51dd0035b0625f1407a8b0fb1011 

Diff: https://git.reviewboard.kde.org/r/128991/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128990: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128990/
---

(Updated Sept. 23, 2016, 12:43 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 36142ace3236517180a3ccbcb3e692beebe53498 by Heiko Becker 
to branch master.


Repository: kjobwidgets


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/debug.cpp 445b7ee4b40560577488b6a3fcd15f593693fbb3 

Diff: https://git.reviewboard.kde.org/r/128990/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128987: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128987/
---

(Updated Sept. 22, 2016, 6:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 61c63d6b8e08c60f3336604f45a647691c32cf91 by Heiko Becker 
to branch master.


Repository: kauth


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/backends/dbus/DBusHelperProxy.cpp 
decc2676a005def1cb6feea0670f3eb981c4519d 
  src/kauthdebug.cpp fb57ddcc0e21eae25f079efc76ec0c05861ad2aa 
  src/kauthhelpersupport.cpp 318d3a0892b8bd18eb9d781b1bc6908afb6c29b2 

Diff: https://git.reviewboard.kde.org/r/128987/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128986: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128986/
---

(Updated Sept. 23, 2016, 12:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
---

Submitted with commit c55f73557ca7ab09caaa593d951297cc551c6d72 by Heiko Becker 
to branch master.


Repository: sonnet


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/plugins/hunspell/hunspelldebug.cpp 
5f9aebe0821cffb44adfe2b82595bce724dc53d7 
  src/plugins/voikko/voikkodebug.cpp c950c649b48e17143f206b990b57cf0033206df3 

Diff: https://git.reviewboard.kde.org/r/128986/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128985: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128985/
---

(Updated Sept. 22, 2016, 4:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit ed9e2553a92844567f76e7ce468a5d3128e9fb51 by Heiko Becker 
to branch master.


Repository: kitemmodels


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  autotests/klinkitemselectionmodeltest.cpp 
1399700cf58dec0ca9f661b7bc2c361e0df2349e 
  autotests/kselectionproxymodeltest.cpp 
fbc26d880f27c9d14e0181cd4f8dcd2df99f9c52 
  src/klinkitemselectionmodel.cpp f6de1c1f22c723ab7556a9fb880dd70c745b3454 
  src/kselectionproxymodel.cpp 4ee510fe22899188757c9a681c0646aa9da4d843 

Diff: https://git.reviewboard.kde.org/r/128985/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128984: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128984/
---

(Updated Sept. 23, 2016, 12:36 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 8c58398b4cafe22ce1cf28fdaf9fb62948425d36 by Heiko Becker 
to branch master.


Repository: kidletime


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/logging.cpp be0cee45adaa11de610c8157e1419d915f871fc0 

Diff: https://git.reviewboard.kde.org/r/128984/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128988: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/
---

(Updated Sept. 22, 2016, 10:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker 
to branch master.


Repository: kcrash


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 

Diff: https://git.reviewboard.kde.org/r/128988/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128988: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/
---

(Updated Sept. 22, 2016, 4:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker 
to branch master.


Repository: kcrash


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 

Diff: https://git.reviewboard.kde.org/r/128988/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128988: Drop obsolete version check

[Heiko Becker]

> On Sept. 22, 2016, 9:12 nachm., David Faure wrote:
> > src/kcrash.cpp, line 62
> > <https://git.reviewboard.kde.org/r/128988/diff/1/?file=477287#file477287line62>
> >
> > While you're here, this should now be QtInfoMsg, see 413eb26 in ECM (or 
> > review 128232).

I'd rather put that in a separate commit.
Also, I've seen that in quite a number of other frameworks. Should I mail 
kde-frameworks one time instead of posting another round of review requests?


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/#review99438
---


On Sept. 21, 2016, 7:11 nachm., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128988/
> ---
> 
> (Updated Sept. 21, 2016, 7:11 nachm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 
> 
> Diff: https://git.reviewboard.kde.org/r/128988/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128993: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128993/
---

(Updated Sept. 22, 2016, 3:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Changes
---

Submitted with commit 1536ab6c8996d5f21d7a59089bf99de675faee18 by Heiko Becker 
to branch master.


Repository: kdesignerplugin


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  autotests/minimaltest.cpp c9f49311427bdc362eafd522998699c1c31233d5 
  autotests/plugintest.cpp c73d224aa151f5a7e2bbba04bb8234ea2f391e5c 

Diff: https://git.reviewboard.kde.org/r/128993/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128995: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128995/
---

Review request for KDE Frameworks and David Faure.


Repository: kinit


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/klauncher/klauncher.cpp 4d563d9d7e7cc150b692e6be78e8197de2725196 

Diff: https://git.reviewboard.kde.org/r/128995/diff/


Testing
---


Thanks,

Heiko Becker