D27660: Add Inno Setup syntax, including embedded Pascal scripting
zrax updated this revision to Diff 77133. zrax added a comment. Relicense as MIT. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27660?vs=76398=77133 BRANCH innosetup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27660 AFFECTED FILES autotests/folding/setup.iss.fold autotests/html/setup.iss.html autotests/input/setup.iss autotests/reference/setup.iss.ref data/syntax/innosetup.xml To: zrax Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D27660: Add Inno Setup syntax, including embedded Pascal scripting
zrax created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. zrax requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH innosetup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27660 AFFECTED FILES autotests/folding/setup.iss.fold autotests/html/setup.iss.html autotests/input/setup.iss autotests/reference/setup.iss.ref data/syntax/innosetup.xml To: zrax Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D25770: Several enhancements to gitolite syntax definition.
This revision was automatically updated to reflect the committed changes. Closed by commit R216:44baed407ac6: Several enhancements to gitolite syntax definition. (authored by zrax). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25770?vs=70989=71138 REVISION DETAIL https://phabricator.kde.org/D25770 AFFECTED FILES autotests/folding/gitolite.conf.fold autotests/html/gitolite.conf.html autotests/input/gitolite.conf autotests/reference/gitolite.conf.ref data/syntax/gitolite.xml To: zrax, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D25770: Several enhancements to gitolite syntax definition.
zrax updated this revision to Diff 70989. zrax added a comment. Fix "+" in keywords to not act as a word break. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25770?vs=70974=70989 BRANCH gitolite-syntax (branched from master) REVISION DETAIL https://phabricator.kde.org/D25770 AFFECTED FILES autotests/folding/gitolite.conf.fold autotests/html/gitolite.conf.html autotests/input/gitolite.conf autotests/reference/gitolite.conf.ref data/syntax/gitolite.xml To: zrax, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D25770: Several enhancements to gitolite syntax definition.
zrax created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. zrax requested review of this revision. REVISION SUMMARY - Add more keywords, including access modes - Highlight include directives properly - Fix group highlighting to not match email addresses - Minor default style tweaks - Add unit tests for gitolite syntax REPOSITORY R216 Syntax Highlighting BRANCH gitolite-syntax (branched from master) REVISION DETAIL https://phabricator.kde.org/D25770 AFFECTED FILES autotests/folding/gitolite.conf.fold autotests/html/gitolite.conf.html autotests/input/gitolite.conf autotests/reference/gitolite.conf.ref data/syntax/gitolite.xml To: zrax Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D25054: Add string escape characters to PowerShell syntax.
zrax updated this revision to Diff 69011. zrax added a comment. - Add test case for new escape sequences to powershell autotest REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25054?vs=69010=69011 BRANCH ps-escape (branched from master) REVISION DETAIL https://phabricator.kde.org/D25054 AFFECTED FILES autotests/folding/craftenv.ps1.fold autotests/html/craftenv.ps1.html autotests/input/craftenv.ps1 autotests/reference/craftenv.ps1.ref data/syntax/powershell.xml To: zrax, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
D25054: Add string escape characters to PowerShell syntax.
zrax updated this revision to Diff 69010. zrax added a comment. - Add test case for new escape sequences to powershell autotest REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25054?vs=68996=69010 BRANCH ps-escape (branched from master) REVISION DETAIL https://phabricator.kde.org/D25054 AFFECTED FILES autotests/folding/craftenv.ps1.fold autotests/html/craftenv.ps1.html autotests/input/craftenv.ps1 autotests/reference/craftenv.ps1.ref data/syntax/powershell.xml To: zrax, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
D25054: Add string escape characters to PowerShell syntax.
zrax added a comment. I do not have a KDE developer account, so I cannot land the change myself presently. REPOSITORY R216 Syntax Highlighting BRANCH ps-escape (branched from master) REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
D25054: Add string escape characters to PowerShell syntax.
zrax edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D25054: Add string escape characters to PowerShell syntax.
zrax edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D25054: Add string escape characters to PowerShell syntax.
zrax edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D25054: Add string escape characters to PowerShell syntax.
zrax created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
zrax requested review of this revision.
REVISION SUMMARY
Powershell uses the syntax ` or `u{hex} as escape sequences within
double-quoted strings. This adds highlighting support for both sequences
to the PowerShell syntax.
REPOSITORY
R216 Syntax Highlighting
BRANCH
ps-escape (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25054
AFFECTED FILES
data/syntax/powershell.xml
To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
D15927: Use specified Perl interpreter instead of relying on PATH
zrax added a comment. PERL_EXECUTABLE is set by cmake's FindPerl module (https://cmake.org/cmake/help/v3.0/module/FindPerl.html), so it should always be defined. This only fixes the case where it's overridden on the command line (or cmake-gui, etc). REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15927 To: zrax Cc: vonreth, kde-doc-english, kde-frameworks-devel, michaelh, ngraham, bruns, skadinna
D15927: Use specified Perl interpreter instead of relying on PATH
zrax created this revision. Herald added projects: Frameworks, Documentation. Herald added a subscriber: kde-doc-english. zrax requested review of this revision. REVISION SUMMARY If a PERL_EXECUTABLE is passed on the CMake command line, e.g. because the default one in PATH is insufficient, kdoctools would still use the one in PATH incorrectly. This fixes it to use the specified perl both at configure time and at build / install time. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15927 AFFECTED FILES cmake/uriencode.cmake src/CMakeLists.txt To: zrax Cc: kde-doc-english, kde-frameworks-devel, michaelh, ngraham, bruns, skadinna
D15909: Fix compile failure on Windows targets
zrax added a comment. No, I do not have push permissions. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15909 To: zrax, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D15909: Fix compile failure on Windows targets
zrax created this revision. Herald added a project: Frameworks. zrax requested review of this revision. REVISION SUMMARY Fix a compile failure on Windows due to the use of QSysInfo enums which are not fully qualified. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15909 AFFECTED FILES src/plugins/voikko/voikkodict.cpp To: zrax Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax added a comment. Is anything else needed for this? I'm assuming installing the indexer would go as a separate review and that nobody is waiting for me to add that here... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, vkrause, cullmann, #framework_syntax_highlighting, #frameworks
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax added a comment. Installing the indexer might be more useful in the custom path case, since it could be used to index bundled rules. If we just add the /syntax-extra search path and a shared library installs an index there, we'd be right back where we started with no way to bundle new rules in an application via qrc. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, vkrause, cullmann, #framework_syntax_highlighting, #frameworks
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax updated this revision to Diff 19256. zrax added a comment. Updated original patch with fixes for @dhaumann REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7699?vs=19253=19256 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7699 AFFECTED FILES autotests/input/syntax/testlang.xml autotests/input/themes/customtheme.theme autotests/syntaxrepository_test.cpp src/lib/repository.cpp src/lib/repository.h src/lib/repository_p.h To: zrax, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, vkrause, cullmann, #framework_syntax_hightlighting, #frameworks
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax added a comment. Sorry, I missed some of the later discussion when updating the patch... I'm fine with either solution, I just want to know which is preferred :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, vkrause, cullmann, #framework_syntax_hightlighting, #frameworks
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax updated this revision to Diff 19253. zrax added a comment. Rework to search :/org.kde.syntax-highlighting/syntax-extra and :<...>/themes-extra resource paths instead of introducing a new API. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7699?vs=19243=19253 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7699 AFFECTED FILES autotests/CMakeLists.txt autotests/input/custom_defs.qrc autotests/input/customtheme.theme autotests/input/testlang.xml autotests/syntaxrepository_test.cpp src/lib/repository.cpp To: zrax, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, vkrause, cullmann, #framework_syntax_hightlighting, #frameworks
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax added a comment. @cullmann, I like that suggestion better... It's closer to what I originally tried, but was unable to because of the index cache. Are the resource paths documented anywhere that I should update? INLINE COMMENTS > dhaumann wrote in syntaxrepository_test.cpp:18 > Is this include required? Yes, it was needed for `TESTSRCDIR` to be defined. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, vkrause, cullmann, #framework_syntax_hightlighting, #frameworks
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax added a comment. @dhaumann yes, your guess is correct. I was experimenting with replacing a difficult-to-maintain qscintilla fork with some custom syntax lexers with QTextEdit + KSyntaxHighlighting + easier-to-maintain custom Kate-style syntax definitions, in a non-KDE application. One of the custom syntax rules is arguably more generally useful outside of the application (although it may be misleading since it shares an extension with a more common use), but the others I feel would just pollute the global set since they're unlikely to ever be edited outside the app. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, vkrause, cullmann, #framework_syntax_hightlighting, #frameworks
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax updated this revision to Diff 19243. zrax added a comment. Add input files for new test case. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7699?vs=19242=19243 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7699 AFFECTED FILES autotests/input/syntax/testlang.xml autotests/input/themes/customtheme.theme autotests/syntaxrepository_test.cpp src/lib/repository.cpp src/lib/repository.h src/lib/repository_p.h To: zrax, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, vkrause, cullmann, #framework_syntax_hightlighting, #frameworks
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax updated this revision to Diff 19242. zrax added a comment. Adjust naming based on review comments; add test case for custom path. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7699?vs=19213=19242 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7699 AFFECTED FILES autotests/syntaxrepository_test.cpp src/lib/repository.cpp src/lib/repository.h src/lib/repository_p.h To: zrax, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, vkrause, cullmann, #framework_syntax_hightlighting, #frameworks
D7699: Add support for custom search paths for application-specific syntax and theme definitions
zrax retitled this revision from "Add support for custom search paths for application-specific syntax and themedefinitions" to "Add support for custom search paths for application-specific syntax and theme definitions". zrax edited the summary of this revision. zrax edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_hightlighting Cc: #frameworks
D7699: Add support for custom search paths for application-specific syntax and themedefinitions
zrax retitled this revision from "Add support for custom search paths for application-specific syntax and theme definitions" to "Add support for custom search paths for application-specific syntax and themedefinitions". zrax added reviewers: Kate, Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_hightlighting Cc: #frameworks
D7699: Add support for custom search paths for application-specific syntax and themedefinitions
zrax created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This allows applications to include application-specific syntax rules and themes which don't necessarily make sense to install globally to be used with syntax-highlighting. TEST PLAN Created custom syntax rule and sample application using QTextEdit; tested both standard syntax rules and the custom rule within the application, using the default theme. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7699 AFFECTED FILES src/lib/repository.cpp src/lib/repository.h src/lib/repository_p.h To: zrax Cc: #frameworks
Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ --- (Updated Nov. 18, 2014, 6:55 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Fix for incorrect soft-tabs alignment after beginning-of-line, by taking the current cursor position into account when expanding tabs to spaces. This also now uses the indentation width rather than the tab width, as I see Tab Width as being the actual width of the \t character, and Indentation width as being the next alignment position for virtual indentation. This more closely matches other editors (e.g. vim) which have similar indentation control. Diffs - src/document/katedocument.h 8e93f7a9940c98324236f1269d25ccf98d04f968 src/document/katedocument.cpp 9a809fad5fe879f11402cf9d274b3463cb267d66 Diff: https://git.reviewboard.kde.org/r/120760/diff/ Testing --- Typed the testcase in bug 340212 with various indent/tab width settings. Only Soft Tab mode is affected by this change. With Indent 4/Tab 4: int x; string y; boolz; With Indent 4/Tab 8: int x; string y; boolz; With Indent 8/Tab 8 (single [tab] on the first line): int x; string y; boolz; Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ --- (Updated Nov. 13, 2014, 9:49 a.m.) Review request for KDE Frameworks and Christoph Cullmann. Changes --- Added comments and referenced the bug # Repository: ktexteditor Description --- Fix for incorrect soft-tabs alignment after beginning-of-line, by taking the current cursor position into account when expanding tabs to spaces. This also now uses the indentation width rather than the tab width, as I see Tab Width as being the actual width of the \t character, and Indentation width as being the next alignment position for virtual indentation. This more closely matches other editors (e.g. vim) which have similar indentation control. Diffs (updated) - src/document/katedocument.h 8e93f7a9940c98324236f1269d25ccf98d04f968 src/document/katedocument.cpp 9a809fad5fe879f11402cf9d274b3463cb267d66 Diff: https://git.reviewboard.kde.org/r/120760/diff/ Testing --- Typed the testcase in bug 340212 with various indent/tab width settings. Only Soft Tab mode is affected by this change. With Indent 4/Tab 4: int x; string y; boolz; With Indent 4/Tab 8: int x; string y; boolz; With Indent 8/Tab 8 (single [tab] on the first line): int x; string y; boolz; Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line
Ping? On Thu, Oct 23, 2014 at 10:09 AM, Michael Hansen zrax0...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ Review request for KDE Frameworks and Christoph Cullmann. By Michael Hansen. *Repository: * ktexteditor Description Fix for incorrect soft-tabs alignment after beginning-of-line, by taking the current cursor position into account when expanding tabs to spaces. This also now uses the indentation width rather than the tab width, as I see Tab Width as being the actual width of the \t character, and Indentation width as being the next alignment position for virtual indentation. This more closely matches other editors (e.g. vim) which have similar indentation control. Testing Typed the testcase in bug 340212 with various indent/tab width settings. Only Soft Tab mode is affected by this change. With Indent 4/Tab 4: int x; string y; boolz; With Indent 4/Tab 8: int x; string y; boolz; With Indent 8/Tab 8 (single [tab] on the first line): int x; string y; boolz; Diffs - src/document/katedocument.h (cc43d6ab033c3d5bcf5b90a18ef9c2dc78b220cf) - src/document/katedocument.cpp (edcf7a430412d30ca2ed210465690bc8e2c42d5b) View Diff https://git.reviewboard.kde.org/r/120760/diff/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ --- (Updated nov. 12, 2014, 7:06 p.m.) Review request for Kate, KDE Frameworks and Christoph Cullmann. Changes --- aacid: Added kate group Repository: ktexteditor Description --- Fix for incorrect soft-tabs alignment after beginning-of-line, by taking the current cursor position into account when expanding tabs to spaces. This also now uses the indentation width rather than the tab width, as I see Tab Width as being the actual width of the \t character, and Indentation width as being the next alignment position for virtual indentation. This more closely matches other editors (e.g. vim) which have similar indentation control. Diffs - src/document/katedocument.h cc43d6ab033c3d5bcf5b90a18ef9c2dc78b220cf src/document/katedocument.cpp edcf7a430412d30ca2ed210465690bc8e2c42d5b Diff: https://git.reviewboard.kde.org/r/120760/diff/ Testing --- Typed the testcase in bug 340212 with various indent/tab width settings. Only Soft Tab mode is affected by this change. With Indent 4/Tab 4: int x; string y; boolz; With Indent 4/Tab 8: int x; string y; boolz; With Indent 8/Tab 8 (single [tab] on the first line): int x; string y; boolz; Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Fix for incorrect soft-tabs alignment after beginning-of-line, by taking the current cursor position into account when expanding tabs to spaces. This also now uses the indentation width rather than the tab width, as I see Tab Width as being the actual width of the \t character, and Indentation width as being the next alignment position for virtual indentation. This more closely matches other editors (e.g. vim) which have similar indentation control. Diffs - src/document/katedocument.h cc43d6ab033c3d5bcf5b90a18ef9c2dc78b220cf src/document/katedocument.cpp edcf7a430412d30ca2ed210465690bc8e2c42d5b Diff: https://git.reviewboard.kde.org/r/120760/diff/ Testing --- Typed the testcase in bug 340212 with various indent/tab width settings. Only Soft Tab mode is affected by this change. With Indent 4/Tab 4: int x; string y; boolz; With Indent 4/Tab 8: int x; string y; boolz; With Indent 8/Tab 8 (single [tab] on the first line): int x; string y; boolz; Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
On March 23, 2014, 4:39 p.m., Aleix Pol Gonzalez wrote: src/colors/kcolorutils.cpp, line 38 https://git.reviewboard.kde.org/r/116866/diff/5/?file=256190#file256190line38 Wouldn't it make more sense to use qIsNan? http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN Alex Merry wrote: Huh. Yes. Doing work on KJS had me in the wrong mindset :-) D'oh, I should have thought of that . - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53877 --- On March 22, 2014, 1:54 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 1:54 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 10:13 a.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs (updated) - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
On March 22, 2014, 6:29 a.m., Alex Merry wrote: src/kguiaddons_config.h.cmake, lines 20-21 https://git.reviewboard.kde.org/r/116866/diff/4/?file=255954#file255954line20 This was also copied out of another file, right? Nope, but it was put in before I changed my mind about the name of the file . - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53754 --- On March 22, 2014, 10:13 a.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 10:13 a.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 8:54 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 21, 2014, 9:26 a.m.) Review request for KDE Frameworks. Changes --- Updated copyright Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs (updated) - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 10:25 a.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs (updated) - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
On March 18, 2014, 10:47 a.m., Nicolás Alvarez wrote: src/kguiaddons_config.h.cmake, line 2 https://git.reviewboard.kde.org/r/116866/diff/3/?file=255187#file255187line2 Do these copyright lines really apply to this new file? I think you should include just your own name (since you created this config file). Oops, I just copied that header from another .h file... - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53348 --- On March 18, 2014, 10:25 a.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 10:25 a.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 18, 2014, 10:51 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 17, 2014, 8:18 p.m.) Review request for KDE Frameworks. Changes --- Add a configuration file, and move isnan function detection to cmake Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs (updated) - src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 src/ConfigureChecks.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/kguiaddons_config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
