D17425: Added DCB settings

[Pranav Gade]

pranavgade updated this revision to Diff 47338.
pranavgade marked 7 inline comments as done.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47282=47338

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D17474: A minor bug in ipv4 and ipv6 test

[Pranav Gade]

pranavgade added a comment.


  In D17474#374522 , @pranavgade 
wrote:
  
  > This change causes the ipv4 address test to fail due to a difference in 
size of list.
  >  [F6468448 ]
  
  
  D17497: A minor typo in ipv4 test  will 
fix this.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17474

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17497: A minor typo in ipv4 test

[Pranav Gade]

pranavgade created this revision.
pranavgade added reviewers: jgrulich, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  A minor typo in ipv4setting test was causing the test to fail after D17474: A 
minor bug in ipv4 and ipv6 test 
  Fixed that.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17497

AFFECTED FILES
  autotests/settings/ipv4settingtest.cpp

To: pranavgade, jgrulich, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: Added DCB settings

[Pranav Gade]

pranavgade retitled this revision from "dcb settings" to "Added DCB settings".
pranavgade edited the summary of this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47282.
pranavgade marked an inline comment as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47279=47282

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47279.
pranavgade marked 4 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47270=47279

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade added a comment.


  Sorry, I had forgot about that.

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47270.
pranavgade marked 6 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47267=47270

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17474: A minor bug in ipv4 and ipv6 test

[Pranav Gade]

pranavgade added a comment.


  This change causes the ipv4 address test to fail due to a difference in size 
of list.
  [F6468448 ]

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17474

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17474: A minor bug in ipv4 and ipv6 test

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Some QCOMPAREs were comparing a value in a map with itself.
  Fixed.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17474

AFFECTED FILES
  autotests/settings/ipv4settingtest.cpp
  autotests/settings/ipv6settingtest.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47267.
pranavgade marked an inline comment as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47263=47267

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47263.
pranavgade marked 4 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47261=47263

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in dcbsetting.cpp:59
> Yes please.

Okay, im on it
But on the other hand, it will add 12 functions unnecessarily

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47261.
pranavgade marked 2 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47253=47261

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade marked 12 inline comments as done.

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47253.
pranavgade marked 15 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47243=47253

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in dcbsetting.cpp:464
> Oh, right, you don't have methods for that. In that case you can again use 
> Q_D(const DcbSetting) and push there d->priorityFlowControl and others.

I can use Q_D in fromMap, but i get this error in toMap:

error: invalid conversion from ‘const NetworkManager::DcbSettingPrivate*’ to 
‘NetworkManager::DcbSettingPrivate*’ [-fpermissive] Q_D(DcbSetting);

so, changed frommap, but keeping this as is.

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade marked an inline comment as done.
pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in dcbsetting.cpp:31
> You can initialize also all the lists here, because they have default values 
> as well.

how do i do that?
i am getting this error:
error: class ‘NetworkManager::DcbSettingPrivate’ does not have any field named 
‘setPriorityFlowControl’

> jgrulich wrote in dcbsetting.cpp:197
> If you initialize the list at the beginning, you will not need to have this 
> check and also do this weird thing below. Simply have the first check and 
> otherwise you can do just d->priorityFlowControl[userPriority] = enabled.

I think it is better to have this as a safety measure, and initialising so many 
values manually wold take 8*6=48 lines in the beginning of the file

> jgrulich wrote in dcbsetting.cpp:212
> Check just if userPriority is < 8.

that may lead to a malloc assertion error sometimes, and thus a crash which is 
confusing to understand

> jgrulich wrote in dcbsetting.cpp:393
> You can directly assign whole UintList. Same for the rest of options below.

I get a type casting error

> jgrulich wrote in dcbsetting.cpp:427
> Remove comments.

oops, i was debugging it

> jgrulich wrote in dcbsetting.cpp:428
> Shouldn't it save appFcoeMode() instead?

yeah, i uploaded some unfinished code

> jgrulich wrote in dcbsetting.cpp:464
> You can directly push the list there. Same for the lists below.

How?

> jgrulich wrote in dcbsetting.h:49
> You are missing Q_DECLARE_FLAGS()

I tried to do it in the same way as in ipv6 settings, so should i add 
Q_DECLARE_FLAGS() ?

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47243.
pranavgade marked 7 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47235=47243

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade added a comment.


  Hey!
  Could you please check and let me know which of the first two commits you 
prefer?
  Thanks!

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47139.
pranavgade added a comment.


  Alternate way to do a part of the task

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47092=47139

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  added dcb settings according to :
  https://developer.gnome.org/NetworkManager/stable/settings-dcb.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade updated this revision to Diff 47027.
pranavgade marked 7 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17381?vs=47021=47027

REVISION DETAIL
  https://phabricator.kde.org/D17381

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  src/CMakeLists.txt
  src/settings/macsecsetting.cpp
  src/settings/macsecsetting.h
  src/settings/macsecsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade updated this revision to Diff 47021.
pranavgade marked 8 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17381?vs=46975=47021

REVISION DETAIL
  https://phabricator.kde.org/D17381

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  src/CMakeLists.txt
  src/settings/macsecsetting.cpp
  src/settings/macsecsetting.h
  src/settings/macsecsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade added inline comments.

INLINE COMMENTS

> pranavgade wrote in macsecsetting.h:58
> From where can I get the possible values? Because I cannot find them here: 
> https://developer.gnome.org/NetworkManager/stable/settings-macsec.html

(I mean the default values to use in the defines)

REVISION DETAIL
  https://phabricator.kde.org/D17381

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade updated this revision to Diff 46975.
pranavgade marked 3 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17381?vs=46958=46975

REVISION DETAIL
  https://phabricator.kde.org/D17381

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  src/CMakeLists.txt
  src/settings/macsecsetting.cpp
  src/settings/macsecsetting.h
  src/settings/macsecsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in macsecsettingtest.cpp:29
> This required version is not true, please verify it properly, I'm not going 
> to do it every time :).

I tried to get the version from here: 
F6459587: Screenshot from 2018-12-06 22-13-34.png 


Is that incorrect?
If so, from where do I check the version?

> jgrulich wrote in macsecsetting.h:58
> Can be turned into an enum.

From where can I get the possible values? Because I cannot find them here: 
https://developer.gnome.org/NetworkManager/stable/settings-macsec.html

REVISION DETAIL
  https://phabricator.kde.org/D17381

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade updated this revision to Diff 46958.
pranavgade added a comment.


  rebased on master

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17381?vs=46953=46958

REVISION DETAIL
  https://phabricator.kde.org/D17381

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  src/CMakeLists.txt
  src/settings/macsecsetting.cpp
  src/settings/macsecsetting.h
  src/settings/macsecsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added macsec setting according to:
  https://developer.gnome.org/NetworkManager/stable/settings-macsec.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17381

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  src/CMakeLists.txt
  src/settings/macsecsetting.cpp
  src/settings/macsecsetting.h
  src/settings/macsecsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46946.
pranavgade marked an inline comment as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17342?vs=46940=46946

REVISION DETAIL
  https://phabricator.kde.org/D17342

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  src/CMakeLists.txt
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/teamportsetting.cpp
  src/settings/teamportsetting.h
  src/settings/teamportsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46940.
pranavgade marked 2 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17342?vs=46905=46940

REVISION DETAIL
  https://phabricator.kde.org/D17342

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  src/CMakeLists.txt
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/teamportsetting.cpp
  src/settings/teamportsetting.h
  src/settings/teamportsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46905.
pranavgade marked 4 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17342?vs=46896=46905

REVISION DETAIL
  https://phabricator.kde.org/D17342

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  src/CMakeLists.txt
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/teamportsetting.cpp
  src/settings/teamportsetting.h
  src/settings/teamportsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46896.
pranavgade marked 8 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17342?vs=46830=46896

REVISION DETAIL
  https://phabricator.kde.org/D17342

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  src/CMakeLists.txt
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/teamportsetting.cpp
  src/settings/teamportsetting.h
  src/settings/teamportsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46830.
pranavgade added a comment.


  add missing indents

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17342?vs=46829=46830

REVISION DETAIL
  https://phabricator.kde.org/D17342

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  src/CMakeLists.txt
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/teamportsetting.cpp
  src/settings/teamportsetting.h
  src/settings/teamportsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added team-port setting according to:
  https://developer.gnome.org/NetworkManager/stable/settings-team-port.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17342

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  src/CMakeLists.txt
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/teamportsetting.cpp
  src/settings/teamportsetting.h
  src/settings/teamportsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46826.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46825=46826

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46825.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46824=46825

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade added a comment.


  In D17317#371009 , @jgrulich wrote:
  
  > The tcsettingtest is failing.
  
  
  Why, exactly?

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46824.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46792=46824

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46792.
pranavgade marked an inline comment as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46789=46792

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46789.
pranavgade marked 4 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46786=46789

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46786.
pranavgade marked 3 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46785=46786

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46785.
pranavgade marked 5 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46761=46785

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in tcsettingtest.cpp:69
> I think that you cannot compare NMVariantMaps this way, that's why probably 
> the test for IPv4 and IPv6 didn't fail when we swapped values for route-data 
> and address-data. You will need to compare values inside the maps separately.

So..how should I do it?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46761.
pranavgade marked 9 inline comments as done.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46724=46761

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added match and tc setting according to:
  https://developer.gnome.org/NetworkManager/stable/settings-match.html 
https://developer.gnome.org/NetworkManager/stable/settings-tc.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h
  src/settings/tunsettingtest.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17252: ovs-patch and ovs-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46708.
pranavgade marked 2 inline comments as done.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17252?vs=46674=46708

REVISION DETAIL
  https://phabricator.kde.org/D17252

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovspatchsettingtest.cpp
  autotests/settings/ovspatchsettingtest.h
  autotests/settings/ovsportsettingtest.cpp
  autotests/settings/ovsportsettingtest.h
  src/CMakeLists.txt
  src/settings/ovspatchsetting.cpp
  src/settings/ovspatchsetting.h
  src/settings/ovspatchsetting_p.h
  src/settings/ovsportsetting.cpp
  src/settings/ovsportsetting.h
  src/settings/ovsportsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17252: ovs-patch and ovs-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46674.
pranavgade marked 4 inline comments as done.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17252?vs=46543=46674

REVISION DETAIL
  https://phabricator.kde.org/D17252

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovspatchsettingtest.cpp
  autotests/settings/ovspatchsettingtest.h
  autotests/settings/ovsportsettingtest.cpp
  autotests/settings/ovsportsettingtest.h
  src/CMakeLists.txt
  src/settings/ovspatchsetting.cpp
  src/settings/ovspatchsetting.h
  src/settings/ovspatchsetting_p.h
  src/settings/ovsportsetting.cpp
  src/settings/ovsportsetting.h
  src/settings/ovsportsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Fixed a couple of misplaced lines of code

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17258

AFFECTED FILES
  src/settings/ipv4setting.cpp
  src/settings/ipv6setting.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17252: ovs-patch and ovs-port setting

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added ovs-patch and ovs-port setting according to: 
   https://developer.gnome.org/NetworkManager/stable/settings-ovs-patch.html 
https://developer.gnome.org/NetworkManager/stable/settings-ovs-port.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17252

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovspatchsettingtest.cpp
  autotests/settings/ovspatchsettingtest.h
  autotests/settings/ovsportsettingtest.cpp
  autotests/settings/ovsportsettingtest.h
  src/CMakeLists.txt
  src/settings/ovspatchsetting.cpp
  src/settings/ovspatchsetting.h
  src/settings/ovspatchsetting_p.h
  src/settings/ovsportsetting.cpp
  src/settings/ovsportsetting.h
  src/settings/ovsportsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17239: ovs-bridge and ovs-interface setting

[Pranav Gade]

pranavgade updated this revision to Diff 46542.
pranavgade marked an inline comment as done.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17239?vs=46537=46542

REVISION DETAIL
  https://phabricator.kde.org/D17239

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovsbridgesettingtest.cpp
  autotests/settings/ovsbridgesettingtest.h
  autotests/settings/ovsinterfacesettingtest.cpp
  autotests/settings/ovsinterfacesettingtest.h
  src/CMakeLists.txt
  src/settings/ovsbridgesetting.cpp
  src/settings/ovsbridgesetting.h
  src/settings/ovsbridgesetting_p.h
  src/settings/ovsinterfacesetting.cpp
  src/settings/ovsinterfacesetting.h
  src/settings/ovsinterfacesetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17239: ovs-bridge and ovs-interface setting

[Pranav Gade]

pranavgade updated this revision to Diff 46537.
pranavgade marked 8 inline comments as done.
pranavgade added a comment.


  Made the required changes

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17239?vs=46491=46537

REVISION DETAIL
  https://phabricator.kde.org/D17239

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovsbridgesettingtest.cpp
  autotests/settings/ovsbridgesettingtest.h
  autotests/settings/ovsinterfacesettingtest.cpp
  autotests/settings/ovsinterfacesettingtest.h
  src/CMakeLists.txt
  src/settings/ovsbridgesetting.cpp
  src/settings/ovsbridgesetting.h
  src/settings/ovsbridgesetting_p.h
  src/settings/ovsinterfacesetting.cpp
  src/settings/ovsinterfacesetting.h
  src/settings/ovsinterfacesetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17251: Update Ip-tunnel settings

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Fixed a few things in ip-tunnel settings

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17251

AFFECTED FILES
  src/settings/iptunnelsetting.cpp
  src/settings/iptunnelsetting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17239: ovs-bridge and ovs-interface setting

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added ovs-bridge and ovs-interface setting according to:
  https://developer.gnome.org/NetworkManager/stable/settings-ovs-bridge.html 
https://developer.gnome.org/NetworkManager/stable/settings-ovs-interface.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17239

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovsbridgesettingtest.cpp
  autotests/settings/ovsbridgesettingtest.h
  autotests/settings/ovsinterfacesettingtest.cpp
  autotests/settings/ovsinterfacesettingtest.h
  src/CMakeLists.txt
  src/settings/ovsbridgesetting.cpp
  src/settings/ovsbridgesetting.h
  src/settings/ovsbridgesetting_p.h
  src/settings/ovsinterfacesetting.cpp
  src/settings/ovsinterfacesetting.h
  src/settings/ovsinterfacesetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade updated this revision to Diff 46488.
pranavgade marked 2 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17210?vs=46469=46488

REVISION DETAIL
  https://phabricator.kde.org/D17210

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/proxysettingtest.cpp
  autotests/settings/proxysettingtest.h
  autotests/settings/usersettingtest.cpp
  autotests/settings/usersettingtest.h
  src/CMakeLists.txt
  src/settings/proxysetting.cpp
  src/settings/proxysetting.h
  src/settings/proxysetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/usersetting.cpp
  src/settings/usersetting.h
  src/settings/usersetting_p.h

To: pranavgade, jgrulich
Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade set the repository for this revision to R282 NetworkManagerQt.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17210

To: pranavgade, jgrulich
Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade marked 3 inline comments as done.

REVISION DETAIL
  https://phabricator.kde.org/D17210

To: pranavgade, jgrulich
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade marked 3 inline comments as done.
pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in proxysetting.cpp:25
> It looks that the proxy setting has been introduced in NetworkManager 1.6. 
> This means that for all property defines, you have to add ifdef the same way 
> you did for ip tunnel setting.

Fixed according to:
https://developer.gnome.org/libnm/stable/NMSettingProxy.html#NM-SETTING-PROXY-METHOD:CAPS

REVISION DETAIL
  https://phabricator.kde.org/D17210

To: pranavgade, jgrulich
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade updated this revision to Diff 46469.
pranavgade added a comment.


  made some changes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17210?vs=46467=46469

REVISION DETAIL
  https://phabricator.kde.org/D17210

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/proxysettingtest.cpp
  autotests/settings/proxysettingtest.h
  autotests/settings/usersettingtest.cpp
  autotests/settings/usersettingtest.h
  src/CMakeLists.txt
  src/settings/proxysetting.cpp
  src/settings/proxysetting.h
  src/settings/proxysetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/usersetting.cpp
  src/settings/usersetting.h
  src/settings/usersetting_p.h

To: pranavgade, jgrulich
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade updated this revision to Diff 46467.
pranavgade marked 6 inline comments as done.
pranavgade added a comment.


  Updated code as required, 
  fixed a minor error in iptunnelsettings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17210?vs=46444=46467

REVISION DETAIL
  https://phabricator.kde.org/D17210

AFFECTED FILES
  src/settings/iptunnelsetting.cpp
  src/settings/proxysetting.cpp
  src/settings/proxysetting.h
  src/settings/proxysetting_p.h
  src/settings/usersetting.cpp
  src/settings/usersetting.h

To: pranavgade, jgrulich
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade updated this revision to Diff 46444.
pranavgade added a comment.


  Updated diff from prev commit->changes to latest commit->changes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17210?vs=46392=46444

REVISION DETAIL
  https://phabricator.kde.org/D17210

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/proxysettingtest.cpp
  autotests/settings/proxysettingtest.h
  autotests/settings/usersettingtest.cpp
  autotests/settings/usersettingtest.h
  src/CMakeLists.txt
  src/settings/proxysetting.cpp
  src/settings/proxysetting.h
  src/settings/proxysetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/usersetting.cpp
  src/settings/usersetting.h
  src/settings/usersetting_p.h

To: pranavgade, jgrulich
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added proxy and user settings according to:
  https://developer.gnome.org/NetworkManager/stable/settings-proxy.html 
https://developer.gnome.org/NetworkManager/stable/settings-user.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17210

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/proxysettingtest.cpp
  autotests/settings/proxysettingtest.h
  autotests/settings/usersettingtest.cpp
  autotests/settings/usersettingtest.h
  src/CMakeLists.txt
  src/settings/proxysetting.cpp
  src/settings/proxysetting.h
  src/settings/proxysetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/usersetting.cpp
  src/settings/usersetting.h
  src/settings/usersetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17185: Added ip-tunnel settings

[Pranav Gade]

pranavgade updated this revision to Diff 46376.
pranavgade removed a subscriber: kde-frameworks-devel.
pranavgade added a comment.


  Made a few minor changes

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17185?vs=46310=46376

REVISION DETAIL
  https://phabricator.kde.org/D17185

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  src/CMakeLists.txt
  src/settings/iptunnelsetting.h

To: pranavgade, jgrulich
Cc: michaelh, ngraham, bruns, kde-frameworks-devel

D17185: Added ip-tunnel settings

[Pranav Gade]

pranavgade marked 5 inline comments as done.
pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in iptunnelsettingtest.cpp:79
> Use NetworkManager defines, do not define your own new defines, there is no 
> reason for that.

I tried to follow the way it is done in ipv6settings.

> jgrulich wrote in connectionsettings.cpp:195
> IpTunnel setting is not part of Tun connection, it should be completely 
> separated connection type.

What should the new connection type be called?

> jgrulich wrote in iptunnelsetting.h:74
> Maybe turn this into QFlags?
> 
> See:
> typedef enum { /*< flags, prefix=NM_IP_TUNNEL_FLAG >*/
>   NM_IP_TUNNEL_FLAG_NONE   = 0x0,
>   NM_IP_TUNNEL_FLAG_IP6_IGN_ENCAP_LIMIT= 0x1,
>   NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_TCLASS= 0x2,
>   NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FLOWLABEL = 0x4,
>   NM_IP_TUNNEL_FLAG_IP6_MIP6_DEV   = 0x8,
>   NM_IP_TUNNEL_FLAG_IP6_RCV_DSCP_COPY  = 0x10,
>   NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FWMARK= 0x20,
> } NMIPTunnelFlags;

What do you mean? Should I create a new Enum?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17185

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17185: Added ip-tunnel settings

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added ip-tunnel settings according to 
https://developer.gnome.org/NetworkManager/stable/settings-ip-tunnel.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17185

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/iptunnelsettingtest.cpp
  autotests/settings/iptunnelsettingtest.h
  src/CMakeLists.txt
  src/settings/connectionsettings.cpp
  src/settings/iptunnelsetting.cpp
  src/settings/iptunnelsetting.h
  src/settings/iptunnelsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns