D26342: Allow overriding to disable auto language detection

2020-06-13 Thread Simon Depiets 
sdepiets added a comment.


  Please see below proposal to restore the previous default behavior
  
  https://invent.kde.org/frameworks/sonnet/-/merge_requests/1

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig, aacid
Cc: dfaure, aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-06-13 Thread Simon Depiets 
sdepiets added a comment.


  In D26342#675142 , @dfaure wrote:
  
  > This actually breaks language auto-detection for me in the KMail composer.
  >
  > Testcase:
  >
  > - New Mail
  > - I type "Bonjour," in the body
  >
  >   Before: It's detected as French and not underlined as a typo
  >
  >   After: The language remains English, and the word is underlined as a typo
  >
  >   Workaround: Tools / Spelling / change language from English to French
  >
  >   Too bad I'm realizing this is the reason for the regression only today 
(day of 5.71 release) by looking at the KF-5.71 changelog :(
  
  
  I don't think that's a regression, in the previous behavior you could try to 
set any language to proofread, it would always auto-detect "Bonjour" as French, 
thus the "Tools / Spelling / change language" had not effect if autodetect was 
enabled at system level (while autodetection should be an application or even 
case by case decision).
  
  It may not seem like an issue for simple cases, but actually for mixed 
contents (i.e. an email that is 50% French, 50% English) that would be detected 
as English, you would have no way at all to check the French text without 
disabling system-wide autodectection.
  
  Calling setAutoDetectLanguageDisabled(false) restores the previous behavior

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig, aacid
Cc: dfaure, aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-04-25 Thread Simon Depiets 
sdepiets updated this revision to Diff 81177.
sdepiets added a comment.


  Bump since + autotest checks the language as well

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26342?vs=81176=81177

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26342

AFFECTED FILES
  autotests/test_highlighter.cpp
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h
  src/core/backgroundchecker_p.h
  src/ui/highlighter.cpp
  src/ui/highlighter.h

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D26342: Allow overriding to disable auto language detection

2020-04-25 Thread Simon Depiets 
sdepiets updated this revision to Diff 81176.
sdepiets added a comment.


  - Merge branch 'master' of git.kde.org:sonnet

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26342?vs=76992=81176

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26342

AFFECTED FILES
  autotests/test_highlighter.cpp
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h
  src/core/backgroundchecker_p.h
  src/ui/highlighter.cpp
  src/ui/highlighter.h

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D26342: Allow overriding to disable auto language detection

2020-03-23 Thread Simon Depiets 
sdepiets added a comment.


  In D26342#623729 , @aacid wrote:
  
  > Would it make sense to enshrine this behaviour with an autotest?
  
  
  Sorry what do you mean by that? Similar to tests/BackgroundTest.cpp ?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-03-07 Thread Simon Depiets 
sdepiets added a comment.


  I don't see a use case where you would want to set the Language, but then let 
the system override it (and only if the user has auto-detection).
  I left the option in the API to "setAutoDetectLanguageDisabled" to false, for 
instance if you are not sure which language is being used anymore and want to 
let the system re-decide by itself.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-03-05 Thread Simon Depiets 
sdepiets updated this revision to Diff 76992.
sdepiets added a comment.


  Disable autodetect on language change

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26342?vs=74851=76992

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26342

AFFECTED FILES
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h
  src/core/backgroundchecker_p.h
  src/ui/highlighter.cpp
  src/ui/highlighter.h

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-02-28 Thread Simon Depiets 
sdepiets added a reviewer: mludwig.
sdepiets added a comment.


  Can we get some traction on this?
  It's a relatively light change that doesn't affect the default Sonnet 
behavior.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D26342: Allow overriding to disable auto language detection

2020-02-04 Thread Simon Depiets 
sdepiets added reviewers: cullmann, mlaurent.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-02-02 Thread Simon Depiets 
sdepiets added a comment.


  In D26342#585867 , @mludwig wrote:
  
  > I'd support such a change for the BackgroundChecker as well. KTextEditor 
needs a way to do its own language detection or override the detected language.
  
  
  I've updated the diff

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-02-02 Thread Simon Depiets 
sdepiets updated this revision to Diff 74851.
sdepiets added a comment.


  Allow overriding to disable auto language detection in BackGround Checker

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26342?vs=72540=74851

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26342

AFFECTED FILES
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h
  src/core/backgroundchecker_p.h
  src/ui/highlighter.cpp
  src/ui/highlighter.h

To: sdepiets, #frameworks
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-01-01 Thread Simon Depiets 
sdepiets edited the summary of this revision.
sdepiets added a reviewer: Frameworks.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-01-01 Thread Simon Depiets 
sdepiets created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sdepiets requested review of this revision.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26342

AFFECTED FILES
  src/ui/highlighter.cpp
  src/ui/highlighter.h

To: sdepiets
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18424: Instantiate QApplication before KCrash/KCatalog

2019-01-21 Thread Simon Depiets 
sdepiets closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18424

To: sdepiets, #baloo, bruns, poboiko, mlaurent
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18424: Instantiate QApplication before KCrash/KCatalog

2019-01-20 Thread Simon Depiets 
sdepiets edited the summary of this revision.
sdepiets added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18424

To: sdepiets, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18424: Instantiate QApplication before KCrash/KCatalog

2019-01-20 Thread Simon Depiets 
sdepiets created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
sdepiets requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18424

AFFECTED FILES
  src/file/extractor/main.cpp

To: sdepiets
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread Simon Depiets 
sdepiets closed this revision.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D15686

To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread Simon Depiets 
sdepiets updated this revision to Diff 42121.
sdepiets added a comment.


  Coding style

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15686?vs=42120=42121

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15686

AFFECTED FILES
  src/ui/highlighter.cpp

To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread Simon Depiets 
sdepiets edited the summary of this revision.
sdepiets added reviewers: Framework: Syntax Highlighting, mlaurent, dfaure.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D15686

To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread Simon Depiets 
sdepiets created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sdepiets requested review of this revision.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15686

AFFECTED FILES
  src/ui/highlighter.cpp

To: sdepiets
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14938: Force ki18n to build with the libintl.so path

2018-09-14 Thread Simon Depiets 
sdepiets added a comment.


  In D14938#325850 , @sars wrote:
  
  > If I understand the comments correct it assumes that if we use a libc that 
already has what we need, we don't need to use a separate library for it.
  
  
  Correct me if I'm wrong, but I don't think "if(LibIntl_SYMBOL_FOUND)" 
discriminates between whether that symbol came from libc or not.

REPOSITORY
  R877 Craft Blueprints for KDE

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: sars, vonreth

D14938: Force ki18n to build with the libintl.so path

2018-09-14 Thread Simon Depiets 
sdepiets added a comment.


  In D14938#325850 , @sars wrote:
  
  > If I understand the comments correct it assumes that if we use a libc that 
already has what we need, we don't need to use a separate library for it.
  
  
  Correct me if I'm wrong, but I don't think "if(LibIntl_SYMBOL_FOUND)" 
discriminates between whether that symbol came from libc or not.

REPOSITORY
  R877 Craft Blueprints for KDE

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: sars, vonreth