D18664: Baloo engine: treat every non-success code as a failure

2019-03-13 Thread Valeriy Malov 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:eb68430ae5f4: Baloo engine: treat every non-success code 
as a failure (authored by valeriymalov).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18664?vs=53608=53838#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=53608=53838

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-03-10 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 53608.
valeriymalov marked 3 inline comments as done.
valeriymalov added a comment.


  - do not ignore results of PostingDB::iter in case of an error/end of db

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=52229=53608

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-21 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 52229.
valeriymalov added a comment.


  - fix MTimeDB::get loop

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=52216=52229

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18873: add baloo engine debugging category

2019-02-21 Thread Valeriy Malov 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f5f1ae889fe9: add baloo engine debugging category 
(authored by valeriymalov).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18873?vs=51279=52220

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-21 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 52216.
valeriymalov marked 4 inline comments as done.
valeriymalov added a comment.


  - review warning fixes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=51284=52216

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-21 Thread Valeriy Malov 
valeriymalov edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-09 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 51284.
valeriymalov marked 4 inline comments as done.
valeriymalov added a comment.


  - fix ::del error logging criteria, don't return without closing cursor in

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=51282=51284

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-09 Thread Valeriy Malov 
valeriymalov added inline comments.

INLINE COMMENTS

> bruns wrote in documentdatadb.cpp:107
> see get

Trying to delete a non-existent entry seems like an error to me

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-09 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 51282.
valeriymalov marked 10 inline comments as done.
valeriymalov added a comment.


  - update logging per review

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=51252=51282

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18873: add baloo engine debugging category

2019-02-09 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 51279.
valeriymalov added a comment.


  is it now how it's supposed to look in the end? not really sure where 
.category syntax is defined

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18873?vs=51261=51279

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18873: add baloo engine debugging category

2019-02-09 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 51261.
valeriymalov added a comment.


  - update categories per review

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18873?vs=51255=51261

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-09 Thread Valeriy Malov 
valeriymalov added a dependency: D18873: add baloo engine debugging category.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18873: add baloo engine debugging category

2019-02-09 Thread Valeriy Malov 
valeriymalov added a dependent revision: D18664: Baloo engine: treat every 
non-success code as a failure.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent
Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18873: add baloo engine debugging category

2019-02-09 Thread Valeriy Malov 
valeriymalov marked an inline comment as done.
valeriymalov added inline comments.

INLINE COMMENTS

> mlaurent wrote in CMakeLists.txt:31
> which files uses it ?
> you generate it but it seems that you don't use it in file no ?

I've been asked to split this from D18664: Baloo engine: treat every 
non-success code as a failure 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent
Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18873: add baloo engine debugging category

2019-02-09 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 51255.
valeriymalov added a comment.


  - use new syntax for baloo.categories

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18873?vs=51248=51255

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo, mlaurent
Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-09 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 51252.
valeriymalov added a comment.


  - move new logging category to D18873: add baloo engine debugging category 


REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=51251=51252

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-09 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 51251.
valeriymalov marked 3 inline comments as done.
valeriymalov added a comment.


  - clean up rest of the asserts

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=50708=51251

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18873: add baloo engine debugging category

2019-02-09 Thread Valeriy Malov 
valeriymalov created this revision.
valeriymalov added a reviewer: Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
valeriymalov requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

AFFECTED FILES
  baloo.categories
  src/engine/CMakeLists.txt

To: valeriymalov, #baloo
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-03 Thread Valeriy Malov 
valeriymalov planned changes to this revision.
valeriymalov added a comment.


  In D18664#404173 , @poboiko wrote:
  
  > 1. Are we actually sure this is gonna fix all those crashes? Otherwise I 
would suggest using CCBUG instead of BUG inside the commit message.
  
  
  I've chosen those bugs based on backtraces I could get myself but without 
core dumps I can't vouch for that, even with core dumps it'd be hard to tell. 
Alternatively I can CCBUG and after this gets into a release, ask in those bugs 
people if they still experience the crash and close them if they won't get back 
in a month or so.
  
  > 1. For now, logging is the only way to know if there's something bad going 
on. In that case I would suggest to at least increase severity of those 
messages - it would increase chances users will notice it. For example, use 
`qCCritical` (but this would also require additional check for 
okayish/non-critical return codes, such as `MDB_NOTFOUND`)
  
  These errors have good potential to flood users log files. I get around 30 
megabytes of those on each boot. I'd rather see them disabled by default.
  It might make sense to add a catch-all error message somewhere on higher 
level, that would get printed out once, but I haven't looked yet where such 
message could be placed.
  
  > 1. Looks like this patch is composed of two parts - introducing new logging 
category and and improving error handling. It would be also nice to split those 
into two separate patches.
  > 2. There are a lot of redundant `Q_ASSERT_X` left, which could be removed. 
I suggest just `grep`'ing over the code to catch'em all. I've started marking 
them here, but then I gave up - too many of them.
  > 3. There are also several unchecked return codes as well, such as inside 
`*DB::size()` calls. Those can also be found by `grep`'ing over `Q_ASSERT_X`.
  
  I'll look into these this week.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-02 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 50708.
valeriymalov added a comment.


  - unbreak documentdatadb::contains, oops :(

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=50706=50708

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-02 Thread Valeriy Malov 
valeriymalov added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18664: Baloo engine: treat every non-success code as a failure

2019-02-02 Thread Valeriy Malov 
valeriymalov created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
valeriymalov requested review of this revision.

REVISION SUMMARY
  Treating only MDB_NOTFOUND as an error leads to use of uninitliazed
  pointers and handle IDs in other cases (e.g. when get fails with
  MDB_BAD_TXN) and wreaks havoc in the application.
  
  This is a bit of a hacky fix since long-term solution probably requires
  more rigorous refactoring of the Baloo Engine. There's a lot of
  duplicate code and uninitialized values, which makes it hard to track
  the misuse of LMDB API.
  
  However this should fix a good deal of crashes, probably more.
  
  BUG: 361186
  BUG: 390823
  BUG: 372880
  BUG: 395888
  BUG: 367480
  BUG: 403720

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread Valeriy Malov 
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:cc4ecfdcd48a: Manually resize KCMUtilDialog to sizeHint() 
(authored by valeriymalov).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15406?vs=41344=41446

REVISION DETAIL
  https://phabricator.kde.org/D15406

AFFECTED FILES
  src/kcmultidialog.cpp

To: valeriymalov, #frameworks, ngraham
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread Valeriy Malov 
valeriymalov added a comment.


  neither `QWidget::adjustSize()` nor `QWidget::adjustedSize()` seem to use 
`devicePixelRatio` 
(https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/kernel/qwidget.cpp#n8665),
 but I can't test that to vouch that it works on HiDPI as intended
  I can land it as is but I don't really want to break kcmshell further for 
HiDPI users

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

To: valeriymalov, #frameworks, ngraham
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-10 Thread Valeriy Malov 
valeriymalov created this revision.
valeriymalov added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
valeriymalov requested review of this revision.

REVISION SUMMARY
  Workaround for https://bugreports.qt.io/browse/QTBUG-3459
  
  Currently adjustSize() is limited to 2/3 of the screen size for windows
  This adds unnecessary scrollbars on dialogs that would otherwise fit the
  screen
  Manually resize the window after adjustSize() happens to avoid this
  limitation
  
  CCBUG: 389585

TEST PLAN
  Tested on a 1366x768 laptop, with this patch networkmanagement window opens
  in full screen height (respecting the panel)

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

AFFECTED FILES
  src/kcmultidialog.cpp

To: valeriymalov, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14692: Use custom QScrollArea with size hint not limited by font size

2018-08-13 Thread Valeriy Malov 
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:23ba2b37ef82: Use custom QScrollArea with size hint not 
limited by font size (authored by valeriymalov).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14692?vs=39313=39564

REVISION DETAIL
  https://phabricator.kde.org/D14692

AFFECTED FILES
  src/kcmultidialog.cpp
  src/kcmultidialog.h

To: valeriymalov, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14692: Use custom QScrollArea with size hint not limited by font size

2018-08-12 Thread Valeriy Malov 
valeriymalov added a comment.


  I don't know, it's frameworks after all but I guess I can land it today since 
it's a popular bug. Should I just land it on master since there seem to be no 
other branches?

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14692

To: valeriymalov, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14692: Use custom QScrollArea with size hint not limited by font size

2018-08-08 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 39313.
valeriymalov added a comment.


  - add link to qt bug

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14692?vs=39308=39313

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14692

AFFECTED FILES
  src/kcmultidialog.cpp
  src/kcmultidialog.h

To: valeriymalov, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14692: Use custom QScrollArea with size hint not limited by font size

2018-08-08 Thread Valeriy Malov 
valeriymalov added a comment.


  I think it's this bug/suggestion: https://bugreports.qt.io/browse/QTBUG-10459

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14692

To: valeriymalov, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14692: Use custom QScrollArea with size hint not limited by font size

2018-08-08 Thread Valeriy Malov 
valeriymalov added a reviewer: Frameworks.
valeriymalov added a comment.


  Context for the size hint limitation this patch is supposed to circumvent: 
https://code.woboq.org/qt5/qtbase/src/widgets/widgets/qscrollarea.cpp.html#403

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D14692

To: valeriymalov, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14692: Use custom QScrollArea with size hint not limited by font size

2018-08-08 Thread Valeriy Malov 
valeriymalov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
valeriymalov requested review of this revision.

REVISION SUMMARY
  For some reason original QScrollArea has constraint on a size hint
  This causes large KCMShell pages open in relatively small windows,
  because QScrollArea inside reports small size hint
  
  BUG: 389585

TEST PLAN
  patched 5.48.0 with this, tested networkmanager and few other kcms,
  they now seem to open in full size (except for kscreen which has custom 
sizehint,
  it probably needs size hint for the QML area specifically, not the whole 
window;
  and except for opengl that has it's own scrollable area which needs a size 
hint too)

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14692

AFFECTED FILES
  src/kcmultidialog.cpp
  src/kcmultidialog.h

To: valeriymalov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11628: Fix remotedirnotify service file

2018-03-24 Thread Valeriy Malov 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6338394f3424: Fix remotedirnotify service file (authored 
by valeriymalov).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11628?vs=30358=30443

REVISION DETAIL
  https://phabricator.kde.org/D11628

AFFECTED FILES
  src/ioslaves/remote/kdedmodule/remotedirnotify.desktop

To: valeriymalov, #frameworks, elvisangelaccio
Cc: elvisangelaccio, michaelh, ngraham

D11628: Fix remotedirnotify service file

2018-03-23 Thread Valeriy Malov 
valeriymalov created this revision.
valeriymalov added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
valeriymalov requested review of this revision.

REVISION SUMMARY
  kded plugin is actually named "remotenotifier", update .desktop file 
accordingly
  This should fix kded kcm not picking up the service status

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11628

AFFECTED FILES
  src/ioslaves/remote/kdedmodule/remotedirnotify.desktop

To: valeriymalov, #frameworks
Cc: michaelh, ngraham

D7487: Make KCMultiDialog scrollable

2017-09-01 Thread Valeriy Malov 
valeriymalov added a comment.


  In https://phabricator.kde.org/D7487#141996, @davidedmundson wrote:
  
  > For some reason "kcmshell5 kscreen" looks awful. It comes up tiny.
  
  
  This seems to be caused by the way KScreen's KCM is initialized, probably 
because of QML? Window content seems to load a split second after the window 
actually comes up.
  
  Setting sizeHint for KCMKScreen circumvents this, although I'm not sure if 
that's the correct way to fix this.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7487

To: valeriymalov, #frameworks, davidedmundson
Cc: davidedmundson, wbauer, broulik

D7487: Make KCMultiDialog scrollable

2017-08-25 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 18774.
valeriymalov edited the summary of this revision.
valeriymalov added a comment.


  Oops, should be fixed now

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7487?vs=18616=18774

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7487

AFFECTED FILES
  src/kcmultidialog.cpp

To: valeriymalov, #frameworks
Cc: wbauer, broulik

D7487: Make KCMultiDialog scrollable

2017-08-23 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 18616.
valeriymalov added a comment.


  Split commit in two (hopefully)

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7487?vs=18604=18616

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7487

AFFECTED FILES
  src/kcmultidialog.cpp

To: valeriymalov, #frameworks
Cc: broulik

D7487: Make KCMultiDialog scrollable

2017-08-23 Thread Valeriy Malov 
valeriymalov created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Put KCModuleProxy into a QScrollArea the same way SystemSettings does
  This should make kcmshell and other users of KCMultiDialog
  a bit more friendly to small screens
  
  However, this assumes that KCMs don't have their own scrollbars
  (at least sytsemsettings ones don't) and preferably have a size hint
  (only a few or none actually have; at least kscreen needs patching)
  
  BUG: 303830
  
  Also, reorder headers of the unit

TEST PLAN
  doesn't break systemsettings/kcmshell/kmail settings
  kcmshell kscreen takes some time initializing
  so it starts very small (patch ready)

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7487

AFFECTED FILES
  src/kcmultidialog.cpp

To: valeriymalov, #frameworks

D6277: Emit errors when keditbookmarks is missing

2017-06-21 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 15681.
valeriymalov added a comment.


  Toned down error from critical to warning, removed const cast

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6277?vs=15608=15681

REVISION DETAIL
  https://phabricator.kde.org/D6277

AFFECTED FILES
  src/kbookmarkmanager.cpp
  src/kbookmarkmanager.h

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6277: Emit errors when keditbookmarks is missing

2017-06-21 Thread Valeriy Malov 
valeriymalov marked 2 inline comments as done.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6277: Emit errors when keditbookmarks is missing

2017-06-19 Thread Valeriy Malov 
valeriymalov marked an inline comment as done.
valeriymalov added inline comments.

INLINE COMMENTS

> aacid wrote in kbookmarkmanager.cpp:341
> Why const_cast?

Uh oh, I'd assume startKEditBookmarks should be const (which I forgot) since it 
doesn't change the object, yet we need to emit non-const singal error. So 
should it be const or not?

Also, I'm looking at slotEditBookmarks and slotEditBookmarksAtAddress, and 
don't understand why those weren't const, since they don't have side-effects 
too, although I might be missing something since I'm not too familiar with Qt.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6277: Emit errors when keditbookmarks is missing

2017-06-19 Thread Valeriy Malov 
valeriymalov marked 2 inline comments as done.
valeriymalov added inline comments.

INLINE COMMENTS

> aacid wrote in kbookmarkmanager.cpp:335
> Have you checked errorString actually returns something?
> 
> Given startDetached is static it seems kind of weird it would update the 
> "this" errorString

Yeah it returns unknown error, my mistake, I suppose I should just switch back 
to call without object since it's a static method
There don't seem to be any informative errors apart from FailedToStart (which 
is the only one we are interested in?) in QProcess anyway

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6277: Emit errors when keditbookmarks is missing

2017-06-19 Thread Valeriy Malov 
valeriymalov updated this revision to Diff 15608.
valeriymalov added a comment.


  Call startDetached without an object since it's static (my bad, QProcess 
object does return an error but it's UnknownError and I assume should be seeing 
FailedToStart; there doesn't seem to be any other interesting errors so 
probably return value from startDetached should be enough)

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6277?vs=15589=15608

REVISION DETAIL
  https://phabricator.kde.org/D6277

AFFECTED FILES
  src/kbookmarkmanager.cpp
  src/kbookmarkmanager.h

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6277: Emit errors when keditbookmarks is missing

2017-06-19 Thread Valeriy Malov 
valeriymalov edited the summary of this revision.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: ltoscano

D6277: Emit errors when keditbookmarks is missing

2017-06-19 Thread Valeriy Malov 
valeriymalov created this revision.
valeriymalov added a project: Frameworks.

REVISION SUMMARY
  KBookmarkManager::slotEditBookmarks is supposed to run keditbookmarks, but 
does not emit any errors when if it's missing
  This makes "Edit bookmarks" menu fail silently in applications that use 
KBookmarks (e.g. krdc, konsole)
  
  See https://bugs.kde.org/show_bug.cgi?id=303830

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

AFFECTED FILES
  src/kbookmarkmanager.cpp
  src/kbookmarkmanager.h

To: valeriymalov, #frameworks