D13394: C++: update for c++20 and fix some syntax errors
jpoelen added a comment. Thank you, but I already made the request and it was accepted last night. I will do the next push :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: kwrite-devel, cullmann, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
D13394: C++: update for c++20 and fix some syntax errors
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a2343cae2bb5: C++: update for c++20 and fix some syntax errors (authored by jpoelen, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13394?vs=36229=37756 REVISION DETAIL https://phabricator.kde.org/D13394 AFFECTED FILES autotests/folding/example.rmd.fold autotests/folding/folding.cpp.fold autotests/folding/highlight.cpp.fold autotests/folding/highlight.lex.fold autotests/folding/highlight.y.fold autotests/folding/preprocessor-bug363280.cpp.fold autotests/html/folding.cpp.html autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/folding.cpp.ref autotests/reference/highlight.cpp.ref data/syntax/gcc.xml data/syntax/isocpp.xml To: jpoelen, dhaumann, cullmann Cc: kwrite-devel, cullmann, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
D13394: C++: update for c++20 and fix some syntax errors
cullmann added a comment. Restricted Application added a project: Kate. Restricted Application added a subscriber: kwrite-devel. To get this in, I will push it for you. If you need some reason for a developer account, you can just link this request. REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: kwrite-devel, cullmann, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
D13394: C++: update for c++20 and fix some syntax errors
jpoelen added a comment. I do not have a developer account, but I can do it. This is not a problem because I will contribute again. REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns
D13394: C++: update for c++20 and fix some syntax errors
dhaumann added a comment. @jpoelen Can you push yourself, or do you still not have a KDE contributor account? REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns
D13394: C++: update for c++20 and fix some syntax errors
jpoelen added inline comments. INLINE COMMENTS > dhaumann wrote in gcc.xml:576-577 > These can be WordDetect as well, right? It does not work because of ':'. But Putting it in `weakDeliminator` will break things. For this to work, it would need `additionalDeliminator` and `weakDeliminator` attributes for WordDetect (and Keyword). REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns
D13394: C++: update for c++20 and fix some syntax errors
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks good for me! Thanks for the improvements. REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns
D13394: C++: update for c++20 and fix some syntax errors
cullmann added a comment. Will take a look ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns
D13394: C++: update for c++20 and fix some syntax errors
jpoelen updated this revision to Diff 36229. jpoelen added a comment. - C++: test with clang:: in an attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13394?vs=35729=36229 BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 AFFECTED FILES autotests/folding/example.rmd.fold autotests/folding/folding.cpp.fold autotests/folding/highlight.cpp.fold autotests/folding/highlight.lex.fold autotests/folding/highlight.y.fold autotests/folding/preprocessor-bug363280.cpp.fold autotests/html/folding.cpp.html autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/folding.cpp.ref autotests/reference/highlight.cpp.ref data/syntax/gcc.xml data/syntax/isocpp.xml To: jpoelen, dhaumann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns
D13394: C++: update for c++20 and fix some syntax errors
dhaumann added a subscriber: cullmann. dhaumann added a comment. To be honest, I cannot claim I can follow all changes, since this is a big update. But in general the usage of the rules look good. The autotest output (html highlighting) looks good to me, it contains nice improvements for C++14 and C++17. @cullmann Since this is a big one, can you test this as well? Would be nice to have some days of testing for this. INLINE COMMENTS > gcc.xml:576-577 > + lineEndContext="#stay"> > + String="gnu::" /> > + String="clang::" /> > + These can be WordDetect as well, right? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns
D13394: C++: update for c++20 and fix some syntax errors
jpoelen edited the summary of this revision. jpoelen added a reviewer: dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13394: C++: update for c++20 and fix some syntax errors
jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY - new keywords, attributes and standard macros - hexadecimal floatting point (c++17) - highlight UDL (standard and user) - fix some syntax error (`operator""_x`, `#elif 0`, ...) - highlight the content of #define to the color of c++ REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 AFFECTED FILES autotests/folding/example.rmd.fold autotests/folding/folding.cpp.fold autotests/folding/highlight.cpp.fold autotests/folding/highlight.lex.fold autotests/folding/highlight.y.fold autotests/folding/preprocessor-bug363280.cpp.fold autotests/html/folding.cpp.html autotests/html/highlight.cpp.html autotests/input/highlight.cpp autotests/reference/folding.cpp.ref autotests/reference/highlight.cpp.ref data/syntax/gcc.xml data/syntax/isocpp.xml To: jpoelen Cc: kde-frameworks-devel, michaelh, ngraham, bruns
