D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[loh tar]

loh.tar added a comment.


  @cullmann wrote:
  
  > Actually, if there is a astyle commandline that enforces the right style, 
could you paste it here?
  
  Um (?) I had in mind it was on the Kate HP but couln'd find it now. But it's 
there 
https://community.kde.org/Policies/Kdelibs_Coding_Style#Artistic_Style_.28astyle.29_automatic_code_formatting
  
  As said I add "--align-pointer=name" but don't like to change this wiki, as 
noob :-)
  Furthermore I noticed that it is still not full coding style conform due to 
not fixed "one line conditional statements", so "--add-braces" may an option 
but I didn't try it
  
  > I am in favor of some script that runs that over the repo and just applying 
that regularly to enforce it stays sane, that is much more useful than to 
review each ( placement in all commits ;=)
  
  In generally a good idea. But sometimes it's nice to break the coding style 
to achieve some more lovely look

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:5dde33b16bca: KateStatusBar: Reformatted by astyle command 
to follow coding style (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17729?vs=48054=48229

REVISION DETAIL
  https://phabricator.kde.org/D17729

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I am fine with that.
  Actually, if there is a astyle commandline that enforces the right style, 
could you paste it here?
  I am in favor of some script that runs that over the repo and just applying 
that regularly to enforce it stays sane, that is much more useful than to 
review each ( placement in all commits ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[Dominik Haumann]

dhaumann added a subscriber: cullmann.
dhaumann added a comment.


  I am fine with this change. @cullmann?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[loh tar]

loh.tar updated this revision to Diff 48054.
loh.tar added a comment.


  - Run astyle again, this time with "--align-pointer=name"
  - Omit changes done in the signal/slot connect code because these need a port 
to the new style. Well, was somehow pointless because these code is changed 
anyway but I noticed that too late :-/

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17729?vs=47994=48054

REVISION DETAIL
  https://phabricator.kde.org/D17729

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor, dhaumann
Cc: sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[loh tar]

loh.tar added a comment.


  - It's a prearrangement for more changes D17730 

  - In the meantime I noticed that these astyle command did not move/fix to 
place "*&" to the right. I will update/fix this before someone like to commit

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

To: loh.tar, #ktexteditor, dhaumann
Cc: sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[Kåre Särs]

sars added a comment.


  +1
  
  I think this is fine, but let Christoph and Dominik decide if we want style 
fixing commits.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

To: loh.tar, #ktexteditor, dhaumann
Cc: sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[loh tar]

loh.tar added a comment.


  Nothing else was done

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17729

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann